RefactoringRope/Refactoring.py

branch
server_client_variant
changeset 184
4a806271f0b9
parent 183
bac69c80d5f4
child 185
3336637a673b
diff -r bac69c80d5f4 -r 4a806271f0b9 RefactoringRope/Refactoring.py
--- a/RefactoringRope/Refactoring.py	Sat Sep 23 15:20:09 2017 +0200
+++ b/RefactoringRope/Refactoring.py	Sat Sep 23 16:52:29 2017 +0200
@@ -1336,7 +1336,6 @@
             lambda: self.__refactoringDialogClosed(changeGroup))
         dlg.show()
     
-    # TODO: continue from here
     def __changeSignature(self):
         """
         Private slot to change the signature of a method or function.
@@ -1362,21 +1361,16 @@
         line, index, line1, index1 = aw.getSelection()
         offset = self.__getOffset(aw, line, index)
         
-        import rope.refactor.change_signature
-        resource = rope.base.libutils.path_to_resource(
-            self.__project, filename)
-        try:
-            changer = rope.refactor.change_signature.ChangeSignature(
-                self.__project, resource, offset)
-        except Exception as err:
-            self.handleRopeError(err, title)
-            return
-        
         from ChangeSignatureDialog import ChangeSignatureDialog
-        self.dlg = ChangeSignatureDialog(self, title, changer,
-                                         parent=self.__ui)
-        self.dlg.show()
+        dlg = ChangeSignatureDialog(self, title, filename, offset,
+                                    parent=self.__ui)
+        changeGroup = dlg.getChangeGroupName()
+        self.__refactoringDialogs[changeGroup] = dlg
+        dlg.finished.connect(
+            lambda: self.__refactoringDialogClosed(changeGroup))
+        dlg.show()
     
+    # TODO: continue from here
     def __inlineArgumentDefault(self):
         """
         Private slot to inline the default value of a parameter of a

eric ide

mercurial