Changed code to use the 'open()' context manager. release-3.1.0

Wed, 14 Oct 2020 19:32:42 +0200

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Wed, 14 Oct 2020 19:32:42 +0200
changeset 47
aee34fc5bccc
parent 46
d5f22a5b7643
child 48
840f06568486

Changed code to use the 'open()' context manager.

ChangeLog file | annotate | diff | comparison | revisions
PluginToolGenerateHash.py file | annotate | diff | comparison | revisions
PluginToolGenerateHash.zip file | annotate | diff | comparison | revisions
--- a/ChangeLog	Wed Jun 24 17:39:57 2020 +0200
+++ b/ChangeLog	Wed Oct 14 19:32:42 2020 +0200
@@ -1,5 +1,8 @@
 ChangeLog
 ---------
+Version 3.1.0:
+- changed code to use the 'open()' context manager
+
 Version 3.0.0:
 - removed support for Python2
 
--- a/PluginToolGenerateHash.py	Wed Jun 24 17:39:57 2020 +0200
+++ b/PluginToolGenerateHash.py	Wed Oct 14 19:32:42 2020 +0200
@@ -21,7 +21,7 @@
 author = "Detlev Offenbach <detlev@die-offenbachs.de>"
 autoactivate = True
 deactivateable = True
-version = "3.0.0"
+version = "3.1.0"
 className = "ToolGenerateHashPlugin"
 packageName = "ToolGenerateHash"
 shortDescription = "Generate a hash for a selectable file or directory"
@@ -281,9 +281,8 @@
             self.tr("Generate File Hash"))
         if name:
             try:
-                f = open(name, "rb")
-                hashStr = self.Hashes[act.data()](f.read()).hexdigest()
-                f.close()
+                with open(name, "rb") as f:
+                    hashStr = self.Hashes[act.data()](f.read()).hexdigest()
             except (IOError, OSError) as err:
                 E5MessageBox.critical(
                     self.__ui,
@@ -318,9 +317,9 @@
                     os.path.isfile(os.path.join(folder, name))
                 ):
                     try:
-                        f = open(os.path.join(folder, name), "rb")
-                        hashStr = self.Hashes[act.data()](f.read()).hexdigest()
-                        f.close()
+                        with open(os.path.join(folder, name), "rb") as f:
+                            hashStr = self.Hashes[act.data()](
+                                f.read()).hexdigest()
                         hashes.append((name, hashStr))
                     except (IOError, OSError):
                         fails += 1
Binary file PluginToolGenerateHash.zip has changed

eric ide

mercurial