Wed, 03 Jan 2024 18:09:15 +0100
Added a bunch of TODO markers to convert some definitions to an enum.
--- a/src/eric7/EricWidgets/EricAnimatedWidget.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/EricWidgets/EricAnimatedWidget.py Wed Jan 03 18:09:15 2024 +0100 @@ -20,6 +20,7 @@ Class implementing an animated widget. """ + # TODO: change this to an enum DirectionDown = 0 DirectionUp = 1
--- a/src/eric7/Network/IRC/IrcWidget.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Network/IRC/IrcWidget.py Wed Jan 03 18:09:15 2024 +0100 @@ -45,6 +45,7 @@ autoConnected = pyqtSignal() + # TODO: change this to an enum ServerDisconnected = 1 ServerConnected = 2 ServerConnecting = 3
--- a/src/eric7/PipInterface/PipPackagesWidget.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/PipInterface/PipPackagesWidget.py Wed Jan 03 18:09:15 2024 +0100 @@ -154,6 +154,7 @@ Class implementing the pip packages management widget. """ + # TODO: change this to an enum ShowProcessGeneralMode = 0 ShowProcessClassifiersMode = 1 ShowProcessEntryPointsMode = 2
--- a/src/eric7/Plugins/VcsPlugins/vcsGit/GitStashDataDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsGit/GitStashDataDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -17,6 +17,7 @@ Class implementing a dialog to enter the data for a stash operation. """ + # TODO: change this to an enum NoUntracked = 0 UntrackedOnly = 1 UntrackedAndIgnored = 2
--- a/src/eric7/Plugins/VcsPlugins/vcsGit/GitTagDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsGit/GitTagDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -18,10 +18,12 @@ Class implementing a dialog to enter the data for a tagging operation. """ + # TODO: change this to an enum CreateTag = 1 DeleteTag = 2 VerifyTag = 3 + # TODO: change this to an enum AnnotatedTag = 1 SignedTag = 2 LocalTag = 3
--- a/src/eric7/Plugins/VcsPlugins/vcsMercurial/HgBookmarkDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsMercurial/HgBookmarkDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -18,6 +18,7 @@ Class mplementing the bookmark dialog. """ + # TODO: change this to an enum DEFINE_MODE = 0 MOVE_MODE = 1
--- a/src/eric7/Plugins/VcsPlugins/vcsMercurial/HgBookmarksInOutDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsMercurial/HgBookmarksInOutDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -19,6 +19,7 @@ bookmarks. """ + # TODO: change this to an enum INCOMING = 0 OUTGOING = 1
--- a/src/eric7/Plugins/VcsPlugins/vcsMercurial/HgTagDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsMercurial/HgTagDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -20,6 +20,7 @@ Class implementing a dialog to enter the data for a tagging operation. """ + # TODO: change this to an enum CreateGlobalTag = 1 CreateLocalTag = 2 DeleteGlobalTag = 3
--- a/src/eric7/Plugins/VcsPlugins/vcsMercurial/QueuesExtension/HgQueuesNewPatchDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsMercurial/QueuesExtension/HgQueuesNewPatchDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -20,6 +20,7 @@ Class implementing a dialog to get the data for a new patch. """ + # TODO: change this to an enum NEW_MODE = 0 REFRESH_MODE = 1
--- a/src/eric7/Plugins/VcsPlugins/vcsMercurial/QueuesExtension/HgQueuesQueueManagementDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsMercurial/QueuesExtension/HgQueuesQueueManagementDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -24,6 +24,7 @@ Class implementing a dialog used by the queue management functions. """ + # TODO: change this to an enum NO_INPUT = 0 NAME_INPUT = 1 QUEUE_INPUT = 2
--- a/src/eric7/Plugins/VcsPlugins/vcsMercurial/QueuesExtension/queues.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Plugins/VcsPlugins/vcsMercurial/QueuesExtension/queues.py Wed Jan 03 18:09:15 2024 +0100 @@ -20,14 +20,17 @@ Class implementing the queues extension interface. """ + # TODO: change this to an enum APPLIED_LIST = 0 UNAPPLIED_LIST = 1 SERIES_LIST = 2 + # TODO: change this to an enum POP = 0 PUSH = 1 GOTO = 2 + # TODO: change this to an enum QUEUE_DELETE = 0 QUEUE_PURGE = 1 QUEUE_ACTIVATE = 2
--- a/src/eric7/Preferences/ConfigurationPages/EditorHighlightingStylesPage.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Preferences/ConfigurationPages/EditorHighlightingStylesPage.py Wed Jan 03 18:09:15 2024 +0100 @@ -38,6 +38,7 @@ Class implementing the Editor Highlighting Styles configuration page. """ + # TODO: change this to an enum FAMILYONLY = 0 SIZEONLY = 1 FAMILYANDSIZE = 2
--- a/src/eric7/QScintilla/MarkupProviders/ImageMarkupDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/QScintilla/MarkupProviders/ImageMarkupDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -23,6 +23,7 @@ Class implementing a dialog to enter data for an image markup. """ + # TODO: change this to an enum HtmlMode = 0 MarkDownMode = 1 RestMode = 2
--- a/src/eric7/UI/UserInterface.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/UI/UserInterface.py Wed Jan 03 18:09:15 2024 +0100 @@ -201,6 +201,7 @@ maxFilePathLen = 100 maxMenuFilePathLen = 75 + # TODO: change this to an enum LeftSide = 1 BottomSide = 2 RightSide = 3
--- a/src/eric7/Utilities/PasswordChecker.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/Utilities/PasswordChecker.py Wed Jan 03 18:09:15 2024 +0100 @@ -15,12 +15,14 @@ Class implementing a checker for password strength. """ + # TODO: change this to an enum Complexity_VeryWeak = 0 Complexity_Weak = 1 Complexity_Good = 2 Complexity_Strong = 3 Complexity_VeryStrong = 4 + # TODO: change this to an enum Status_Failed = 0 Status_Passed = 1 Status_Exceeded = 2
--- a/src/eric7/VCS/VersionControl.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/VCS/VersionControl.py Wed Jan 03 18:09:15 2024 +0100 @@ -56,6 +56,7 @@ vcsStatusMonitorInfo = pyqtSignal(str) vcsStatusChanged = pyqtSignal() + # TODO: change this to an enum canBeCommitted = 1 # Indicates that a file/directory is in the vcs. canBeAdded = 2 # Indicates that a file/directory is not in vcs.
--- a/src/eric7/WebBrowser/Bookmarks/BookmarkNode.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/Bookmarks/BookmarkNode.py Wed Jan 03 18:09:15 2024 +0100 @@ -15,12 +15,14 @@ Class implementing the bookmark node type. """ + # TODO: change this to an enum # possible bookmark node types Root = 0 Folder = 1 Bookmark = 2 Separator = 3 + # TODO: change this to an enum # possible timestamp types TsAdded = 0 TsModified = 1
--- a/src/eric7/WebBrowser/Bookmarks/BookmarksManager.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/Bookmarks/BookmarksManager.py Wed Jan 03 18:09:15 2024 +0100 @@ -34,6 +34,7 @@ BOOKMARKBAR = QT_TRANSLATE_NOOP("BookmarksManager", "Bookmarks Bar") BOOKMARKMENU = QT_TRANSLATE_NOOP("BookmarksManager", "Bookmarks Menu") +# TODO: change this to an enum StartRoot = 0 StartMenu = 1 StartToolBar = 2
--- a/src/eric7/WebBrowser/CookieJar/CookieJar.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/CookieJar/CookieJar.py Wed Jan 03 18:09:15 2024 +0100 @@ -27,15 +27,18 @@ cookiesChanged = pyqtSignal() + # TODO: change this to an enum AcceptAlways = 0 AcceptNever = 1 AcceptOnlyFromSitesNavigatedTo = 2 AcceptMax = 2 + # TODO: change this to an enum KeepUntilExpire = 0 KeepUntilExit = 1 KeepMax = 1 + # TODO: change this to an enum Allow = 0 Block = 1 AllowForSession = 2
--- a/src/eric7/WebBrowser/Download/DownloadManager.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/Download/DownloadManager.py Wed Jan 03 18:09:15 2024 +0100 @@ -41,6 +41,7 @@ count of download items """ + # TODO: change this to an enum RemoveNever = 0 RemoveExit = 1 RemoveSuccessFullDownload = 2
--- a/src/eric7/WebBrowser/GreaseMonkey/GreaseMonkeyDownloader.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/GreaseMonkey/GreaseMonkeyDownloader.py Wed Jan 03 18:09:15 2024 +0100 @@ -29,6 +29,7 @@ finished = pyqtSignal(str) error = pyqtSignal() + # TODO: change this to an enum DownloadMainScript = 1 DownloadRequireScript = 2
--- a/src/eric7/WebBrowser/GreaseMonkey/GreaseMonkeyScript.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/GreaseMonkey/GreaseMonkeyScript.py Wed Jan 03 18:09:15 2024 +0100 @@ -37,6 +37,7 @@ updating state """ + # TODO: change this to an enum DocumentStart = 0 DocumentEnd = 1 DocumentIdle = 2
--- a/src/eric7/WebBrowser/PersonalInformationManager/PersonalInformationManager.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/PersonalInformationManager/PersonalInformationManager.py Wed Jan 03 18:09:15 2024 +0100 @@ -25,6 +25,7 @@ fields. """ + # TODO: change this to an enum FullName = 0 LastName = 1 FirstName = 2
--- a/src/eric7/WebBrowser/TabManager/TabManagerWidget.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/TabManager/TabManagerWidget.py Wed Jan 03 18:09:15 2024 +0100 @@ -40,6 +40,7 @@ @signal groupTypeChanged(int) emitted when the 'Group By' value was changed """ + # TODO: change this to an enum GroupByWindow = 0 GroupByDomain = 1 GroupByHost = 2
--- a/src/eric7/WebBrowser/UrlBar/BookmarkActionSelectionDialog.py Wed Jan 03 17:36:30 2024 +0100 +++ b/src/eric7/WebBrowser/UrlBar/BookmarkActionSelectionDialog.py Wed Jan 03 18:09:15 2024 +0100 @@ -23,6 +23,7 @@ the bookmark. """ + # TODO: change this to an enum Undefined = -1 AddBookmark = 0 EditBookmark = 1