diff -r 157f119cd10d -r fb7b78071ee8 src/eric7/WebBrowser/UrlBar/BookmarkActionSelectionDialog.py
--- a/src/eric7/WebBrowser/UrlBar/BookmarkActionSelectionDialog.py Sun Jan 07 12:40:28 2024 +0100
+++ b/src/eric7/WebBrowser/UrlBar/BookmarkActionSelectionDialog.py Sun Jan 07 14:20:24 2024 +0100
@@ -8,6 +8,8 @@
bookmark.
"""
+import enum
+
from PyQt6.QtCore import pyqtSlot
from PyQt6.QtWidgets import QDialog
@@ -17,19 +19,24 @@
from .Ui_BookmarkActionSelectionDialog import Ui_BookmarkActionSelectionDialog
+class BookmarkAction(enum.Enum):
+ """
+ Class defining the available bookmark actions.
+ """
+
+ Undefined = -1
+ AddBookmark = 0
+ EditBookmark = 1
+ AddSpeeddial = 2
+ RemoveSpeeddial = 3
+
+
class BookmarkActionSelectionDialog(QDialog, Ui_BookmarkActionSelectionDialog):
"""
Class implementing a dialog to select the action to be performed on
the bookmark.
"""
- # TODO: change this to an enum
- Undefined = -1
- AddBookmark = 0
- EditBookmark = 1
- AddSpeeddial = 2
- RemoveSpeeddial = 3
-
def __init__(self, url, parent=None):
"""
Constructor
@@ -42,22 +49,22 @@
super().__init__(parent)
self.setupUi(self)
- self.__action = self.Undefined
+ self.__action = BookmarkAction.Undefined
self.icon.setPixmap(EricPixmapCache.getPixmap("bookmark32"))
if WebBrowserWindow.bookmarksManager().bookmarkForUrl(url) is None:
- self.__bmAction = self.AddBookmark
+ self.__bmAction = BookmarkAction.AddBookmark
self.bookmarkPushButton.setText(self.tr("Add Bookmark"))
else:
- self.__bmAction = self.EditBookmark
+ self.__bmAction = BookmarkAction.EditBookmark
self.bookmarkPushButton.setText(self.tr("Edit Bookmark"))
if WebBrowserWindow.speedDial().pageForUrl(url).url:
- self.__sdAction = self.RemoveSpeeddial
+ self.__sdAction = BookmarkAction.RemoveSpeeddial
self.speeddialPushButton.setText(self.tr("Remove from Speed Dial"))
else:
- self.__sdAction = self.AddSpeeddial
+ self.__sdAction = BookmarkAction.AddSpeeddial
self.speeddialPushButton.setText(self.tr("Add to Speed Dial"))
msh = self.minimumSizeHint()
