diff -r dbeeed55df08 -r 5fb53279f2df eric6/Plugins/VcsPlugins/vcsMercurial/HgBookmarksListDialog.py
--- a/eric6/Plugins/VcsPlugins/vcsMercurial/HgBookmarksListDialog.py Wed Jan 08 19:13:57 2020 +0100
+++ b/eric6/Plugins/VcsPlugins/vcsMercurial/HgBookmarksListDialog.py Mon Jan 13 19:23:08 2020 +0100
@@ -7,12 +7,9 @@
Module implementing a dialog to show a list of bookmarks.
"""
-
import os
-from PyQt5.QtCore import (
- pyqtSlot, QProcess, Qt, QTimer, QCoreApplication, QPoint
-)
+from PyQt5.QtCore import pyqtSlot, Qt, QCoreApplication, QPoint
from PyQt5.QtWidgets import (
QDialog, QDialogButtonBox, QHeaderView, QTreeWidgetItem, QLineEdit, QMenu,
QInputDialog
@@ -24,7 +21,6 @@
from .Ui_HgBookmarksListDialog import Ui_HgBookmarksListDialog
import UI.PixmapCache
-from Globals import strToQByteArray
class HgBookmarksListDialog(QDialog, Ui_HgBookmarksListDialog):
@@ -50,7 +46,6 @@
self.buttonBox.button(QDialogButtonBox.Close).setEnabled(False)
self.buttonBox.button(QDialogButtonBox.Cancel).setDefault(True)
- self.process = QProcess()
self.vcs = vcs
self.__bookmarksList = None
self.__repoDir = None
@@ -62,10 +57,6 @@
self.bookmarksList.columnCount(), "")
self.bookmarksList.header().setSortIndicator(3, Qt.AscendingOrder)
- self.process.finished.connect(self.__procFinished)
- self.process.readyReadStandardOutput.connect(self.__readStdout)
- self.process.readyReadStandardError.connect(self.__readStderr)
-
self.show()
QCoreApplication.processEvents()
@@ -75,17 +66,8 @@
@param e close event (QCloseEvent)
"""
- if self.__hgClient:
- if self.__hgClient.isExecuting():
- self.__hgClient.cancel()
- else:
- if (
- self.process is not None and
- self.process.state() != QProcess.NotRunning
- ):
- self.process.terminate()
- QTimer.singleShot(2000, self.process.kill)
- self.process.waitForFinished(3000)
+ if self.__hgClient.isExecuting():
+ self.__hgClient.cancel()
e.accept()
@@ -120,60 +102,23 @@
args = self.vcs.initCommand("bookmarks")
- if self.__hgClient:
- self.inputGroup.setEnabled(False)
- self.inputGroup.hide()
- self.refreshButton.setEnabled(False)
-
- out, err = self.__hgClient.runcommand(args)
- if err:
- self.__showError(err)
- if out:
- for line in out.splitlines():
- self.__processOutputLine(line)
- if self.__hgClient.wasCanceled():
- break
- self.__finish()
- else:
- self.process.kill()
- self.process.setWorkingDirectory(repodir)
-
- self.process.start('hg', args)
- procStarted = self.process.waitForStarted(5000)
- if not procStarted:
- self.inputGroup.setEnabled(False)
- self.inputGroup.hide()
- E5MessageBox.critical(
- self,
- self.tr('Process Generation Error'),
- self.tr(
- 'The process {0} could not be started. '
- 'Ensure, that it is in the search path.'
- ).format('hg'))
- else:
- self.buttonBox.button(QDialogButtonBox.Close).setEnabled(False)
- self.buttonBox.button(QDialogButtonBox.Cancel).setEnabled(True)
- self.buttonBox.button(QDialogButtonBox.Cancel).setDefault(True)
-
- self.inputGroup.setEnabled(True)
- self.inputGroup.show()
- self.refreshButton.setEnabled(False)
+ self.refreshButton.setEnabled(False)
+
+ out, err = self.__hgClient.runcommand(args)
+ if err:
+ self.__showError(err)
+ if out:
+ for line in out.splitlines():
+ self.__processOutputLine(line)
+ if self.__hgClient.wasCanceled():
+ break
+ self.__finish()
def __finish(self):
"""
Private slot called when the process finished or the user pressed
the button.
"""
- if (
- self.process is not None and
- self.process.state() != QProcess.NotRunning
- ):
- self.process.terminate()
- QTimer.singleShot(2000, self.process.kill)
- self.process.waitForFinished(3000)
-
- self.inputGroup.setEnabled(False)
- self.inputGroup.hide()
self.refreshButton.setEnabled(True)
self.buttonBox.button(QDialogButtonBox.Close).setEnabled(True)
@@ -218,15 +163,6 @@
elif button == self.refreshButton:
self.on_refreshButton_clicked()
- def __procFinished(self, exitCode, exitStatus):
- """
- Private slot connected to the finished signal.
-
- @param exitCode exit code of the process (integer)
- @param exitStatus exit status of the process (QProcess.ExitStatus)
- """
- self.__finish()
-
def __resort(self):
"""
Private method to resort the tree.
@@ -266,20 +202,6 @@
# error message
itm.setData(0, Qt.DisplayRole, revision)
- def __readStdout(self):
- """
- Private slot to handle the readyReadStdout signal.
-
- It reads the output of the process, formats it and inserts it into
- the contents pane.
- """
- self.process.setReadChannel(QProcess.StandardOutput)
-
- while self.process.canReadLine():
- s = str(self.process.readLine(), self.vcs.getEncoding(),
- 'replace').strip()
- self.__processOutputLine(s)
-
def __processOutputLine(self, line):
"""
Private method to process the lines of output.
@@ -301,18 +223,6 @@
if self.__bookmarksList is not None:
self.__bookmarksList.append(name)
- def __readStderr(self):
- """
- Private slot to handle the readyReadStderr signal.
-
- It reads the error output of the process and inserts it into the
- error pane.
- """
- if self.process is not None:
- s = str(self.process.readAllStandardError(),
- self.vcs.getEncoding(), 'replace')
- self.__showError(s)
-
def __showError(self, out):
"""
Private slot to show some error.
@@ -323,56 +233,6 @@
self.errors.insertPlainText(out)
self.errors.ensureCursorVisible()
- def on_passwordCheckBox_toggled(self, isOn):
- """
- Private slot to handle the password checkbox toggled.
-
- @param isOn flag indicating the status of the check box (boolean)
- """
- if isOn:
- self.input.setEchoMode(QLineEdit.Password)
- else:
- self.input.setEchoMode(QLineEdit.Normal)
-
- @pyqtSlot()
- def on_sendButton_clicked(self):
- """
- Private slot to send the input to the subversion process.
- """
- inputTxt = self.input.text()
- inputTxt += os.linesep
-
- if self.passwordCheckBox.isChecked():
- self.errors.insertPlainText(os.linesep)
- self.errors.ensureCursorVisible()
- else:
- self.errors.insertPlainText(inputTxt)
- self.errors.ensureCursorVisible()
-
- self.process.write(strToQByteArray(inputTxt))
-
- self.passwordCheckBox.setChecked(False)
- self.input.clear()
-
- def on_input_returnPressed(self):
- """
- Private slot to handle the press of the return key in the input field.
- """
- self.intercept = True
- self.on_sendButton_clicked()
-
- def keyPressEvent(self, evt):
- """
- Protected slot to handle a key press event.
-
- @param evt the key press event (QKeyEvent)
- """
- if self.intercept:
- self.intercept = False
- evt.accept()
- return
- super(HgBookmarksListDialog, self).keyPressEvent(evt)
-
@pyqtSlot()
def on_refreshButton_clicked(self):
"""
