src/eric7/Plugins/CheckerPlugins/CodeStyleChecker/Security/Checks/requestWithoutTimeout.py

Mon, 24 Feb 2025 15:11:18 +0100

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Mon, 24 Feb 2025 15:11:18 +0100
branch
eric7
changeset 11147
dee6e106b4d3
parent 11137
a90284948331
permissions
-rw-r--r--

Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).

# -*- coding: utf-8 -*-

# Copyright (c) 2022 - 2025 Detlev Offenbach <detlev@die-offenbachs.de>
#

"""
Module implementing checks for using 'requests' or 'httpx' calls without timeout.
"""

#
# This is a modified version of the one found in the bandit package.
#
# SPDX-License-Identifier: Apache-2.0
#


def getChecks():
    """
    Public method to get a dictionary with checks handled by this module.

    @return dictionary containing checker lists containing checker function and
        list of codes
    @rtype dict
    """
    return {
        "Call": [
            (checkRequestWithouTimeout, ("S-114",)),
        ],
    }


def checkRequestWithouTimeout(reportError, context, _config):
    """
    Function to check for use of requests without timeout.

    @param reportError function to be used to report errors
    @type func
    @param context security context object
    @type SecurityContext
    @param _config dictionary with configuration data (unused)
    @type dict
    """
    httpVerbs = {"get", "options", "head", "post", "put", "patch", "delete"}
    httpxAttrs = {"request", "stream", "Client", "AsyncClient"} | httpVerbs
    qualName = context.callFunctionNameQual.split(".")[0]

    if (
        qualName == "requests"
        and context.callFunctionName in httpVerbs
        and context.checkCallArgValue("timeout") is None
    ):
        # check for missing timeout
        reportError(
            context.node.lineno - 1,
            context.node.col_offset,
            "S-114.1",
            "M",
            "L",
            qualName,
        )

    if (
        (qualName == "requests" and context.callFunctionName in httpVerbs)
        or (qualName == "httpx" and context.callFunctionName in httpxAttrs)
    ) and context.checkCallArgValue("timeout", "None"):
        # check for timeout=None
        reportError(
            context.node.lineno - 1,
            context.node.col_offset,
            "S-114.2",
            "M",
            "L",
            qualName,
        )

eric ide

mercurial