Mercurial Repositories > eric / file diff

--- a/src/eric7/UI/Previewers/PreviewerHTML.py	Fri Nov 29 13:19:56 2024 +0100
+++ b/src/eric7/UI/Previewers/PreviewerHTML.py	Fri Nov 29 14:55:15 2024 +0100
@@ -66,6 +66,10 @@
 
             self.previewView = QWebEngineView(self)
             self.previewView.page().linkHovered.connect(self.__showLink)
+
+            settings = self.previewView.settings()
+            settings.setAttribute(settings.WebAttribute.JavascriptEnabled, True)
+            # JavaScript needs to be enabled.
         except ImportError:
             self.__previewAvailable = False
             self.titleLabel.setText(
@@ -93,12 +97,6 @@
         sizePolicy = QSizePolicy(
             QSizePolicy.Policy.Expanding, QSizePolicy.Policy.Preferred
         )
-        self.jsCheckBox = QCheckBox(self.tr("Enable JavaScript"), self)
-        self.jsCheckBox.setToolTip(
-            self.tr("Select to enable JavaScript for HTML previews")
-        )
-        self.jsCheckBox.setSizePolicy(sizePolicy)
-        self.__footerLayout.addWidget(self.jsCheckBox, 0, 0)
 
         self.ssiCheckBox = QCheckBox(self.tr("Enable Server Side Includes"), self)
         self.ssiCheckBox.setToolTip(
@@ -114,12 +112,10 @@
         self.__footerLayout.addWidget(self.__htmlButton, 1, 1)
         self.__layout.addLayout(self.__footerLayout)
 
-        self.jsCheckBox.clicked[bool].connect(self.on_jsCheckBox_clicked)
         self.ssiCheckBox.clicked[bool].connect(self.on_ssiCheckBox_clicked)
         self.previewView.titleChanged.connect(self.on_previewView_titleChanged)
         self.__htmlButton.clicked.connect(self.on_htmlButton_clicked)
 
-        self.jsCheckBox.setChecked(Preferences.getUI("ShowFilePreviewJS"))
         self.ssiCheckBox.setChecked(Preferences.getUI("ShowFilePreviewSSI"))
 
         self.__scrollBarPositions = {}
@@ -141,31 +137,6 @@
             self.__processingThread.wait()
 
     @pyqtSlot(bool)
-    def on_jsCheckBox_clicked(self, checked):
-        """
-        Private slot to enable/disable JavaScript.
-
-        @param checked state of the checkbox
-        @type bool
-        """
-        Preferences.setUI("ShowFilePreviewJS", checked)
-        self.__setJavaScriptEnabled(checked)
-
-    def __setJavaScriptEnabled(self, enable):
-        """
-        Private method to enable/disable JavaScript.
-
-        @param enable flag indicating the enable state
-        @type bool
-        """
-        self.jsCheckBox.setChecked(enable)
-
-        settings = self.previewView.settings()
-        settings.setAttribute(settings.WebAttribute.JavascriptEnabled, enable)
-
-        self.processEditor()
-
-    @pyqtSlot(bool)
     def on_ssiCheckBox_clicked(self, checked):
         """
         Private slot to enable/disable SSI.