--- a/Helpviewer/Bookmarks/BookmarksImporters/FirefoxImporter.py Tue Mar 07 18:46:09 2017 +0100 +++ b/Helpviewer/Bookmarks/BookmarksImporters/FirefoxImporter.py Tue Mar 07 18:53:18 2017 +0100 @@ -20,18 +20,18 @@ import Globals -def getImporterInfo(id): +def getImporterInfo(sourceId): """ Module function to get information for the given source id. - @param id id of the browser ("chrome" or "chromium") + @param sourceId id of the browser ("chrome" or "chromium") @return tuple with an icon (QPixmap), readable name (string), name of the default bookmarks file (string), an info text (string), a prompt (string) and the default directory of the bookmarks file (string) @exception ValueError raised to indicate an invalid browser ID """ - if id == "firefox": + if sourceId == "firefox": if Globals.isWindowsPlatform(): standardDir = os.path.expandvars( "%APPDATA%\\Mozilla\\Firefox\\Profiles") @@ -55,21 +55,22 @@ standardDir, ) else: - raise ValueError("Unsupported browser ID given ({0}).".format(id)) + raise ValueError( + "Unsupported browser ID given ({0}).".format(sourceId)) class FirefoxImporter(BookmarksImporter): """ Class implementing the Chrome bookmarks importer. """ - def __init__(self, id="", parent=None): + def __init__(self, sourceId="", parent=None): """ Constructor - @param id source ID (string) + @param sourceId source ID (string) @param parent reference to the parent object (QObject) """ - super(FirefoxImporter, self).__init__(id, parent) + super(FirefoxImporter, self).__init__(sourceId, parent) self.__fileName = "" self.__db = None