eric6/Plugins/CheckerPlugins/CodeStyleChecker/Security/Checks/insecureSslTls.py

branch
maintenance
changeset 8273
698ae46f40a4
parent 8259
2bbec88047dd
--- a/eric6/Plugins/CheckerPlugins/CodeStyleChecker/Security/Checks/insecureSslTls.py	Fri Apr 02 11:59:41 2021 +0200
+++ b/eric6/Plugins/CheckerPlugins/CodeStyleChecker/Security/Checks/insecureSslTls.py	Sat May 01 14:27:20 2021 +0200
@@ -48,11 +48,11 @@
     @param config dictionary with configuration data
     @type dict
     """
-    if config and "insecure_ssl_protocol_versions" in config:
-        insecureProtocolVersions = config["insecure_ssl_protocol_versions"]
-    else:
-        insecureProtocolVersions = SecurityDefaults[
-            "insecure_ssl_protocol_versions"]
+    insecureProtocolVersions = (
+        config["insecure_ssl_protocol_versions"]
+        if config and "insecure_ssl_protocol_versions" in config else
+        SecurityDefaults["insecure_ssl_protocol_versions"]
+    )
     
     if context.callFunctionNameQual == 'ssl.wrap_socket':
         if context.checkCallArgValue('ssl_version', insecureProtocolVersions):
@@ -109,11 +109,11 @@
     @param config dictionary with configuration data
     @type dict
     """
-    if config and "insecure_ssl_protocol_versions" in config:
-        insecureProtocolVersions = config["insecure_ssl_protocol_versions"]
-    else:
-        insecureProtocolVersions = SecurityDefaults[
-            "insecure_ssl_protocol_versions"]
+    insecureProtocolVersions = (
+        config["insecure_ssl_protocol_versions"]
+        if config and "insecure_ssl_protocol_versions" in config else
+        SecurityDefaults["insecure_ssl_protocol_versions"]
+    )
     
     for default in context.functionDefDefaultsQual:
         val = default.split(".")[-1]
@@ -138,16 +138,18 @@
     @param config dictionary with configuration data
     @type dict
     """
-    if context.callFunctionNameQual == 'ssl.wrap_socket':
-        if context.checkCallArgValue('ssl_version') is None:
-            # checkCallArgValue() returns False if the argument is found
-            # but does not match the supplied value (or the default None).
-            # It returns None if the argument passed doesn't exist. This
-            # tests for that (ssl_version is not specified).
-            reportError(
-                context.node.lineno - 1,
-                context.node.col_offset,
-                "S504",
-                "L",
-                "M",
-            )
+    if (
+        context.callFunctionNameQual == 'ssl.wrap_socket' and
+        context.checkCallArgValue('ssl_version') is None
+    ):
+        # checkCallArgValue() returns False if the argument is found
+        # but does not match the supplied value (or the default None).
+        # It returns None if the argument passed doesn't exist. This
+        # tests for that (ssl_version is not specified).
+        reportError(
+            context.node.lineno - 1,
+            context.node.col_offset,
+            "S504",
+            "L",
+            "M",
+        )

eric ide

mercurial