eric: comparison eric6/Plugins/CheckerPlugins/CodeStyleChecker/MiscellaneousChecker.py

-:d595f6f9cbf8
+:4ef3b78ebb4e
 "MinFilesize",
 self.__defaultArgs["CopyrightChecker"]["MinFilesize"])
 copyrightAuthor = copyrightArgs.get(
 "Author",
 self.__defaultArgs["CopyrightChecker"]["Author"])
-copyrightRegexStr = \
+copyrightRegexStr = (
 r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}"
+)
 tocheck = max(1024, copyrightMinFileSize)
 topOfSource = source[:tocheck]
 if len(topOfSource) < copyrightMinFileSize:
 return
 def __checkPrintStatements(self):
 """
 Private method to check for print statements.
 """
 for node in ast.walk(self.__tree):
-if (isinstance(node, ast.Call) and
+if (
-getattr(node.func, 'id', None) == 'print') or \
+(isinstance(node, ast.Call) and
-(hasattr(ast, 'Print') and isinstance(node, ast.Print)):
+getattr(node.func, 'id', None) == 'print') or
+(hasattr(ast, 'Print') and isinstance(node, ast.Print))
+):
 self.__error(node.lineno - 1, node.col_offset, "M801")
 def __checkTuple(self):
 """
 Private method to check for one element tuples.
 """
 for node in ast.walk(self.__tree):
-if isinstance(node, ast.Tuple) and \
+if (
-len(node.elts) == 1:
+isinstance(node, ast.Tuple) and
+len(node.elts) == 1
+):
 self.__error(node.lineno - 1, node.col_offset, "M811")
 def __checkFuture(self):
 """
 Private method to check the __future__ imports.
 for node in ast.walk(self.__tree):
 if isinstance(node, ast.Assign):
 # assign statement
 for element in node.targets:
-if isinstance(element, ast.Name) and \
+if (
-element.id in self.__builtins:
+isinstance(element, ast.Name) and
+element.id in self.__builtins
+):
 value = node.value
-if isinstance(value, ast.Name) and \
+if (
-element.id in ignoreBuiltinAssignments and \
+isinstance(value, ast.Name) and
-value.id in ignoreBuiltinAssignments[element.id]:
+element.id in ignoreBuiltinAssignments and
+value.id in ignoreBuiltinAssignments[element.id]
+):
 # ignore compatibility assignments
 continue
 self.__error(element.lineno - 1, element.col_offset,
 "M131", element.id)
 elif isinstance(element, (ast.Tuple, ast.List)):
 for tupleElement in element.elts:
-if isinstance(tupleElement, ast.Name) and \
+if (
-tupleElement.id in self.__builtins:
+isinstance(tupleElement, ast.Name) and
+tupleElement.id in self.__builtins
+):
 self.__error(tupleElement.lineno - 1,
 tupleElement.col_offset,
 "M131", tupleElement.id)
 elif isinstance(node, ast.For):
 # for loop
 target = node.target
-if isinstance(target, ast.Name) and \
+if (
-target.id in self.__builtins:
+isinstance(target, ast.Name) and
+target.id in self.__builtins
+):
 self.__error(target.lineno - 1, target.col_offset,
 "M131", target.id)
 elif isinstance(target, (ast.Tuple, ast.List)):
 for element in target.elts:
-if isinstance(element, ast.Name) and \
+if (
-element.id in self.__builtins:
+isinstance(element, ast.Name) and
+element.id in self.__builtins
+):
 self.__error(element.lineno - 1,
 element.col_offset,
 "M131", element.id)
 elif any(isinstance(node, functionDef)
 for functionDef in functionDefs):
 # (asynchronous) function definition
 if sys.version_info >= (3, 0):
 for arg in node.args.args:
-if isinstance(arg, ast.arg) and \
+if (
-arg.arg in self.__builtins:
+isinstance(arg, ast.arg) and
+arg.arg in self.__builtins
+):
 self.__error(arg.lineno - 1, arg.col_offset,
 "M132", arg.arg)
 else:
 for arg in node.args.args:
-if isinstance(arg, ast.Name) and \
+if (
-arg.id in self.__builtins:
+isinstance(arg, ast.Name) and
+arg.id in self.__builtins
+):
 self.__error(arg.lineno - 1, arg.col_offset,
 "M132", arg.id)
 def __checkComprehensions(self):
 """
 @rtype bool
 """
 if not all(isinstance(key, ast.Str) for key in node.keys):
 return False
-if "__IGNORE_WARNING__" in self.__source[node.lineno - 1] or \
+if (
-"__IGNORE_WARNING_M201__" in self.__source[node.lineno - 1]:
+"__IGNORE_WARNING__" in self.__source[node.lineno - 1] or
+"__IGNORE_WARNING_M201__" in self.__source[node.lineno - 1]
+):
 return False
 lineNumbers = [key.lineno for key in node.keys]
 return len(lineNumbers) == len(set(lineNumbers))
 def __checkGettext(self):
 """
 Private method to check the 'gettext' import statement.
 """
 for node in ast.walk(self.__tree):
-if isinstance(node, ast.ImportFrom) and \
+if (
-any(name.asname == '_' for name in node.names):
+isinstance(node, ast.ImportFrom) and
+any(name.asname == '_' for name in node.names)
+):
 self.__error(node.lineno - 1, node.col_offset, "M711",
 node.names[0].name)
 def __checkBugBear(self):
 """
 @param node reference to the node to be checked
 @type ast.keyword
 @return flag indicating we are inside the extra keyword
 @rtype bool
 """
-return self.__currentExtraKeyword is not None and \
+return (
+self.__currentExtraKeyword is not None and
 self.__currentExtraKeyword != node
+)
 def __detectLoggingLevel(self, node):
 """
 Private method to decide whether an AST Call is a logging call.
 self.violations.append((node, "M655"))
 for index, child in enumerate(ast.iter_child_nodes(node)):
 if index == 1:
 self.__currentLoggingArgument = child
-if index > 1 and isinstance(child, ast.keyword) and \
+if (
-child.arg == "extra":
+index > 1 and
+isinstance(child, ast.keyword) and
+child.arg == "extra"
+):
 self.__currentExtraKeyword = child
 super(LoggingVisitor, self).visit(child)
 self.__currentLoggingArgument = None
 @param node AST node to be traversed
 @type ast.Node
 """
 self.__nodeStack.append(node)
 self.__nodeWindow.append(node)
-self.__nodeWindow = \
+self.__nodeWindow = self.__nodeWindow[-BugBearVisitor.NodeWindowSize:]
-self.__nodeWindow[-BugBearVisitor.NodeWindowSize:]
 super(BugBearVisitor, self).visit(node)
 self.__nodeStack.pop()
 callPath = list(composeCallPath(node))
 if '.'.join(callPath) == 'sys.maxint' and sys.version_info >= (3, 0):
 self.violations.append((node, "M504"))
-elif len(callPath) == 2 and callPath[1] == 'message' and \
+elif (
-sys.version_info >= (2, 6):
+len(callPath) == 2 and
+callPath[1] == 'message' and
+sys.version_info >= (2, 6)
+):
 name = callPath[0]
 for elem in reversed(self.__nodeStack[:-1]):
 if isinstance(elem, ast.ExceptHandler) and elem.name == name:
 self.violations.append((node, "M505"))
 break
 if '__metaclass__' in assignTargets and sys.version_info >= (3, 0):
 self.violations.append((node, "M524"))
 elif len(node.targets) == 1:
 target = node.targets[0]
-if isinstance(target, ast.Attribute) and \
+if (
-isinstance(target.value, ast.Name):
+isinstance(target, ast.Attribute) and
+isinstance(target.value, ast.Name)
+):
 if (target.value.id, target.attr) == ('os', 'environ'):
 self.violations.append((node, "M506"))
 self.generic_visit(node)
 Public method to handle 'assert' statements.
 @param node reference to the node to be processed
 @type ast.Assert
 """
-if isinstance(node.test, ast.NameConstant) and \
+if (
-node.test.value is False:
+isinstance(node.test, ast.NameConstant) and
+node.test.value is False
+):
 self.violations.append((node, "M503"))
 self.generic_visit(node)
 def visit_JoinedStr(self, node):

Mercurial Repositories > eric / file comparison

comparison: eric6/Plugins/CheckerPlugins/CodeStyleChecker/MiscellaneousChecker.py

eric6/Plugins/CheckerPlugins/CodeStyleChecker/MiscellaneousChecker.py