Sat, 26 Apr 2025 12:34:32 +0200
MicroPython
- Added a configuration option to disable the support for the no longer produced Pimoroni Pico Wireless Pack.
8189 | 1 | # -*- coding: utf-8 -*- |
2 | ||
11090
f5f5f5803935
Updated copyright for 2025.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3 | # Copyright (c) 2021 - 2025 Detlev Offenbach <detlev@die-offenbachs.de> |
8189 | 4 | # |
5 | ||
6 | """ | |
7 | Module implementing a node visitor checking for code that could be simplified. | |
8 | """ | |
9 | ||
10 | import ast | |
11 | import collections | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
12 | import copy |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
13 | import itertools |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
14 | import json |
8189 | 15 | |
16 | try: | |
17 | from ast import unparse | |
18 | except ImportError: | |
19 | # Python < 3.9 | |
10116
4a619fb7bd09
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10050
diff
changeset
|
20 | from ast_unparse import unparse |
8189 | 21 | |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
22 | import AstUtilities |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
23 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
24 | ############################################################################### |
10355
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
25 | ## adapted from: flake8-simplify v0.21.0 |
8189 | 26 | ## |
11141
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
27 | ## combined with: flake8-nested-fstring v1.1.0 |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
28 | ############################################################################### |
8189 | 29 | |
30 | ||
31 | class SimplifyNodeVisitor(ast.NodeVisitor): | |
32 | """ | |
33 | Class to traverse the AST node tree and check for code that can be | |
34 | simplified. | |
35 | """ | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
36 | |
8189 | 37 | def __init__(self, errorCallback): |
38 | """ | |
39 | Constructor | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
40 | |
8189 | 41 | @param errorCallback callback function to register an error |
42 | @type func | |
43 | """ | |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8216
diff
changeset
|
44 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
45 | |
8189 | 46 | self.__error = errorCallback |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
47 | |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
48 | self.__classDefinitionStack = [] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
49 | |
8189 | 50 | def visit_Expr(self, node): |
51 | """ | |
52 | Public method to process an Expr node. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
53 | |
8189 | 54 | @param node reference to the Expr node |
55 | @type ast.Expr | |
56 | """ | |
57 | self.__check112(node) | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
58 | |
8189 | 59 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
60 | |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
61 | def visit_Assign(self, node): |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
62 | """ |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
63 | Public method to process an Assign node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
64 | |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
65 | @param node reference to the Assign node |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
66 | @type ast.Assign |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
67 | """ |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
68 | self.__check181(node) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
69 | self.__check904(node) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
70 | self.__check909(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
71 | |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
72 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
73 | |
8189 | 74 | def visit_BoolOp(self, node): |
75 | """ | |
76 | Public method to process a BoolOp node. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
77 | |
8189 | 78 | @param node reference to the BoolOp node |
79 | @type ast.BoolOp | |
80 | """ | |
81 | self.__check101(node) | |
82 | self.__check109(node) | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
83 | self.__check221(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
84 | self.__check222(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
85 | self.__check223(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
86 | self.__check224(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
87 | |
8189 | 88 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
89 | |
8189 | 90 | def visit_If(self, node): |
91 | """ | |
92 | Public method to process an If node. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
93 | |
8189 | 94 | @param node reference to the If node |
95 | @type ast.If | |
96 | """ | |
97 | self.__check102(node) | |
98 | self.__check103(node) | |
99 | self.__check106(node) | |
100 | self.__check108(node) | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
101 | self.__check114(node) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
102 | self.__check116(node) |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
103 | self.__check122(node) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
104 | self.__check123(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
105 | |
8189 | 106 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
107 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
108 | def visit_IfExp(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
109 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
110 | Public method to process an IfExp node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
111 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
112 | @param node reference to the IfExp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
113 | @type ast.IfExp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
114 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
115 | self.__check211(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
116 | self.__check212(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
117 | self.__check213(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
118 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
119 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
120 | |
8189 | 121 | def visit_For(self, node): |
122 | """ | |
123 | Public method to process a For node. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
124 | |
8189 | 125 | @param node reference to the For node |
126 | @type ast.For | |
127 | """ | |
128 | self.__check104(node) | |
129 | self.__check110_111(node) | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
130 | self.__check113(node) |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
131 | self.__check118(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
132 | |
8189 | 133 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
134 | |
8189 | 135 | def visit_Try(self, node): |
136 | """ | |
137 | Public method to process a Try node. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
138 | |
8189 | 139 | @param node reference to the Try node |
140 | @type ast.Try | |
141 | """ | |
142 | self.__check105(node) | |
143 | self.__check107(node) | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
144 | |
8189 | 145 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
146 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
147 | def visit_Call(self, node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
148 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
149 | Public method to process a Call node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
150 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
151 | @param node reference to the Call node |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
152 | @type ast.Call |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
153 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
154 | self.__check115(node) |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
155 | self.__check182(node) |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
156 | self.__check401(node) |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
157 | self.__check402(node) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
158 | self.__check901(node) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
159 | self.__check905(node) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
160 | self.__check906(node) |
10047
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
161 | self.__check910(node) |
10355
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
162 | self.__check911(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
163 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
164 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
165 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
166 | def visit_With(self, node): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
167 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
168 | Public method to process a With node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
169 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
170 | @param node reference to the With node |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
171 | @type ast.With |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
172 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
173 | self.__check117(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
174 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
175 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
176 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
177 | def visit_Compare(self, node): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
178 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
179 | Public method to process a Compare node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
180 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
181 | @param node reference to the Compare node |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
182 | @type ast.Compare |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
183 | """ |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
184 | self.__check118(node) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
185 | self.__check301(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
186 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
187 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
188 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
189 | def visit_ClassDef(self, node): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
190 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
191 | Public method to process a ClassDef node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
192 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
193 | @param node reference to the ClassDef node |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
194 | @type ast.ClassDef |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
195 | """ |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
196 | # register the name of the class being defined |
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
197 | self.__classDefinitionStack.append(node.name) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
198 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
199 | self.__check119(node) |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
200 | self.__check120_121(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
201 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
202 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
203 | |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
204 | self.__classDefinitionStack.pop() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
205 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
206 | def visit_UnaryOp(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
207 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
208 | Public method to process a UnaryOp node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
209 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
210 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
211 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
212 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
213 | self.__check201(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
214 | self.__check202(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
215 | self.__check203(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
216 | self.__check204(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
217 | self.__check205(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
218 | self.__check206(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
219 | self.__check207(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
220 | self.__check208(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
221 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
222 | self.generic_visit(node) |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
223 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
224 | def visit_Subscript(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
225 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
226 | Public method to process a Subscript node. |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
227 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
228 | @param node reference to the Subscript node |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
229 | @type ast.Subscript |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
230 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
231 | self.__check907(node) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
232 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
233 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
234 | |
11141
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
235 | def visit_JoinedStr(self, node): |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
236 | """ |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
237 | Public method to check a joined string node. |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
238 | |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
239 | @param node reference to the node to be processed |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
240 | @type ast.JoinedStr |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
241 | """ |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
242 | self.__check411(node) |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
243 | |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
244 | self.generic_visit(node) |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
245 | |
8189 | 246 | ############################################################# |
247 | ## Helper methods for the various checkers below | |
248 | ############################################################# | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
249 | |
8189 | 250 | def __getDuplicatedIsinstanceCall(self, node): |
251 | """ | |
252 | Private method to get a list of isinstance arguments which could | |
253 | be combined. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
254 | |
8189 | 255 | @param node reference to the AST node to be inspected |
256 | @type ast.BoolOp | |
257 | @return list of variable names of duplicated isinstance calls | |
258 | @rtype list of str | |
259 | """ | |
260 | counter = collections.defaultdict(int) | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
261 | |
8189 | 262 | for call in node.values: |
263 | # Ensure this is a call of the built-in isinstance() function. | |
264 | if not isinstance(call, ast.Call) or len(call.args) != 2: | |
265 | continue | |
266 | functionName = unparse(call.func) | |
267 | if functionName != "isinstance": | |
268 | continue | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
269 | |
8189 | 270 | arg0Name = unparse(call.args[0]) |
271 | counter[arg0Name] += 1 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
272 | |
8189 | 273 | return [name for name, count in counter.items() if count > 1] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
274 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
275 | def __isConstantIncrease(self, expr): |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
276 | """ |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
277 | Private method to check an expression for being a constant increase. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
278 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
279 | @param expr reference to the node to be checked |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
280 | @type ast.AugAssign |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
281 | @return flag indicating a constant increase |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
282 | @rtype bool |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
283 | """ |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
284 | return isinstance(expr.op, ast.Add) and ( |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
285 | (isinstance(expr.value, ast.Constant) and expr.value.value == 1) |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
286 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
287 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
288 | def __getIfBodyPairs(self, node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
289 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
290 | Private method to extract a list of pairs of test and body for an |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
291 | If node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
292 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
293 | @param node reference to the If node to be processed |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
294 | @type ast.If |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
295 | @return list of pairs of test and body |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
296 | @rtype list of tuples of (ast.expr, [ast.stmt]) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
297 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
298 | pairs = [(node.test, node.body)] |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
299 | orelse = node.orelse |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
300 | while ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
301 | isinstance(orelse, list) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
302 | and len(orelse) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
303 | and isinstance(orelse[0], ast.If) |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
304 | ): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
305 | pairs.append((orelse[0].test, orelse[0].body)) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
306 | orelse = orelse[0].orelse |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
307 | return pairs |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
308 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
309 | def __isSameBody(self, body1, body2): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
310 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
311 | Private method check, if the given bodies are equivalent. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
312 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
313 | @param body1 list of statements of the first body |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
314 | @type list of ast.stmt |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
315 | @param body2 list of statements of the second body |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
316 | @type list of ast.stmt |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
317 | @return flag indicating identical bodies |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
318 | @rtype bool |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
319 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
320 | if len(body1) != len(body2): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
321 | return False |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
322 | for a, b in zip(body1, body2): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
323 | try: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
324 | statementEqual = self.__isStatementEqual(a, b) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
325 | except RecursionError: # maximum recursion depth |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
326 | statementEqual = False |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
327 | if not statementEqual: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
328 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
329 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
330 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
331 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
332 | def __isSameExpression(self, a, b): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
333 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
334 | Private method to check, if two expressions are equal. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
335 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
336 | @param a first expression to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
337 | @type ast.expr |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
338 | @param b second expression to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
339 | @type ast.expr |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
340 | @return flag indicating equal expressions |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
341 | @rtype bool |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
342 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
343 | if isinstance(a, ast.Name) and isinstance(b, ast.Name): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
344 | return a.id == b.id |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
345 | else: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
346 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
347 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
348 | def __isStatementEqual(self, a, b): |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
349 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
350 | Private method to check, if two statements are equal. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
351 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
352 | @param a reference to the first statement |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
353 | @type ast.stmt |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
354 | @param b reference to the second statement |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
355 | @type ast.stmt |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
356 | @return flag indicating if the two statements are equal |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
357 | @rtype bool |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
358 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
359 | if type(a) is not type(b): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
360 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
361 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
362 | if isinstance(a, ast.AST): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
363 | for k, v in vars(a).items(): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
364 | if k in ("lineno", "col_offset", "ctx", "end_lineno", "parent"): |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
365 | continue |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
366 | if not self.__isStatementEqual(v, getattr(b, k)): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
367 | return False |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
368 | return True |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
369 | elif isinstance(a, list): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
370 | return all(itertools.starmap(self.__isStatementEqual, zip(a, b))) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
371 | else: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
372 | return a == b |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
373 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
374 | def __isExceptionCheck(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
375 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
376 | Private method to check, if the node is checking an exception. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
377 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
378 | @param node reference to the node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
379 | @type ast.If |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
380 | @return flag indicating an exception check |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
381 | @rtype bool |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
382 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
383 | return len(node.body) == 1 and isinstance(node.body[0], ast.Raise) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
384 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
385 | def __negateTest(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
386 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
387 | Private method negate the given Compare node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
388 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
389 | @param node reference to the node to be negated |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
390 | @type ast.Compare |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
391 | @return node with negated logic |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
392 | @rtype ast.Compare |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
393 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
394 | newNode = copy.deepcopy(node) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
395 | op = newNode.ops[0] |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
396 | if isinstance(op, ast.Eq): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
397 | op = ast.NotEq() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
398 | elif isinstance(op, ast.NotEq): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
399 | op = ast.Eq() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
400 | elif isinstance(op, ast.Lt): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
401 | op = ast.GtE() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
402 | elif isinstance(op, ast.LtE): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
403 | op = ast.Gt() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
404 | elif isinstance(op, ast.Gt): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
405 | op = ast.LtE() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
406 | elif isinstance(op, ast.GtE): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
407 | op = ast.Lt() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
408 | elif isinstance(op, ast.Is): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
409 | op = ast.IsNot() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
410 | elif isinstance(op, ast.IsNot): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
411 | op = ast.Is() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
412 | elif isinstance(op, ast.In): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
413 | op = ast.NotIn() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
414 | elif isinstance(op, ast.NotIn): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
415 | op = ast.In() |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
416 | newNode.ops = [op] |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
417 | return newNode |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
418 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
419 | def __expressionUsesVariable(self, expr, var): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
420 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
421 | Private method to check, if a variable is used by an expression. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
422 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
423 | @param expr expression node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
424 | @type ast.expr |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
425 | @param var variable name to be checked for |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
426 | @type str |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
427 | @return flag indicating the expression uses the variable |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
428 | @rtype bool |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
429 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
430 | return var in unparse(expr) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
431 | # This is WAY too broad, but it's better to have false-negatives than |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
432 | # false-positives. |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
433 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
434 | def __bodyContainsContinue(self, stmts): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
435 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
436 | Private method to check, if a list of statements contain a 'continue' statement. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
437 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
438 | @param stmts list of statements |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
439 | @type list of ast.stmt |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
440 | @return flag indicating a continue statement |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
441 | @rtype bool |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
442 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
443 | return any( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
444 | isinstance(stmt, ast.Continue) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
445 | or (isinstance(stmt, ast.If) and self.__bodyContainsContinue(stmt.body)) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
446 | for stmt in stmts |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
447 | ) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
448 | |
8189 | 449 | ############################################################# |
450 | ## Methods to check for possible code simplifications below | |
451 | ############################################################# | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
452 | |
8189 | 453 | def __check101(self, node): |
454 | """ | |
455 | Private method to check for duplicate isinstance() calls. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
456 | |
8189 | 457 | @param node reference to the AST node to be checked |
458 | @type ast.BoolOp | |
459 | """ | |
460 | if isinstance(node.op, ast.Or): | |
461 | for variable in self.__getDuplicatedIsinstanceCall(node): | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
462 | self.__error(node, "Y-101", variable) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
463 | |
8189 | 464 | def __check102(self, node): |
465 | """ | |
466 | Private method to check for nested if statements without else blocks. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
467 | |
8189 | 468 | @param node reference to the AST node to be checked |
469 | @type ast.If | |
470 | """ | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
471 | # Don't treat 'if __name__ == "__main__":' as an issue. |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
472 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
473 | isinstance(node.test, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
474 | and isinstance(node.test.left, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
475 | and node.test.left.id == "__name__" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
476 | and isinstance(node.test.ops[0], ast.Eq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
477 | and isinstance(node.test.comparators[0], ast.Constant) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
478 | and node.test.comparators[0].value == "__main__" |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
479 | ): |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
480 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
481 | |
8189 | 482 | # ## Pattern 1 |
483 | # if a: <--- | |
484 | # if b: <--- | |
485 | # c | |
486 | isPattern1 = ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
487 | node.orelse == [] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
488 | and len(node.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
489 | and isinstance(node.body[0], ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
490 | and node.body[0].orelse == [] |
8189 | 491 | ) |
492 | # ## Pattern 2 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
493 | # if a: < irrelevant for here |
8189 | 494 | # pass |
495 | # elif b: <--- this is treated like a nested block | |
496 | # if c: <--- | |
497 | # d | |
498 | if isPattern1: | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
499 | self.__error(node, "Y-102") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
500 | |
8189 | 501 | def __check103(self, node): |
502 | """ | |
503 | Private method to check for calls that wrap a condition to return | |
504 | a bool. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
505 | |
8189 | 506 | @param node reference to the AST node to be checked |
507 | @type ast.If | |
508 | """ | |
509 | # if cond: | |
510 | # return True | |
511 | # else: | |
512 | # return False | |
513 | if not ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
514 | len(node.body) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
515 | or not isinstance(node.body[0], ast.Return) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
516 | or not isinstance(node.body[0].value, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
517 | or not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
518 | node.body[0].value.value is True or node.body[0].value.value is False |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
519 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
520 | or len(node.orelse) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
521 | or not isinstance(node.orelse[0], ast.Return) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
522 | or not isinstance(node.orelse[0].value, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
523 | or not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
524 | node.orelse[0].value.value is True |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
525 | or node.orelse[0].value.value is False |
8189 | 526 | ) |
527 | ): | |
528 | condition = unparse(node.test) | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
529 | self.__error(node, "Y-103", condition) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
530 | |
8189 | 531 | def __check104(self, node): |
532 | """ | |
533 | Private method to check for "iterate and yield" patterns. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
534 | |
8189 | 535 | @param node reference to the AST node to be checked |
536 | @type ast.For | |
537 | """ | |
538 | # for item in iterable: | |
539 | # yield item | |
540 | if not ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
541 | len(node.body) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
542 | or not isinstance(node.body[0], ast.Expr) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
543 | or not isinstance(node.body[0].value, ast.Yield) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
544 | or not isinstance(node.target, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
545 | or not isinstance(node.body[0].value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
546 | or node.target.id != node.body[0].value.value.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
547 | or node.orelse != [] |
8189 | 548 | ): |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
549 | parent = getattr(node, "parent", None) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
550 | while ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
551 | parent |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
552 | and hasattr(parent, "parent") |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
553 | and parent.parent is not parent |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
554 | and not isinstance(parent, ast.AsyncFunctionDef) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
555 | ): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
556 | parent = getattr(parent, "parent", None) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
557 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
558 | if not isinstance(parent, ast.AsyncFunctionDef): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9278
diff
changeset
|
559 | iterable = unparse(node.iter) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
560 | self.__error(node, "Y-104", iterable) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
561 | |
8189 | 562 | def __check105(self, node): |
563 | """ | |
564 | Private method to check for "try-except-pass" patterns. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
565 | |
8189 | 566 | @param node reference to the AST node to be checked |
567 | @type ast.Try | |
568 | """ | |
569 | # try: | |
570 | # foo() | |
571 | # except ValueError: | |
572 | # pass | |
573 | if not ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
574 | len(node.handlers) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
575 | or not isinstance(node.handlers[0], ast.ExceptHandler) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
576 | or len(node.handlers[0].body) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
577 | or not isinstance(node.handlers[0].body[0], ast.Pass) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
578 | or node.orelse != [] |
8189 | 579 | ): |
580 | if node.handlers[0].type is None: | |
581 | exception = "Exception" | |
8241
de2ebf20d822
SimplifyNodeVisitor: fixed an issue in the Y105 message for multiple exceptions.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8219
diff
changeset
|
582 | elif isinstance(node.handlers[0].type, ast.Tuple): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
583 | exception = ", ".join([unparse(n) for n in node.handlers[0].type.elts]) |
8189 | 584 | else: |
585 | exception = unparse(node.handlers[0].type) | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
586 | self.__error(node, "Y-105", exception) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
587 | |
8189 | 588 | def __check106(self, node): |
589 | """ | |
590 | Private method to check for calls where an exception is raised in else. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
591 | |
8189 | 592 | @param node reference to the AST node to be checked |
593 | @type ast.If | |
594 | """ | |
595 | # if cond: | |
596 | # return True | |
597 | # else: | |
598 | # raise Exception | |
599 | just_one = ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
600 | len(node.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
601 | and len(node.orelse) >= 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
602 | and isinstance(node.orelse[-1], ast.Raise) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
603 | and not isinstance(node.body[-1], ast.Raise) |
8189 | 604 | ) |
605 | many = ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
606 | len(node.body) > 2 * len(node.orelse) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
607 | and len(node.orelse) >= 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
608 | and isinstance(node.orelse[-1], ast.Raise) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
609 | and not isinstance(node.body[-1], ast.Raise) |
8189 | 610 | ) |
611 | if just_one or many: | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
612 | self.__error(node, "Y-106") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
613 | |
8189 | 614 | def __check107(self, node): |
615 | """ | |
616 | Private method to check for calls where try/except and finally have | |
617 | 'return'. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
618 | |
8189 | 619 | @param node reference to the AST node to be checked |
620 | @type ast.Try | |
621 | """ | |
622 | # def foo(): | |
623 | # try: | |
624 | # 1 / 0 | |
625 | # return "1" | |
626 | # except: | |
627 | # return "2" | |
628 | # finally: | |
629 | # return "3" | |
630 | tryHasReturn = False | |
631 | for stmt in node.body: | |
632 | if isinstance(stmt, ast.Return): | |
633 | tryHasReturn = True | |
634 | break | |
635 | ||
636 | exceptHasReturn = False | |
637 | for stmt2 in node.handlers: | |
638 | if isinstance(stmt2, ast.Return): | |
639 | exceptHasReturn = True | |
640 | break | |
641 | ||
642 | finallyHasReturn = False | |
643 | finallyReturn = None | |
644 | for stmt in node.finalbody: | |
645 | if isinstance(stmt, ast.Return): | |
646 | finallyHasReturn = True | |
647 | finallyReturn = stmt | |
648 | break | |
649 | ||
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
650 | if (tryHasReturn or exceptHasReturn) and finallyHasReturn: |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
651 | self.__error(finallyReturn, "Y-107") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
652 | |
8189 | 653 | def __check108(self, node): |
654 | """ | |
655 | Private method to check for if-elses which could be a ternary | |
656 | operator assignment. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
657 | |
8189 | 658 | @param node reference to the AST node to be checked |
659 | @type ast.If | |
660 | """ | |
661 | # if a: | |
662 | # b = c | |
663 | # else: | |
664 | # b = d | |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
665 | # |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
666 | # but not: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
667 | # if a: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
668 | # b = c |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
669 | # elif c: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
670 | # b = e |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
671 | # else: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
672 | # b = d |
8189 | 673 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
674 | len(node.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
675 | and len(node.orelse) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
676 | and isinstance(node.body[0], ast.Assign) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
677 | and isinstance(node.orelse[0], ast.Assign) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
678 | and len(node.body[0].targets) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
679 | and len(node.orelse[0].targets) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
680 | and isinstance(node.body[0].targets[0], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
681 | and isinstance(node.orelse[0].targets[0], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
682 | and node.body[0].targets[0].id == node.orelse[0].targets[0].id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
683 | and not isinstance(node.parent, ast.If) |
8189 | 684 | ): |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
685 | targetVar = node.body[0].targets[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
686 | assign = unparse(targetVar) |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
687 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
688 | # It's part of a bigger if-elseif block: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
689 | if isinstance(node.parent, ast.If): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
690 | for n in node.parent.body: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
691 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
692 | isinstance(n, ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
693 | and isinstance(n.targets[0], ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
694 | and n.targets[0].id == targetVar.id |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
695 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
696 | return |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
697 | |
8189 | 698 | body = unparse(node.body[0].value) |
699 | cond = unparse(node.test) | |
700 | orelse = unparse(node.orelse[0].value) | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
701 | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
702 | self.__error(node, "Y-108", assign, body, cond, orelse) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
703 | |
8189 | 704 | def __check109(self, node): |
705 | """ | |
706 | Private method to check for multiple equalities with the same value | |
707 | are combined via "or". | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
708 | |
8189 | 709 | @param node reference to the AST node to be checked |
710 | @type ast.BoolOp | |
711 | """ | |
712 | # if a == b or a == c: | |
713 | # d | |
714 | if isinstance(node.op, ast.Or): | |
715 | equalities = [ | |
716 | value | |
717 | for value in node.values | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
718 | if isinstance(value, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
719 | and len(value.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
720 | and isinstance(value.ops[0], ast.Eq) |
8189 | 721 | ] |
722 | ids = [] # (name, compared_to) | |
723 | for eq in equalities: | |
724 | if isinstance(eq.left, ast.Name): | |
725 | ids.append((eq.left, eq.comparators[0])) | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
726 | if len(eq.comparators) == 1 and isinstance(eq.comparators[0], ast.Name): |
8189 | 727 | ids.append((eq.comparators[0], eq.left)) |
728 | ||
729 | id2count = {} | |
730 | for identifier, comparedTo in ids: | |
731 | if identifier.id not in id2count: | |
732 | id2count[identifier.id] = [] | |
733 | id2count[identifier.id].append(comparedTo) | |
734 | for value, values in id2count.items(): | |
735 | if len(values) == 1: | |
736 | continue | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
737 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
738 | self.__error( |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
739 | node, "Y-109", value, unparse(ast.Tuple(elts=values)), unparse(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
740 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
741 | |
8189 | 742 | def __check110_111(self, node): |
743 | """ | |
744 | Private method to check if any / all could be used. | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
745 | |
8189 | 746 | @param node reference to the AST node to be checked |
747 | @type ast.For | |
748 | """ | |
749 | # for x in iterable: | |
750 | # if check(x): | |
751 | # return True | |
752 | # return False | |
753 | # | |
754 | # for x in iterable: | |
755 | # if check(x): | |
756 | # return False | |
757 | # return True | |
758 | if ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
759 | len(node.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
760 | and isinstance(node.body[0], ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
761 | and len(node.body[0].body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
762 | and isinstance(node.body[0].body[0], ast.Return) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
763 | and isinstance(node.body[0].body[0].value, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
764 | and hasattr(node.body[0].body[0].value, "value") |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
765 | and isinstance(node.next_sibling, ast.Return) |
8189 | 766 | ): |
767 | check = unparse(node.body[0].test) | |
768 | target = unparse(node.target) | |
769 | iterable = unparse(node.iter) | |
770 | if node.body[0].body[0].value.value is True: | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
771 | self.__error(node, "Y-110", check, target, iterable) |
8189 | 772 | elif node.body[0].body[0].value.value is False: |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
773 | isCompoundExpression = " and " in check or " or " in check |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
774 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
775 | if isCompoundExpression: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
776 | check = f"not ({check})" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
777 | else: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
778 | if check.startswith("not "): |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
779 | check = check[len("not ") :] |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
780 | else: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
781 | check = f"not {check}" |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
782 | self.__error(node, "Y-111", check, target, iterable) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
783 | |
8189 | 784 | def __check112(self, node): |
785 | """ | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
786 | Private method to check for non-capitalized calls to environment |
8189 | 787 | variables. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
788 | |
8189 | 789 | @param node reference to the AST node to be checked |
790 | @type ast.Expr | |
791 | """ | |
792 | # os.environ["foo"] | |
793 | # os.environ.get("bar") | |
794 | isIndexCall = ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
795 | isinstance(node.value, ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
796 | and isinstance(node.value.value, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
797 | and isinstance(node.value.value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
798 | and node.value.value.value.id == "os" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
799 | and node.value.value.attr == "environ" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
800 | and ( |
8189 | 801 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
802 | isinstance(node.value.slice, ast.Index) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
803 | and isinstance(node.value.slice.value, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
804 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
805 | or isinstance(node.value.slice, ast.Constant) |
8189 | 806 | ) |
807 | ) | |
808 | if isIndexCall: | |
809 | subscript = node.value | |
810 | slice_ = subscript.slice | |
811 | if isinstance(slice_, ast.Index): | |
812 | # Python < 3.9 | |
813 | stringPart = slice_.value # type: ignore | |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
814 | envName = stringPart.value |
8189 | 815 | elif isinstance(slice_, ast.Constant): |
816 | # Python 3.9 | |
817 | envName = slice_.value | |
818 | ||
819 | # Check if this has a change | |
820 | hasChange = envName != envName.upper() | |
821 | ||
822 | isGetCall = ( | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
823 | isinstance(node.value, ast.Call) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
824 | and isinstance(node.value.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
825 | and isinstance(node.value.func.value, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
826 | and isinstance(node.value.func.value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
827 | and node.value.func.value.value.id == "os" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
828 | and node.value.func.value.attr == "environ" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
829 | and node.value.func.attr == "get" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
830 | and len(node.value.args) in [1, 2] |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
831 | and isinstance(node.value.args[0], ast.Constant) |
8189 | 832 | ) |
833 | if isGetCall: | |
834 | call = node.value | |
835 | stringPart = call.args[0] | |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
836 | envName = stringPart.value |
8189 | 837 | # Check if this has a change |
838 | hasChange = envName != envName.upper() | |
839 | if not (isIndexCall or isGetCall) or not hasChange: | |
840 | return | |
841 | if isIndexCall: | |
842 | original = unparse(node) | |
843 | expected = f"os.environ['{envName.upper()}']" | |
844 | elif isGetCall: | |
845 | original = unparse(node) | |
846 | if len(node.value.args) == 1: | |
847 | expected = f"os.environ.get('{envName.upper()}')" | |
848 | else: | |
849 | defaultValue = unparse(node.value.args[1]) | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
850 | expected = f"os.environ.get('{envName.upper()}', '{defaultValue}')" |
8189 | 851 | else: |
852 | return | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
853 | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
854 | self.__error(node, "Y-112", expected, original) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
855 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
856 | def __check113(self, node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
857 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
858 | Private method to check for loops in which "enumerate" should be |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
859 | used. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
860 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
861 | @param node reference to the AST node to be checked |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
862 | @type ast.For |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
863 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
864 | # idx = 0 |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
865 | # for el in iterable: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
866 | # ... |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
867 | # idx += 1 |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
868 | if not self.__bodyContainsContinue(node.body): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
869 | # Find variables that might just count the iteration of the current loop |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
870 | variableCandidates = [] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
871 | for expression in node.body: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
872 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
873 | isinstance(expression, ast.AugAssign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
874 | and self.__isConstantIncrease(expression) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
875 | and isinstance(expression.target, ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
876 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
877 | variableCandidates.append(expression.target) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
878 | strCandidates = [unparse(x) for x in variableCandidates] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
879 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
880 | olderSiblings = [] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
881 | for olderSibling in node.parent.body: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
882 | if olderSibling is node: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
883 | break |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
884 | olderSiblings.append(olderSibling) |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
885 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
886 | matches = [ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
887 | n.targets[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
888 | for n in olderSiblings |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
889 | if isinstance(n, ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
890 | and len(n.targets) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
891 | and isinstance(n.targets[0], ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
892 | and unparse(n.targets[0]) in strCandidates |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
893 | ] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
894 | if len(matches) == 0: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
895 | return |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
896 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
897 | sibling = node.previous_sibling |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
898 | while sibling is not None: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
899 | sibling = sibling.previous_sibling |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
900 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
901 | for match in matches: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
902 | variable = unparse(match) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
903 | self.__error(match, "Y-113", variable) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
904 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
905 | def __check114(self, node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
906 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
907 | Private method to check for alternative if clauses with identical |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
908 | bodies. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
909 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
910 | @param node reference to the AST node to be checked |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
911 | @type ast.If |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
912 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
913 | # if a: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
914 | # b |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
915 | # elif c: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
916 | # b |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
917 | ifBodyPairs = self.__getIfBodyPairs(node) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
918 | errorPairs = [] |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
919 | for i in range(len(ifBodyPairs) - 1): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
920 | # It's not all combinations because of this: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
921 | ifbody1 = ifBodyPairs[i] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
922 | ifbody2 = ifBodyPairs[i + 1] |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
923 | if self.__isSameBody(ifbody1[1], ifbody2[1]): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
924 | errorPairs.append((ifbody1, ifbody2)) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
925 | for ifbody1, ifbody2 in errorPairs: |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
926 | self.__error(ifbody1[0], "Y-114", unparse(ifbody1[0]), unparse(ifbody2[0])) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
927 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
928 | def __check115(self, node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
929 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
930 | Private method to to check for places where open() is called without |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
931 | a context handler. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
932 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
933 | @param node reference to the AST node to be checked |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
934 | @type ast.Call |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
935 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
936 | # f = open(...) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
937 | # . .. # (do something with f) |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
938 | # f.close() |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
939 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
940 | isinstance(node.func, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
941 | and node.func.id == "open" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
942 | and not isinstance(node.parent, ast.withitem) |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
943 | ): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
944 | self.__error(node, "Y-115") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
945 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
946 | def __check116(self, node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
947 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
948 | Private method to check for places with 3 or more consecutive |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
949 | if-statements with direct returns. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
950 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
951 | * Each if-statement must be a check for equality with the |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
952 | same variable |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
953 | * Each if-statement must just have a "return" |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
954 | * Else must also just have a return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
955 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
956 | @param node reference to the AST node to be checked |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
957 | @type ast.If |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
958 | """ |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
959 | # if a == "foo": |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
960 | # return "bar" |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
961 | # elif a == "bar": |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
962 | # return "baz" |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
963 | # elif a == "boo": |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
964 | # return "ooh" |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
965 | # else: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
966 | # return 42 |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
967 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
968 | isinstance(node.test, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
969 | and isinstance(node.test.left, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
970 | and len(node.test.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
971 | and isinstance(node.test.ops[0], ast.Eq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
972 | and len(node.test.comparators) == 1 |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
973 | and isinstance(node.test.comparators[0], ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
974 | and len(node.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
975 | and isinstance(node.body[0], ast.Return) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
976 | and len(node.orelse) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
977 | and isinstance(node.orelse[0], ast.If) |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
978 | ): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
979 | variable = node.test.left |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
980 | child = node.orelse[0] |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
981 | elseValue = None |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
982 | if node.body[0].value is not None: |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
983 | bodyValueStr = unparse(node.body[0].value).strip("'") |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
984 | else: |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
985 | bodyValueStr = "None" |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
986 | if AstUtilities.isString(node.test.comparators[0]): |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
987 | value = ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
988 | bodyValueStr |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
989 | if bodyValueStr[0] == '"' and bodyValueStr[-1] == '"' |
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
990 | else bodyValueStr[1:-1] |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
991 | ) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
992 | keyValuePairs = {node.test.comparators[0].s: value} |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
993 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
994 | keyValuePairs = {node.test.comparators[0].value: bodyValueStr} |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
995 | while child: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
996 | if not ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
997 | isinstance(child.test, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
998 | and isinstance(child.test.left, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
999 | and child.test.left.id == variable.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1000 | and len(child.test.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1001 | and isinstance(child.test.ops[0], ast.Eq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1002 | and len(child.test.comparators) == 1 |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1003 | and isinstance(child.test.comparators[0], ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1004 | and len(child.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1005 | and isinstance(child.body[0], ast.Return) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1006 | and len(child.orelse) <= 1 |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1007 | ): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1008 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1009 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1010 | returnCall = child.body[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1011 | if isinstance(returnCall.value, ast.Call): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1012 | return |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1013 | |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1014 | key = child.test.comparators[0].value |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1015 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1016 | value = unparse(child.body[0].value) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1017 | if value[0] == '"' and value[-1] == '"': |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1018 | value = value[1:-1] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1019 | keyValuePairs[key] = value |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1020 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1021 | if len(child.orelse) == 1: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1022 | if isinstance(child.orelse[0], ast.If): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1023 | child = child.orelse[0] |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1024 | elif isinstance(child.orelse[0], ast.Return): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1025 | elseValue = unparse(child.orelse[0].value) |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1026 | child = None |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1027 | else: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1028 | return |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1029 | else: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1030 | child = None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1031 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1032 | if len(keyValuePairs) < 3: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1033 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1034 | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1035 | if elseValue: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1036 | ret = f"{keyValuePairs}.get({variable.id}, {elseValue})" |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1037 | else: |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
1038 | ret = f"{keyValuePairs}.get({variable.id})" |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1039 | |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1040 | self.__error(node, "Y-116", ret) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1041 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1042 | def __check117(self, node): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1043 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1044 | Private method to check for multiple with-statements with same scope. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1045 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1046 | @param node reference to the AST node to be checked |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1047 | @type ast.With |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1048 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1049 | # with A() as a: |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1050 | # with B() as b: |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1051 | # print("hello") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1052 | if len(node.body) == 1 and isinstance(node.body[0], ast.With): |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1053 | withItems = [] |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1054 | for withitem in node.items + node.body[0].items: |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1055 | withItems.append(f"{unparse(withitem)}") |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1056 | mergedWith = f"with {', '.join(withItems)}:" |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1057 | self.__error(node, "Y-117", mergedWith) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1058 | |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1059 | def __check118(self, node): |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1060 | """ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1061 | Private method to check for usages of "key in dict.keys()". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1062 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1063 | @param node reference to the AST node to be checked |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1064 | @type ast.Compare or ast.For |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1065 | """ |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1066 | # Pattern 1: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1067 | # |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1068 | # if key in dict.keys(): |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1069 | # # do something |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1070 | # |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1071 | # Pattern 2: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1072 | # |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1073 | # for key in dict.keys(): |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1074 | # # do something |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1075 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1076 | isinstance(node, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1077 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1078 | and isinstance(node.ops[0], ast.In) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1079 | and len(node.comparators) == 1 |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1080 | ): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1081 | callNode = node.comparators[0] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1082 | elif isinstance(node, ast.For): |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1083 | callNode = node.iter |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1084 | else: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1085 | callNode = None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1086 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1087 | if not isinstance(callNode, ast.Call): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1088 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1089 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1090 | attrNode = callNode.func |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1091 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1092 | isinstance(callNode.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1093 | and callNode.func.attr == "keys" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1094 | and isinstance(callNode.func.ctx, ast.Load) |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1095 | ): |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1096 | if isinstance(node, ast.Compare): |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1097 | keyStr = unparse(node.left) |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1098 | else: |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1099 | keyStr = unparse(node.target) |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1100 | dictStr = unparse(attrNode.value) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1101 | self.__error(node, "Y-118", keyStr, dictStr) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1102 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1103 | def __check119(self, node): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1104 | """ |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1105 | Private method to check for classes that should be "dataclasses". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1106 | |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1107 | @param node reference to the AST node to be checked |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1108 | @type ast.ClassDef |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1109 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1110 | if len(node.decorator_list) == 0 and len(node.bases) == 0: |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1111 | dataclassFunctions = [ |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1112 | "__init__", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1113 | "__eq__", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1114 | "__hash__", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1115 | "__repr__", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1116 | "__str__", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1117 | ] |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1118 | hasOnlyConstructorMethod = True |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1119 | for bodyElement in node.body: |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1120 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1121 | isinstance(bodyElement, ast.FunctionDef) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1122 | and bodyElement.name not in dataclassFunctions |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1123 | ): |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1124 | hasOnlyConstructorMethod = False |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1125 | break |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1126 | |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1127 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1128 | hasOnlyConstructorMethod |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1129 | and sum(1 for el in node.body if isinstance(el, ast.FunctionDef)) > 0 |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
1130 | ): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1131 | self.__error(node, "Y-119", node.name) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1132 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1133 | def __check120_121(self, node): |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1134 | """ |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1135 | Private method to check for classes that inherit from object. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1136 | |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1137 | @param node reference to the AST node to be checked |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1138 | @type ast.ClassDef |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1139 | """ |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1140 | # class FooBar(object): |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1141 | # ... |
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1142 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1143 | len(node.bases) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1144 | and isinstance(node.bases[0], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1145 | and node.bases[0].id == "object" |
8194
b925628bf91f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8192
diff
changeset
|
1146 | ): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1147 | self.__error(node, "Y-120", node.name) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1148 | |
8210
b5903eaa7a7b
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8209
diff
changeset
|
1149 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1150 | len(node.bases) > 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1151 | and isinstance(node.bases[-1], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1152 | and node.bases[-1].id == "object" |
8210
b5903eaa7a7b
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8209
diff
changeset
|
1153 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1154 | self.__error( |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1155 | node, "Y-121", node.name, ", ".join(b.id for b in node.bases[:-1]) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1156 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1157 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1158 | def __check122(self, node): |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1159 | """ |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1160 | Private method to check for all if-blocks which only check if a key |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1161 | is in a dictionary. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1162 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1163 | @param node reference to the AST node to be checked |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1164 | @type ast.If |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1165 | """ |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1166 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1167 | isinstance(node.test, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1168 | and len(node.test.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1169 | and isinstance(node.test.ops[0], ast.In) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1170 | and len(node.body) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1171 | and len(node.orelse) == 0 |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1172 | ) and ( |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1173 | # We might still be left with a check if a value is in a list or |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1174 | # in the body the developer might remove the element from the list. |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1175 | # We need to have a look at the body. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1176 | isinstance(node.body[0], ast.Assign) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1177 | and isinstance(node.body[0].value, ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1178 | and len(node.body[0].targets) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1179 | and isinstance(node.body[0].targets[0], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1180 | and isinstance(node.body[0].value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1181 | and isinstance(node.test.comparators[0], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1182 | and node.body[0].value.value.id == node.test.comparators[0].id |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1183 | ): |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1184 | key = unparse(node.test.left) |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1185 | dictname = unparse(node.test.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1186 | self.__error(node, "Y-122", dictname, key) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1187 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1188 | def __check123(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1189 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1190 | Private method to check for complicated dictionary access with default value. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1191 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1192 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1193 | @type ast.If |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1194 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1195 | isPattern1 = ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1196 | len(node.body) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1197 | and isinstance(node.body[0], ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1198 | and len(node.body[0].targets) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1199 | and isinstance(node.body[0].value, ast.Subscript) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1200 | and len(node.orelse) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1201 | and isinstance(node.orelse[0], ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1202 | and len(node.orelse[0].targets) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1203 | and isinstance(node.test, ast.Compare) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1204 | and len(node.test.ops) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1205 | and isinstance(node.test.ops[0], ast.In) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1206 | ) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1207 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1208 | # just like pattern_1, but using NotIn and reversing if/else |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1209 | isPattern2 = ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1210 | len(node.body) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1211 | and isinstance(node.body[0], ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1212 | and len(node.orelse) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1213 | and isinstance(node.orelse[0], ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1214 | and isinstance(node.orelse[0].value, ast.Subscript) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1215 | and isinstance(node.test, ast.Compare) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1216 | and len(node.test.ops) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1217 | and isinstance(node.test.ops[0], ast.NotIn) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1218 | ) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1219 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1220 | if isPattern1: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1221 | key = node.test.left |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1222 | if unparse(key) != unparse(node.body[0].value.slice): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1223 | return |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1224 | assignToIfBody = node.body[0].targets[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1225 | assignToElse = node.orelse[0].targets[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1226 | if unparse(assignToIfBody) != unparse(assignToElse): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1227 | return |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1228 | dictName = node.test.comparators[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1229 | defaultValue = node.orelse[0].value |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1230 | valueNode = node.body[0].targets[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1231 | keyStr = unparse(key) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1232 | dictStr = unparse(dictName) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1233 | defaultStr = unparse(defaultValue) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1234 | valueStr = unparse(valueNode) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1235 | elif isPattern2: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1236 | key = node.test.left |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1237 | if unparse(key) != unparse(node.orelse[0].value.slice): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1238 | return |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1239 | dictName = node.test.comparators[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1240 | defaultValue = node.body[0].value |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1241 | valueNode = node.body[0].targets[0] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1242 | keyStr = unparse(key) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1243 | dictStr = unparse(dictName) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1244 | defaultStr = unparse(defaultValue) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1245 | valueStr = unparse(valueNode) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1246 | else: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1247 | return |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1248 | self.__error(node, "Y-123", valueStr, dictStr, keyStr, defaultStr) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1249 | |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1250 | def __check181(self, node): |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1251 | """ |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1252 | Private method to check for assignments that could be converted into |
8204
fd477cded1c1
Corrected some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8202
diff
changeset
|
1253 | an augmented assignment. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1254 | |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1255 | @param node reference to the AST node to be checked |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1256 | @type ast.Assign |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1257 | """ |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1258 | # a = a - b |
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1259 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1260 | len(node.targets) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1261 | and isinstance(node.targets[0], ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1262 | and isinstance(node.value, ast.BinOp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1263 | and isinstance(node.value.left, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1264 | and node.value.left.id == node.targets[0].id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1265 | and not isinstance(node.value.right, ast.Tuple) |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
1266 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1267 | newNode = ast.AugAssign(node.targets[0], node.value.op, node.value.right) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1268 | self.__error(node, "Y-181", unparse(newNode), unparse(node)) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1269 | |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1270 | def __check182(self, node): |
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1271 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8216
diff
changeset
|
1272 | Private method to check for calls of type 'super()' that could |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1273 | be shortened to 'super()'. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1274 | |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1275 | @param node reference to the AST node to be checked |
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1276 | @type ast.Call |
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1277 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8216
diff
changeset
|
1278 | # super() |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1279 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1280 | self.__classDefinitionStack |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1281 | and isinstance(node.func, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1282 | and node.func.id == "super" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1283 | and len(node.args) == 2 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1284 | and all(isinstance(arg, ast.Name) for arg in node.args) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1285 | and node.args[0].id == self.__classDefinitionStack[-1] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1286 | and node.args[1].id == "self" |
8209
14470a65a52e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
1287 | ): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1288 | self.__error(node, "Y-182", unparse(node)) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1289 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1290 | def __check201(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1291 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1292 | Private method to check for calls where an unary 'not' is used for |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1293 | an unequality. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1294 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1295 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1296 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1297 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1298 | # not a == b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1299 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1300 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1301 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1302 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1303 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1304 | or not isinstance(node.operand.ops[0], ast.Eq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1305 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1306 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1307 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1308 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1309 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1310 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1311 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1312 | self.__error(node, "Y-201", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1313 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1314 | def __check202(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1315 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1316 | Private method to check for calls where an unary 'not' is used for |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1317 | an equality. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1318 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1319 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1320 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1321 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1322 | # not a != b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1323 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1324 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1325 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1326 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1327 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1328 | or not isinstance(node.operand.ops[0], ast.NotEq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1329 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1330 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1331 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1332 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1333 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1334 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1335 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1336 | self.__error(node, "Y-202", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1337 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1338 | def __check203(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1339 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1340 | Private method to check for calls where an unary 'not' is used for |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1341 | an in-check. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1342 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1343 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1344 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1345 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1346 | # not a in b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1347 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1348 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1349 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1350 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1351 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1352 | or not isinstance(node.operand.ops[0], ast.In) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1353 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1354 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1355 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1356 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1357 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1358 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1359 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1360 | self.__error(node, "Y-203", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1361 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1362 | def __check204(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1363 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1364 | Private method to check for calls of the type "not (a < b)". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1365 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1366 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1367 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1368 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1369 | # not a < b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1370 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1371 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1372 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1373 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1374 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1375 | or not isinstance(node.operand.ops[0], ast.Lt) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1376 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1377 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1378 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1379 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1380 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1381 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1382 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1383 | self.__error(node, "Y-204", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1384 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1385 | def __check205(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1386 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1387 | Private method to check for calls of the type "not (a <= b)". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1388 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1389 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1390 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1391 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1392 | # not a <= b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1393 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1394 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1395 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1396 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1397 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1398 | or not isinstance(node.operand.ops[0], ast.LtE) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1399 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1400 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1401 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1402 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1403 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1404 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1405 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1406 | self.__error(node, "Y-205", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1407 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1408 | def __check206(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1409 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1410 | Private method to check for calls of the type "not (a > b)". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1411 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1412 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1413 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1414 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1415 | # not a > b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1416 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1417 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1418 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1419 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1420 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1421 | or not isinstance(node.operand.ops[0], ast.Gt) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1422 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1423 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1424 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1425 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1426 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1427 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1428 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1429 | self.__error(node, "Y-206", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1430 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1431 | def __check207(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1432 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1433 | Private method to check for calls of the type "not (a >= b)". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1434 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1435 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1436 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1437 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1438 | # not a >= b |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1439 | if not ( |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1440 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1441 | not isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1442 | or not isinstance(node.operand, ast.Compare) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1443 | or len(node.operand.ops) != 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1444 | or not isinstance(node.operand.ops[0], ast.GtE) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1445 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1446 | or isinstance(node.parent, ast.If) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1447 | and self.__isExceptionCheck(node.parent) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1448 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1449 | comparison = node.operand |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1450 | left = unparse(comparison.left) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1451 | right = unparse(comparison.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1452 | self.__error(node, "Y-207", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1453 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1454 | def __check208(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1455 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1456 | Private method to check for calls of the type "not (not a)". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1457 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1458 | @param node reference to the UnaryOp node |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1459 | @type ast.UnaryOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1460 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1461 | # not (not a) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1462 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1463 | isinstance(node.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1464 | and isinstance(node.operand, ast.UnaryOp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1465 | and isinstance(node.operand.op, ast.Not) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1466 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1467 | var = unparse(node.operand.operand) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1468 | self.__error(node, "Y-208", var) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1469 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1470 | def __check211(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1471 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1472 | Private method to check for calls of the type "True if a else False". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1473 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1474 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1475 | @type ast.IfExp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1476 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1477 | # True if a else False |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1478 | if ( |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1479 | isinstance(node.body, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1480 | and node.body.value is True |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1481 | and isinstance(node.orelse, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1482 | and node.orelse.value is False |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1483 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1484 | cond = unparse(node.test) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1485 | if isinstance(node.test, ast.Name): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1486 | newCond = "bool({0})".format(cond) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1487 | else: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1488 | newCond = cond |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1489 | self.__error(node, "Y-211", cond, newCond) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1490 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1491 | def __check212(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1492 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1493 | Private method to check for calls of the type "False if a else True". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1494 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1495 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1496 | @type ast.IfExp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1497 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1498 | # False if a else True |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1499 | if ( |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1500 | isinstance(node.body, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1501 | and node.body.value is False |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1502 | and isinstance(node.orelse, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1503 | and node.orelse.value is True |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1504 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1505 | cond = unparse(node.test) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1506 | if isinstance(node.test, ast.Name): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1507 | newCond = "not {0}".format(cond) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1508 | else: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1509 | if len(node.test.ops) == 1: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1510 | newCond = unparse(self.__negateTest(node.test)) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1511 | else: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1512 | newCond = "not ({0})".format(cond) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1513 | self.__error(node, "Y-212", cond, newCond) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1514 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1515 | def __check213(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1516 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1517 | Private method to check for calls of the type "b if not a else a". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1518 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1519 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1520 | @type ast.IfExp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1521 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1522 | # b if not a else a |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1523 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1524 | isinstance(node.test, ast.UnaryOp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1525 | and isinstance(node.test.op, ast.Not) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1526 | and self.__isSameExpression(node.test.operand, node.orelse) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1527 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1528 | a = unparse(node.test.operand) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1529 | b = unparse(node.body) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1530 | self.__error(node, "Y-213", a, b) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1531 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1532 | def __check221(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1533 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1534 | Private method to check for calls of the type "a and not a". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1535 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1536 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1537 | @type ast.BoolOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1538 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1539 | # a and not a |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1540 | if isinstance(node.op, ast.And) and len(node.values) >= 2: |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1541 | # We have a boolean And. Let's make sure there is two times the |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1542 | # same expression, but once with a "not" |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1543 | negatedExpressions = [] |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1544 | nonNegatedExpressions = [] |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1545 | for exp in node.values: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1546 | if isinstance(exp, ast.UnaryOp) and isinstance(exp.op, ast.Not): |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1547 | negatedExpressions.append(exp.operand) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1548 | else: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1549 | nonNegatedExpressions.append(exp) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1550 | for negatedExpression in negatedExpressions: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1551 | for nonNegatedExpression in nonNegatedExpressions: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1552 | if self.__isSameExpression(negatedExpression, nonNegatedExpression): |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1553 | negExp = unparse(negatedExpression) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1554 | self.__error(node, "Y-221", negExp) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1555 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1556 | def __check222(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1557 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1558 | Private method to check for calls of the type "a or not a". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1559 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1560 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1561 | @type ast.BoolOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1562 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1563 | # a or not a |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1564 | if isinstance(node.op, ast.Or) and len(node.values) >= 2: |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1565 | # We have a boolean And. Let's make sure there is two times the |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1566 | # same expression, but once with a "not" |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1567 | negatedExpressions = [] |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1568 | nonNegatedExpressions = [] |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1569 | for exp in node.values: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1570 | if isinstance(exp, ast.UnaryOp) and isinstance(exp.op, ast.Not): |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1571 | negatedExpressions.append(exp.operand) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1572 | else: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1573 | nonNegatedExpressions.append(exp) |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1574 | for negatedExpression in negatedExpressions: |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1575 | for nonNegatedExpression in nonNegatedExpressions: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1576 | if self.__isSameExpression(negatedExpression, nonNegatedExpression): |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1577 | negExp = unparse(negatedExpression) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1578 | self.__error(node, "Y-222", negExp) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1579 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1580 | def __check223(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1581 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1582 | Private method to check for calls of the type "... or True". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1583 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1584 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1585 | @type ast.BoolOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1586 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1587 | # a or True |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1588 | if isinstance(node.op, ast.Or): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1589 | for exp in node.values: |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1590 | if isinstance(exp, ast.Constant) and exp.value is True: |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1591 | self.__error(node, "Y-223") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1592 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1593 | def __check224(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1594 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1595 | Private method to check for calls of the type "... and False". |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1596 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1597 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1598 | @type ast.BoolOp |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1599 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1600 | # a and False |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1601 | if isinstance(node.op, ast.And): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1602 | for exp in node.values: |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1603 | if isinstance(exp, ast.Constant) and exp.value is False: |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1604 | self.__error(node, "Y-224") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1605 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1606 | def __check301(self, node): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1607 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1608 | Private method to check for Yoda conditions. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1609 | |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1610 | @param node reference to the AST node to be checked |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1611 | @type ast.Compare |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1612 | """ |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1613 | # 42 == age |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1614 | if ( |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1615 | isinstance(node.left, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1616 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1617 | and isinstance(node.ops[0], ast.Eq) |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1618 | ): |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1619 | left = unparse(node.left) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1620 | isStr = isinstance(node.left, ast.Constant) and isinstance( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1621 | node.left.value, str |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1622 | ) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1623 | if isStr: |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1624 | left = f"'{left}'" |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
1625 | right = unparse(node.comparators[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1626 | self.__error(node, "Y-301", left, right) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1627 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1628 | def __check401(self, node): |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1629 | """ |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1630 | Private method to check for bare boolean function arguments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1631 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1632 | @param node reference to the AST node to be checked |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1633 | @type ast.Call |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1634 | """ |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1635 | # foo(a, b, True) |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1636 | hasBareBool = any( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1637 | isinstance(callArg, ast.Constant) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1638 | and (callArg.value is True or callArg.value is False) |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1639 | for callArg in node.args |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1640 | ) |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1641 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1642 | isException = isinstance(node.func, ast.Attribute) and node.func.attr in ["get"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1643 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1644 | if hasBareBool and not isException: |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1645 | self.__error(node, "Y-401") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1646 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1647 | def __check402(self, node): |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1648 | """ |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1649 | Private method to check for bare numeric function arguments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1650 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1651 | @param node reference to the AST node to be checked |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1652 | @type ast.Call |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1653 | """ |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1654 | # foo(a, b, 123123) |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1655 | hasBareNumeric = any( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1656 | isinstance(callArg, ast.Constant) and type(callArg.value) in (float, int) |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1657 | for callArg in node.args |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1658 | ) |
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1659 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1660 | isException = isinstance(node.func, ast.Name) and node.func.id == "range" |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1661 | isException = isException or ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1662 | isinstance(node.func, ast.Attribute) and node.func.attr in ("get", "insert") |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1663 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1664 | |
8211
8322a6f219ff
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8210
diff
changeset
|
1665 | if hasBareNumeric and not isException: |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1666 | self.__error(node, "Y-402") |
8189 | 1667 | |
11141
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1668 | def __check411(self, node): |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1669 | """ |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1670 | Private method to check for nested f-strings. |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1671 | |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1672 | Note: This method is adapted from flake8-nested-fstrings v1.1.0. |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1673 | |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1674 | @param node reference to the AST node to be checked |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1675 | @type ast.JoinedStr or ast.expr |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1676 | """ |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1677 | for fieldName, value in ast.iter_fields(node): |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1678 | if fieldName == "values": |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1679 | for innerNode in value: |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1680 | self.__check411(innerNode) |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1681 | |
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1682 | if fieldName == "value" and isinstance(value, ast.JoinedStr): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1683 | self.__error(node, "Y-411") |
11141
2f5f73c51c7c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
1684 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1685 | def __check901(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1686 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1687 | Private method to check for unnecessary bool conversion. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1688 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1689 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1690 | @type ast.Call |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1691 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1692 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1693 | isinstance(node.func, ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1694 | and node.func.id == "bool" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1695 | and len(node.args) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1696 | and isinstance(node.args[0], ast.Compare) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1697 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1698 | actual = unparse(node) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1699 | expected = unparse(node.args[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1700 | self.__error(node, "Y-901", expected, actual) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1701 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1702 | def __check904(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1703 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1704 | Private method to check for dictionary initialization. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1705 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1706 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1707 | @type ast.Assign |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1708 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1709 | # a = {}; a['b'] = 'c' |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1710 | n2 = node.next_sibling |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1711 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1712 | isinstance(node.value, ast.Dict) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1713 | and isinstance(n2, ast.Assign) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1714 | and len(n2.targets) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1715 | and len(node.targets) == 1 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1716 | and isinstance(n2.targets[0], ast.Subscript) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1717 | and isinstance(n2.targets[0].value, ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1718 | and isinstance(node.targets[0], ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1719 | and n2.targets[0].value.id == node.targets[0].id |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1720 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1721 | dictName = unparse(node.targets[0]) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1722 | if not self.__expressionUsesVariable(n2.value, dictName): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1723 | self.__error(node, "Y-904", dictName) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1724 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1725 | def __check905(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1726 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1727 | Private method to check for list initialization by splitting a string. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1728 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1729 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1730 | @type ast.Call |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1731 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1732 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1733 | isinstance(node.func, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1734 | and node.func.attr == "split" |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1735 | and isinstance(node.func.value, ast.Constant) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1736 | ): |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1737 | value = node.func.value.value |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1738 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1739 | expected = json.dumps(value.split()) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1740 | actual = unparse(node.func.value) + ".split()" |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1741 | self.__error(node, "Y-905", expected, actual) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1742 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1743 | def __check906(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1744 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1745 | Private method to check for unnecessary nesting of os.path.join(). |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1746 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1747 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1748 | @type ast.Call |
11148
15e30f0c76a8
Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11147
diff
changeset
|
1749 | """ # __IGNORE_WARNING_D-234r__ |
9786
f94b530722af
Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1750 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1751 | def getOsPathJoinArgs(node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1752 | names = [] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1753 | for arg in node.args: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1754 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1755 | isinstance(arg, ast.Call) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1756 | and isinstance(arg.func, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1757 | and isinstance(arg.func.value, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1758 | and isinstance(arg.func.value.value, ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1759 | and arg.func.value.value.id == "os" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1760 | and arg.func.value.attr == "path" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1761 | and arg.func.attr == "join" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1762 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1763 | names += getOsPathJoinArgs(arg) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1764 | elif isinstance(arg, ast.Name): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1765 | names.append(arg.id) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1766 | elif AstUtilities.isString(arg): |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1767 | names.append(f"'{arg.value}'") |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1768 | return names |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1769 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1770 | if ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1771 | isinstance(node.func, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1772 | and isinstance(node.func.value, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1773 | and isinstance(node.func.value.value, ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1774 | and node.func.value.value.id == "os" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1775 | and node.func.value.attr == "path" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1776 | and node.func.attr == "join" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1777 | and len(node.args) == 2 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1778 | and any( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1779 | ( |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1780 | isinstance(arg, ast.Call) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1781 | and isinstance(arg.func, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1782 | and isinstance(arg.func.value, ast.Attribute) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1783 | and isinstance(arg.func.value.value, ast.Name) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1784 | and arg.func.value.value.id == "os" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1785 | and arg.func.value.attr == "path" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1786 | and arg.func.attr == "join" |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1787 | ) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1788 | for arg in node.args |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1789 | ) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1790 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1791 | names = getOsPathJoinArgs(node) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1792 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1793 | actual = unparse(node) |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1794 | expected = "os.path.join({0})".format(", ".join(names)) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1795 | self.__error(node, "Y-906", expected, actual) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1796 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1797 | def __check907(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1798 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1799 | Private method to check for Union type annotation with None. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1800 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1801 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1802 | @type ast.Subscript |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1803 | """ |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1804 | if isinstance(node.value, ast.Name) and node.value.id == "Union": |
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1805 | if isinstance(node.slice, ast.Index) and isinstance( |
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1806 | node.slice.value, ast.Tuple |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1807 | ): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1808 | # Python 3.8 |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1809 | tupleVar = node.slice.value |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1810 | elif isinstance(node.slice, ast.Tuple): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1811 | # Python 3.9+ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1812 | tupleVar = node.slice |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1813 | else: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1814 | return |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1815 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1816 | hasNone = False |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1817 | others = [] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1818 | for elt in tupleVar.elts: |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1819 | if isinstance(elt, ast.Constant) and elt.value is None: |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1820 | hasNone = True |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1821 | else: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1822 | others.append(elt) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1823 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1824 | if len(others) == 1 and hasNone: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1825 | type_ = unparse(others[0]) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1826 | self.__error(node, "Y-907", type_, unparse(node)) |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1827 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1828 | def __check909(self, node): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1829 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1830 | Private method to check for reflexive assignments. |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1831 | |
9277
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1832 | @param node reference to the AST node to be checked |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1833 | @type ast.Assign |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1834 | """ |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1835 | names = [] |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1836 | if isinstance(node.value, (ast.Name, ast.Subscript, ast.Tuple)): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1837 | names.append(unparse(node.value)) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1838 | for target in node.targets: |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1839 | names.append(unparse(target)) |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1840 | |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1841 | if len(names) != len(set(names)) and not isinstance(node.parent, ast.ClassDef): |
471c5a263d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1842 | srccode = unparse(node) |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1843 | self.__error(node, "Y-909", srccode) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1844 | |
10047
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1845 | def __check910(self, node): |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1846 | """ |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1847 | Private method to check for uses of 'dict.get(key, None)'. |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1848 | |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1849 | @param node reference to the AST node to be checked |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1850 | @type ast.Call |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1851 | """ |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1852 | if not ( |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1853 | isinstance(node.func, ast.Attribute) |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1854 | and node.func.attr == "get" |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1855 | and isinstance(node.func.ctx, ast.Load) |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1856 | ): |
10050
3750abc45d5e
Corrected some code style issues detected by the extended checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10047
diff
changeset
|
1857 | return |
10047
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1858 | |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1859 | # check the argument value |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1860 | if not ( |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1861 | len(node.args) == 2 |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10116
diff
changeset
|
1862 | and isinstance(node.args[1], ast.Constant) |
10047
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1863 | and node.args[1].value is None |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1864 | ): |
10050
3750abc45d5e
Corrected some code style issues detected by the extended checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10047
diff
changeset
|
1865 | return |
10047
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1866 | |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1867 | actual = unparse(node) |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1868 | func = unparse(node.func) |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1869 | key = unparse(node.args[0]) |
cc9ead6d1c46
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9786
diff
changeset
|
1870 | expected = f"{func}({key})" |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1871 | self.__error(node, "Y-910", expected, actual) |
9278
36448ca469c2
Simplified some code iaw. recommendations of the extended style checker and reformatted the code with black.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9277
diff
changeset
|
1872 | |
10355
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1873 | def __check911(self, node): |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1874 | """ |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1875 | Private method to check for the expression "zip(_.keys(), _.values())". |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1876 | |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1877 | @param node reference to the AST node to be checked |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1878 | @type ast.Call |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1879 | """ |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1880 | if isinstance(node, ast.Call) and ( |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1881 | isinstance(node.func, ast.Name) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1882 | and node.func.id == "zip" |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1883 | and len(node.args) == 2 |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1884 | ): |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1885 | firstArg, secondArg = node.args |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1886 | if ( |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1887 | isinstance(firstArg, ast.Call) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1888 | and isinstance(firstArg.func, ast.Attribute) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1889 | and isinstance(firstArg.func.value, ast.Name) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1890 | and firstArg.func.attr == "keys" |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1891 | and isinstance(secondArg, ast.Call) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1892 | and isinstance(secondArg.func, ast.Attribute) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1893 | and isinstance(secondArg.func.value, ast.Name) |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1894 | and secondArg.func.attr == "values" |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1895 | and firstArg.func.value.id == secondArg.func.value.id |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1896 | ): |
11150
73d80859079c
Code Style Checkers
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11148
diff
changeset
|
1897 | self.__error(node, "Y-911", firstArg.func.value.id) |
10355
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1898 | |
f3187412ecf4
Updated the 'Simplify' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
1899 | |
8189 | 1900 | # |
11148
15e30f0c76a8
Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11147
diff
changeset
|
1901 | # eflag: noqa = M-891 |