10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1
|
# -*- coding: utf-8 -*- |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2
|
|
11090
|
3
|
# Copyright (c) 2021 - 2025 Detlev Offenbach <detlev@die-offenbachs.de> |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7
|
Module implementing a checker for import statements. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10
|
import ast |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11
|
import re |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12
|
|
11150
|
13
|
from CodeStyleTopicChecker import CodeStyleTopicChecker |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14
|
|
11150
|
15
|
|
|
16
|
class NameOrderChecker(CodeStyleTopicChecker): |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18
|
Class implementing a checker for name ordering. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20
|
Note: Name ordering is checked for import statements, the '__all__' statement |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21
|
and exception names of exception handlers. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24
|
Codes = [ |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25
|
## Imports order |
11150
|
26
|
"NO-101", |
|
27
|
"NO-102", |
|
28
|
"NO-103", |
|
29
|
"NO-104", |
|
30
|
"NO-105", |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31
|
] |
11150
|
32
|
Category = "NO" |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34
|
def __init__(self, source, filename, tree, select, ignore, expected, repeat, args): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36
|
Constructor |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38
|
@param source source code to be checked |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40
|
@param filename name of the source file |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42
|
@param tree AST tree of the source code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43
|
@type ast.Module |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44
|
@param select list of selected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46
|
@param ignore list of codes to be ignored |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48
|
@param expected list of expected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50
|
@param repeat flag indicating to report each occurrence of a code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51
|
@type bool |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52
|
@param args dictionary of arguments for the various checks |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53
|
@type dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54
|
""" |
11150
|
55
|
super().__init__( |
|
56
|
NameOrderChecker.Category, |
|
57
|
source, |
|
58
|
filename, |
|
59
|
tree, |
|
60
|
select, |
|
61
|
ignore, |
|
62
|
expected, |
|
63
|
repeat, |
|
64
|
args, |
11142
|
65
|
) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67
|
# parameters for import sorting |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68
|
if args["SortOrder"] == "native": |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69
|
self.__sortingFunction = sorted |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71
|
# naturally is the default sort order |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72
|
self.__sortingFunction = self.__naturally |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73
|
self.__sortCaseSensitive = args["SortCaseSensitive"] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75
|
checkersWithCodes = [ |
11150
|
76
|
(self.__checkNameOrder, ("NO-101", "NO-102", "NO-103", "NO-104", "NO-105")), |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77
|
] |
11150
|
78
|
self._initializeCheckers(checkersWithCodes) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80
|
####################################################################### |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81
|
## Name Order |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82
|
## |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83
|
## adapted from: flake8-alphabetize v0.0.21 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84
|
####################################################################### |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86
|
def __checkNameOrder(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87
|
""" |
10052
|
88
|
Private method to check the order of import statements and handled exceptions. |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90
|
from .ImportNode import ImportNode |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
92
|
errors = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93
|
imports = [] |
11150
|
94
|
importNodes, aListNode, eListNodes = self.__findNodes(self.tree) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96
|
# check for an error in '__all__' |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97
|
allError = self.__findErrorInAll(aListNode) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98
|
if allError is not None: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99
|
errors.append(allError) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101
|
errors.extend(self.__findExceptionListErrors(eListNodes)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103
|
for importNode in importNodes: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104
|
if isinstance(importNode, ast.Import) and len(importNode.names) > 1: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105
|
# skip suck imports because its already handled by pycodestyle |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106
|
continue |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108
|
imports.append( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109
|
ImportNode( |
11150
|
110
|
self.args.get("ApplicationPackageNames", []), |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111
|
importNode, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112
|
self, |
11150
|
113
|
self.args.get("SortIgnoringStyle", False), |
|
114
|
self.args.get("SortFromFirst", False), |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115
|
) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116
|
) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118
|
lenImports = len(imports) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119
|
if lenImports > 0: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120
|
p = imports[0] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121
|
if p.error is not None: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122
|
errors.append(p.error) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124
|
if lenImports > 1: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125
|
for n in imports[1:]: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126
|
if n.error is not None: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127
|
errors.append(n.error) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129
|
if n == p: |
11150
|
130
|
if self.args.get("CombinedAsImports", False) or ( |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131
|
not n.asImport and not p.asImport |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132
|
): |
11150
|
133
|
errors.append((n.node, "NO-103", str(p), str(n))) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
134
|
elif n < p: |
11150
|
135
|
errors.append((n.node, "NO-101", str(n), str(p))) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137
|
p = n |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
138
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
139
|
for error in errors: |
11150
|
140
|
self.addErrorFromNode(error[0], error[1], *error[2:]) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
142
|
def __findExceptionListNodes(self, tree): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
143
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
144
|
Private method to find all exception types handled by given tree. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
145
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
146
|
@param tree reference to the ast node tree to be parsed |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
147
|
@type ast.AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
148
|
@return list of exception types |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
149
|
@rtype list of ast.Name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
150
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
151
|
nodes = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153
|
for node in ast.walk(tree): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
154
|
if isinstance(node, ast.ExceptHandler): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155
|
nodeType = node.type |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156
|
if isinstance(nodeType, (ast.List, ast.Tuple)): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157
|
nodes.append(nodeType) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
159
|
return nodes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
160
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
161
|
def __findNodes(self, tree): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
162
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
163
|
Private method to find all import and import from nodes of the given |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
164
|
tree. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
166
|
@param tree reference to the ast node tree to be parsed |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
167
|
@type ast.AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
168
|
@return tuple containing a list of import nodes, the '__all__' node and |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
169
|
exception nodes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
170
|
@rtype tuple of (ast.Import | ast.ImportFrom, ast.List | ast.Tuple, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
171
|
ast.List | ast.Tuple) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
172
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
173
|
importNodes = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
174
|
aListNode = None |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
175
|
eListNodes = self.__findExceptionListNodes(tree) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
176
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
177
|
if isinstance(tree, ast.Module): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
178
|
body = tree.body |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
179
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
180
|
for n in body: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
181
|
if isinstance(n, (ast.Import, ast.ImportFrom)): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
182
|
importNodes.append(n) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
183
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
184
|
elif isinstance(n, ast.Assign): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
185
|
for t in n.targets: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
186
|
if isinstance(t, ast.Name) and t.id == "__all__": |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
187
|
value = n.value |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
188
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
189
|
if isinstance(value, (ast.List, ast.Tuple)): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
190
|
aListNode = value |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
191
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
192
|
return importNodes, aListNode, eListNodes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
193
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
194
|
def __findErrorInAll(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
195
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
196
|
Private method to check the '__all__' node for errors. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
197
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
198
|
@param node reference to the '__all__' node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
199
|
@type ast.List or ast.Tuple |
11150
|
200
|
@return tuple containing a reference to the node, an error code and the error |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
201
|
arguments |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202
|
@rtype tuple of (ast.List | ast.Tuple, str, str) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
204
|
if node is not None: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
205
|
actualList = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
206
|
for el in node.elts: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
207
|
if isinstance(el, ast.Constant): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
208
|
actualList.append(el.value) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
209
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
210
|
# Can't handle anything that isn't a string literal |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
211
|
return None |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
212
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
213
|
expectedList = self.sorted( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
214
|
actualList, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
215
|
key=lambda k: self.moduleKey(k, subImports=True), |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
216
|
) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
217
|
if expectedList != actualList: |
11150
|
218
|
return (node, "NO-104", ", ".join(expectedList)) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
219
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
220
|
return None |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
221
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
222
|
def __findExceptionListStr(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
223
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
224
|
Private method to get the exception name out of an exception handler type node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
225
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
226
|
@param node node to be treated |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
227
|
@type ast.Name or ast.Attribute |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
228
|
@return string containing the exception name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
229
|
@rtype str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
230
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
231
|
if isinstance(node, ast.Name): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
232
|
return node.id |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
233
|
elif isinstance(node, ast.Attribute): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
234
|
return f"{self.__findExceptionListStr(node.value)}.{node.attr}" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
235
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
236
|
return "" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
237
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
238
|
def __findExceptionListErrors(self, nodes): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
239
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
240
|
Private method to check the exception node for errors. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
241
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
242
|
@param nodes list of exception nodes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
243
|
@type list of ast.List or ast.Tuple |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
244
|
@return DESCRIPTION |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
245
|
@rtype TYPE |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
246
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
247
|
errors = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
248
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
249
|
for node in nodes: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
250
|
actualList = [self.__findExceptionListStr(elt) for elt in node.elts] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
251
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
252
|
expectedList = self.sorted(actualList) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
253
|
if expectedList != actualList: |
11150
|
254
|
errors.append((node, "NO-105", ", ".join(expectedList))) |
10046
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
255
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
256
|
return errors |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
257
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
258
|
def sorted(self, toSort, key=None, reverse=False): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
259
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
260
|
Public method to sort the given list of names. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
261
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
262
|
@param toSort list of names to be sorted |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
263
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
264
|
@param key function to generate keys (defaults to None) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
265
|
@type function (optional) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
266
|
@param reverse flag indicating a reverse sort (defaults to False) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
267
|
@type bool (optional) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
268
|
@return sorted list of names |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
269
|
@rtype list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
270
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
271
|
return self.__sortingFunction(toSort, key=key, reverse=reverse) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
272
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
273
|
def __naturally(self, toSort, key=None, reverse=False): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
274
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
275
|
Private method to sort the given list of names naturally. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
276
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
277
|
Note: Natural sorting maintains the sort order of numbers (i.e. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
278
|
[Q1, Q10, Q2] is sorted as [Q1, Q2, Q10] while the Python |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
279
|
standard sort would yield [Q1, Q10, Q2]. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
280
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
281
|
@param toSort list of names to be sorted |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
282
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
283
|
@param key function to generate keys (defaults to None) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
284
|
@type function (optional) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
285
|
@param reverse flag indicating a reverse sort (defaults to False) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
286
|
@type bool (optional) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
287
|
@return sorted list of names |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
288
|
@rtype list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
289
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
290
|
if key is None: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
291
|
keyCallback = self.__naturalKeys |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
292
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
293
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
294
|
def keyCallback(text): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
295
|
return self.__naturalKeys(key(text)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
296
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
297
|
return sorted(toSort, key=keyCallback, reverse=reverse) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
298
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
299
|
def __atoi(self, text): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
300
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
301
|
Private method to convert the given text to an integer number. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
302
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
303
|
@param text text to be converted |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
304
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
305
|
@return integer number |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
306
|
@rtype int |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
307
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
308
|
return int(text) if text.isdigit() else text |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
309
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
310
|
def __naturalKeys(self, text): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
311
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
312
|
Private method to generate keys for natural sorting. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
313
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
314
|
@param text text to generate a key for |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
315
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
316
|
@return key for natural sorting |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
317
|
@rtype list of str or int |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
318
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
319
|
return [self.__atoi(c) for c in re.split(r"(\d+)", text)] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
320
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
321
|
def moduleKey(self, moduleName, subImports=False): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
322
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
323
|
Public method to generate a key for the given module name. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
324
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
325
|
@param moduleName module name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
326
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
327
|
@param subImports flag indicating a sub import like in |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
328
|
'from foo import bar, baz' (defaults to False) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
329
|
@type bool (optional) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
330
|
@return generated key |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
331
|
@rtype str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
332
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
333
|
prefix = "" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
334
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
335
|
if subImports: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
336
|
if moduleName.isupper() and len(moduleName) > 1: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
337
|
prefix = "A" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
338
|
elif moduleName[0:1].isupper(): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
339
|
prefix = "B" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
340
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
341
|
prefix = "C" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
342
|
if not self.__sortCaseSensitive: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
343
|
moduleName = moduleName.lower() |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
344
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
345
|
return f"{prefix}{moduleName}" |