Fri, 02 Apr 2021 18:13:12 +0200
Code Style Checker
- continued to implement checkers for potential code simplifications
8186 | 1 | # -*- coding: utf-8 -*- |
2 | ||
3 | # Copyright (c) 2020 - 2021 Detlev Offenbach <detlev@die-offenbachs.de> | |
4 | # | |
5 | ||
6 | ||
7 | """ | |
8 | Module implementing message translations for the code style plugin messages | |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
9 | (simplify part). |
8186 | 10 | """ |
11 | ||
12 | from PyQt5.QtCore import QCoreApplication | |
13 | ||
14 | _simplifyMessages = { | |
15 | "Y101": QCoreApplication.translate( | |
16 | "SimplifyChecker", | |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
17 | '''Multiple "isinstance()" calls which can be merged into a single ''' |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
18 | '''call for variable "{0}"'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
19 | "Y102": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
20 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
21 | '''Use a single if-statement instead of nested if-statements'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
22 | "Y103": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
23 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
24 | '''Return the condition "{0}" directly'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
25 | "Y104": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
26 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
27 | '''Use "yield from {0}"'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
28 | "Y105": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
29 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
30 | '''Use "with contextlib.suppress({0}):"'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
31 | "Y106": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
32 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
33 | '''Handle error-cases first'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
34 | "Y107": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
35 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
36 | '''Don't use return in try/except and finally'''), |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
37 | "Y108a": QCoreApplication.translate( |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
38 | "SimplifyChecker", |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
39 | '''Use ternary operator instead of if-else-block'''), |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
40 | "Y108b": QCoreApplication.translate( |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
41 | "SimplifyChecker", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
42 | '''Use ternary operator "{0} = {1} if {2} else {3}" ''' |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
43 | '''instead of if-else-block'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
44 | "Y109": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
45 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
46 | '''Use "{0} in {1}" instead of "{2}"'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
47 | "Y110": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
48 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
49 | '''Use "return any({0} for {1} in {2})"'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
50 | "Y111": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
51 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
52 | '''Use "return all({0} for {1} in {2})"'''), |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
53 | "Y112": QCoreApplication.translate( |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
54 | "SimplifyChecker", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
55 | '''Use "{0}" instead of "{1}"'''), |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
56 | "Y113": QCoreApplication.translate( |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
57 | "SimplifyChecker", |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
58 | '''Use enumerate instead of "{0}"'''), |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
59 | "Y114": QCoreApplication.translate( |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
60 | "SimplifyChecker", |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
61 | '''Use logical or ("({0}) or ({1})") and a single body'''), |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
62 | "Y115": QCoreApplication.translate( |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
63 | "SimplifyChecker", |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
64 | '''Use context handler for opening files'''), |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
65 | "Y116": QCoreApplication.translate( |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
66 | "SimplifyChecker", |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
67 | '''Use a dictionary lookup instead of 3+ if/elif-statements: ''' |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
68 | '''return {0}'''), |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
69 | "Y117": QCoreApplication.translate( |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
70 | "SimplifyChecker", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
71 | '''Use "{0}" instead of multiple with statements'''), |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
72 | "Y118": QCoreApplication.translate( |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
73 | "SimplifyChecker", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
74 | '''Use "{0} in {1}" instead of "{0} in {1}.keys()"'''), |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
75 | "Y119": QCoreApplication.translate( |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
76 | "SimplifyChecker", |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
77 | '''Use a dataclass for "class {0}"'''), |
8186 | 78 | } |
79 | ||
80 | _simplifyMessagesSampleArgs = { | |
81 | "Y101": ["foo"], | |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
82 | "Y103": ["foo != bar"], |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
83 | "Y104": ["iterable"], |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
84 | "Y105": ["Exception"], |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
85 | "Y108b": ["foo", "bar", "condition", "baz"], |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
86 | "Y109": ["foo", "[1, 42]", "foo == 1 or foo == 42"], |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
87 | "Y110": ["check", "foo", "iterable"], |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
88 | "Y111": ["check", "foo", "iterable"], |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
89 | "Y112": ["FOO", "foo"], |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
90 | "Y113": ["foo"], |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
91 | "Y114": ["foo > 42", "bar < 42"], |
8192
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
92 | "Y116": ["mapping.get(foo, 42)"], |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
93 | "Y117": ["with Foo() as foo, Bar() as bar:"], |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
94 | "Y118": ["foo", "bar_dict"], |
e1157bd8b4c2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8191
diff
changeset
|
95 | "Y119": ["Foo"] |
8186 | 96 | } |