Sat, 06 Jun 2020 19:42:15 +0200
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
7360
9190402e4505
Updated copyright for 2020.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7247
diff
changeset
|
3 | # Copyright (c) 2019 - 2020 Detlev Offenbach <detlev@die-offenbachs.de> |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for function type annotations. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10 | import sys |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11 | import ast |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14 | class AnnotationsChecker(object): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16 | Class implementing a checker for function type annotations. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18 | Codes = [ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19 | ## Function Annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20 | "A001", "A002", "A003", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22 | ## Method Annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23 | "A101", "A102", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25 | ## Return Annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
26 | "A201", "A202", "A203", "A204", "A205", "A206", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27 | |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
28 | ## Annotation Coverage |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
29 | "A881", |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
30 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
31 | ## Annotation Complexity |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
32 | "A891", |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
33 | |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34 | ## Syntax Error |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35 | "A999", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36 | ] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37 | |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
38 | def __init__(self, source, filename, select, ignore, expected, repeat, |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
39 | args): |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41 | Constructor |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43 | @param source source code to be checked |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45 | @param filename name of the source file |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47 | @param select list of selected codes |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49 | @param ignore list of codes to be ignored |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51 | @param expected list of expected codes |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53 | @param repeat flag indicating to report each occurrence of a code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54 | @type bool |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
55 | @param args dictionary of arguments for the annotation checks |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
56 | @type dict |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58 | self.__select = tuple(select) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59 | self.__ignore = ('',) if select else tuple(ignore) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60 | self.__expected = expected[:] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61 | self.__repeat = repeat |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62 | self.__filename = filename |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63 | self.__source = source[:] |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
64 | self.__args = args |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66 | # statistics counters |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67 | self.counters = {} |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69 | # collection of detected errors |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70 | self.errors = [] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72 | checkersWithCodes = [ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73 | ( |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74 | self.__checkFunctionAnnotations, |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75 | ("A001", "A002", "A003", "A101", "A102", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76 | "A201", "A202", "A203", "A204", "A205", "A206",) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77 | ), |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
78 | (self.__checkAnnotationsCoverage, ("A881",)), |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
79 | (self.__checkAnnotationComplexity, ("A891",)), |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80 | ] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81 | |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
82 | self.__defaultArgs = { |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
83 | "MinimumCoverage": 75, # % of type annotation coverage |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
84 | "MaximumComplexity": 3, |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
85 | } |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
86 | |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87 | self.__checkers = [] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
88 | for checker, codes in checkersWithCodes: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89 | if any(not (code and self.__ignoreCode(code)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90 | for code in codes): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91 | self.__checkers.append(checker) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
92 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93 | def __ignoreCode(self, code): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
94 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95 | Private method to check if the message code should be ignored. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97 | @param code message code to check for |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99 | @return flag indicating to ignore the given code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100 | @rtype bool |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102 | return (code.startswith(self.__ignore) and |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103 | not code.startswith(self.__select)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105 | def __error(self, lineNumber, offset, code, *args): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107 | Private method to record an issue. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109 | @param lineNumber line number of the issue |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110 | @type int |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111 | @param offset position within line of the issue |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112 | @type int |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
113 | @param code message code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
114 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115 | @param args arguments for the message |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116 | @type list |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118 | if self.__ignoreCode(code): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121 | if code in self.counters: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122 | self.counters[code] += 1 |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124 | self.counters[code] = 1 |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126 | # Don't care about expected codes |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127 | if code in self.__expected: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130 | if code and (self.counters[code] == 1 or self.__repeat): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131 | # record the issue with one based line number |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132 | self.errors.append( |
7610
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
133 | { |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
134 | "file": self.__filename, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
135 | "line": lineNumber + 1, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
136 | "offset": offset, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
137 | "code": code, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
138 | "args": args, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
139 | } |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
140 | ) |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
142 | def __reportInvalidSyntax(self): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
143 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
144 | Private method to report a syntax error. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
145 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
146 | exc_type, exc = sys.exc_info()[:2] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
147 | if len(exc.args) > 1: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
148 | offset = exc.args[1] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
149 | if len(offset) > 2: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
150 | offset = offset[1:3] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
151 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152 | offset = (1, 0) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153 | self.__error(offset[0] - 1, offset[1] or 0, |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
154 | 'A999', exc_type.__name__, exc.args[0]) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156 | def __generateTree(self): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158 | Private method to generate an AST for our source. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
159 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
160 | @return generated AST |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
161 | @rtype ast.Module |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
162 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
163 | source = "".join(self.__source) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
164 | # Check type for py2: if not str it's unicode |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165 | if sys.version_info[0] == 2: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
166 | try: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
167 | source = source.encode('utf-8') |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
168 | except UnicodeError: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
169 | pass |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
170 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
171 | return compile(source, self.__filename, 'exec', ast.PyCF_ONLY_AST) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
172 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
173 | def run(self): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
174 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
175 | Public method to check the given source against annotation issues. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
176 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
177 | if not self.__filename: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
178 | # don't do anything, if essential data is missing |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
179 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
180 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
181 | if not self.__checkers: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
182 | # don't do anything, if no codes were selected |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
183 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
184 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
185 | try: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
186 | self.__tree = self.__generateTree() |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
187 | except (SyntaxError, TypeError): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
188 | self.__reportInvalidSyntax() |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
189 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
190 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
191 | for check in self.__checkers: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
192 | check() |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
193 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
194 | def __checkFunctionAnnotations(self): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
195 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
196 | Private method to check for function annotation issues. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
197 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
198 | visitor = FunctionVisitor(self.__source) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
199 | visitor.visit(self.__tree) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
200 | for issue in visitor.issues: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
201 | node = issue[0] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202 | reason = issue[1] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203 | params = issue[2:] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
204 | self.__error(node.lineno - 1, node.col_offset, reason, *params) |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
205 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
206 | def __checkAnnotationsCoverage(self): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
207 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
208 | Private method to check for function annotation coverage. |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
209 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
210 | minAnnotationsCoverage = self.__args.get( |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
211 | "MinimumCoverage", self.__defaultArgs["MinimumCoverage"]) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
212 | if minAnnotationsCoverage == 0: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
213 | # 0 means it is switched off |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
214 | return |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
215 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
216 | functionDefs = [ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
217 | f for f in ast.walk(self.__tree) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
218 | if isinstance(f, (ast.AsyncFunctionDef, ast.FunctionDef)) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
219 | ] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
220 | if not functionDefs: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
221 | # no functions/methods at all |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
222 | return |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
223 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
224 | functionDefAnnotationsInfo = [ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
225 | hasTypeAnnotations(f) for f in functionDefs |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
226 | ] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
227 | annotationsCoverage = int( |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
228 | len(list(filter(None, functionDefAnnotationsInfo))) / |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
229 | len(functionDefAnnotationsInfo) * 100 |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
230 | ) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
231 | if annotationsCoverage < minAnnotationsCoverage: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
232 | self.__error(0, 0, "A881", annotationsCoverage) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
233 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
234 | def __checkAnnotationComplexity(self): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
235 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
236 | Private method to check the type annotation complexity. |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
237 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
238 | maxAnnotationComplexity = self.__args.get( |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
239 | "MaximumComplexity", self.__defaultArgs["MaximumComplexity"]) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
240 | typeAnnotations = [] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
241 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
242 | functionDefs = [ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
243 | f for f in ast.walk(self.__tree) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
244 | if isinstance(f, (ast.AsyncFunctionDef, ast.FunctionDef)) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
245 | ] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
246 | for functionDef in functionDefs: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
247 | typeAnnotations += list(filter( |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
248 | None, [a.annotation for a in functionDef.args.args])) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
249 | if functionDef.returns: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
250 | typeAnnotations.append(functionDef.returns) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
251 | typeAnnotations += [a.annotation for a in ast.walk(self.__tree) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
252 | if isinstance(a, ast.AnnAssign) and a.annotation] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
253 | for annotation in typeAnnotations: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
254 | complexity = getAnnotationComplexity(annotation) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
255 | if complexity > maxAnnotationComplexity: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
256 | self.__error(annotation.lineno - 1, annotation.col_offset, |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
257 | "A891", complexity, maxAnnotationComplexity) |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
258 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
259 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
260 | class FunctionVisitor(ast.NodeVisitor): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
261 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
262 | Class implementing a node visitor to check function annotations. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
263 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
264 | Note: this class is modelled after flake8-annotations checker. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
265 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
266 | def __init__(self, sourceLines): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
267 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
268 | Constructor |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
269 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
270 | @param sourceLines lines of source code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
271 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
272 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
273 | super(FunctionVisitor, self).__init__() |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
274 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
275 | self.__sourceLines = sourceLines |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
276 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
277 | self.issues = [] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
278 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
279 | def visit_FunctionDef(self, node): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
280 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
281 | Public method to handle a function or method definition. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
282 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
283 | @param node reference to the node to be processed |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
284 | @type ast.FunctionDef |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
285 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
286 | self.__checkFunctionNode(node) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
287 | self.generic_visit(node) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
288 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
289 | def visit_AsyncFunctionDef(self, node): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
290 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
291 | Public method to handle an async function or method definition. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
292 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
293 | @param node reference to the node to be processed |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
294 | @type ast.AsyncFunctionDef |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
295 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
296 | self.__checkFunctionNode(node) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
297 | self.generic_visit(node) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
298 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
299 | def visit_ClassDef(self, node): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
300 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
301 | Public method to handle class definitions. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
302 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
303 | @param node reference to the node to be processed |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
304 | @type ast.ClassDef |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
305 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
306 | methodNodes = [ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
307 | childNode for childNode in node.body |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
308 | if isinstance(childNode, (ast.FunctionDef, ast.AsyncFunctionDef)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
309 | ] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
310 | for methodNode in methodNodes: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
311 | self.__checkFunctionNode(methodNode, classMethod=True) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
312 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
313 | def __checkFunctionNode(self, node, classMethod=False): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
314 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
315 | Private method to check an individual function definition node. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
316 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
317 | @param node reference to the node to be processed |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
318 | @type ast.FunctionDef or ast.AsyncFunctionDef |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
319 | @param classMethod flag indicating a class method |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
320 | @type bool |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
321 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
322 | if node.name.startswith("__") and node.name.endswith("__"): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
323 | visibilityType = "special" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
324 | elif node.name.startswith("__"): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
325 | visibilityType = "private" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
326 | elif node.name.startswith("_"): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
327 | visibilityType = "protected" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
328 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
329 | visibilityType = "public" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
330 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
331 | if classMethod: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
332 | decorators = [ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
333 | decorator.id for decorator in node.decorator_list |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
334 | if isinstance(decorator, ast.Name) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
335 | ] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
336 | if "classmethod" in decorators: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
337 | classMethodType = "decorator" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
338 | elif "staticmethod" in decorators: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
339 | classMethodType = "staticmethod" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
340 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
341 | classMethodType = "" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
342 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
343 | classMethodType = "function" |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
344 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
345 | # check argument annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
346 | for argType in ("args", "vararg", "kwonlyargs", "kwarg"): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
347 | args = node.args.__getattribute__(argType) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
348 | if args: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
349 | if not isinstance(args, list): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
350 | args = [args] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
351 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
352 | for arg in args: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
353 | if not arg.annotation: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
354 | self.__classifyArgumentError( |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
355 | arg, argType, classMethodType) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
356 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
357 | # check function return annotation |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
358 | if not node.returns: |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
359 | lineno = node.lineno |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
360 | colOffset = self.__sourceLines[lineno - 1].rfind(":") + 1 |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
361 | self.__classifyReturnError(classMethodType, visibilityType, |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
362 | lineno, colOffset) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
363 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
364 | def __classifyReturnError(self, methodType, visibilityType, lineno, |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
365 | colOffset): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
366 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
367 | Private method to classify and record a return annotation issue. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
368 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
369 | @param methodType type of method/function the argument belongs to |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
370 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
371 | @param visibilityType visibility of the function |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
372 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
373 | @param lineno line number |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
374 | @type int |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
375 | @param colOffset column number |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
376 | @type int |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
377 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
378 | # create a dummy AST node to report line and column |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
379 | node = ast.AST() |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
380 | node.lineno = lineno |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
381 | node.col_offset = colOffset |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
382 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
383 | # now classify the issue |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
384 | if methodType == "classmethod": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
385 | self.issues.append((node, "A206")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
386 | elif methodType == "staticmethod": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
387 | self.issues.append((node, "A205")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
388 | elif visibilityType == "special": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
389 | self.issues.append((node, "A204")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
390 | elif visibilityType == "private": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
391 | self.issues.append((node, "A203")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
392 | elif visibilityType == "protected": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
393 | self.issues.append((node, "A202")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
394 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
395 | self.issues.append((node, "A201")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
396 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
397 | def __classifyArgumentError(self, argNode, argType, methodType): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
398 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
399 | Private method to classify and record an argument annotation issue. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
400 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
401 | @param argNode reference to the argument node |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
402 | @type ast.arguments |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
403 | @param argType type of the argument node |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
404 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
405 | @param methodType type of method/function the argument belongs to |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
406 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
407 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
408 | # check class method issues |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
409 | if methodType != "function": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
410 | if argNode.arg in ("cls", "self"): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
411 | if methodType == "classmethod": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
412 | self.issues.append((argNode, "A102")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
413 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
414 | elif methodType != "staticmethod": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
415 | self.issues.append((argNode, "A101")) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
416 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
417 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
418 | # check all other arguments |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
419 | if argType == "kwarg": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
420 | self.issues.append((argNode, "A003", argNode.arg)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
421 | elif argType == "vararg": |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
422 | self.issues.append((argNode, "A002", argNode.arg)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
423 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
424 | # args and kwonlyargs |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
425 | self.issues.append((argNode, "A001", argNode.arg)) |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
426 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
427 | ###################################################################### |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
428 | ## some utility functions below |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
429 | ###################################################################### |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
430 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
431 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
432 | def hasTypeAnnotations(funcNode): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
433 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
434 | Function to check for type annotations. |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
435 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
436 | @param funcNode reference to the function definition node to be checked |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
437 | @type ast.AsyncFunctionDef or ast.FunctionDef |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
438 | @return flag indicating the presence of type annotations |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
439 | @rtype bool |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
440 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
441 | hasReturnAnnotation = funcNode.returns is not None |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
442 | hasArgsAnnotations = any(a for a in funcNode.args.args |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
443 | if a.annotation is not None) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
444 | hasKwargsAnnotations = (funcNode.args and |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
445 | funcNode.args.kwarg and |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
446 | funcNode.args.kwarg.annotation is not None) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
447 | hasKwonlyargsAnnotations = any(a for a in funcNode.args.kwonlyargs |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
448 | if a.annotation is not None) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
449 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
450 | return any((hasReturnAnnotation, hasArgsAnnotations, hasKwargsAnnotations, |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
451 | hasKwonlyargsAnnotations)) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
452 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
453 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
454 | def getAnnotationComplexity(annotationNode): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
455 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
456 | Function to determine the annotation complexity. |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
457 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
458 | @param annotationNode reference to the node to determine the annotation |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
459 | complexity for |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
460 | @type ast.AST |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
461 | @return annotation complexity |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
462 | @rtype = int |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
463 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
464 | if isinstance(annotationNode, ast.Str): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
465 | annotationNode = ast.parse(annotationNode.s).body[0].value |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
466 | if isinstance(annotationNode, ast.Subscript): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
467 | return 1 + getAnnotationComplexity(annotationNode.slice.value) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
468 | if isinstance(annotationNode, ast.Tuple): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
469 | return max(getAnnotationComplexity(n) for n in annotationNode.elts) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
470 | return 1 |