Tue, 06 Apr 2021 17:53:39 +0200
Code Style Checker
- added a simplify check to detect assignments that could be converted to augmented assignments
8186 | 1 | # -*- coding: utf-8 -*- |
2 | ||
3 | # Copyright (c) 2021 Detlev Offenbach <detlev@die-offenbachs.de> | |
4 | # | |
5 | ||
6 | """ | |
7 | Module implementing the checker for simplifying Python code. | |
8 | """ | |
9 | ||
10 | import ast | |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
11 | import copy |
8186 | 12 | |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
13 | from .SimplifyNodeVisitor import SimplifyNodeVisitor |
8186 | 14 | |
15 | ||
16 | class SimplifyChecker(object): | |
17 | """ | |
18 | Class implementing a checker for to help simplifying Python code. | |
19 | """ | |
20 | Codes = [ | |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
21 | # Python-specifics |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
22 | "Y101", "Y102", "Y103", "Y104", "Y105", "Y106", "Y107", "Y108", |
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
23 | "Y109", "Y110", "Y111", "Y112", "Y113", "Y114", "Y115", "Y116", |
8202
df194f43119c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
24 | "Y117", "Y118", "Y119", "Y120", "Y121", |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
25 | |
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
26 | # Comparations |
8195
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
27 | "Y201", "Y202", "Y203", "Y204", "Y205", "Y206", "Y207", "Y208", |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
28 | "Y211", "Y212", "Y213", |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
29 | "Y221", "Y222", "Y223", "Y224", |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
30 | |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
31 | # Opinionated |
db7f2badd374
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8194
diff
changeset
|
32 | "Y301", |
8186 | 33 | ] |
34 | ||
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
35 | def __init__(self, source, filename, tree, selected, ignored, expected, |
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
36 | repeat): |
8186 | 37 | """ |
38 | Constructor | |
39 | ||
40 | @param source source code to be checked | |
41 | @type list of str | |
42 | @param filename name of the source file | |
43 | @type str | |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
44 | @param tree AST tree of the source code |
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
45 | @type ast.Module |
8186 | 46 | @param selected list of selected codes |
47 | @type list of str | |
48 | @param ignored list of codes to be ignored | |
49 | @type list of str | |
50 | @param expected list of expected codes | |
51 | @type list of str | |
52 | @param repeat flag indicating to report each occurrence of a code | |
53 | @type bool | |
54 | """ | |
55 | self.__select = tuple(selected) | |
56 | self.__ignore = ('',) if selected else tuple(ignored) | |
57 | self.__expected = expected[:] | |
58 | self.__repeat = repeat | |
59 | self.__filename = filename | |
60 | self.__source = source[:] | |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8195
diff
changeset
|
61 | self.__tree = copy.deepcopy(tree) |
8186 | 62 | |
63 | # statistics counters | |
64 | self.counters = {} | |
65 | ||
66 | # collection of detected errors | |
67 | self.errors = [] | |
68 | ||
69 | self.__checkCodes = (code for code in self.Codes | |
70 | if not self.__ignoreCode(code)) | |
71 | ||
72 | def __ignoreCode(self, code): | |
73 | """ | |
74 | Private method to check if the message code should be ignored. | |
75 | ||
76 | @param code message code to check for | |
77 | @type str | |
78 | @return flag indicating to ignore the given code | |
79 | @rtype bool | |
80 | """ | |
81 | return (code.startswith(self.__ignore) and | |
82 | not code.startswith(self.__select)) | |
83 | ||
84 | def __error(self, lineNumber, offset, code, *args): | |
85 | """ | |
86 | Private method to record an issue. | |
87 | ||
88 | @param lineNumber line number of the issue | |
89 | @type int | |
90 | @param offset position within line of the issue | |
91 | @type int | |
92 | @param code message code | |
93 | @type str | |
94 | @param args arguments for the message | |
95 | @type list | |
96 | """ | |
97 | if self.__ignoreCode(code): | |
98 | return | |
99 | ||
100 | if code in self.counters: | |
101 | self.counters[code] += 1 | |
102 | else: | |
103 | self.counters[code] = 1 | |
104 | ||
105 | # Don't care about expected codes | |
106 | if code in self.__expected: | |
107 | return | |
108 | ||
109 | if code and (self.counters[code] == 1 or self.__repeat): | |
110 | # record the issue with one based line number | |
111 | self.errors.append( | |
112 | { | |
113 | "file": self.__filename, | |
114 | "line": lineNumber + 1, | |
115 | "offset": offset, | |
116 | "code": code, | |
117 | "args": args, | |
118 | } | |
119 | ) | |
120 | ||
121 | def run(self): | |
122 | """ | |
123 | Public method to check the given source against functions | |
124 | to be replaced by 'pathlib' equivalents. | |
125 | """ | |
126 | if not self.__filename: | |
127 | # don't do anything, if essential data is missing | |
128 | return | |
129 | ||
130 | if not self.__checkCodes: | |
131 | # don't do anything, if no codes were selected | |
132 | return | |
133 | ||
8191
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
134 | # Add parent information |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
135 | for node in ast.walk(self.__tree): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
136 | for child in ast.iter_child_nodes(node): |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
137 | child.parent = node # type: ignore |
9125da0c227e
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8189
diff
changeset
|
138 | |
8189
17df5c8df8c1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8186
diff
changeset
|
139 | visitor = SimplifyNodeVisitor(self.__error) |
8186 | 140 | visitor.visit(self.__tree) |