8186
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1
|
# -*- coding: utf-8 -*- |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
3
|
# Copyright (c) 2021 Detlev Offenbach <detlev@die-offenbachs.de> |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7
|
Module implementing the checker for simplifying Python code. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10
|
import ast |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11
|
import sys |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12
|
|
8189
|
13
|
from .SimplifyNodeVisitor import SimplifyNodeVisitor |
8186
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16
|
class SimplifyChecker(object): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18
|
Class implementing a checker for to help simplifying Python code. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20
|
Codes = [ |
8189
|
21
|
# Python-specifics |
|
22
|
"Y101", "Y102", "Y103", "Y104", "Y105", "Y106", "Y107", "Y108", |
8191
|
23
|
"Y109", "Y110", "Y111", "Y112", "Y113", "Y114", "Y115", "Y116", |
8194
|
24
|
"Y117", "Y118", "Y119", "Y120", |
8189
|
25
|
|
|
26
|
# Comparations |
8195
|
27
|
"Y201", "Y202", "Y203", "Y204", "Y205", "Y206", "Y207", "Y208", |
|
28
|
"Y211", "Y212", "Y213", |
|
29
|
"Y221", "Y222", "Y223", "Y224", |
|
30
|
|
|
31
|
# Opinionated |
|
32
|
"Y301", |
8186
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33
|
] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35
|
def __init__(self, source, filename, selected, ignored, expected, repeat): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37
|
Constructor |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39
|
@param source source code to be checked |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41
|
@param filename name of the source file |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43
|
@param selected list of selected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45
|
@param ignored list of codes to be ignored |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47
|
@param expected list of expected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49
|
@param repeat flag indicating to report each occurrence of a code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50
|
@type bool |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52
|
self.__select = tuple(selected) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53
|
self.__ignore = ('',) if selected else tuple(ignored) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54
|
self.__expected = expected[:] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55
|
self.__repeat = repeat |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56
|
self.__filename = filename |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57
|
self.__source = source[:] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59
|
# statistics counters |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60
|
self.counters = {} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62
|
# collection of detected errors |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63
|
self.errors = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65
|
self.__checkCodes = (code for code in self.Codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66
|
if not self.__ignoreCode(code)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68
|
def __ignoreCode(self, code): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70
|
Private method to check if the message code should be ignored. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72
|
@param code message code to check for |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74
|
@return flag indicating to ignore the given code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75
|
@rtype bool |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77
|
return (code.startswith(self.__ignore) and |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78
|
not code.startswith(self.__select)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80
|
def __error(self, lineNumber, offset, code, *args): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82
|
Private method to record an issue. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84
|
@param lineNumber line number of the issue |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85
|
@type int |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86
|
@param offset position within line of the issue |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87
|
@type int |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
88
|
@param code message code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90
|
@param args arguments for the message |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91
|
@type list |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
92
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93
|
if self.__ignoreCode(code): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
94
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96
|
if code in self.counters: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97
|
self.counters[code] += 1 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99
|
self.counters[code] = 1 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101
|
# Don't care about expected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102
|
if code in self.__expected: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105
|
if code and (self.counters[code] == 1 or self.__repeat): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106
|
# record the issue with one based line number |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107
|
self.errors.append( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108
|
{ |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109
|
"file": self.__filename, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110
|
"line": lineNumber + 1, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111
|
"offset": offset, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112
|
"code": code, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
113
|
"args": args, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
114
|
} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115
|
) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117
|
def __reportInvalidSyntax(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119
|
Private method to report a syntax error. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121
|
exc_type, exc = sys.exc_info()[:2] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122
|
if len(exc.args) > 1: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123
|
offset = exc.args[1] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124
|
if len(offset) > 2: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125
|
offset = offset[1:3] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127
|
offset = (1, 0) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128
|
self.__error(offset[0] - 1, offset[1] or 0, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129
|
'M901', exc_type.__name__, exc.args[0]) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131
|
def __generateTree(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
133
|
Private method to generate an AST for our source. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
134
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
135
|
@return generated AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136
|
@rtype ast.AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
138
|
return ast.parse("".join(self.__source), self.__filename) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
139
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
140
|
def run(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
142
|
Public method to check the given source against functions |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
143
|
to be replaced by 'pathlib' equivalents. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
144
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
145
|
if not self.__filename: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
146
|
# don't do anything, if essential data is missing |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
147
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
148
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
149
|
if not self.__checkCodes: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
150
|
# don't do anything, if no codes were selected |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
151
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153
|
try: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
154
|
self.__tree = self.__generateTree() |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155
|
except (SyntaxError, TypeError): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156
|
self.__reportInvalidSyntax() |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158
|
|
8191
|
159
|
# Add parent information |
|
160
|
for node in ast.walk(self.__tree): |
|
161
|
for child in ast.iter_child_nodes(node): |
|
162
|
child.parent = node # type: ignore |
|
163
|
|
8189
|
164
|
visitor = SimplifyNodeVisitor(self.__error) |
8186
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165
|
visitor.visit(self.__tree) |