8166
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1
|
# -*- coding: utf-8 -*- |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
3
|
# Copyright (c) 2021 Detlev Offenbach <detlev@die-offenbachs.de> |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7
|
Module implementing the checker for functions that can be replaced by use of |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8
|
the pathlib module. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11
|
import ast |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12
|
import sys |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15
|
class PathlibChecker(object): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17
|
Class implementing a checker for functions that can be replaced by use of |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18
|
the pathlib module. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20
|
Codes = [ |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21
|
## Replacements for the os module functions |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22
|
"P101", "P102", "P103", "P104", "P105", "P106", "P107", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23
|
"P108", "P109", "P110", "P111", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25
|
## Replacements for the os.path module functions |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
26
|
"P201", "P202", "P203", "P204", "P205", "P206", "P207", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27
|
"P208", "P209", "P210", "P211", "P212", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
28
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
29
|
## Replacements for some Python standrd library functions |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30
|
"P301", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
32
|
## Replacements for py.path.local |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33
|
"P401", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34
|
] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36
|
# map functions to be replaced to error codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37
|
Function2Code = { |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38
|
"os.chmod": "P101", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39
|
"os.mkdir": "P102", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40
|
"os.makedirs": "P103", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41
|
"os.rename": "P104", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42
|
"os.replace": "P105", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43
|
"os.rmdir": "P106", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44
|
"os.remove": "P107", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45
|
"os.unlink": "P108", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46
|
"os.getcwd": "P109", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47
|
"os.readlink": "P110", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48
|
"os.stat": "P111", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50
|
"os.path.abspath": "P201", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51
|
"os.path.exists": "P202", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52
|
"os.path.expanduser": "P203", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53
|
"os.path.isdir": "P204", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54
|
"os.path.isfile": "P205", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55
|
"os.path.islink": "P206", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56
|
"os.path.isabs": "P207", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57
|
"os.path.join": "P208", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58
|
"os.path.basename": "P209", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59
|
"os.path.dirname": "P210", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60
|
"os.path.samefile": "P211", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61
|
"os.path.splitext": "P212", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63
|
"open": "P301", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65
|
"py.path.local": "P401", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66
|
} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68
|
def __init__(self, source, filename, selected, ignored, expected, repeat): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70
|
Constructor |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72
|
@param source source code to be checked |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74
|
@param filename name of the source file |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76
|
@param selected list of selected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78
|
@param ignored list of codes to be ignored |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80
|
@param expected list of expected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81
|
@type list of str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82
|
@param repeat flag indicating to report each occurrence of a code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83
|
@type bool |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85
|
self.__select = tuple(selected) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86
|
self.__ignore = ('',) if selected else tuple(ignored) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87
|
self.__expected = expected[:] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
88
|
self.__repeat = repeat |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89
|
self.__filename = filename |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90
|
self.__source = source[:] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
92
|
# statistics counters |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93
|
self.counters = {} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
94
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95
|
# collection of detected errors |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96
|
self.errors = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98
|
self.__checkCodes = (code for code in self.Codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99
|
if not self.__ignoreCode(code)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101
|
def __ignoreCode(self, code): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103
|
Private method to check if the message code should be ignored. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105
|
@param code message code to check for |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107
|
@return flag indicating to ignore the given code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108
|
@rtype bool |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110
|
return (code.startswith(self.__ignore) and |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111
|
not code.startswith(self.__select)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
113
|
def __error(self, lineNumber, offset, code, *args): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
114
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115
|
Private method to record an issue. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117
|
@param lineNumber line number of the issue |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118
|
@type int |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119
|
@param offset position within line of the issue |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120
|
@type int |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121
|
@param code message code |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123
|
@param args arguments for the message |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124
|
@type list |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126
|
if self.__ignoreCode(code): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129
|
if code in self.counters: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130
|
self.counters[code] += 1 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132
|
self.counters[code] = 1 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
133
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
134
|
# Don't care about expected codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
135
|
if code in self.__expected: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
138
|
if code and (self.counters[code] == 1 or self.__repeat): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
139
|
# record the issue with one based line number |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
140
|
self.errors.append( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141
|
{ |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
142
|
"file": self.__filename, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
143
|
"line": lineNumber + 1, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
144
|
"offset": offset, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
145
|
"code": code, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
146
|
"args": args, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
147
|
} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
148
|
) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
149
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
150
|
def __reportInvalidSyntax(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
151
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152
|
Private method to report a syntax error. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
154
|
exc_type, exc = sys.exc_info()[:2] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155
|
if len(exc.args) > 1: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156
|
offset = exc.args[1] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157
|
if len(offset) > 2: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158
|
offset = offset[1:3] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
159
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
160
|
offset = (1, 0) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
161
|
self.__error(offset[0] - 1, offset[1] or 0, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
162
|
'M901', exc_type.__name__, exc.args[0]) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
163
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
164
|
def __generateTree(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
166
|
Private method to generate an AST for our source. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
167
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
168
|
@return generated AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
169
|
@rtype ast.AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
170
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
171
|
return ast.parse("".join(self.__source), self.__filename) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
172
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
173
|
def run(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
174
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
175
|
Public method to check the given source against functions |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
176
|
to be replaced by 'pathlib' equivalents. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
177
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
178
|
if not self.__filename: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
179
|
# don't do anything, if essential data is missing |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
180
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
181
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
182
|
if not self.__checkCodes: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
183
|
# don't do anything, if no codes were selected |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
184
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
185
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
186
|
try: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
187
|
self.__tree = self.__generateTree() |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
188
|
except (SyntaxError, TypeError): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
189
|
self.__reportInvalidSyntax() |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
190
|
return |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
191
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
192
|
visitor = PathlibVisitor(self.__checkForReplacement) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
193
|
visitor.visit(self.__tree) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
194
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
195
|
def __checkForReplacement(self, node, name): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
196
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
197
|
Private method to check the given node for the need for a |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
198
|
replacement. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
199
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
200
|
@param node reference to the AST node to check |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
201
|
@type ast.AST |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202
|
@param name resolved name of the node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203
|
@type str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
204
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
205
|
try: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
206
|
errorCode = self.Function2Code[name] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
207
|
self.__error(node.lineno - 1, node.col_offset, errorCode) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
208
|
except KeyError: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
209
|
# name is not in our list of replacements |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
210
|
pass |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
211
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
212
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
213
|
class PathlibVisitor(ast.NodeVisitor): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
214
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
215
|
Class to traverse the AST node tree and check for potential issues. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
216
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
217
|
def __init__(self, checkCallback): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
218
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
219
|
Constructor |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
220
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
221
|
@param checkCallback callback function taking a reference to the |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
222
|
AST node and the resolved name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
223
|
@type func |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
224
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
225
|
super(PathlibVisitor, self).__init__() |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
226
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
227
|
self.__checkCallback = checkCallback |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
228
|
self.__importAlias = {} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
229
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
230
|
def visit_ImportFrom(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
231
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
232
|
Public method handle the ImportFrom AST node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
233
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
234
|
@param node reference to the ImportFrom AST node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
235
|
@type ast.ImportFrom |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
236
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
237
|
for imp in node.names: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
238
|
if imp.asname: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
239
|
self.__importAlias[imp.asname] = f"{node.module}.{imp.name}" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
240
|
else: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
241
|
self.__importAlias[imp.name] = f"{node.module}.{imp.name}" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
242
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
243
|
def visit_Import(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
244
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
245
|
Public method to handle the Import AST node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
246
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
247
|
@param node reference to the Import AST node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
248
|
@type ast.Import |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
249
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
250
|
for imp in node.names: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
251
|
if imp.asname: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
252
|
self.__importAlias[imp.asname] = imp.name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
253
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
254
|
def visit_Call(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
255
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
256
|
Public method to handle the Call AST node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
257
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
258
|
@param node reference to the Call AST node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
259
|
@type ast.Call |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
260
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
261
|
nameResolver = NameResolver(self.__importAlias) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
262
|
nameResolver.visit(node.func) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
263
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
264
|
self.__checkCallback(node, nameResolver.name()) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
265
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
266
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
267
|
class NameResolver(ast.NodeVisitor): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
268
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
269
|
Class to resolve a Name or Attribute node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
270
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
271
|
def __init__(self, importAlias): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
272
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
273
|
Constructor |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
274
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
275
|
@param importAlias reference to the import aliases dictionary |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
276
|
@type dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
277
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
278
|
self.__importAlias = importAlias |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
279
|
self.__names = [] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
280
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
281
|
def name(self): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
282
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
283
|
Public method to resolve the name. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
284
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
285
|
@return resolved name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
286
|
@rtype str |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
287
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
288
|
try: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
289
|
attr = self.__importAlias[self.__names[-1]] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
290
|
self.__names[-1] = attr |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
291
|
except (KeyError, IndexError): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
292
|
# do nothing if there is no such name or the names list is empty |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
293
|
pass |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
294
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
295
|
return ".".join(reversed(self.__names)) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
296
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
297
|
def visit_Name(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
298
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
299
|
Public method to handle the Name AST node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
300
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
301
|
@param node reference to the Name AST node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
302
|
@type ast.Name |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
303
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
304
|
self.__names.append(node.id) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
305
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
306
|
def visit_Attribute(self, node): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
307
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
308
|
Public method to handle the Attribute AST node. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
309
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
310
|
@param node reference to the Attribute AST node |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
311
|
@type ast.Attribute |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
312
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
313
|
try: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
314
|
self.__names.append(node.attr) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
315
|
self.__names.append(node.value.id) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
316
|
except AttributeError: |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
317
|
self.generic_visit(node) |