Fri, 01 Dec 2023 16:19:15 +0100
Code Style Checker
- Updated the logging checker to support more cases (based on flake8_logging 1.4.0).
10362 | 1 | # -*- coding: utf-8 -*- |
2 | ||
3 | # Copyright (c) 2023 Detlev Offenbach <detlev@die-offenbachs.de> | |
4 | # | |
5 | ||
6 | ||
7 | """ | |
8 | Module implementing message translations for the code style plugin messages | |
9 | (logging part). | |
10 | """ | |
11 | ||
12 | from PyQt6.QtCore import QCoreApplication | |
13 | ||
14 | _loggingMessages = { | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
15 | ## Logging |
10362 | 16 | "L101": QCoreApplication.translate( |
17 | "LoggingChecker", | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
18 | "use logging.getLogger() to instantiate loggers", |
10362 | 19 | ), |
20 | "L102": QCoreApplication.translate( | |
21 | "LoggingChecker", | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
22 | "use '__name__' with getLogger()", |
10362 | 23 | ), |
24 | "L103": QCoreApplication.translate( | |
25 | "LoggingChecker", | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
26 | "extra key {0} clashes with LogRecord attribute", |
10362 | 27 | ), |
28 | "L104": QCoreApplication.translate( | |
29 | "LoggingChecker", | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
30 | "avoid exception() outside of exception handlers", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
31 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
32 | "L105": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
33 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
34 | ".exception(...) should be used instead of .error(..., exc_info=True)", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
35 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
36 | "L106": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
37 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
38 | "redundant exc_info argument for exception() should be removed", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
39 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
40 | "L107": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
41 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
42 | "use error() instead of exception() with exc_info=False", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
43 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
44 | "L108": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
45 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
46 | "warn() is deprecated, use warning() instead", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
47 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
48 | "L109": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
49 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
50 | "WARN is undocumented, use WARNING instead", |
10362 | 51 | ), |
52 | "L110": QCoreApplication.translate( | |
53 | "LoggingChecker", | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
54 | "exception() does not take an exception", |
10362 | 55 | ), |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
56 | "L111a": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
57 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
58 | "avoid pre-formatting log messages using f-string", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
59 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
60 | "L111b": QCoreApplication.translate( |
10362 | 61 | "LoggingChecker", |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
62 | "avoid pre-formatting log messages using string.format()", |
10362 | 63 | ), |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
64 | "L111c": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
65 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
66 | "avoid pre-formatting log messages using '%'", # noqa: M601 |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
67 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
68 | "L111d": QCoreApplication.translate( |
10362 | 69 | "LoggingChecker", |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
70 | "avoid pre-formatting log messages using '+'", |
10362 | 71 | ), |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
72 | "L112": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
73 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
74 | "formatting error: {0} {1} placeholder(s) but {2} argument(s)", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
75 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
76 | "L113a": QCoreApplication.translate( |
10362 | 77 | "LoggingChecker", |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
78 | "formatting error: missing key(s): {0}", |
10362 | 79 | ), |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
80 | "L113b": QCoreApplication.translate( |
10362 | 81 | "LoggingChecker", |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
82 | "formatting error: unreferenced key(s): {0}", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
83 | ), |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
84 | "L114": QCoreApplication.translate( |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
85 | "LoggingChecker", |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
86 | "avoid exc_info=True outside of exception handlers", |
10362 | 87 | ), |
88 | } | |
89 | ||
90 | _loggingMessagesSampleArgs = { | |
10367
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
91 | ## Logging |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
92 | "L103": ["'pathname'"], |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
93 | "L112": [3, "'%'", 2], # noqa: M601 |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
94 | "L113a": ["'foo', 'bar'"], |
b189ca1f5d53
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10363
diff
changeset
|
95 | "L113b": ["'foo', 'bar'"], |
10362 | 96 | } |