Sun, 26 Jun 2022 17:21:11 +0200
Changed default max. line length of code documentation style checker and code style fixer to 88 characters because this gives better looking code (see 'Black' tool).
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
8881
54e42bc2437a
Updated copyright for 2022.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8773
diff
changeset
|
3 | # Copyright (c) 2019 - 2022 Detlev Offenbach <detlev@die-offenbachs.de> |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for function type annotations. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8166
diff
changeset
|
10 | import copy |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11 | import ast |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
12 | import sys |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
13 | from functools import lru_cache |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14 | |
7622
384e2aa5c073
Code Style Checker: continued to implement checker for security related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
15 | import AstUtilities |
384e2aa5c073
Code Style Checker: continued to implement checker for security related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
16 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
17 | from .AnnotationsEnums import AnnotationType, ClassDecoratorType, FunctionType |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
18 | from .AnnotationsCheckerDefaults import AnnotationsCheckerDefaultArgs |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
19 | |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20 | |
8207
d359172d11be
Applied some more code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8204
diff
changeset
|
21 | class AnnotationsChecker: |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23 | Class implementing a checker for function type annotations. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25 | Codes = [ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
26 | ## Function Annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27 | "A001", "A002", "A003", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
28 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
29 | ## Method Annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30 | "A101", "A102", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
32 | ## Return Annotations |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33 | "A201", "A202", "A203", "A204", "A205", "A206", |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
35 | ## Mixed kind of annotations |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
36 | "A301", |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
37 | |
8773
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
38 | ## Annotations Future |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
39 | "A871", |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
40 | |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
41 | ## Annotation Coverage |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
42 | "A881", |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
43 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
44 | ## Annotation Complexity |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
45 | "A891", "A892", |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46 | ] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47 | |
8204
fd477cded1c1
Corrected some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
48 | def __init__(self, source, filename, tree, select, ignore, expected, |
fd477cded1c1
Corrected some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
49 | repeat, args): |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51 | Constructor |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53 | @param source source code to be checked |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55 | @param filename name of the source file |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56 | @type str |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8166
diff
changeset
|
57 | @param tree AST tree of the source code |
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8166
diff
changeset
|
58 | @type ast.Module |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59 | @param select list of selected codes |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61 | @param ignore list of codes to be ignored |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63 | @param expected list of expected codes |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64 | @type list of str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65 | @param repeat flag indicating to report each occurrence of a code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66 | @type bool |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
67 | @param args dictionary of arguments for the annotation checks |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
68 | @type dict |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70 | self.__select = tuple(select) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71 | self.__ignore = ('',) if select else tuple(ignore) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72 | self.__expected = expected[:] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73 | self.__repeat = repeat |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74 | self.__filename = filename |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75 | self.__source = source[:] |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8166
diff
changeset
|
76 | self.__tree = copy.deepcopy(tree) |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
77 | self.__args = args |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79 | # statistics counters |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80 | self.counters = {} |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82 | # collection of detected errors |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83 | self.errors = [] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85 | checkersWithCodes = [ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86 | ( |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87 | self.__checkFunctionAnnotations, |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
88 | ("A001", "A002", "A003", "A101", "A102", |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
89 | "A201", "A202", "A203", "A204", "A205", "A206", |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
90 | "A301", ) |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91 | ), |
8773
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
92 | (self.__checkAnnotationsFuture, ("A871",)), |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
93 | (self.__checkAnnotationsCoverage, ("A881",)), |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
94 | (self.__checkAnnotationComplexity, ("A891", "A892")), |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95 | ] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97 | self.__checkers = [] |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98 | for checker, codes in checkersWithCodes: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99 | if any(not (code and self.__ignoreCode(code)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100 | for code in codes): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101 | self.__checkers.append(checker) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103 | def __ignoreCode(self, code): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105 | Private method to check if the message code should be ignored. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107 | @param code message code to check for |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109 | @return flag indicating to ignore the given code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110 | @rtype bool |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112 | return (code.startswith(self.__ignore) and |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
113 | not code.startswith(self.__select)) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
114 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115 | def __error(self, lineNumber, offset, code, *args): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117 | Private method to record an issue. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119 | @param lineNumber line number of the issue |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120 | @type int |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121 | @param offset position within line of the issue |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122 | @type int |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123 | @param code message code |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124 | @type str |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125 | @param args arguments for the message |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126 | @type list |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128 | if self.__ignoreCode(code): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131 | if code in self.counters: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132 | self.counters[code] += 1 |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
133 | else: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
134 | self.counters[code] = 1 |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
135 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136 | # Don't care about expected codes |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137 | if code in self.__expected: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
138 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
139 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
140 | if code and (self.counters[code] == 1 or self.__repeat): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141 | # record the issue with one based line number |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
142 | self.errors.append( |
7610
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
143 | { |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
144 | "file": self.__filename, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
145 | "line": lineNumber + 1, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
146 | "offset": offset, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
147 | "code": code, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
148 | "args": args, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
149 | } |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
150 | ) |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
151 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152 | def run(self): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
154 | Public method to check the given source against annotation issues. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156 | if not self.__filename: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157 | # don't do anything, if essential data is missing |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
159 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
160 | if not self.__checkers: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
161 | # don't do anything, if no codes were selected |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
162 | return |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
163 | |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
164 | for check in self.__checkers: |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165 | check() |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
166 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
167 | ####################################################################### |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
168 | ## Annotations |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
169 | ## |
8773
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
170 | ## adapted from: flake8-annotations v2.7.0 |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
171 | ####################################################################### |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
172 | |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
173 | def __checkFunctionAnnotations(self): |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
174 | """ |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
175 | Private method to check for function annotation issues. |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
176 | """ |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
177 | suppressNoneReturning = self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
178 | "SuppressNoneReturning", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
179 | AnnotationsCheckerDefaultArgs["SuppressNoneReturning"]) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
180 | suppressDummyArgs = self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
181 | "SuppressDummyArgs", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
182 | AnnotationsCheckerDefaultArgs["SuppressDummyArgs"]) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
183 | allowUntypedDefs = self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
184 | "AllowUntypedDefs", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
185 | AnnotationsCheckerDefaultArgs["AllowUntypedDefs"]) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
186 | allowUntypedNested = self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
187 | "AllowUntypedNested", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
188 | AnnotationsCheckerDefaultArgs["AllowUntypedNested"]) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
189 | mypyInitReturn = self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
190 | "MypyInitReturn", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
191 | AnnotationsCheckerDefaultArgs["MypyInitReturn"]) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
192 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
193 | # Store decorator lists as sets for easier lookup |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
194 | dispatchDecorators = set(self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
195 | "DispatchDecorators", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
196 | AnnotationsCheckerDefaultArgs["DispatchDecorators"])) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
197 | overloadDecorators = set(self.__args.get( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
198 | "OverloadDecorators", |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
199 | AnnotationsCheckerDefaultArgs["OverloadDecorators"])) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
200 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
201 | from .AnnotationsFunctionVisitor import FunctionVisitor |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202 | visitor = FunctionVisitor(self.__source) |
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203 | visitor.visit(self.__tree) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
204 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
205 | # Keep track of the last encountered function decorated by |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
206 | # `typing.overload`, if any. Per the `typing` module documentation, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
207 | # a series of overload-decorated definitions must be followed by |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
208 | # exactly one non-overload-decorated definition of the same function. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
209 | lastOverloadDecoratedFunctionName = None |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
210 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
211 | # Iterate over the arguments with missing type hints, by function. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
212 | for function in visitor.functionDefinitions: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
213 | if ( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
214 | function.isDynamicallyTyped() and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
215 | (allowUntypedDefs or |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
216 | (function.isNested and allowUntypedNested)) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
217 | ): |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
218 | # Skip recording errors from dynamically typed functions |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
219 | # or nested functions |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
220 | continue |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
221 | |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
222 | # Skip recording errors for configured dispatch functions, such as |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
223 | # (by default) `functools.singledispatch` and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
224 | # `functools.singledispatchmethod` |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
225 | if function.hasDecorator(dispatchDecorators): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
226 | continue |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
227 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
228 | # Create sentinels to check for mixed hint styles |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
229 | hasTypeComment = function.hasTypeComment |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
230 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
231 | has3107Annotation = False |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
232 | # PEP 3107 annotations are captured by the return arg |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
233 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
234 | # Iterate over annotated args to detect mixing of type annotations |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
235 | # and type comments. Emit this only once per function definition |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
236 | for arg in function.getAnnotatedArguments(): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
237 | if arg.hasTypeComment: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
238 | hasTypeComment = True |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
239 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
240 | if arg.has3107Annotation: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
241 | has3107Annotation = True |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
242 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
243 | if hasTypeComment and has3107Annotation: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
244 | # Short-circuit check for mixing of type comments & |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
245 | # 3107-style annotations |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
246 | self.__error(function.lineno - 1, function.col_offset, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
247 | "A301") |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
248 | break |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
249 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
250 | # Before we iterate over the function's missing annotations, check |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
251 | # to see if it's the closing function def in a series of |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
252 | # `typing.overload` decorated functions. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
253 | if lastOverloadDecoratedFunctionName == function.name: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
254 | continue |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
255 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
256 | # If it's not, and it is overload decorated, store it for the next |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
257 | # iteration |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
258 | if function.hasDecorator(overloadDecorators): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
259 | lastOverloadDecoratedFunctionName = function.name |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
260 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
261 | # Record explicit errors for arguments that are missing annotations |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
262 | for arg in function.getMissedAnnotations(): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
263 | if arg.argname == "return": |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
264 | # return annotations have multiple possible short-circuit |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
265 | # paths |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
266 | if ( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
267 | suppressNoneReturning and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
268 | not arg.hasTypeAnnotation and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
269 | function.hasOnlyNoneReturns |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
270 | ): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
271 | # Skip recording return errors if the function has only |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
272 | # `None` returns. This includes the case of no returns. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
273 | continue |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
274 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
275 | if ( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
276 | mypyInitReturn and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
277 | function.isClassMethod and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
278 | function.name == "__init__" and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
279 | function.getAnnotatedArguments() |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
280 | ): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
281 | # Skip recording return errors for `__init__` if at |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
282 | # least one argument is annotated |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
283 | continue |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
284 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
285 | # If the `suppressDummyArgs` flag is `True`, skip recording |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
286 | # errors for any arguments named `_` |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
287 | if arg.argname == "_" and suppressDummyArgs: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
288 | continue |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
289 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
290 | self.__classifyError(function, arg) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
291 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
292 | def __classifyError(self, function, arg): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
293 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
294 | Private method to classify the missing type annotation based on the |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
295 | Function & Argument metadata. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
296 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
297 | For the currently defined rules & program flow, the assumption can be |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
298 | made that an argument passed to this method will match a linting error, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
299 | and will only match a single linting error |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
300 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
301 | This function provides an initial classificaton, then passes relevant |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
302 | attributes to cached helper function(s). |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
303 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
304 | @param function reference to the Function object |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
305 | @type Function |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
306 | @param arg reference to the Argument object |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
307 | @type Argument |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
308 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
309 | # Check for return type |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
310 | # All return "arguments" have an explicitly defined name "return" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
311 | if arg.argname == "return": |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
312 | errorCode = self.__returnErrorClassifier( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
313 | function.isClassMethod, function.classDecoratorType, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
314 | function.functionType |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
315 | ) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
316 | else: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
317 | # Otherwise, classify function argument error |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
318 | isFirstArg = arg == function.args[0] |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
319 | errorCode = self.__argumentErrorClassifier( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
320 | function.isClassMethod, isFirstArg, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
321 | function.classDecoratorType, arg.annotationType, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
322 | ) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
323 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
324 | if errorCode in ("A001", "A002", "A003"): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
325 | self.__error(arg.lineno - 1, arg.col_offset, errorCode, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
326 | arg.argname) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
327 | else: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
328 | self.__error(arg.lineno - 1, arg.col_offset, errorCode) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
329 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
330 | @lru_cache() |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
331 | def __returnErrorClassifier(self, isClassMethod, classDecoratorType, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
332 | functionType): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
333 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
334 | Private method to classify a return type annotation issue. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
335 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
336 | @param isClassMethod flag indicating a classmethod type function |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
337 | @type bool |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
338 | @param classDecoratorType type of class decorator |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
339 | @type ClassDecoratorType |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
340 | @param functionType type of function |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
341 | @type FunctionType |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
342 | @return error code |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
343 | @rtype str |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
344 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
345 | # Decorated class methods (@classmethod, @staticmethod) have a higher |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
346 | # priority than the rest |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
347 | if isClassMethod: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
348 | if classDecoratorType == ClassDecoratorType.CLASSMETHOD: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
349 | return "A206" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
350 | elif classDecoratorType == ClassDecoratorType.STATICMETHOD: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
351 | return "A205" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
352 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
353 | if functionType == FunctionType.SPECIAL: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
354 | return "A204" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
355 | elif functionType == FunctionType.PRIVATE: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
356 | return "A203" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
357 | elif functionType == FunctionType.PROTECTED: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
358 | return "A202" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
359 | else: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
360 | return "A201" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
361 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
362 | @lru_cache() |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
363 | def __argumentErrorClassifier(self, isClassMethod, isFirstArg, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
364 | classDecoratorType, annotationType): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
365 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
366 | Private method to classify an argument type annotation issue. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
367 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
368 | @param isClassMethod flag indicating a classmethod type function |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
369 | @type bool |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
370 | @param isFirstArg flag indicating the first argument |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
371 | @type bool |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
372 | @param classDecoratorType type of class decorator |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
373 | @type enums.ClassDecoratorType |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
374 | @param annotationType type of annotation |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
375 | @type AnnotationType |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
376 | @return error code |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
377 | @rtype str |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
378 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
379 | # Check for regular class methods and @classmethod, @staticmethod is |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
380 | # deferred to final check |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
381 | if isClassMethod and isFirstArg: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
382 | # The first function argument here would be an instance of self or |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
383 | # class |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
384 | if classDecoratorType == ClassDecoratorType.CLASSMETHOD: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
385 | return "A102" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
386 | elif classDecoratorType != ClassDecoratorType.STATICMETHOD: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
387 | # Regular class method |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
388 | return "A101" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
389 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
390 | # Check for remaining codes |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
391 | if annotationType == AnnotationType.KWARG: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
392 | return "A003" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
393 | elif annotationType == AnnotationType.VARARG: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
394 | return "A002" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
395 | else: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
396 | # Combine PosOnlyArgs, Args, and KwOnlyArgs |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
397 | return "A001" |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
398 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
399 | ####################################################################### |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
400 | ## Annotations Coverage |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
401 | ## |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
402 | ## adapted from: flake8-annotations-coverage v0.0.5 |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
403 | ####################################################################### |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
404 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
405 | def __checkAnnotationsCoverage(self): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
406 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
407 | Private method to check for function annotation coverage. |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
408 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
409 | minAnnotationsCoverage = self.__args.get( |
8249
8232e8e4eeef
Fixed some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8246
diff
changeset
|
410 | "MinimumCoverage", |
8232e8e4eeef
Fixed some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8246
diff
changeset
|
411 | AnnotationsCheckerDefaultArgs["MinimumCoverage"]) |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
412 | if minAnnotationsCoverage == 0: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
413 | # 0 means it is switched off |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
414 | return |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
415 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
416 | functionDefs = [ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
417 | f for f in ast.walk(self.__tree) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
418 | if isinstance(f, (ast.AsyncFunctionDef, ast.FunctionDef)) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
419 | ] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
420 | if not functionDefs: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
421 | # no functions/methods at all |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
422 | return |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
423 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
424 | functionDefAnnotationsInfo = [ |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
425 | self.__hasTypeAnnotations(f) for f in functionDefs |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
426 | ] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
427 | annotationsCoverage = int( |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
428 | len(list(filter(None, functionDefAnnotationsInfo))) / |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
429 | len(functionDefAnnotationsInfo) * 100 |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
430 | ) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
431 | if annotationsCoverage < minAnnotationsCoverage: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
432 | self.__error(0, 0, "A881", annotationsCoverage) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
433 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
434 | def __hasTypeAnnotations(self, funcNode): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
435 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
436 | Private method to check for type annotations. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
437 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
438 | @param funcNode reference to the function definition node to be checked |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
439 | @type ast.AsyncFunctionDef or ast.FunctionDef |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
440 | @return flag indicating the presence of type annotations |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
441 | @rtype bool |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
442 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
443 | hasReturnAnnotation = funcNode.returns is not None |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
444 | hasArgsAnnotations = any(a for a in funcNode.args.args |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
445 | if a.annotation is not None) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
446 | hasKwargsAnnotations = (funcNode.args and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
447 | funcNode.args.kwarg and |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
448 | funcNode.args.kwarg.annotation is not None) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
449 | hasKwonlyargsAnnotations = any(a for a in funcNode.args.kwonlyargs |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
450 | if a.annotation is not None) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
451 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
452 | return any((hasReturnAnnotation, hasArgsAnnotations, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
453 | hasKwargsAnnotations, hasKwonlyargsAnnotations)) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
454 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
455 | ####################################################################### |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
456 | ## Annotations Complexity |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
457 | ## |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
458 | ## adapted from: flake8-annotations-complexity v0.0.6 |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
459 | ####################################################################### |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
460 | |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
461 | def __checkAnnotationComplexity(self): |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
462 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
463 | Private method to check the type annotation complexity. |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
464 | """ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
465 | maxAnnotationComplexity = self.__args.get( |
8249
8232e8e4eeef
Fixed some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8246
diff
changeset
|
466 | "MaximumComplexity", |
8232e8e4eeef
Fixed some code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8246
diff
changeset
|
467 | AnnotationsCheckerDefaultArgs["MaximumComplexity"]) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
468 | maxAnnotationLength = self.__args.get( |
8246
e4b95b0ebd31
Code Style Checker: added configuration options for the reworked the type annotations checker to the code style checker dialog.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8244
diff
changeset
|
469 | "MaximumLength", AnnotationsCheckerDefaultArgs["MaximumLength"]) |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
470 | typeAnnotations = [] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
471 | |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
472 | functionDefs = [ |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
473 | f for f in ast.walk(self.__tree) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
474 | if isinstance(f, (ast.AsyncFunctionDef, ast.FunctionDef)) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
475 | ] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
476 | for functionDef in functionDefs: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
477 | typeAnnotations += list(filter( |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
478 | None, [a.annotation for a in functionDef.args.args])) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
479 | if functionDef.returns: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
480 | typeAnnotations.append(functionDef.returns) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
481 | typeAnnotations += [a.annotation for a in ast.walk(self.__tree) |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
482 | if isinstance(a, ast.AnnAssign) and a.annotation] |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
483 | for annotation in typeAnnotations: |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
484 | complexity = self.__getAnnotationComplexity(annotation) |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
485 | if complexity > maxAnnotationComplexity: |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
486 | self.__error(annotation.lineno - 1, annotation.col_offset, |
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
487 | "A891", complexity, maxAnnotationComplexity) |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
488 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
489 | annotationLength = self.__getAnnotationLength(annotation) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
490 | if annotationLength > maxAnnotationLength: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
491 | self.__error(annotation.lineno - 1, annotation.col_offset, |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
492 | "A892", annotationLength, maxAnnotationLength) |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
493 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
494 | def __getAnnotationComplexity(self, annotationNode, defaultComplexity=1): |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
495 | """ |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
496 | Private method to determine the annotation complexity. |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
497 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
498 | @param annotationNode reference to the node to determine the annotation |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
499 | complexity for |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
500 | @type ast.AST |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
501 | @param defaultComplexity default complexity value |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
502 | @type int |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
503 | @return annotation complexity |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
504 | @rtype = int |
7246
c32a350d2414
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
505 | """ |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
506 | if AstUtilities.isString(annotationNode): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
507 | try: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
508 | annotationNode = ast.parse(annotationNode.s).body[0].value |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
509 | except (SyntaxError, IndexError): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
510 | return defaultComplexity |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
511 | if isinstance(annotationNode, ast.Subscript): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
512 | if sys.version_info >= (3, 9): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
513 | return (defaultComplexity + |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
514 | self.__getAnnotationComplexity(annotationNode.slice)) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
515 | else: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
516 | return ( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
517 | defaultComplexity + |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
518 | self.__getAnnotationComplexity(annotationNode.slice.value) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
519 | ) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
520 | if isinstance(annotationNode, ast.Tuple): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
521 | return max( |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
522 | (self.__getAnnotationComplexity(n) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
523 | for n in annotationNode.elts), |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
524 | default=defaultComplexity |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
525 | ) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
526 | return defaultComplexity |
7247
bf9379f964f3
Code Style Checker:
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7246
diff
changeset
|
527 | |
8244
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
528 | def __getAnnotationLength(self, annotationNode): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
529 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
530 | Private method to determine the annotation length. |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
531 | |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
532 | @param annotationNode reference to the node to determine the annotation |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
533 | length for |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
534 | @type ast.AST |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
535 | @return annotation length |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
536 | @rtype = int |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
537 | """ |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
538 | if AstUtilities.isString(annotationNode): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
539 | try: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
540 | annotationNode = ast.parse(annotationNode.s).body[0].value |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
541 | except (SyntaxError, IndexError): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
542 | return 0 |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
543 | if isinstance(annotationNode, ast.Subscript): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
544 | try: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
545 | if sys.version_info >= (3, 9): |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
546 | return len(annotationNode.slice.elts) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
547 | else: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
548 | return len(annotationNode.slice.value.elts) |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
549 | except AttributeError: |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
550 | return 0 |
ed8cb108b27b
Code Style Checker: reworked the type annotations checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8236
diff
changeset
|
551 | return 0 |
8773
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
552 | |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
553 | ####################################################################### |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
554 | ## 'from __future__ import annotations' checck |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
555 | ## |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
556 | ## adapted from: flake8-future-annotations v0.0.4 |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
557 | ####################################################################### |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
558 | |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
559 | def __checkAnnotationsFuture(self): |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
560 | """ |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
561 | Private method to check the use of __future__ and typing imports. |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
562 | """ |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
563 | from .AnnotationsFutureVisitor import AnnotationsFutureVisitor |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
564 | visitor = AnnotationsFutureVisitor() |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
565 | visitor.visit(self.__tree) |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
566 | |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
567 | if ( |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
568 | visitor.importsFutureAnnotations() or |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
569 | not visitor.hasTypingImports() |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
570 | ): |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
571 | return |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
572 | |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
573 | imports = ", ".join(visitor.getTypingImports()) |
3dd81b827455
Extended the annotations checker to check for missing 'from __future__ import annotations'.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
574 | self.__error(0, 0, "A871", imports) |