Tue, 18 Oct 2022 16:06:21 +0200
Changed the eric7 import statements to include the package name (i.e. eric7) in order to not fiddle with sys.path.
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
8881
54e42bc2437a
Updated copyright for 2022.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8759
diff
changeset
|
3 | # Copyright (c) 2015 - 2022 Detlev Offenbach <detlev@die-offenbachs.de> |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
10 | import ast |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
11 | import builtins |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
12 | import contextlib |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
13 | import copy |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
14 | import itertools |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
15 | import re |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16 | import sys |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
17 | import tokenize |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
18 | from collections import defaultdict, namedtuple |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
19 | from keyword import iskeyword |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
20 | from string import Formatter |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
22 | import AstUtilities |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
23 | |
8168
bdb0258faf42
Code Style Checker: reorganized the code a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8166
diff
changeset
|
24 | from .eradicate import Eradicator |
7972
4fc11172df1b
Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7923
diff
changeset
|
25 | |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
26 | from .MiscellaneousDefaults import MiscellaneousCheckerDefaultArgs |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
27 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
28 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
29 | def composeCallPath(node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
30 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
31 | Generator function to assemble the call path of a given node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
32 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
33 | @param node node to assemble call path for |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
34 | @type ast.Node |
7988
c4c17121eff8
Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7980
diff
changeset
|
35 | @yield call path components |
c4c17121eff8
Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7980
diff
changeset
|
36 | @ytype str |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
37 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
38 | if isinstance(node, ast.Attribute): |
8205
4a0f1f896341
Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
39 | yield from composeCallPath(node.value) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
40 | yield node.attr |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
41 | elif isinstance(node, ast.Name): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
42 | yield node.id |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
43 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
44 | |
8207
d359172d11be
Applied some more code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
45 | class MiscellaneousChecker: |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47 | Class implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
49 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50 | Codes = [ |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
51 | ## Coding line |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
52 | "M101", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
53 | "M102", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
54 | ## Copyright |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
55 | "M111", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
56 | "M112", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
57 | ## Shadowed Builtins |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
58 | "M131", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
59 | "M132", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
60 | ## Comprehensions |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
61 | "M181", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
62 | "M182", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
63 | "M183", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
64 | "M184", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
65 | "M185", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
66 | "M186", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
67 | "M187", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
68 | "M188", |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
69 | "M189", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
70 | "M191", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
71 | "M192", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
72 | "M193", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
73 | "M195", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
74 | "M196", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
75 | "M197", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
76 | "M198", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
77 | ## Dictionaries with sorted keys |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
78 | "M201", |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
79 | ## Naive datetime usage |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
80 | "M301", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
81 | "M302", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
82 | "M303", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
83 | "M304", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
84 | "M305", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
85 | "M306", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
86 | "M307", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
87 | "M308", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
88 | "M311", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
89 | "M312", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
90 | "M313", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
91 | "M314", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
92 | "M315", |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
93 | "M321", |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
94 | ## sys.version and sys.version_info usage |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
95 | "M401", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
96 | "M402", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
97 | "M403", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
98 | "M411", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
99 | "M412", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
100 | "M413", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
101 | "M414", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
102 | "M421", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
103 | "M422", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
104 | "M423", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
105 | ## Bugbear |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
106 | "M501", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
107 | "M502", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
108 | "M503", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
109 | "M504", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
110 | "M505", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
111 | "M507", |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
112 | "M509", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
113 | "M510", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
114 | "M511", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
115 | "M512", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
116 | "M513", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
117 | "M514", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
118 | "M515", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
119 | "M516", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
120 | "M517", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
121 | "M518", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
122 | "M519", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
123 | "M520", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
124 | "M521", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
125 | "M522", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
126 | "M523", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
127 | "M524", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
128 | "M525", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
129 | ## Bugbear++ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
130 | "M581", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
131 | "M582", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
132 | ## Format Strings |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
133 | "M601", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
134 | "M611", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
135 | "M612", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
136 | "M613", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
137 | "M621", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
138 | "M622", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
139 | "M623", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
140 | "M624", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
141 | "M625", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
142 | "M631", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
143 | "M632", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
144 | ## Logging |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
145 | "M651", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
146 | "M652", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
147 | "M653", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
148 | "M654", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
149 | "M655", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
150 | ## Future statements |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
151 | "M701", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
152 | "M702", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
153 | ## Gettext |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
154 | "M711", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
155 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156 | "M801", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
157 | ## one element tuple |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
158 | "M811", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
159 | ## Mutable Defaults |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
160 | "M821", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
161 | "M822", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
162 | ## return statements |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
163 | "M831", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
164 | "M832", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
165 | "M833", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
166 | "M834", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
167 | ## line continuation |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
168 | "M841", |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
169 | ## commented code |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
170 | "M891", |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
171 | ] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
172 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
173 | Formatter = Formatter() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
174 | FormatFieldRegex = re.compile(r"^((?:\s|.)*?)(\..*|\[.*\])?$") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
175 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
176 | BuiltinsWhiteList = [ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
177 | "__name__", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
178 | "__doc__", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
179 | "credits", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
180 | ] |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
181 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
182 | def __init__(self, source, filename, tree, select, ignore, expected, repeat, args): |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
183 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
184 | Constructor |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
185 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
186 | @param source source code to be checked |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
187 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
188 | @param filename name of the source file |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
189 | @type str |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
190 | @param tree AST tree of the source code |
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
191 | @type ast.Module |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
192 | @param select list of selected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
193 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
194 | @param ignore list of codes to be ignored |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
195 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
196 | @param expected list of expected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
197 | @type list of str |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
198 | @param repeat flag indicating to report each occurrence of a code |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
199 | @type bool |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
200 | @param args dictionary of arguments for the miscellaneous checks |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
201 | @type dict |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203 | self.__select = tuple(select) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
204 | self.__ignore = ("",) if select else tuple(ignore) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
205 | self.__expected = expected[:] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
206 | self.__repeat = repeat |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
207 | self.__filename = filename |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
208 | self.__source = source[:] |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
209 | self.__tree = copy.deepcopy(tree) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
210 | self.__args = args |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
211 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
212 | self.__pep3101FormatRegex = re.compile( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
213 | r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%' |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
214 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
215 | |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
216 | import builtins |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
217 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
218 | self.__builtins = [b for b in dir(builtins) if b not in self.BuiltinsWhiteList] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
219 | |
7972
4fc11172df1b
Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7923
diff
changeset
|
220 | self.__eradicator = Eradicator() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
221 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
222 | # statistics counters |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
223 | self.counters = {} |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
224 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
225 | # collection of detected errors |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
226 | self.errors = [] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
227 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
228 | checkersWithCodes = [ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
229 | (self.__checkCoding, ("M101", "M102")), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
230 | (self.__checkCopyright, ("M111", "M112")), |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
231 | (self.__checkBuiltins, ("M131", "M132")), |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
232 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
233 | self.__checkComprehensions, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
234 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
235 | "M181", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
236 | "M182", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
237 | "M183", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
238 | "M184", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
239 | "M185", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
240 | "M186", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
241 | "M187", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
242 | "M188", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
243 | "M189", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
244 | "M191", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
245 | "M192", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
246 | "M193", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
247 | "M195", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
248 | "M196", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
249 | "M197", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
250 | "M198", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
251 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
252 | ), |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
253 | (self.__checkDictWithSortedKeys, ("M201",)), |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
254 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
255 | self.__checkDateTime, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
256 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
257 | "M301", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
258 | "M302", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
259 | "M303", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
260 | "M304", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
261 | "M305", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
262 | "M306", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
263 | "M307", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
264 | "M308", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
265 | "M311", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
266 | "M312", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
267 | "M313", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
268 | "M314", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
269 | "M315", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
270 | "M321", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
271 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
272 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
273 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
274 | self.__checkSysVersion, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
275 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
276 | "M401", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
277 | "M402", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
278 | "M403", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
279 | "M411", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
280 | "M412", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
281 | "M413", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
282 | "M414", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
283 | "M421", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
284 | "M422", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
285 | "M423", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
286 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
287 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
288 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
289 | self.__checkBugBear, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
290 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
291 | "M501", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
292 | "M502", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
293 | "M503", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
294 | "M504", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
295 | "M505", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
296 | "M507", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
297 | "M509", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
298 | "M510", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
299 | "M511", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
300 | "M512", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
301 | "M513", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
302 | "M514", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
303 | "M515", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
304 | "M516", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
305 | "M517", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
306 | "M518", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
307 | "M519", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
308 | "M520", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
309 | "M521", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
310 | "M522", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
311 | "M523", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
312 | "M524", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
313 | "M525", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
314 | "M581", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
315 | "M582", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
316 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
317 | ), |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
318 | (self.__checkPep3101, ("M601",)), |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
319 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
320 | self.__checkFormatString, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
321 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
322 | "M611", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
323 | "M612", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
324 | "M613", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
325 | "M621", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
326 | "M622", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
327 | "M623", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
328 | "M624", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
329 | "M625", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
330 | "M631", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
331 | "M632", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
332 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
333 | ), |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
334 | (self.__checkLogging, ("M651", "M652", "M653", "M654", "M655")), |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
335 | (self.__checkFuture, ("M701", "M702")), |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
336 | (self.__checkGettext, ("M711",)), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
337 | (self.__checkPrintStatements, ("M801",)), |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
338 | (self.__checkTuple, ("M811",)), |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
339 | (self.__checkMutableDefault, ("M821", "M822")), |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
340 | (self.__checkReturn, ("M831", "M832", "M833", "M834")), |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
341 | (self.__checkLineContinuation, ("M841",)), |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
342 | (self.__checkCommentedCode, ("M891",)), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
343 | ] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
344 | |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
345 | # the eradicate whitelist |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
346 | commentedCodeCheckerArgs = self.__args.get( |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
347 | "CommentedCodeChecker", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
348 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
349 | ) |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
350 | commentedCodeCheckerWhitelist = commentedCodeCheckerArgs.get( |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
351 | "WhiteList", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
352 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["WhiteList"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
353 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
354 | self.__eradicator.update_whitelist( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
355 | commentedCodeCheckerWhitelist, extend_default=False |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
356 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
357 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
358 | self.__checkers = [] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
359 | for checker, codes in checkersWithCodes: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
360 | if any(not (code and self.__ignoreCode(code)) for code in codes): |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
361 | self.__checkers.append(checker) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
362 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
363 | def __ignoreCode(self, code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
364 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
365 | Private method to check if the message code should be ignored. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
366 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
367 | @param code message code to check for |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
368 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
369 | @return flag indicating to ignore the given code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
370 | @rtype bool |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
371 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
372 | return code.startswith(self.__ignore) and not code.startswith(self.__select) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
373 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
374 | def __error(self, lineNumber, offset, code, *args): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
375 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
376 | Private method to record an issue. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
377 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
378 | @param lineNumber line number of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
379 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
380 | @param offset position within line of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
381 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
382 | @param code message code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
383 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
384 | @param args arguments for the message |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
385 | @type list |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
386 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
387 | if self.__ignoreCode(code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
388 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
389 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
390 | if code in self.counters: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
391 | self.counters[code] += 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
392 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
393 | self.counters[code] = 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
394 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
395 | # Don't care about expected codes |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
396 | if code in self.__expected: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
397 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
398 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
399 | if code and (self.counters[code] == 1 or self.__repeat): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
400 | # record the issue with one based line number |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
401 | self.errors.append( |
7610
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
402 | { |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
403 | "file": self.__filename, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
404 | "line": lineNumber + 1, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
405 | "offset": offset, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
406 | "code": code, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
407 | "args": args, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
408 | } |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
409 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
410 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
411 | def run(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
412 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
413 | Public method to check the given source against miscellaneous |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
414 | conditions. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
415 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
416 | if not self.__filename: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
417 | # don't do anything, if essential data is missing |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
418 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
419 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
420 | if not self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
421 | # don't do anything, if no codes were selected |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
422 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
423 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
424 | for check in self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
425 | check() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
426 | |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
427 | def __getCoding(self): |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
428 | """ |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
429 | Private method to get the defined coding of the source. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
430 | |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
431 | @return tuple containing the line number and the coding |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
432 | @rtype tuple of int and str |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
433 | """ |
6106
921d070cec82
Finished implementing support for EditorConfig.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6100
diff
changeset
|
434 | for lineno, line in enumerate(self.__source[:5]): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
435 | matched = re.search(r"coding[:=]\s*([-\w_.]+)", line, re.IGNORECASE) |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
436 | if matched: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
437 | return lineno, matched.group(1) |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
438 | else: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
439 | return 0, "" |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
440 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
441 | def __checkCoding(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
442 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
443 | Private method to check the presence of a coding line and valid |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
444 | encodings. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
445 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
446 | if len(self.__source) == 0: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
447 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
448 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
449 | encodings = [ |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
450 | e.lower().strip() |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
451 | for e in self.__args.get( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
452 | "CodingChecker", MiscellaneousCheckerDefaultArgs["CodingChecker"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
453 | ).split(",") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
454 | ] |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
455 | lineno, coding = self.__getCoding() |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
456 | if coding: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
457 | if coding.lower() not in encodings: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
458 | self.__error(lineno, 0, "M102", coding) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
459 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
460 | self.__error(0, 0, "M101") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
461 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
462 | def __checkCopyright(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
463 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
464 | Private method to check the presence of a copyright statement. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
465 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
466 | source = "".join(self.__source) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
467 | copyrightArgs = self.__args.get( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
468 | "CopyrightChecker", MiscellaneousCheckerDefaultArgs["CopyrightChecker"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
469 | ) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
470 | copyrightMinFileSize = copyrightArgs.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
471 | "MinFilesize", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
472 | MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["MinFilesize"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
473 | ) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
474 | copyrightAuthor = copyrightArgs.get( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
475 | "Author", MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["Author"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
476 | ) |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
477 | copyrightRegexStr = ( |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
478 | r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}" |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
479 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
480 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
481 | tocheck = max(1024, copyrightMinFileSize) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
482 | topOfSource = source[:tocheck] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
483 | if len(topOfSource) < copyrightMinFileSize: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
484 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
485 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
486 | copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"), re.IGNORECASE) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
487 | if not copyrightRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
488 | self.__error(0, 0, "M111") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
489 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
490 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
491 | if copyrightAuthor: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
492 | copyrightAuthorRe = re.compile( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
493 | copyrightRegexStr.format(author=copyrightAuthor), re.IGNORECASE |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
494 | ) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
495 | if not copyrightAuthorRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
496 | self.__error(0, 0, "M112") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
497 | |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
498 | def __checkCommentedCode(self): |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
499 | """ |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
500 | Private method to check for commented code. |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
501 | """ |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
502 | source = "".join(self.__source) |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
503 | commentedCodeCheckerArgs = self.__args.get( |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
504 | "CommentedCodeChecker", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
505 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
506 | ) |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
507 | aggressive = commentedCodeCheckerArgs.get( |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
508 | "Aggressive", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
509 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["Aggressive"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
510 | ) |
7972
4fc11172df1b
Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7923
diff
changeset
|
511 | for markedLine in self.__eradicator.commented_out_code_line_numbers( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
512 | source, aggressive=aggressive |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
513 | ): |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
514 | self.__error(markedLine - 1, 0, "M891") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
515 | |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
516 | def __checkLineContinuation(self): |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
517 | """ |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
518 | Private method to check line continuation using backslash. |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
519 | """ |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
520 | # generate source lines without comments |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
521 | linesIterator = iter(self.__source) |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
522 | tokens = tokenize.generate_tokens(lambda: next(linesIterator)) |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
523 | comments = [token for token in tokens if token[0] == tokenize.COMMENT] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
524 | stripped = self.__source[:] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
525 | for comment in comments: |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
526 | lineno = comment[3][0] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
527 | start = comment[2][1] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
528 | stop = comment[3][1] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
529 | content = stripped[lineno - 1] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
530 | withoutComment = content[:start] + content[stop:] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
531 | stripped[lineno - 1] = withoutComment.rstrip() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
532 | |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
533 | # perform check with 'cleaned' source |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
534 | for lineIndex, line in enumerate(stripped): |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
535 | strippedLine = line.strip() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
536 | if strippedLine.endswith("\\") and not strippedLine.startswith( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
537 | ("assert", "with") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
538 | ): |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
539 | self.__error(lineIndex, len(line), "M841") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
540 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
541 | def __checkPrintStatements(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
542 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
543 | Private method to check for print statements. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
544 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
545 | for node in ast.walk(self.__tree): |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
546 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
547 | isinstance(node, ast.Call) and getattr(node.func, "id", None) == "print" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
548 | ) or (hasattr(ast, "Print") and isinstance(node, ast.Print)): |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
549 | self.__error(node.lineno - 1, node.col_offset, "M801") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
550 | |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
551 | def __checkTuple(self): |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
552 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
553 | Private method to check for one element tuples. |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
554 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
555 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
556 | if isinstance(node, ast.Tuple) and len(node.elts) == 1: |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
557 | self.__error(node.lineno - 1, node.col_offset, "M811") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
558 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
559 | def __checkFuture(self): |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
560 | """ |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
561 | Private method to check the __future__ imports. |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
562 | """ |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
563 | expectedImports = { |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
564 | i.strip() |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
565 | for i in self.__args.get("FutureChecker", "").split(",") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
566 | if bool(i.strip()) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
567 | } |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
568 | if len(expectedImports) == 0: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
569 | # nothing to check for; disabling the check |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
570 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
571 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
572 | imports = set() |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
573 | node = None |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
574 | hasCode = False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
575 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
576 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
577 | if isinstance(node, ast.ImportFrom) and node.module == "__future__": |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
578 | imports |= {name.name for name in node.names} |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
579 | elif isinstance(node, ast.Expr): |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
580 | if not AstUtilities.isString(node.value): |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
581 | hasCode = True |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
582 | break |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
583 | elif not (AstUtilities.isString(node) or isinstance(node, ast.Module)): |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
584 | hasCode = True |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
585 | break |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
586 | |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
587 | if isinstance(node, ast.Module) or not hasCode: |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
588 | return |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
589 | |
8205
4a0f1f896341
Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
590 | if imports < expectedImports: |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
591 | if imports: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
592 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
593 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
594 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
595 | "M701", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
596 | ", ".join(expectedImports), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
597 | ", ".join(imports), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
598 | ) |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
599 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
600 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
601 | node.lineno - 1, node.col_offset, "M702", ", ".join(expectedImports) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
602 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
603 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
604 | def __checkPep3101(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
605 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
606 | Private method to check for old style string formatting. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
607 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
608 | for lineno, line in enumerate(self.__source): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
609 | match = self.__pep3101FormatRegex.search(line) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
610 | if match: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
611 | lineLen = len(line) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
612 | pos = line.find("%") |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
613 | formatPos = pos |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
614 | formatter = "%" |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
615 | if line[pos + 1] == "(": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
616 | pos = line.find(")", pos) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
617 | c = line[pos] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
618 | while c not in "diouxXeEfFgGcrs": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
619 | pos += 1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
620 | if pos >= lineLen: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
621 | break |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
622 | c = line[pos] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
623 | if c in "diouxXeEfFgGcrs": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
624 | formatter += c |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
625 | self.__error(lineno, formatPos, "M601", formatter) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
626 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
627 | def __checkFormatString(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
628 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
629 | Private method to check string format strings. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
630 | """ |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
631 | coding = self.__getCoding()[1] |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
632 | if not coding: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
633 | # default to utf-8 |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
634 | coding = "utf-8" |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
635 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
636 | visitor = TextVisitor() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
637 | visitor.visit(self.__tree) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
638 | for node in visitor.nodes: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
639 | text = node.s |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
640 | if isinstance(text, bytes): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
641 | try: |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
642 | text = text.decode(coding) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
643 | except UnicodeDecodeError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
644 | continue |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
645 | fields, implicit, explicit = self.__getFields(text) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
646 | if implicit: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
647 | if node in visitor.calls: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
648 | self.__error(node.lineno - 1, node.col_offset, "M611") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
649 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
650 | if node.is_docstring: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
651 | self.__error(node.lineno - 1, node.col_offset, "M612") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
652 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
653 | self.__error(node.lineno - 1, node.col_offset, "M613") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
654 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
655 | if node in visitor.calls: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
656 | call, strArgs = visitor.calls[node] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
657 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
658 | numbers = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
659 | names = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
660 | # Determine which fields require a keyword and which an arg |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
661 | for name in fields: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
662 | fieldMatch = self.FormatFieldRegex.match(name) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
663 | try: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
664 | number = int(fieldMatch.group(1)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
665 | except ValueError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
666 | number = -1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
667 | # negative numbers are considered keywords |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
668 | if number >= 0: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
669 | numbers.add(number) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
670 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
671 | names.add(fieldMatch.group(1)) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
672 | |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
673 | keywords = {keyword.arg for keyword in call.keywords} |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
674 | numArgs = len(call.args) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
675 | if strArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
676 | numArgs -= 1 |
7894
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
677 | hasKwArgs = any(kw.arg is None for kw in call.keywords) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
678 | hasStarArgs = sum( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
679 | 1 for arg in call.args if isinstance(arg, ast.Starred) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
680 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
681 | |
7894
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
682 | if hasKwArgs: |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
683 | keywords.discard(None) |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
684 | if hasStarArgs: |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
685 | numArgs -= 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
686 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
687 | # if starargs or kwargs is not None, it can't count the |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
688 | # parameters but at least check if the args are used |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
689 | if hasKwArgs and not names: |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
690 | # No names but kwargs |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
691 | self.__error(call.lineno - 1, call.col_offset, "M623") |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
692 | if hasStarArgs and not numbers: |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
693 | # No numbers but args |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
694 | self.__error(call.lineno - 1, call.col_offset, "M624") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
695 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
696 | if not hasKwArgs and not hasStarArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
697 | # can actually verify numbers and names |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
698 | for number in sorted(numbers): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
699 | if number >= numArgs: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
700 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
701 | call.lineno - 1, call.col_offset, "M621", number |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
702 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
703 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
704 | for name in sorted(names): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
705 | if name not in keywords: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
706 | self.__error(call.lineno - 1, call.col_offset, "M622", name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
707 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
708 | for arg in range(numArgs): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
709 | if arg not in numbers: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
710 | self.__error(call.lineno - 1, call.col_offset, "M631", arg) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
711 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
712 | for keyword in keywords: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
713 | if keyword not in names: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
714 | self.__error(call.lineno - 1, call.col_offset, "M632", keyword) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
715 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
716 | if implicit and explicit: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
717 | self.__error(call.lineno - 1, call.col_offset, "M625") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
718 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
719 | def __getFields(self, string): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
720 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
721 | Private method to extract the format field information. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
722 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
723 | @param string format string to be parsed |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
724 | @type str |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
725 | @return format field information as a tuple with fields, implicit |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
726 | field definitions present and explicit field definitions present |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
727 | @rtype tuple of set of str, bool, bool |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
728 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
729 | fields = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
730 | cnt = itertools.count() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
731 | implicit = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
732 | explicit = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
733 | try: |
6188
5a6ae3be31e6
Fixed some loop related coding issues detected by the extended code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6184
diff
changeset
|
734 | for _literal, field, spec, conv in self.Formatter.parse(string): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
735 | if field is not None and (conv is None or conv in "rsa"): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
736 | if not field: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
737 | field = str(next(cnt)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
738 | implicit = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
739 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
740 | explicit = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
741 | fields.add(field) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
742 | fields.update( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
743 | parsedSpec[1] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
744 | for parsedSpec in self.Formatter.parse(spec) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
745 | if parsedSpec[1] is not None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
746 | ) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
747 | except ValueError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
748 | return set(), False, False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
749 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
750 | return fields, implicit, explicit |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
751 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
752 | def __checkBuiltins(self): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
753 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
754 | Private method to check, if built-ins are shadowed. |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
755 | """ |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
756 | functionDefs = [ast.FunctionDef] |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
757 | with contextlib.suppress(AttributeError): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
758 | functionDefs.append(ast.AsyncFunctionDef) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
759 | |
5619
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
760 | ignoreBuiltinAssignments = self.__args.get( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
761 | "BuiltinsChecker", MiscellaneousCheckerDefaultArgs["BuiltinsChecker"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
762 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
763 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
764 | for node in ast.walk(self.__tree): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
765 | if isinstance(node, ast.Assign): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
766 | # assign statement |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
767 | for element in node.targets: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
768 | if isinstance(element, ast.Name) and element.id in self.__builtins: |
5617
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
769 | value = node.value |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
770 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
771 | isinstance(value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
772 | and element.id in ignoreBuiltinAssignments |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
773 | and value.id in ignoreBuiltinAssignments[element.id] |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
774 | ): |
5617
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
775 | # ignore compatibility assignments |
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
776 | continue |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
777 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
778 | element.lineno - 1, element.col_offset, "M131", element.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
779 | ) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
780 | elif isinstance(element, (ast.Tuple, ast.List)): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
781 | for tupleElement in element.elts: |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
782 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
783 | isinstance(tupleElement, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
784 | and tupleElement.id in self.__builtins |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
785 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
786 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
787 | tupleElement.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
788 | tupleElement.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
789 | "M131", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
790 | tupleElement.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
791 | ) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
792 | elif isinstance(node, ast.For): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
793 | # for loop |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
794 | target = node.target |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
795 | if isinstance(target, ast.Name) and target.id in self.__builtins: |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
796 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
797 | target.lineno - 1, target.col_offset, "M131", target.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
798 | ) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
799 | elif isinstance(target, (ast.Tuple, ast.List)): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
800 | for element in target.elts: |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
801 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
802 | isinstance(element, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
803 | and element.id in self.__builtins |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
804 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
805 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
806 | element.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
807 | element.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
808 | "M131", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
809 | element.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
810 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
811 | elif any(isinstance(node, functionDef) for functionDef in functionDefs): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
812 | # (asynchronous) function definition |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
813 | for arg in node.args.args: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
814 | if isinstance(arg, ast.arg) and arg.arg in self.__builtins: |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
815 | self.__error(arg.lineno - 1, arg.col_offset, "M132", arg.arg) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
816 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
817 | def __checkComprehensions(self): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
818 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
819 | Private method to check some comprehension related things. |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
820 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
821 | for node in ast.walk(self.__tree): |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
822 | if isinstance(node, ast.Call) and isinstance(node.func, ast.Name): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
823 | nArgs = len(node.args) |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
824 | nKwArgs = len(node.keywords) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
825 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
826 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
827 | nArgs == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
828 | and isinstance(node.args[0], ast.GeneratorExp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
829 | and node.func.id in ("list", "set") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
830 | ): |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
831 | errorCode = { |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
832 | "list": "M181", |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
833 | "set": "M182", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
834 | }[node.func.id] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
835 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
836 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
837 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
838 | nArgs == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
839 | and isinstance(node.args[0], (ast.GeneratorExp, ast.ListComp)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
840 | and isinstance(node.args[0].elt, ast.Tuple) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
841 | and len(node.args[0].elt.elts) == 2 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
842 | and node.func.id == "dict" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
843 | ): |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
844 | if isinstance(node.args[0], ast.GeneratorExp): |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
845 | errorCode = "M183" |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
846 | else: |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
847 | errorCode = "M185" |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
848 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
849 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
850 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
851 | nArgs == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
852 | and isinstance(node.args[0], ast.ListComp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
853 | and node.func.id in ("list", "set") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
854 | ): |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
855 | errorCode = { |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
856 | "list": "M195", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
857 | "set": "M184", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
858 | }[node.func.id] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
859 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
860 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
861 | elif nArgs == 1 and ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
862 | isinstance(node.args[0], ast.Tuple) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
863 | and node.func.id == "tuple" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
864 | or isinstance(node.args[0], ast.List) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
865 | and node.func.id == "list" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
866 | ): |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
867 | errorCode = { |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
868 | "tuple": "M197", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
869 | "list": "M198", |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
870 | }[node.func.id] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
871 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
872 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
873 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
874 | errorCode, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
875 | type(node.args[0]).__name__.lower(), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
876 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
877 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
878 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
879 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
880 | nArgs == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
881 | and isinstance(node.args[0], (ast.Tuple, ast.List)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
882 | and node.func.id in ("tuple", "list", "set", "dict") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
883 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
884 | errorCode = { |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
885 | "tuple": "M192", |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
886 | "list": "M193", |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
887 | "set": "M191", |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
888 | "dict": "M191", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
889 | }[node.func.id] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
890 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
891 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
892 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
893 | errorCode, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
894 | type(node.args[0]).__name__.lower(), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
895 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
896 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
897 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
898 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
899 | nArgs == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
900 | and not any(isinstance(a, ast.Starred) for a in node.args) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
901 | and not any(k.arg is None for k in node.keywords) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
902 | and node.func.id == "dict" |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
903 | ) or ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
904 | nArgs == 0 and nKwArgs == 0 and node.func.id in ("tuple", "list") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
905 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
906 | self.__error(node.lineno - 1, node.col_offset, "M186", node.func.id) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
907 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
908 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
909 | node.func.id in {"list", "reversed"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
910 | and nArgs > 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
911 | and isinstance(node.args[0], ast.Call) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
912 | and isinstance(node.args[0].func, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
913 | and node.args[0].func.id == "sorted" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
914 | ): |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
915 | if node.func.id == "reversed": |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
916 | reverseFlagValue = False |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
917 | for kw in node.args[0].keywords: |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
918 | if kw.arg != "reverse": |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
919 | continue |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
920 | if isinstance(kw.value, ast.NameConstant): |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
921 | reverseFlagValue = kw.value.value |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
922 | elif isinstance(kw.value, ast.Num): |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
923 | reverseFlagValue = bool(kw.value.n) |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
924 | else: |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
925 | # Complex value |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
926 | reverseFlagValue = None |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
927 | |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
928 | if reverseFlagValue is None: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
929 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
930 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
931 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
932 | "M187a", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
933 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
934 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
935 | ) |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
936 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
937 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
938 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
939 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
940 | "M187b", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
941 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
942 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
943 | not reverseFlagValue, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
944 | ) |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
945 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
946 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
947 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
948 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
949 | "M187c", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
950 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
951 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
952 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
953 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
954 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
955 | nArgs > 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
956 | and isinstance(node.args[0], ast.Call) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
957 | and isinstance(node.args[0].func, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
958 | and ( |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
959 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
960 | node.func.id in {"set", "sorted"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
961 | and node.args[0].func.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
962 | in {"list", "reversed", "sorted", "tuple"} |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
963 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
964 | or ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
965 | node.func.id in {"list", "tuple"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
966 | and node.args[0].func.id in {"list", "tuple"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
967 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
968 | or (node.func.id == "set" and node.args[0].func.id == "set") |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
969 | ) |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
970 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
971 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
972 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
973 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
974 | "M188", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
975 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
976 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
977 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
978 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
979 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
980 | node.func.id in {"reversed", "set", "sorted"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
981 | and nArgs > 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
982 | and isinstance(node.args[0], ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
983 | and isinstance(node.args[0].slice, ast.Slice) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
984 | and node.args[0].slice.lower is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
985 | and node.args[0].slice.upper is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
986 | and isinstance(node.args[0].slice.step, ast.UnaryOp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
987 | and isinstance(node.args[0].slice.step.op, ast.USub) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
988 | and isinstance(node.args[0].slice.step.operand, ast.Num) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
989 | and node.args[0].slice.step.operand.n == 1 |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
990 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
991 | self.__error(node.lineno - 1, node.col_offset, "M189", node.func.id) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
992 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
993 | elif isinstance(node, (ast.ListComp, ast.SetComp)) and ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
994 | len(node.generators) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
995 | and not node.generators[0].ifs |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
996 | and not node.generators[0].is_async |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
997 | and ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
998 | isinstance(node.elt, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
999 | and isinstance(node.generators[0].target, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1000 | and node.elt.id == node.generators[0].target.id |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1001 | ) |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1002 | ): |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1003 | compType = { |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1004 | ast.DictComp: "dict", |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1005 | ast.ListComp: "list", |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1006 | ast.SetComp: "set", |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1007 | }[node.__class__] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1008 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1009 | self.__error(node.lineno - 1, node.col_offset, "M196", compType) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1010 | |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1011 | def __checkMutableDefault(self): |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1012 | """ |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1013 | Private method to check for use of mutable types as default arguments. |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1014 | """ |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1015 | mutableTypes = ( |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1016 | ast.Call, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1017 | ast.Dict, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1018 | ast.List, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1019 | ast.Set, |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1020 | ast.DictComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1021 | ast.ListComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1022 | ast.SetComp, |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1023 | ) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1024 | mutableCalls = ( |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1025 | "Counter", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1026 | "OrderedDict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1027 | "collections.Counter", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1028 | "collections.OrderedDict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1029 | "collections.defaultdict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1030 | "collections.deque", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1031 | "defaultdict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1032 | "deque", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1033 | "dict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1034 | "list", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1035 | "set", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1036 | ) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1037 | immutableCalls = ( |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1038 | "tuple", |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1039 | "frozenset", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1040 | "types.MappingProxyType", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1041 | "MappingProxyType", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1042 | "re.compile", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1043 | "operator.attrgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1044 | "operator.itemgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1045 | "operator.methodcaller", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1046 | "attrgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1047 | "itemgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1048 | "methodcaller", |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1049 | ) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1050 | functionDefs = [ast.FunctionDef] |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
1051 | with contextlib.suppress(AttributeError): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1052 | functionDefs.append(ast.AsyncFunctionDef) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1053 | |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1054 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1055 | if any(isinstance(node, functionDef) for functionDef in functionDefs): |
7057
0e8d3b0c4889
MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7045
diff
changeset
|
1056 | defaults = node.args.defaults[:] |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
1057 | with contextlib.suppress(AttributeError): |
7057
0e8d3b0c4889
MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7045
diff
changeset
|
1058 | defaults += node.args.kw_defaults[:] |
0e8d3b0c4889
MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7045
diff
changeset
|
1059 | for default in defaults: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1060 | if any( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1061 | isinstance(default, mutableType) for mutableType in mutableTypes |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1062 | ): |
5703
7650c11cc5f2
MiscChecker, ast: No special case for Python 2 needed.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
5649
diff
changeset
|
1063 | typeName = type(default).__name__ |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
1064 | if isinstance(default, ast.Call): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1065 | callPath = ".".join(composeCallPath(default.func)) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1066 | if callPath in mutableCalls: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1067 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1068 | default.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1069 | default.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1070 | "M823", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1071 | callPath + "()", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1072 | ) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1073 | elif callPath not in immutableCalls: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1074 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1075 | default.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1076 | default.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1077 | "M822", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1078 | typeName, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1079 | ) |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
1080 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1081 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1082 | default.lineno - 1, default.col_offset, "M821", typeName |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1083 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1084 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1085 | def __dictShouldBeChecked(self, node): |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1086 | """ |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1087 | Private function to test, if the node should be checked. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1088 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1089 | @param node reference to the AST node |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1090 | @return flag indicating to check the node |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1091 | @rtype bool |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1092 | """ |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1093 | if not all(AstUtilities.isString(key) for key in node.keys): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1094 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1095 | |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1096 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1097 | "__IGNORE_WARNING__" in self.__source[node.lineno - 1] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1098 | or "__IGNORE_WARNING_M201__" in self.__source[node.lineno - 1] |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1099 | ): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1100 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1101 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1102 | lineNumbers = [key.lineno for key in node.keys] |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1103 | return len(lineNumbers) == len(set(lineNumbers)) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1104 | |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1105 | def __checkDictWithSortedKeys(self): |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1106 | """ |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1107 | Private method to check, if dictionary keys appear in sorted order. |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1108 | """ |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1109 | for node in ast.walk(self.__tree): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1110 | if isinstance(node, ast.Dict) and self.__dictShouldBeChecked(node): |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1111 | for key1, key2 in zip(node.keys, node.keys[1:]): |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1112 | if key2.s < key1.s: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1113 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1114 | key2.lineno - 1, key2.col_offset, "M201", key2.s, key1.s |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1115 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1116 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1117 | def __checkLogging(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1118 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1119 | Private method to check logging statements. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1120 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1121 | visitor = LoggingVisitor() |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1122 | visitor.visit(self.__tree) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1123 | for node, reason in visitor.violations: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1124 | self.__error(node.lineno - 1, node.col_offset, reason) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1125 | |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1126 | def __checkGettext(self): |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1127 | """ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1128 | Private method to check the 'gettext' import statement. |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1129 | """ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1130 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1131 | if isinstance(node, ast.ImportFrom) and any( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1132 | name.asname == "_" for name in node.names |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1133 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1134 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1135 | node.lineno - 1, node.col_offset, "M711", node.names[0].name |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1136 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1137 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1138 | def __checkBugBear(self): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1139 | """ |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1140 | Private method for bugbear checks. |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1141 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1142 | visitor = BugBearVisitor() |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1143 | visitor.visit(self.__tree) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1144 | for violation in visitor.violations: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1145 | node = violation[0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1146 | reason = violation[1] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1147 | params = violation[2:] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1148 | self.__error(node.lineno - 1, node.col_offset, reason, *params) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1149 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1150 | def __checkReturn(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1151 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1152 | Private method to check return statements. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1153 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1154 | visitor = ReturnVisitor() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1155 | visitor.visit(self.__tree) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1156 | for violation in visitor.violations: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1157 | node = violation[0] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1158 | reason = violation[1] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1159 | self.__error(node.lineno - 1, node.col_offset, reason) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1160 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1161 | def __checkDateTime(self): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1162 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1163 | Private method to check use of naive datetime functions. |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1164 | """ |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1165 | # step 1: generate an augmented node tree containing parent info |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1166 | # for each child node |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
1167 | tree = copy.deepcopy(self.__tree) |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1168 | for node in ast.walk(tree): |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1169 | for childNode in ast.iter_child_nodes(node): |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1170 | childNode._dtCheckerParent = node |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1171 | |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1172 | # step 2: perform checks and report issues |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1173 | visitor = DateTimeVisitor() |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1174 | visitor.visit(tree) |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1175 | for violation in visitor.violations: |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1176 | node = violation[0] |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1177 | reason = violation[1] |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1178 | self.__error(node.lineno - 1, node.col_offset, reason) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1179 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1180 | def __checkSysVersion(self): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1181 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1182 | Private method to check the use of sys.version and sys.version_info. |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1183 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1184 | visitor = SysVersionVisitor() |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1185 | visitor.visit(self.__tree) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1186 | for violation in visitor.violations: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1187 | node = violation[0] |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1188 | reason = violation[1] |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1189 | self.__error(node.lineno - 1, node.col_offset, reason) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1190 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1191 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1192 | class TextVisitor(ast.NodeVisitor): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1193 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1194 | Class implementing a node visitor for bytes and str instances. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1195 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1196 | It tries to detect docstrings as string of the first expression of each |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1197 | module, class or function. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1198 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1199 | |
9274
86fab0c74430
Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9221
diff
changeset
|
1200 | # modeled after the string format flake8 extension |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1201 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1202 | def __init__(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1203 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1204 | Constructor |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1205 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1206 | super().__init__() |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1207 | self.nodes = [] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1208 | self.calls = {} |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1209 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1210 | def __addNode(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1211 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1212 | Private method to add a node to our list of nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1213 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1214 | @param node reference to the node to add |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1215 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1216 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1217 | if not hasattr(node, "is_docstring"): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1218 | node.is_docstring = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1219 | self.nodes.append(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1220 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1221 | def visit_Str(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1222 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1223 | Public method to record a string node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1224 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1225 | @param node reference to the string node |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1226 | @type ast.Str |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1227 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1228 | self.__addNode(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1229 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1230 | def visit_Bytes(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1231 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1232 | Public method to record a bytes node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1233 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1234 | @param node reference to the bytes node |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1235 | @type ast.Bytes |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1236 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1237 | self.__addNode(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1238 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1239 | def visit_Constant(self, node): |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1240 | """ |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1241 | Public method to handle constant nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1242 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1243 | @param node reference to the bytes node |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1244 | @type ast.Constant |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1245 | """ |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1246 | if sys.version_info >= (3, 8, 0): |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1247 | if AstUtilities.isBaseString(node): |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1248 | self.__addNode(node) |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1249 | else: |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1250 | super().generic_visit(node) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1251 | else: |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1252 | super().generic_visit(node) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1253 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1254 | def __visitDefinition(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1255 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1256 | Private method handling class and function definitions. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1257 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1258 | @param node reference to the node to handle |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1259 | @type ast.FunctionDef, ast.AsyncFunctionDef or ast.ClassDef |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1260 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1261 | # Manually traverse class or function definition |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1262 | # * Handle decorators normally |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1263 | # * Use special check for body content |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1264 | # * Don't handle the rest (e.g. bases) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1265 | for decorator in node.decorator_list: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1266 | self.visit(decorator) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1267 | self.__visitBody(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1268 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1269 | def __visitBody(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1270 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1271 | Private method to traverse the body of the node manually. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1272 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1273 | If the first node is an expression which contains a string or bytes it |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1274 | marks that as a docstring. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1275 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1276 | @param node reference to the node to traverse |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1277 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1278 | """ |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1279 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1280 | node.body |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1281 | and isinstance(node.body[0], ast.Expr) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1282 | and AstUtilities.isBaseString(node.body[0].value) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1283 | ): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1284 | node.body[0].value.is_docstring = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1285 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1286 | for subnode in node.body: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1287 | self.visit(subnode) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1288 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1289 | def visit_Module(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1290 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1291 | Public method to handle a module. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1292 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1293 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1294 | @type ast.Module |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1295 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1296 | self.__visitBody(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1297 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1298 | def visit_ClassDef(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1299 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1300 | Public method to handle a class definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1301 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1302 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1303 | @type ast.ClassDef |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1304 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1305 | # Skipped nodes: ('name', 'bases', 'keywords', 'starargs', 'kwargs') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1306 | self.__visitDefinition(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1307 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1308 | def visit_FunctionDef(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1309 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1310 | Public method to handle a function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1311 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1312 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1313 | @type ast.FunctionDef |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1314 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1315 | # Skipped nodes: ('name', 'args', 'returns') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1316 | self.__visitDefinition(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1317 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1318 | def visit_AsyncFunctionDef(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1319 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1320 | Public method to handle an asynchronous function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1321 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1322 | @param node reference to the node to handle |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1323 | @type ast.AsyncFunctionDef |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1324 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1325 | # Skipped nodes: ('name', 'args', 'returns') |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1326 | self.__visitDefinition(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1327 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1328 | def visit_Call(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1329 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1330 | Public method to handle a function call. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1331 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1332 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1333 | @type ast.Call |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1334 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1335 | if isinstance(node.func, ast.Attribute) and node.func.attr == "format": |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1336 | if AstUtilities.isBaseString(node.func.value): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1337 | self.calls[node.func.value] = (node, False) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1338 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1339 | isinstance(node.func.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1340 | and node.func.value.id == "str" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1341 | and node.args |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1342 | and AstUtilities.isBaseString(node.args[0]) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1343 | ): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1344 | self.calls[node.args[0]] = (node, True) |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1345 | super().generic_visit(node) |
4555
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
1346 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1347 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1348 | class LoggingVisitor(ast.NodeVisitor): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1349 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1350 | Class implementing a node visitor to check logging statements. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1351 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1352 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1353 | LoggingLevels = { |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1354 | "debug", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1355 | "critical", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1356 | "error", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1357 | "info", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1358 | "warn", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1359 | "warning", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1360 | } |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1361 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1362 | def __init__(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1363 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1364 | Constructor |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1365 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1366 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1367 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1368 | self.__currentLoggingCall = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1369 | self.__currentLoggingArgument = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1370 | self.__currentLoggingLevel = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1371 | self.__currentExtraKeyword = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1372 | self.violations = [] |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1373 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1374 | def __withinLoggingStatement(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1375 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1376 | Private method to check, if we are inside a logging statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1377 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1378 | @return flag indicating we are inside a logging statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1379 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1380 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1381 | return self.__currentLoggingCall is not None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1382 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1383 | def __withinLoggingArgument(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1384 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1385 | Private method to check, if we are inside a logging argument. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1386 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1387 | @return flag indicating we are inside a logging argument |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1388 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1389 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1390 | return self.__currentLoggingArgument is not None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1391 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1392 | def __withinExtraKeyword(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1393 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1394 | Private method to check, if we are inside the extra keyword. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1395 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1396 | @param node reference to the node to be checked |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1397 | @type ast.keyword |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1398 | @return flag indicating we are inside the extra keyword |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1399 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1400 | """ |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1401 | return ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1402 | self.__currentExtraKeyword is not None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1403 | and self.__currentExtraKeyword != node |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1404 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1405 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1406 | def __detectLoggingLevel(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1407 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1408 | Private method to decide whether an AST Call is a logging call. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1409 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1410 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1411 | @type ast.Call |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1412 | @return logging level |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1413 | @rtype str or None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1414 | """ |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
1415 | with contextlib.suppress(AttributeError): |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1416 | if node.func.value.id == "warnings": |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1417 | return None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1418 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1419 | if node.func.attr in LoggingVisitor.LoggingLevels: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1420 | return node.func.attr |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1421 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1422 | return None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1423 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1424 | def __isFormatCall(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1425 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1426 | Private method to check if a function call uses format. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1427 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1428 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1429 | @type ast.Call |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1430 | @return flag indicating the function call uses format |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1431 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1432 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1433 | try: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1434 | return node.func.attr == "format" |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1435 | except AttributeError: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1436 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1437 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1438 | def visit_Call(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1439 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1440 | Public method to handle a function call. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1441 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1442 | Every logging statement and string format is expected to be a function |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1443 | call. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1444 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1445 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1446 | @type ast.Call |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1447 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1448 | # we are in a logging statement |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1449 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1450 | self.__withinLoggingStatement() |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1451 | and self.__withinLoggingArgument() |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1452 | and self.__isFormatCall(node) |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1453 | ): |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1454 | self.violations.append((node, "M651")) |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1455 | super().generic_visit(node) |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1456 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1457 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1458 | loggingLevel = self.__detectLoggingLevel(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1459 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1460 | if loggingLevel and self.__currentLoggingLevel is None: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1461 | self.__currentLoggingLevel = loggingLevel |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1462 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1463 | # we are in some other statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1464 | if loggingLevel is None: |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1465 | super().generic_visit(node) |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1466 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1467 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1468 | # we are entering a new logging statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1469 | self.__currentLoggingCall = node |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1470 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1471 | if loggingLevel == "warn": |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1472 | self.violations.append((node, "M655")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1473 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1474 | for index, child in enumerate(ast.iter_child_nodes(node)): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1475 | if index == 1: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1476 | self.__currentLoggingArgument = child |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1477 | if index > 1 and isinstance(child, ast.keyword) and child.arg == "extra": |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1478 | self.__currentExtraKeyword = child |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1479 | |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1480 | super().visit(child) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1481 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1482 | self.__currentLoggingArgument = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1483 | self.__currentExtraKeyword = None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1484 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1485 | self.__currentLoggingCall = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1486 | self.__currentLoggingLevel = None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1487 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1488 | def visit_BinOp(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1489 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1490 | Public method to handle binary operations while processing the first |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1491 | logging argument. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1492 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1493 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1494 | @type ast.BinOp |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1495 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1496 | if self.__withinLoggingStatement() and self.__withinLoggingArgument(): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1497 | # handle percent format |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1498 | if isinstance(node.op, ast.Mod): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1499 | self.violations.append((node, "M652")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1500 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1501 | # handle string concat |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1502 | if isinstance(node.op, ast.Add): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1503 | self.violations.append((node, "M653")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1504 | |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1505 | super().generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1506 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1507 | def visit_JoinedStr(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1508 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1509 | Public method to handle f-string arguments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1510 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1511 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1512 | @type ast.JoinedStr |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1513 | """ |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1514 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1515 | self.__withinLoggingStatement() |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1516 | and any(isinstance(i, ast.FormattedValue) for i in node.values) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1517 | and self.__withinLoggingArgument() |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1518 | ): |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1519 | self.violations.append((node, "M654")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1520 | |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
1521 | super().generic_visit(node) |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1522 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1523 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1524 | BugBearContext = namedtuple("BugBearContext", ["node", "stack"]) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1525 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1526 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1527 | class BugBearVisitor(ast.NodeVisitor): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1528 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1529 | Class implementing a node visitor to check for various topics. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1530 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1531 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1532 | # |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1533 | # This class was implemented along the BugBear flake8 extension (v 22.9.11). |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1534 | # Original: Copyright (c) 2016 Łukasz Langa |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1535 | # |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1536 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1537 | CONTEXTFUL_NODES = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1538 | ast.Module, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1539 | ast.ClassDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1540 | ast.AsyncFunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1541 | ast.FunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1542 | ast.Lambda, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1543 | ast.ListComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1544 | ast.SetComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1545 | ast.DictComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1546 | ast.GeneratorExp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1547 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1548 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1549 | FUNCTION_NODES = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1550 | ast.AsyncFunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1551 | ast.FunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1552 | ast.Lambda, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1553 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1554 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1555 | NodeWindowSize = 4 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1556 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1557 | def __init__(self): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1558 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1559 | Constructor |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1560 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1561 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1562 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1563 | self.nodeWindow = [] |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1564 | self.violations = [] |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1565 | self.contexts = [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1566 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1567 | self.__M523Seen = set() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1568 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1569 | @property |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1570 | def nodeStack(self): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1571 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1572 | Public method to get a reference to the most recent node stack. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1573 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1574 | @return reference to the most recent node stack |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1575 | @rtype list |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1576 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1577 | if len(self.contexts) == 0: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1578 | return [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1579 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1580 | context, stack = self.contexts[-1] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1581 | return stack |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1582 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1583 | def __isIdentifier(self, arg): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1584 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1585 | Private method to check if arg is a valid identifier. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1586 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1587 | See https://docs.python.org/2/reference/lexical_analysis.html#identifiers |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1588 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1589 | @param arg reference to an argument node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1590 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1591 | @return flag indicating a valid identifier |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1592 | @rtype TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1593 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1594 | if not AstUtilities.isString(arg): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1595 | return False |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1596 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1597 | return ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1598 | re.match(r"^[A-Za-z_][A-Za-z0-9_]*$", AstUtilities.getValue(arg)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1599 | is not None |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1600 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1601 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1602 | def __composeCallPath(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1603 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1604 | Private method get the individual elements of the call path of a node. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1605 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1606 | @param node reference to the node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1607 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1608 | @yield one element of the call path |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1609 | @ytype ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1610 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1611 | if isinstance(node, ast.Attribute): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1612 | yield from self.__composeCallPath(node.value) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1613 | yield node.attr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1614 | elif isinstance(node, ast.Call): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1615 | yield from self.__composeCallPath(node.func) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1616 | elif isinstance(node, ast.Name): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1617 | yield node.id |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1618 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1619 | def __toNameStr(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1620 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1621 | Private method to turn Name and Attribute nodes to strings, handling any |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1622 | depth of attribute accesses. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1623 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1624 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1625 | @param node reference to the node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1626 | @type ast.Name or ast.Attribute |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1627 | @return string representation |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1628 | @rtype str |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1629 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1630 | if isinstance(node, ast.Name): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1631 | return node.id |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1632 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1633 | if isinstance(node, ast.Call): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1634 | return self.__toNameStr(node.func) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1635 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1636 | try: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1637 | return self.__toNameStr(node.value) + "." + node.attr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1638 | except AttributeError: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1639 | return self.__toNameStr(node.value) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1640 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1641 | def __typesafeIssubclass(self, obj, classOrTuple): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1642 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1643 | Private method implementing a type safe issubclass() function. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1644 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1645 | @param obj reference to the object to be tested |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1646 | @type any |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1647 | @param classOrTuple type to check against |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1648 | @type type |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1649 | @return flag indicating a subclass |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1650 | @rtype bool |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1651 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1652 | try: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1653 | return issubclass(obj, classOrTuple) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1654 | except TypeError: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1655 | # User code specifies a type that is not a type in our current run. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1656 | # Might be their error, might be a difference in our environments. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1657 | # We don't know so we ignore this. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1658 | return False |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1659 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1660 | def __getAssignedNames(self, loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1661 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1662 | Private method to get the names of a for loop. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1663 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1664 | @param loopNode reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1665 | @type ast.For |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1666 | @yield DESCRIPTION |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1667 | @ytype TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1668 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1669 | loopTargets = (ast.For, ast.AsyncFor, ast.comprehension) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1670 | for node in self.__childrenInScope(loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1671 | if isinstance(node, (ast.Assign)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1672 | for child in node.targets: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1673 | yield from self.__namesFromAssignments(child) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1674 | if isinstance(node, loopTargets + (ast.AnnAssign, ast.AugAssign)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1675 | yield from self.__namesFromAssignments(node.target) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1676 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1677 | def __namesFromAssignments(self, assignTarget): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1678 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1679 | Private method to get names of an assignment. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1680 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1681 | @param assignTarget reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1682 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1683 | @yield name of the assignment |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1684 | @ytype str |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1685 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1686 | if isinstance(assignTarget, ast.Name): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1687 | yield assignTarget.id |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1688 | elif isinstance(assignTarget, ast.Starred): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1689 | yield from self.__namesFromAssignments(assignTarget.value) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1690 | elif isinstance(assignTarget, (ast.List, ast.Tuple)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1691 | for child in assignTarget.elts: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1692 | yield from self.__namesFromAssignments(child) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1693 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1694 | def __childrenInScope(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1695 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1696 | Private method to get all child nodes in the given scope. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1697 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1698 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1699 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1700 | @yield reference to a child node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1701 | @ytype ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1702 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1703 | yield node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1704 | if not isinstance(node, BugBearVisitor.FUNCTION_NODES): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1705 | for child in ast.iter_child_nodes(node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1706 | yield from self.__childrenInScope(child) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1707 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1708 | def visit(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1709 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1710 | Public method to traverse a given AST node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1711 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1712 | @param node AST node to be traversed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1713 | @type ast.Node |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1714 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1715 | isContextful = isinstance(node, BugBearVisitor.CONTEXTFUL_NODES) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1716 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1717 | if isContextful: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1718 | context = BugBearContext(node, []) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1719 | self.contexts.append(context) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1720 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1721 | self.nodeStack.append(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1722 | self.nodeWindow.append(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1723 | self.nodeWindow = self.nodeWindow[-BugBearVisitor.NodeWindowSize :] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1724 | |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1725 | super().visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1726 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1727 | self.nodeStack.pop() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1728 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1729 | if isContextful: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1730 | self.contexts.pop() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1731 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1732 | def visit_ExceptHandler(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1733 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1734 | Public method to handle exception handlers. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1735 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1736 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1737 | @type ast.ExceptHandler |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1738 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1739 | redundantExceptions = { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1740 | "OSError": { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1741 | # All of these are actually aliases of OSError since Python 3.3 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1742 | "IOError", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1743 | "EnvironmentError", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1744 | "WindowsError", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1745 | "mmap.error", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1746 | "socket.error", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1747 | "select.error", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1748 | }, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1749 | "ValueError": { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1750 | "binascii.Error", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1751 | }, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1752 | } |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1753 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1754 | if node.type is None: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1755 | # bare except is handled by pycodestyle already |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1756 | pass |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1757 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1758 | elif isinstance(node.type, ast.Tuple): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1759 | names = [self.__toNameStr(e) for e in node.type.elts] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1760 | as_ = " as " + node.name if node.name is not None else "" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1761 | if len(names) == 0: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1762 | self.violations.append((node, "M501", as_)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1763 | elif len(names) == 1: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1764 | self.violations.append((node, "M513", *names)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1765 | else: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1766 | # See if any of the given exception names could be removed, e.g. from: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1767 | # (MyError, MyError) # duplicate names |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1768 | # (MyError, BaseException) # everything derives from the Base |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1769 | # (Exception, TypeError) # builtins where one subclasses another |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1770 | # (IOError, OSError) # IOError is an alias of OSError since Python3.3 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1771 | # but note that other cases are impractical to handle from the AST. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1772 | # We expect this is mostly useful for users who do not have the |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1773 | # builtin exception hierarchy memorised, and include a 'shadowed' |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1774 | # subtype without realising that it's redundant. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1775 | good = sorted(set(names), key=names.index) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1776 | if "BaseException" in good: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1777 | good = ["BaseException"] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1778 | # Remove redundant exceptions that the automatic system either handles |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1779 | # poorly (usually aliases) or can't be checked (e.g. it's not an |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1780 | # built-in exception). |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1781 | for primary, equivalents in redundantExceptions.items(): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1782 | if primary in good: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1783 | good = [g for g in good if g not in equivalents] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1784 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1785 | for name, other in itertools.permutations(tuple(good), 2): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1786 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1787 | self.__typesafeIssubclass( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1788 | getattr(builtins, name, type), getattr(builtins, other, ()) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1789 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1790 | and name in good |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1791 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1792 | good.remove(name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1793 | if good != names: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1794 | desc = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1795 | good[0] if len(good) == 1 else "({0})".format(", ".join(good)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1796 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1797 | self.violations.append((node, "M514", ", ".join(names), as_, desc)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1798 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1799 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1800 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1801 | def visit_UAdd(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1802 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1803 | Public method to handle unary additions. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1804 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1805 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1806 | @type ast.UAdd |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1807 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1808 | trailingNodes = list(map(type, self.nodeWindow[-4:])) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1809 | if trailingNodes == [ast.UnaryOp, ast.UAdd, ast.UnaryOp, ast.UAdd]: |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1810 | originator = self.nodeWindow[-4] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1811 | self.violations.append((originator, "M502")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1812 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1813 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1814 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1815 | def visit_Call(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1816 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1817 | Public method to handle a function call. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1818 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1819 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1820 | @type ast.Call |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1821 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1822 | if isinstance(node.func, ast.Attribute): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1823 | self.__checkForM505(node) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1824 | else: |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
1825 | with contextlib.suppress(AttributeError, IndexError): |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1826 | # bad super() call |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1827 | if isinstance(node.func, ast.Name) and node.func.id == "super": |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1828 | args = node.args |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1829 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1830 | len(args) == 2 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1831 | and isinstance(args[0], ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1832 | and isinstance(args[0].value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1833 | and args[0].value.id == "self" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1834 | and args[0].attr == "__class__" |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1835 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1836 | self.violations.append((node, "M582")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1837 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1838 | # bad getattr and setattr |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1839 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1840 | node.func.id in ("getattr", "hasattr") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1841 | and node.args[1].s == "__call__" |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1842 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1843 | self.violations.append((node, "M504")) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1844 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1845 | node.func.id == "getattr" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1846 | and len(node.args) == 2 |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1847 | and self.__isIdentifier(node.args[1]) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1848 | and iskeyword(AstUtilities.getValue(node.args[1])) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1849 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1850 | self.violations.append((node, "M509")) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1851 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1852 | node.func.id == "setattr" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1853 | and len(node.args) == 3 |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1854 | and self.__isIdentifier(node.args[1]) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1855 | and iskeyword(AstUtilities.getValue(node.args[1])) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1856 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1857 | self.violations.append((node, "M510")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1858 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1859 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1860 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1861 | def visit_Assign(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1862 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1863 | Public method to handle assignments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1864 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1865 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1866 | @type ast.Assign |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1867 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1868 | if len(node.targets) == 1: |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1869 | target = node.targets[0] |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1870 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1871 | isinstance(target, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1872 | and isinstance(target.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1873 | and (target.value.id, target.attr) == ("os", "environ") |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1874 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1875 | self.violations.append((node, "M503")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1876 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1877 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1878 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1879 | def visit_For(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1880 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1881 | Public method to handle 'for' statements. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1882 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1883 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1884 | @type ast.For |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1885 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1886 | self.__checkForM507(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1887 | self.__checkForM520(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1888 | self.__checkForM523(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1889 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1890 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1891 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1892 | def visit_AsyncFor(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1893 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1894 | Public method to handle 'for' statements. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1895 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1896 | @param node reference to the node to be processed |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1897 | @type ast.AsyncFor |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1898 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1899 | self.__checkForM507(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1900 | self.__checkForM520(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1901 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1902 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1903 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1904 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1905 | def visit_While(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1906 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1907 | Public method to handle 'while' statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1908 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1909 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1910 | @type ast.While |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1911 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1912 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1913 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1914 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1915 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1916 | def visit_ListComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1917 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1918 | Public method to handle list comprehensions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1919 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1920 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1921 | @type ast.ListComp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1922 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1923 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1924 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1925 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1926 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1927 | def visit_SetComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1928 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1929 | Public method to handle set comprehensions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1930 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1931 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1932 | @type ast.SetComp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1933 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1934 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1935 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1936 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1937 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1938 | def visit_DictComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1939 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1940 | Public method to handle dictionary comprehensions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1941 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1942 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1943 | @type ast.DictComp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1944 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1945 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1946 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1947 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1948 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1949 | def visit_GeneratorExp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1950 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1951 | Public method to handle generator expressions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1952 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1953 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1954 | @type ast.GeneratorExp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1955 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1956 | self.__checkForM523(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1957 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
1958 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1959 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1960 | def visit_Assert(self, node): |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1961 | """ |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1962 | Public method to handle 'assert' statements. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1963 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1964 | @param node reference to the node to be processed |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1965 | @type ast.Assert |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1966 | """ |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1967 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1968 | AstUtilities.isNameConstant(node.test) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1969 | and AstUtilities.getValue(node.test) is False |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1970 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1971 | self.violations.append((node, "M511")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1972 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1973 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1974 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1975 | def visit_FunctionDef(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1976 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1977 | Public method to handle function definitions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1978 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1979 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1980 | @type ast.FunctionDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1981 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1982 | self.__checkForM518(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1983 | self.__checkForM519(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1984 | self.__checkForM521(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1985 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1986 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1987 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1988 | def visit_ClassDef(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1989 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1990 | Public method to handle class definitions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1991 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1992 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1993 | @type ast.ClassDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1994 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1995 | self.__checkForM518(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1996 | self.__checkForM521(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1997 | self.__checkForM524(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1998 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1999 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2000 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2001 | def visit_Try(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2002 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2003 | Public method to handle 'try' statements'. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2004 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2005 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2006 | @type ast.Try |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2007 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2008 | self.__checkForM512(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2009 | self.__checkForM525(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2010 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2011 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2012 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2013 | def visit_Compare(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2014 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2015 | Public method to handle comparison statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2016 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2017 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2018 | @type ast.Compare |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2019 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2020 | self.__checkForM515(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2021 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2022 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2023 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2024 | def visit_Raise(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2025 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2026 | Public method to handle 'raise' statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2027 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2028 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2029 | @type ast.Raise |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2030 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2031 | self.__checkForM516(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2032 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2033 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2034 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2035 | def visit_With(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2036 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2037 | Public method to handle 'with' statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2038 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2039 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2040 | @type ast.With |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2041 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2042 | self.__checkForM517(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2043 | self.__checkForM522(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2044 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2045 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2046 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2047 | def visit_JoinedStr(self, node): |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2048 | """ |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2049 | Public method to handle f-string arguments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2050 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2051 | @param node reference to the node to be processed |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2052 | @type ast.JoinedStr |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2053 | """ |
7894
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
2054 | for value in node.values: |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
2055 | if isinstance(value, ast.FormattedValue): |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
2056 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2057 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2058 | self.violations.append((node, "M581")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2059 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2060 | def __checkForM505(self, node): |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2061 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2062 | Private method to check the use of *strip(). |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2063 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2064 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2065 | @type ast.Call |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2066 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2067 | if node.func.attr not in ("lstrip", "rstrip", "strip"): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2068 | return # method name doesn't match |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2069 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2070 | if len(node.args) != 1 or not AstUtilities.isString(node.args[0]): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2071 | return # used arguments don't match the builtin strip |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2072 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2073 | s = AstUtilities.getValue(node.args[0]) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2074 | if len(s) == 1: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2075 | return # stripping just one character |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2076 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2077 | if len(s) == len(set(s)): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2078 | return # no characters appear more than once |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2079 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2080 | self.violations.append((node, "M505")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2081 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2082 | def __checkForM507(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2083 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2084 | Private method to check for unused loop variables. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2085 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2086 | @param node reference to the node to be processed |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2087 | @type ast.For or ast.AsyncFor |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2088 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2089 | targets = NameFinder() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2090 | targets.visit(node.target) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2091 | ctrlNames = set(filter(lambda s: not s.startswith("_"), targets.getNames())) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2092 | body = NameFinder() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2093 | for expr in node.body: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2094 | body.visit(expr) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2095 | usedNames = set(body.getNames()) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2096 | for name in sorted(ctrlNames - usedNames): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2097 | n = targets.getNames()[name][0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2098 | self.violations.append((n, "M507", name)) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2099 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2100 | def __checkForM512(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2101 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2102 | Private method to check for return/continue/break inside finally blocks. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2103 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2104 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2105 | @type ast.Try |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2106 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2107 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2108 | def _loop(node, badNodeTypes): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2109 | if isinstance(node, (ast.AsyncFunctionDef, ast.FunctionDef)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2110 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2111 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2112 | if isinstance(node, (ast.While, ast.For)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2113 | badNodeTypes = (ast.Return,) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2114 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2115 | elif isinstance(node, badNodeTypes): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2116 | self.violations.append((node, "M512")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2117 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2118 | for child in ast.iter_child_nodes(node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2119 | _loop(child, badNodeTypes) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2120 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2121 | for child in node.finalbody: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2122 | _loop(child, (ast.Return, ast.Continue, ast.Break)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2123 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2124 | def __checkForM515(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2125 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2126 | Private method to check for pointless comparisons. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2127 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2128 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2129 | @type ast.Compare |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2130 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2131 | if isinstance(self.nodeStack[-2], ast.Expr): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2132 | self.violations.append((node, "M515")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2133 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2134 | def __checkForM516(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2135 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2136 | Private method to check for raising a literal instead of an exception. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2137 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2138 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2139 | @type ast.Raise |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2140 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2141 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2142 | AstUtilities.isNameConstant(node.exc) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2143 | or AstUtilities.isNumber(node.exc) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2144 | or AstUtilities.isString(node.exc) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2145 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2146 | self.violations.append((node, "M516")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2147 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2148 | def __checkForM517(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2149 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2150 | Private method to check for use of the evil syntax |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2151 | 'with assertRaises(Exception):. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2152 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2153 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2154 | @type ast.With |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2155 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2156 | item = node.items[0] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2157 | itemContext = item.context_expr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2158 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2159 | hasattr(itemContext, "func") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2160 | and hasattr(itemContext.func, "attr") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2161 | and itemContext.func.attr == "assertRaises" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2162 | and len(itemContext.args) == 1 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2163 | and isinstance(itemContext.args[0], ast.Name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2164 | and itemContext.args[0].id == "Exception" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2165 | and not item.optional_vars |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2166 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2167 | self.violations.append((node, "M517")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2168 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2169 | def __checkForM518(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2170 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2171 | Private method to check for useless expressions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2172 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2173 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2174 | @type ast.FunctionDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2175 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2176 | subnodeClasses = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2177 | ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2178 | ast.Constant, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2179 | ast.List, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2180 | ast.Set, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2181 | ast.Dict, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2182 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2183 | if sys.version_info >= (3, 8, 0) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2184 | else ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2185 | ast.Num, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2186 | ast.Bytes, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2187 | ast.NameConstant, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2188 | ast.List, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2189 | ast.Set, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2190 | ast.Dict, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2191 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2192 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2193 | for subnode in node.body: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2194 | if not isinstance(subnode, ast.Expr): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2195 | continue |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2196 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2197 | if isinstance(subnode.value, subnodeClasses) and not AstUtilities.isString( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2198 | subnode.value |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2199 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2200 | self.violations.append((subnode, "M518")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2201 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2202 | def __checkForM519(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2203 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2204 | Private method to check for use of 'functools.lru_cache' or 'functools.cache'. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2205 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2206 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2207 | @type ast.FunctionDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2208 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2209 | caches = { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2210 | "functools.cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2211 | "functools.lru_cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2212 | "cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2213 | "lru_cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2214 | } |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2215 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2216 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2217 | len(node.decorator_list) == 0 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2218 | or len(self.contexts) < 2 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2219 | or not isinstance(self.contexts[-2].node, ast.ClassDef) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2220 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2221 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2222 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2223 | # Preserve decorator order so we can get the lineno from the decorator node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2224 | # rather than the function node (this location definition changes in Python 3.8) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2225 | resolvedDecorators = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2226 | ".".join(self.__composeCallPath(decorator)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2227 | for decorator in node.decorator_list |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2228 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2229 | for idx, decorator in enumerate(resolvedDecorators): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2230 | if decorator in {"classmethod", "staticmethod"}: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2231 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2232 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2233 | if decorator in caches: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2234 | self.violations.append((node.decorator_list[idx], "M519")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2235 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2236 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2237 | def __checkForM520(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2238 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2239 | Private method to check for a loop that modifies its iterable. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2240 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2241 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2242 | @type ast.For or ast.AsyncFor |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2243 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2244 | targets = NameFinder() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2245 | targets.visit(node.target) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2246 | ctrlNames = set(targets.getNames()) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2247 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2248 | iterset = M520NameFinder() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2249 | iterset.visit(node.iter) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2250 | itersetNames = set(iterset.getNames()) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2251 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2252 | for name in sorted(ctrlNames): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2253 | if name in itersetNames: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2254 | n = targets.getNames()[name][0] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2255 | self.violations.append((n, "M520")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2256 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2257 | def __checkForM521(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2258 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2259 | Private method to check for use of an f-string as docstring. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2260 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2261 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2262 | @type ast.FunctionDef or ast.ClassDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2263 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2264 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2265 | node.body |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2266 | and isinstance(node.body[0], ast.Expr) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2267 | and isinstance(node.body[0].value, ast.JoinedStr) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2268 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2269 | self.violations.append((node.body[0].value, "M521")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2270 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2271 | def __checkForM522(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2272 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2273 | Private method to check for use of an f-string as docstring. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2274 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2275 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2276 | @type ast.With |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2277 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2278 | item = node.items[0] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2279 | itemContext = item.context_expr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2280 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2281 | hasattr(itemContext, "func") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2282 | and hasattr(itemContext.func, "value") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2283 | and hasattr(itemContext.func.value, "id") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2284 | and itemContext.func.value.id == "contextlib" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2285 | and hasattr(itemContext.func, "attr") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2286 | and itemContext.func.attr == "suppress" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2287 | and len(itemContext.args) == 0 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2288 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2289 | self.violations.append((node, "M522")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2290 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2291 | def __checkForM523(self, loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2292 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2293 | Private method to check that functions (including lambdas) do not use loop |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2294 | variables. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2295 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2296 | @param loopNode reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2297 | @type ast.For, ast.AsyncFor, ast.While, ast.ListComp, ast.SetComp,ast.DictComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2298 | or ast.GeneratorExp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2299 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2300 | suspiciousVariables = [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2301 | for node in ast.walk(loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2302 | if isinstance(node, BugBearVisitor.FUNCTION_NODES): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2303 | argnames = { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2304 | arg.arg for arg in ast.walk(node.args) if isinstance(arg, ast.arg) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2305 | } |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2306 | if isinstance(node, ast.Lambda): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2307 | bodyNodes = ast.walk(node.body) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2308 | else: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2309 | bodyNodes = itertools.chain.from_iterable(map(ast.walk, node.body)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2310 | for name in bodyNodes: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2311 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2312 | isinstance(name, ast.Name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2313 | and name.id not in argnames |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2314 | and isinstance(name.ctx, ast.Load) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2315 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2316 | err = (name.lineno, name.col_offset, name.id, name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2317 | if err not in self.__M523Seen: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2318 | self.__M523Seen.add(err) # dedupe across nested loops |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2319 | suspiciousVariables.append(err) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2320 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2321 | if suspiciousVariables: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2322 | reassignedInLoop = set(self.__getAssignedNames(loopNode)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2323 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2324 | for err in sorted(suspiciousVariables): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2325 | if reassignedInLoop.issuperset(err[2]): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2326 | self.violations.append((err[3], "M523", err[2])) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2327 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2328 | def __checkForM524(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2329 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2330 | Private method to check for inheritance from abstract classes in abc and lack of |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2331 | any methods decorated with abstract*. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2332 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2333 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2334 | @type ast.ClassDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2335 | """ # __IGNORE_WARNING_D234r__ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2336 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2337 | def isAbcClass(value): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2338 | if isinstance(value, ast.keyword): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2339 | return value.arg == "metaclass" and isAbcClass(value.value) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2340 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2341 | abcNames = ("ABC", "ABCMeta") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2342 | return (isinstance(value, ast.Name) and value.id in abcNames) or ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2343 | isinstance(value, ast.Attribute) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2344 | and value.attr in abcNames |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2345 | and isinstance(value.value, ast.Name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2346 | and value.value.id == "abc" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2347 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2348 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2349 | def isAbstractDecorator(expr): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2350 | return (isinstance(expr, ast.Name) and expr.id[:8] == "abstract") or ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2351 | isinstance(expr, ast.Attribute) and expr.attr[:8] == "abstract" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2352 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2353 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2354 | if not any(map(isAbcClass, (*node.bases, *node.keywords))): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2355 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2356 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2357 | for stmt in node.body: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2358 | if isinstance(stmt, (ast.FunctionDef, ast.AsyncFunctionDef)) and any( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2359 | map(isAbstractDecorator, stmt.decorator_list) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2360 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2361 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2362 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2363 | self.violations.append((node, "M524", node.name)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2364 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2365 | def __checkForM525(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2366 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2367 | Private method to check for exceptions being handled multiple times. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2368 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2369 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2370 | @type ast.Try |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2371 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2372 | seen = [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2373 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2374 | for handler in node.handlers: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2375 | if isinstance(handler.type, (ast.Name, ast.Attribute)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2376 | name = ".".join(self.__composeCallPath(handler.type)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2377 | seen.append(name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2378 | elif isinstance(handler.type, ast.Tuple): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2379 | # to avoid checking the same as M514, remove duplicates per except |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2380 | uniques = set() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2381 | for entry in handler.type.elts: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2382 | name = ".".join(self.__composeCallPath(entry)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2383 | uniques.add(name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2384 | seen.extend(uniques) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2385 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2386 | # sort to have a deterministic output |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2387 | duplicates = sorted({x for x in seen if seen.count(x) > 1}) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2388 | for duplicate in duplicates: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2389 | self.violations.append((node, "M525", duplicate)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2390 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2391 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2392 | class NameFinder(ast.NodeVisitor): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2393 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2394 | Class to extract a name out of a tree of nodes. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2395 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2396 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2397 | def __init__(self): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2398 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2399 | Constructor |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2400 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
2401 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2402 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2403 | self.__names = {} |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2404 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2405 | def visit_Name(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2406 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2407 | Public method to handle 'Name' nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2408 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2409 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2410 | @type ast.Name |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2411 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2412 | self.__names.setdefault(node.id, []).append(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2413 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2414 | def visit(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2415 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2416 | Public method to traverse a given AST node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2417 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2418 | @param node AST node to be traversed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2419 | @type ast.Node |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2420 | @return reference to the last processed node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2421 | @rtype ast.Node |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2422 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2423 | if isinstance(node, list): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2424 | for elem in node: |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
2425 | super().visit(elem) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2426 | return node |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2427 | else: |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2428 | return super().visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2429 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2430 | def getNames(self): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2431 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2432 | Public method to return the extracted names and Name nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2433 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2434 | @return dictionary containing the names as keys and the list of nodes |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2435 | @rtype dict |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2436 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2437 | return self.__names |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2438 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2439 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2440 | class M520NameFinder(NameFinder): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2441 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2442 | Class to extract a name out of a tree of nodes ignoring names defined within the |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2443 | local scope of a comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2444 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2445 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2446 | def visit_GeneratorExp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2447 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2448 | Public method to handle a generator expressions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2449 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2450 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2451 | @type ast.GeneratorExp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2452 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2453 | self.visit(node.generators) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2454 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2455 | def visit_ListComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2456 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2457 | Public method to handle a list comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2458 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2459 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2460 | @type TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2461 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2462 | self.visit(node.generators) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2463 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2464 | def visit_DictComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2465 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2466 | Public method to handle a dictionary comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2467 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2468 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2469 | @type TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2470 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2471 | self.visit(node.generators) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2472 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2473 | def visit_comprehension(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2474 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2475 | Public method to handle the 'for' of a comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2476 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2477 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2478 | @type ast.comprehension |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2479 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2480 | self.visit(node.iter) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2481 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2482 | def visit_Lambda(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2483 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2484 | Public method to handle a Lambda function. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2485 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2486 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2487 | @type ast.Lambda |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2488 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2489 | self.visit(node.body) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2490 | for lambdaArg in node.args.args: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2491 | self.getNames().pop(lambdaArg.arg, None) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2492 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2493 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2494 | class ReturnVisitor(ast.NodeVisitor): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2495 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2496 | Class implementing a node visitor to check return statements. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2497 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2498 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2499 | Assigns = "assigns" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2500 | Refs = "refs" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2501 | Returns = "returns" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2502 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2503 | def __init__(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2504 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2505 | Constructor |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2506 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
2507 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2508 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2509 | self.__stack = [] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2510 | self.violations = [] |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2511 | self.__loopCount = 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2512 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2513 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2514 | def assigns(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2515 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2516 | Public method to get the Assign nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2517 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2518 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2519 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2520 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2521 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2522 | return self.__stack[-1][ReturnVisitor.Assigns] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2523 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2524 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2525 | def refs(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2526 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2527 | Public method to get the References nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2528 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2529 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2530 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2531 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2532 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2533 | return self.__stack[-1][ReturnVisitor.Refs] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2534 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2535 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2536 | def returns(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2537 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2538 | Public method to get the Return nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2539 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2540 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2541 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2542 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2543 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2544 | return self.__stack[-1][ReturnVisitor.Returns] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2545 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2546 | def visit_For(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2547 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2548 | Public method to handle a for loop. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2549 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2550 | @param node reference to the for node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2551 | @type ast.For |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2552 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2553 | self.__visitLoop(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2554 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2555 | def visit_AsyncFor(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2556 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2557 | Public method to handle an async for loop. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2558 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2559 | @param node reference to the async for node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2560 | @type ast.AsyncFor |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2561 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2562 | self.__visitLoop(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2563 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2564 | def visit_While(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2565 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2566 | Public method to handle a while loop. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2567 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2568 | @param node reference to the while node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2569 | @type ast.While |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2570 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2571 | self.__visitLoop(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2572 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2573 | def __visitLoop(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2574 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2575 | Private method to handle loop nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2576 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2577 | @param node reference to the loop node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2578 | @type ast.For, ast.AsyncFor or ast.While |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2579 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2580 | self.__loopCount += 1 |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2581 | self.generic_visit(node) |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2582 | self.__loopCount -= 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2583 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2584 | def __visitWithStack(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2585 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2586 | Private method to traverse a given function node using a stack. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2587 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2588 | @param node AST node to be traversed |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2589 | @type ast.FunctionDef or ast.AsyncFunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2590 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2591 | self.__stack.append( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2592 | { |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2593 | ReturnVisitor.Assigns: defaultdict(list), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2594 | ReturnVisitor.Refs: defaultdict(list), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2595 | ReturnVisitor.Returns: [], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2596 | } |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2597 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2598 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2599 | self.generic_visit(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2600 | self.__checkFunction(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2601 | self.__stack.pop() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2602 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2603 | def visit_FunctionDef(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2604 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2605 | Public method to handle a function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2606 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2607 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2608 | @type ast.FunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2609 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2610 | self.__visitWithStack(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2611 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2612 | def visit_AsyncFunctionDef(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2613 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2614 | Public method to handle a function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2615 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2616 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2617 | @type ast.AsyncFunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2618 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2619 | self.__visitWithStack(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2620 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2621 | def visit_Return(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2622 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2623 | Public method to handle a return node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2624 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2625 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2626 | @type ast.Return |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2627 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2628 | self.returns.append(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2629 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2630 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2631 | def visit_Assign(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2632 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2633 | Public method to handle an assign node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2634 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2635 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2636 | @type ast.Assign |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2637 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2638 | if not self.__stack: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2639 | return |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2640 | |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2641 | self.generic_visit(node.value) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2642 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2643 | target = node.targets[0] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2644 | if isinstance(target, ast.Tuple) and not isinstance(node.value, ast.Tuple): |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2645 | # skip unpacking assign |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2646 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2647 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2648 | self.__visitAssignTarget(target) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2649 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2650 | def visit_Name(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2651 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2652 | Public method to handle a name node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2653 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2654 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2655 | @type ast.Name |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2656 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2657 | if self.__stack: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2658 | self.refs[node.id].append(node.lineno) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2659 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2660 | def __visitAssignTarget(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2661 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2662 | Private method to handle an assign target node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2663 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2664 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2665 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2666 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2667 | if isinstance(node, ast.Tuple): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2668 | for elt in node.elts: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2669 | self.__visitAssignTarget(elt) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2670 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2671 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2672 | if not self.__loopCount and isinstance(node, ast.Name): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2673 | self.assigns[node.id].append(node.lineno) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2674 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2675 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2676 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2677 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2678 | def __checkFunction(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2679 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2680 | Private method to check a function definition node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2681 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2682 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2683 | @type ast.AsyncFunctionDef or ast.FunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2684 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2685 | if not self.returns or not node.body: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2686 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2687 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2688 | if len(node.body) == 1 and isinstance(node.body[-1], ast.Return): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2689 | # skip functions that consist of `return None` only |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2690 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2691 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2692 | if not self.__resultExists(): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2693 | self.__checkUnnecessaryReturnNone() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2694 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2695 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2696 | self.__checkImplicitReturnValue() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2697 | self.__checkImplicitReturn(node.body[-1]) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2698 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2699 | for n in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2700 | if n.value: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2701 | self.__checkUnnecessaryAssign(n.value) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2702 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2703 | def __isNone(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2704 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2705 | Private method to check, if a node value is None. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2706 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2707 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2708 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2709 | @return flag indicating the node contains a None value |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2710 | @rtype bool |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2711 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2712 | return AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2713 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2714 | def __isFalse(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2715 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2716 | Private method to check, if a node value is False. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2717 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2718 | @param node reference to the node to check |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2719 | @type ast.AST |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2720 | @return flag indicating the node contains a False value |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2721 | @rtype bool |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2722 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2723 | return ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2724 | AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is False |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2725 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2726 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2727 | def __resultExists(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2728 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2729 | Private method to check the existance of a return result. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2730 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2731 | @return flag indicating the existence of a return result |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2732 | @rtype bool |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2733 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2734 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2735 | value = node.value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2736 | if value and not self.__isNone(value): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2737 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2738 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2739 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2740 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2741 | def __checkImplicitReturnValue(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2742 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2743 | Private method to check for implicit return values. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2744 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2745 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2746 | if not node.value: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2747 | self.violations.append((node, "M832")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2748 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2749 | def __checkUnnecessaryReturnNone(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2750 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2751 | Private method to check for an unnecessary 'return None' statement. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2752 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2753 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2754 | if self.__isNone(node.value): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2755 | self.violations.append((node, "M831")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2756 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2757 | def __checkImplicitReturn(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2758 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2759 | Private method to check for an implicit return statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2760 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2761 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2762 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2763 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2764 | if isinstance(node, ast.If): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2765 | if not node.body or not node.orelse: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2766 | self.violations.append((node, "M833")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2767 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2768 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2769 | self.__checkImplicitReturn(node.body[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2770 | self.__checkImplicitReturn(node.orelse[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2771 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2772 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2773 | if isinstance(node, (ast.For, ast.AsyncFor)) and node.orelse: |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2774 | self.__checkImplicitReturn(node.orelse[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2775 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2776 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2777 | if isinstance(node, (ast.With, ast.AsyncWith)): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2778 | self.__checkImplicitReturn(node.body[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2779 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2780 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2781 | if isinstance(node, ast.Assert) and self.__isFalse(node.test): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2782 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2783 | |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
2784 | try: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
2785 | okNodes = (ast.Return, ast.Raise, ast.While, ast.Try) |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
2786 | except AttributeError: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
2787 | okNodes = (ast.Return, ast.Raise, ast.While) |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
2788 | if not isinstance(node, okNodes): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2789 | self.violations.append((node, "M833")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2790 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2791 | def __checkUnnecessaryAssign(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2792 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2793 | Private method to check for an unnecessary assign statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2794 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2795 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2796 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2797 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2798 | if not isinstance(node, ast.Name): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2799 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2800 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2801 | varname = node.id |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2802 | returnLineno = node.lineno |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2803 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2804 | if varname not in self.assigns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2805 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2806 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2807 | if varname not in self.refs: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2808 | self.violations.append((node, "M834")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2809 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2810 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2811 | if self.__hasRefsBeforeNextAssign(varname, returnLineno): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2812 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2813 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2814 | self.violations.append((node, "M834")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2815 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2816 | def __hasRefsBeforeNextAssign(self, varname, returnLineno): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2817 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2818 | Private method to check for references before a following assign |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2819 | statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2820 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2821 | @param varname variable name to check for |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2822 | @type str |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2823 | @param returnLineno line number of the return statement |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2824 | @type int |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2825 | @return flag indicating the existence of references |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2826 | @rtype bool |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2827 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2828 | beforeAssign = 0 |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2829 | afterAssign = None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2830 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2831 | for lineno in sorted(self.assigns[varname]): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2832 | if lineno > returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2833 | afterAssign = lineno |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2834 | break |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2835 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2836 | if lineno <= returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2837 | beforeAssign = lineno |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2838 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2839 | for lineno in self.refs[varname]: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2840 | if lineno == returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2841 | continue |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2842 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2843 | if afterAssign: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2844 | if beforeAssign < lineno <= afterAssign: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2845 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2846 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2847 | elif beforeAssign < lineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2848 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2849 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
2850 | return False |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2851 | |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2852 | |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2853 | class DateTimeVisitor(ast.NodeVisitor): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2854 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2855 | Class implementing a node visitor to check datetime function calls. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2856 | |
9274
86fab0c74430
Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9221
diff
changeset
|
2857 | Note: This class is modeled after flake8_datetimez checker. |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2858 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2859 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2860 | def __init__(self): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2861 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2862 | Constructor |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2863 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
2864 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2865 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2866 | self.violations = [] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2867 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2868 | def __getFromKeywords(self, keywords, name): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2869 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2870 | Private method to get a keyword node given its name. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2871 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2872 | @param keywords list of keyword argument nodes |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2873 | @type list of ast.AST |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2874 | @param name name of the keyword node |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2875 | @type str |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2876 | @return keyword node |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2877 | @rtype ast.AST |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2878 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2879 | for keyword in keywords: |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2880 | if keyword.arg == name: |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2881 | return keyword |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2882 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2883 | return None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2884 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2885 | def visit_Call(self, node): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2886 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2887 | Public method to handle a function call. |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2888 | |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2889 | Every datetime related function call is check for use of the naive |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2890 | variant (i.e. use without TZ info). |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2891 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2892 | @param node reference to the node to be processed |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2893 | @type ast.Call |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2894 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2895 | # datetime.something() |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2896 | isDateTimeClass = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2897 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2898 | and isinstance(node.func.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2899 | and node.func.value.id == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2900 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2901 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2902 | # datetime.datetime.something() |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2903 | isDateTimeModuleAndClass = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2904 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2905 | and isinstance(node.func.value, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2906 | and node.func.value.attr == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2907 | and isinstance(node.func.value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2908 | and node.func.value.value.id == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2909 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2910 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2911 | if isDateTimeClass: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2912 | if node.func.attr == "datetime": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2913 | # datetime.datetime(2000, 1, 1, 0, 0, 0, 0, |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2914 | # datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2915 | isCase1 = len(node.args) >= 8 and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2916 | AstUtilities.isNameConstant(node.args[7]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2917 | and AstUtilities.getValue(node.args[7]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2918 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2919 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2920 | # datetime.datetime(2000, 1, 1, tzinfo=datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2921 | tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2922 | isCase2 = tzinfoKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2923 | AstUtilities.isNameConstant(tzinfoKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2924 | and AstUtilities.getValue(tzinfoKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2925 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2926 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2927 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2928 | self.violations.append((node, "M301")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2929 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2930 | elif node.func.attr == "time": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2931 | # time(12, 10, 45, 0, datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2932 | isCase1 = len(node.args) >= 5 and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2933 | AstUtilities.isNameConstant(node.args[4]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2934 | and AstUtilities.getValue(node.args[4]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2935 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2936 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2937 | # datetime.time(12, 10, 45, tzinfo=datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2938 | tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2939 | isCase2 = tzinfoKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2940 | AstUtilities.isNameConstant(tzinfoKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2941 | and AstUtilities.getValue(tzinfoKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2942 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2943 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2944 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2945 | self.violations.append((node, "M321")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2946 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2947 | elif node.func.attr == "date": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2948 | self.violations.append((node, "M311")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2949 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2950 | if isDateTimeClass or isDateTimeModuleAndClass: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2951 | if node.func.attr == "today": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2952 | self.violations.append((node, "M302")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2953 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2954 | elif node.func.attr == "utcnow": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2955 | self.violations.append((node, "M303")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2956 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2957 | elif node.func.attr == "utcfromtimestamp": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2958 | self.violations.append((node, "M304")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2959 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2960 | elif node.func.attr in "now": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2961 | # datetime.now(UTC) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2962 | isCase1 = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2963 | len(node.args) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2964 | and len(node.keywords) == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2965 | and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2966 | AstUtilities.isNameConstant(node.args[0]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2967 | and AstUtilities.getValue(node.args[0]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2968 | ) |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2969 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2970 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2971 | # datetime.now(tz=UTC) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2972 | tzKeyword = self.__getFromKeywords(node.keywords, "tz") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2973 | isCase2 = tzKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2974 | AstUtilities.isNameConstant(tzKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2975 | and AstUtilities.getValue(tzKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2976 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2977 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2978 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2979 | self.violations.append((node, "M305")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2980 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2981 | elif node.func.attr == "fromtimestamp": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2982 | # datetime.fromtimestamp(1234, UTC) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2983 | isCase1 = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2984 | len(node.args) == 2 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2985 | and len(node.keywords) == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2986 | and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2987 | AstUtilities.isNameConstant(node.args[1]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2988 | and AstUtilities.getValue(node.args[1]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2989 | ) |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2990 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2991 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2992 | # datetime.fromtimestamp(1234, tz=UTC) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2993 | tzKeyword = self.__getFromKeywords(node.keywords, "tz") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2994 | isCase2 = tzKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2995 | AstUtilities.isNameConstant(tzKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2996 | and AstUtilities.getValue(tzKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
2997 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2998 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
2999 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3000 | self.violations.append((node, "M306")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3001 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3002 | elif node.func.attr == "strptime": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3003 | # datetime.strptime(...).replace(tzinfo=UTC) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3004 | parent = getattr(node, "_dtCheckerParent", None) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3005 | pparent = getattr(parent, "_dtCheckerParent", None) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3006 | if not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3007 | isinstance(parent, ast.Attribute) and parent.attr == "replace" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3008 | ) or not isinstance(pparent, ast.Call): |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3009 | isCase1 = False |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3010 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3011 | tzinfoKeyword = self.__getFromKeywords(pparent.keywords, "tzinfo") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3012 | isCase1 = tzinfoKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3013 | AstUtilities.isNameConstant(tzinfoKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3014 | and AstUtilities.getValue(tzinfoKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3015 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3016 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3017 | if not isCase1: |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3018 | self.violations.append((node, "M307")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3019 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3020 | elif node.func.attr == "fromordinal": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3021 | self.violations.append((node, "M308")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3022 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3023 | # date.something() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3024 | isDateClass = ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3025 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3026 | and isinstance(node.func.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3027 | and node.func.value.id == "date" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3028 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3029 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3030 | # datetime.date.something() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3031 | isDateModuleAndClass = ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3032 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3033 | and isinstance(node.func.value, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3034 | and node.func.value.attr == "date" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3035 | and isinstance(node.func.value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3036 | and node.func.value.value.id == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3037 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3038 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3039 | if isDateClass or isDateModuleAndClass: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3040 | if node.func.attr == "today": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3041 | self.violations.append((node, "M312")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3042 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3043 | elif node.func.attr == "fromtimestamp": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3044 | self.violations.append((node, "M313")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3045 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3046 | elif node.func.attr == "fromordinal": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3047 | self.violations.append((node, "M314")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3048 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3049 | elif node.func.attr == "fromisoformat": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3050 | self.violations.append((node, "M315")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3051 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3052 | self.generic_visit(node) |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3053 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3054 | |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3055 | class SysVersionVisitor(ast.NodeVisitor): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3056 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3057 | Class implementing a node visitor to check the use of sys.version and |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3058 | sys.version_info. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3059 | |
9274
86fab0c74430
Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9221
diff
changeset
|
3060 | Note: This class is modeled after flake8-2020 checker. |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3061 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3062 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3063 | def __init__(self): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3064 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3065 | Constructor |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3066 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
3067 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3068 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3069 | self.violations = [] |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3070 | self.__fromImports = {} |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3071 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3072 | def visit_ImportFrom(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3073 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3074 | Public method to handle a from ... import ... statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3075 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3076 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3077 | @type ast.ImportFrom |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3078 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3079 | for alias in node.names: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3080 | if node.module is not None and not alias.asname: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3081 | self.__fromImports[alias.name] = node.module |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3082 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3083 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3084 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3085 | def __isSys(self, attr, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3086 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3087 | Private method to check for a reference to sys attribute. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3088 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3089 | @param attr attribute name |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3090 | @type str |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3091 | @param node reference to the node to be checked |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3092 | @type ast.Node |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3093 | @return flag indicating a match |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3094 | @rtype bool |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3095 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3096 | match = False |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3097 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3098 | isinstance(node, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3099 | and isinstance(node.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3100 | and node.value.id == "sys" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3101 | and node.attr == attr |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3102 | ) or ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3103 | isinstance(node, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3104 | and node.id == attr |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3105 | and self.__fromImports.get(node.id) == "sys" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3106 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3107 | match = True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3108 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3109 | return match |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3110 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3111 | def __isSysVersionUpperSlice(self, node, n): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3112 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3113 | Private method to check the upper slice of sys.version. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3114 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3115 | @param node reference to the node to be checked |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3116 | @type ast.Node |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3117 | @param n slice value to check against |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3118 | @type int |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3119 | @return flag indicating a match |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3120 | @rtype bool |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3121 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3122 | return ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3123 | self.__isSys("version", node.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3124 | and isinstance(node.slice, ast.Slice) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3125 | and node.slice.lower is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3126 | and AstUtilities.isNumber(node.slice.upper) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3127 | and AstUtilities.getValue(node.slice.upper) == n |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3128 | and node.slice.step is None |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3129 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3130 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3131 | def visit_Subscript(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3132 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3133 | Public method to handle a subscript. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3134 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3135 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3136 | @type ast.Subscript |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3137 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3138 | if self.__isSysVersionUpperSlice(node, 1): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3139 | self.violations.append((node.value, "M423")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3140 | elif self.__isSysVersionUpperSlice(node, 3): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3141 | self.violations.append((node.value, "M401")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3142 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3143 | self.__isSys("version", node.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3144 | and isinstance(node.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3145 | and AstUtilities.isNumber(node.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3146 | and AstUtilities.getValue(node.slice.value) == 2 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3147 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3148 | self.violations.append((node.value, "M402")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3149 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3150 | self.__isSys("version", node.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3151 | and isinstance(node.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3152 | and AstUtilities.isNumber(node.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3153 | and AstUtilities.getValue(node.slice.value) == 0 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3154 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3155 | self.violations.append((node.value, "M421")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3156 | |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3157 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3158 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3159 | def visit_Compare(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3160 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3161 | Public method to handle a comparison. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3162 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3163 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3164 | @type ast.Compare |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3165 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3166 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3167 | isinstance(node.left, ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3168 | and self.__isSys("version_info", node.left.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3169 | and isinstance(node.left.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3170 | and AstUtilities.isNumber(node.left.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3171 | and AstUtilities.getValue(node.left.slice.value) == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3172 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3173 | and isinstance(node.ops[0], ast.Eq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3174 | and AstUtilities.isNumber(node.comparators[0]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3175 | and AstUtilities.getValue(node.comparators[0]) == 3 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3176 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3177 | self.violations.append((node.left, "M411")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3178 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3179 | self.__isSys("version", node.left) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3180 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3181 | and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3182 | and AstUtilities.isString(node.comparators[0]) |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3183 | ): |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3184 | if len(AstUtilities.getValue(node.comparators[0])) == 1: |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3185 | errorCode = "M422" |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3186 | else: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3187 | errorCode = "M403" |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3188 | self.violations.append((node.left, errorCode)) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3189 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3190 | isinstance(node.left, ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3191 | and self.__isSys("version_info", node.left.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3192 | and isinstance(node.left.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3193 | and AstUtilities.isNumber(node.left.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3194 | and AstUtilities.getValue(node.left.slice.value) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3195 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3196 | and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3197 | and AstUtilities.isNumber(node.comparators[0]) |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3198 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3199 | self.violations.append((node, "M413")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3200 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3201 | isinstance(node.left, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3202 | and self.__isSys("version_info", node.left.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3203 | and node.left.attr == "minor" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3204 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3205 | and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3206 | and AstUtilities.isNumber(node.comparators[0]) |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3207 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3208 | self.violations.append((node, "M414")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3209 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3210 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3211 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3212 | def visit_Attribute(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3213 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3214 | Public method to handle an attribute. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3215 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3216 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3217 | @type ast.Attribute |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3218 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3219 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3220 | isinstance(node.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3221 | and node.value.id == "six" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3222 | and node.attr == "PY3" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3223 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3224 | self.violations.append((node, "M412")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3225 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3226 | self.generic_visit(node) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3227 | |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3228 | def visit_Name(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3229 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3230 | Public method to handle an name. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3231 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3232 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3233 | @type ast.Name |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3234 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3235 | if node.id == "PY3" and self.__fromImports.get(node.id) == "six": |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3236 | self.violations.append((node, "M412")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3237 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3238 | self.generic_visit(node) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3239 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3240 | |
4555
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
3241 | # |
7639
422fd05e9c91
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7637
diff
changeset
|
3242 | # eflag: noqa = M891 |