Wed, 28 Oct 2015 19:47:16 +0100
Redid the future imports checker.
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
3 | # Copyright (c) 2015 Detlev Offenbach <detlev@die-offenbachs.de> |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10 | from __future__ import unicode_literals |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12 | import sys |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13 | import ast |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14 | import re |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17 | class MiscellaneousChecker(object): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19 | Class implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21 | Codes = [ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22 | "M101", "M102", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23 | "M111", "M112", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24 | "M121", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25 | "M131", |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
26 | "M701", "M702", |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27 | "M801", |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
28 | "M811", |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
29 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30 | "M901", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31 | ] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
32 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33 | def __init__(self, source, filename, select, ignore, expected, repeat, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34 | args): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36 | Constructor |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
38 | @param source source code to be checked |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
39 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
40 | @param filename name of the source file |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
41 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
42 | @param select list of selected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
43 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
44 | @param ignore list of codes to be ignored |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
45 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
46 | @param expected list of expected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
47 | @type list of str |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48 | @param repeat flag indicating to report each occurrence of a code |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
49 | @type bool |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
50 | @param args dictionary of arguments for the miscellaneous checks |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
51 | @type dict |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53 | self.__select = tuple(select) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54 | self.__ignore = ('',) if select else tuple(ignore) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55 | self.__expected = expected[:] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56 | self.__repeat = repeat |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57 | self.__filename = filename |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58 | self.__source = source[:] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59 | self.__args = args |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61 | self.__blindExceptRegex = re.compile( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62 | r'(except:)') # __IGNORE_WARNING__ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63 | self.__pep3101FormatRegex = re.compile( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64 | r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%') |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66 | # statistics counters |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67 | self.counters = {} |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69 | # collection of detected errors |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70 | self.errors = [] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72 | checkersWithCodes = [ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73 | # TODO: fill this |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74 | (self.__checkCoding, ("M101", "M102")), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75 | (self.__checkCopyright, ("M111", "M112")), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76 | (self.__checkBlindExcept, ("M121",)), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77 | (self.__checkPep3101, ("M131",)), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78 | (self.__checkPrintStatements, ("M801",)), |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
79 | (self.__checkTuple, ("M811", )), |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
80 | (self.__checkFuture, ("M701", "M702")), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81 | ] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83 | self.__defaultArgs = { |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84 | "CodingChecker": 'latin-1, utf-8', |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85 | "CopyrightChecker": { |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86 | "MinFilesize": 0, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87 | "Author": "", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
88 | }, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89 | } |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91 | self.__checkers = [] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
92 | for checker, codes in checkersWithCodes: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93 | if any(not (code and self.__ignoreCode(code)) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
94 | for code in codes): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95 | self.__checkers.append(checker) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97 | def __ignoreCode(self, code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99 | Private method to check if the message code should be ignored. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
101 | @param code message code to check for |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
102 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
103 | @return flag indicating to ignore the given code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
104 | @rtype bool |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106 | return (code.startswith(self.__ignore) and |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107 | not code.startswith(self.__select)) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109 | def __error(self, lineNumber, offset, code, *args): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111 | Private method to record an issue. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
113 | @param lineNumber line number of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
114 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
115 | @param offset position within line of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
116 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
117 | @param code message code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
118 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
119 | @param args arguments for the message |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
120 | @type list |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122 | if self.__ignoreCode(code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125 | if code in self.counters: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126 | self.counters[code] += 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128 | self.counters[code] = 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130 | # Don't care about expected codes |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131 | if code in self.__expected: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
133 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
134 | if code and (self.counters[code] == 1 or self.__repeat): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
135 | # record the issue with one based line number |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136 | self.errors.append( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137 | (self.__filename, lineNumber + 1, offset, (code, args))) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
138 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
139 | def __reportInvalidSyntax(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
140 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141 | Private method to report a syntax error. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
142 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
143 | exc_type, exc = sys.exc_info()[:2] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
144 | if len(exc.args) > 1: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
145 | offset = exc.args[1] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
146 | if len(offset) > 2: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
147 | offset = offset[1:3] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
148 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
149 | offset = (1, 0) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
150 | self.__error(offset[0] - 1, offset[1] or 0, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
151 | 'M901', exc_type.__name__, exc.args[0]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153 | def run(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
154 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155 | Public method to check the given source against miscellaneous |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156 | conditions. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158 | if not self.__filename: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
159 | # don't do anything, if essential data is missing |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
160 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
161 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
162 | if not self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
163 | # don't do anything, if no codes were selected |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
164 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
166 | try: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
167 | self.__tree = compile( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
168 | ''.join(self.__source), '', 'exec', ast.PyCF_ONLY_AST) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
169 | except (SyntaxError, TypeError): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
170 | self.__reportInvalidSyntax() |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
171 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
172 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
173 | for check in self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
174 | check() |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
175 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
176 | def __checkCoding(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
177 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
178 | Private method to check the presence of a coding line and valid |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
179 | encodings. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
180 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
181 | if len(self.__source) == 0: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
182 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
183 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
184 | encodings = [e.lower().strip() |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
185 | for e in self.__args.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
186 | "CodingChecker", self.__defaultArgs["CodingChecker"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
187 | .split(",")] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
188 | for lineno, line in enumerate(self.__source[:2]): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
189 | matched = re.search('coding[:=]\s*([-\w.]+)', line, re.IGNORECASE) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
190 | if matched: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
191 | if encodings and matched.group(1).lower() not in encodings: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
192 | self.__error(lineno, 0, "M102", matched.group(1)) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
193 | break |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
194 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
195 | self.__error(0, 0, "M101") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
196 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
197 | def __checkCopyright(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
198 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
199 | Private method to check the presence of a copyright statement. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
200 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
201 | source = "".join(self.__source) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202 | copyrightArgs = self.__args.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203 | "CopyrightChecker", self.__defaultArgs["CopyrightChecker"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
204 | copyrightMinFileSize = copyrightArgs.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
205 | "MinFilesize", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
206 | self.__defaultArgs["CopyrightChecker"]["MinFilesize"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
207 | copyrightAuthor = copyrightArgs.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
208 | "Author", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
209 | self.__defaultArgs["CopyrightChecker"]["Author"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
210 | copyrightRegexStr = \ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
211 | r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}" |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
212 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
213 | tocheck = max(1024, copyrightMinFileSize) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
214 | topOfSource = source[:tocheck] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
215 | if len(topOfSource) < copyrightMinFileSize: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
216 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
217 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
218 | copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
219 | re.IGNORECASE) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
220 | if not copyrightRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
221 | self.__error(0, 0, "M111") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
222 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
223 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
224 | if copyrightAuthor: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
225 | copyrightAuthorRe = re.compile( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
226 | copyrightRegexStr.format(author=copyrightAuthor), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
227 | re.IGNORECASE) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
228 | if not copyrightAuthorRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
229 | self.__error(0, 0, "M112") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
230 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
231 | def __checkBlindExcept(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
232 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
233 | Private method to check for blind except statements. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
234 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
235 | for lineno, line in enumerate(self.__source): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
236 | match = self.__blindExceptRegex.search(line) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
237 | if match: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
238 | self.__error(lineno, match.start(), "M121") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
239 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
240 | def __checkPep3101(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
241 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
242 | Private method to check for old style string formatting. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
243 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
244 | for lineno, line in enumerate(self.__source): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
245 | match = self.__pep3101FormatRegex.search(line) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
246 | if match: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
247 | lineLen = len(line) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
248 | pos = line.find('%') |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
249 | formatPos = pos |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
250 | formatter = '%' |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
251 | if line[pos + 1] == "(": |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
252 | pos = line.find(")", pos) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
253 | c = line[pos] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
254 | while c not in "diouxXeEfFgGcrs": |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
255 | pos += 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
256 | if pos >= lineLen: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
257 | break |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
258 | c = line[pos] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
259 | if c in "diouxXeEfFgGcrs": |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
260 | formatter += c |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
261 | self.__error(lineno, formatPos, "M131", formatter) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
262 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
263 | def __checkPrintStatements(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
264 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
265 | Private method to check for print statements. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
266 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
267 | for node in ast.walk(self.__tree): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
268 | if (isinstance(node, ast.Call) and |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
269 | getattr(node.func, 'id', None) == 'print') or \ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
270 | (hasattr(ast, 'Print') and isinstance(node, ast.Print)): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
271 | self.__error(node.lineno - 1, node.col_offset, "M801") |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
272 | |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
273 | def __checkTuple(self): |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
274 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
275 | Private method to check for one element tuples. |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
276 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
277 | for node in ast.walk(self.__tree): |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
278 | if isinstance(node, ast.Tuple) and \ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
279 | len(node.elts) == 1: |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
280 | self.__error(node.lineno - 1, node.col_offset, "M811") |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
281 | |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
282 | def __checkFuture(self): |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
283 | """ |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
284 | Private method to check the __future__ imports. |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
285 | """ |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
286 | expectedImports = set( |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
287 | [i.strip() |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
288 | for i in self.__args.get("FutureChecker", "").split(",") |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
289 | if bool(i.strip())]) |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
290 | if len(expectedImports) == 0: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
291 | # nothing to check for; disabling the check |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
292 | return |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
293 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
294 | imports = set() |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
295 | node = None |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
296 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
297 | for node in ast.walk(self.__tree): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
298 | if (isinstance(node, ast.ImportFrom) and |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
299 | node.module == '__future__'): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
300 | imports |= set(name.name for name in node.names) |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
301 | elif isinstance(node, ast.Expr): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
302 | if not isinstance(node.value, ast.Str): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
303 | break |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
304 | elif not isinstance(node, ast.Module): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
305 | break |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
306 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
307 | if isinstance(node, ast.Module): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
308 | return |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
309 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
310 | if not (imports >= expectedImports): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
311 | if imports: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
312 | self.__error(node.lineno - 1, node.col_offset, "M701", |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
313 | ", ".join(expectedImports), ", ".join(imports)) |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
314 | else: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
315 | self.__error(node.lineno - 1, node.col_offset, "M702", |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
316 | ", ".join(expectedImports)) |