Mon, 11 Mar 2024 16:50:06 +0100
Code Style Checker
- Updated miscellaneous checker to bugbear v24.2.6`.
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
10439
21c28b0f9e41
Updated copyright for 2024.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10437
diff
changeset
|
3 | # Copyright (c) 2015 - 2024 Detlev Offenbach <detlev@die-offenbachs.de> |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
10 | import ast |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
11 | import builtins |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
12 | import contextlib |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
13 | import copy |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
14 | import itertools |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
15 | import re |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
16 | import sys |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
17 | import tokenize |
9473
3f23dbf37dbe
Resorted the import statements using isort.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9327
diff
changeset
|
18 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
19 | from collections import defaultdict, namedtuple |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
20 | from keyword import iskeyword |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
21 | from string import Formatter |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22 | |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
23 | try: |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
24 | # Python 3.10+ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
25 | from itertools import pairwise |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
26 | except ImportError: |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
27 | # replacement for Python < 3.10 |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
28 | from itertools import tee |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
29 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
30 | def pairwise(iterable): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
31 | a, b = tee(iterable) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
32 | next(b, None) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
33 | return zip(a, b) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
34 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
35 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
36 | import AstUtilities |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
37 | |
8168
bdb0258faf42
Code Style Checker: reorganized the code a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8166
diff
changeset
|
38 | from .eradicate import Eradicator |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
39 | from .MiscellaneousDefaults import MiscellaneousCheckerDefaultArgs |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
40 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
42 | def composeCallPath(node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
43 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
44 | Generator function to assemble the call path of a given node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
45 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
46 | @param node node to assemble call path for |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
47 | @type ast.Node |
7988
c4c17121eff8
Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7980
diff
changeset
|
48 | @yield call path components |
c4c17121eff8
Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7980
diff
changeset
|
49 | @ytype str |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
50 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
51 | if isinstance(node, ast.Attribute): |
8205
4a0f1f896341
Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
52 | yield from composeCallPath(node.value) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
53 | yield node.attr |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
54 | elif isinstance(node, ast.Name): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
55 | yield node.id |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
56 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
57 | |
8207
d359172d11be
Applied some more code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8205
diff
changeset
|
58 | class MiscellaneousChecker: |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60 | Class implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
62 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63 | Codes = [ |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
64 | ## Coding line |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
65 | "M101", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
66 | "M102", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
67 | ## Copyright |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
68 | "M111", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
69 | "M112", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
70 | ## Shadowed Builtins |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
71 | "M131", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
72 | "M132", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
73 | ## Comprehensions |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
74 | "M180", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
75 | "M181", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
76 | "M182", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
77 | "M183", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
78 | "M184", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
79 | "M185", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
80 | "M186", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
81 | "M188", |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
82 | "M189", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
83 | "M189a", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
84 | "M189b", |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
85 | "M190", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
86 | "M190a", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
87 | "M190b", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
88 | "M191", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
89 | "M193", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
90 | "M193a", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
91 | "M193b", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
92 | "M193c", |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
93 | "M194", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
94 | "M195", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
95 | "M196", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
96 | "M197", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
97 | "M198", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
98 | "M199", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
99 | ## Dictionaries with sorted keys |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
100 | "M201", |
10085
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
101 | ## Property |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
102 | "M210", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
103 | "M211", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
104 | "M212", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
105 | "M213", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
106 | "M214", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
107 | "M215", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
108 | "M216", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
109 | "M217", |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
110 | ## Naive datetime usage |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
111 | "M301", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
112 | "M302", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
113 | "M303", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
114 | "M304", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
115 | "M305", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
116 | "M306", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
117 | "M307", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
118 | "M308", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
119 | "M311", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
120 | "M312", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
121 | "M313", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
122 | "M314", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
123 | "M315", |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
124 | "M321", |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
125 | ## sys.version and sys.version_info usage |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
126 | "M401", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
127 | "M402", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
128 | "M403", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
129 | "M411", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
130 | "M412", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
131 | "M413", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
132 | "M414", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
133 | "M421", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
134 | "M422", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
135 | "M423", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
136 | ## Bugbear |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
137 | "M501", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
138 | "M502", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
139 | "M503", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
140 | "M504", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
141 | "M505", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
142 | "M507", |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
143 | "M509", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
144 | "M510", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
145 | "M511", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
146 | "M512", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
147 | "M513", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
148 | "M514", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
149 | "M515", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
150 | "M516", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
151 | "M517", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
152 | "M518", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
153 | "M519", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
154 | "M520", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
155 | "M521", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
156 | "M522", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
157 | "M523", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
158 | "M524", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
159 | "M525", |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
160 | "M526", |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
161 | "M527", |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
162 | "M528", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
163 | "M529", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
164 | "M530", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
165 | "M531", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
166 | "M532", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
167 | "M533", |
10186
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
168 | "M534", |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
169 | "M535", |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
170 | "M536", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
171 | "M537", |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
172 | ## Bugbear, opininonated |
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
173 | "M569", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
174 | ## Bugbear++ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
175 | "M581", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
176 | "M582", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
177 | ## Format Strings |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
178 | "M601", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
179 | "M611", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
180 | "M612", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
181 | "M613", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
182 | "M621", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
183 | "M622", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
184 | "M623", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
185 | "M624", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
186 | "M625", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
187 | "M631", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
188 | "M632", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
189 | ## Future statements |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
190 | "M701", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
191 | "M702", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
192 | ## Gettext |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
193 | "M711", |
10085
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
194 | ## print() statements |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
195 | "M801", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
196 | ## one element tuple |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
197 | "M811", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
198 | ## Mutable Defaults |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
199 | "M821", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
200 | "M822", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
201 | ## return statements |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
202 | "M831", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
203 | "M832", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
204 | "M833", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
205 | "M834", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
206 | ## line continuation |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
207 | "M841", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
208 | ## implicitly concatenated strings |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
209 | "M851", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
210 | "M852", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
211 | "M853", |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
212 | ## commented code |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
213 | "M891", |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
214 | ] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
215 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
216 | Formatter = Formatter() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
217 | FormatFieldRegex = re.compile(r"^((?:\s|.)*?)(\..*|\[.*\])?$") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
218 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
219 | BuiltinsWhiteList = [ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
220 | "__name__", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
221 | "__doc__", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
222 | "credits", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
223 | ] |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
224 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
225 | def __init__(self, source, filename, tree, select, ignore, expected, repeat, args): |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
226 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
227 | Constructor |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
228 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
229 | @param source source code to be checked |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
230 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
231 | @param filename name of the source file |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
232 | @type str |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
233 | @param tree AST tree of the source code |
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
234 | @type ast.Module |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
235 | @param select list of selected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
236 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
237 | @param ignore list of codes to be ignored |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
238 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
239 | @param expected list of expected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
240 | @type list of str |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
241 | @param repeat flag indicating to report each occurrence of a code |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
242 | @type bool |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
243 | @param args dictionary of arguments for the miscellaneous checks |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
244 | @type dict |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
245 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
246 | self.__select = tuple(select) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
247 | self.__ignore = ("",) if select else tuple(ignore) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
248 | self.__expected = expected[:] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
249 | self.__repeat = repeat |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
250 | self.__filename = filename |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
251 | self.__source = source[:] |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
252 | self.__tree = copy.deepcopy(tree) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
253 | self.__args = args |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
254 | |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
255 | linesIterator = iter(self.__source) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
256 | self.__tokens = list(tokenize.generate_tokens(lambda: next(linesIterator))) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
257 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
258 | self.__pep3101FormatRegex = re.compile( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
259 | r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%' |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
260 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
261 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
262 | self.__builtins = [b for b in dir(builtins) if b not in self.BuiltinsWhiteList] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
263 | |
7972
4fc11172df1b
Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7923
diff
changeset
|
264 | self.__eradicator = Eradicator() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
265 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
266 | # statistics counters |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
267 | self.counters = {} |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
268 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
269 | # collection of detected errors |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
270 | self.errors = [] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
271 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
272 | checkersWithCodes = [ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
273 | (self.__checkCoding, ("M101", "M102")), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
274 | (self.__checkCopyright, ("M111", "M112")), |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
275 | (self.__checkBuiltins, ("M131", "M132")), |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
276 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
277 | self.__checkComprehensions, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
278 | ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
279 | "M180", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
280 | "M181", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
281 | "M182", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
282 | "M183", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
283 | "M184", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
284 | "M185", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
285 | "M186", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
286 | "M188", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
287 | "M189", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
288 | "M189a", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
289 | "M189b", |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
290 | "M190", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
291 | "M190a", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
292 | "M190b", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
293 | "M191", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
294 | "M193", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
295 | "M193a", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
296 | "M193b", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
297 | "M193c", |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
298 | "M194", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
299 | "M195", |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
300 | "M196", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
301 | "M197", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
302 | "M198", |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
303 | "M199", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
304 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
305 | ), |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
306 | (self.__checkDictWithSortedKeys, ("M201",)), |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
307 | ( |
10085
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
308 | self.__checkProperties, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
309 | ("M210", "M211", "M212", "M213", "M214", "M215", "M216", "M217"), |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
310 | ), |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
311 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
312 | self.__checkDateTime, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
313 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
314 | "M301", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
315 | "M302", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
316 | "M303", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
317 | "M304", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
318 | "M305", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
319 | "M306", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
320 | "M307", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
321 | "M308", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
322 | "M311", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
323 | "M312", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
324 | "M313", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
325 | "M314", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
326 | "M315", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
327 | "M321", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
328 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
329 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
330 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
331 | self.__checkSysVersion, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
332 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
333 | "M401", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
334 | "M402", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
335 | "M403", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
336 | "M411", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
337 | "M412", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
338 | "M413", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
339 | "M414", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
340 | "M421", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
341 | "M422", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
342 | "M423", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
343 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
344 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
345 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
346 | self.__checkBugBear, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
347 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
348 | "M501", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
349 | "M502", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
350 | "M503", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
351 | "M504", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
352 | "M505", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
353 | "M507", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
354 | "M509", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
355 | "M510", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
356 | "M511", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
357 | "M512", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
358 | "M513", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
359 | "M514", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
360 | "M515", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
361 | "M516", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
362 | "M517", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
363 | "M518", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
364 | "M519", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
365 | "M520", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
366 | "M521", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
367 | "M522", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
368 | "M523", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
369 | "M524", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
370 | "M525", |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
371 | "M526", |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
372 | "M527", |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
373 | "M528", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
374 | "M529", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
375 | "M530", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
376 | "M531", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
377 | "M532", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
378 | "M533", |
10186
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
379 | "M534", |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
380 | "M535", |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
381 | "M536", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
382 | "M537", |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
383 | "M569", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
384 | "M581", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
385 | "M582", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
386 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
387 | ), |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
388 | (self.__checkPep3101, ("M601",)), |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
389 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
390 | self.__checkFormatString, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
391 | ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
392 | "M611", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
393 | "M612", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
394 | "M613", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
395 | "M621", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
396 | "M622", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
397 | "M623", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
398 | "M624", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
399 | "M625", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
400 | "M631", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
401 | "M632", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
402 | ), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
403 | ), |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
404 | (self.__checkFuture, ("M701", "M702")), |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
405 | (self.__checkGettext, ("M711",)), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
406 | (self.__checkPrintStatements, ("M801",)), |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
407 | (self.__checkTuple, ("M811",)), |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
408 | (self.__checkMutableDefault, ("M821", "M822")), |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
409 | (self.__checkReturn, ("M831", "M832", "M833", "M834")), |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
410 | (self.__checkLineContinuation, ("M841",)), |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
411 | (self.__checkImplicitStringConcat, ("M851", "M852")), |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
412 | (self.__checkExplicitStringConcat, ("M853",)), |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
413 | (self.__checkCommentedCode, ("M891",)), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
414 | ] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
415 | |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
416 | # the eradicate whitelist |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
417 | commentedCodeCheckerArgs = self.__args.get( |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
418 | "CommentedCodeChecker", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
419 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
420 | ) |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
421 | commentedCodeCheckerWhitelist = commentedCodeCheckerArgs.get( |
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
422 | "WhiteList", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
423 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["WhiteList"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
424 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
425 | self.__eradicator.update_whitelist( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
426 | commentedCodeCheckerWhitelist, extend_default=False |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
427 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
428 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
429 | self.__checkers = [] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
430 | for checker, codes in checkersWithCodes: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
431 | if any(not (code and self.__ignoreCode(code)) for code in codes): |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
432 | self.__checkers.append(checker) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
433 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
434 | def __ignoreCode(self, code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
435 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
436 | Private method to check if the message code should be ignored. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
437 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
438 | @param code message code to check for |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
439 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
440 | @return flag indicating to ignore the given code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
441 | @rtype bool |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
442 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
443 | return code.startswith(self.__ignore) and not code.startswith(self.__select) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
444 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
445 | def __error(self, lineNumber, offset, code, *args): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
446 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
447 | Private method to record an issue. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
448 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
449 | @param lineNumber line number of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
450 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
451 | @param offset position within line of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
452 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
453 | @param code message code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
454 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
455 | @param args arguments for the message |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
456 | @type list |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
457 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
458 | if self.__ignoreCode(code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
459 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
460 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
461 | if code in self.counters: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
462 | self.counters[code] += 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
463 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
464 | self.counters[code] = 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
465 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
466 | # Don't care about expected codes |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
467 | if code in self.__expected: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
468 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
469 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
470 | if code and (self.counters[code] == 1 or self.__repeat): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
471 | # record the issue with one based line number |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
472 | self.errors.append( |
7610
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
473 | { |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
474 | "file": self.__filename, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
475 | "line": lineNumber + 1, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
476 | "offset": offset, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
477 | "code": code, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
478 | "args": args, |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
479 | } |
df7025fe26a3
Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7360
diff
changeset
|
480 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
481 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
482 | def run(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
483 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
484 | Public method to check the given source against miscellaneous |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
485 | conditions. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
486 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
487 | if not self.__filename: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
488 | # don't do anything, if essential data is missing |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
489 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
490 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
491 | if not self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
492 | # don't do anything, if no codes were selected |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
493 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
494 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
495 | for check in self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
496 | check() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
497 | |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
498 | def __getCoding(self): |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
499 | """ |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
500 | Private method to get the defined coding of the source. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
501 | |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
502 | @return tuple containing the line number and the coding |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
503 | @rtype tuple of int and str |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
504 | """ |
6106
921d070cec82
Finished implementing support for EditorConfig.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6100
diff
changeset
|
505 | for lineno, line in enumerate(self.__source[:5]): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
506 | matched = re.search(r"coding[:=]\s*([-\w_.]+)", line, re.IGNORECASE) |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
507 | if matched: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
508 | return lineno, matched.group(1) |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
509 | else: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
510 | return 0, "" |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
511 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
512 | def __checkCoding(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
513 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
514 | Private method to check the presence of a coding line and valid |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
515 | encodings. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
516 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
517 | if len(self.__source) == 0: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
518 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
519 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
520 | encodings = [ |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
521 | e.lower().strip() |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
522 | for e in self.__args.get( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
523 | "CodingChecker", MiscellaneousCheckerDefaultArgs["CodingChecker"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
524 | ).split(",") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
525 | ] |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
526 | lineno, coding = self.__getCoding() |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
527 | if coding: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
528 | if coding.lower() not in encodings: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
529 | self.__error(lineno, 0, "M102", coding) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
530 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
531 | self.__error(0, 0, "M101") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
532 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
533 | def __checkCopyright(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
534 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
535 | Private method to check the presence of a copyright statement. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
536 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
537 | source = "".join(self.__source) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
538 | copyrightArgs = self.__args.get( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
539 | "CopyrightChecker", MiscellaneousCheckerDefaultArgs["CopyrightChecker"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
540 | ) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
541 | copyrightMinFileSize = copyrightArgs.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
542 | "MinFilesize", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
543 | MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["MinFilesize"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
544 | ) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
545 | copyrightAuthor = copyrightArgs.get( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
546 | "Author", MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["Author"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
547 | ) |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
548 | copyrightRegexStr = ( |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
549 | r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}" |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
550 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
551 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
552 | tocheck = max(1024, copyrightMinFileSize) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
553 | topOfSource = source[:tocheck] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
554 | if len(topOfSource) < copyrightMinFileSize: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
555 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
556 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
557 | copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"), re.IGNORECASE) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
558 | if not copyrightRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
559 | self.__error(0, 0, "M111") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
560 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
561 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
562 | if copyrightAuthor: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
563 | copyrightAuthorRe = re.compile( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
564 | copyrightRegexStr.format(author=copyrightAuthor), re.IGNORECASE |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
565 | ) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
566 | if not copyrightAuthorRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
567 | self.__error(0, 0, "M112") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
568 | |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
569 | def __checkCommentedCode(self): |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
570 | """ |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
571 | Private method to check for commented code. |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
572 | """ |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
573 | source = "".join(self.__source) |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
574 | commentedCodeCheckerArgs = self.__args.get( |
7980
2c3f14a3c595
CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7972
diff
changeset
|
575 | "CommentedCodeChecker", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
576 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
577 | ) |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
578 | aggressive = commentedCodeCheckerArgs.get( |
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
579 | "Aggressive", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
580 | MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["Aggressive"], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
581 | ) |
7972
4fc11172df1b
Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7923
diff
changeset
|
582 | for markedLine in self.__eradicator.commented_out_code_line_numbers( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
583 | source, aggressive=aggressive |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
584 | ): |
7040
f89952e5fc11
Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7021
diff
changeset
|
585 | self.__error(markedLine - 1, 0, "M891") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
586 | |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
587 | def __checkLineContinuation(self): |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
588 | """ |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
589 | Private method to check line continuation using backslash. |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
590 | """ |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
591 | # generate source lines without comments |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
592 | comments = [tok for tok in self.__tokens if tok[0] == tokenize.COMMENT] |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
593 | stripped = self.__source[:] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
594 | for comment in comments: |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
595 | lineno = comment[3][0] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
596 | start = comment[2][1] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
597 | stop = comment[3][1] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
598 | content = stripped[lineno - 1] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
599 | withoutComment = content[:start] + content[stop:] |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
600 | stripped[lineno - 1] = withoutComment.rstrip() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
601 | |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
602 | # perform check with 'cleaned' source |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
603 | for lineIndex, line in enumerate(stripped): |
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
604 | strippedLine = line.strip() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
605 | if strippedLine.endswith("\\") and not strippedLine.startswith( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
606 | ("assert", "with") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
607 | ): |
7042
2be5b245e1b8
Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7040
diff
changeset
|
608 | self.__error(lineIndex, len(line), "M841") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
609 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
610 | def __checkPrintStatements(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
611 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
612 | Private method to check for print statements. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
613 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
614 | for node in ast.walk(self.__tree): |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
615 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
616 | isinstance(node, ast.Call) and getattr(node.func, "id", None) == "print" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
617 | ) or (hasattr(ast, "Print") and isinstance(node, ast.Print)): |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
618 | self.__error(node.lineno - 1, node.col_offset, "M801") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
619 | |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
620 | def __checkTuple(self): |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
621 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
622 | Private method to check for one element tuples. |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
623 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
624 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
625 | if isinstance(node, ast.Tuple) and len(node.elts) == 1: |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
626 | self.__error(node.lineno - 1, node.col_offset, "M811") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
627 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
628 | def __checkFuture(self): |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
629 | """ |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
630 | Private method to check the __future__ imports. |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
631 | """ |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
632 | expectedImports = { |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
633 | i.strip() |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
634 | for i in self.__args.get("FutureChecker", "").split(",") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
635 | if bool(i.strip()) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
636 | } |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
637 | if len(expectedImports) == 0: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
638 | # nothing to check for; disabling the check |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
639 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
640 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
641 | imports = set() |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
642 | node = None |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
643 | hasCode = False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
644 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
645 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
646 | if isinstance(node, ast.ImportFrom) and node.module == "__future__": |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
647 | imports |= {name.name for name in node.names} |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
648 | elif isinstance(node, ast.Expr): |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
649 | if not AstUtilities.isString(node.value): |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
650 | hasCode = True |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
651 | break |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
652 | elif not (AstUtilities.isString(node) or isinstance(node, ast.Module)): |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
653 | hasCode = True |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
654 | break |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
655 | |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
656 | if isinstance(node, ast.Module) or not hasCode: |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
657 | return |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
658 | |
8205
4a0f1f896341
Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8198
diff
changeset
|
659 | if imports < expectedImports: |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
660 | if imports: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
661 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
662 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
663 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
664 | "M701", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
665 | ", ".join(expectedImports), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
666 | ", ".join(imports), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
667 | ) |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
668 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
669 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
670 | node.lineno - 1, node.col_offset, "M702", ", ".join(expectedImports) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
671 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
672 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
673 | def __checkPep3101(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
674 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
675 | Private method to check for old style string formatting. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
676 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
677 | for lineno, line in enumerate(self.__source): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
678 | match = self.__pep3101FormatRegex.search(line) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
679 | if match: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
680 | lineLen = len(line) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
681 | pos = line.find("%") |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
682 | formatPos = pos |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
683 | formatter = "%" |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
684 | if line[pos + 1] == "(": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
685 | pos = line.find(")", pos) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
686 | c = line[pos] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
687 | while c not in "diouxXeEfFgGcrs": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
688 | pos += 1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
689 | if pos >= lineLen: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
690 | break |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
691 | c = line[pos] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
692 | if c in "diouxXeEfFgGcrs": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
693 | formatter += c |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
694 | self.__error(lineno, formatPos, "M601", formatter) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
695 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
696 | def __checkFormatString(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
697 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
698 | Private method to check string format strings. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
699 | """ |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
700 | coding = self.__getCoding()[1] |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
701 | if not coding: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
702 | # default to utf-8 |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
703 | coding = "utf-8" |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
704 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
705 | visitor = TextVisitor() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
706 | visitor.visit(self.__tree) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
707 | for node in visitor.nodes: |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
708 | text = node.value |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
709 | if isinstance(text, bytes): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
710 | try: |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
711 | text = text.decode(coding) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
712 | except UnicodeDecodeError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
713 | continue |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
714 | fields, implicit, explicit = self.__getFields(text) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
715 | if implicit: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
716 | if node in visitor.calls: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
717 | self.__error(node.lineno - 1, node.col_offset, "M611") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
718 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
719 | if node.is_docstring: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
720 | self.__error(node.lineno - 1, node.col_offset, "M612") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
721 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
722 | self.__error(node.lineno - 1, node.col_offset, "M613") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
723 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
724 | if node in visitor.calls: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
725 | call, strArgs = visitor.calls[node] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
726 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
727 | numbers = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
728 | names = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
729 | # Determine which fields require a keyword and which an arg |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
730 | for name in fields: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
731 | fieldMatch = self.FormatFieldRegex.match(name) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
732 | try: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
733 | number = int(fieldMatch.group(1)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
734 | except ValueError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
735 | number = -1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
736 | # negative numbers are considered keywords |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
737 | if number >= 0: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
738 | numbers.add(number) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
739 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
740 | names.add(fieldMatch.group(1)) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
741 | |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
742 | keywords = {keyword.arg for keyword in call.keywords} |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
743 | numArgs = len(call.args) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
744 | if strArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
745 | numArgs -= 1 |
7894
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
746 | hasKwArgs = any(kw.arg is None for kw in call.keywords) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
747 | hasStarArgs = sum( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
748 | 1 for arg in call.args if isinstance(arg, ast.Starred) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
749 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
750 | |
7894
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
751 | if hasKwArgs: |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
752 | keywords.discard(None) |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
753 | if hasStarArgs: |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
754 | numArgs -= 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
755 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
756 | # if starargs or kwargs is not None, it can't count the |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
757 | # parameters but at least check if the args are used |
8222
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
758 | if hasKwArgs and not names: |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
759 | # No names but kwargs |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
760 | self.__error(call.lineno - 1, call.col_offset, "M623") |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
761 | if hasStarArgs and not numbers: |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
762 | # No numbers but args |
5994b80b8760
Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8218
diff
changeset
|
763 | self.__error(call.lineno - 1, call.col_offset, "M624") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
764 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
765 | if not hasKwArgs and not hasStarArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
766 | # can actually verify numbers and names |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
767 | for number in sorted(numbers): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
768 | if number >= numArgs: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
769 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
770 | call.lineno - 1, call.col_offset, "M621", number |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
771 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
772 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
773 | for name in sorted(names): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
774 | if name not in keywords: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
775 | self.__error(call.lineno - 1, call.col_offset, "M622", name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
776 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
777 | for arg in range(numArgs): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
778 | if arg not in numbers: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
779 | self.__error(call.lineno - 1, call.col_offset, "M631", arg) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
780 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
781 | for keyword in keywords: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
782 | if keyword not in names: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
783 | self.__error(call.lineno - 1, call.col_offset, "M632", keyword) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
784 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
785 | if implicit and explicit: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
786 | self.__error(call.lineno - 1, call.col_offset, "M625") |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
787 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
788 | def __getFields(self, string): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
789 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
790 | Private method to extract the format field information. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
791 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
792 | @param string format string to be parsed |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
793 | @type str |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
794 | @return format field information as a tuple with fields, implicit |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
795 | field definitions present and explicit field definitions present |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
796 | @rtype tuple of set of str, bool, bool |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
797 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
798 | fields = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
799 | cnt = itertools.count() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
800 | implicit = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
801 | explicit = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
802 | try: |
6188
5a6ae3be31e6
Fixed some loop related coding issues detected by the extended code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6184
diff
changeset
|
803 | for _literal, field, spec, conv in self.Formatter.parse(string): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
804 | if field is not None and (conv is None or conv in "rsa"): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
805 | if not field: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
806 | field = str(next(cnt)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
807 | implicit = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
808 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
809 | explicit = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
810 | fields.add(field) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
811 | fields.update( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
812 | parsedSpec[1] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
813 | for parsedSpec in self.Formatter.parse(spec) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
814 | if parsedSpec[1] is not None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
815 | ) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
816 | except ValueError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
817 | return set(), False, False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
818 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
819 | return fields, implicit, explicit |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
820 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
821 | def __checkBuiltins(self): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
822 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
823 | Private method to check, if built-ins are shadowed. |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
824 | """ |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
825 | functionDefs = [ast.FunctionDef] |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
826 | with contextlib.suppress(AttributeError): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
827 | functionDefs.append(ast.AsyncFunctionDef) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
828 | |
5619
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
829 | ignoreBuiltinAssignments = self.__args.get( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
830 | "BuiltinsChecker", MiscellaneousCheckerDefaultArgs["BuiltinsChecker"] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
831 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
832 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
833 | for node in ast.walk(self.__tree): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
834 | if isinstance(node, ast.Assign): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
835 | # assign statement |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
836 | for element in node.targets: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
837 | if isinstance(element, ast.Name) and element.id in self.__builtins: |
5617
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
838 | value = node.value |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
839 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
840 | isinstance(value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
841 | and element.id in ignoreBuiltinAssignments |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
842 | and value.id in ignoreBuiltinAssignments[element.id] |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
843 | ): |
5617
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
844 | # ignore compatibility assignments |
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
845 | continue |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
846 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
847 | element.lineno - 1, element.col_offset, "M131", element.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
848 | ) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
849 | elif isinstance(element, (ast.Tuple, ast.List)): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
850 | for tupleElement in element.elts: |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
851 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
852 | isinstance(tupleElement, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
853 | and tupleElement.id in self.__builtins |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
854 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
855 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
856 | tupleElement.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
857 | tupleElement.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
858 | "M131", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
859 | tupleElement.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
860 | ) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
861 | elif isinstance(node, ast.For): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
862 | # for loop |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
863 | target = node.target |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
864 | if isinstance(target, ast.Name) and target.id in self.__builtins: |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
865 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
866 | target.lineno - 1, target.col_offset, "M131", target.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
867 | ) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
868 | elif isinstance(target, (ast.Tuple, ast.List)): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
869 | for element in target.elts: |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
870 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
871 | isinstance(element, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
872 | and element.id in self.__builtins |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
873 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
874 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
875 | element.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
876 | element.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
877 | "M131", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
878 | element.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
879 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
880 | elif any(isinstance(node, functionDef) for functionDef in functionDefs): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
881 | # (asynchronous) function definition |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
882 | for arg in node.args.args: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
883 | if isinstance(arg, ast.arg) and arg.arg in self.__builtins: |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
884 | self.__error(arg.lineno - 1, arg.col_offset, "M132", arg.arg) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
885 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
886 | def __checkComprehensions(self): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
887 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
888 | Private method to check some comprehension related things. |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
889 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
890 | This method is adapted from: flake8-comprehensions v3.14.0 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
891 | Original: Copyright (c) 2017 Adam Johnson |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
892 | """ |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
893 | visitedMapCalls = set() |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
894 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
895 | for node in ast.walk(self.__tree): |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
896 | if isinstance(node, ast.Call) and isinstance(node.func, ast.Name): |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
897 | numPositionalArgs = len(node.args) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
898 | numKeywordArgs = len(node.keywords) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
899 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
900 | if ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
901 | numPositionalArgs == 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
902 | and isinstance(node.args[0], ast.GeneratorExp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
903 | and node.func.id in ("list", "set") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
904 | ): |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
905 | errorCode = { |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
906 | "list": "M180", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
907 | "set": "M181", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
908 | }[node.func.id] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
909 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
910 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
911 | elif ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
912 | numPositionalArgs == 1 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
913 | and node.func.id == "dict" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
914 | and len(node.keywords) == 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
915 | and isinstance(node.args[0], (ast.GeneratorExp, ast.ListComp)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
916 | and isinstance(node.args[0].elt, ast.Tuple) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
917 | and len(node.args[0].elt.elts) == 2 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
918 | ): |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
919 | if isinstance(node.args[0], ast.GeneratorExp): |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
920 | errorCode = "M182" |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
921 | else: |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
922 | errorCode = "M184" |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
923 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
924 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
925 | elif ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
926 | numPositionalArgs == 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
927 | and isinstance(node.args[0], ast.ListComp) |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
928 | and node.func.id in ("list", "set", "any", "all") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
929 | ): |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
930 | errorCode = { |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
931 | "list": "M191", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
932 | "set": "M183", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
933 | "any": "M199", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
934 | "all": "M199", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
935 | }[node.func.id] |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
936 | self.__error( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
937 | node.lineno - 1, node.col_offset, errorCode, node.func.id |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
938 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
939 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
940 | elif numPositionalArgs == 1 and ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
941 | isinstance(node.args[0], ast.Tuple) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
942 | and node.func.id == "tuple" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
943 | or isinstance(node.args[0], ast.List) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
944 | and node.func.id == "list" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
945 | ): |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
946 | errorCode = { |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
947 | "tuple": "M189a", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
948 | "list": "M190a", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
949 | }[node.func.id] |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
950 | self.__error( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
951 | node.lineno - 1, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
952 | node.col_offset, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
953 | errorCode, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
954 | type(node.args[0]).__name__.lower(), |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
955 | node.func.id, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
956 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
957 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
958 | elif ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
959 | numPositionalArgs == 1 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
960 | and numKeywordArgs == 0 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
961 | and isinstance(node.args[0], (ast.Dict, ast.DictComp)) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
962 | and node.func.id == "dict" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
963 | ): |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
964 | if isinstance(node.args[0], ast.Dict): |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
965 | type_ = "dict" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
966 | else: |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
967 | type_ = "dict comprehension" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
968 | self.__error( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
969 | node.lineno - 1, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
970 | node.col_offset, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
971 | "M198", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
972 | type_, |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
973 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
974 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
975 | elif ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
976 | numPositionalArgs == 1 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
977 | and isinstance(node.args[0], (ast.Tuple, ast.List)) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
978 | and ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
979 | node.func.id in ("tuple", "list", "set") |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
980 | or ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
981 | node.func.id == "dict" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
982 | and all( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
983 | isinstance(elt, ast.Tuple) and len(elt.elts) == 2 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
984 | for elt in node.args[0].elts |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
985 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
986 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
987 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
988 | ): |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
989 | errorCode = { |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
990 | "tuple": "M189b", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
991 | "list": "M190b", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
992 | "set": "M185", |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
993 | "dict": "M186", |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
994 | }[node.func.id] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
995 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
996 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
997 | node.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
998 | errorCode, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
999 | type(node.args[0]).__name__.lower(), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1000 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1001 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1002 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1003 | elif ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1004 | numPositionalArgs == 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1005 | and not any(isinstance(a, ast.Starred) for a in node.args) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1006 | and not any(k.arg is None for k in node.keywords) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1007 | and node.func.id == "dict" |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1008 | ) or ( |
10371
1f54843e8152
Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10362
diff
changeset
|
1009 | numPositionalArgs == 0 |
1f54843e8152
Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10362
diff
changeset
|
1010 | and numKeywordArgs == 0 |
1f54843e8152
Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10362
diff
changeset
|
1011 | and node.func.id in ("tuple", "list") |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1012 | ): |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1013 | self.__error(node.lineno - 1, node.col_offset, "M188", node.func.id) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1014 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1015 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1016 | node.func.id in {"list", "reversed"} |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1017 | and numPositionalArgs > 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1018 | and isinstance(node.args[0], ast.Call) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1019 | and isinstance(node.args[0].func, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1020 | and node.args[0].func.id == "sorted" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1021 | ): |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1022 | if node.func.id == "reversed": |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1023 | reverseFlagValue = False |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1024 | for kw in node.args[0].keywords: |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1025 | if kw.arg != "reverse": |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1026 | continue |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1027 | reverseFlagValue = ( |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1028 | bool(kw.value.value) |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1029 | if isinstance(kw.value, ast.Constant) |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1030 | else None |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1031 | ) |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1032 | |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1033 | if reverseFlagValue is None: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1034 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1035 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1036 | node.col_offset, |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1037 | "M193a", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1038 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1039 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1040 | ) |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1041 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1042 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1043 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1044 | node.col_offset, |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1045 | "M193b", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1046 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1047 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1048 | not reverseFlagValue, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1049 | ) |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1050 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1051 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1052 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1053 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1054 | node.col_offset, |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1055 | "M193c", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1056 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1057 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1058 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1059 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1060 | elif ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1061 | numPositionalArgs > 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1062 | and isinstance(node.args[0], ast.Call) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1063 | and isinstance(node.args[0].func, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1064 | and ( |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1065 | ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1066 | node.func.id in {"set", "sorted"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1067 | and node.args[0].func.id |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1068 | in {"list", "reversed", "sorted", "tuple"} |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1069 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1070 | or ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1071 | node.func.id in {"list", "tuple"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1072 | and node.args[0].func.id in {"list", "tuple"} |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1073 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1074 | or (node.func.id == "set" and node.args[0].func.id == "set") |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1075 | ) |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1076 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1077 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1078 | node.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1079 | node.col_offset, |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1080 | "M194", |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1081 | node.args[0].func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1082 | node.func.id, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1083 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1084 | |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1085 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1086 | node.func.id in {"reversed", "set", "sorted"} |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1087 | and numPositionalArgs > 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1088 | and isinstance(node.args[0], ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1089 | and isinstance(node.args[0].slice, ast.Slice) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1090 | and node.args[0].slice.lower is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1091 | and node.args[0].slice.upper is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1092 | and isinstance(node.args[0].slice.step, ast.UnaryOp) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1093 | and isinstance(node.args[0].slice.step.op, ast.USub) |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1094 | and isinstance(node.args[0].slice.step.operand, ast.Constant) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1095 | and node.args[0].slice.step.operand.n == 1 |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1096 | ): |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1097 | self.__error(node.lineno - 1, node.col_offset, "M195", node.func.id) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1098 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1099 | elif ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1100 | node.func.id == "map" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1101 | and node not in visitedMapCalls |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1102 | and len(node.args) == 2 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1103 | and isinstance(node.args[0], ast.Lambda) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1104 | ): |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1105 | self.__error( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1106 | node.lineno - 1, node.col_offset, "M197", "generator expression" |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1107 | ) |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1108 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1109 | elif ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1110 | node.func.id in ("list", "set", "dict") |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1111 | and len(node.args) == 1 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1112 | and isinstance(node.args[0], ast.Call) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1113 | and isinstance(node.args[0].func, ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1114 | and node.args[0].func.id == "map" |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1115 | and len(node.args[0].args) == 2 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1116 | and isinstance(node.args[0].args[0], ast.Lambda) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1117 | ): |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1118 | # To avoid raising M197 on the map() call inside the list/set/dict. |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1119 | mapCall = node.args[0] |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1120 | visitedMapCalls.add(mapCall) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1121 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1122 | rewriteable = True |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1123 | if node.func.id == "dict": |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1124 | # For the generator expression to be rewriteable as a |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1125 | # dict comprehension, its lambda must return a 2-tuple. |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1126 | lambdaNode = node.args[0].args[0] |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1127 | if ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1128 | not isinstance(lambdaNode.body, (ast.List, ast.Tuple)) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1129 | or len(lambdaNode.body.elts) != 2 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1130 | ): |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1131 | rewriteable = False |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1132 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1133 | if rewriteable: |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1134 | comprehensionType = f"{node.func.id} comprehension" |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1135 | self.__error( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1136 | node.lineno - 1, node.col_offset, "M197", comprehensionType |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1137 | ) |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1138 | |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1139 | elif isinstance(node, (ast.DictComp, ast.ListComp, ast.SetComp)) and ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1140 | len(node.generators) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1141 | and not node.generators[0].ifs |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1142 | and not node.generators[0].is_async |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1143 | and ( |
10360
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1144 | ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1145 | isinstance(node, (ast.ListComp, ast.SetComp)) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1146 | and isinstance(node.elt, ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1147 | and isinstance(node.generators[0].target, ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1148 | and node.elt.id == node.generators[0].target.id |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1149 | ) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1150 | or ( |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1151 | isinstance(node, ast.DictComp) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1152 | and isinstance(node.key, ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1153 | and isinstance(node.value, ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1154 | and isinstance(node.generators[0].target, ast.Tuple) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1155 | and len(node.generators[0].target.elts) == 2 |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1156 | and isinstance(node.generators[0].target.elts[0], ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1157 | and node.generators[0].target.elts[0].id == node.key.id |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1158 | and isinstance(node.generators[0].target.elts[1], ast.Name) |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1159 | and node.generators[0].target.elts[1].id == node.value.id |
9ffdb1490bd2
Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10359
diff
changeset
|
1160 | ) |
8759
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1161 | ) |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1162 | ): |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1163 | compType = { |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1164 | ast.DictComp: "dict", |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1165 | ast.ListComp: "list", |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1166 | ast.SetComp: "set", |
7efebdfa5dc2
Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8312
diff
changeset
|
1167 | }[node.__class__] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1168 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1169 | self.__error(node.lineno - 1, node.col_offset, "M196", compType) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1170 | |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1171 | def __checkMutableDefault(self): |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1172 | """ |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1173 | Private method to check for use of mutable types as default arguments. |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1174 | """ |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1175 | mutableTypes = ( |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1176 | ast.Call, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1177 | ast.Dict, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1178 | ast.List, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1179 | ast.Set, |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1180 | ast.DictComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1181 | ast.ListComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1182 | ast.SetComp, |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1183 | ) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1184 | mutableCalls = ( |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1185 | "Counter", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1186 | "OrderedDict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1187 | "collections.Counter", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1188 | "collections.OrderedDict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1189 | "collections.defaultdict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1190 | "collections.deque", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1191 | "defaultdict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1192 | "deque", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1193 | "dict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1194 | "list", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1195 | "set", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1196 | ) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1197 | immutableCalls = ( |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1198 | "tuple", |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1199 | "frozenset", |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1200 | "types.MappingProxyType", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1201 | "MappingProxyType", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1202 | "re.compile", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1203 | "operator.attrgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1204 | "operator.itemgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1205 | "operator.methodcaller", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1206 | "attrgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1207 | "itemgetter", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1208 | "methodcaller", |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1209 | ) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1210 | functionDefs = [ast.FunctionDef] |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
1211 | with contextlib.suppress(AttributeError): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1212 | functionDefs.append(ast.AsyncFunctionDef) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1213 | |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
1214 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1215 | if any(isinstance(node, functionDef) for functionDef in functionDefs): |
7057
0e8d3b0c4889
MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7045
diff
changeset
|
1216 | defaults = node.args.defaults[:] |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
1217 | with contextlib.suppress(AttributeError): |
7057
0e8d3b0c4889
MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7045
diff
changeset
|
1218 | defaults += node.args.kw_defaults[:] |
0e8d3b0c4889
MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7045
diff
changeset
|
1219 | for default in defaults: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1220 | if any( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1221 | isinstance(default, mutableType) for mutableType in mutableTypes |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1222 | ): |
5703
7650c11cc5f2
MiscChecker, ast: No special case for Python 2 needed.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
5649
diff
changeset
|
1223 | typeName = type(default).__name__ |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
1224 | if isinstance(default, ast.Call): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1225 | callPath = ".".join(composeCallPath(default.func)) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1226 | if callPath in mutableCalls: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1227 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1228 | default.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1229 | default.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1230 | "M823", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1231 | callPath + "()", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1232 | ) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1233 | elif callPath not in immutableCalls: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1234 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1235 | default.lineno - 1, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1236 | default.col_offset, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1237 | "M822", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1238 | typeName, |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1239 | ) |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
1240 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1241 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1242 | default.lineno - 1, default.col_offset, "M821", typeName |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1243 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1244 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1245 | def __dictShouldBeChecked(self, node): |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1246 | """ |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1247 | Private function to test, if the node should be checked. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1248 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1249 | @param node reference to the AST node |
10437
2f70ca07f0af
Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10417
diff
changeset
|
1250 | @type ast.Dict |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1251 | @return flag indicating to check the node |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1252 | @rtype bool |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1253 | """ |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1254 | if not all(AstUtilities.isString(key) for key in node.keys): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1255 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1256 | |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1257 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1258 | "__IGNORE_WARNING__" in self.__source[node.lineno - 1] |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1259 | or "__IGNORE_WARNING_M201__" in self.__source[node.lineno - 1] |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1260 | ): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1261 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1262 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1263 | lineNumbers = [key.lineno for key in node.keys] |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1264 | return len(lineNumbers) == len(set(lineNumbers)) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1265 | |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1266 | def __checkDictWithSortedKeys(self): |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1267 | """ |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1268 | Private method to check, if dictionary keys appear in sorted order. |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1269 | """ |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1270 | for node in ast.walk(self.__tree): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
1271 | if isinstance(node, ast.Dict) and self.__dictShouldBeChecked(node): |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
1272 | for key1, key2 in zip(node.keys, node.keys[1:]): |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1273 | if key2.value < key1.value: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1274 | self.__error( |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1275 | key2.lineno - 1, |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1276 | key2.col_offset, |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1277 | "M201", |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1278 | key2.value, |
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
1279 | key1.value, |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1280 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1281 | |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1282 | def __checkGettext(self): |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1283 | """ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1284 | Private method to check the 'gettext' import statement. |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1285 | """ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
1286 | for node in ast.walk(self.__tree): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1287 | if isinstance(node, ast.ImportFrom) and any( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1288 | name.asname == "_" for name in node.names |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
1289 | ): |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1290 | self.__error( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1291 | node.lineno - 1, node.col_offset, "M711", node.names[0].name |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1292 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1293 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1294 | def __checkBugBear(self): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1295 | """ |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
1296 | Private method for bugbear checks. |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1297 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1298 | visitor = BugBearVisitor() |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1299 | visitor.visit(self.__tree) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1300 | for violation in visitor.violations: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1301 | node = violation[0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1302 | reason = violation[1] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1303 | params = violation[2:] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1304 | self.__error(node.lineno - 1, node.col_offset, reason, *params) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1305 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1306 | def __checkReturn(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1307 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1308 | Private method to check return statements. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1309 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1310 | visitor = ReturnVisitor() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1311 | visitor.visit(self.__tree) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1312 | for violation in visitor.violations: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1313 | node = violation[0] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1314 | reason = violation[1] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1315 | self.__error(node.lineno - 1, node.col_offset, reason) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1316 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1317 | def __checkDateTime(self): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1318 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1319 | Private method to check use of naive datetime functions. |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
1320 | """ |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1321 | # step 1: generate an augmented node tree containing parent info |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1322 | # for each child node |
8198
1c765dc90c21
Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8168
diff
changeset
|
1323 | tree = copy.deepcopy(self.__tree) |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1324 | for node in ast.walk(tree): |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1325 | for childNode in ast.iter_child_nodes(node): |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1326 | childNode._dtCheckerParent = node |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1327 | |
7637
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1328 | # step 2: perform checks and report issues |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1329 | visitor = DateTimeVisitor() |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1330 | visitor.visit(tree) |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1331 | for violation in visitor.violations: |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1332 | node = violation[0] |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1333 | reason = violation[1] |
c878e8255972
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7610
diff
changeset
|
1334 | self.__error(node.lineno - 1, node.col_offset, reason) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1335 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1336 | def __checkSysVersion(self): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1337 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1338 | Private method to check the use of sys.version and sys.version_info. |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1339 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1340 | visitor = SysVersionVisitor() |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1341 | visitor.visit(self.__tree) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1342 | for violation in visitor.violations: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1343 | node = violation[0] |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1344 | reason = violation[1] |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
1345 | self.__error(node.lineno - 1, node.col_offset, reason) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1346 | |
10085
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1347 | def __checkProperties(self): |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1348 | """ |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1349 | Private method to check for issue with property related methods. |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1350 | """ |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1351 | properties = [] |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1352 | for node in ast.walk(self.__tree): |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1353 | if isinstance(node, ast.ClassDef): |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1354 | properties.clear() |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1355 | |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1356 | elif isinstance(node, ast.FunctionDef): |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1357 | propertyCount = 0 |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1358 | for decorator in node.decorator_list: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1359 | # property getter method |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1360 | if isinstance(decorator, ast.Name) and decorator.id == "property": |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1361 | propertyCount += 1 |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1362 | properties.append(node.name) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1363 | if len(node.args.args) != 1: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1364 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1365 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1366 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1367 | "M210", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1368 | len(node.args.args), |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1369 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1370 | |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1371 | if isinstance(decorator, ast.Attribute): |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1372 | # property setter method |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1373 | if decorator.attr == "setter": |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1374 | propertyCount += 1 |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1375 | if node.name != decorator.value.id: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1376 | if node.name in properties: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1377 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1378 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1379 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1380 | "M215", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1381 | node.name, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1382 | decorator.value.id, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1383 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1384 | else: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1385 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1386 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1387 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1388 | "M213", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1389 | decorator.value.id, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1390 | node.name, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1391 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1392 | if len(node.args.args) != 2: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1393 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1394 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1395 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1396 | "M211", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1397 | len(node.args.args), |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1398 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1399 | |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1400 | # property deleter method |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1401 | if decorator.attr == "deleter": |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1402 | propertyCount += 1 |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1403 | if node.name != decorator.value.id: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1404 | if node.name in properties: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1405 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1406 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1407 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1408 | "M216", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1409 | node.name, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1410 | decorator.value.id, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1411 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1412 | else: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1413 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1414 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1415 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1416 | "M214", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1417 | decorator.value.id, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1418 | node.name, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1419 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1420 | if len(node.args.args) != 1: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1421 | self.__error( |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1422 | node.lineno - 1, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1423 | node.col_offset, |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1424 | "M212", |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1425 | len(node.args.args), |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1426 | ) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1427 | |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1428 | if propertyCount > 1: |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1429 | self.__error(node.lineno - 1, node.col_offset, "M217", node.name) |
b5808c3a9967
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10048
diff
changeset
|
1430 | |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1431 | ####################################################################### |
10362
cfa7034cccf6
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10361
diff
changeset
|
1432 | ## The following methods check for implicitly concatenated strings. |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1433 | ## |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1434 | ## These methods are adapted from: flake8-implicit-str-concat v0.4.0 |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1435 | ## Original: Copyright (c) 2023 Dylan Turner |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1436 | ####################################################################### |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1437 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1438 | if sys.version_info < (3, 12): |
10371
1f54843e8152
Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10362
diff
changeset
|
1439 | |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1440 | def __isImplicitStringConcat(self, first, second): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1441 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1442 | Private method to check, if the given strings indicate an implicit string |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1443 | concatenation. |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1444 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1445 | @param first first token |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1446 | @type tuple |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1447 | @param second second token |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1448 | @type tuple |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1449 | @return flag indicating an implicit string concatenation |
10437
2f70ca07f0af
Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10417
diff
changeset
|
1450 | @rtype bool |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1451 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1452 | return first.type == second.type == tokenize.STRING |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1453 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1454 | else: |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1455 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1456 | def __isImplicitStringConcat(self, first, second): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1457 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1458 | Private method to check, if the given strings indicate an implicit string |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1459 | concatenation. |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1460 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1461 | @param first first token |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1462 | @type tuple |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1463 | @param second second token |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1464 | @type tuple |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1465 | @return flag indicating an implicit string concatenation |
10437
2f70ca07f0af
Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10417
diff
changeset
|
1466 | @rtype bool |
10361
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1467 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1468 | return ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1469 | (first.type == second.type == tokenize.STRING) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1470 | or ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1471 | first.type == tokenize.STRING |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1472 | and second.type == tokenize.FSTRING_START |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1473 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1474 | or ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1475 | first.type == tokenize.FSTRING_END |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1476 | and second.type == tokenize.STRING |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1477 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1478 | or ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1479 | first.type == tokenize.FSTRING_END |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1480 | and second.type == tokenize.FSTRING_START |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1481 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1482 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1483 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1484 | def __checkImplicitStringConcat(self): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1485 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1486 | Private method to check for implicitly concatenated strings. |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1487 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1488 | tokensWithoutWhitespace = ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1489 | tok |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1490 | for tok in self.__tokens |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1491 | if tok.type |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1492 | not in ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1493 | tokenize.NL, |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1494 | tokenize.NEWLINE, |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1495 | tokenize.INDENT, |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1496 | tokenize.DEDENT, |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1497 | tokenize.COMMENT, |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1498 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1499 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1500 | for a, b in pairwise(tokensWithoutWhitespace): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1501 | if self.__isImplicitStringConcat(a, b): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1502 | self.__error( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1503 | a.end[0] - 1, a.end[1], "M851" if a.end[0] == b.start[0] else "M852" |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1504 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1505 | |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1506 | def __checkExplicitStringConcat(self): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1507 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1508 | Private method to check for explicitly concatenated strings. |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1509 | """ |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1510 | for node in ast.walk(self.__tree): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1511 | if ( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1512 | isinstance(node, ast.BinOp) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1513 | and isinstance(node.op, ast.Add) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1514 | and all( |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1515 | AstUtilities.isBaseString(operand) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1516 | or isinstance(operand, ast.JoinedStr) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1517 | for operand in (node.left, node.right) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1518 | ) |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1519 | ): |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1520 | self.__error(node.lineno - 1, node.col_offset, "M853") |
e6ff9a4f6ee5
Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10360
diff
changeset
|
1521 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1522 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1523 | class TextVisitor(ast.NodeVisitor): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1524 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1525 | Class implementing a node visitor for bytes and str instances. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1526 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1527 | It tries to detect docstrings as string of the first expression of each |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1528 | module, class or function. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1529 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1530 | |
9274
86fab0c74430
Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9221
diff
changeset
|
1531 | # modeled after the string format flake8 extension |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1532 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1533 | def __init__(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1534 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1535 | Constructor |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1536 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1537 | super().__init__() |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1538 | self.nodes = [] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1539 | self.calls = {} |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1540 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1541 | def __addNode(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1542 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1543 | Private method to add a node to our list of nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1544 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1545 | @param node reference to the node to add |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1546 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1547 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1548 | if not hasattr(node, "is_docstring"): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1549 | node.is_docstring = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1550 | self.nodes.append(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1551 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1552 | def visit_Constant(self, node): |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1553 | """ |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1554 | Public method to handle constant nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1555 | |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1556 | @param node reference to the bytes node |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1557 | @type ast.Constant |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1558 | """ |
10119
64147a7e6393
Removed support for Python 3.7 because that is EOL.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10085
diff
changeset
|
1559 | if AstUtilities.isBaseString(node): |
64147a7e6393
Removed support for Python 3.7 because that is EOL.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10085
diff
changeset
|
1560 | self.__addNode(node) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1561 | else: |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1562 | super().generic_visit(node) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1563 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1564 | def __visitDefinition(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1565 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1566 | Private method handling class and function definitions. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1567 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1568 | @param node reference to the node to handle |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1569 | @type ast.FunctionDef, ast.AsyncFunctionDef or ast.ClassDef |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1570 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1571 | # Manually traverse class or function definition |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1572 | # * Handle decorators normally |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1573 | # * Use special check for body content |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1574 | # * Don't handle the rest (e.g. bases) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1575 | for decorator in node.decorator_list: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1576 | self.visit(decorator) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1577 | self.__visitBody(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1578 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1579 | def __visitBody(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1580 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1581 | Private method to traverse the body of the node manually. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1582 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1583 | If the first node is an expression which contains a string or bytes it |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1584 | marks that as a docstring. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1585 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1586 | @param node reference to the node to traverse |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1587 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1588 | """ |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1589 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1590 | node.body |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1591 | and isinstance(node.body[0], ast.Expr) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1592 | and AstUtilities.isBaseString(node.body[0].value) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1593 | ): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1594 | node.body[0].value.is_docstring = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1595 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1596 | for subnode in node.body: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1597 | self.visit(subnode) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1598 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1599 | def visit_Module(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1600 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1601 | Public method to handle a module. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1602 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1603 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1604 | @type ast.Module |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1605 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1606 | self.__visitBody(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1607 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1608 | def visit_ClassDef(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1609 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1610 | Public method to handle a class definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1611 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1612 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1613 | @type ast.ClassDef |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1614 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1615 | # Skipped nodes: ('name', 'bases', 'keywords', 'starargs', 'kwargs') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1616 | self.__visitDefinition(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1617 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1618 | def visit_FunctionDef(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1619 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1620 | Public method to handle a function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1621 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1622 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1623 | @type ast.FunctionDef |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1624 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1625 | # Skipped nodes: ('name', 'args', 'returns') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1626 | self.__visitDefinition(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1627 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1628 | def visit_AsyncFunctionDef(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1629 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1630 | Public method to handle an asynchronous function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1631 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1632 | @param node reference to the node to handle |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1633 | @type ast.AsyncFunctionDef |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1634 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1635 | # Skipped nodes: ('name', 'args', 'returns') |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1636 | self.__visitDefinition(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1637 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1638 | def visit_Call(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1639 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1640 | Public method to handle a function call. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1641 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1642 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1643 | @type ast.Call |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1644 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1645 | if isinstance(node.func, ast.Attribute) and node.func.attr == "format": |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1646 | if AstUtilities.isBaseString(node.func.value): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1647 | self.calls[node.func.value] = (node, False) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1648 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1649 | isinstance(node.func.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1650 | and node.func.value.id == "str" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1651 | and node.args |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1652 | and AstUtilities.isBaseString(node.args[0]) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
1653 | ): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
1654 | self.calls[node.args[0]] = (node, True) |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1655 | super().generic_visit(node) |
4555
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
1656 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1657 | |
10175
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1658 | ####################################################################### |
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1659 | ## BugBearVisitor |
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1660 | ## |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
1661 | ## adapted from: flake8-bugbear v24.2.6 |
10175
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1662 | ## |
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1663 | ## Original: Copyright (c) 2016 Łukasz Langa |
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1664 | ####################################################################### |
57ed3cb66e9a
Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10170
diff
changeset
|
1665 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1666 | BugBearContext = namedtuple("BugBearContext", ["node", "stack"]) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1667 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1668 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1669 | class BugBearVisitor(ast.NodeVisitor): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1670 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1671 | Class implementing a node visitor to check for various topics. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1672 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1673 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1674 | CONTEXTFUL_NODES = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1675 | ast.Module, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1676 | ast.ClassDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1677 | ast.AsyncFunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1678 | ast.FunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1679 | ast.Lambda, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1680 | ast.ListComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1681 | ast.SetComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1682 | ast.DictComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1683 | ast.GeneratorExp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1684 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1685 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1686 | FUNCTION_NODES = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1687 | ast.AsyncFunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1688 | ast.FunctionDef, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1689 | ast.Lambda, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1690 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1691 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1692 | NodeWindowSize = 4 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1693 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1694 | def __init__(self): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1695 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1696 | Constructor |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1697 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
1698 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1699 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1700 | self.nodeWindow = [] |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1701 | self.violations = [] |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1702 | self.contexts = [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1703 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1704 | self.__M523Seen = set() |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1705 | self.__M505Imports = set() |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1706 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1707 | @property |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1708 | def nodeStack(self): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1709 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1710 | Public method to get a reference to the most recent node stack. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1711 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1712 | @return reference to the most recent node stack |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1713 | @rtype list |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1714 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1715 | if len(self.contexts) == 0: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1716 | return [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1717 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1718 | context, stack = self.contexts[-1] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1719 | return stack |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1720 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1721 | def __isIdentifier(self, arg): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1722 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1723 | Private method to check if arg is a valid identifier. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1724 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1725 | See https://docs.python.org/2/reference/lexical_analysis.html#identifiers |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1726 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1727 | @param arg reference to an argument node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1728 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1729 | @return flag indicating a valid identifier |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1730 | @rtype TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1731 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1732 | if not AstUtilities.isString(arg): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1733 | return False |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1734 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1735 | return ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1736 | re.match(r"^[A-Za-z_][A-Za-z0-9_]*$", AstUtilities.getValue(arg)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1737 | is not None |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1738 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1739 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1740 | def __composeCallPath(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1741 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1742 | Private method get the individual elements of the call path of a node. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1743 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1744 | @param node reference to the node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1745 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1746 | @yield one element of the call path |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1747 | @ytype ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1748 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1749 | if isinstance(node, ast.Attribute): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1750 | yield from self.__composeCallPath(node.value) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1751 | yield node.attr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1752 | elif isinstance(node, ast.Call): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1753 | yield from self.__composeCallPath(node.func) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1754 | elif isinstance(node, ast.Name): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1755 | yield node.id |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1756 | |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1757 | def toNameStr(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1758 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1759 | Public method to turn Name and Attribute nodes to strings, handling any |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1760 | depth of attribute accesses. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1761 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1762 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1763 | @param node reference to the node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1764 | @type ast.Name or ast.Attribute |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1765 | @return string representation |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1766 | @rtype str |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1767 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1768 | if isinstance(node, ast.Name): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1769 | return node.id |
10516
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1770 | elif isinstance(node, ast.Call): |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1771 | return self.toNameStr(node.func) |
10516
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1772 | elif isinstance(node, ast.Attribute): |
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1773 | inner = self.toNameStr(node.value) |
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1774 | if inner is None: |
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1775 | return None |
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1776 | return f"{inner}.{node.attr}" |
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1777 | else: |
72baef0baa76
Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10510
diff
changeset
|
1778 | return None |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1779 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1780 | def __typesafeIssubclass(self, obj, classOrTuple): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1781 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1782 | Private method implementing a type safe issubclass() function. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1783 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1784 | @param obj reference to the object to be tested |
10417
c6011e501282
Modernized some code and converted Debug Client and Debugger source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10371
diff
changeset
|
1785 | @type Any |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1786 | @param classOrTuple type to check against |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1787 | @type type |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1788 | @return flag indicating a subclass |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1789 | @rtype bool |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1790 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1791 | try: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1792 | return issubclass(obj, classOrTuple) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1793 | except TypeError: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1794 | # User code specifies a type that is not a type in our current run. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1795 | # Might be their error, might be a difference in our environments. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1796 | # We don't know so we ignore this. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1797 | return False |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1798 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1799 | def __getAssignedNames(self, loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1800 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1801 | Private method to get the names of a for loop. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1802 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1803 | @param loopNode reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1804 | @type ast.For |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1805 | @yield DESCRIPTION |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1806 | @ytype TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1807 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1808 | loopTargets = (ast.For, ast.AsyncFor, ast.comprehension) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1809 | for node in self.__childrenInScope(loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1810 | if isinstance(node, (ast.Assign)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1811 | for child in node.targets: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1812 | yield from self.__namesFromAssignments(child) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1813 | if isinstance(node, loopTargets + (ast.AnnAssign, ast.AugAssign)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1814 | yield from self.__namesFromAssignments(node.target) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1815 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1816 | def __namesFromAssignments(self, assignTarget): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1817 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1818 | Private method to get names of an assignment. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1819 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1820 | @param assignTarget reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1821 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1822 | @yield name of the assignment |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1823 | @ytype str |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1824 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1825 | if isinstance(assignTarget, ast.Name): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1826 | yield assignTarget.id |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1827 | elif isinstance(assignTarget, ast.Starred): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1828 | yield from self.__namesFromAssignments(assignTarget.value) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1829 | elif isinstance(assignTarget, (ast.List, ast.Tuple)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1830 | for child in assignTarget.elts: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1831 | yield from self.__namesFromAssignments(child) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1832 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1833 | def __childrenInScope(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1834 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1835 | Private method to get all child nodes in the given scope. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1836 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1837 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1838 | @type ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1839 | @yield reference to a child node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1840 | @ytype ast.Node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1841 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1842 | yield node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1843 | if not isinstance(node, BugBearVisitor.FUNCTION_NODES): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1844 | for child in ast.iter_child_nodes(node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
1845 | yield from self.__childrenInScope(child) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
1846 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1847 | def __flattenExcepthandler(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1848 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1849 | Private method to flatten the list of exceptions handled by an except handler. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1850 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1851 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1852 | @type ast.Node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1853 | @yield reference to the exception type node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1854 | @ytype ast.Node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1855 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1856 | if not isinstance(node, ast.Tuple): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1857 | yield node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1858 | return |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1859 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1860 | exprList = node.elts.copy() |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1861 | while len(exprList): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1862 | expr = exprList.pop(0) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1863 | if isinstance(expr, ast.Starred) and isinstance( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1864 | expr.value, (ast.List, ast.Tuple) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1865 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1866 | exprList.extend(expr.value.elts) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1867 | continue |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1868 | yield expr |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1869 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1870 | def __checkRedundantExcepthandlers(self, names, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1871 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1872 | Private method to check for redundant exception types in an exception handler. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1873 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1874 | @param names list of exception types to be checked |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1875 | @type list of ast.Name |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1876 | @param node reference to the exception handler node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1877 | @type ast.ExceptionHandler |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1878 | @return tuple containing the error data |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1879 | @rtype tuple of (ast.Node, str, str, str, str) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1880 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1881 | redundantExceptions = { |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1882 | "OSError": { |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1883 | # All of these are actually aliases of OSError since Python 3.3 |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1884 | "IOError", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1885 | "EnvironmentError", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1886 | "WindowsError", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1887 | "mmap.error", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1888 | "socket.error", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1889 | "select.error", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1890 | }, |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1891 | "ValueError": { |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1892 | "binascii.Error", |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1893 | }, |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1894 | } |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1895 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1896 | # See if any of the given exception names could be removed, e.g. from: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1897 | # (MyError, MyError) # duplicate names |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1898 | # (MyError, BaseException) # everything derives from the Base |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1899 | # (Exception, TypeError) # builtins where one subclasses another |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1900 | # (IOError, OSError) # IOError is an alias of OSError since Python3.3 |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1901 | # but note that other cases are impractical to handle from the AST. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1902 | # We expect this is mostly useful for users who do not have the |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1903 | # builtin exception hierarchy memorised, and include a 'shadowed' |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1904 | # subtype without realising that it's redundant. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1905 | good = sorted(set(names), key=names.index) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1906 | if "BaseException" in good: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1907 | good = ["BaseException"] |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1908 | # Remove redundant exceptions that the automatic system either handles |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1909 | # poorly (usually aliases) or can't be checked (e.g. it's not an |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1910 | # built-in exception). |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1911 | for primary, equivalents in redundantExceptions.items(): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1912 | if primary in good: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1913 | good = [g for g in good if g not in equivalents] |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1914 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1915 | for name, other in itertools.permutations(tuple(good), 2): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1916 | if ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1917 | self.__typesafeIssubclass( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1918 | getattr(builtins, name, type), getattr(builtins, other, ()) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1919 | ) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1920 | and name in good |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1921 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1922 | good.remove(name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1923 | if good != names: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1924 | desc = good[0] if len(good) == 1 else "({0})".format(", ".join(good)) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1925 | as_ = " as " + node.name if node.name is not None else "" |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1926 | return (node, "M514", ", ".join(names), as_, desc) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1927 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1928 | return None |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1929 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1930 | def __walkList(self, nodes): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1931 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1932 | Private method to walk a given list of nodes. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1933 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1934 | @param nodes list of nodes to walk |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1935 | @type list of ast.Node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1936 | @yield node references as determined by the ast.walk() function |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1937 | @ytype ast.Node |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1938 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1939 | for node in nodes: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1940 | yield from ast.walk(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
1941 | |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1942 | def __getNamesFromTuple(self, node): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1943 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1944 | Private method to get the names from an ast.Tuple node. |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1945 | |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1946 | @param node ast node to be processed |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1947 | @type ast.Tuple |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1948 | @yield names |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1949 | @ytype str |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1950 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1951 | for dim in node.elts: |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1952 | if isinstance(dim, ast.Name): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1953 | yield dim.id |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1954 | elif isinstance(dim, ast.Tuple): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1955 | yield from self.__getNamesFromTuple(dim) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1956 | |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1957 | def __getDictCompLoopAndNamedExprVarNames(self, node): |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1958 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1959 | Private method to get the names of comprehension loop variables. |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1960 | |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1961 | @param node ast node to be processed |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1962 | @type ast.DictComp |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1963 | @yield loop variable names |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1964 | @ytype str |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1965 | """ |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1966 | finder = NamedExprFinder() |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1967 | for gen in node.generators: |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1968 | if isinstance(gen.target, ast.Name): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1969 | yield gen.target.id |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1970 | elif isinstance(gen.target, ast.Tuple): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1971 | yield from self.__getNamesFromTuple(gen.target) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
1972 | |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1973 | finder.visit(gen.ifs) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1974 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1975 | yield from finder.getNames().keys() |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1976 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1977 | def __inClassInit(self): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1978 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1979 | Private method to check, if we are inside an '__init__' method. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1980 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1981 | @return flag indicating being within the '__init__' method |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1982 | @rtype bool |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1983 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1984 | return ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1985 | len(self.contexts) >= 2 |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1986 | and isinstance(self.contexts[-2].node, ast.ClassDef) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1987 | and isinstance(self.contexts[-1].node, ast.FunctionDef) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1988 | and self.contexts[-1].node.name == "__init__" |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1989 | ) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1990 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1991 | def visit_Return(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1992 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1993 | Public method to handle 'Return' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1994 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1995 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1996 | @type ast.Return |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1997 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1998 | if self.__inClassInit() and node.value is not None: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
1999 | self.violations.append((node, "M537")) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2000 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2001 | self.generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2002 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2003 | def visit_Yield(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2004 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2005 | Public method to handle 'Yield' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2006 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2007 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2008 | @type ast.Yield |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2009 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2010 | if self.__inClassInit(): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2011 | self.violations.append((node, "M537")) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2012 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2013 | self.generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2014 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2015 | def visit_YieldFrom(self, node) -> None: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2016 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2017 | Public method to handle 'YieldFrom' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2018 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2019 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2020 | @type ast.YieldFrom |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2021 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2022 | if self.__inClassInit(): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2023 | self.violations.append((node, "M537")) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2024 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2025 | self.generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2026 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2027 | def visit(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2028 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2029 | Public method to traverse a given AST node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2030 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2031 | @param node AST node to be traversed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2032 | @type ast.Node |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2033 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2034 | isContextful = isinstance(node, BugBearVisitor.CONTEXTFUL_NODES) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2035 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2036 | if isContextful: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2037 | context = BugBearContext(node, []) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2038 | self.contexts.append(context) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2039 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2040 | self.nodeStack.append(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2041 | self.nodeWindow.append(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2042 | self.nodeWindow = self.nodeWindow[-BugBearVisitor.NodeWindowSize :] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2043 | |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
2044 | super().visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2045 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2046 | self.nodeStack.pop() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2047 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2048 | if isContextful: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2049 | self.contexts.pop() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2050 | |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2051 | self.__checkForM518(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2052 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2053 | def visit_ExceptHandler(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2054 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2055 | Public method to handle exception handlers. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2056 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2057 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2058 | @type ast.ExceptHandler |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2059 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2060 | if node.type is None: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2061 | # bare except is handled by pycodestyle already |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2062 | pass |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2063 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2064 | else: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2065 | handlers = self.__flattenExcepthandler(node.type) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2066 | names = [] |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2067 | badHandlers = [] |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2068 | ignoredHandlers = [] |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2069 | for handler in handlers: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2070 | if isinstance(handler, (ast.Name, ast.Attribute)): |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2071 | name = self.toNameStr(handler) |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2072 | if name is None: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2073 | ignoredHandlers.append(handler) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2074 | else: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2075 | names.append(name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2076 | elif isinstance(handler, (ast.Call, ast.Starred)): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2077 | ignoredHandlers.append(handler) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2078 | else: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2079 | badHandlers.append(handler) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2080 | if badHandlers: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2081 | self.violations.append((node, "M530")) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2082 | if len(names) == 0 and not badHandlers and not ignoredHandlers: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2083 | self.violations.append((node, "M529")) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2084 | elif ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2085 | len(names) == 1 |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2086 | and not badHandlers |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2087 | and not ignoredHandlers |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2088 | and isinstance(node.type, ast.Tuple) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2089 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2090 | self.violations.append((node, "M513", *names)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2091 | else: |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2092 | maybeError = self.__checkRedundantExcepthandlers(names, node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2093 | if maybeError is not None: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2094 | self.violations.append(maybeError) |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2095 | if ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2096 | "BaseException" in names |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2097 | and not ExceptBaseExceptionVisitor(node).reRaised() |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2098 | ): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2099 | self.violations.append((node, "M536")) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2100 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2101 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2102 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2103 | def visit_UAdd(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2104 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2105 | Public method to handle unary additions. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2106 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2107 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2108 | @type ast.UAdd |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2109 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2110 | trailingNodes = list(map(type, self.nodeWindow[-4:])) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2111 | if trailingNodes == [ast.UnaryOp, ast.UAdd, ast.UnaryOp, ast.UAdd]: |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2112 | originator = self.nodeWindow[-4] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2113 | self.violations.append((originator, "M502")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2114 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2115 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2116 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2117 | def visit_Call(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2118 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2119 | Public method to handle a function call. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2120 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2121 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2122 | @type ast.Call |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2123 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2124 | if isinstance(node.func, ast.Attribute): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2125 | self.__checkForM505(node) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2126 | else: |
8243
cc717c2ae956
Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8228
diff
changeset
|
2127 | with contextlib.suppress(AttributeError, IndexError): |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2128 | # bad super() call |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2129 | if isinstance(node.func, ast.Name) and node.func.id == "super": |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2130 | args = node.args |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2131 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2132 | len(args) == 2 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2133 | and isinstance(args[0], ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2134 | and isinstance(args[0].value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2135 | and args[0].value.id == "self" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2136 | and args[0].attr == "__class__" |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2137 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2138 | self.violations.append((node, "M582")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2139 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2140 | # bad getattr and setattr |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2141 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2142 | node.func.id in ("getattr", "hasattr") |
10169
0f70a4ef4592
Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10163
diff
changeset
|
2143 | and node.args[1].value == "__call__" |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2144 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2145 | self.violations.append((node, "M504")) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2146 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2147 | node.func.id == "getattr" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2148 | and len(node.args) == 2 |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2149 | and self.__isIdentifier(node.args[1]) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2150 | and iskeyword(AstUtilities.getValue(node.args[1])) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2151 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2152 | self.violations.append((node, "M509")) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2153 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2154 | node.func.id == "setattr" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2155 | and len(node.args) == 3 |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2156 | and self.__isIdentifier(node.args[1]) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2157 | and iskeyword(AstUtilities.getValue(node.args[1])) |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2158 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2159 | self.violations.append((node, "M510")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2160 | |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2161 | self.__checkForM526(node) |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2162 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2163 | self.__checkForM528(node) |
10186
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2164 | self.__checkForM534(node) |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2165 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2166 | self.generic_visit(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2167 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2168 | def visit_Module(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2169 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2170 | Public method to handle a module node. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2171 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2172 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2173 | @type ast.Module |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2174 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2175 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2176 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2177 | def visit_Assign(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2178 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2179 | Public method to handle assignments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2180 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2181 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2182 | @type ast.Assign |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2183 | """ |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2184 | if len(node.targets) == 1: |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2185 | target = node.targets[0] |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
2186 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2187 | isinstance(target, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2188 | and isinstance(target.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2189 | and (target.value.id, target.attr) == ("os", "environ") |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
2190 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2191 | self.violations.append((node, "M503")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2192 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2193 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2194 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2195 | def visit_For(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2196 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2197 | Public method to handle 'for' statements. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2198 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2199 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2200 | @type ast.For |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2201 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2202 | self.__checkForM507(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2203 | self.__checkForM520(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2204 | self.__checkForM523(node) |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2205 | self.__checkForM531(node) |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
2206 | self.__checkForM569(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2207 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2208 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2209 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2210 | def visit_AsyncFor(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2211 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2212 | Public method to handle 'for' statements. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2213 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2214 | @param node reference to the node to be processed |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2215 | @type ast.AsyncFor |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2216 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2217 | self.__checkForM507(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2218 | self.__checkForM520(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2219 | self.__checkForM523(node) |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2220 | self.__checkForM531(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2221 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2222 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2223 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2224 | def visit_While(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2225 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2226 | Public method to handle 'while' statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2227 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2228 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2229 | @type ast.While |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2230 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2231 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2232 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2233 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2234 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2235 | def visit_ListComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2236 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2237 | Public method to handle list comprehensions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2238 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2239 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2240 | @type ast.ListComp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2241 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2242 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2243 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2244 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2245 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2246 | def visit_SetComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2247 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2248 | Public method to handle set comprehensions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2249 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2250 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2251 | @type ast.SetComp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2252 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2253 | self.__checkForM523(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2254 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2255 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2256 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2257 | def visit_DictComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2258 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2259 | Public method to handle dictionary comprehensions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2260 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2261 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2262 | @type ast.DictComp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2263 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2264 | self.__checkForM523(node) |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2265 | self.__checkForM535(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2266 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2267 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2268 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2269 | def visit_GeneratorExp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2270 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2271 | Public method to handle generator expressions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2272 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2273 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2274 | @type ast.GeneratorExp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2275 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2276 | self.__checkForM523(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2277 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
2278 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2279 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2280 | def visit_Assert(self, node): |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2281 | """ |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2282 | Public method to handle 'assert' statements. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2283 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2284 | @param node reference to the node to be processed |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2285 | @type ast.Assert |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2286 | """ |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
2287 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2288 | AstUtilities.isNameConstant(node.test) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2289 | and AstUtilities.getValue(node.test) is False |
7256
4ef3b78ebb4e
Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7249
diff
changeset
|
2290 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2291 | self.violations.append((node, "M511")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2292 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2293 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2294 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2295 | def visit_FunctionDef(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2296 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2297 | Public method to handle function definitions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2298 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2299 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2300 | @type ast.FunctionDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2301 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2302 | self.__checkForM519(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2303 | self.__checkForM521(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2304 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2305 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2306 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2307 | def visit_ClassDef(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2308 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2309 | Public method to handle class definitions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2310 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2311 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2312 | @type ast.ClassDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2313 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2314 | self.__checkForM521(node) |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2315 | self.__checkForM524AndM527(node) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2316 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2317 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2318 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2319 | def visit_Try(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2320 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2321 | Public method to handle 'try' statements'. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2322 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2323 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2324 | @type ast.Try |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2325 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2326 | self.__checkForM512(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2327 | self.__checkForM525(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2328 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2329 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2330 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2331 | def visit_Compare(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2332 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2333 | Public method to handle comparison statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2334 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2335 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2336 | @type ast.Compare |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2337 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2338 | self.__checkForM515(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2339 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2340 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2341 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2342 | def visit_Raise(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2343 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2344 | Public method to handle 'raise' statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2345 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2346 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2347 | @type ast.Raise |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2348 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2349 | self.__checkForM516(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2350 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2351 | self.generic_visit(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2352 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2353 | def visit_With(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2354 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2355 | Public method to handle 'with' statements. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2356 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2357 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2358 | @type ast.With |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2359 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2360 | self.__checkForM517(node) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2361 | self.__checkForM522(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2362 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2363 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2364 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2365 | def visit_JoinedStr(self, node): |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2366 | """ |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2367 | Public method to handle f-string arguments. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2368 | |
7021
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2369 | @param node reference to the node to be processed |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2370 | @type ast.JoinedStr |
2894aa889a4e
MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6942
diff
changeset
|
2371 | """ |
7894
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
2372 | for value in node.values: |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
2373 | if isinstance(value, ast.FormattedValue): |
4370a8b30648
Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7784
diff
changeset
|
2374 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2375 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2376 | self.violations.append((node, "M581")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2377 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2378 | def visit_AnnAssign(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2379 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2380 | Public method to check annotated assign statements. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2381 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2382 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2383 | @type ast.AnnAssign |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2384 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2385 | self.__checkForM532(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2386 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2387 | self.generic_visit(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2388 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2389 | def visit_Import(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2390 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2391 | Public method to check imports. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2392 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2393 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2394 | @type ast.Import |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2395 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2396 | self.__checkForM505(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2397 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2398 | self.generic_visit(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2399 | |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2400 | def visit_ImportFrom(self, node): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2401 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2402 | Public method to check from imports. |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2403 | |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2404 | @param node reference to the node to be processed |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2405 | @type ast.Import |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2406 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2407 | self.visit_Import(node) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2408 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2409 | def visit_Set(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2410 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2411 | Public method to check a set. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2412 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2413 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2414 | @type ast.Set |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2415 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2416 | self.__checkForM533(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2417 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2418 | self.generic_visit(node) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2419 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2420 | def __checkForM505(self, node): |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2421 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2422 | Private method to check the use of *strip(). |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2423 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2424 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2425 | @type ast.Call |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
2426 | """ |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2427 | if isinstance(node, ast.Import): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2428 | for name in node.names: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2429 | self.__M505Imports.add(name.asname or name.name) |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2430 | elif isinstance(node, ast.ImportFrom): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2431 | for name in node.names: |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2432 | self.__M505Imports.add(f"{node.module}.{name.name or name.asname}") |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2433 | elif isinstance(node, ast.Call): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2434 | if node.func.attr not in ("lstrip", "rstrip", "strip"): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2435 | return # method name doesn't match |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2436 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2437 | if ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2438 | isinstance(node.func.value, ast.Name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2439 | and node.func.value.id in self.__M505Imports |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2440 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2441 | return # method is being run on an imported module |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2442 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2443 | if len(node.args) != 1 or not AstUtilities.isString(node.args[0]): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2444 | return # used arguments don't match the builtin strip |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2445 | |
10186
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2446 | value = AstUtilities.getValue(node.args[0]) |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2447 | if len(value) == 1: |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2448 | return # stripping just one character |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2449 | |
10186
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2450 | if len(value) == len(set(value)): |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2451 | return # no characters appear more than once |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2452 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2453 | self.violations.append((node, "M505")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2454 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2455 | def __checkForM507(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2456 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2457 | Private method to check for unused loop variables. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2458 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2459 | @param node reference to the node to be processed |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2460 | @type ast.For or ast.AsyncFor |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2461 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2462 | targets = NameFinder() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2463 | targets.visit(node.target) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
2464 | ctrlNames = set(filter(lambda s: not s.startswith("_"), targets.getNames())) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2465 | body = NameFinder() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2466 | for expr in node.body: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2467 | body.visit(expr) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2468 | usedNames = set(body.getNames()) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2469 | for name in sorted(ctrlNames - usedNames): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2470 | n = targets.getNames()[name][0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2471 | self.violations.append((n, "M507", name)) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
2472 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2473 | def __checkForM512(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2474 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2475 | Private method to check for return/continue/break inside finally blocks. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2476 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2477 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2478 | @type ast.Try |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2479 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2480 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2481 | def _loop(node, badNodeTypes): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2482 | if isinstance(node, (ast.AsyncFunctionDef, ast.FunctionDef)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2483 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2484 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2485 | if isinstance(node, (ast.While, ast.For)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2486 | badNodeTypes = (ast.Return,) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2487 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2488 | elif isinstance(node, badNodeTypes): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2489 | self.violations.append((node, "M512")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2490 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2491 | for child in ast.iter_child_nodes(node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2492 | _loop(child, badNodeTypes) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2493 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2494 | for child in node.finalbody: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2495 | _loop(child, (ast.Return, ast.Continue, ast.Break)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2496 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2497 | def __checkForM515(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2498 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2499 | Private method to check for pointless comparisons. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2500 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2501 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2502 | @type ast.Compare |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2503 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2504 | if isinstance(self.nodeStack[-2], ast.Expr): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2505 | self.violations.append((node, "M515")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2506 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2507 | def __checkForM516(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2508 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2509 | Private method to check for raising a literal instead of an exception. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2510 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2511 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2512 | @type ast.Raise |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2513 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2514 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2515 | AstUtilities.isNameConstant(node.exc) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2516 | or AstUtilities.isNumber(node.exc) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2517 | or AstUtilities.isString(node.exc) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2518 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2519 | self.violations.append((node, "M516")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2520 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2521 | def __checkForM517(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2522 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2523 | Private method to check for use of the evil syntax |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2524 | 'with assertRaises(Exception): or 'with pytest.raises(Exception):'. |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2525 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2526 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2527 | @type ast.With |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2528 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2529 | item = node.items[0] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2530 | itemContext = item.context_expr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2531 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2532 | hasattr(itemContext, "func") |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2533 | and ( |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2534 | ( |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2535 | isinstance(itemContext.func, ast.Attribute) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2536 | and ( |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2537 | itemContext.func.attr == "assertRaises" |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2538 | or ( |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2539 | itemContext.func.attr == "raises" |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2540 | and isinstance(itemContext.func.value, ast.Name) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2541 | and itemContext.func.value.id == "pytest" |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2542 | and "match" not in (kwd.arg for kwd in itemContext.keywords) |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2543 | ) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2544 | ) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2545 | ) |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2546 | or ( |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2547 | isinstance(itemContext.func, ast.Name) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2548 | and itemContext.func.id == "raises" |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2549 | and isinstance(itemContext.func.ctx, ast.Load) |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
2550 | and "pytest.raises" in self.__M505Imports |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2551 | and "match" not in (kwd.arg for kwd in itemContext.keywords) |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2552 | ) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2553 | ) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2554 | and len(itemContext.args) == 1 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2555 | and isinstance(itemContext.args[0], ast.Name) |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2556 | and itemContext.args[0].id in ("Exception", "BaseException") |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2557 | and not item.optional_vars |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2558 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2559 | self.violations.append((node, "M517")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2560 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2561 | def __checkForM518(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2562 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2563 | Private method to check for useless expressions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2564 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2565 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2566 | @type ast.FunctionDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2567 | """ |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2568 | if not isinstance(node, ast.Expr): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2569 | return |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2570 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2571 | if isinstance( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2572 | node.value, |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2573 | (ast.List, ast.Set, ast.Dict, ast.Tuple), |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2574 | ) or ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2575 | isinstance(node.value, ast.Constant) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2576 | and ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2577 | isinstance( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2578 | node.value.value, |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2579 | (int, float, complex, bytes, bool), |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2580 | ) |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2581 | or node.value.value is None |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2582 | ) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2583 | ): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
2584 | self.violations.append((node, "M518", node.value.__class__.__name__)) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2585 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2586 | def __checkForM519(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2587 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2588 | Private method to check for use of 'functools.lru_cache' or 'functools.cache'. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2589 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2590 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2591 | @type ast.FunctionDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2592 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2593 | caches = { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2594 | "functools.cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2595 | "functools.lru_cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2596 | "cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2597 | "lru_cache", |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2598 | } |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2599 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2600 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2601 | len(node.decorator_list) == 0 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2602 | or len(self.contexts) < 2 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2603 | or not isinstance(self.contexts[-2].node, ast.ClassDef) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2604 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2605 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2606 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2607 | # Preserve decorator order so we can get the lineno from the decorator node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2608 | # rather than the function node (this location definition changes in Python 3.8) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2609 | resolvedDecorators = ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2610 | ".".join(self.__composeCallPath(decorator)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2611 | for decorator in node.decorator_list |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2612 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2613 | for idx, decorator in enumerate(resolvedDecorators): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2614 | if decorator in {"classmethod", "staticmethod"}: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2615 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2616 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2617 | if decorator in caches: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2618 | self.violations.append((node.decorator_list[idx], "M519")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2619 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2620 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2621 | def __checkForM520(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2622 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2623 | Private method to check for a loop that modifies its iterable. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2624 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2625 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2626 | @type ast.For or ast.AsyncFor |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2627 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2628 | targets = NameFinder() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2629 | targets.visit(node.target) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2630 | ctrlNames = set(targets.getNames()) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2631 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2632 | iterset = M520NameFinder() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2633 | iterset.visit(node.iter) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2634 | itersetNames = set(iterset.getNames()) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2635 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2636 | for name in sorted(ctrlNames): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2637 | if name in itersetNames: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2638 | n = targets.getNames()[name][0] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2639 | self.violations.append((n, "M520")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2640 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2641 | def __checkForM521(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2642 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2643 | Private method to check for use of an f-string as docstring. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2644 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2645 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2646 | @type ast.FunctionDef or ast.ClassDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2647 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2648 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2649 | node.body |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2650 | and isinstance(node.body[0], ast.Expr) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2651 | and isinstance(node.body[0].value, ast.JoinedStr) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2652 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2653 | self.violations.append((node.body[0].value, "M521")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2654 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2655 | def __checkForM522(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2656 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2657 | Private method to check for use of an f-string as docstring. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2658 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2659 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2660 | @type ast.With |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2661 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2662 | item = node.items[0] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2663 | itemContext = item.context_expr |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2664 | if ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2665 | hasattr(itemContext, "func") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2666 | and hasattr(itemContext.func, "value") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2667 | and hasattr(itemContext.func.value, "id") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2668 | and itemContext.func.value.id == "contextlib" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2669 | and hasattr(itemContext.func, "attr") |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2670 | and itemContext.func.attr == "suppress" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2671 | and len(itemContext.args) == 0 |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2672 | ): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2673 | self.violations.append((node, "M522")) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2674 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2675 | def __checkForM523(self, loopNode): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2676 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2677 | Private method to check that functions (including lambdas) do not use loop |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2678 | variables. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2679 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2680 | @param loopNode reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2681 | @type ast.For, ast.AsyncFor, ast.While, ast.ListComp, ast.SetComp,ast.DictComp, |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2682 | or ast.GeneratorExp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2683 | """ |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2684 | safe_functions = [] |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2685 | suspiciousVariables = [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2686 | for node in ast.walk(loopNode): |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2687 | # check if function is immediately consumed to avoid false alarm |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2688 | if isinstance(node, ast.Call): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2689 | # check for filter&reduce |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2690 | if ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2691 | isinstance(node.func, ast.Name) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2692 | and node.func.id in ("filter", "reduce", "map") |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2693 | ) or ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2694 | isinstance(node.func, ast.Attribute) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2695 | and node.func.attr == "reduce" |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2696 | and isinstance(node.func.value, ast.Name) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2697 | and node.func.value.id == "functools" |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2698 | ): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2699 | for arg in node.args: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2700 | if isinstance(arg, BugBearVisitor.FUNCTION_NODES): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2701 | safe_functions.append(arg) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2702 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2703 | # check for key= |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2704 | for keyword in node.keywords: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2705 | if keyword.arg == "key" and isinstance( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2706 | keyword.value, BugBearVisitor.FUNCTION_NODES |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2707 | ): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2708 | safe_functions.append(keyword.value) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2709 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2710 | # mark `return lambda: x` as safe |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2711 | # does not (currently) check inner lambdas in a returned expression |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2712 | # e.g. `return (lambda: x, ) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2713 | if isinstance(node, ast.Return) and isinstance( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2714 | node.value, BugBearVisitor.FUNCTION_NODES |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2715 | ): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2716 | safe_functions.append(node.value) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2717 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2718 | # find unsafe functions |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2719 | if ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2720 | isinstance(node, BugBearVisitor.FUNCTION_NODES) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2721 | and node not in safe_functions |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2722 | ): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2723 | argnames = { |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2724 | arg.arg for arg in ast.walk(node.args) if isinstance(arg, ast.arg) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2725 | } |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2726 | if isinstance(node, ast.Lambda): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2727 | bodyNodes = ast.walk(node.body) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2728 | else: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2729 | bodyNodes = itertools.chain.from_iterable(map(ast.walk, node.body)) |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2730 | errors = [] |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2731 | for name in bodyNodes: |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2732 | if isinstance(name, ast.Name) and name.id not in argnames: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2733 | if isinstance(name.ctx, ast.Load): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2734 | errors.append((name.lineno, name.col_offset, name.id, name)) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2735 | elif isinstance(name.ctx, ast.Store): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2736 | argnames.add(name.id) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2737 | for err in errors: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2738 | if err[2] not in argnames and err not in self.__M523Seen: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2739 | self.__M523Seen.add(err) # dedupe across nested loops |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2740 | suspiciousVariables.append(err) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2741 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2742 | if suspiciousVariables: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2743 | reassignedInLoop = set(self.__getAssignedNames(loopNode)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2744 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2745 | for err in sorted(suspiciousVariables): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2746 | if reassignedInLoop.issuperset(err[2]): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2747 | self.violations.append((err[3], "M523", err[2])) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2748 | |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2749 | def __checkForM524AndM527(self, node): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2750 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2751 | Private method to check for inheritance from abstract classes in abc and lack of |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2752 | any methods decorated with abstract*. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2753 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2754 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2755 | @type ast.ClassDef |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2756 | """ # __IGNORE_WARNING_D234r__ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2757 | |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2758 | def isAbcClass(value, name="ABC"): |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2759 | if isinstance(value, ast.keyword): |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2760 | return value.arg == "metaclass" and isAbcClass(value.value, "ABCMeta") |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2761 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2762 | # class foo(ABC) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2763 | # class foo(abc.ABC) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2764 | return (isinstance(value, ast.Name) and value.id == name) or ( |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2765 | isinstance(value, ast.Attribute) |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2766 | and value.attr == name |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2767 | and isinstance(value.value, ast.Name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2768 | and value.value.id == "abc" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2769 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2770 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2771 | def isAbstractDecorator(expr): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2772 | return (isinstance(expr, ast.Name) and expr.id[:8] == "abstract") or ( |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2773 | isinstance(expr, ast.Attribute) and expr.attr[:8] == "abstract" |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2774 | ) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2775 | |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2776 | def isOverload(expr): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2777 | return (isinstance(expr, ast.Name) and expr.id == "overload") or ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2778 | isinstance(expr, ast.Attribute) and expr.attr == "overload" |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2779 | ) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2780 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2781 | def emptyBody(body): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2782 | def isStrOrEllipsis(node): |
10170
6cf1ee737d8f
Corrected some more code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10169
diff
changeset
|
2783 | return isinstance(node, ast.Constant) and ( |
6cf1ee737d8f
Corrected some more code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10169
diff
changeset
|
2784 | node.value is Ellipsis or isinstance(node.value, str) |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2785 | ) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2786 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2787 | # Function body consist solely of `pass`, `...`, and/or (doc)string literals |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2788 | return all( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2789 | isinstance(stmt, ast.Pass) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2790 | or (isinstance(stmt, ast.Expr) and isStrOrEllipsis(stmt.value)) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2791 | for stmt in body |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2792 | ) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2793 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2794 | # don't check multiple inheritance |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2795 | if len(node.bases) + len(node.keywords) > 1: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2796 | return |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2797 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2798 | # only check abstract classes |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2799 | if not any(map(isAbcClass, (*node.bases, *node.keywords))): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2800 | return |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2801 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2802 | hasMethod = False |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2803 | hasAbstractMethod = False |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2804 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2805 | if not any(map(isAbcClass, (*node.bases, *node.keywords))): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2806 | return |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2807 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2808 | for stmt in node.body: |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2809 | # Ignore abc's that declares a class attribute that must be set |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2810 | if isinstance(stmt, (ast.AnnAssign, ast.Assign)): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2811 | hasAbstractMethod = True |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2812 | continue |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2813 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2814 | # only check function defs |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2815 | if not isinstance(stmt, (ast.FunctionDef, ast.AsyncFunctionDef)): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2816 | continue |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2817 | hasMethod = True |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2818 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2819 | hasAbstractDecorator = any(map(isAbstractDecorator, stmt.decorator_list)) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2820 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2821 | hasAbstractMethod |= hasAbstractDecorator |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2822 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2823 | if ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2824 | not hasAbstractDecorator |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2825 | and emptyBody(stmt.body) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2826 | and not any(map(isOverload, stmt.decorator_list)) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2827 | ): |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2828 | self.violations.append((stmt, "M527", stmt.name)) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2829 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2830 | if hasMethod and not hasAbstractMethod: |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2831 | self.violations.append((node, "M524", node.name)) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2832 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2833 | def __checkForM525(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2834 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2835 | Private method to check for exceptions being handled multiple times. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2836 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2837 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2838 | @type ast.Try |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2839 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2840 | seen = [] |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2841 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2842 | for handler in node.handlers: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2843 | if isinstance(handler.type, (ast.Name, ast.Attribute)): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2844 | name = ".".join(self.__composeCallPath(handler.type)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2845 | seen.append(name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2846 | elif isinstance(handler.type, ast.Tuple): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2847 | # to avoid checking the same as M514, remove duplicates per except |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2848 | uniques = set() |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2849 | for entry in handler.type.elts: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2850 | name = ".".join(self.__composeCallPath(entry)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2851 | uniques.add(name) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2852 | seen.extend(uniques) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2853 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2854 | # sort to have a deterministic output |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2855 | duplicates = sorted({x for x in seen if seen.count(x) > 1}) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2856 | for duplicate in duplicates: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2857 | self.violations.append((node, "M525", duplicate)) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
2858 | |
9595
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2859 | def __checkForM526(self, node): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2860 | """ |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2861 | Private method to check for Star-arg unpacking after keyword argument. |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2862 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2863 | @param node reference to the node to be processed |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2864 | @type ast.Call |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2865 | """ |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2866 | if not node.keywords: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2867 | return |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2868 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2869 | starreds = [arg for arg in node.args if isinstance(arg, ast.Starred)] |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2870 | if not starreds: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2871 | return |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2872 | |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2873 | firstKeyword = node.keywords[0].value |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2874 | for starred in starreds: |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2875 | if (starred.lineno, starred.col_offset) > ( |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2876 | firstKeyword.lineno, |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2877 | firstKeyword.col_offset, |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2878 | ): |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2879 | self.violations.append((node, "M526")) |
2bd590c40309
Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9482
diff
changeset
|
2880 | |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2881 | def __checkForM528(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2882 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2883 | Private method to check for warn without stacklevel. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2884 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2885 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2886 | @type ast.Call |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2887 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2888 | if ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2889 | isinstance(node.func, ast.Attribute) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2890 | and node.func.attr == "warn" |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2891 | and isinstance(node.func.value, ast.Name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2892 | and node.func.value.id == "warnings" |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2893 | and not any(kw.arg == "stacklevel" for kw in node.keywords) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2894 | and len(node.args) < 3 |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2895 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2896 | self.violations.append((node, "M528")) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2897 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2898 | def __checkForM531(self, loopNode): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2899 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2900 | Private method to check that 'itertools.groupby' isn't iterated over more than |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2901 | once. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2902 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2903 | A warning is emitted when the generator returned by 'groupby()' is used |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2904 | more than once inside a loop body or when it's used in a nested loop. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2905 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2906 | @param loopNode reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2907 | @type ast.For or ast.AsyncFor |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2908 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2909 | # for <loop_node.target> in <loop_node.iter>: ... |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2910 | if isinstance(loopNode.iter, ast.Call): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2911 | node = loopNode.iter |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2912 | if (isinstance(node.func, ast.Name) and node.func.id in ("groupby",)) or ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2913 | isinstance(node.func, ast.Attribute) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2914 | and node.func.attr == "groupby" |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2915 | and isinstance(node.func.value, ast.Name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2916 | and node.func.value.id == "itertools" |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2917 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2918 | # We have an invocation of groupby which is a simple unpacking |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2919 | if isinstance(loopNode.target, ast.Tuple) and isinstance( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2920 | loopNode.target.elts[1], ast.Name |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2921 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2922 | groupName = loopNode.target.elts[1].id |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2923 | else: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2924 | # Ignore any 'groupby()' invocation that isn't unpacked |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2925 | return |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2926 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2927 | numUsages = 0 |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2928 | for node in self.__walkList(loopNode.body): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2929 | # Handled nested loops |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2930 | if isinstance(node, ast.For): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2931 | for nestedNode in self.__walkList(node.body): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2932 | if ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2933 | isinstance(nestedNode, ast.Name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2934 | and nestedNode.id == groupName |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2935 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2936 | self.violations.append((nestedNode, "M531")) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2937 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2938 | # Handle multiple uses |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2939 | if isinstance(node, ast.Name) and node.id == groupName: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2940 | numUsages += 1 |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2941 | if numUsages > 1: |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2942 | self.violations.append((nestedNode, "M531")) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2943 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2944 | def __checkForM532(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2945 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2946 | Private method to check for possible unintentional typing annotation. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2947 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2948 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2949 | @type ast.AnnAssign |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2950 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2951 | if ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2952 | node.value is None |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2953 | and hasattr(node.target, "value") |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2954 | and isinstance(node.target.value, ast.Name) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2955 | and ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2956 | isinstance(node.target, ast.Subscript) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2957 | or ( |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2958 | isinstance(node.target, ast.Attribute) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2959 | and node.target.value.id != "self" |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2960 | ) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2961 | ) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2962 | ): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2963 | self.violations.append((node, "M532")) |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2964 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2965 | def __checkForM533(self, node): |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2966 | """ |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2967 | Private method to check a set for duplicate items. |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2968 | |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2969 | @param node reference to the node to be processed |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2970 | @type ast.Set |
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
2971 | """ |
10186
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2972 | seen = set() |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2973 | for elt in node.elts: |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2974 | if not isinstance(elt, ast.Constant): |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2975 | continue |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2976 | if elt.value in seen: |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2977 | self.violations.append((node, "M533", repr(elt.value))) |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2978 | else: |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2979 | seen.add(elt.value) |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2980 | |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2981 | def __checkForM534(self, node): |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2982 | """ |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2983 | Private method to check that re.sub/subn/split arguments flags/count/maxsplit |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2984 | are passed as keyword arguments. |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2985 | |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2986 | @param node reference to the node to be processed |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2987 | @type ast.Call |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2988 | """ |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2989 | if not isinstance(node.func, ast.Attribute): |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2990 | return |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2991 | if not isinstance(node.func.value, ast.Name) or node.func.value.id != "re": |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2992 | return |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2993 | |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2994 | def check(numArgs, paramName): |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2995 | if len(node.args) > numArgs: |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2996 | self.violations.append((node, "M534", node.func.attr, paramName)) |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2997 | |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2998 | if node.func.attr in ("sub", "subn"): |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
2999 | check(3, "count") |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
3000 | elif node.func.attr == "split": |
91c3ba0767ad
Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10175
diff
changeset
|
3001 | check(2, "maxsplit") |
10048
df836ff707fd
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9653
diff
changeset
|
3002 | |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3003 | def __checkForM535(self, node): |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3004 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3005 | Private method to check that a static key isn't used in a dict comprehension. |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3006 | |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3007 | Record a warning if a likely unchanging key is used - either a constant, |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3008 | or a variable that isn't coming from the generator expression. |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3009 | |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3010 | @param node reference to the node to be processed |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3011 | @type ast.DictComp |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3012 | """ |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3013 | if isinstance(node.key, ast.Constant): |
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3014 | self.violations.append((node, "M535", node.key.value)) |
10359
de0420dac60e
Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10356
diff
changeset
|
3015 | elif isinstance( |
de0420dac60e
Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10356
diff
changeset
|
3016 | node.key, ast.Name |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3017 | ) and node.key.id not in self.__getDictCompLoopAndNamedExprVarNames(node): |
10359
de0420dac60e
Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10356
diff
changeset
|
3018 | self.violations.append((node, "M535", node.key.id)) |
10356
09c698245a5c
Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10186
diff
changeset
|
3019 | |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
3020 | def __checkForM569(self, node): |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3021 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3022 | Private method to check for changes to a loop's mutable iterable. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3023 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3024 | @param node loop node to be checked |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3025 | @type ast.For |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3026 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3027 | if isinstance(node.iter, ast.Name): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3028 | name = self.toNameStr(node.iter) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3029 | elif isinstance(node.iter, ast.Attribute): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3030 | name = self.toNameStr(node.iter) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3031 | else: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3032 | return |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
3033 | checker = M569Checker(name, self) |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3034 | checker.visit(node.body) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3035 | for mutation in checker.mutations: |
10639
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
3036 | self.violations.append((mutation, "M569")) |
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
3037 | |
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
3038 | |
757bfe32983f
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10516
diff
changeset
|
3039 | class M569Checker(ast.NodeVisitor): |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3040 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3041 | Class traversing a 'for' loop body to check for modifications to a loop's |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3042 | mutable iterable. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3043 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3044 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3045 | # https://docs.python.org/3/library/stdtypes.html#mutable-sequence-types |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3046 | MUTATING_FUNCTIONS = ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3047 | "append", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3048 | "sort", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3049 | "reverse", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3050 | "remove", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3051 | "clear", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3052 | "extend", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3053 | "insert", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3054 | "pop", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3055 | "popitem", |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3056 | ) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3057 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3058 | def __init__(self, name, bugbear): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3059 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3060 | Constructor |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3061 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3062 | @param name name of the iterator |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3063 | @type str |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3064 | @param bugbear reference to the bugbear visitor |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3065 | @type BugBearVisitor |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3066 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3067 | self.__name = name |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3068 | self.__bb = bugbear |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3069 | self.mutations = [] |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3070 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3071 | def visit_Delete(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3072 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3073 | Public method handling 'Delete' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3074 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3075 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3076 | @type ast.Delete |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3077 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3078 | for target in node.targets: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3079 | if isinstance(target, ast.Subscript): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3080 | name = self.__bb.toNameStr(target.value) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3081 | elif isinstance(target, (ast.Attribute, ast.Name)): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3082 | name = self.__bb.toNameStr(target) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3083 | else: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3084 | name = "" # fallback |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3085 | self.generic_visit(target) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3086 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3087 | if name == self.__name: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3088 | self.mutations.append(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3089 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3090 | def visit_Call(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3091 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3092 | Public method handling 'Call' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3093 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3094 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3095 | @type ast.Call |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3096 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3097 | if isinstance(node.func, ast.Attribute): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3098 | name = self.__bb.toNameStr(node.func.value) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3099 | functionObject = name |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3100 | functionName = node.func.attr |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3101 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3102 | if ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3103 | functionObject == self.__name |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3104 | and functionName in self.MUTATING_FUNCTIONS |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3105 | ): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3106 | self.mutations.append(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3107 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3108 | self.generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3109 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3110 | def visit(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3111 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3112 | Public method to inspect an ast node. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3113 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3114 | Like super-visit but supports iteration over lists. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3115 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3116 | @param node AST node to be traversed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3117 | @type TYPE |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3118 | @return reference to the last processed node |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3119 | @rtype ast.Node |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3120 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3121 | if not isinstance(node, list): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3122 | return super().visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3123 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3124 | for elem in node: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3125 | super().visit(elem) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3126 | return node |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3127 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3128 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3129 | class ExceptBaseExceptionVisitor(ast.NodeVisitor): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3130 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3131 | Class to determine, if a 'BaseException' is re-raised. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3132 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3133 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3134 | def __init__(self, exceptNode): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3135 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3136 | Constructor |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3137 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3138 | @param exceptNode exception node to be inspected |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3139 | @type ast.ExceptHandler |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3140 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3141 | super().__init__() |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3142 | self.__root = exceptNode |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3143 | self.__reRaised = False |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3144 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3145 | def reRaised(self) -> bool: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3146 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3147 | Public method to check, if the exception is re-raised. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3148 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3149 | @return flag indicating a re-raised exception |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3150 | @rtype bool |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3151 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3152 | self.visit(self.__root) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3153 | return self.__reRaised |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3154 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3155 | def visit_Raise(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3156 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3157 | Public method to handle 'Raise' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3158 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3159 | If we find a corresponding `raise` or `raise e` where e was from |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3160 | `except BaseException as e:` then we mark re_raised as True and can |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3161 | stop scanning. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3162 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3163 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3164 | @type ast.Raise |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3165 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3166 | if node.exc is None or ( |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3167 | isinstance(node.exc, ast.Name) and node.exc.id == self.__root.name |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3168 | ): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3169 | self.__reRaised = True |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3170 | return |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3171 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3172 | super().generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3173 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3174 | def visit_ExceptHandler(self, node: ast.ExceptHandler): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3175 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3176 | Public method to handle 'ExceptHandler' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3177 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3178 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3179 | @type ast.ExceptHandler |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3180 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3181 | if node is not self.__root: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3182 | return # entered a nested except - stop searching |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3183 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3184 | super().generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3185 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3186 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3187 | class NameFinder(ast.NodeVisitor): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3188 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3189 | Class to extract a name out of a tree of nodes. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3190 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3191 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3192 | def __init__(self): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3193 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3194 | Constructor |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3195 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
3196 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3197 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3198 | self.__names = {} |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3199 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3200 | def visit_Name(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3201 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3202 | Public method to handle 'Name' nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3203 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3204 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3205 | @type ast.Name |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3206 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3207 | self.__names.setdefault(node.id, []).append(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3208 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3209 | def visit(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3210 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3211 | Public method to traverse a given AST node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3212 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3213 | @param node AST node to be traversed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3214 | @type ast.Node |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3215 | @return reference to the last processed node |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3216 | @rtype ast.Node |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3217 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3218 | if isinstance(node, list): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3219 | for elem in node: |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
3220 | super().visit(elem) |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3221 | return node |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3222 | else: |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3223 | return super().visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3224 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3225 | def getNames(self): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3226 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3227 | Public method to return the extracted names and Name nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3228 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3229 | @return dictionary containing the names as keys and the list of nodes |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3230 | @rtype dict |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3231 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
3232 | return self.__names |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
3233 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3234 | |
10510
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3235 | class NamedExprFinder(ast.NodeVisitor): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3236 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3237 | Class to extract names defined through an ast.NamedExpr. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3238 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3239 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3240 | def __init__(self): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3241 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3242 | Constructor |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3243 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3244 | super().__init__() |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3245 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3246 | self.__names = {} |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3247 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3248 | def visit_NamedExpr(self, node: ast.NamedExpr): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3249 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3250 | Public method handling 'NamedExpr' nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3251 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3252 | @param node reference to the node to be processed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3253 | @type ast.NamedExpr |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3254 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3255 | self.__names.setdefault(node.target.id, []).append(node.target) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3256 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3257 | self.generic_visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3258 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3259 | def visit(self, node): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3260 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3261 | Public method to traverse a given AST node. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3262 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3263 | Like super-visit but supports iteration over lists. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3264 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3265 | @param node AST node to be traversed |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3266 | @type TYPE |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3267 | @return reference to the last processed node |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3268 | @rtype ast.Node |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3269 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3270 | if not isinstance(node, list): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3271 | super().visit(node) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3272 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3273 | for elem in node: |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3274 | super().visit(elem) |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3275 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3276 | return node |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3277 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3278 | def getNames(self): |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3279 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3280 | Public method to return the extracted names and Name nodes. |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3281 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3282 | @return dictionary containing the names as keys and the list of nodes |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3283 | @rtype dict |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3284 | """ |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3285 | return self.__names |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3286 | |
fa7b8ebfbe13
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3287 | |
9327
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3288 | class M520NameFinder(NameFinder): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3289 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3290 | Class to extract a name out of a tree of nodes ignoring names defined within the |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3291 | local scope of a comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3292 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3293 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3294 | def visit_GeneratorExp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3295 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3296 | Public method to handle a generator expressions. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3297 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3298 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3299 | @type ast.GeneratorExp |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3300 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3301 | self.visit(node.generators) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3302 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3303 | def visit_ListComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3304 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3305 | Public method to handle a list comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3306 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3307 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3308 | @type TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3309 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3310 | self.visit(node.generators) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3311 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3312 | def visit_DictComp(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3313 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3314 | Public method to handle a dictionary comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3315 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3316 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3317 | @type TYPE |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3318 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3319 | self.visit(node.generators) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3320 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3321 | def visit_comprehension(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3322 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3323 | Public method to handle the 'for' of a comprehension. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3324 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3325 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3326 | @type ast.comprehension |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3327 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3328 | self.visit(node.iter) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3329 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3330 | def visit_Lambda(self, node): |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3331 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3332 | Public method to handle a Lambda function. |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3333 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3334 | @param node reference to the node to be processed |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3335 | @type ast.Lambda |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3336 | """ |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3337 | self.visit(node.body) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3338 | for lambdaArg in node.args.args: |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3339 | self.getNames().pop(lambdaArg.arg, None) |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3340 | |
2b768afcaee1
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
3341 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3342 | class ReturnVisitor(ast.NodeVisitor): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3343 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3344 | Class implementing a node visitor to check return statements. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3345 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3346 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3347 | Assigns = "assigns" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3348 | Refs = "refs" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3349 | Returns = "returns" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3350 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3351 | def __init__(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3352 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3353 | Constructor |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3354 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
3355 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3356 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3357 | self.__stack = [] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3358 | self.violations = [] |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3359 | self.__loopCount = 0 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3360 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3361 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3362 | def assigns(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3363 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3364 | Public method to get the Assign nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3365 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3366 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3367 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3368 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3369 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3370 | return self.__stack[-1][ReturnVisitor.Assigns] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3371 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3372 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3373 | def refs(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3374 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3375 | Public method to get the References nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3376 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3377 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3378 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3379 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3380 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3381 | return self.__stack[-1][ReturnVisitor.Refs] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3382 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3383 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3384 | def returns(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3385 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3386 | Public method to get the Return nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3387 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3388 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3389 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3390 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3391 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3392 | return self.__stack[-1][ReturnVisitor.Returns] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3393 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3394 | def visit_For(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3395 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3396 | Public method to handle a for loop. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3397 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3398 | @param node reference to the for node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3399 | @type ast.For |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3400 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3401 | self.__visitLoop(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3402 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3403 | def visit_AsyncFor(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3404 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3405 | Public method to handle an async for loop. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3406 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3407 | @param node reference to the async for node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3408 | @type ast.AsyncFor |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3409 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3410 | self.__visitLoop(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3411 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3412 | def visit_While(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3413 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3414 | Public method to handle a while loop. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3415 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3416 | @param node reference to the while node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3417 | @type ast.While |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3418 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3419 | self.__visitLoop(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3420 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3421 | def __visitLoop(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3422 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3423 | Private method to handle loop nodes. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3424 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3425 | @param node reference to the loop node to handle |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3426 | @type ast.For, ast.AsyncFor or ast.While |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3427 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3428 | self.__loopCount += 1 |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3429 | self.generic_visit(node) |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3430 | self.__loopCount -= 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3431 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3432 | def __visitWithStack(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3433 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3434 | Private method to traverse a given function node using a stack. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3435 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3436 | @param node AST node to be traversed |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3437 | @type ast.FunctionDef or ast.AsyncFunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3438 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3439 | self.__stack.append( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3440 | { |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3441 | ReturnVisitor.Assigns: defaultdict(list), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3442 | ReturnVisitor.Refs: defaultdict(list), |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3443 | ReturnVisitor.Returns: [], |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3444 | } |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3445 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3446 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3447 | self.generic_visit(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3448 | self.__checkFunction(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3449 | self.__stack.pop() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3450 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3451 | def visit_FunctionDef(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3452 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3453 | Public method to handle a function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3454 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3455 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3456 | @type ast.FunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3457 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3458 | self.__visitWithStack(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3459 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3460 | def visit_AsyncFunctionDef(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3461 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3462 | Public method to handle a function definition. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3463 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3464 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3465 | @type ast.AsyncFunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3466 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3467 | self.__visitWithStack(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3468 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3469 | def visit_Return(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3470 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3471 | Public method to handle a return node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3472 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3473 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3474 | @type ast.Return |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3475 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3476 | self.returns.append(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3477 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3478 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3479 | def visit_Assign(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3480 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3481 | Public method to handle an assign node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3482 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3483 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3484 | @type ast.Assign |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3485 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3486 | if not self.__stack: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3487 | return |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3488 | |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3489 | self.generic_visit(node.value) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3490 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3491 | target = node.targets[0] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3492 | if isinstance(target, ast.Tuple) and not isinstance(node.value, ast.Tuple): |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3493 | # skip unpacking assign |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3494 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3495 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3496 | self.__visitAssignTarget(target) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3497 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3498 | def visit_Name(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3499 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3500 | Public method to handle a name node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3501 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3502 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3503 | @type ast.Name |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3504 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3505 | if self.__stack: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3506 | self.refs[node.id].append(node.lineno) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3507 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3508 | def __visitAssignTarget(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3509 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3510 | Private method to handle an assign target node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3511 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3512 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3513 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3514 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3515 | if isinstance(node, ast.Tuple): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3516 | for elt in node.elts: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3517 | self.__visitAssignTarget(elt) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3518 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3519 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3520 | if not self.__loopCount and isinstance(node, ast.Name): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3521 | self.assigns[node.id].append(node.lineno) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3522 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3523 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3524 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3525 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3526 | def __checkFunction(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3527 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3528 | Private method to check a function definition node. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3529 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3530 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3531 | @type ast.AsyncFunctionDef or ast.FunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3532 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3533 | if not self.returns or not node.body: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3534 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3535 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3536 | if len(node.body) == 1 and isinstance(node.body[-1], ast.Return): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3537 | # skip functions that consist of `return None` only |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3538 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3539 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3540 | if not self.__resultExists(): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3541 | self.__checkUnnecessaryReturnNone() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3542 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3543 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3544 | self.__checkImplicitReturnValue() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3545 | self.__checkImplicitReturn(node.body[-1]) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3546 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3547 | for n in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3548 | if n.value: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3549 | self.__checkUnnecessaryAssign(n.value) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3550 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3551 | def __isNone(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3552 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3553 | Private method to check, if a node value is None. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3554 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3555 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3556 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3557 | @return flag indicating the node contains a None value |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3558 | @rtype bool |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3559 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3560 | return AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3561 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3562 | def __isFalse(self, node): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3563 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3564 | Private method to check, if a node value is False. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3565 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3566 | @param node reference to the node to check |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3567 | @type ast.AST |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3568 | @return flag indicating the node contains a False value |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3569 | @rtype bool |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3570 | """ |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3571 | return ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3572 | AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is False |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3573 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3574 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3575 | def __resultExists(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3576 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3577 | Private method to check the existance of a return result. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3578 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3579 | @return flag indicating the existence of a return result |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3580 | @rtype bool |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3581 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3582 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3583 | value = node.value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3584 | if value and not self.__isNone(value): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3585 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3586 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3587 | return False |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3588 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3589 | def __checkImplicitReturnValue(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3590 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3591 | Private method to check for implicit return values. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3592 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3593 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3594 | if not node.value: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3595 | self.violations.append((node, "M832")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3596 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3597 | def __checkUnnecessaryReturnNone(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3598 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3599 | Private method to check for an unnecessary 'return None' statement. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3600 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3601 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3602 | if self.__isNone(node.value): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3603 | self.violations.append((node, "M831")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3604 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3605 | def __checkImplicitReturn(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3606 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3607 | Private method to check for an implicit return statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3608 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3609 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3610 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3611 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3612 | if isinstance(node, ast.If): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3613 | if not node.body or not node.orelse: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3614 | self.violations.append((node, "M833")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3615 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3616 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3617 | self.__checkImplicitReturn(node.body[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3618 | self.__checkImplicitReturn(node.orelse[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3619 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3620 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3621 | if isinstance(node, (ast.For, ast.AsyncFor)) and node.orelse: |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3622 | self.__checkImplicitReturn(node.orelse[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3623 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3624 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3625 | if isinstance(node, (ast.With, ast.AsyncWith)): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3626 | self.__checkImplicitReturn(node.body[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3627 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3628 | |
7651
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3629 | if isinstance(node, ast.Assert) and self.__isFalse(node.test): |
ca87b7490449
Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7639
diff
changeset
|
3630 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3631 | |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
3632 | try: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
3633 | okNodes = (ast.Return, ast.Raise, ast.While, ast.Try) |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
3634 | except AttributeError: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
3635 | okNodes = (ast.Return, ast.Raise, ast.While) |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
3636 | if not isinstance(node, okNodes): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3637 | self.violations.append((node, "M833")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3638 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3639 | def __checkUnnecessaryAssign(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3640 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3641 | Private method to check for an unnecessary assign statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3642 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3643 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3644 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3645 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3646 | if not isinstance(node, ast.Name): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3647 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3648 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3649 | varname = node.id |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3650 | returnLineno = node.lineno |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3651 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3652 | if varname not in self.assigns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3653 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3654 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3655 | if varname not in self.refs: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3656 | self.violations.append((node, "M834")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3657 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3658 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3659 | if self.__hasRefsBeforeNextAssign(varname, returnLineno): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3660 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3661 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3662 | self.violations.append((node, "M834")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3663 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3664 | def __hasRefsBeforeNextAssign(self, varname, returnLineno): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3665 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3666 | Private method to check for references before a following assign |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3667 | statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3668 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3669 | @param varname variable name to check for |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3670 | @type str |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3671 | @param returnLineno line number of the return statement |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3672 | @type int |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3673 | @return flag indicating the existence of references |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3674 | @rtype bool |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3675 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3676 | beforeAssign = 0 |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3677 | afterAssign = None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3678 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3679 | for lineno in sorted(self.assigns[varname]): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3680 | if lineno > returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3681 | afterAssign = lineno |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3682 | break |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3683 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3684 | if lineno <= returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3685 | beforeAssign = lineno |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3686 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3687 | for lineno in self.refs[varname]: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3688 | if lineno == returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3689 | continue |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3690 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3691 | if afterAssign: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3692 | if beforeAssign < lineno <= afterAssign: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3693 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3694 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3695 | elif beforeAssign < lineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3696 | return True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3697 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
3698 | return False |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3699 | |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3700 | |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3701 | class DateTimeVisitor(ast.NodeVisitor): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3702 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3703 | Class implementing a node visitor to check datetime function calls. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3704 | |
9274
86fab0c74430
Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9221
diff
changeset
|
3705 | Note: This class is modeled after flake8_datetimez checker. |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3706 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3707 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3708 | def __init__(self): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3709 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3710 | Constructor |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3711 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
3712 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3713 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3714 | self.violations = [] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3715 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3716 | def __getFromKeywords(self, keywords, name): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3717 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3718 | Private method to get a keyword node given its name. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3719 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3720 | @param keywords list of keyword argument nodes |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3721 | @type list of ast.AST |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3722 | @param name name of the keyword node |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3723 | @type str |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3724 | @return keyword node |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3725 | @rtype ast.AST |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3726 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3727 | for keyword in keywords: |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3728 | if keyword.arg == name: |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3729 | return keyword |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3730 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3731 | return None |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3732 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3733 | def visit_Call(self, node): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3734 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3735 | Public method to handle a function call. |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3736 | |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3737 | Every datetime related function call is check for use of the naive |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3738 | variant (i.e. use without TZ info). |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3739 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3740 | @param node reference to the node to be processed |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3741 | @type ast.Call |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3742 | """ |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3743 | # datetime.something() |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3744 | isDateTimeClass = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3745 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3746 | and isinstance(node.func.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3747 | and node.func.value.id == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3748 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3749 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3750 | # datetime.datetime.something() |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3751 | isDateTimeModuleAndClass = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3752 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3753 | and isinstance(node.func.value, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3754 | and node.func.value.attr == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3755 | and isinstance(node.func.value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3756 | and node.func.value.value.id == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3757 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3758 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3759 | if isDateTimeClass: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3760 | if node.func.attr == "datetime": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3761 | # datetime.datetime(2000, 1, 1, 0, 0, 0, 0, |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3762 | # datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3763 | isCase1 = len(node.args) >= 8 and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3764 | AstUtilities.isNameConstant(node.args[7]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3765 | and AstUtilities.getValue(node.args[7]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3766 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3767 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3768 | # datetime.datetime(2000, 1, 1, tzinfo=datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3769 | tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3770 | isCase2 = tzinfoKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3771 | AstUtilities.isNameConstant(tzinfoKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3772 | and AstUtilities.getValue(tzinfoKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3773 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3774 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3775 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3776 | self.violations.append((node, "M301")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3777 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3778 | elif node.func.attr == "time": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3779 | # time(12, 10, 45, 0, datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3780 | isCase1 = len(node.args) >= 5 and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3781 | AstUtilities.isNameConstant(node.args[4]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3782 | and AstUtilities.getValue(node.args[4]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3783 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3784 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3785 | # datetime.time(12, 10, 45, tzinfo=datetime.timezone.utc) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3786 | tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3787 | isCase2 = tzinfoKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3788 | AstUtilities.isNameConstant(tzinfoKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3789 | and AstUtilities.getValue(tzinfoKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3790 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3791 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3792 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3793 | self.violations.append((node, "M321")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3794 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3795 | elif node.func.attr == "date": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3796 | self.violations.append((node, "M311")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3797 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3798 | if isDateTimeClass or isDateTimeModuleAndClass: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3799 | if node.func.attr == "today": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3800 | self.violations.append((node, "M302")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3801 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3802 | elif node.func.attr == "utcnow": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3803 | self.violations.append((node, "M303")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3804 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3805 | elif node.func.attr == "utcfromtimestamp": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3806 | self.violations.append((node, "M304")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3807 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3808 | elif node.func.attr in "now": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3809 | # datetime.now(UTC) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3810 | isCase1 = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3811 | len(node.args) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3812 | and len(node.keywords) == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3813 | and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3814 | AstUtilities.isNameConstant(node.args[0]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3815 | and AstUtilities.getValue(node.args[0]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3816 | ) |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3817 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3818 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3819 | # datetime.now(tz=UTC) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3820 | tzKeyword = self.__getFromKeywords(node.keywords, "tz") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3821 | isCase2 = tzKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3822 | AstUtilities.isNameConstant(tzKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3823 | and AstUtilities.getValue(tzKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3824 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3825 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3826 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3827 | self.violations.append((node, "M305")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3828 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3829 | elif node.func.attr == "fromtimestamp": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3830 | # datetime.fromtimestamp(1234, UTC) |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3831 | isCase1 = ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3832 | len(node.args) == 2 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3833 | and len(node.keywords) == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3834 | and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3835 | AstUtilities.isNameConstant(node.args[1]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3836 | and AstUtilities.getValue(node.args[1]) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3837 | ) |
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3838 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3839 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3840 | # datetime.fromtimestamp(1234, tz=UTC) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3841 | tzKeyword = self.__getFromKeywords(node.keywords, "tz") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3842 | isCase2 = tzKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3843 | AstUtilities.isNameConstant(tzKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3844 | and AstUtilities.getValue(tzKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3845 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3846 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3847 | if not (isCase1 or isCase2): |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3848 | self.violations.append((node, "M306")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3849 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3850 | elif node.func.attr == "strptime": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3851 | # datetime.strptime(...).replace(tzinfo=UTC) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3852 | parent = getattr(node, "_dtCheckerParent", None) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3853 | pparent = getattr(parent, "_dtCheckerParent", None) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3854 | if not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3855 | isinstance(parent, ast.Attribute) and parent.attr == "replace" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3856 | ) or not isinstance(pparent, ast.Call): |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3857 | isCase1 = False |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3858 | else: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3859 | tzinfoKeyword = self.__getFromKeywords(pparent.keywords, "tzinfo") |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3860 | isCase1 = tzinfoKeyword is not None and not ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3861 | AstUtilities.isNameConstant(tzinfoKeyword.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3862 | and AstUtilities.getValue(tzinfoKeyword.value) is None |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
3863 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3864 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3865 | if not isCase1: |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3866 | self.violations.append((node, "M307")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3867 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3868 | elif node.func.attr == "fromordinal": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3869 | self.violations.append((node, "M308")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3870 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3871 | # date.something() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3872 | isDateClass = ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3873 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3874 | and isinstance(node.func.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3875 | and node.func.value.id == "date" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3876 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3877 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3878 | # datetime.date.something() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3879 | isDateModuleAndClass = ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3880 | isinstance(node.func, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3881 | and isinstance(node.func.value, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3882 | and node.func.value.attr == "date" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3883 | and isinstance(node.func.value.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3884 | and node.func.value.value.id == "datetime" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3885 | ) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3886 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3887 | if isDateClass or isDateModuleAndClass: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3888 | if node.func.attr == "today": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3889 | self.violations.append((node, "M312")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3890 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3891 | elif node.func.attr == "fromtimestamp": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3892 | self.violations.append((node, "M313")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3893 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3894 | elif node.func.attr == "fromordinal": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3895 | self.violations.append((node, "M314")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3896 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3897 | elif node.func.attr == "fromisoformat": |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3898 | self.violations.append((node, "M315")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3899 | |
7045
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3900 | self.generic_visit(node) |
c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7042
diff
changeset
|
3901 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3902 | |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3903 | class SysVersionVisitor(ast.NodeVisitor): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3904 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3905 | Class implementing a node visitor to check the use of sys.version and |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3906 | sys.version_info. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3907 | |
9274
86fab0c74430
Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9221
diff
changeset
|
3908 | Note: This class is modeled after flake8-2020 checker. |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3909 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3910 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3911 | def __init__(self): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3912 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3913 | Constructor |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3914 | """ |
8218
7c09585bd960
Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8207
diff
changeset
|
3915 | super().__init__() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3916 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3917 | self.violations = [] |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3918 | self.__fromImports = {} |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3919 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3920 | def visit_ImportFrom(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3921 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3922 | Public method to handle a from ... import ... statement. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3923 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3924 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3925 | @type ast.ImportFrom |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3926 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3927 | for alias in node.names: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3928 | if node.module is not None and not alias.asname: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3929 | self.__fromImports[alias.name] = node.module |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3930 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3931 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3932 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3933 | def __isSys(self, attr, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3934 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3935 | Private method to check for a reference to sys attribute. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3936 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3937 | @param attr attribute name |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3938 | @type str |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3939 | @param node reference to the node to be checked |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3940 | @type ast.Node |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3941 | @return flag indicating a match |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3942 | @rtype bool |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3943 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3944 | match = False |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3945 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3946 | isinstance(node, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3947 | and isinstance(node.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3948 | and node.value.id == "sys" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3949 | and node.attr == attr |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3950 | ) or ( |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3951 | isinstance(node, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3952 | and node.id == attr |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3953 | and self.__fromImports.get(node.id) == "sys" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3954 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3955 | match = True |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3956 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3957 | return match |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3958 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3959 | def __isSysVersionUpperSlice(self, node, n): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3960 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3961 | Private method to check the upper slice of sys.version. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3962 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3963 | @param node reference to the node to be checked |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3964 | @type ast.Node |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3965 | @param n slice value to check against |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3966 | @type int |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3967 | @return flag indicating a match |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3968 | @rtype bool |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3969 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3970 | return ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3971 | self.__isSys("version", node.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3972 | and isinstance(node.slice, ast.Slice) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3973 | and node.slice.lower is None |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3974 | and AstUtilities.isNumber(node.slice.upper) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3975 | and AstUtilities.getValue(node.slice.upper) == n |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3976 | and node.slice.step is None |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3977 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3978 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3979 | def visit_Subscript(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3980 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3981 | Public method to handle a subscript. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3982 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3983 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3984 | @type ast.Subscript |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3985 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3986 | if self.__isSysVersionUpperSlice(node, 1): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3987 | self.violations.append((node.value, "M423")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3988 | elif self.__isSysVersionUpperSlice(node, 3): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3989 | self.violations.append((node.value, "M401")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3990 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3991 | self.__isSys("version", node.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3992 | and isinstance(node.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3993 | and AstUtilities.isNumber(node.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3994 | and AstUtilities.getValue(node.slice.value) == 2 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3995 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3996 | self.violations.append((node.value, "M402")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
3997 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3998 | self.__isSys("version", node.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
3999 | and isinstance(node.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4000 | and AstUtilities.isNumber(node.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4001 | and AstUtilities.getValue(node.slice.value) == 0 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4002 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4003 | self.violations.append((node.value, "M421")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4004 | |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4005 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4006 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4007 | def visit_Compare(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4008 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4009 | Public method to handle a comparison. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4010 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4011 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4012 | @type ast.Compare |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4013 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4014 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4015 | isinstance(node.left, ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4016 | and self.__isSys("version_info", node.left.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4017 | and isinstance(node.left.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4018 | and AstUtilities.isNumber(node.left.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4019 | and AstUtilities.getValue(node.left.slice.value) == 0 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4020 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4021 | and isinstance(node.ops[0], ast.Eq) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4022 | and AstUtilities.isNumber(node.comparators[0]) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4023 | and AstUtilities.getValue(node.comparators[0]) == 3 |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4024 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4025 | self.violations.append((node.left, "M411")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4026 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4027 | self.__isSys("version", node.left) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4028 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4029 | and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4030 | and AstUtilities.isString(node.comparators[0]) |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4031 | ): |
7289
6f4761a73f5f
MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7256
diff
changeset
|
4032 | if len(AstUtilities.getValue(node.comparators[0])) == 1: |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4033 | errorCode = "M422" |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4034 | else: |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4035 | errorCode = "M403" |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4036 | self.violations.append((node.left, errorCode)) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4037 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4038 | isinstance(node.left, ast.Subscript) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4039 | and self.__isSys("version_info", node.left.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4040 | and isinstance(node.left.slice, ast.Index) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4041 | and AstUtilities.isNumber(node.left.slice.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4042 | and AstUtilities.getValue(node.left.slice.value) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4043 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4044 | and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4045 | and AstUtilities.isNumber(node.comparators[0]) |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4046 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4047 | self.violations.append((node, "M413")) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4048 | elif ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4049 | isinstance(node.left, ast.Attribute) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4050 | and self.__isSys("version_info", node.left.value) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4051 | and node.left.attr == "minor" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4052 | and len(node.ops) == 1 |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4053 | and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE)) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4054 | and AstUtilities.isNumber(node.comparators[0]) |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4055 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4056 | self.violations.append((node, "M414")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4057 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4058 | self.generic_visit(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4059 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4060 | def visit_Attribute(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4061 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4062 | Public method to handle an attribute. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4063 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4064 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4065 | @type ast.Attribute |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4066 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4067 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4068 | isinstance(node.value, ast.Name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4069 | and node.value.id == "six" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4070 | and node.attr == "PY3" |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4071 | ): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4072 | self.violations.append((node, "M412")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4073 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4074 | self.generic_visit(node) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4075 | |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4076 | def visit_Name(self, node): |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4077 | """ |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4078 | Public method to handle an name. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4079 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4080 | @param node reference to the node to be processed |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4081 | @type ast.Name |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4082 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4083 | if node.id == "PY3" and self.__fromImports.get(node.id) == "six": |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4084 | self.violations.append((node, "M412")) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4085 | |
7245
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4086 | self.generic_visit(node) |
b47179fbb9d8
Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7057
diff
changeset
|
4087 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
4088 | |
4555
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
4089 | # |
7639
422fd05e9c91
Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
7637
diff
changeset
|
4090 | # eflag: noqa = M891 |