Corrected and checked some code style issues (unused function arguments).
9325
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1
|
# -*- coding: utf-8 -*- |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2
|
|
9653
|
3
|
# Copyright (c) 2022 - 2023 Detlev Offenbach <detlev@die-offenbachs.de> |
9325
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7
|
Module implementing checks for the insecure use of SNMP. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11
|
# This is a modified version of the one found in the bandit package. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13
|
# Original Copyright (c) 2018 SolarWinds, Inc. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15
|
# SPDX-License-Identifier: Apache-2.0 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19
|
def getChecks(): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21
|
Public method to get a dictionary with checks handled by this module. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23
|
@return dictionary containing checker lists containing checker function and |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24
|
list of codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25
|
@rtype dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
26
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27
|
return { |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
28
|
"Call": [ |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
29
|
(checkInsecureVersion, ("S508",)), |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30
|
(checkWeakCryptography, ("S509",)), |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31
|
], |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
32
|
} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34
|
|
10069
435cc5875135
Corrected and checked some code style issues (unused function arguments).
Detlev Offenbach <detlev@die-offenbachs.de>
diff
changeset
|
35
|
def checkInsecureVersion(reportError, context, config): # noqa: U100 |
9325
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37
|
Function to check for the use of insecure SNMP version like |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38
|
v1, v2c. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40
|
@param reportError function to be used to report errors |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41
|
@type func |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42
|
@param context security context object |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43
|
@type SecurityContext |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44
|
@param config dictionary with configuration data |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45
|
@type dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47
|
if context.callFunctionNameQual == "pysnmp.hlapi.CommunityData" and ( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48
|
context.checkCallArgValue("mpModel", 0) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49
|
or context.check_call_arg_value("mpModel", 1) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50
|
): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51
|
# We called community data. Lets check our args |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52
|
reportError( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53
|
context.node.lineno - 1, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54
|
context.node.col_offset, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55
|
"S508", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56
|
"M", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57
|
"H", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58
|
) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60
|
|
10069
435cc5875135
Corrected and checked some code style issues (unused function arguments).
Detlev Offenbach <detlev@die-offenbachs.de>
diff
changeset
|
61
|
def checkWeakCryptography(reportError, context, config): # noqa: U100 |
9325
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63
|
Function to check for the use of insecure SNMP cryptography |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64
|
(i.e. v3 using noAuthNoPriv). |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66
|
@param reportError function to be used to report errors |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67
|
@type func |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68
|
@param context security context object |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69
|
@type SecurityContext |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70
|
@param config dictionary with configuration data |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71
|
@type dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73
|
if ( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74
|
context.callFunctionNameQual == "pysnmp.hlapi.UsmUserData" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75
|
and context.callArgsCount < 3 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76
|
): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77
|
reportError(context.node.lineno - 1, context.node.col_offset, "S509", "M", "H") |