Sun, 21 May 2023 15:26:11 +0200
Code Style Checker
- Reorganized the code of the Imports Checker and extracted the name order stuff into its own checker.
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
9653
e67609152c5e
Updated copyright for 2023.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9479
diff
changeset
|
3 | # Copyright (c) 2021 - 2023 Detlev Offenbach <detlev@die-offenbachs.de> |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for import statements. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
10 | import ast |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11 | import copy |
9275
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
12 | import re |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15 | class ImportsChecker: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17 | Class implementing a checker for import statements. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
19 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20 | Codes = [ |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
21 | ## Local imports |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
22 | "I101", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
23 | "I102", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
24 | "I103", |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
25 | ## Various other import related |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
26 | "I901", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
27 | "I902", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
28 | "I903", |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
29 | "I904", |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30 | ] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31 | |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
32 | def __init__(self, source, filename, tree, select, ignore, expected, repeat, args): |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34 | Constructor |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
35 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36 | @param source source code to be checked |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38 | @param filename name of the source file |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39 | @type str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40 | @param tree AST tree of the source code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41 | @type ast.Module |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42 | @param select list of selected codes |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44 | @param ignore list of codes to be ignored |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46 | @param expected list of expected codes |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48 | @param repeat flag indicating to report each occurrence of a code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49 | @type bool |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
50 | @param args dictionary of arguments for the various checks |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51 | @type dict |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53 | self.__select = tuple(select) |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
54 | self.__ignore = ("",) if select else tuple(ignore) |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55 | self.__expected = expected[:] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56 | self.__repeat = repeat |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57 | self.__filename = filename |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58 | self.__source = source[:] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59 | self.__tree = copy.deepcopy(tree) |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60 | self.__args = args |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
61 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62 | # statistics counters |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63 | self.counters = {} |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
64 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65 | # collection of detected errors |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66 | self.errors = [] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
67 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68 | checkersWithCodes = [ |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
69 | (self.__checkLocalImports, ("I101", "I102", "I103")), |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
70 | (self.__tidyImports, ("I901", "I902", "I903", "I904")), |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71 | ] |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
72 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73 | self.__checkers = [] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74 | for checker, codes in checkersWithCodes: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
75 | if any(not (code and self.__ignoreCode(code)) for code in codes): |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76 | self.__checkers.append(checker) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
77 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78 | def __ignoreCode(self, code): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80 | Private method to check if the message code should be ignored. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82 | @param code message code to check for |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83 | @type str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84 | @return flag indicating to ignore the given code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85 | @rtype bool |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86 | """ |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
87 | return code.startswith(self.__ignore) and not code.startswith(self.__select) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
88 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89 | def __error(self, lineNumber, offset, code, *args): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91 | Private method to record an issue. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
92 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93 | @param lineNumber line number of the issue |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
94 | @type int |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95 | @param offset position within line of the issue |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96 | @type int |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97 | @param code message code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98 | @type str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99 | @param args arguments for the message |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100 | @type list |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102 | if self.__ignoreCode(code): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
104 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105 | if code in self.counters: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106 | self.counters[code] += 1 |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107 | else: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108 | self.counters[code] = 1 |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
109 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110 | # Don't care about expected codes |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111 | if code in self.__expected: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
113 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
114 | if code and (self.counters[code] == 1 or self.__repeat): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115 | # record the issue with one based line number |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116 | self.errors.append( |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117 | { |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118 | "file": self.__filename, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119 | "line": lineNumber + 1, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120 | "offset": offset, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121 | "code": code, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122 | "args": args, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123 | } |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124 | ) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
125 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126 | def run(self): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128 | Public method to check the given source against miscellaneous |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129 | conditions. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131 | if not self.__filename: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132 | # don't do anything, if essential data is missing |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
133 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
134 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
135 | if not self.__checkers: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136 | # don't do anything, if no codes were selected |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
138 | |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
139 | for check in self.__checkers: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
140 | check() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
141 | |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
142 | ####################################################################### |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
143 | ## Local imports |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
144 | ## |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
145 | ## adapted from: flake8-local-import v1.0.6 |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
146 | ####################################################################### |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
147 | |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
148 | def __checkLocalImports(self): |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
149 | """ |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
150 | Private method to check local imports. |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
151 | """ |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
152 | from .LocalImportVisitor import LocalImportVisitor |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
153 | |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
154 | visitor = LocalImportVisitor(self.__args, self) |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
155 | visitor.visit(copy.deepcopy(self.__tree)) |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
156 | for violation in visitor.violations: |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
157 | if not self.__ignoreCode(violation[1]): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
158 | node = violation[0] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
159 | reason = violation[1] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
160 | self.__error(node.lineno - 1, node.col_offset, reason) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
161 | |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
162 | ####################################################################### |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
163 | ## Tidy imports |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
164 | ## |
9275
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
165 | ## adapted from: flake8-tidy-imports v4.8.0 |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
166 | ####################################################################### |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
167 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
168 | def __tidyImports(self): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
169 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
170 | Private method to check various other import related topics. |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
171 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
172 | self.__banRelativeImports = self.__args.get("BanRelativeImports", "") |
9275
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
173 | self.__bannedModules = [] |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
174 | self.__bannedStructuredPatterns = [] |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
175 | self.__bannedUnstructuredPatterns = [] |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
176 | for module in self.__args.get("BannedModules", []): |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
177 | module = module.strip() |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
178 | if "*" in module[:-1] or module == "*": |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
179 | # unstructured |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
180 | self.__bannedUnstructuredPatterns.append( |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
181 | self.__compileUnstructuredGlob(module) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
182 | ) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
183 | elif module.endswith(".*"): |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
184 | # structured |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
185 | self.__bannedStructuredPatterns.append(module) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
186 | # Also check for exact matches without the wildcard |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
187 | # e.g. "foo.*" matches "foo" |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
188 | prefix = module[:-2] |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
189 | if prefix not in self.__bannedModules: |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
190 | self.__bannedModules.append(prefix) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
191 | else: |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
192 | self.__bannedModules.append(module) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
193 | |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
194 | # Sort the structured patterns so we match the specifc ones first. |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
195 | self.__bannedStructuredPatterns.sort(key=lambda x: len(x[0]), reverse=True) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
196 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
197 | ruleMethods = [] |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
198 | if not self.__ignoreCode("I901"): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
199 | ruleMethods.append(self.__checkUnnecessaryAlias) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
200 | if not self.__ignoreCode("I902") and bool(self.__bannedModules): |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
201 | ruleMethods.append(self.__checkBannedImport) |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
202 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
203 | not self.__ignoreCode("I903") and self.__banRelativeImports == "parents" |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
204 | ) or (not self.__ignoreCode("I904") and self.__banRelativeImports == "true"): |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
205 | ruleMethods.append(self.__checkBannedRelativeImports) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
206 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
207 | for node in ast.walk(self.__tree): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
208 | for method in ruleMethods: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
209 | method(node) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
210 | |
9275
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
211 | def __compileUnstructuredGlob(self, module): |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
212 | """ |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
213 | Private method to convert a pattern to a regex such that ".*" matches zero or |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
214 | more modules. |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
215 | |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
216 | @param module module pattern to be converted |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
217 | @type str |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
218 | @return compiled regex |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
219 | @rtype re.regex object |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
220 | """ |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
221 | parts = module.split(".") |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
222 | transformedParts = [ |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
223 | "(\\..*)?" if p == "*" else "\\." + re.escape(p) for p in parts |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
224 | ] |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
225 | if parts[0] == "*": |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
226 | transformedParts[0] = ".*" |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
227 | else: |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
228 | transformedParts[0] = re.escape(parts[0]) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
229 | return re.compile("".join(transformedParts) + "\\Z") |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
230 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
231 | def __checkUnnecessaryAlias(self, node): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
232 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
233 | Private method to check unnecessary import aliases. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
234 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
235 | @param node reference to the node to be checked |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
236 | @type ast.AST |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
237 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
238 | if isinstance(node, ast.Import): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
239 | for alias in node.names: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
240 | if "." not in alias.name: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
241 | fromName = None |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
242 | importedName = alias.name |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
243 | else: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
244 | fromName, importedName = alias.name.rsplit(".", 1) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
245 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
246 | if importedName == alias.asname: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
247 | if fromName: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
248 | rewritten = "from {0} import {1}".format(fromName, importedName) |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
249 | else: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
250 | rewritten = "import {0}".format(importedName) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
251 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
252 | self.__error(node.lineno - 1, node.col_offset, "I901", rewritten) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
253 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
254 | elif isinstance(node, ast.ImportFrom): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
255 | for alias in node.names: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
256 | if alias.name == alias.asname: |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
257 | rewritten = "from {0} import {1}".format(node.module, alias.name) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
258 | |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
259 | self.__error(node.lineno - 1, node.col_offset, "I901", rewritten) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
260 | |
9275
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
261 | def __isModuleBanned(self, moduleName): |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
262 | """ |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
263 | Private method to check, if the given module name banned. |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
264 | |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
265 | @param moduleName module name to be checked |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
266 | @type str |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
267 | @return flag indicating a banned module |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
268 | @rtype bool |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
269 | """ |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
270 | if moduleName in self.__bannedModules: |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
271 | return True |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
272 | |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
273 | # Check unustructed wildcards |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
274 | if any( |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
275 | bannedPattern.match(moduleName) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
276 | for bannedPattern in self.__bannedUnstructuredPatterns |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
277 | ): |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
278 | return True |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
279 | |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
280 | # Check structured wildcards |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
281 | if any( |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
282 | moduleName.startswith(bannedPrefix[:-1]) |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
283 | for bannedPrefix in self.__bannedStructuredPatterns |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
284 | ): |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
285 | return True |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
286 | |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
287 | return False |
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
288 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
289 | def __checkBannedImport(self, node): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
290 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
291 | Private method to check import of banned modules. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
292 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
293 | @param node reference to the node to be checked |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
294 | @type ast.AST |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
295 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
296 | if not bool(self.__bannedModules): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
297 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
298 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
299 | if isinstance(node, ast.Import): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
300 | moduleNames = [alias.name for alias in node.names] |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
301 | elif isinstance(node, ast.ImportFrom): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
302 | nodeModule = node.module or "" |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
303 | moduleNames = [nodeModule] |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
304 | for alias in node.names: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
305 | moduleNames.append("{0}.{1}".format(nodeModule, alias.name)) |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
306 | else: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
307 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
308 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
309 | # Sort from most to least specific paths. |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
310 | moduleNames.sort(key=len, reverse=True) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
311 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
312 | warned = set() |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
313 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
314 | for moduleName in moduleNames: |
9275
1a7d545d3ef2
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9274
diff
changeset
|
315 | if self.__isModuleBanned(moduleName): |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
316 | if any(mod.startswith(moduleName) for mod in warned): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
317 | # Do not show an error for this line if we already showed |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
318 | # a more specific error. |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
319 | continue |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
320 | else: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
321 | warned.add(moduleName) |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
322 | self.__error(node.lineno - 1, node.col_offset, "I902", moduleName) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
323 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
324 | def __checkBannedRelativeImports(self, node): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
325 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
326 | Private method to check if relative imports are banned. |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
327 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
328 | @param node reference to the node to be checked |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
329 | @type ast.AST |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
330 | """ |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
331 | if not self.__banRelativeImports: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
332 | return |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
333 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
334 | elif self.__banRelativeImports == "parents": |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
335 | minNodeLevel = 1 |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
336 | msgCode = "I903" |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
337 | else: |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
338 | minNodeLevel = 0 |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
339 | msgCode = "I904" |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
340 | |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
341 | if ( |
9221
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
342 | self.__banRelativeImports |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
343 | and isinstance(node, ast.ImportFrom) |
bf71ee032bb4
Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
9209
diff
changeset
|
344 | and node.level > minNodeLevel |
8808
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
345 | ): |
033fa34447d0
Finished implementing a checker for import statements (unnecessary alias, banned relative and banned modules).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8802
diff
changeset
|
346 | self.__error(node.lineno - 1, node.col_offset, msgCode) |