Wed, 20 Mar 2019 20:03:22 +0100
MiscellaneousChecker: fixed some Python2 related issues.
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
6645
ad476851d7e0
Updated copyright for 2019.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6247
diff
changeset
|
3 | # Copyright (c) 2015 - 2019 Detlev Offenbach <detlev@die-offenbachs.de> |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10 | import sys |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11 | import ast |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12 | import re |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
13 | import itertools |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
14 | from string import Formatter |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
15 | from collections import defaultdict |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
18 | def composeCallPath(node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
19 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
20 | Generator function to assemble the call path of a given node. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
21 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
22 | @param node node to assemble call path for |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
23 | @type ast.Node |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
24 | @return call path components |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
25 | @rtype str |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
26 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
27 | if isinstance(node, ast.Attribute): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
28 | for v in composeCallPath(node.value): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
29 | yield v |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
30 | yield node.attr |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
31 | elif isinstance(node, ast.Name): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
32 | yield node.id |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
33 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
34 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35 | class MiscellaneousChecker(object): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37 | Class implementing a checker for miscellaneous checks. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39 | Codes = [ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40 | "M101", "M102", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41 | "M111", "M112", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
42 | "M131", "M132", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
43 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
44 | "M191", "M192", "M193", "M194", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
45 | "M195", "M196", "M197", "M198", |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
46 | |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
47 | "M201", |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
48 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
49 | "M501", "M502", "M503", "M504", "M505", "M506", "M507", |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
50 | "M511", "M512", "M513", "M514", |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
51 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
52 | "M601", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
53 | "M611", "M612", "M613", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
54 | "M621", "M622", "M623", "M624", "M625", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
55 | "M631", "M632", |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
56 | "M651", "M652", "M653", "M654", "M655", |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
57 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
58 | "M701", "M702", |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
59 | "M711", |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
60 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61 | "M801", |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
62 | "M811", |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
63 | "M821", "M822", |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
64 | "M831", "M832", "M833", "M834", |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66 | "M901", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67 | ] |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
68 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
69 | Formatter = Formatter() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
70 | FormatFieldRegex = re.compile(r'^((?:\s|.)*?)(\..*|\[.*\])?$') |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
71 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
72 | BuiltinsWhiteList = [ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
73 | "__name__", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
74 | "__doc__", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
75 | "credits", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
76 | ] |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78 | def __init__(self, source, filename, select, ignore, expected, repeat, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79 | args): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81 | Constructor |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
83 | @param source source code to be checked |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
84 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
85 | @param filename name of the source file |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
86 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
87 | @param select list of selected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
88 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
89 | @param ignore list of codes to be ignored |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
90 | @type list of str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
91 | @param expected list of expected codes |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
92 | @type list of str |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93 | @param repeat flag indicating to report each occurrence of a code |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
94 | @type bool |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
95 | @param args dictionary of arguments for the miscellaneous checks |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
96 | @type dict |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98 | self.__select = tuple(select) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99 | self.__ignore = ('',) if select else tuple(ignore) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100 | self.__expected = expected[:] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101 | self.__repeat = repeat |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102 | self.__filename = filename |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103 | self.__source = source[:] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104 | self.__args = args |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106 | self.__pep3101FormatRegex = re.compile( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107 | r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%') |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
108 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
109 | if sys.version_info >= (3, 0): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
110 | import builtins |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
111 | self.__builtins = [b for b in dir(builtins) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
112 | if b not in self.BuiltinsWhiteList] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
113 | else: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
114 | import __builtin__ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
115 | self.__builtins = [b for b in dir(__builtin__) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
116 | if b not in self.BuiltinsWhiteList] |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118 | # statistics counters |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119 | self.counters = {} |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121 | # collection of detected errors |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122 | self.errors = [] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124 | checkersWithCodes = [ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125 | (self.__checkCoding, ("M101", "M102")), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126 | (self.__checkCopyright, ("M111", "M112")), |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
127 | (self.__checkBuiltins, ("M131", "M132")), |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
128 | (self.__checkComprehensions, ("M191", "M192", "M193", "M194", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
129 | "M195", "M196", "M197", "M198")), |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
130 | (self.__checkDictWithSortedKeys, ("M201",)), |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
131 | (self.__checkPep3101, ("M601",)), |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
132 | (self.__checkFormatString, ("M611", "M612", "M613", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
133 | "M621", "M622", "M623", "M624", "M625", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
134 | "M631", "M632")), |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
135 | (self.__checkBugBear, ("M501", "M502", "M503", "M504", "M505", |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
136 | "M506", "M507", |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
137 | "M511", "M512", "M513", "M514")), |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
138 | (self.__checkLogging, ("M651", "M652", "M653", "M654", "M655")), |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
139 | (self.__checkFuture, ("M701", "M702")), |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
140 | (self.__checkGettext, ("M711",)), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
141 | (self.__checkPrintStatements, ("M801",)), |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
142 | (self.__checkTuple, ("M811", )), |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
143 | (self.__checkMutableDefault, ("M821", "M822")), |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
144 | (self.__checkReturn, ("M831", "M832", "M833", "M834")), |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
145 | ] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
146 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
147 | self.__defaultArgs = { |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
148 | "BuiltinsChecker": { |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
149 | "chr": ["unichr", ], |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
150 | "str": ["unicode", ], |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
151 | }, |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
152 | "CodingChecker": 'latin-1, utf-8', |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
153 | "CopyrightChecker": { |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
154 | "Author": "", |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
155 | "MinFilesize": 0, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
156 | }, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
157 | } |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
158 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
159 | self.__checkers = [] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
160 | for checker, codes in checkersWithCodes: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
161 | if any(not (code and self.__ignoreCode(code)) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
162 | for code in codes): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
163 | self.__checkers.append(checker) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
164 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
165 | def __ignoreCode(self, code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
166 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
167 | Private method to check if the message code should be ignored. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
168 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
169 | @param code message code to check for |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
170 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
171 | @return flag indicating to ignore the given code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
172 | @rtype bool |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
173 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
174 | return (code.startswith(self.__ignore) and |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
175 | not code.startswith(self.__select)) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
176 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
177 | def __error(self, lineNumber, offset, code, *args): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
178 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
179 | Private method to record an issue. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
180 | |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
181 | @param lineNumber line number of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
182 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
183 | @param offset position within line of the issue |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
184 | @type int |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
185 | @param code message code |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
186 | @type str |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
187 | @param args arguments for the message |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
188 | @type list |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
189 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
190 | if self.__ignoreCode(code): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
191 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
192 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
193 | if code in self.counters: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
194 | self.counters[code] += 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
195 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
196 | self.counters[code] = 1 |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
197 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
198 | # Don't care about expected codes |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
199 | if code in self.__expected: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
200 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
201 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
202 | if code and (self.counters[code] == 1 or self.__repeat): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
203 | # record the issue with one based line number |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
204 | self.errors.append( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
205 | (self.__filename, lineNumber + 1, offset, (code, args))) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
206 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
207 | def __reportInvalidSyntax(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
208 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
209 | Private method to report a syntax error. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
210 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
211 | exc_type, exc = sys.exc_info()[:2] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
212 | if len(exc.args) > 1: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
213 | offset = exc.args[1] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
214 | if len(offset) > 2: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
215 | offset = offset[1:3] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
216 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
217 | offset = (1, 0) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
218 | self.__error(offset[0] - 1, offset[1] or 0, |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
219 | 'M901', exc_type.__name__, exc.args[0]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
220 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
221 | def run(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
222 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
223 | Public method to check the given source against miscellaneous |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
224 | conditions. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
225 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
226 | if not self.__filename: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
227 | # don't do anything, if essential data is missing |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
228 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
229 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
230 | if not self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
231 | # don't do anything, if no codes were selected |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
232 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
233 | |
4510
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
234 | source = "".join(self.__source) |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
235 | # Check type for py2: if not str it's unicode |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
236 | if sys.version_info[0] == 2: |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
237 | try: |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
238 | source = source.encode('utf-8') |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
239 | except UnicodeError: |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
240 | pass |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
241 | try: |
4510
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
242 | self.__tree = compile(source, self.__filename, 'exec', |
43437fc9f4c9
Fixed an encoding related issue in the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4509
diff
changeset
|
243 | ast.PyCF_ONLY_AST) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
244 | except (SyntaxError, TypeError): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
245 | self.__reportInvalidSyntax() |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
246 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
247 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
248 | for check in self.__checkers: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
249 | check() |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
250 | |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
251 | def __getCoding(self): |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
252 | """ |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
253 | Private method to get the defined coding of the source. |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
254 | |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
255 | @return tuple containing the line number and the coding |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
256 | @rtype tuple of int and str |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
257 | """ |
6106
921d070cec82
Finished implementing support for EditorConfig.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6100
diff
changeset
|
258 | for lineno, line in enumerate(self.__source[:5]): |
6247
5c677a7f7d51
Corrected some code style issues detected by the new pycodestyle version.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6188
diff
changeset
|
259 | matched = re.search(r'coding[:=]\s*([-\w_.]+)', |
5c677a7f7d51
Corrected some code style issues detected by the new pycodestyle version.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6188
diff
changeset
|
260 | line, re.IGNORECASE) |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
261 | if matched: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
262 | return lineno, matched.group(1) |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
263 | else: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
264 | return 0, "" |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
265 | |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
266 | def __checkCoding(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
267 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
268 | Private method to check the presence of a coding line and valid |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
269 | encodings. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
270 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
271 | if len(self.__source) == 0: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
272 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
273 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
274 | encodings = [e.lower().strip() |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
275 | for e in self.__args.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
276 | "CodingChecker", self.__defaultArgs["CodingChecker"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
277 | .split(",")] |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
278 | lineno, coding = self.__getCoding() |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
279 | if coding: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
280 | if coding.lower() not in encodings: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
281 | self.__error(lineno, 0, "M102", coding) |
4506
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
282 | else: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
283 | self.__error(0, 0, "M101") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
284 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
285 | def __checkCopyright(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
286 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
287 | Private method to check the presence of a copyright statement. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
288 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
289 | source = "".join(self.__source) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
290 | copyrightArgs = self.__args.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
291 | "CopyrightChecker", self.__defaultArgs["CopyrightChecker"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
292 | copyrightMinFileSize = copyrightArgs.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
293 | "MinFilesize", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
294 | self.__defaultArgs["CopyrightChecker"]["MinFilesize"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
295 | copyrightAuthor = copyrightArgs.get( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
296 | "Author", |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
297 | self.__defaultArgs["CopyrightChecker"]["Author"]) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
298 | copyrightRegexStr = \ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
299 | r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}" |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
300 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
301 | tocheck = max(1024, copyrightMinFileSize) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
302 | topOfSource = source[:tocheck] |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
303 | if len(topOfSource) < copyrightMinFileSize: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
304 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
305 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
306 | copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
307 | re.IGNORECASE) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
308 | if not copyrightRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
309 | self.__error(0, 0, "M111") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
310 | return |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
311 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
312 | if copyrightAuthor: |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
313 | copyrightAuthorRe = re.compile( |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
314 | copyrightRegexStr.format(author=copyrightAuthor), |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
315 | re.IGNORECASE) |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
316 | if not copyrightAuthorRe.search(topOfSource): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
317 | self.__error(0, 0, "M112") |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
318 | |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
319 | def __checkPrintStatements(self): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
320 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
321 | Private method to check for print statements. |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
322 | """ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
323 | for node in ast.walk(self.__tree): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
324 | if (isinstance(node, ast.Call) and |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
325 | getattr(node.func, 'id', None) == 'print') or \ |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
326 | (hasattr(ast, 'Print') and isinstance(node, ast.Print)): |
57666e501a42
Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
327 | self.__error(node.lineno - 1, node.col_offset, "M801") |
4507
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
328 | |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
329 | def __checkTuple(self): |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
330 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
331 | Private method to check for one element tuples. |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
332 | """ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
333 | for node in ast.walk(self.__tree): |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
334 | if isinstance(node, ast.Tuple) and \ |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
335 | len(node.elts) == 1: |
1a5bc1ac7c2e
Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4506
diff
changeset
|
336 | self.__error(node.lineno - 1, node.col_offset, "M811") |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
337 | |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
338 | def __checkFuture(self): |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
339 | """ |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
340 | Private method to check the __future__ imports. |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
341 | """ |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
342 | expectedImports = { |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
343 | i.strip() |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
344 | for i in self.__args.get("FutureChecker", "").split(",") |
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
345 | if bool(i.strip())} |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
346 | if len(expectedImports) == 0: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
347 | # nothing to check for; disabling the check |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
348 | return |
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
349 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
350 | imports = set() |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
351 | node = None |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
352 | hasCode = False |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
353 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
354 | for node in ast.walk(self.__tree): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
355 | if (isinstance(node, ast.ImportFrom) and |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
356 | node.module == '__future__'): |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
357 | imports |= {name.name for name in node.names} |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
358 | elif isinstance(node, ast.Expr): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
359 | if not isinstance(node.value, ast.Str): |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
360 | hasCode = True |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
361 | break |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
362 | elif not isinstance(node, (ast.Module, ast.Str)): |
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
363 | hasCode = True |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
364 | break |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
365 | |
4540
45627d092846
Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4515
diff
changeset
|
366 | if isinstance(node, ast.Module) or not hasCode: |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
367 | return |
4508
a3b38825acf0
Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4507
diff
changeset
|
368 | |
4509
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
369 | if not (imports >= expectedImports): |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
370 | if imports: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
371 | self.__error(node.lineno - 1, node.col_offset, "M701", |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
372 | ", ".join(expectedImports), ", ".join(imports)) |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
373 | else: |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
374 | self.__error(node.lineno - 1, node.col_offset, "M702", |
7797ee4a45f9
Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4508
diff
changeset
|
375 | ", ".join(expectedImports)) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
376 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
377 | def __checkPep3101(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
378 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
379 | Private method to check for old style string formatting. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
380 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
381 | for lineno, line in enumerate(self.__source): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
382 | match = self.__pep3101FormatRegex.search(line) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
383 | if match: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
384 | lineLen = len(line) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
385 | pos = line.find('%') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
386 | formatPos = pos |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
387 | formatter = '%' |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
388 | if line[pos + 1] == "(": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
389 | pos = line.find(")", pos) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
390 | c = line[pos] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
391 | while c not in "diouxXeEfFgGcrs": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
392 | pos += 1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
393 | if pos >= lineLen: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
394 | break |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
395 | c = line[pos] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
396 | if c in "diouxXeEfFgGcrs": |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
397 | formatter += c |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
398 | self.__error(lineno, formatPos, "M601", formatter) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
399 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
400 | def __checkFormatString(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
401 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
402 | Private method to check string format strings. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
403 | """ |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
404 | coding = self.__getCoding()[1] |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
405 | if not coding: |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
406 | # default to utf-8 |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
407 | coding = "utf-8" |
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
408 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
409 | visitor = TextVisitor() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
410 | visitor.visit(self.__tree) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
411 | for node in visitor.nodes: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
412 | text = node.s |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
413 | if sys.version_info[0] > 2 and isinstance(text, bytes): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
414 | try: |
4515
d7cebe39ffba
Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4511
diff
changeset
|
415 | text = text.decode(coding) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
416 | except UnicodeDecodeError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
417 | continue |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
418 | fields, implicit, explicit = self.__getFields(text) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
419 | if implicit: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
420 | if node in visitor.calls: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
421 | self.__error(node.lineno - 1, node.col_offset, "M611") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
422 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
423 | if node.is_docstring: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
424 | self.__error(node.lineno - 1, node.col_offset, "M612") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
425 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
426 | self.__error(node.lineno - 1, node.col_offset, "M613") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
427 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
428 | if node in visitor.calls: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
429 | call, strArgs = visitor.calls[node] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
430 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
431 | numbers = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
432 | names = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
433 | # Determine which fields require a keyword and which an arg |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
434 | for name in fields: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
435 | fieldMatch = self.FormatFieldRegex.match(name) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
436 | try: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
437 | number = int(fieldMatch.group(1)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
438 | except ValueError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
439 | number = -1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
440 | # negative numbers are considered keywords |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
441 | if number >= 0: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
442 | numbers.add(number) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
443 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
444 | names.add(fieldMatch.group(1)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
445 | |
5588
6ba512d9f46a
Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5585
diff
changeset
|
446 | keywords = {keyword.arg for keyword in call.keywords} |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
447 | numArgs = len(call.args) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
448 | if strArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
449 | numArgs -= 1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
450 | if sys.version_info < (3, 5): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
451 | hasKwArgs = bool(call.kwargs) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
452 | hasStarArgs = bool(call.starargs) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
453 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
454 | hasKwArgs = any(kw.arg is None for kw in call.keywords) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
455 | hasStarArgs = sum(1 for arg in call.args |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
456 | if isinstance(arg, ast.Starred)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
457 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
458 | if hasKwArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
459 | keywords.discard(None) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
460 | if hasStarArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
461 | numArgs -= 1 |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
462 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
463 | # if starargs or kwargs is not None, it can't count the |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
464 | # parameters but at least check if the args are used |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
465 | if hasKwArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
466 | if not names: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
467 | # No names but kwargs |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
468 | self.__error(call.lineno - 1, call.col_offset, "M623") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
469 | if hasStarArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
470 | if not numbers: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
471 | # No numbers but args |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
472 | self.__error(call.lineno - 1, call.col_offset, "M624") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
473 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
474 | if not hasKwArgs and not hasStarArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
475 | # can actually verify numbers and names |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
476 | for number in sorted(numbers): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
477 | if number >= numArgs: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
478 | self.__error(call.lineno - 1, call.col_offset, |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
479 | "M621", number) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
480 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
481 | for name in sorted(names): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
482 | if name not in keywords: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
483 | self.__error(call.lineno - 1, call.col_offset, |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
484 | "M622", name) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
485 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
486 | for arg in range(numArgs): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
487 | if arg not in numbers: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
488 | self.__error(call.lineno - 1, call.col_offset, "M631", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
489 | arg) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
490 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
491 | for keyword in keywords: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
492 | if keyword not in names: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
493 | self.__error(call.lineno - 1, call.col_offset, "M632", |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
494 | keyword) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
495 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
496 | if implicit and explicit: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
497 | self.__error(call.lineno - 1, call.col_offset, "M625") |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
498 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
499 | def __getFields(self, string): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
500 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
501 | Private method to extract the format field information. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
502 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
503 | @param string format string to be parsed |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
504 | @type str |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
505 | @return format field information as a tuple with fields, implicit |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
506 | field definitions present and explicit field definitions present |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
507 | @rtype tuple of set of str, bool, bool |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
508 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
509 | fields = set() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
510 | cnt = itertools.count() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
511 | implicit = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
512 | explicit = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
513 | try: |
6188
5a6ae3be31e6
Fixed some loop related coding issues detected by the extended code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6184
diff
changeset
|
514 | for _literal, field, spec, conv in self.Formatter.parse(string): |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
515 | if field is not None and (conv is None or conv in 'rsa'): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
516 | if not field: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
517 | field = str(next(cnt)) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
518 | implicit = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
519 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
520 | explicit = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
521 | fields.add(field) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
522 | fields.update(parsedSpec[1] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
523 | for parsedSpec in self.Formatter.parse(spec) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
524 | if parsedSpec[1] is not None) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
525 | except ValueError: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
526 | return set(), False, False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
527 | else: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
528 | return fields, implicit, explicit |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
529 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
530 | def __checkBuiltins(self): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
531 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
532 | Private method to check, if built-ins are shadowed. |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
533 | """ |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
534 | functionDefs = [ast.FunctionDef] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
535 | try: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
536 | functionDefs.append(ast.AsyncFunctionDef) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
537 | except AttributeError: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
538 | pass |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
539 | |
5619
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
540 | ignoreBuiltinAssignments = self.__args.get( |
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
541 | "BuiltinsChecker", self.__defaultArgs["BuiltinsChecker"]) |
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
542 | |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
543 | for node in ast.walk(self.__tree): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
544 | if isinstance(node, ast.Assign): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
545 | # assign statement |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
546 | for element in node.targets: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
547 | if isinstance(element, ast.Name) and \ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
548 | element.id in self.__builtins: |
5617
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
549 | value = node.value |
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
550 | if isinstance(value, ast.Name) and \ |
5619
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
551 | element.id in ignoreBuiltinAssignments and \ |
ab999dc48132
Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5617
diff
changeset
|
552 | value.id in ignoreBuiltinAssignments[element.id]: |
5617
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
553 | # ignore compatibility assignments |
1b9e3d94864a
Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5589
diff
changeset
|
554 | continue |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
555 | self.__error(element.lineno - 1, element.col_offset, |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
556 | "M131", element.id) |
5589
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
557 | elif isinstance(element, (ast.Tuple, ast.List)): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
558 | for tupleElement in element.elts: |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
559 | if isinstance(tupleElement, ast.Name) and \ |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
560 | tupleElement.id in self.__builtins: |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
561 | self.__error(tupleElement.lineno - 1, |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
562 | tupleElement.col_offset, |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
563 | "M131", tupleElement.id) |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
564 | elif isinstance(node, ast.For): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
565 | # for loop |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
566 | target = node.target |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
567 | if isinstance(target, ast.Name) and \ |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
568 | target.id in self.__builtins: |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
569 | self.__error(target.lineno - 1, target.col_offset, |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
570 | "M131", target.id) |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
571 | elif isinstance(target, (ast.Tuple, ast.List)): |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
572 | for element in target.elts: |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
573 | if isinstance(element, ast.Name) and \ |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
574 | element.id in self.__builtins: |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
575 | self.__error(element.lineno - 1, |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
576 | element.col_offset, |
ad8f37c6a306
Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5588
diff
changeset
|
577 | "M131", element.id) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
578 | elif any(isinstance(node, functionDef) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
579 | for functionDef in functionDefs): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
580 | # (asynchronous) function definition |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
581 | if sys.version_info >= (3, 0): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
582 | for arg in node.args.args: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
583 | if isinstance(arg, ast.arg) and \ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
584 | arg.arg in self.__builtins: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
585 | self.__error(arg.lineno - 1, arg.col_offset, |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
586 | "M132", arg.arg) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
587 | else: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
588 | for arg in node.args.args: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
589 | if isinstance(arg, ast.Name) and \ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
590 | arg.id in self.__builtins: |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
591 | self.__error(arg.lineno - 1, arg.col_offset, |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
592 | "M132", arg.id) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
593 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
594 | def __checkComprehensions(self): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
595 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
596 | Private method to check some comprehension related things. |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
597 | """ |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
598 | for node in ast.walk(self.__tree): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
599 | if (isinstance(node, ast.Call) and |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
600 | len(node.args) == 1 and |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
601 | isinstance(node.func, ast.Name)): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
602 | if (isinstance(node.args[0], ast.GeneratorExp) and |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
603 | node.func.id in ('list', 'set', 'dict')): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
604 | errorCode = { |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
605 | "dict": "M193", |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
606 | "list": "M191", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
607 | "set": "M192", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
608 | }[node.func.id] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
609 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
610 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
611 | elif (isinstance(node.args[0], ast.ListComp) and |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
612 | node.func.id in ('set', 'dict')): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
613 | errorCode = { |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
614 | 'dict': 'M195', |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
615 | 'set': 'M194', |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
616 | }[node.func.id] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
617 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
618 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
619 | elif (isinstance(node.args[0], ast.List) and |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
620 | node.func.id in ('set', 'dict')): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
621 | errorCode = { |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
622 | 'dict': 'M197', |
5585
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
623 | 'set': 'M196', |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
624 | }[node.func.id] |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
625 | self.__error(node.lineno - 1, node.col_offset, errorCode) |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
626 | |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
627 | elif (isinstance(node.args[0], ast.ListComp) and |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
628 | node.func.id in ('all', 'any', 'frozenset', 'max', 'min', |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
629 | 'sorted', 'sum', 'tuple',)): |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
630 | self.__error(node.lineno - 1, node.col_offset, "M198", |
dab20c39f08c
Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5389
diff
changeset
|
631 | node.func.id) |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
632 | |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
633 | def __checkMutableDefault(self): |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
634 | """ |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
635 | Private method to check for use of mutable types as default arguments. |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
636 | """ |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
637 | mutableTypes = ( |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
638 | ast.Call, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
639 | ast.Dict, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
640 | ast.List, |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
641 | ast.Set, |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
642 | ) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
643 | mutableCalls = ( |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
644 | "Counter", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
645 | "OrderedDict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
646 | "collections.Counter", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
647 | "collections.OrderedDict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
648 | "collections.defaultdict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
649 | "collections.deque", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
650 | "defaultdict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
651 | "deque", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
652 | "dict", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
653 | "list", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
654 | "set", |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
655 | ) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
656 | functionDefs = [ast.FunctionDef] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
657 | try: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
658 | functionDefs.append(ast.AsyncFunctionDef) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
659 | except AttributeError: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
660 | pass |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
661 | |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
662 | for node in ast.walk(self.__tree): |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
663 | if any(isinstance(node, functionDef) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
664 | for functionDef in functionDefs): |
5621
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
665 | for default in node.args.defaults: |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
666 | if any(isinstance(default, mutableType) |
80cce672d505
Added a checker for using mutable types as default functiona rgument (M821).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5619
diff
changeset
|
667 | for mutableType in mutableTypes): |
5703
7650c11cc5f2
MiscChecker, ast: No special case for Python 2 needed.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
5649
diff
changeset
|
668 | typeName = type(default).__name__ |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
669 | if isinstance(default, ast.Call): |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
670 | callPath = '.'.join(composeCallPath(default.func)) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
671 | if callPath in mutableCalls: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
672 | self.__error(default.lineno - 1, |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
673 | default.col_offset, |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
674 | "M823", callPath + "()") |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
675 | else: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
676 | self.__error(default.lineno - 1, |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
677 | default.col_offset, |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
678 | "M822", typeName) |
5639
9ee960bceb51
Refined the "mutable default arguments" checker a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
5621
diff
changeset
|
679 | else: |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
680 | self.__error(default.lineno - 1, |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
681 | default.col_offset, |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
682 | "M821", typeName) |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
683 | |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
684 | def __dictShouldBeChecked(self, node): |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
685 | """ |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
686 | Private function to test, if the node should be checked. |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
687 | |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
688 | @param node reference to the AST node |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
689 | @return flag indicating to check the node |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
690 | @rtype bool |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
691 | """ |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
692 | if not all(isinstance(key, ast.Str) for key in node.keys): |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
693 | return False |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
694 | |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
695 | if "__IGNORE_WARNING__" in self.__source[node.lineno - 1] or \ |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
696 | "__IGNORE_WARNING_M201__" in self.__source[node.lineno - 1]: |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
697 | return False |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
698 | |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
699 | lineNumbers = [key.lineno for key in node.keys] |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
700 | return len(lineNumbers) == len(set(lineNumbers)) |
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
701 | |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
702 | def __checkDictWithSortedKeys(self): |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
703 | """ |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
704 | Private method to check, if dictionary keys appear in sorted order. |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
705 | """ |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
706 | for node in ast.walk(self.__tree): |
6178
905ea208884a
Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6177
diff
changeset
|
707 | if isinstance(node, ast.Dict) and self.__dictShouldBeChecked(node): |
6177
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
708 | for key1, key2 in zip(node.keys, node.keys[1:]): |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
709 | if key2.s < key1.s: |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
710 | self.__error(key2.lineno - 1, key2.col_offset, |
af76e795c4ce
Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6106
diff
changeset
|
711 | "M201", key2.s, key1.s) |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
712 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
713 | def __checkLogging(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
714 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
715 | Private method to check logging statements. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
716 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
717 | visitor = LoggingVisitor() |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
718 | visitor.visit(self.__tree) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
719 | for node, reason in visitor.violations: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
720 | self.__error(node.lineno - 1, node.col_offset, reason) |
6182
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
721 | |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
722 | def __checkGettext(self): |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
723 | """ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
724 | Private method to check the 'gettext' import statement. |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
725 | """ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
726 | for node in ast.walk(self.__tree): |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
727 | if isinstance(node, ast.ImportFrom) and \ |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
728 | any(name.asname == '_' for name in node.names): |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
729 | self.__error(node.lineno - 1, node.col_offset, "M711", |
f293e95b914d
Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6180
diff
changeset
|
730 | node.names[0].name) |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
731 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
732 | def __checkBugBear(self): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
733 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
734 | Private method to bugbear checks. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
735 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
736 | visitor = BugBearVisitor() |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
737 | visitor.visit(self.__tree) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
738 | for violation in visitor.violations: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
739 | node = violation[0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
740 | reason = violation[1] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
741 | params = violation[2:] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
742 | self.__error(node.lineno - 1, node.col_offset, reason, *params) |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
743 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
744 | def __checkReturn(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
745 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
746 | Private method to check return statements. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
747 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
748 | visitor = ReturnVisitor() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
749 | visitor.visit(self.__tree) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
750 | for violation in visitor.violations: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
751 | node = violation[0] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
752 | reason = violation[1] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
753 | self.__error(node.lineno - 1, node.col_offset, reason) |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
754 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
755 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
756 | class TextVisitor(ast.NodeVisitor): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
757 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
758 | Class implementing a node visitor for bytes and str instances. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
759 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
760 | It tries to detect docstrings as string of the first expression of each |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
761 | module, class or function. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
762 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
763 | # modelled after the string format flake8 extension |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
764 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
765 | def __init__(self): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
766 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
767 | Constructor |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
768 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
769 | super(TextVisitor, self).__init__() |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
770 | self.nodes = [] |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
771 | self.calls = {} |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
772 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
773 | def __addNode(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
774 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
775 | Private method to add a node to our list of nodes. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
776 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
777 | @param node reference to the node to add |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
778 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
779 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
780 | if not hasattr(node, 'is_docstring'): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
781 | node.is_docstring = False |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
782 | self.nodes.append(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
783 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
784 | def __isBaseString(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
785 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
786 | Private method to determine, if a node is a base string node. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
787 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
788 | @param node reference to the node to check |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
789 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
790 | @return flag indicating a base string |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
791 | @rtype bool |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
792 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
793 | typ = (ast.Str,) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
794 | if sys.version_info[0] > 2: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
795 | typ += (ast.Bytes,) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
796 | return isinstance(node, typ) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
797 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
798 | def visit_Str(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
799 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
800 | Public method to record a string node. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
801 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
802 | @param node reference to the string node |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
803 | @type ast.Str |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
804 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
805 | self.__addNode(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
806 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
807 | def visit_Bytes(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
808 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
809 | Public method to record a bytes node. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
810 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
811 | @param node reference to the bytes node |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
812 | @type ast.Bytes |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
813 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
814 | self.__addNode(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
815 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
816 | def __visitDefinition(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
817 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
818 | Private method handling class and function definitions. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
819 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
820 | @param node reference to the node to handle |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
821 | @type ast.FunctionDef, ast.AsyncFunctionDef or ast.ClassDef |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
822 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
823 | # Manually traverse class or function definition |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
824 | # * Handle decorators normally |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
825 | # * Use special check for body content |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
826 | # * Don't handle the rest (e.g. bases) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
827 | for decorator in node.decorator_list: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
828 | self.visit(decorator) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
829 | self.__visitBody(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
830 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
831 | def __visitBody(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
832 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
833 | Private method to traverse the body of the node manually. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
834 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
835 | If the first node is an expression which contains a string or bytes it |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
836 | marks that as a docstring. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
837 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
838 | @param node reference to the node to traverse |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
839 | @type ast.AST |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
840 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
841 | if (node.body and isinstance(node.body[0], ast.Expr) and |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
842 | self.__isBaseString(node.body[0].value)): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
843 | node.body[0].value.is_docstring = True |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
844 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
845 | for subnode in node.body: |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
846 | self.visit(subnode) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
847 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
848 | def visit_Module(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
849 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
850 | Public method to handle a module. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
851 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
852 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
853 | @type ast.Module |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
854 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
855 | self.__visitBody(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
856 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
857 | def visit_ClassDef(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
858 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
859 | Public method to handle a class definition. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
860 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
861 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
862 | @type ast.ClassDef |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
863 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
864 | # Skipped nodes: ('name', 'bases', 'keywords', 'starargs', 'kwargs') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
865 | self.__visitDefinition(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
866 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
867 | def visit_FunctionDef(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
868 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
869 | Public method to handle a function definition. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
870 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
871 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
872 | @type ast.FunctionDef |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
873 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
874 | # Skipped nodes: ('name', 'args', 'returns') |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
875 | self.__visitDefinition(node) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
876 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
877 | def visit_AsyncFunctionDef(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
878 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
879 | Public method to handle an asynchronous function definition. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
880 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
881 | @param node reference to the node to handle |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
882 | @type ast.AsyncFunctionDef |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
883 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
884 | # Skipped nodes: ('name', 'args', 'returns') |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
885 | self.__visitDefinition(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
886 | |
4511
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
887 | def visit_Call(self, node): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
888 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
889 | Public method to handle a function call. |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
890 | |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
891 | @param node reference to the node to handle |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
892 | @type ast.Call |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
893 | """ |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
894 | if (isinstance(node.func, ast.Attribute) and |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
895 | node.func.attr == 'format'): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
896 | if self.__isBaseString(node.func.value): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
897 | self.calls[node.func.value] = (node, False) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
898 | elif (isinstance(node.func.value, ast.Name) and |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
899 | node.func.value.id == 'str' and node.args and |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
900 | self.__isBaseString(node.args[0])): |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
901 | self.calls[node.args[0]] = (node, True) |
b5e4e7efa904
Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
4510
diff
changeset
|
902 | super(TextVisitor, self).generic_visit(node) |
4555
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
903 | |
6180
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
904 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
905 | class LoggingVisitor(ast.NodeVisitor): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
906 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
907 | Class implementing a node visitor to check logging statements. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
908 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
909 | LoggingLevels = { |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
910 | "debug", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
911 | "critical", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
912 | "error", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
913 | "info", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
914 | "warn", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
915 | "warning", |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
916 | } |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
917 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
918 | def __init__(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
919 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
920 | Constructor |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
921 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
922 | super(LoggingVisitor, self).__init__() |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
923 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
924 | self.__currentLoggingCall = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
925 | self.__currentLoggingArgument = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
926 | self.__currentLoggingLevel = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
927 | self.__currentExtraKeyword = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
928 | self.violations = [] |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
929 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
930 | def __withinLoggingStatement(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
931 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
932 | Private method to check, if we are inside a logging statement. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
933 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
934 | @return flag indicating we are inside a logging statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
935 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
936 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
937 | return self.__currentLoggingCall is not None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
938 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
939 | def __withinLoggingArgument(self): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
940 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
941 | Private method to check, if we are inside a logging argument. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
942 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
943 | @return flag indicating we are inside a logging argument |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
944 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
945 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
946 | return self.__currentLoggingArgument is not None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
947 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
948 | def __withinExtraKeyword(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
949 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
950 | Private method to check, if we are inside the extra keyword. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
951 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
952 | @param node reference to the node to be checked |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
953 | @type ast.keyword |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
954 | @return flag indicating we are inside the extra keyword |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
955 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
956 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
957 | return self.__currentExtraKeyword is not None and \ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
958 | self.__currentExtraKeyword != node |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
959 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
960 | def __detectLoggingLevel(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
961 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
962 | Private method to decide whether an AST Call is a logging call. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
963 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
964 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
965 | @type ast.Call |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
966 | @return logging level |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
967 | @rtype str or None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
968 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
969 | try: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
970 | if node.func.value.id == "warnings": |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
971 | return None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
972 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
973 | if node.func.attr in LoggingVisitor.LoggingLevels: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
974 | return node.func.attr |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
975 | except AttributeError: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
976 | pass |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
977 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
978 | return None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
979 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
980 | def __isFormatCall(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
981 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
982 | Private method to check if a function call uses format. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
983 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
984 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
985 | @type ast.Call |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
986 | @return flag indicating the function call uses format |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
987 | @rtype bool |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
988 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
989 | try: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
990 | return node.func.attr == "format" |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
991 | except AttributeError: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
992 | return False |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
993 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
994 | def visit_Call(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
995 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
996 | Public method to handle a function call. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
997 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
998 | Every logging statement and string format is expected to be a function |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
999 | call. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1000 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1001 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1002 | @type ast.Call |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1003 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1004 | # we are in a logging statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1005 | if self.__withinLoggingStatement(): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1006 | if self.__withinLoggingArgument() and self.__isFormatCall(node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1007 | self.violations.append((node, "M651")) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1008 | super(LoggingVisitor, self).generic_visit(node) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1009 | return |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1010 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1011 | loggingLevel = self.__detectLoggingLevel(node) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1012 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1013 | if loggingLevel and self.__currentLoggingLevel is None: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1014 | self.__currentLoggingLevel = loggingLevel |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1015 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1016 | # we are in some other statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1017 | if loggingLevel is None: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1018 | super(LoggingVisitor, self).generic_visit(node) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1019 | return |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1020 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1021 | # we are entering a new logging statement |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1022 | self.__currentLoggingCall = node |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1023 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1024 | if loggingLevel == "warn": |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1025 | self.violations.append((node, "M655")) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1026 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1027 | for index, child in enumerate(ast.iter_child_nodes(node)): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1028 | if index == 1: |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1029 | self.__currentLoggingArgument = child |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1030 | if index > 1 and isinstance(child, ast.keyword) and \ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1031 | child.arg == "extra": |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1032 | self.__currentExtraKeyword = child |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1033 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1034 | super(LoggingVisitor, self).visit(child) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1035 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1036 | self.__currentLoggingArgument = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1037 | self.__currentExtraKeyword = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1038 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1039 | self.__currentLoggingCall = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1040 | self.__currentLoggingLevel = None |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1041 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1042 | def visit_BinOp(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1043 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1044 | Public method to handle binary operations while processing the first |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1045 | logging argument. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1046 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1047 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1048 | @type ast.BinOp |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1049 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1050 | if self.__withinLoggingStatement() and self.__withinLoggingArgument(): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1051 | # handle percent format |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1052 | if isinstance(node.op, ast.Mod): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1053 | self.violations.append((node, "M652")) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1054 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1055 | # handle string concat |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1056 | if isinstance(node.op, ast.Add): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1057 | self.violations.append((node, "M653")) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1058 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1059 | super(LoggingVisitor, self).generic_visit(node) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1060 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1061 | def visit_JoinedStr(self, node): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1062 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1063 | Public method to handle f-string arguments. |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1064 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1065 | @param node reference to the node to be processed |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1066 | @type ast.JoinedStr |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1067 | """ |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1068 | if sys.version_info >= (3, 6): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1069 | if self.__withinLoggingStatement(): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1070 | if any(isinstance(i, ast.FormattedValue) for i in node.values): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1071 | if self.__withinLoggingArgument(): |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1072 | self.violations.append((node, "M654")) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1073 | |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1074 | super(LoggingVisitor, self).generic_visit(node) |
8d72871c16ba
Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6178
diff
changeset
|
1075 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1076 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1077 | class BugBearVisitor(ast.NodeVisitor): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1078 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1079 | Class implementing a node visitor to check for various topics. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1080 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1081 | # |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1082 | # This class was implemented along the BugBear flake8 extension (v 18.2.0). |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1083 | # Original: Copyright (c) 2016 Łukasz Langa |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1084 | # |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1085 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1086 | NodeWindowSize = 4 |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1087 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1088 | def __init__(self): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1089 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1090 | Constructor |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1091 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1092 | super(BugBearVisitor, self).__init__() |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1093 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1094 | self.__nodeStack = [] |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1095 | self.__nodeWindow = [] |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1096 | self.violations = [] |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1097 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1098 | def visit(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1099 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1100 | Public method to traverse a given AST node. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1101 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1102 | @param node AST node to be traversed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1103 | @type ast.Node |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1104 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1105 | self.__nodeStack.append(node) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1106 | self.__nodeWindow.append(node) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1107 | self.__nodeWindow = \ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1108 | self.__nodeWindow[-BugBearVisitor.NodeWindowSize:] |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1109 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1110 | super(BugBearVisitor, self).visit(node) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1111 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1112 | self.__nodeStack.pop() |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1113 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1114 | def visit_UAdd(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1115 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1116 | Public method to handle unary additions. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1117 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1118 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1119 | @type ast.UAdd |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1120 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1121 | trailingNodes = list(map(type, self.__nodeWindow[-4:])) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1122 | if trailingNodes == [ast.UnaryOp, ast.UAdd, ast.UnaryOp, ast.UAdd]: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1123 | originator = self.__nodeWindow[-4] |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1124 | self.violations.append((originator, "M501")) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1125 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1126 | self.generic_visit(node) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1127 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1128 | def visit_Call(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1129 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1130 | Public method to handle a function call. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1131 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1132 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1133 | @type ast.Call |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1134 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1135 | if sys.version_info >= (3, 0): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1136 | validPaths = ("six", "future.utils", "builtins") |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1137 | methodsDict = { |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1138 | "M511": ("iterkeys", "itervalues", "iteritems", "iterlists"), |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1139 | "M512": ("viewkeys", "viewvalues", "viewitems", "viewlists"), |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1140 | "M513": ("next",), |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1141 | } |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1142 | else: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1143 | validPaths = () |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1144 | methodsDict = {} |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1145 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1146 | if isinstance(node.func, ast.Attribute): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1147 | for code, methods in methodsDict.items(): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1148 | if node.func.attr in methods: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1149 | callPath = ".".join(composeCallPath(node.func.value)) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1150 | if callPath not in validPaths: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1151 | self.violations.append((node, code)) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1152 | break |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1153 | else: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1154 | self.__checkForM502(node) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1155 | else: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1156 | try: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1157 | if ( |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1158 | node.func.id in ("getattr", "hasattr") and |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1159 | node.args[1].s == "__call__" |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1160 | ): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1161 | self.violations.append((node, "M503")) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1162 | except (AttributeError, IndexError): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1163 | pass |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1164 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1165 | self.generic_visit(node) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1166 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1167 | def visit_Attribute(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1168 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1169 | Public method to handle attributes. |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1170 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1171 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1172 | @type ast.Attribute |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1173 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1174 | callPath = list(composeCallPath(node)) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1175 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1176 | if '.'.join(callPath) == 'sys.maxint' and sys.version_info >= (3, 0): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1177 | self.violations.append((node, "M504")) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1178 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1179 | elif len(callPath) == 2 and callPath[1] == 'message' and \ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1180 | sys.version_info >= (2, 6): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1181 | name = callPath[0] |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1182 | for elem in reversed(self.__nodeStack[:-1]): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1183 | if isinstance(elem, ast.ExceptHandler) and elem.name == name: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1184 | self.violations.append((node, "M505")) |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1185 | break |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1186 | |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1187 | def visit_Assign(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1188 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1189 | Public method to handle assignments. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1190 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1191 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1192 | @type ast.Assign |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1193 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1194 | if isinstance(self.__nodeStack[-2], ast.ClassDef): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1195 | # By using 'hasattr' below we're ignoring starred arguments, slices |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1196 | # and tuples for simplicity. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1197 | assignTargets = {t.id for t in node.targets if hasattr(t, 'id')} |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1198 | if '__metaclass__' in assignTargets and sys.version_info >= (3, 0): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1199 | self.violations.append((node, "M514")) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1200 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1201 | elif len(node.targets) == 1: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1202 | target = node.targets[0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1203 | if isinstance(target, ast.Attribute) and \ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1204 | isinstance(target.value, ast.Name): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1205 | if (target.value.id, target.attr) == ('os', 'environ'): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1206 | self.violations.append((node, "M506")) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1207 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1208 | self.generic_visit(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1209 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1210 | def visit_For(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1211 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1212 | Public method to handle 'for' statements. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1213 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1214 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1215 | @type ast.For |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1216 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1217 | self.__checkForM507(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1218 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1219 | self.generic_visit(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1220 | |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1221 | def __checkForM502(self, node): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1222 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1223 | Private method to check the use of *strip(). |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1224 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1225 | @param node reference to the node to be processed |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1226 | @type ast.Call |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1227 | """ |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1228 | if node.func.attr not in ("lstrip", "rstrip", "strip"): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1229 | return # method name doesn't match |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1230 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1231 | if len(node.args) != 1 or not isinstance(node.args[0], ast.Str): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1232 | return # used arguments don't match the builtin strip |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1233 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1234 | s = node.args[0].s |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1235 | if len(s) == 1: |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1236 | return # stripping just one character |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1237 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1238 | if len(s) == len(set(s)): |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1239 | return # no characters appear more than once |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1240 | |
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1241 | self.violations.append((node, "M502")) |
6184
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1242 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1243 | def __checkForM507(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1244 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1245 | Private method to check for unused loop variables. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1246 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1247 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1248 | @type ast.For |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1249 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1250 | targets = NameFinder() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1251 | targets.visit(node.target) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1252 | ctrlNames = set(filter(lambda s: not s.startswith('_'), |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1253 | targets.getNames())) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1254 | body = NameFinder() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1255 | for expr in node.body: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1256 | body.visit(expr) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1257 | usedNames = set(body.getNames()) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1258 | for name in sorted(ctrlNames - usedNames): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1259 | n = targets.getNames()[name][0] |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1260 | self.violations.append((n, "M507", name)) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1261 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1262 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1263 | class NameFinder(ast.NodeVisitor): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1264 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1265 | Class to extract a name out of a tree of nodes. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1266 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1267 | def __init__(self): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1268 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1269 | Constructor |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1270 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1271 | super(NameFinder, self).__init__() |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1272 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1273 | self.__names = {} |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1274 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1275 | def visit_Name(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1276 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1277 | Public method to handle 'Name' nodes. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1278 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1279 | @param node reference to the node to be processed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1280 | @type ast.Name |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1281 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1282 | self.__names.setdefault(node.id, []).append(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1283 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1284 | def visit(self, node): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1285 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1286 | Public method to traverse a given AST node. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1287 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1288 | @param node AST node to be traversed |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1289 | @type ast.Node |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1290 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1291 | if isinstance(node, list): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1292 | for elem in node: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1293 | super(NameFinder, self).visit(elem) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1294 | else: |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1295 | super(NameFinder, self).visit(node) |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1296 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1297 | def getNames(self): |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1298 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1299 | Public method to return the extracted names and Name nodes. |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1300 | |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1301 | @return dictionary containing the names as keys and the list of nodes |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1302 | @rtype dict |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1303 | """ |
789e88d94899
Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6183
diff
changeset
|
1304 | return self.__names |
6183
29384109306c
Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6182
diff
changeset
|
1305 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1306 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1307 | class ReturnVisitor(ast.NodeVisitor): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1308 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1309 | Class implementing a node visitor to check return statements. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1310 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1311 | Assigns = 'assigns' |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1312 | Refs = 'refs' |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1313 | Returns = 'returns' |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1314 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1315 | def __init__(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1316 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1317 | Constructor |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1318 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1319 | super(ReturnVisitor, self).__init__() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1320 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1321 | self.__stack = [] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1322 | self.violations = [] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1323 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1324 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1325 | def assigns(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1326 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1327 | Public method to get the Assign nodes. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1328 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1329 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1330 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1331 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1332 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1333 | return self.__stack[-1][ReturnVisitor.Assigns] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1334 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1335 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1336 | def refs(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1337 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1338 | Public method to get the References nodes. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1339 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1340 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1341 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1342 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1343 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1344 | return self.__stack[-1][ReturnVisitor.Refs] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1345 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1346 | @property |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1347 | def returns(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1348 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1349 | Public method to get the Return nodes. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1350 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1351 | @return dictionary containing the node name as key and line number |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1352 | as value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1353 | @rtype dict |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1354 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1355 | return self.__stack[-1][ReturnVisitor.Returns] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1356 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1357 | def __visitWithStack(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1358 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1359 | Private method to traverse a given function node using a stack. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1360 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1361 | @param node AST node to be traversed |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1362 | @type ast.FunctionDef or ast.AsyncFunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1363 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1364 | self.__stack.append({ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1365 | ReturnVisitor.Assigns: defaultdict(list), |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1366 | ReturnVisitor.Refs: defaultdict(list), |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1367 | ReturnVisitor.Returns: [] |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1368 | }) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1369 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1370 | self.generic_visit(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1371 | self.__checkFunction(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1372 | self.__stack.pop() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1373 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1374 | def visit_FunctionDef(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1375 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1376 | Public method to handle a function definition. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1377 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1378 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1379 | @type ast.FunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1380 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1381 | self.__visitWithStack(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1382 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1383 | def visit_AsyncFunctionDef(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1384 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1385 | Public method to handle a function definition. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1386 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1387 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1388 | @type ast.AsyncFunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1389 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1390 | self.__visitWithStack(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1391 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1392 | def visit_Return(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1393 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1394 | Public method to handle a return node. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1395 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1396 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1397 | @type ast.Return |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1398 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1399 | self.returns.append(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1400 | self.generic_visit(node) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1401 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1402 | def visit_Assign(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1403 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1404 | Public method to handle an assign node. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1405 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1406 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1407 | @type ast.Assign |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1408 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1409 | if not self.__stack: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1410 | return |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1411 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1412 | for target in node.targets: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1413 | self.__visitAssignTarget(target) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1414 | self.generic_visit(node.value) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1415 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1416 | def visit_Name(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1417 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1418 | Public method to handle a name node. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1419 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1420 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1421 | @type ast.Name |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1422 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1423 | if self.__stack: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1424 | self.refs[node.id].append(node.lineno) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1425 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1426 | def __visitAssignTarget(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1427 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1428 | Private method to handle an assign target node. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1429 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1430 | @param node reference to the node to handle |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1431 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1432 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1433 | if isinstance(node, ast.Tuple): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1434 | for elt in node.elts: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1435 | self.__visitAssignTarget(elt) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1436 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1437 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1438 | if isinstance(node, ast.Name): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1439 | self.assigns[node.id].append(node.lineno) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1440 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1441 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1442 | self.generic_visit(node) |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1443 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1444 | def __checkFunction(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1445 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1446 | Private method to check a function definition node. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1447 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1448 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1449 | @type ast.AsyncFunctionDef or ast.FunctionDef |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1450 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1451 | if not self.returns or not node.body: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1452 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1453 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1454 | if len(node.body) == 1 and isinstance(node.body[-1], ast.Return): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1455 | # skip functions that consist of `return None` only |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1456 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1457 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1458 | if not self.__resultExists(): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1459 | self.__checkUnnecessaryReturnNone() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1460 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1461 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1462 | self.__checkImplicitReturnValue() |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1463 | self.__checkImplicitReturn(node.body[-1]) |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1464 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1465 | for n in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1466 | if n.value: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1467 | self.__checkUnnecessaryAssign(n.value) |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1468 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1469 | def __isNone(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1470 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1471 | Private method to check, if a node value is None. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1472 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1473 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1474 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1475 | @return flag indicating the node contains a None value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1476 | """ |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1477 | try: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1478 | return isinstance(node, ast.NameConstant) and node.value is None |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1479 | except AttributeError: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1480 | # try Py2 |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1481 | return isinstance(node, ast.Name) and node.id == "None" |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1482 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1483 | def __resultExists(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1484 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1485 | Private method to check the existance of a return result. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1486 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1487 | @return flag indicating the existence of a return result |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1488 | @rtype bool |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1489 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1490 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1491 | value = node.value |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1492 | if value and not self.__isNone(value): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1493 | return True |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1494 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1495 | return False |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1496 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1497 | def __checkImplicitReturnValue(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1498 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1499 | Private method to check for implicit return values. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1500 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1501 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1502 | if not node.value: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1503 | self.violations.append((node, "M832")) |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1504 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1505 | def __checkUnnecessaryReturnNone(self): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1506 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1507 | Private method to check for an unnecessary 'return None' statement. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1508 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1509 | for node in self.returns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1510 | if self.__isNone(node.value): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1511 | self.violations.append((node, "M831")) |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1512 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1513 | def __checkImplicitReturn(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1514 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1515 | Private method to check for an implicit return statement. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1516 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1517 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1518 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1519 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1520 | if isinstance(node, ast.If): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1521 | if not node.body or not node.orelse: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1522 | self.violations.append((node, "M833")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1523 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1524 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1525 | self.__checkImplicitReturn(node.body[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1526 | self.__checkImplicitReturn(node.orelse[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1527 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1528 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1529 | if isinstance(node, ast.For) and node.orelse: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1530 | self.__checkImplicitReturn(node.orelse[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1531 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1532 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1533 | if isinstance(node, ast.With): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1534 | self.__checkImplicitReturn(node.body[-1]) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1535 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1536 | |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1537 | try: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1538 | okNodes = (ast.Return, ast.Raise, ast.While, ast.Try) |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1539 | except AttributeError: |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1540 | # Py2 |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1541 | okNodes = (ast.Return, ast.Raise, ast.While) |
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1542 | if not isinstance(node, okNodes): |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1543 | self.violations.append((node, "M833")) |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1544 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1545 | def __checkUnnecessaryAssign(self, node): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1546 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1547 | Private method to check for an unnecessary assign statement. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1548 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1549 | @param node reference to the node to check |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1550 | @type ast.AST |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1551 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1552 | if not isinstance(node, ast.Name): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1553 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1554 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1555 | varname = node.id |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1556 | returnLineno = node.lineno |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1557 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1558 | if varname not in self.assigns: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1559 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1560 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1561 | if varname not in self.refs: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1562 | self.violations.append((node, "M834")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1563 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1564 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1565 | if self.__hasRefsBeforeNextAssign(varname, returnLineno): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1566 | return |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1567 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1568 | self.violations.append((node, "M834")) |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1569 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1570 | def __hasRefsBeforeNextAssign(self, varname, returnLineno): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1571 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1572 | Private method to check for references before a following assign |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1573 | statement. |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1574 | |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1575 | @param varname variable name to check for |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1576 | @type str |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1577 | @param returnLineno line number of the return statement |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1578 | @type int |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1579 | @return flag indicating the existence of references |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1580 | @rtype bool |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1581 | """ |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1582 | beforeAssign = 0 |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1583 | afterAssign = None |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1584 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1585 | for lineno in sorted(self.assigns[varname]): |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1586 | if lineno > returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1587 | afterAssign = lineno |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1588 | break |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1589 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1590 | if lineno <= returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1591 | beforeAssign = lineno |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1592 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1593 | for lineno in self.refs[varname]: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1594 | if lineno == returnLineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1595 | continue |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1596 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1597 | if afterAssign: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1598 | if beforeAssign < lineno <= afterAssign: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1599 | return True |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1600 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1601 | elif beforeAssign < lineno: |
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1602 | return True |
6889
334257ef9435
MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6882
diff
changeset
|
1603 | |
6882
65d1bf4b7427
MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
6645
diff
changeset
|
1604 | return False |
4555
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
1605 | # |
861e1741985c
Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents:
4540
diff
changeset
|
1606 | # eflag: noqa = M702 |