src/eric7/Plugins/CheckerPlugins/CodeStyleChecker/Unused/UnusedChecker.py

Wed, 19 Feb 2025 15:09:52 +0100

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Wed, 19 Feb 2025 15:09:52 +0100
branch
eric7
changeset 11142
2f0fb22c1d63
parent 11090
f5f5f5803935
child 11145
d328a7b74fd8
permissions
-rw-r--r--

Fixed a few issues in the code style checker.

10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
1 # -*- coding: utf-8 -*-
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
2
11090
f5f5f5803935 Updated copyright for 2025.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3 # Copyright (c) 2023 - 2025 Detlev Offenbach <detlev@die-offenbachs.de>
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
4 #
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
5
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
6 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
7 Module implementing a checker for unused arguments, variables, ... .
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
8 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
9
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
10 import ast
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
11 import collections
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
12 import copy
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
13
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
14 import AstUtilities
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
15
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
16
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
17 class UnusedChecker:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
18 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
19 Class implementing a checker for unused arguments, variables, ... .
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
20 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
21
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
22 Codes = [
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
23 ## Unused Arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
24 "U100",
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
25 "U101",
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
26 ## Unused Globals
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
27 "U200",
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
28 ]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
29
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
30 def __init__(self, source, filename, tree, select, ignore, expected, repeat, args):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
31 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
32 Constructor
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
33
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
34 @param source source code to be checked
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
35 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
36 @param filename name of the source file
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
37 @type str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
38 @param tree AST tree of the source code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
39 @type ast.Module
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
40 @param select list of selected codes
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
41 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
42 @param ignore list of codes to be ignored
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
43 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
44 @param expected list of expected codes
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
45 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
46 @param repeat flag indicating to report each occurrence of a code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
47 @type bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
48 @param args dictionary of arguments for the various checks
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
49 @type dict
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
50 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
51 self.__select = tuple(select)
11142
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
52 self.__ignore = tuple(ignore)
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
53 self.__expected = expected[:]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
54 self.__repeat = repeat
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
55 self.__filename = filename
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
56 self.__source = source[:]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
57 self.__tree = copy.deepcopy(tree)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
58 self.__args = args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
59
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
60 # statistics counters
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
61 self.counters = {}
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
62
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
63 # collection of detected errors
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
64 self.errors = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
65
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
66 checkersWithCodes = [
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
67 (self.__checkUnusedArguments, ("U100", "U101")),
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
68 (self.__checkUnusedGlobals, ("U200",)),
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
69 ]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
70
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
71 self.__checkers = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
72 for checker, codes in checkersWithCodes:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
73 if any(not (code and self.__ignoreCode(code)) for code in codes):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
74 self.__checkers.append(checker)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
75
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
76 def __ignoreCode(self, code):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
77 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
78 Private method to check if the message code should be ignored.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
79
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
80 @param code message code to check for
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
81 @type str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
82 @return flag indicating to ignore the given code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
83 @rtype bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
84 """
11142
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
85 return (
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
86 code in self.__ignore
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
87 or (code.startswith(self.__ignore) and not code.startswith(self.__select))
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
88 )
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
89
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
90 def __error(self, lineNumber, offset, code, *args):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
91 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
92 Private method to record an issue.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
93
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
94 @param lineNumber line number of the issue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
95 @type int
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
96 @param offset position within line of the issue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
97 @type int
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
98 @param code message code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
99 @type str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
100 @param args arguments for the message
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
101 @type list
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
102 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
103 if self.__ignoreCode(code):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
104 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
105
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
106 if code in self.counters:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
107 self.counters[code] += 1
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
108 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
109 self.counters[code] = 1
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
110
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
111 # Don't care about expected codes
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
112 if code in self.__expected:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
113 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
114
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
115 if code and (self.counters[code] == 1 or self.__repeat):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
116 # record the issue with one based line number
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
117 self.errors.append(
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
118 {
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
119 "file": self.__filename,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
120 "line": lineNumber + 1,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
121 "offset": offset,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
122 "code": code,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
123 "args": args,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
124 }
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
125 )
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
126
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
127 def run(self):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
128 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
129 Public method to check the given source against miscellaneous
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
130 conditions.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
131 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
132 if not self.__filename:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
133 # don't do anything, if essential data is missing
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
134 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
135
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
136 if not self.__checkers:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
137 # don't do anything, if no codes were selected
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
138 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
139
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
140 for check in self.__checkers:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
141 check()
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
142
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
143 #######################################################################
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
144 ## Unused Arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
145 ##
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
146 ## adapted from: flake8-unused-arguments v0.0.13
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
147 #######################################################################
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
148
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
149 def __checkUnusedArguments(self):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
150 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
151 Private method to check function and method definitions for unused arguments.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
152 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
153 finder = FunctionFinder(self.__args["IgnoreNestedFunctions"])
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
154 finder.visit(self.__tree)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
155
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
156 for functionNode in finder.functionNodes():
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
157 decoratorNames = set(self.__getDecoratorNames(functionNode))
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
158
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
159 # ignore overload functions, it's not a surprise when they're empty
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
160 if self.__args["IgnoreOverload"] and "overload" in decoratorNames:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
161 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
162
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
163 # ignore overridden functions
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
164 if self.__args["IgnoreOverride"] and "override" in decoratorNames:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
165 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
166
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
167 # ignore abstractmethods, it's not a surprise when they're empty
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
168 if self.__args["IgnoreAbstract"] and "abstractmethod" in decoratorNames:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
169 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
170
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
171 # ignore Qt slot methods
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
172 if self.__args["IgnoreSlotMethods"] and (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
173 "pyqtSlot" in decoratorNames or "Slot" in decoratorNames
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
174 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
175 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
176
10066
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
177 if self.__args["IgnoreEventHandlerMethods"] and self.__isEventHandlerMethod(
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
178 functionNode
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
179 ):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
180 continue
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
181
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
182 # ignore stub functions
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
183 if self.__args["IgnoreStubs"] and self.__isStubFunction(functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
184 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
185
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
186 # ignore lambdas
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
187 if self.__args["IgnoreLambdas"] and isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
188 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
189
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
190 # ignore __double_underscore_methods__()
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
191 if self.__args["IgnoreDunderMethods"] and self.__isDunderMethod(
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
192 functionNode
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
193 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
194 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
195
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
196 for i, argument in self.__getUnusedArguments(functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
197 name = argument.arg
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
198 if self.__args["IgnoreVariadicNames"]:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
199 if (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
200 functionNode.args.vararg
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
201 and functionNode.args.vararg.arg == name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
202 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
203 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
204 if functionNode.args.kwarg and functionNode.args.kwarg.arg == name:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
205 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
206
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
207 # ignore self or whatever the first argument is for a classmethod
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
208 if i == 0 and (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
209 name in ("self", "cls") or "classmethod" in decoratorNames
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
210 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
211 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
212
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
213 lineNumber = argument.lineno
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
214 offset = argument.col_offset
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
215
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
216 errorCode = "U101" if name.startswith("_") else "U100"
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
217 self.__error(lineNumber - 1, offset, errorCode, name)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
218
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
219 def __getDecoratorNames(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
220 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
221 Private method to yield the decorator names of the function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
222
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
223 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
224 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
225 @yield decorator name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
226 @ytype str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
227 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
228 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
229 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
230
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
231 for decorator in functionNode.decorator_list:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
232 if isinstance(decorator, ast.Name):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
233 yield decorator.id
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
234 elif isinstance(decorator, ast.Attribute):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
235 yield decorator.attr
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
236 elif isinstance(decorator, ast.Call):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
237 if isinstance(decorator.func, ast.Name):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
238 yield decorator.func.id
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
239 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
240 yield decorator.func.attr
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
241
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
242 def __isStubFunction(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
243 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
244 Private method to check, if the given function node defines a stub function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
245
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
246 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
247 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
248 @return flag indicating a stub function
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
249 @rtype bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
250 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
251 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
252 return AstUtilities.isEllipsis(functionNode.body)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
253
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
254 statement = functionNode.body[0]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
255 if isinstance(statement, ast.Expr) and AstUtilities.isString(statement.value):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
256 if len(functionNode.body) > 1:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
257 # first statement is a docstring, let's skip it
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
258 statement = functionNode.body[1]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
259 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
260 # it's a function with only a docstring, that's a stub
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
261 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
262
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
263 if isinstance(statement, ast.Pass):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
264 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
265 if isinstance(statement, ast.Expr) and AstUtilities.isEllipsis(statement.value):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
266 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
267
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
268 if isinstance(statement, ast.Raise):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
269 # like 'raise NotImplementedError()'
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
270 if (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
271 isinstance(statement.exc, ast.Call)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
272 and hasattr(statement.exc.func, "id")
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
273 and statement.exc.func.id == "NotImplementedError"
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
274 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
275 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
276
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
277 # like 'raise NotImplementedError'
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
278 elif (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
279 isinstance(statement.exc, ast.Name)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
280 and hasattr(statement.exc, "id")
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
281 and statement.exc.id == "NotImplementedError"
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
282 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
283 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
284
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
285 return False
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
286
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
287 def __isDunderMethod(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
288 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
289 Private method to check, if the function node defines a special function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
290
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
291 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
292 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
293 @return flag indicating a special function
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
294 @rtype bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
295 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
296 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
297 return False
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
298
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
299 if not hasattr(functionNode, "name"):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
300 return False
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
301
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
302 name = functionNode.name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
303 return len(name) > 4 and name.startswith("__") and name.endswith("__")
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
304
10066
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
305 def __isEventHandlerMethod(self, functionNode):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
306 """
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
307 Private method to check, if the function node defines a Qt event handler.
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
308
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
309 Qt event handler methods are assumed to end with 'Event' or have the name
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
310 'event' or 'eventFilter'. Only standard methodes (i.e. ast.FunctionDef)
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
311 are assumed to be potential event handlers.
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
312
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
313 @param functionNode reference to the node defining the function or lambda
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
314 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
315 @return flag indicating a Qt event handler method
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
316 @rtype bool
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
317 """
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
318 if isinstance(functionNode, (ast.Lambda, ast.AsyncFunctionDef)):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
319 return False
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
320
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
321 if not hasattr(functionNode, "name"):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
322 return False
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
323
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
324 name = functionNode.name
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
325 return name.endswith("Event") or name in ("event", "eventFilter")
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
326
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
327 def __getUnusedArguments(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
328 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
329 Private method to get a list of unused arguments of the given function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
330
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
331 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
332 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
333 @return list of tuples of the argument position and the argument
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
334 @rtype list of tuples of (int, ast.arg)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
335 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
336 arguments = list(enumerate(self.__getArguments(functionNode)))
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
337
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
338 class NameFinder(ast.NodeVisitor):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
339 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
340 Class to find the used argument names.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
341 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
342
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
343 def visit_Name(self, name):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
344 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
345 Public method to check a Name node.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
346
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
347 @param name reference to the name node to be checked
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
348 @type ast.Name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
349 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
350 nonlocal arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
351
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
352 if isinstance(name.ctx, ast.Store):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
353 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
354
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
355 arguments = [
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
356 (argIndex, arg) for argIndex, arg in arguments if arg.arg != name.id
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
357 ]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
358
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
359 NameFinder().visit(functionNode)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
360 return arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
361
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
362 def __getArguments(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
363 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
364 Private method to get all argument names of the given function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
365
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
366 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
367 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
368 @return list of argument names
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
369 @rtype list of ast.arg
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
370 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
371 args = functionNode.args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
372
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
373 orderedArguments = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
374
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
375 # plain old args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
376 orderedArguments.extend(args.args)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
377
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
378 # *arg name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
379 if args.vararg is not None:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
380 orderedArguments.append(args.vararg)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
381
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
382 # *, key, word, only, args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
383 orderedArguments.extend(args.kwonlyargs)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
384
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
385 # **kwarg name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
386 if args.kwarg is not None:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
387 orderedArguments.append(args.kwarg)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
388
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
389 return orderedArguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
390
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
391 #######################################################################
10056
ac1c214e0a05 Corrected some comments.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10054
diff changeset
392 ## Unused Globals
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
393 ##
10185
29e896e9e74e Updated some codestyle checkers for imports and too complex annotations.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10127
diff changeset
394 ## adapted from: flake8-unused-globals v0.1.10
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
395 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
396
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
397 def __checkUnusedGlobals(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
398 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
399 Private method to check for unused global variables.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
400 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
401 errors = {}
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
402 loadCounter = GlobalVariableLoadCounter()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
403 loadCounter.visit(self.__tree)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
404
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
405 globalVariables = self.__extractGlobalVariables()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
406
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
407 for varId, loads in loadCounter.getLoads():
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
408 if varId in globalVariables and loads == 0:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
409 storeInfo = loadCounter.getStoreInfo(varId)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
410 errorInfo = (storeInfo.lineno - 1, storeInfo.offset, "U200", varId)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
411 errors[varId] = errorInfo
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
412
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
413 for node in self.__tree.body[::-1]:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
414 if isinstance(node, ast.Assign):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
415 for target in node.targets:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
416 if isinstance(target, ast.Name) and target.id in errors:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
417 errors.pop(target.id)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
418 elif (
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
419 isinstance(node, ast.AnnAssign)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
420 and isinstance(node.target, ast.Name)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
421 and node.target.id in errors
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
422 ):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
423 errors.pop(node.target.id)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
424 else:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
425 break
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
426
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
427 if self.__args["IgnoreDunderGlobals"]:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
428 # eliminate some special cases
10373
093dcebe5ecb Corrected some uses of dict.keys(), dict.values() and dict.items().
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10185
diff changeset
429 for name in list(errors):
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
430 if name.startswith("__") and name.endswith("__"):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
431 errors.pop(name)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
432
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
433 for varId in errors:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
434 self.__error(*errors[varId])
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
435
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
436 def __extractGlobalVariables(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
437 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
438 Private method to get the names of all global variables.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
439
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
440 @return set containing the defined global variable names
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
441 @rtype set of str
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
442 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
443 variables = set()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
444
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
445 for assignment in self.__tree.body:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
446 if isinstance(assignment, ast.Assign):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
447 for target in assignment.targets:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
448 if isinstance(target, ast.Name):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
449 variables.add(target.id)
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
450 elif isinstance(assignment, ast.AnnAssign) and isinstance(
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
451 assignment.target, ast.Name
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
452 ):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
453 variables.add(assignment.target.id)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
454
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
455 return variables
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
456
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
457
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
458 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
459 ## Class used by 'Unused Arguments'
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
460 ##
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
461 ## adapted from: flake8-unused-arguments v0.0.13
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
462 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
463
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
464
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
465 class FunctionFinder(ast.NodeVisitor):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
466 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
467 Class to find all defined functions and methods.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
468 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
469
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
470 def __init__(self, onlyTopLevel=False):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
471 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
472 Constructor
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
473
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
474 @param onlyTopLevel flag indicating to search for top level functions only
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
475 (defaults to False)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
476 @type bool (optional)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
477 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
478 super().__init__()
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
479
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
480 self.__functions = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
481 self.__onlyTopLevel = onlyTopLevel
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
482
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
483 def functionNodes(self):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
484 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
485 Public method to get the list of detected functions and lambdas.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
486
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
487 @return list of detected functions and lambdas
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
488 @rtype list of ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
489 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
490 return self.__functions
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
491
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
492 def __visitFunctionTypes(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
493 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
494 Private method to handle an AST node defining a function or lambda.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
495
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
496 @param functionNode reference to the node defining a function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
497 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
498 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
499 self.__functions.append(functionNode)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
500 if not self.__onlyTopLevel:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
501 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
502 self.visit(functionNode.body)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
503 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
504 for obj in functionNode.body:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
505 self.visit(obj)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
506
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
507 visit_AsyncFunctionDef = visit_FunctionDef = visit_Lambda = __visitFunctionTypes
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
508
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
509
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
510 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
511 ## Class used by 'Unused Globals'
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
512 ##
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
513 ## adapted from: flake8-unused-globals v0.1.9
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
514 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
515
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
516
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
517 GlobalVariableStoreInfo = collections.namedtuple(
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
518 "GlobalVariableStoreInfo", ["lineno", "offset"]
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
519 )
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
520
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
521
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
522 class GlobalVariableLoadCounter(ast.NodeVisitor):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
523 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
524 Class to find all defined global variables and count their usages.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
525 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
526
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
527 def __init__(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
528 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
529 Constructor
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
530 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
531 super().__init__()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
532
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
533 self.__loads = {}
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
534 self.__storeInfo = {}
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
535
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
536 def visit_Name(self, nameNode):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
537 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
538 Public method to record the definition and use of a global variable.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
539
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
540 @param nameNode reference to the name node to be processed
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
541 @type ast.Name
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
542 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
543 if isinstance(nameNode.ctx, ast.Load) and nameNode.id in self.__loads:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
544 self.__loads[nameNode.id] += 1
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
545 elif (
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
546 isinstance(nameNode.ctx, ast.Store) and nameNode.id not in self.__storeInfo
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
547 ):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
548 self.__loads[nameNode.id] = 0
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
549 self.__storeInfo[nameNode.id] = GlobalVariableStoreInfo(
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
550 lineno=nameNode.lineno, offset=nameNode.col_offset
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
551 )
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
552
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
553 def getLoads(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
554 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
555 Public method to get an iterator of the detected variable loads.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
556
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
557 @return DESCRIPTION
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
558 @rtype TYPE
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
559 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
560 return self.__loads.items()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
561
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
562 def getStoreInfo(self, variableId):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
563 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
564 Public method to get the store info data of a given variable ID.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
565
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
566 @param variableId variable ID to retrieve the store info for
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
567 @type str
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
568 @return named tuple containing the line number and column offset
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
569 @rtype GlobalVariableStoreInfo
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
570 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
571 try:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
572 return self.__storeInfo[variableId]
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
573 except KeyError:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
574 return None

eric ide

mercurial