11297
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1
|
# -*- coding: utf-8 -*- |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
3
|
# Copyright (c) 2025 Detlev Offenbach <detlev@die-offenbachs.de> |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7
|
Module implementing checks for potential XSS on markupsafe.Markup use. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
10
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11
|
# This is a modified version of the one found in the bandit package. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
12
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13
|
# Copyright (c) 2025 David Salvisberg |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15
|
# SPDX-License-Identifier: Apache-2.0 |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16
|
# |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18
|
import ast |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
20
|
from Security import SecurityUtils |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
21
|
from Security.SecurityDefaults import SecurityDefaults |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
22
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
23
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
24
|
def getChecks(): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
26
|
Public method to get a dictionary with checks handled by this module. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
28
|
@return dictionary containing checker lists containing checker function and |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
29
|
list of codes |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30
|
@rtype dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
32
|
return { |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33
|
"Call": [ |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34
|
(markupsafeMarkupXss, ("S-704",)), |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35
|
], |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36
|
} |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39
|
def markupsafeMarkupXss(reportError, context, config): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41
|
Function to check for potential XSS on markupsafe.Markup use. |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43
|
@param reportError function to be used to report errors |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44
|
@type func |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45
|
@param context security context object |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
46
|
@type SecurityContext |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47
|
@param config dictionary with configuration data (unused) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48
|
@type dict |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49
|
""" |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
50
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51
|
qualname = context.callFunctionNameQual |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52
|
if qualname not in ("markupsafe.Markup", "flask.Markup"): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53
|
if qualname not in config.get( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54
|
"extend_markup_names", SecurityDefaults["extend_markup_names"] |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55
|
): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56
|
# not a Markup call |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57
|
return None |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59
|
args = context.node.args |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60
|
if not args or isinstance(args[0], ast.Constant): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61
|
# both no arguments and a constant are fine |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62
|
return None |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64
|
allowedCalls = config.get("allowed_calls", SecurityDefaults["allowed_calls"]) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
65
|
if ( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
66
|
allowedCalls |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67
|
and isinstance(args[0], ast.Call) |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68
|
and SecurityUtils.getCallName(args[0], context.importAliases) in allowedCalls |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69
|
): |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70
|
# the argument contains a whitelisted call |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71
|
return None |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72
|
|
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73
|
reportError( |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74
|
context.node.lineno - 1, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75
|
context.node.col_offset, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76
|
"S-704", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77
|
"M", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78
|
"H", |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79
|
qualname, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80
|
context.callFunctionName, |
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81
|
) |