src/eric7/Plugins/CheckerPlugins/CodeStyleChecker/Security/Checks/markupsafeMarkupXSS.py

Mon, 19 May 2025 14:33:49 +0200

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Mon, 19 May 2025 14:33:49 +0200
branch
eric7
changeset 11297
2c773823fb7d
child 11300
0119e3818e12
permissions
-rw-r--r--

Code Style Checker
- Updated the security checker to `bandit` v1.8.3.

11297
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
1 # -*- coding: utf-8 -*-
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
2
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
3 # Copyright (c) 2025 Detlev Offenbach <detlev@die-offenbachs.de>
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
4 #
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
5
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
6 """
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
7 Module implementing checks for potential XSS on markupsafe.Markup use.
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
8 """
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
9
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
10 #
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
11 # This is a modified version of the one found in the bandit package.
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
12 #
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
13 # Copyright (c) 2025 David Salvisberg
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
14 #
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
15 # SPDX-License-Identifier: Apache-2.0
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
16 #
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
17
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
18 import ast
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
19
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
20 from Security import SecurityUtils
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
21 from Security.SecurityDefaults import SecurityDefaults
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
22
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
23
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
24 def getChecks():
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
25 """
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
26 Public method to get a dictionary with checks handled by this module.
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
27
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
28 @return dictionary containing checker lists containing checker function and
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
29 list of codes
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
30 @rtype dict
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
31 """
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
32 return {
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
33 "Call": [
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
34 (markupsafeMarkupXss, ("S-704",)),
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
35 ],
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
36 }
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
37
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
38
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
39 def markupsafeMarkupXss(reportError, context, config):
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
40 """
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
41 Function to check for potential XSS on markupsafe.Markup use.
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
42
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
43 @param reportError function to be used to report errors
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
44 @type func
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
45 @param context security context object
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
46 @type SecurityContext
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
47 @param config dictionary with configuration data (unused)
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
48 @type dict
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
49 """
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
50
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
51 qualname = context.callFunctionNameQual
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
52 if qualname not in ("markupsafe.Markup", "flask.Markup"):
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
53 if qualname not in config.get(
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
54 "extend_markup_names", SecurityDefaults["extend_markup_names"]
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
55 ):
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
56 # not a Markup call
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
57 return None
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
58
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
59 args = context.node.args
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
60 if not args or isinstance(args[0], ast.Constant):
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
61 # both no arguments and a constant are fine
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
62 return None
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
63
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
64 allowedCalls = config.get("allowed_calls", SecurityDefaults["allowed_calls"])
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
65 if (
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
66 allowedCalls
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
67 and isinstance(args[0], ast.Call)
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
68 and SecurityUtils.getCallName(args[0], context.importAliases) in allowedCalls
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
69 ):
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
70 # the argument contains a whitelisted call
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
71 return None
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
72
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
73 reportError(
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
74 context.node.lineno - 1,
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
75 context.node.col_offset,
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
76 "S-704",
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
77 "M",
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
78 "H",
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
79 qualname,
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
80 context.callFunctionName,
2c773823fb7d Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
81 )

eric ide

mercurial