Thu, 25 May 2023 11:06:31 +0200
Code Style Checker
- Added an option to ignore unused arguments of Qt event handler methods.
10052 | 1 | # -*- coding: utf-8 -*- |
2 | ||
3 | # Copyright (c) 2023 Detlev Offenbach <detlev@die-offenbachs.de> | |
4 | # | |
5 | ||
6 | """ | |
7 | Module implementing a checker for unused arguments, variables, ... . | |
8 | """ | |
9 | ||
10 | import ast | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
11 | import collections |
10052 | 12 | import copy |
13 | ||
14 | import AstUtilities | |
15 | ||
16 | ||
17 | class UnusedChecker: | |
18 | """ | |
19 | Class implementing a checker for unused arguments, variables, ... . | |
20 | """ | |
21 | ||
22 | Codes = [ | |
23 | ## Unused Arguments | |
24 | "U100", | |
25 | "U101", | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
26 | ## Unused Globals |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
27 | "U200", |
10052 | 28 | ] |
29 | ||
30 | def __init__(self, source, filename, tree, select, ignore, expected, repeat, args): | |
31 | """ | |
32 | Constructor | |
33 | ||
34 | @param source source code to be checked | |
35 | @type list of str | |
36 | @param filename name of the source file | |
37 | @type str | |
38 | @param tree AST tree of the source code | |
39 | @type ast.Module | |
40 | @param select list of selected codes | |
41 | @type list of str | |
42 | @param ignore list of codes to be ignored | |
43 | @type list of str | |
44 | @param expected list of expected codes | |
45 | @type list of str | |
46 | @param repeat flag indicating to report each occurrence of a code | |
47 | @type bool | |
48 | @param args dictionary of arguments for the various checks | |
49 | @type dict | |
50 | """ | |
51 | self.__select = tuple(select) | |
52 | self.__ignore = ("",) if select else tuple(ignore) | |
53 | self.__expected = expected[:] | |
54 | self.__repeat = repeat | |
55 | self.__filename = filename | |
56 | self.__source = source[:] | |
57 | self.__tree = copy.deepcopy(tree) | |
58 | self.__args = args | |
59 | ||
60 | # statistics counters | |
61 | self.counters = {} | |
62 | ||
63 | # collection of detected errors | |
64 | self.errors = [] | |
65 | ||
66 | checkersWithCodes = [ | |
67 | (self.__checkUnusedArguments, ("U100", "U101")), | |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
68 | (self.__checkUnusedGlobals, ("U200",)), |
10052 | 69 | ] |
70 | ||
71 | self.__checkers = [] | |
72 | for checker, codes in checkersWithCodes: | |
73 | if any(not (code and self.__ignoreCode(code)) for code in codes): | |
74 | self.__checkers.append(checker) | |
75 | ||
76 | def __ignoreCode(self, code): | |
77 | """ | |
78 | Private method to check if the message code should be ignored. | |
79 | ||
80 | @param code message code to check for | |
81 | @type str | |
82 | @return flag indicating to ignore the given code | |
83 | @rtype bool | |
84 | """ | |
85 | return code.startswith(self.__ignore) and not code.startswith(self.__select) | |
86 | ||
87 | def __error(self, lineNumber, offset, code, *args): | |
88 | """ | |
89 | Private method to record an issue. | |
90 | ||
91 | @param lineNumber line number of the issue | |
92 | @type int | |
93 | @param offset position within line of the issue | |
94 | @type int | |
95 | @param code message code | |
96 | @type str | |
97 | @param args arguments for the message | |
98 | @type list | |
99 | """ | |
100 | if self.__ignoreCode(code): | |
101 | return | |
102 | ||
103 | if code in self.counters: | |
104 | self.counters[code] += 1 | |
105 | else: | |
106 | self.counters[code] = 1 | |
107 | ||
108 | # Don't care about expected codes | |
109 | if code in self.__expected: | |
110 | return | |
111 | ||
112 | if code and (self.counters[code] == 1 or self.__repeat): | |
113 | # record the issue with one based line number | |
114 | self.errors.append( | |
115 | { | |
116 | "file": self.__filename, | |
117 | "line": lineNumber + 1, | |
118 | "offset": offset, | |
119 | "code": code, | |
120 | "args": args, | |
121 | } | |
122 | ) | |
123 | ||
124 | def run(self): | |
125 | """ | |
126 | Public method to check the given source against miscellaneous | |
127 | conditions. | |
128 | """ | |
129 | if not self.__filename: | |
130 | # don't do anything, if essential data is missing | |
131 | return | |
132 | ||
133 | if not self.__checkers: | |
134 | # don't do anything, if no codes were selected | |
135 | return | |
136 | ||
137 | for check in self.__checkers: | |
138 | check() | |
139 | ||
140 | ####################################################################### | |
141 | ## Unused Arguments | |
142 | ## | |
143 | ## adapted from: flake8-unused-arguments v0.0.13 | |
144 | ####################################################################### | |
145 | ||
146 | def __checkUnusedArguments(self): | |
147 | """ | |
148 | Private method to check function and method definitions for unused arguments. | |
149 | """ | |
150 | finder = FunctionFinder(self.__args["IgnoreNestedFunctions"]) | |
151 | finder.visit(self.__tree) | |
152 | ||
153 | for functionNode in finder.functionNodes(): | |
154 | decoratorNames = set(self.__getDecoratorNames(functionNode)) | |
155 | ||
156 | # ignore overload functions, it's not a surprise when they're empty | |
157 | if self.__args["IgnoreOverload"] and "overload" in decoratorNames: | |
158 | continue | |
159 | ||
160 | # ignore overridden functions | |
161 | if self.__args["IgnoreOverride"] and "override" in decoratorNames: | |
162 | continue | |
163 | ||
164 | # ignore abstractmethods, it's not a surprise when they're empty | |
165 | if self.__args["IgnoreAbstract"] and "abstractmethod" in decoratorNames: | |
166 | continue | |
167 | ||
168 | # ignore Qt slot methods | |
169 | if self.__args["IgnoreSlotMethods"] and ( | |
170 | "pyqtSlot" in decoratorNames or "Slot" in decoratorNames | |
171 | ): | |
172 | continue | |
173 | ||
10066
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
174 | # TODO: add 'IgnoreEventHandlerMethods' to ignore Qt event handlers |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
175 | # - function name ends with 'Event' |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
176 | # - function name is 'event' or 'eventFilter' |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
177 | if self.__args["IgnoreEventHandlerMethods"] and self.__isEventHandlerMethod( |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
178 | functionNode |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
179 | ): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
180 | continue |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
181 | |
10052 | 182 | # ignore stub functions |
183 | if self.__args["IgnoreStubs"] and self.__isStubFunction(functionNode): | |
184 | continue | |
185 | ||
186 | # ignore lambdas | |
187 | if self.__args["IgnoreLambdas"] and isinstance(functionNode, ast.Lambda): | |
188 | continue | |
189 | ||
190 | # ignore __double_underscore_methods__() | |
191 | if self.__args["IgnoreDunderMethods"] and self.__isDunderMethod( | |
192 | functionNode | |
193 | ): | |
194 | continue | |
195 | ||
196 | for i, argument in self.__getUnusedArguments(functionNode): | |
197 | name = argument.arg | |
198 | if self.__args["IgnoreVariadicNames"]: | |
199 | if ( | |
200 | functionNode.args.vararg | |
201 | and functionNode.args.vararg.arg == name | |
202 | ): | |
203 | continue | |
204 | if functionNode.args.kwarg and functionNode.args.kwarg.arg == name: | |
205 | continue | |
206 | ||
207 | # ignore self or whatever the first argument is for a classmethod | |
208 | if i == 0 and ( | |
209 | name in ("self", "cls") or "classmethod" in decoratorNames | |
210 | ): | |
211 | continue | |
212 | ||
213 | lineNumber = argument.lineno | |
214 | offset = argument.col_offset | |
215 | ||
216 | errorCode = "U101" if name.startswith("_") else "U100" | |
217 | self.__error(lineNumber - 1, offset, errorCode, name) | |
218 | ||
219 | def __getDecoratorNames(self, functionNode): | |
220 | """ | |
221 | Private method to yield the decorator names of the function. | |
222 | ||
223 | @param functionNode reference to the node defining the function or lambda | |
224 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
225 | @yield decorator name | |
226 | @ytype str | |
227 | """ | |
228 | if isinstance(functionNode, ast.Lambda): | |
229 | return | |
230 | ||
231 | for decorator in functionNode.decorator_list: | |
232 | if isinstance(decorator, ast.Name): | |
233 | yield decorator.id | |
234 | elif isinstance(decorator, ast.Attribute): | |
235 | yield decorator.attr | |
236 | elif isinstance(decorator, ast.Call): | |
237 | if isinstance(decorator.func, ast.Name): | |
238 | yield decorator.func.id | |
239 | else: | |
240 | yield decorator.func.attr | |
241 | ||
242 | def __isStubFunction(self, functionNode): | |
243 | """ | |
244 | Private method to check, if the given function node defines a stub function. | |
245 | ||
246 | @param functionNode reference to the node defining the function or lambda | |
247 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
248 | @return flag indicating a stub function | |
249 | @rtype bool | |
250 | """ | |
251 | if isinstance(functionNode, ast.Lambda): | |
252 | return AstUtilities.isEllipsis(functionNode.body) | |
253 | ||
254 | statement = functionNode.body[0] | |
255 | if isinstance(statement, ast.Expr) and AstUtilities.isString(statement.value): | |
256 | if len(functionNode.body) > 1: | |
257 | # first statement is a docstring, let's skip it | |
258 | statement = functionNode.body[1] | |
259 | else: | |
260 | # it's a function with only a docstring, that's a stub | |
261 | return True | |
262 | ||
263 | if isinstance(statement, ast.Pass): | |
264 | return True | |
265 | if isinstance(statement, ast.Expr) and AstUtilities.isEllipsis(statement.value): | |
266 | return True | |
267 | ||
268 | if isinstance(statement, ast.Raise): | |
269 | # like 'raise NotImplementedError()' | |
270 | if ( | |
271 | isinstance(statement.exc, ast.Call) | |
272 | and hasattr(statement.exc.func, "id") | |
273 | and statement.exc.func.id == "NotImplementedError" | |
274 | ): | |
275 | return True | |
276 | ||
277 | # like 'raise NotImplementedError' | |
278 | elif ( | |
279 | isinstance(statement.exc, ast.Name) | |
280 | and hasattr(statement.exc, "id") | |
281 | and statement.exc.id == "NotImplementedError" | |
282 | ): | |
283 | return True | |
284 | ||
285 | return False | |
286 | ||
287 | def __isDunderMethod(self, functionNode): | |
288 | """ | |
289 | Private method to check, if the function node defines a special function. | |
290 | ||
291 | @param functionNode reference to the node defining the function or lambda | |
292 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
293 | @return flag indicating a special function | |
294 | @rtype bool | |
295 | """ | |
296 | if isinstance(functionNode, ast.Lambda): | |
297 | return False | |
298 | ||
299 | if not hasattr(functionNode, "name"): | |
300 | return False | |
301 | ||
302 | name = functionNode.name | |
303 | return len(name) > 4 and name.startswith("__") and name.endswith("__") | |
304 | ||
10066
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
305 | def __isEventHandlerMethod(self, functionNode): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
306 | """ |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
307 | Private method to check, if the function node defines a Qt event handler. |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
308 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
309 | Qt event handler methods are assumed to end with 'Event' or have the name |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
310 | 'event' or 'eventFilter'. Only standard methodes (i.e. ast.FunctionDef) |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
311 | are assumed to be potential event handlers. |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
312 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
313 | @param functionNode reference to the node defining the function or lambda |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
314 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
315 | @return flag indicating a Qt event handler method |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
316 | @rtype bool |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
317 | """ |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
318 | if isinstance(functionNode, (ast.Lambda, ast.AsyncFunctionDef)): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
319 | return False |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
320 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
321 | if not hasattr(functionNode, "name"): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
322 | return False |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
323 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
324 | name = functionNode.name |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
325 | return name.endswith("Event") or name in ("event", "eventFilter") |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
326 | |
10052 | 327 | def __getUnusedArguments(self, functionNode): |
328 | """ | |
329 | Private method to get a list of unused arguments of the given function. | |
330 | ||
331 | @param functionNode reference to the node defining the function or lambda | |
332 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
333 | @return list of tuples of the argument position and the argument | |
334 | @rtype list of tuples of (int, ast.arg) | |
335 | """ | |
336 | arguments = list(enumerate(self.__getArguments(functionNode))) | |
337 | ||
338 | class NameFinder(ast.NodeVisitor): | |
339 | """ | |
340 | Class to find the used argument names. | |
341 | """ | |
342 | ||
343 | def visit_Name(self, name): | |
344 | """ | |
345 | Public method to check a Name node. | |
346 | ||
347 | @param name reference to the name node to be checked | |
348 | @type ast.Name | |
349 | """ | |
350 | nonlocal arguments | |
351 | ||
352 | if isinstance(name.ctx, ast.Store): | |
353 | return | |
354 | ||
355 | arguments = [ | |
356 | (argIndex, arg) for argIndex, arg in arguments if arg.arg != name.id | |
357 | ] | |
358 | ||
359 | NameFinder().visit(functionNode) | |
360 | return arguments | |
361 | ||
362 | def __getArguments(self, functionNode): | |
363 | """ | |
364 | Private method to get all argument names of the given function. | |
365 | ||
366 | @param functionNode reference to the node defining the function or lambda | |
367 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
368 | @return list of argument names | |
369 | @rtype list of ast.arg | |
370 | """ | |
371 | args = functionNode.args | |
372 | ||
373 | orderedArguments = [] | |
374 | ||
375 | # plain old args | |
376 | orderedArguments.extend(args.args) | |
377 | ||
378 | # *arg name | |
379 | if args.vararg is not None: | |
380 | orderedArguments.append(args.vararg) | |
381 | ||
382 | # *, key, word, only, args | |
383 | orderedArguments.extend(args.kwonlyargs) | |
384 | ||
385 | # **kwarg name | |
386 | if args.kwarg is not None: | |
387 | orderedArguments.append(args.kwarg) | |
388 | ||
389 | return orderedArguments | |
390 | ||
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
391 | ####################################################################### |
10056
ac1c214e0a05
Corrected some comments.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10054
diff
changeset
|
392 | ## Unused Globals |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
393 | ## |
10056
ac1c214e0a05
Corrected some comments.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10054
diff
changeset
|
394 | ## adapted from: flake8-unused-globals v0.1.9 |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
395 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
396 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
397 | def __checkUnusedGlobals(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
398 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
399 | Private method to check for unused global variables. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
400 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
401 | errors = {} |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
402 | loadCounter = GlobalVariableLoadCounter() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
403 | loadCounter.visit(self.__tree) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
404 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
405 | globalVariables = self.__extractGlobalVariables() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
406 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
407 | for varId, loads in loadCounter.getLoads(): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
408 | if varId in globalVariables and loads == 0: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
409 | storeInfo = loadCounter.getStoreInfo(varId) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
410 | errorInfo = (storeInfo.lineno - 1, storeInfo.offset, "U200", varId) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
411 | errors[varId] = errorInfo |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
412 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
413 | for node in self.__tree.body[::-1]: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
414 | if isinstance(node, ast.Assign): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
415 | for target in node.targets: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
416 | if isinstance(target, ast.Name) and target.id in errors: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
417 | errors.pop(target.id) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
418 | elif ( |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
419 | isinstance(node, ast.AnnAssign) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
420 | and isinstance(node.target, ast.Name) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
421 | and node.target.id in errors |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
422 | ): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
423 | errors.pop(node.target.id) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
424 | else: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
425 | break |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
426 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
427 | if self.__args["IgnoreDunderGlobals"]: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
428 | # eliminate some special cases |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
429 | for name in list(errors.keys()): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
430 | if name.startswith("__") and name.endswith("__"): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
431 | errors.pop(name) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
432 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
433 | for varId in errors: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
434 | self.__error(*errors[varId]) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
435 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
436 | def __extractGlobalVariables(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
437 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
438 | Private method to get the names of all global variables. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
439 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
440 | @return set containing the defined global variable names |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
441 | @rtype set of str |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
442 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
443 | variables = set() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
444 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
445 | for assignment in self.__tree.body: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
446 | if isinstance(assignment, ast.Assign): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
447 | for target in assignment.targets: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
448 | if isinstance(target, ast.Name): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
449 | variables.add(target.id) |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
450 | elif isinstance(assignment, ast.AnnAssign) and isinstance( |
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
451 | assignment.target, ast.Name |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
452 | ): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
453 | variables.add(assignment.target.id) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
454 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
455 | return variables |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
456 | |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
457 | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
458 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
459 | ## Class used by 'Unused Arguments' |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
460 | ## |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
461 | ## adapted from: flake8-unused-arguments v0.0.13 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
462 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
463 | |
10052 | 464 | |
465 | class FunctionFinder(ast.NodeVisitor): | |
466 | """ | |
467 | Class to find all defined functions and methods. | |
468 | """ | |
469 | ||
470 | def __init__(self, onlyTopLevel=False): | |
471 | """ | |
472 | Constructor | |
473 | ||
474 | @param onlyTopLevel flag indicating to search for top level functions only | |
475 | (defaults to False) | |
476 | @type bool (optional) | |
477 | """ | |
478 | super().__init__() | |
479 | ||
480 | self.__functions = [] | |
481 | self.__onlyTopLevel = onlyTopLevel | |
482 | ||
483 | def functionNodes(self): | |
484 | """ | |
485 | Public method to get the list of detected functions and lambdas. | |
486 | ||
487 | @return list of detected functions and lambdas | |
488 | @rtype list of ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
489 | """ | |
490 | return self.__functions | |
491 | ||
492 | def __visitFunctionTypes(self, functionNode): | |
493 | """ | |
494 | Private method to handle an AST node defining a function or lambda. | |
495 | ||
496 | @param functionNode reference to the node defining a function or lambda | |
497 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
498 | """ | |
499 | self.__functions.append(functionNode) | |
500 | if not self.__onlyTopLevel: | |
501 | if isinstance(functionNode, ast.Lambda): | |
502 | self.visit(functionNode.body) | |
503 | else: | |
504 | for obj in functionNode.body: | |
505 | self.visit(obj) | |
506 | ||
507 | visit_AsyncFunctionDef = visit_FunctionDef = visit_Lambda = __visitFunctionTypes | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
508 | |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
509 | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
510 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
511 | ## Class used by 'Unused Globals' |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
512 | ## |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
513 | ## adapted from: flake8-unused-globals v0.1.9 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
514 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
515 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
516 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
517 | GlobalVariableStoreInfo = collections.namedtuple( |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
518 | "GlobalVariableStoreInfo", ["lineno", "offset"] |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
519 | ) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
520 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
521 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
522 | class GlobalVariableLoadCounter(ast.NodeVisitor): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
523 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
524 | Class to find all defined global variables and count their usages. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
525 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
526 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
527 | def __init__(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
528 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
529 | Constructor |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
530 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
531 | super().__init__() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
532 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
533 | self.__loads = {} |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
534 | self.__storeInfo = {} |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
535 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
536 | def visit_Name(self, nameNode): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
537 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
538 | Public method to record the definition and use of a global variable. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
539 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
540 | @param nameNode reference to the name node to be processed |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
541 | @type ast.Name |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
542 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
543 | if isinstance(nameNode.ctx, ast.Load) and nameNode.id in self.__loads: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
544 | self.__loads[nameNode.id] += 1 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
545 | elif ( |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
546 | isinstance(nameNode.ctx, ast.Store) and nameNode.id not in self.__storeInfo |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
547 | ): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
548 | self.__loads[nameNode.id] = 0 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
549 | self.__storeInfo[nameNode.id] = GlobalVariableStoreInfo( |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
550 | lineno=nameNode.lineno, offset=nameNode.col_offset |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
551 | ) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
552 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
553 | def getLoads(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
554 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
555 | Public method to get an iterator of the detected variable loads. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
556 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
557 | @return DESCRIPTION |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
558 | @rtype TYPE |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
559 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
560 | return self.__loads.items() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
561 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
562 | def getStoreInfo(self, variableId): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
563 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
564 | Public method to get the store info data of a given variable ID. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
565 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
566 | @param variableId variable ID to retrieve the store info for |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
567 | @type str |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
568 | @return named tuple containing the line number and column offset |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
569 | @rtype GlobalVariableStoreInfo |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
570 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
571 | try: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
572 | return self.__storeInfo[variableId] |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
573 | except KeyError: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
574 | return None |