src/eric7/Plugins/CheckerPlugins/CodeStyleChecker/Miscellaneous/MiscellaneousChecker.py

Sun, 16 Feb 2025 15:05:39 +0100

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Sun, 16 Feb 2025 15:05:39 +0100
branch
eric7
changeset 11138
1f743bad6fd3
parent 11134
3243a66db84a
child 11140
b823386f7591
permissions
-rw-r--r--

Code Style Checker
- Updated the Miscellaneous checker to `flake8-bugbear` v24.12.12.

4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
1 # -*- coding: utf-8 -*-
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
2
11090
f5f5f5803935 Updated copyright for 2025.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11000
diff changeset
3 # Copyright (c) 2015 - 2025 Detlev Offenbach <detlev@die-offenbachs.de>
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
4 #
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
5
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
6 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
7 Module implementing a checker for miscellaneous checks.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
8 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
9
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
10 import ast
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
11 import builtins
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
12 import contextlib
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
13 import copy
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
14 import itertools
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
15 import math
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
16 import re
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
17 import sys
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
18 import tokenize
9473
3f23dbf37dbe Resorted the import statements using isort.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9327
diff changeset
19
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
20 from collections import Counter, defaultdict, namedtuple
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
21 from dataclasses import dataclass
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
22 from keyword import iskeyword
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
23 from string import Formatter
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
24
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
25 try:
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
26 # Python 3.10+
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
27 from itertools import pairwise
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
28 except ImportError:
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
29 # replacement for Python < 3.10
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
30 from itertools import tee
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
31
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
32 def pairwise(iterable):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
33 a, b = tee(iterable)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
34 next(b, None)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
35 return zip(a, b)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
36
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
37
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
38 import AstUtilities
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
39
8168
bdb0258faf42 Code Style Checker: reorganized the code a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8166
diff changeset
40 from .eradicate import Eradicator
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
41 from .MiscellaneousDefaults import MiscellaneousCheckerDefaultArgs
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
42
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
43 BugbearMutableLiterals = ("Dict", "List", "Set")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
44 BugbearMutableComprehensions = ("ListComp", "DictComp", "SetComp")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
45 BugbearMutableCalls = (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
46 "Counter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
47 "OrderedDict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
48 "collections.Counter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
49 "collections.OrderedDict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
50 "collections.defaultdict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
51 "collections.deque",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
52 "defaultdict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
53 "deque",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
54 "dict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
55 "list",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
56 "set",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
57 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
58 BugbearImmutableCalls = (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
59 "tuple",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
60 "frozenset",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
61 "types.MappingProxyType",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
62 "MappingProxyType",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
63 "re.compile",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
64 "operator.attrgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
65 "operator.itemgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
66 "operator.methodcaller",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
67 "attrgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
68 "itemgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
69 "methodcaller",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
70 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
71
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
72
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
73 def composeCallPath(node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
74 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
75 Generator function to assemble the call path of a given node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
76
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
77 @param node node to assemble call path for
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
78 @type ast.Node
7988
c4c17121eff8 Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7980
diff changeset
79 @yield call path components
c4c17121eff8 Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7980
diff changeset
80 @ytype str
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
81 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
82 if isinstance(node, ast.Attribute):
8205
4a0f1f896341 Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8198
diff changeset
83 yield from composeCallPath(node.value)
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
84 yield node.attr
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
85 elif isinstance(node, ast.Call):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
86 yield from composeCallPath(node.func)
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
87 elif isinstance(node, ast.Name):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
88 yield node.id
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
89
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
90
8207
d359172d11be Applied some more code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8205
diff changeset
91 class MiscellaneousChecker:
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
92 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
93 Class implementing a checker for miscellaneous checks.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
94 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
95
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
96 Codes = [
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
97 ## Coding line
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
98 "M101",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
99 "M102",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
100 ## Copyright
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
101 "M111",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
102 "M112",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
103 ## Shadowed Builtins
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
104 "M131",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
105 "M132",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
106 ## Comprehensions
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
107 "M180",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
108 "M181",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
109 "M182",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
110 "M183",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
111 "M184",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
112 "M185",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
113 "M186",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
114 "M188",
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
115 "M189",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
116 "M189a",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
117 "M189b",
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
118 "M190",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
119 "M190a",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
120 "M190b",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
121 "M191",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
122 "M193",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
123 "M193a",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
124 "M193b",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
125 "M193c",
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
126 "M194",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
127 "M195",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
128 "M196",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
129 "M197",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
130 "M198",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
131 "M199",
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
132 "M200",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
133 ## Dictionaries with sorted keys
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
134 "M251",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
135 ## Property
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
136 "M260",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
137 "M261",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
138 "M262",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
139 "M263",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
140 "M264",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
141 "M265",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
142 "M266",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
143 "M267",
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
144 ## Naive datetime usage
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
145 "M301",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
146 "M302",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
147 "M303",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
148 "M304",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
149 "M305",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
150 "M306",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
151 "M307",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
152 "M308",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
153 "M311",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
154 "M312",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
155 "M313",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
156 "M314",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
157 "M315",
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
158 "M321",
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
159 ## sys.version and sys.version_info usage
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
160 "M401",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
161 "M402",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
162 "M403",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
163 "M411",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
164 "M412",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
165 "M413",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
166 "M414",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
167 "M421",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
168 "M422",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
169 "M423",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
170 ## Bugbear
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
171 "M501",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
172 "M502",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
173 "M503",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
174 "M504",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
175 "M505",
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
176 "M506",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
177 "M507",
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
178 "M508",
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
179 "M509",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
180 "M510",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
181 "M511",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
182 "M512",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
183 "M513",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
184 "M514",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
185 "M515",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
186 "M516",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
187 "M517",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
188 "M518",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
189 "M519",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
190 "M520",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
191 "M521",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
192 "M522",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
193 "M523",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
194 "M524",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
195 "M525",
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
196 "M526",
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
197 "M527",
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
198 "M528",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
199 "M529",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
200 "M530",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
201 "M531",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
202 "M532",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
203 "M533",
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
204 "M534",
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
205 "M535",
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
206 "M536",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
207 "M537",
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
208 "M539",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
209 "M540",
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
210 "M541",
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
211 ## Bugbear, opininonated
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
212 "M569",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
213 ## Bugbear++
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
214 "M581",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
215 "M582",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
216 ## Format Strings
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
217 "M601",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
218 "M611",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
219 "M612",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
220 "M613",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
221 "M621",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
222 "M622",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
223 "M623",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
224 "M624",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
225 "M625",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
226 "M631",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
227 "M632",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
228 ## Future statements
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
229 "M701",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
230 "M702",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
231 ## Gettext
6182
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
232 "M711",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
233 ## print() statements
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
234 "M801",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
235 ## one element tuple
4507
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
236 "M811",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
237 ## return statements
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
238 "M831",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
239 "M832",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
240 "M833",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
241 "M834",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
242 ## line continuation
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
243 "M841",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
244 ## implicitly concatenated strings
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
245 "M851",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
246 "M852",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
247 "M853",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
248 ## commented code
7040
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
249 "M891",
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
250 ]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
251
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
252 Formatter = Formatter()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
253 FormatFieldRegex = re.compile(r"^((?:\s|.)*?)(\..*|\[.*\])?$")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
254
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
255 BuiltinsWhiteList = [
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
256 "__name__",
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
257 "__doc__",
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
258 "credits",
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
259 ]
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
260
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
261 def __init__(self, source, filename, tree, select, ignore, expected, repeat, args):
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
262 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
263 Constructor
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
264
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
265 @param source source code to be checked
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
266 @type list of str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
267 @param filename name of the source file
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
268 @type str
8198
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
269 @param tree AST tree of the source code
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
270 @type ast.Module
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
271 @param select list of selected codes
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
272 @type list of str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
273 @param ignore list of codes to be ignored
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
274 @type list of str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
275 @param expected list of expected codes
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
276 @type list of str
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
277 @param repeat flag indicating to report each occurrence of a code
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
278 @type bool
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
279 @param args dictionary of arguments for the miscellaneous checks
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
280 @type dict
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
281 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
282 self.__select = tuple(select)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
283 self.__ignore = ("",) if select else tuple(ignore)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
284 self.__expected = expected[:]
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
285 self.__repeat = repeat
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
286 self.__filename = filename
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
287 self.__source = source[:]
8198
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
288 self.__tree = copy.deepcopy(tree)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
289 self.__args = args
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
290
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
291 linesIterator = iter(self.__source)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
292 self.__tokens = list(tokenize.generate_tokens(lambda: next(linesIterator)))
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
293
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
294 self.__pep3101FormatRegex = re.compile(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
295 r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%'
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
296 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
297
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
298 self.__builtins = [b for b in dir(builtins) if b not in self.BuiltinsWhiteList]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
299
7972
4fc11172df1b Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7923
diff changeset
300 self.__eradicator = Eradicator()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
301
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
302 # statistics counters
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
303 self.counters = {}
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
304
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
305 # collection of detected errors
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
306 self.errors = []
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
307
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
308 checkersWithCodes = [
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
309 (self.__checkCoding, ("M101", "M102")),
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
310 (self.__checkCopyright, ("M111", "M112")),
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
311 (self.__checkBuiltins, ("M131", "M132")),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
312 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
313 self.__checkComprehensions,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
314 (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
315 "M180",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
316 "M181",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
317 "M182",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
318 "M183",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
319 "M184",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
320 "M185",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
321 "M186",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
322 "M188",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
323 "M189",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
324 "M189a",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
325 "M189b",
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
326 "M190",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
327 "M190a",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
328 "M190b",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
329 "M191",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
330 "M193",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
331 "M193a",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
332 "M193b",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
333 "M193c",
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
334 "M194",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
335 "M195",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
336 "M196",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
337 "M197",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
338 "M198",
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
339 "M199",
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
340 "M200",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
341 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
342 ),
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
343 (self.__checkDictWithSortedKeys, ("M251",)),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
344 (
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
345 self.__checkProperties,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
346 ("M260", "M261", "M262", "M263", "M264", "M265", "M266", "M267"),
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
347 ),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
348 (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
349 self.__checkDateTime,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
350 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
351 "M301",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
352 "M302",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
353 "M303",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
354 "M304",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
355 "M305",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
356 "M306",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
357 "M307",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
358 "M308",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
359 "M311",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
360 "M312",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
361 "M313",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
362 "M314",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
363 "M315",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
364 "M321",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
365 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
366 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
367 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
368 self.__checkSysVersion,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
369 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
370 "M401",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
371 "M402",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
372 "M403",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
373 "M411",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
374 "M412",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
375 "M413",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
376 "M414",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
377 "M421",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
378 "M422",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
379 "M423",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
380 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
381 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
382 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
383 self.__checkBugBear,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
384 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
385 "M501",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
386 "M502",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
387 "M503",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
388 "M504",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
389 "M505",
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
390 "M506",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
391 "M507",
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
392 "M508",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
393 "M509",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
394 "M510",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
395 "M511",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
396 "M512",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
397 "M513",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
398 "M514",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
399 "M515",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
400 "M516",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
401 "M517",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
402 "M518",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
403 "M519",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
404 "M520",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
405 "M521",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
406 "M522",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
407 "M523",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
408 "M524",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
409 "M525",
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
410 "M526",
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
411 "M527",
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
412 "M528",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
413 "M529",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
414 "M530",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
415 "M531",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
416 "M532",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
417 "M533",
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
418 "M534",
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
419 "M535",
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
420 "M536",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
421 "M537",
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
422 "M539",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
423 "M540",
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
424 "M541",
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
425 "M569",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
426 "M581",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
427 "M582",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
428 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
429 ),
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
430 (self.__checkPep3101, ("M601",)),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
431 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
432 self.__checkFormatString,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
433 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
434 "M611",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
435 "M612",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
436 "M613",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
437 "M621",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
438 "M622",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
439 "M623",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
440 "M624",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
441 "M625",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
442 "M631",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
443 "M632",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
444 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
445 ),
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
446 (self.__checkFuture, ("M701", "M702")),
6182
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
447 (self.__checkGettext, ("M711",)),
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
448 (self.__checkPrintStatements, ("M801",)),
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
449 (self.__checkTuple, ("M811",)),
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
450 (self.__checkReturn, ("M831", "M832", "M833", "M834")),
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
451 (self.__checkLineContinuation, ("M841",)),
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
452 (self.__checkImplicitStringConcat, ("M851", "M852")),
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
453 (self.__checkExplicitStringConcat, ("M853",)),
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
454 (self.__checkCommentedCode, ("M891",)),
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
455 ]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
456
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
457 # the eradicate whitelist
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
458 commentedCodeCheckerArgs = self.__args.get(
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
459 "CommentedCodeChecker",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
460 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
461 )
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
462 commentedCodeCheckerWhitelist = commentedCodeCheckerArgs.get(
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
463 "WhiteList",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
464 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["WhiteList"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
465 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
466 self.__eradicator.update_whitelist(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
467 commentedCodeCheckerWhitelist, extend_default=False
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
468 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
469
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
470 self.__checkers = []
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
471 for checker, codes in checkersWithCodes:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
472 if any(not (code and self.__ignoreCode(code)) for code in codes):
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
473 self.__checkers.append(checker)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
474
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
475 def __ignoreCode(self, code):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
476 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
477 Private method to check if the message code should be ignored.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
478
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
479 @param code message code to check for
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
480 @type str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
481 @return flag indicating to ignore the given code
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
482 @rtype bool
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
483 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
484 return code.startswith(self.__ignore) and not code.startswith(self.__select)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
485
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
486 def __error(self, lineNumber, offset, code, *args):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
487 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
488 Private method to record an issue.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
489
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
490 @param lineNumber line number of the issue
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
491 @type int
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
492 @param offset position within line of the issue
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
493 @type int
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
494 @param code message code
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
495 @type str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
496 @param args arguments for the message
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
497 @type list
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
498 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
499 if self.__ignoreCode(code):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
500 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
501
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
502 if code in self.counters:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
503 self.counters[code] += 1
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
504 else:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
505 self.counters[code] = 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
506
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
507 # Don't care about expected codes
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
508 if code in self.__expected:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
509 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
510
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
511 if code and (self.counters[code] == 1 or self.__repeat):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
512 # record the issue with one based line number
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
513 self.errors.append(
7610
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
514 {
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
515 "file": self.__filename,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
516 "line": lineNumber + 1,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
517 "offset": offset,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
518 "code": code,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
519 "args": args,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
520 }
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
521 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
522
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
523 def run(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
524 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
525 Public method to check the given source against miscellaneous
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
526 conditions.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
527 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
528 if not self.__filename:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
529 # don't do anything, if essential data is missing
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
530 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
531
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
532 if not self.__checkers:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
533 # don't do anything, if no codes were selected
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
534 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
535
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
536 for check in self.__checkers:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
537 check()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
538
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
539 def __getCoding(self):
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
540 """
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
541 Private method to get the defined coding of the source.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
542
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
543 @return tuple containing the line number and the coding
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
544 @rtype tuple of int and str
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
545 """
6106
921d070cec82 Finished implementing support for EditorConfig.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6100
diff changeset
546 for lineno, line in enumerate(self.__source[:5]):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
547 matched = re.search(r"coding[:=]\s*([-\w_.]+)", line, re.IGNORECASE)
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
548 if matched:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
549 return lineno, matched.group(1)
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
550 else:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
551 return 0, ""
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
552
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
553 def __checkCoding(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
554 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
555 Private method to check the presence of a coding line and valid
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
556 encodings.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
557 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
558 if len(self.__source) == 0:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
559 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
560
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
561 encodings = [
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
562 e.lower().strip()
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
563 for e in self.__args.get(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
564 "CodingChecker", MiscellaneousCheckerDefaultArgs["CodingChecker"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
565 ).split(",")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
566 ]
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
567 lineno, coding = self.__getCoding()
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
568 if coding:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
569 if coding.lower() not in encodings:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
570 self.__error(lineno, 0, "M102", coding)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
571 else:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
572 self.__error(0, 0, "M101")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
573
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
574 def __checkCopyright(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
575 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
576 Private method to check the presence of a copyright statement.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
577 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
578 source = "".join(self.__source)
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
579 copyrightArgs = self.__args.get(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
580 "CopyrightChecker", MiscellaneousCheckerDefaultArgs["CopyrightChecker"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
581 )
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
582 copyrightMinFileSize = copyrightArgs.get(
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
583 "MinFilesize",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
584 MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["MinFilesize"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
585 )
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
586 copyrightAuthor = copyrightArgs.get(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
587 "Author", MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["Author"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
588 )
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
589 copyrightRegexStr = (
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
590 r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}"
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
591 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
592
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
593 tocheck = max(1024, copyrightMinFileSize)
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
594 topOfSource = source[:tocheck]
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
595 if len(topOfSource) < copyrightMinFileSize:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
596 return
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
597
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
598 copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"), re.IGNORECASE)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
599 if not copyrightRe.search(topOfSource):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
600 self.__error(0, 0, "M111")
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
601 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
602
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
603 if copyrightAuthor:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
604 copyrightAuthorRe = re.compile(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
605 copyrightRegexStr.format(author=copyrightAuthor), re.IGNORECASE
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
606 )
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
607 if not copyrightAuthorRe.search(topOfSource):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
608 self.__error(0, 0, "M112")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
609
7040
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
610 def __checkCommentedCode(self):
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
611 """
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
612 Private method to check for commented code.
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
613 """
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
614 source = "".join(self.__source)
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
615 commentedCodeCheckerArgs = self.__args.get(
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
616 "CommentedCodeChecker",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
617 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
618 )
7040
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
619 aggressive = commentedCodeCheckerArgs.get(
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
620 "Aggressive",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
621 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["Aggressive"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
622 )
7972
4fc11172df1b Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7923
diff changeset
623 for markedLine in self.__eradicator.commented_out_code_line_numbers(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
624 source, aggressive=aggressive
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
625 ):
7040
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
626 self.__error(markedLine - 1, 0, "M891")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
627
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
628 def __checkLineContinuation(self):
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
629 """
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
630 Private method to check line continuation using backslash.
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
631 """
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
632 # generate source lines without comments
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
633 comments = [tok for tok in self.__tokens if tok[0] == tokenize.COMMENT]
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
634 stripped = self.__source[:]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
635 for comment in comments:
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
636 lineno = comment[3][0]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
637 start = comment[2][1]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
638 stop = comment[3][1]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
639 content = stripped[lineno - 1]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
640 withoutComment = content[:start] + content[stop:]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
641 stripped[lineno - 1] = withoutComment.rstrip()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
642
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
643 # perform check with 'cleaned' source
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
644 for lineIndex, line in enumerate(stripped):
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
645 strippedLine = line.strip()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
646 if strippedLine.endswith("\\") and not strippedLine.startswith(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
647 ("assert", "with")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
648 ):
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
649 self.__error(lineIndex, len(line), "M841")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
650
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
651 def __checkPrintStatements(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
652 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
653 Private method to check for print statements.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
654 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
655 for node in ast.walk(self.__tree):
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
656 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
657 isinstance(node, ast.Call) and getattr(node.func, "id", None) == "print"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
658 ) or (hasattr(ast, "Print") and isinstance(node, ast.Print)):
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
659 self.__error(node.lineno - 1, node.col_offset, "M801")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
660
4507
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
661 def __checkTuple(self):
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
662 """
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
663 Private method to check for one element tuples.
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
664 """
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
665 for node in ast.walk(self.__tree):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
666 if isinstance(node, ast.Tuple) and len(node.elts) == 1:
4507
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
667 self.__error(node.lineno - 1, node.col_offset, "M811")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
668
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
669 def __checkFuture(self):
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
670 """
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
671 Private method to check the __future__ imports.
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
672 """
5588
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
673 expectedImports = {
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
674 i.strip()
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
675 for i in self.__args.get("FutureChecker", "").split(",")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
676 if bool(i.strip())
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
677 }
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
678 if len(expectedImports) == 0:
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
679 # nothing to check for; disabling the check
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
680 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
681
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
682 imports = set()
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
683 node = None
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
684 hasCode = False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
685
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
686 for node in ast.walk(self.__tree):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
687 if isinstance(node, ast.ImportFrom) and node.module == "__future__":
5588
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
688 imports |= {name.name for name in node.names}
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
689 elif isinstance(node, ast.Expr):
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
690 if not AstUtilities.isString(node.value):
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
691 hasCode = True
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
692 break
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
693 elif not (AstUtilities.isString(node) or isinstance(node, ast.Module)):
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
694 hasCode = True
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
695 break
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
696
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
697 if isinstance(node, ast.Module) or not hasCode:
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
698 return
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
699
8205
4a0f1f896341 Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8198
diff changeset
700 if imports < expectedImports:
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
701 if imports:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
702 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
703 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
704 node.col_offset,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
705 "M701",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
706 ", ".join(expectedImports),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
707 ", ".join(imports),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
708 )
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
709 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
710 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
711 node.lineno - 1, node.col_offset, "M702", ", ".join(expectedImports)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
712 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
713
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
714 def __checkPep3101(self):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
715 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
716 Private method to check for old style string formatting.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
717 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
718 for lineno, line in enumerate(self.__source):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
719 match = self.__pep3101FormatRegex.search(line)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
720 if match:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
721 lineLen = len(line)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
722 pos = line.find("%")
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
723 formatPos = pos
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
724 formatter = "%"
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
725 if line[pos + 1] == "(":
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
726 pos = line.find(")", pos)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
727 c = line[pos]
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
728 while c not in "diouxXeEfFgGcrs":
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
729 pos += 1
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
730 if pos >= lineLen:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
731 break
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
732 c = line[pos]
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
733 if c in "diouxXeEfFgGcrs":
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
734 formatter += c
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
735 self.__error(lineno, formatPos, "M601", formatter)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
736
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
737 def __checkFormatString(self):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
738 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
739 Private method to check string format strings.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
740 """
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
741 coding = self.__getCoding()[1]
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
742 if not coding:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
743 # default to utf-8
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
744 coding = "utf-8"
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
745
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
746 visitor = TextVisitor()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
747 visitor.visit(self.__tree)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
748 for node in visitor.nodes:
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
749 text = node.value
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
750 if isinstance(text, bytes):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
751 try:
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
752 text = text.decode(coding)
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
753 except UnicodeDecodeError:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
754 continue
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
755 fields, implicit, explicit = self.__getFields(text)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
756 if implicit:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
757 if node in visitor.calls:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
758 self.__error(node.lineno - 1, node.col_offset, "M611")
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
759 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
760 if node.is_docstring:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
761 self.__error(node.lineno - 1, node.col_offset, "M612")
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
762 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
763 self.__error(node.lineno - 1, node.col_offset, "M613")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
764
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
765 if node in visitor.calls:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
766 call, strArgs = visitor.calls[node]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
767
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
768 numbers = set()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
769 names = set()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
770 # Determine which fields require a keyword and which an arg
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
771 for name in fields:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
772 fieldMatch = self.FormatFieldRegex.match(name)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
773 try:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
774 number = int(fieldMatch.group(1))
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
775 except ValueError:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
776 number = -1
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
777 # negative numbers are considered keywords
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
778 if number >= 0:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
779 numbers.add(number)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
780 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
781 names.add(fieldMatch.group(1))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
782
5588
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
783 keywords = {keyword.arg for keyword in call.keywords}
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
784 numArgs = len(call.args)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
785 if strArgs:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
786 numArgs -= 1
7894
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
787 hasKwArgs = any(kw.arg is None for kw in call.keywords)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
788 hasStarArgs = sum(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
789 1 for arg in call.args if isinstance(arg, ast.Starred)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
790 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
791
7894
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
792 if hasKwArgs:
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
793 keywords.discard(None)
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
794 if hasStarArgs:
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
795 numArgs -= 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
796
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
797 # if starargs or kwargs is not None, it can't count the
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
798 # parameters but at least check if the args are used
8222
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
799 if hasKwArgs and not names:
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
800 # No names but kwargs
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
801 self.__error(call.lineno - 1, call.col_offset, "M623")
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
802 if hasStarArgs and not numbers:
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
803 # No numbers but args
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
804 self.__error(call.lineno - 1, call.col_offset, "M624")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
805
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
806 if not hasKwArgs and not hasStarArgs:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
807 # can actually verify numbers and names
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
808 for number in sorted(numbers):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
809 if number >= numArgs:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
810 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
811 call.lineno - 1, call.col_offset, "M621", number
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
812 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
813
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
814 for name in sorted(names):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
815 if name not in keywords:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
816 self.__error(call.lineno - 1, call.col_offset, "M622", name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
817
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
818 for arg in range(numArgs):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
819 if arg not in numbers:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
820 self.__error(call.lineno - 1, call.col_offset, "M631", arg)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
821
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
822 for keyword in keywords:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
823 if keyword not in names:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
824 self.__error(call.lineno - 1, call.col_offset, "M632", keyword)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
825
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
826 if implicit and explicit:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
827 self.__error(call.lineno - 1, call.col_offset, "M625")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
828
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
829 def __getFields(self, string):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
830 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
831 Private method to extract the format field information.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
832
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
833 @param string format string to be parsed
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
834 @type str
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
835 @return format field information as a tuple with fields, implicit
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
836 field definitions present and explicit field definitions present
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
837 @rtype tuple of set of str, bool, bool
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
838 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
839 fields = set()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
840 cnt = itertools.count()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
841 implicit = False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
842 explicit = False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
843 try:
6188
5a6ae3be31e6 Fixed some loop related coding issues detected by the extended code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6184
diff changeset
844 for _literal, field, spec, conv in self.Formatter.parse(string):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
845 if field is not None and (conv is None or conv in "rsa"):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
846 if not field:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
847 field = str(next(cnt))
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
848 implicit = True
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
849 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
850 explicit = True
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
851 fields.add(field)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
852 fields.update(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
853 parsedSpec[1]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
854 for parsedSpec in self.Formatter.parse(spec)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
855 if parsedSpec[1] is not None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
856 )
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
857 except ValueError:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
858 return set(), False, False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
859 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
860 return fields, implicit, explicit
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
861
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
862 def __checkBuiltins(self):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
863 """
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
864 Private method to check, if built-ins are shadowed.
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
865 """
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
866 functionDefs = [ast.FunctionDef]
8243
cc717c2ae956 Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8228
diff changeset
867 with contextlib.suppress(AttributeError):
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
868 functionDefs.append(ast.AsyncFunctionDef)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
869
5619
ab999dc48132 Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5617
diff changeset
870 ignoreBuiltinAssignments = self.__args.get(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
871 "BuiltinsChecker", MiscellaneousCheckerDefaultArgs["BuiltinsChecker"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
872 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
873
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
874 for node in ast.walk(self.__tree):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
875 if isinstance(node, ast.Assign):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
876 # assign statement
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
877 for element in node.targets:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
878 if isinstance(element, ast.Name) and element.id in self.__builtins:
5617
1b9e3d94864a Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5589
diff changeset
879 value = node.value
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
880 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
881 isinstance(value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
882 and element.id in ignoreBuiltinAssignments
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
883 and value.id in ignoreBuiltinAssignments[element.id]
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
884 ):
5617
1b9e3d94864a Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5589
diff changeset
885 # ignore compatibility assignments
1b9e3d94864a Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5589
diff changeset
886 continue
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
887 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
888 element.lineno - 1, element.col_offset, "M131", element.id
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
889 )
5589
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
890 elif isinstance(element, (ast.Tuple, ast.List)):
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
891 for tupleElement in element.elts:
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
892 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
893 isinstance(tupleElement, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
894 and tupleElement.id in self.__builtins
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
895 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
896 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
897 tupleElement.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
898 tupleElement.col_offset,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
899 "M131",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
900 tupleElement.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
901 )
5589
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
902 elif isinstance(node, ast.For):
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
903 # for loop
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
904 target = node.target
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
905 if isinstance(target, ast.Name) and target.id in self.__builtins:
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
906 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
907 target.lineno - 1, target.col_offset, "M131", target.id
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
908 )
5589
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
909 elif isinstance(target, (ast.Tuple, ast.List)):
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
910 for element in target.elts:
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
911 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
912 isinstance(element, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
913 and element.id in self.__builtins
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
914 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
915 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
916 element.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
917 element.col_offset,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
918 "M131",
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
919 element.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
920 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
921 elif any(isinstance(node, functionDef) for functionDef in functionDefs):
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
922 # (asynchronous) function definition
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
923 for arg in node.args.args:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
924 if isinstance(arg, ast.arg) and arg.arg in self.__builtins:
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
925 self.__error(arg.lineno - 1, arg.col_offset, "M132", arg.arg)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
926
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
927 def __checkComprehensions(self):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
928 """
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
929 Private method to check some comprehension related things.
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
930
11134
3243a66db84a Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
931 This method is adapted from: flake8-comprehensions v3.16.0
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
932 Original: Copyright (c) 2017 Adam Johnson
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
933 """
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
934 compType = {
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
935 ast.DictComp: "dict",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
936 ast.ListComp: "list",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
937 ast.SetComp: "set",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
938 }
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
939
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
940 visitedMapCalls = set()
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
941
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
942 for node in ast.walk(self.__tree):
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
943 if isinstance(node, ast.Call) and isinstance(node.func, ast.Name):
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
944 numPositionalArgs = len(node.args)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
945 numKeywordArgs = len(node.keywords)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
946
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
947 if (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
948 numPositionalArgs == 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
949 and isinstance(node.args[0], ast.GeneratorExp)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
950 and node.func.id in ("list", "set")
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
951 ):
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
952 errorCode = {
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
953 "list": "M180",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
954 "set": "M181",
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
955 }[node.func.id]
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
956 self.__error(node.lineno - 1, node.col_offset, errorCode)
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
957
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
958 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
959 numPositionalArgs == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
960 and node.func.id == "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
961 and len(node.keywords) == 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
962 and isinstance(node.args[0], (ast.GeneratorExp, ast.ListComp))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
963 and isinstance(node.args[0].elt, ast.Tuple)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
964 and len(node.args[0].elt.elts) == 2
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
965 ):
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
966 if isinstance(node.args[0], ast.GeneratorExp):
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
967 errorCode = "M182"
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
968 else:
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
969 errorCode = "M184"
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
970 self.__error(node.lineno - 1, node.col_offset, errorCode)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
971
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
972 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
973 numPositionalArgs == 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
974 and isinstance(node.args[0], ast.ListComp)
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
975 and node.func.id in ("list", "set", "any", "all")
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
976 ):
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
977 errorCode = {
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
978 "list": "M191",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
979 "set": "M183",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
980 "any": "M199",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
981 "all": "M199",
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
982 }[node.func.id]
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
983 self.__error(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
984 node.lineno - 1, node.col_offset, errorCode, node.func.id
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
985 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
986
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
987 elif numPositionalArgs == 1 and (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
988 isinstance(node.args[0], ast.Tuple)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
989 and node.func.id == "tuple"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
990 or isinstance(node.args[0], ast.List)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
991 and node.func.id == "list"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
992 ):
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
993 errorCode = {
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
994 "tuple": "M189a",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
995 "list": "M190a",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
996 }[node.func.id]
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
997 self.__error(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
998 node.lineno - 1,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
999 node.col_offset,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1000 errorCode,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1001 type(node.args[0]).__name__.lower(),
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1002 node.func.id,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1003 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1004
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1005 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1006 numPositionalArgs == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1007 and numKeywordArgs == 0
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1008 and isinstance(node.args[0], (ast.Dict, ast.DictComp))
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1009 and node.func.id == "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1010 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1011 if isinstance(node.args[0], ast.Dict):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1012 type_ = "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1013 else:
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1014 type_ = "dict comprehension"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1015 self.__error(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1016 node.lineno - 1,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1017 node.col_offset,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1018 "M198",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1019 type_,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1020 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1021
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1022 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1023 numPositionalArgs == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1024 and isinstance(node.args[0], (ast.Tuple, ast.List))
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1025 and (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1026 node.func.id in ("tuple", "list", "set")
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1027 or (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1028 node.func.id == "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1029 and all(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1030 isinstance(elt, ast.Tuple) and len(elt.elts) == 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1031 for elt in node.args[0].elts
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1032 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1033 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1034 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1035 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1036 errorCode = {
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1037 "tuple": "M189b",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1038 "list": "M190b",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1039 "set": "M185",
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1040 "dict": "M186",
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1041 }[node.func.id]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1042 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1043 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1044 node.col_offset,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1045 errorCode,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1046 type(node.args[0]).__name__.lower(),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1047 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1048 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1049
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1050 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1051 numPositionalArgs == 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1052 and not any(isinstance(a, ast.Starred) for a in node.args)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1053 and not any(k.arg is None for k in node.keywords)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1054 and node.func.id == "dict"
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1055 ) or (
10371
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1056 numPositionalArgs == 0
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1057 and numKeywordArgs == 0
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1058 and node.func.id in ("tuple", "list")
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1059 ):
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1060 self.__error(node.lineno - 1, node.col_offset, "M188", node.func.id)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1061
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1062 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1063 node.func.id in {"list", "reversed"}
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1064 and numPositionalArgs > 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1065 and isinstance(node.args[0], ast.Call)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1066 and isinstance(node.args[0].func, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1067 and node.args[0].func.id == "sorted"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1068 ):
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1069 if node.func.id == "reversed":
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1070 reverseFlagValue = False
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1071 for kw in node.args[0].keywords:
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1072 if kw.arg != "reverse":
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1073 continue
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1074 reverseFlagValue = (
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1075 bool(kw.value.value)
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1076 if isinstance(kw.value, ast.Constant)
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1077 else None
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1078 )
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1079
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1080 if reverseFlagValue is None:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1081 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1082 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1083 node.col_offset,
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1084 "M193a",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1085 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1086 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1087 )
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1088 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1089 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1090 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1091 node.col_offset,
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1092 "M193b",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1093 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1094 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1095 not reverseFlagValue,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1096 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1097
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1098 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1099 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1100 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1101 node.col_offset,
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1102 "M193c",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1103 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1104 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1105 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1106
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1107 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1108 numPositionalArgs > 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1109 and isinstance(node.args[0], ast.Call)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1110 and isinstance(node.args[0].func, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1111 and (
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1112 (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1113 node.func.id in {"set", "sorted"}
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1114 and node.args[0].func.id
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1115 in {"list", "reversed", "sorted", "tuple"}
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1116 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1117 or (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1118 node.func.id in {"list", "tuple"}
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1119 and node.args[0].func.id in {"list", "tuple"}
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1120 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1121 or (node.func.id == "set" and node.args[0].func.id == "set")
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1122 )
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1123 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1124 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1125 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1126 node.col_offset,
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1127 "M194",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1128 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1129 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1130 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1131
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1132 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1133 node.func.id in {"reversed", "set", "sorted"}
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1134 and numPositionalArgs > 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1135 and isinstance(node.args[0], ast.Subscript)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1136 and isinstance(node.args[0].slice, ast.Slice)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1137 and node.args[0].slice.lower is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1138 and node.args[0].slice.upper is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1139 and isinstance(node.args[0].slice.step, ast.UnaryOp)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1140 and isinstance(node.args[0].slice.step.op, ast.USub)
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1141 and isinstance(node.args[0].slice.step.operand, ast.Constant)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1142 and node.args[0].slice.step.operand.n == 1
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1143 ):
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1144 self.__error(node.lineno - 1, node.col_offset, "M195", node.func.id)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1145
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1146 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1147 node.func.id == "map"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1148 and node not in visitedMapCalls
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1149 and len(node.args) == 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1150 and isinstance(node.args[0], ast.Lambda)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1151 ):
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1152 self.__error(
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1153 node.lineno - 1, node.col_offset, "M197", "generator expression"
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1154 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1155
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1156 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1157 node.func.id in ("list", "set", "dict")
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1158 and len(node.args) == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1159 and isinstance(node.args[0], ast.Call)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1160 and isinstance(node.args[0].func, ast.Name)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1161 and node.args[0].func.id == "map"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1162 and len(node.args[0].args) == 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1163 and isinstance(node.args[0].args[0], ast.Lambda)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1164 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1165 # To avoid raising M197 on the map() call inside the list/set/dict.
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1166 mapCall = node.args[0]
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1167 visitedMapCalls.add(mapCall)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1168
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1169 rewriteable = True
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1170 if node.func.id == "dict":
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1171 # For the generator expression to be rewriteable as a
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1172 # dict comprehension, its lambda must return a 2-tuple.
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1173 lambdaNode = node.args[0].args[0]
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1174 if (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1175 not isinstance(lambdaNode.body, (ast.List, ast.Tuple))
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1176 or len(lambdaNode.body.elts) != 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1177 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1178 rewriteable = False
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1179
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1180 if rewriteable:
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1181 comprehensionType = f"{node.func.id} comprehension"
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1182 self.__error(
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1183 node.lineno - 1, node.col_offset, "M197", comprehensionType
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1184 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1185
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1186 elif isinstance(node, (ast.DictComp, ast.ListComp, ast.SetComp)) and (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1187 len(node.generators) == 1
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1188 and not node.generators[0].ifs
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1189 and not node.generators[0].is_async
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1190 ):
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1191 if (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1192 isinstance(node, (ast.ListComp, ast.SetComp))
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1193 and isinstance(node.elt, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1194 and isinstance(node.generators[0].target, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1195 and node.elt.id == node.generators[0].target.id
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1196 ) or (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1197 isinstance(node, ast.DictComp)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1198 and isinstance(node.key, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1199 and isinstance(node.value, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1200 and isinstance(node.generators[0].target, ast.Tuple)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1201 and len(node.generators[0].target.elts) == 2
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1202 and isinstance(node.generators[0].target.elts[0], ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1203 and node.generators[0].target.elts[0].id == node.key.id
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1204 and isinstance(node.generators[0].target.elts[1], ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1205 and node.generators[0].target.elts[1].id == node.value.id
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1206 ):
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1207 self.__error(
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1208 node.lineno - 1,
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1209 node.col_offset,
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1210 "M196",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1211 compType[node.__class__],
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1212 )
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1213
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1214 elif (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1215 isinstance(node, ast.DictComp)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1216 and isinstance(node.key, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1217 and isinstance(node.value, ast.Constant)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1218 and isinstance(node.generators[0].target, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1219 and node.key.id == node.generators[0].target.id
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1220 ):
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1221 self.__error(
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1222 node.lineno - 1,
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1223 node.col_offset,
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1224 "M200",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1225 compType[node.__class__],
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1226 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1227
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1228 def __dictShouldBeChecked(self, node):
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1229 """
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1230 Private function to test, if the node should be checked.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1231
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1232 @param node reference to the AST node
10437
2f70ca07f0af Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10417
diff changeset
1233 @type ast.Dict
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1234 @return flag indicating to check the node
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1235 @rtype bool
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1236 """
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1237 if not all(AstUtilities.isString(key) for key in node.keys):
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1238 return False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1239
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
1240 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1241 "__IGNORE_WARNING__" in self.__source[node.lineno - 1]
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1242 or "__IGNORE_WARNING_M251__" in self.__source[node.lineno - 1]
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
1243 ):
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1244 return False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1245
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1246 lineNumbers = [key.lineno for key in node.keys]
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1247 return len(lineNumbers) == len(set(lineNumbers))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1248
6177
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1249 def __checkDictWithSortedKeys(self):
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1250 """
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1251 Private method to check, if dictionary keys appear in sorted order.
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1252 """
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1253 for node in ast.walk(self.__tree):
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1254 if isinstance(node, ast.Dict) and self.__dictShouldBeChecked(node):
6177
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1255 for key1, key2 in zip(node.keys, node.keys[1:]):
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1256 if key2.value < key1.value:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1257 self.__error(
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1258 key2.lineno - 1,
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1259 key2.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1260 "M251",
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1261 key2.value,
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1262 key1.value,
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1263 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1264
6182
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1265 def __checkGettext(self):
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1266 """
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1267 Private method to check the 'gettext' import statement.
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1268 """
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1269 for node in ast.walk(self.__tree):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1270 if isinstance(node, ast.ImportFrom) and any(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1271 name.asname == "_" for name in node.names
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
1272 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1273 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1274 node.lineno - 1, node.col_offset, "M711", node.names[0].name
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1275 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1276
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1277 def __checkBugBear(self):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1278 """
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
1279 Private method for bugbear checks.
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1280 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1281 visitor = BugBearVisitor()
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1282 visitor.visit(self.__tree)
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1283 for violation in visitor.violations:
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1284 node = violation[0]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1285 reason = violation[1]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1286 params = violation[2:]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1287 self.__error(node.lineno - 1, node.col_offset, reason, *params)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1288
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1289 def __checkReturn(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1290 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1291 Private method to check return statements.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1292 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1293 visitor = ReturnVisitor()
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1294 visitor.visit(self.__tree)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1295 for violation in visitor.violations:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1296 node = violation[0]
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1297 reason = violation[1]
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1298 self.__error(node.lineno - 1, node.col_offset, reason)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1299
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1300 def __checkDateTime(self):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1301 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1302 Private method to check use of naive datetime functions.
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1303 """
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1304 # step 1: generate an augmented node tree containing parent info
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1305 # for each child node
8198
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
1306 tree = copy.deepcopy(self.__tree)
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1307 for node in ast.walk(tree):
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1308 for childNode in ast.iter_child_nodes(node):
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1309 childNode._dtCheckerParent = node
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1310
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1311 # step 2: perform checks and report issues
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1312 visitor = DateTimeVisitor()
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1313 visitor.visit(tree)
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1314 for violation in visitor.violations:
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1315 node = violation[0]
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1316 reason = violation[1]
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1317 self.__error(node.lineno - 1, node.col_offset, reason)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1318
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1319 def __checkSysVersion(self):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1320 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1321 Private method to check the use of sys.version and sys.version_info.
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1322 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1323 visitor = SysVersionVisitor()
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1324 visitor.visit(self.__tree)
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1325 for violation in visitor.violations:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1326 node = violation[0]
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1327 reason = violation[1]
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1328 self.__error(node.lineno - 1, node.col_offset, reason)
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1329
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1330 def __checkProperties(self):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1331 """
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1332 Private method to check for issue with property related methods.
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1333 """
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1334 properties = []
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1335 for node in ast.walk(self.__tree):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1336 if isinstance(node, ast.ClassDef):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1337 properties.clear()
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1338
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1339 elif isinstance(node, ast.FunctionDef):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1340 propertyCount = 0
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1341 for decorator in node.decorator_list:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1342 # property getter method
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1343 if isinstance(decorator, ast.Name) and decorator.id == "property":
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1344 propertyCount += 1
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1345 properties.append(node.name)
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1346 if len(node.args.args) != 1:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1347 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1348 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1349 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1350 "M260",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1351 len(node.args.args),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1352 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1353
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1354 if isinstance(decorator, ast.Attribute):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1355 # property setter method
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1356 if decorator.attr == "setter":
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1357 propertyCount += 1
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1358 if node.name != decorator.value.id:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1359 if node.name in properties:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1360 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1361 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1362 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1363 "M265",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1364 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1365 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1366 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1367 else:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1368 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1369 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1370 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1371 "M263",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1372 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1373 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1374 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1375 if len(node.args.args) != 2:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1376 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1377 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1378 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1379 "M261",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1380 len(node.args.args),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1381 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1382
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1383 # property deleter method
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1384 if decorator.attr == "deleter":
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1385 propertyCount += 1
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1386 if node.name != decorator.value.id:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1387 if node.name in properties:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1388 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1389 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1390 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1391 "M266",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1392 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1393 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1394 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1395 else:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1396 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1397 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1398 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1399 "M264",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1400 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1401 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1402 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1403 if len(node.args.args) != 1:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1404 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1405 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1406 node.col_offset,
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1407 "M262",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1408 len(node.args.args),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1409 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1410
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1411 if propertyCount > 1:
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1412 self.__error(node.lineno - 1, node.col_offset, "M267", node.name)
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1413
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1414 #######################################################################
10362
cfa7034cccf6 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10361
diff changeset
1415 ## The following methods check for implicitly concatenated strings.
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1416 ##
10997
d470b58626d2 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10884
diff changeset
1417 ## These methods are adapted from: flake8-implicit-str-concat v0.5.0
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1418 ## Original: Copyright (c) 2023 Dylan Turner
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1419 #######################################################################
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1420
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1421 if sys.version_info < (3, 12):
10371
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1422
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1423 def __isImplicitStringConcat(self, first, second):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1424 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1425 Private method to check, if the given strings indicate an implicit string
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1426 concatenation.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1427
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1428 @param first first token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1429 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1430 @param second second token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1431 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1432 @return flag indicating an implicit string concatenation
10437
2f70ca07f0af Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10417
diff changeset
1433 @rtype bool
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1434 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1435 return first.type == second.type == tokenize.STRING
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1436
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1437 else:
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1438
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1439 def __isImplicitStringConcat(self, first, second):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1440 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1441 Private method to check, if the given strings indicate an implicit string
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1442 concatenation.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1443
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1444 @param first first token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1445 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1446 @param second second token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1447 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1448 @return flag indicating an implicit string concatenation
10437
2f70ca07f0af Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10417
diff changeset
1449 @rtype bool
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1450 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1451 return (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1452 (first.type == second.type == tokenize.STRING)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1453 or (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1454 first.type == tokenize.STRING
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1455 and second.type == tokenize.FSTRING_START
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1456 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1457 or (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1458 first.type == tokenize.FSTRING_END
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1459 and second.type == tokenize.STRING
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1460 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1461 or (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1462 first.type == tokenize.FSTRING_END
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1463 and second.type == tokenize.FSTRING_START
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1464 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1465 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1466
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1467 def __checkImplicitStringConcat(self):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1468 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1469 Private method to check for implicitly concatenated strings.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1470 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1471 tokensWithoutWhitespace = (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1472 tok
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1473 for tok in self.__tokens
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1474 if tok.type
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1475 not in (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1476 tokenize.NL,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1477 tokenize.NEWLINE,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1478 tokenize.INDENT,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1479 tokenize.DEDENT,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1480 tokenize.COMMENT,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1481 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1482 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1483 for a, b in pairwise(tokensWithoutWhitespace):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1484 if self.__isImplicitStringConcat(a, b):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1485 self.__error(
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1486 a.end[0] - 1, a.end[1], "M851" if a.end[0] == b.start[0] else "M852"
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1487 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1488
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1489 def __checkExplicitStringConcat(self):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1490 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1491 Private method to check for explicitly concatenated strings.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1492 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1493 for node in ast.walk(self.__tree):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1494 if (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1495 isinstance(node, ast.BinOp)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1496 and isinstance(node.op, ast.Add)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1497 and all(
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1498 AstUtilities.isBaseString(operand)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1499 or isinstance(operand, ast.JoinedStr)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1500 for operand in (node.left, node.right)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1501 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1502 ):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1503 self.__error(node.lineno - 1, node.col_offset, "M853")
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1504
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1505
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1506 class TextVisitor(ast.NodeVisitor):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1507 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1508 Class implementing a node visitor for bytes and str instances.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1509
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1510 It tries to detect docstrings as string of the first expression of each
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1511 module, class or function.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1512 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1513
9274
86fab0c74430 Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9221
diff changeset
1514 # modeled after the string format flake8 extension
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1515
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1516 def __init__(self):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1517 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1518 Constructor
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1519 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1520 super().__init__()
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1521 self.nodes = []
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1522 self.calls = {}
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1523
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1524 def __addNode(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1525 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1526 Private method to add a node to our list of nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1527
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1528 @param node reference to the node to add
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1529 @type ast.AST
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1530 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1531 if not hasattr(node, "is_docstring"):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1532 node.is_docstring = False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1533 self.nodes.append(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1534
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1535 def visit_Constant(self, node):
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1536 """
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1537 Public method to handle constant nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1538
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1539 @param node reference to the bytes node
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1540 @type ast.Constant
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1541 """
10119
64147a7e6393 Removed support for Python 3.7 because that is EOL.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10085
diff changeset
1542 if AstUtilities.isBaseString(node):
64147a7e6393 Removed support for Python 3.7 because that is EOL.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10085
diff changeset
1543 self.__addNode(node)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1544 else:
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1545 super().generic_visit(node)
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1546
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1547 def __visitDefinition(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1548 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1549 Private method handling class and function definitions.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1550
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1551 @param node reference to the node to handle
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1552 @type ast.FunctionDef, ast.AsyncFunctionDef or ast.ClassDef
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1553 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1554 # Manually traverse class or function definition
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1555 # * Handle decorators normally
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1556 # * Use special check for body content
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1557 # * Don't handle the rest (e.g. bases)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1558 for decorator in node.decorator_list:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1559 self.visit(decorator)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1560 self.__visitBody(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1561
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1562 def __visitBody(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1563 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1564 Private method to traverse the body of the node manually.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1565
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1566 If the first node is an expression which contains a string or bytes it
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1567 marks that as a docstring.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1568
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1569 @param node reference to the node to traverse
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1570 @type ast.AST
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1571 """
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1572 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1573 node.body
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1574 and isinstance(node.body[0], ast.Expr)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1575 and AstUtilities.isBaseString(node.body[0].value)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1576 ):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1577 node.body[0].value.is_docstring = True
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1578
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1579 for subnode in node.body:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1580 self.visit(subnode)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1581
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1582 def visit_Module(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1583 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1584 Public method to handle a module.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1585
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1586 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1587 @type ast.Module
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1588 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1589 self.__visitBody(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1590
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1591 def visit_ClassDef(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1592 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1593 Public method to handle a class definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1594
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1595 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1596 @type ast.ClassDef
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1597 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1598 # Skipped nodes: ('name', 'bases', 'keywords', 'starargs', 'kwargs')
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1599 self.__visitDefinition(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1600
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1601 def visit_FunctionDef(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1602 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1603 Public method to handle a function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1604
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1605 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1606 @type ast.FunctionDef
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1607 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1608 # Skipped nodes: ('name', 'args', 'returns')
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1609 self.__visitDefinition(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1610
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1611 def visit_AsyncFunctionDef(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1612 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1613 Public method to handle an asynchronous function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1614
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1615 @param node reference to the node to handle
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1616 @type ast.AsyncFunctionDef
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1617 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1618 # Skipped nodes: ('name', 'args', 'returns')
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1619 self.__visitDefinition(node)
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1620
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1621 def visit_Call(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1622 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1623 Public method to handle a function call.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1624
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1625 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1626 @type ast.Call
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1627 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1628 if isinstance(node.func, ast.Attribute) and node.func.attr == "format":
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1629 if AstUtilities.isBaseString(node.func.value):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1630 self.calls[node.func.value] = (node, False)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1631 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1632 isinstance(node.func.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1633 and node.func.value.id == "str"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1634 and node.args
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1635 and AstUtilities.isBaseString(node.args[0])
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1636 ):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1637 self.calls[node.args[0]] = (node, True)
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1638 super().generic_visit(node)
4555
861e1741985c Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents: 4540
diff changeset
1639
6180
8d72871c16ba Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6178
diff changeset
1640
10175
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1641 #######################################################################
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1642 ## BugBearVisitor
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1643 ##
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1644 ## adapted from: flake8-bugbear v24.12.12
10175
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1645 ##
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1646 ## Original: Copyright (c) 2016 Łukasz Langa
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1647 #######################################################################
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1648
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1649 BugBearContext = namedtuple("BugBearContext", ["node", "stack"])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1650
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
1651
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1652 @dataclass
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1653 class M540CaughtException:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1654 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1655 Class to hold the data for a caught exception.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1656 """
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
1657
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
1658 name: str
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1659 hasNote: bool
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1660
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1661
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1662 class M541UnhandledKeyType:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1663 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1664 Class to hold a dictionary key of a type that we do not check for duplicates.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1665 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1666
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1667
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1668 class M541VariableKeyType:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1669 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1670 Class to hold the name of a variable key type.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1671 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1672
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1673 def __init__(self, name):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1674 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1675 Constructor
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1676
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1677 @param name name of the variable key type
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1678 @type str
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1679 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1680 self.name = name
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1681
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1682
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1683 class BugBearVisitor(ast.NodeVisitor):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1684 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1685 Class implementing a node visitor to check for various topics.
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1686 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1687
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1688 CONTEXTFUL_NODES = (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1689 ast.Module,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1690 ast.ClassDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1691 ast.AsyncFunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1692 ast.FunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1693 ast.Lambda,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1694 ast.ListComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1695 ast.SetComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1696 ast.DictComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1697 ast.GeneratorExp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1698 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1699
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1700 FUNCTION_NODES = (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1701 ast.AsyncFunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1702 ast.FunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1703 ast.Lambda,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1704 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1705
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1706 NodeWindowSize = 4
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1707
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1708 def __init__(self):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1709 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1710 Constructor
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1711 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1712 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1713
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1714 self.nodeWindow = []
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1715 self.violations = []
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1716 self.contexts = []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1717
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1718 self.__M523Seen = set()
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1719 self.__M505Imports = set()
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1720 self.__M540CaughtException = None
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1721
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1722 self.__inTryStar = ""
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1723
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1724 @property
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1725 def nodeStack(self):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1726 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1727 Public method to get a reference to the most recent node stack.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1728
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1729 @return reference to the most recent node stack
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1730 @rtype list
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1731 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1732 if len(self.contexts) == 0:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1733 return []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1734
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1735 context, stack = self.contexts[-1]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1736 return stack
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1737
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1738 def __isIdentifier(self, arg):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1739 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1740 Private method to check if arg is a valid identifier.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1741
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1742 See https://docs.python.org/2/reference/lexical_analysis.html#identifiers
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1743
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1744 @param arg reference to an argument node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1745 @type ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1746 @return flag indicating a valid identifier
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1747 @rtype TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1748 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1749 if not AstUtilities.isString(arg):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1750 return False
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1751
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1752 return (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1753 re.match(r"^[A-Za-z_][A-Za-z0-9_]*$", AstUtilities.getValue(arg))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1754 is not None
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1755 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1756
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1757 def toNameStr(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1758 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1759 Public method to turn Name and Attribute nodes to strings, handling any
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1760 depth of attribute accesses.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1761
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1762
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1763 @param node reference to the node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1764 @type ast.Name or ast.Attribute
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1765 @return string representation
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1766 @rtype str
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1767 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1768 if isinstance(node, ast.Name):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1769 return node.id
10516
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1770 elif isinstance(node, ast.Call):
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1771 return self.toNameStr(node.func)
10516
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1772 elif isinstance(node, ast.Attribute):
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1773 inner = self.toNameStr(node.value)
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1774 if inner is None:
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1775 return None
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1776 return f"{inner}.{node.attr}"
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1777 else:
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1778 return None
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1779
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1780 def __typesafeIssubclass(self, obj, classOrTuple):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1781 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1782 Private method implementing a type safe issubclass() function.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1783
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1784 @param obj reference to the object to be tested
10417
c6011e501282 Modernized some code and converted Debug Client and Debugger source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10371
diff changeset
1785 @type Any
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1786 @param classOrTuple type to check against
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1787 @type type
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1788 @return flag indicating a subclass
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1789 @rtype bool
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1790 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1791 try:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1792 return issubclass(obj, classOrTuple)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1793 except TypeError:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1794 # User code specifies a type that is not a type in our current run.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1795 # Might be their error, might be a difference in our environments.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1796 # We don't know so we ignore this.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1797 return False
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1798
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1799 def __getAssignedNames(self, loopNode):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1800 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1801 Private method to get the names of a for loop.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1802
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1803 @param loopNode reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1804 @type ast.For
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1805 @yield DESCRIPTION
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1806 @ytype TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1807 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1808 loopTargets = (ast.For, ast.AsyncFor, ast.comprehension)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1809 for node in self.__childrenInScope(loopNode):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1810 if isinstance(node, (ast.Assign)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1811 for child in node.targets:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1812 yield from self.__namesFromAssignments(child)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1813 if isinstance(node, loopTargets + (ast.AnnAssign, ast.AugAssign)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1814 yield from self.__namesFromAssignments(node.target)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1815
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1816 def __namesFromAssignments(self, assignTarget):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1817 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1818 Private method to get names of an assignment.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1819
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1820 @param assignTarget reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1821 @type ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1822 @yield name of the assignment
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1823 @ytype str
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1824 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1825 if isinstance(assignTarget, ast.Name):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1826 yield assignTarget.id
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1827 elif isinstance(assignTarget, ast.Starred):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1828 yield from self.__namesFromAssignments(assignTarget.value)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1829 elif isinstance(assignTarget, (ast.List, ast.Tuple)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1830 for child in assignTarget.elts:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1831 yield from self.__namesFromAssignments(child)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1832
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1833 def __childrenInScope(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1834 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1835 Private method to get all child nodes in the given scope.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1836
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1837 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1838 @type ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1839 @yield reference to a child node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1840 @ytype ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1841 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1842 yield node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1843 if not isinstance(node, BugBearVisitor.FUNCTION_NODES):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1844 for child in ast.iter_child_nodes(node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1845 yield from self.__childrenInScope(child)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1846
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1847 def __flattenExcepthandler(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1848 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1849 Private method to flatten the list of exceptions handled by an except handler.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1850
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1851 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1852 @type ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1853 @yield reference to the exception type node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1854 @ytype ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1855 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1856 if not isinstance(node, ast.Tuple):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1857 yield node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1858 return
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1859
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1860 exprList = node.elts.copy()
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1861 while len(exprList):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1862 expr = exprList.pop(0)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1863 if isinstance(expr, ast.Starred) and isinstance(
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1864 expr.value, (ast.List, ast.Tuple)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1865 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1866 exprList.extend(expr.value.elts)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1867 continue
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1868 yield expr
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1869
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1870 def __checkRedundantExcepthandlers(self, names, node, inTryStar):
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1871 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1872 Private method to check for redundant exception types in an exception handler.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1873
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1874 @param names list of exception types to be checked
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1875 @type list of ast.Name
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1876 @param node reference to the exception handler node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1877 @type ast.ExceptionHandler
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1878 @param inTryStar character indicating an 'except*' handler
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1879 @type str
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1880 @return tuple containing the error data
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1881 @rtype tuple of (ast.Node, str, str, str, str)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1882 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1883 redundantExceptions = {
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1884 "OSError": {
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1885 # All of these are actually aliases of OSError since Python 3.3
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1886 "IOError",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1887 "EnvironmentError",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1888 "WindowsError",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1889 "mmap.error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1890 "socket.error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1891 "select.error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1892 },
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1893 "ValueError": {
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1894 "binascii.Error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1895 },
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1896 }
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1897
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1898 # See if any of the given exception names could be removed, e.g. from:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1899 # (MyError, MyError) # duplicate names
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1900 # (MyError, BaseException) # everything derives from the Base
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1901 # (Exception, TypeError) # builtins where one subclasses another
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1902 # (IOError, OSError) # IOError is an alias of OSError since Python3.3
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1903 # but note that other cases are impractical to handle from the AST.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1904 # We expect this is mostly useful for users who do not have the
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1905 # builtin exception hierarchy memorised, and include a 'shadowed'
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1906 # subtype without realising that it's redundant.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1907 good = sorted(set(names), key=names.index)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1908 if "BaseException" in good:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1909 good = ["BaseException"]
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1910 # Remove redundant exceptions that the automatic system either handles
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1911 # poorly (usually aliases) or can't be checked (e.g. it's not an
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1912 # built-in exception).
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1913 for primary, equivalents in redundantExceptions.items():
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1914 if primary in good:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1915 good = [g for g in good if g not in equivalents]
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1916
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1917 for name, other in itertools.permutations(tuple(good), 2):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1918 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1919 self.__typesafeIssubclass(
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1920 getattr(builtins, name, type), getattr(builtins, other, ())
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1921 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1922 and name in good
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1923 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1924 good.remove(name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1925 if good != names:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1926 desc = good[0] if len(good) == 1 else "({0})".format(", ".join(good))
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1927 as_ = " as " + node.name if node.name is not None else ""
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1928 return (node, "M514", ", ".join(names), as_, desc, inTryStar)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1929
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1930 return None
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1931
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1932 def __walkList(self, nodes):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1933 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1934 Private method to walk a given list of nodes.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1935
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1936 @param nodes list of nodes to walk
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1937 @type list of ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1938 @yield node references as determined by the ast.walk() function
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1939 @ytype ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1940 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1941 for node in nodes:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1942 yield from ast.walk(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1943
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1944 def __getNamesFromTuple(self, node):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1945 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1946 Private method to get the names from an ast.Tuple node.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1947
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1948 @param node ast node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1949 @type ast.Tuple
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1950 @yield names
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1951 @ytype str
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1952 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1953 for dim in node.elts:
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1954 if isinstance(dim, ast.Name):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1955 yield dim.id
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1956 elif isinstance(dim, ast.Tuple):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1957 yield from self.__getNamesFromTuple(dim)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1958
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1959 def __getDictCompLoopAndNamedExprVarNames(self, node):
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1960 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1961 Private method to get the names of comprehension loop variables.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1962
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1963 @param node ast node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1964 @type ast.DictComp
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1965 @yield loop variable names
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1966 @ytype str
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1967 """
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1968 finder = NamedExprFinder()
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1969 for gen in node.generators:
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1970 if isinstance(gen.target, ast.Name):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1971 yield gen.target.id
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1972 elif isinstance(gen.target, ast.Tuple):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1973 yield from self.__getNamesFromTuple(gen.target)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1974
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1975 finder.visit(gen.ifs)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1976
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1977 yield from finder.getNames().keys()
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1978
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1979 def __inClassInit(self):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1980 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1981 Private method to check, if we are inside an '__init__' method.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1982
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1983 @return flag indicating being within the '__init__' method
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1984 @rtype bool
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1985 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1986 return (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1987 len(self.contexts) >= 2
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1988 and isinstance(self.contexts[-2].node, ast.ClassDef)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1989 and isinstance(self.contexts[-1].node, ast.FunctionDef)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1990 and self.contexts[-1].node.name == "__init__"
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1991 )
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1992
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1993 def visit_Return(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1994 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1995 Public method to handle 'Return' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1996
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1997 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1998 @type ast.Return
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1999 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2000 if self.__inClassInit() and node.value is not None:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2001 self.violations.append((node, "M537"))
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2002
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2003 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2004
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2005 def visit_Yield(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2006 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2007 Public method to handle 'Yield' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2008
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2009 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2010 @type ast.Yield
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2011 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2012 if self.__inClassInit():
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2013 self.violations.append((node, "M537"))
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2014
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2015 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2016
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2017 def visit_YieldFrom(self, node) -> None:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2018 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2019 Public method to handle 'YieldFrom' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2020
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2021 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2022 @type ast.YieldFrom
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2023 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2024 if self.__inClassInit():
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2025 self.violations.append((node, "M537"))
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2026
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2027 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2028
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2029 def visit(self, node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2030 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2031 Public method to traverse a given AST node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2032
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2033 @param node AST node to be traversed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2034 @type ast.Node
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2035 """
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2036 isContextful = isinstance(node, BugBearVisitor.CONTEXTFUL_NODES)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2037
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2038 if isContextful:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2039 context = BugBearContext(node, [])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2040 self.contexts.append(context)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2041
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2042 self.nodeStack.append(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2043 self.nodeWindow.append(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2044 self.nodeWindow = self.nodeWindow[-BugBearVisitor.NodeWindowSize :]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2045
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
2046 super().visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2047
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2048 self.nodeStack.pop()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2049
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2050 if isContextful:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2051 self.contexts.pop()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2052
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2053 self.__checkForM518(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2054
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2055 def visit_ExceptHandler(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2056 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2057 Public method to handle exception handlers.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2058
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2059 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2060 @type ast.ExceptHandler
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2061 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2062 if node.type is None:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2063 # bare except is handled by pycodestyle already
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2064 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2065 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2066
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2067 oldM540CaughtException = self.__M540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2068 if node.name is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2069 self.__M540CaughtException = None
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2070 else:
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2071 self.__M540CaughtException = M540CaughtException(node.name, False)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2072
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2073 names = self.__checkForM513_M514_M529_M530(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2074
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2075 if "BaseException" in names and not ExceptBaseExceptionVisitor(node).reRaised():
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2076 self.violations.append((node, "M536"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2077
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2078 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2079
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2080 if (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2081 self.__M540CaughtException is not None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2082 and self.__M540CaughtException.hasNote
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2083 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2084 self.violations.append((node, "M540"))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2085 self.__M540CaughtException = oldM540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2086
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2087 def visit_UAdd(self, node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2088 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2089 Public method to handle unary additions.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2090
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2091 @param node reference to the node to be processed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2092 @type ast.UAdd
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2093 """
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2094 trailingNodes = list(map(type, self.nodeWindow[-4:]))
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2095 if trailingNodes == [ast.UnaryOp, ast.UAdd, ast.UnaryOp, ast.UAdd]:
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2096 originator = self.nodeWindow[-4]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2097 self.violations.append((originator, "M502"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2098
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2099 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2100
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2101 def visit_Call(self, node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2102 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2103 Public method to handle a function call.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2104
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2105 @param node reference to the node to be processed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2106 @type ast.Call
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2107 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2108 isM540AddNote = False
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2109
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2110 if isinstance(node.func, ast.Attribute):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2111 self.__checkForM505(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2112 isM540AddNote = self.__checkForM540AddNote(node.func)
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2113 else:
8243
cc717c2ae956 Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8228
diff changeset
2114 with contextlib.suppress(AttributeError, IndexError):
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2115 # bad super() call
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2116 if isinstance(node.func, ast.Name) and node.func.id == "super":
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2117 args = node.args
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2118 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2119 len(args) == 2
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2120 and isinstance(args[0], ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2121 and isinstance(args[0].value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2122 and args[0].value.id == "self"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2123 and args[0].attr == "__class__"
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2124 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2125 self.violations.append((node, "M582"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2126
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2127 # bad getattr and setattr
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2128 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2129 node.func.id in ("getattr", "hasattr")
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
2130 and node.args[1].value == "__call__"
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2131 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2132 self.violations.append((node, "M504"))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2133 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2134 node.func.id == "getattr"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2135 and len(node.args) == 2
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2136 and self.__isIdentifier(node.args[1])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2137 and iskeyword(AstUtilities.getValue(node.args[1]))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2138 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2139 self.violations.append((node, "M509"))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2140 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2141 node.func.id == "setattr"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2142 and len(node.args) == 3
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2143 and self.__isIdentifier(node.args[1])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2144 and iskeyword(AstUtilities.getValue(node.args[1]))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2145 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2146 self.violations.append((node, "M510"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2147
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2148 self.__checkForM526(node)
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2149
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2150 self.__checkForM528(node)
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2151 self.__checkForM534(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2152 self.__checkForM539(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2153
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2154 # no need for copying, if used in nested calls it will be set to None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2155 currentM540CaughtException = self.__M540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2156 if not isM540AddNote:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2157 self.__checkForM540Usage(node.args)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2158 self.__checkForM540Usage(node.keywords)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2159
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2160 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2161
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2162 if isM540AddNote:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2163 # Avoid nested calls within the parameter list using the variable itself.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2164 # e.g. `e.add_note(str(e))`
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2165 self.__M540CaughtException = currentM540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2166
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2167 def visit_Module(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2168 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2169 Public method to handle a module node.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2170
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2171 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2172 @type ast.Module
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2173 """
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2174 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2175
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2176 def visit_Assign(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2177 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2178 Public method to handle assignments.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2179
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2180 @param node reference to the node to be processed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2181 @type ast.Assign
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2182 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2183 self.__checkForM540Usage(node.value)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2184 if len(node.targets) == 1:
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2185 target = node.targets[0]
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2186 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2187 isinstance(target, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2188 and isinstance(target.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2189 and (target.value.id, target.attr) == ("os", "environ")
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2190 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2191 self.violations.append((node, "M503"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2192
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2193 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2194
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2195 def visit_For(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2196 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2197 Public method to handle 'for' statements.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2198
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2199 @param node reference to the node to be processed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2200 @type ast.For
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2201 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2202 self.__checkForM507(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2203 self.__checkForM520(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2204 self.__checkForM523(node)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2205 self.__checkForM531(node)
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
2206 self.__checkForM569(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2207
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2208 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2209
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2210 def visit_AsyncFor(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2211 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2212 Public method to handle 'for' statements.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2213
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2214 @param node reference to the node to be processed
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2215 @type ast.AsyncFor
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2216 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2217 self.__checkForM507(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2218 self.__checkForM520(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2219 self.__checkForM523(node)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2220 self.__checkForM531(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2221
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2222 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2223
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2224 def visit_While(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2225 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2226 Public method to handle 'while' statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2227
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2228 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2229 @type ast.While
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2230 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2231 self.__checkForM523(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2232
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2233 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2234
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2235 def visit_ListComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2236 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2237 Public method to handle list comprehensions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2238
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2239 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2240 @type ast.ListComp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2241 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2242 self.__checkForM523(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2243
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2244 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2245
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2246 def visit_SetComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2247 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2248 Public method to handle set comprehensions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2249
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2250 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2251 @type ast.SetComp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2252 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2253 self.__checkForM523(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2254
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2255 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2256
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2257 def visit_DictComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2258 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2259 Public method to handle dictionary comprehensions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2260
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2261 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2262 @type ast.DictComp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2263 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2264 self.__checkForM523(node)
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2265 self.__checkForM535(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2266
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2267 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2268
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2269 def visit_GeneratorExp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2270 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2271 Public method to handle generator expressions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2272
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2273 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2274 @type ast.GeneratorExp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2275 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2276 self.__checkForM523(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2277
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2278 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2279
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2280 def visit_Assert(self, node):
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2281 """
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2282 Public method to handle 'assert' statements.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2283
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2284 @param node reference to the node to be processed
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2285 @type ast.Assert
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2286 """
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2287 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2288 AstUtilities.isNameConstant(node.test)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2289 and AstUtilities.getValue(node.test) is False
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2290 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2291 self.violations.append((node, "M511"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2292
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2293 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2294
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2295 def visit_AsyncFunctionDef(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2296 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2297 Public method to handle async function definitions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2298
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2299 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2300 @type ast.AsyncFunctionDef
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2301 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2302 self.__checkForM506_M508(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2303
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2304 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2305
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2306 def visit_FunctionDef(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2307 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2308 Public method to handle function definitions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2309
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2310 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2311 @type ast.FunctionDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2312 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2313 self.__checkForM506_M508(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2314 self.__checkForM519(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2315 self.__checkForM521(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2316
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2317 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2318
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2319 def visit_ClassDef(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2320 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2321 Public method to handle class definitions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2322
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2323 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2324 @type ast.ClassDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2325 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2326 self.__checkForM521(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2327 self.__checkForM524_M527(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2328
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2329 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2330
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2331 def visit_Try(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2332 """
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2333 Public method to handle 'try' statements.
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2334
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2335 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2336 @type ast.Try
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2337 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2338 self.__checkForM512(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2339 self.__checkForM525(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2340
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2341 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2342
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2343 def visit_TryStar(self, node):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2344 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2345 Public method to handle 'except*' statements.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2346
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2347 @param node reference to the node to be processed
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2348 @type ast.TryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2349 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2350 outerTryStar = self.__inTryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2351 self.__inTryStar = "*"
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2352 self.visit_Try(node)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2353 self.__inTryStar = outerTryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2354
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2355 def visit_Compare(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2356 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2357 Public method to handle comparison statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2358
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2359 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2360 @type ast.Compare
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2361 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2362 self.__checkForM515(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2363
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2364 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2365
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2366 def visit_Raise(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2367 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2368 Public method to handle 'raise' statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2369
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2370 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2371 @type ast.Raise
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2372 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2373 if node.exc is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2374 self.__M540CaughtException = None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2375 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2376 self.__checkForM540Usage(node.exc)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2377 self.__checkForM540Usage(node.cause)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2378 self.__checkForM516(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2379
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2380 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2381
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2382 def visit_With(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2383 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2384 Public method to handle 'with' statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2385
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2386 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2387 @type ast.With
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2388 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2389 self.__checkForM517(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2390 self.__checkForM522(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2391
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2392 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2393
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2394 def visit_JoinedStr(self, node):
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2395 """
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2396 Public method to handle f-string arguments.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2397
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2398 @param node reference to the node to be processed
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2399 @type ast.JoinedStr
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2400 """
7894
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
2401 for value in node.values:
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
2402 if isinstance(value, ast.FormattedValue):
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
2403 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2404
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2405 self.violations.append((node, "M581"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2406
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2407 def visit_AnnAssign(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2408 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2409 Public method to check annotated assign statements.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2410
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2411 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2412 @type ast.AnnAssign
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2413 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2414 self.__checkForM532(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2415 self.__checkForM540Usage(node.value)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2416
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2417 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2418
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2419 def visit_Import(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2420 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2421 Public method to check imports.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2422
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2423 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2424 @type ast.Import
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2425 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2426 self.__checkForM505(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2427
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2428 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2429
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2430 def visit_ImportFrom(self, node):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2431 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2432 Public method to check from imports.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2433
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2434 @param node reference to the node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2435 @type ast.Import
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2436 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2437 self.visit_Import(node)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2438
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2439 def visit_Set(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2440 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2441 Public method to check a set.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2442
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2443 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2444 @type ast.Set
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2445 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2446 self.__checkForM533(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2447
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2448 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2449
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2450 def visit_Dict(self, node):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2451 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2452 Public method to check a dictionary.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2453
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2454 @param node reference to the node to be processed
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2455 @type ast.Dict
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2456 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2457 self.__checkForM541(node)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2458
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2459 self.generic_visit(node)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2460
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2461 def __checkForM505(self, node):
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2462 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2463 Private method to check the use of *strip().
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2464
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2465 @param node reference to the node to be processed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2466 @type ast.Call
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2467 """
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2468 if isinstance(node, ast.Import):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2469 for name in node.names:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2470 self.__M505Imports.add(name.asname or name.name)
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2471 elif isinstance(node, ast.ImportFrom):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2472 for name in node.names:
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2473 self.__M505Imports.add(f"{node.module}.{name.name or name.asname}")
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2474 elif isinstance(node, ast.Call) and isinstance(node.func, ast.Attribute):
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2475 if node.func.attr not in ("lstrip", "rstrip", "strip"):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2476 return # method name doesn't match
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2477
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2478 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2479 isinstance(node.func.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2480 and node.func.value.id in self.__M505Imports
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2481 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2482 return # method is being run on an imported module
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2483
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2484 if len(node.args) != 1 or not AstUtilities.isString(node.args[0]):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2485 return # used arguments don't match the builtin strip
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2486
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2487 value = AstUtilities.getValue(node.args[0])
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2488 if len(value) == 1:
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2489 return # stripping just one character
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2490
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2491 if len(value) == len(set(value)):
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2492 return # no characters appear more than once
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2493
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2494 self.violations.append((node, "M505"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2495
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2496 def __checkForM506_M508(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2497 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2498 Private method to check the use of mutable literals, comprehensions and calls.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2499
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2500 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2501 @type ast.AsyncFunctionDef or ast.FunctionDef
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2502 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2503 visitor = FunctionDefDefaultsVisitor("M506", "M508")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2504 visitor.visit(node.args.defaults + node.args.kw_defaults)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2505 self.violations.extend(visitor.errors)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2506
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2507 def __checkForM507(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2508 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2509 Private method to check for unused loop variables.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2510
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2511 @param node reference to the node to be processed
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2512 @type ast.For or ast.AsyncFor
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2513 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2514 targets = NameFinder()
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2515 targets.visit(node.target)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2516 ctrlNames = set(filter(lambda s: not s.startswith("_"), targets.getNames()))
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2517 body = NameFinder()
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2518 for expr in node.body:
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2519 body.visit(expr)
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2520 usedNames = set(body.getNames())
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2521 for name in sorted(ctrlNames - usedNames):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2522 n = targets.getNames()[name][0]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2523 self.violations.append((n, "M507", name))
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2524
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2525 def __checkForM512(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2526 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2527 Private method to check for return/continue/break inside finally blocks.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2528
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2529 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2530 @type ast.Try
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2531 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2532
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2533 def _loop(node, badNodeTypes):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2534 if isinstance(node, (ast.AsyncFunctionDef, ast.FunctionDef)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2535 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2536
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2537 if isinstance(node, (ast.While, ast.For)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2538 badNodeTypes = (ast.Return,)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2539
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2540 elif isinstance(node, badNodeTypes):
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2541 self.violations.append((node, "M512", self.__inTryStar))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2542
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2543 for child in ast.iter_child_nodes(node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2544 _loop(child, badNodeTypes)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2545
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2546 for child in node.finalbody:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2547 _loop(child, (ast.Return, ast.Continue, ast.Break))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2548
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2549 def __checkForM513_M514_M529_M530(self, node):
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2550 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2551 Private method to check various exception handler situations.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2552
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2553 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2554 @type ast.ExceptHandler
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2555 @return list of exception handler names
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2556 @rtype list of str
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2557 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2558 handlers = self.__flattenExcepthandler(node.type)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2559 names = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2560 badHandlers = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2561 ignoredHandlers = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2562
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2563 for handler in handlers:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2564 if isinstance(handler, (ast.Name, ast.Attribute)):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2565 name = self.toNameStr(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2566 if name is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2567 ignoredHandlers.append(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2568 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2569 names.append(name)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2570 elif isinstance(handler, (ast.Call, ast.Starred)):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2571 ignoredHandlers.append(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2572 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2573 badHandlers.append(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2574 if badHandlers:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2575 self.violations.append((node, "M530"))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2576 if len(names) == 0 and not badHandlers and not ignoredHandlers:
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2577 self.violations.append((node, "M529", self.__inTryStar))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2578 elif (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2579 len(names) == 1
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2580 and not badHandlers
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2581 and not ignoredHandlers
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2582 and isinstance(node.type, ast.Tuple)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2583 ):
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2584 self.violations.append((node, "M513", *names, self.__inTryStar))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2585 else:
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2586 maybeError = self.__checkRedundantExcepthandlers(
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2587 names, node, self.__inTryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2588 )
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2589 if maybeError is not None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2590 self.violations.append(maybeError)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2591 return names
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2592
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2593 def __checkForM515(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2594 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2595 Private method to check for pointless comparisons.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2596
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2597 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2598 @type ast.Compare
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2599 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2600 if isinstance(self.nodeStack[-2], ast.Expr):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2601 self.violations.append((node, "M515"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2602
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2603 def __checkForM516(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2604 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2605 Private method to check for raising a literal instead of an exception.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2606
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2607 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2608 @type ast.Raise
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2609 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2610 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2611 AstUtilities.isNameConstant(node.exc)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2612 or AstUtilities.isNumber(node.exc)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2613 or AstUtilities.isString(node.exc)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2614 ):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2615 self.violations.append((node, "M516"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2616
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2617 def __checkForM517(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2618 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2619 Private method to check for use of the evil syntax
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2620 'with assertRaises(Exception): or 'with pytest.raises(Exception):'.
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2621
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2622 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2623 @type ast.With
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2624 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2625 item = node.items[0]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2626 itemContext = item.context_expr
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2627 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2628 hasattr(itemContext, "func")
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2629 and (
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2630 (
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2631 isinstance(itemContext.func, ast.Attribute)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2632 and (
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2633 itemContext.func.attr == "assertRaises"
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2634 or (
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2635 itemContext.func.attr == "raises"
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2636 and isinstance(itemContext.func.value, ast.Name)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2637 and itemContext.func.value.id == "pytest"
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2638 and "match" not in (kwd.arg for kwd in itemContext.keywords)
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2639 )
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2640 )
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2641 )
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2642 or (
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2643 isinstance(itemContext.func, ast.Name)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2644 and itemContext.func.id == "raises"
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2645 and isinstance(itemContext.func.ctx, ast.Load)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2646 and "pytest.raises" in self.__M505Imports
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2647 and "match" not in (kwd.arg for kwd in itemContext.keywords)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2648 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2649 )
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2650 and len(itemContext.args) == 1
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2651 and isinstance(itemContext.args[0], ast.Name)
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2652 and itemContext.args[0].id in ("Exception", "BaseException")
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2653 and not item.optional_vars
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2654 ):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2655 self.violations.append((node, "M517"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2656
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2657 def __checkForM518(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2658 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2659 Private method to check for useless expressions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2660
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2661 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2662 @type ast.FunctionDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2663 """
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2664 if not isinstance(node, ast.Expr):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2665 return
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2666
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2667 if isinstance(
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2668 node.value,
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2669 (ast.List, ast.Set, ast.Dict, ast.Tuple),
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2670 ) or (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2671 isinstance(node.value, ast.Constant)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2672 and (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2673 isinstance(
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2674 node.value.value,
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2675 (int, float, complex, bytes, bool),
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2676 )
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2677 or node.value.value is None
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2678 )
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2679 ):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2680 self.violations.append((node, "M518", node.value.__class__.__name__))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2681
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2682 def __checkForM519(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2683 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2684 Private method to check for use of 'functools.lru_cache' or 'functools.cache'.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2685
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2686 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2687 @type ast.FunctionDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2688 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2689 caches = {
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2690 "functools.cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2691 "functools.lru_cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2692 "cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2693 "lru_cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2694 }
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2695
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2696 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2697 len(node.decorator_list) == 0
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2698 or len(self.contexts) < 2
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2699 or not isinstance(self.contexts[-2].node, ast.ClassDef)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2700 ):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2701 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2702
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2703 # Preserve decorator order so we can get the lineno from the decorator node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2704 # rather than the function node (this location definition changes in Python 3.8)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2705 resolvedDecorators = (
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2706 ".".join(composeCallPath(decorator)) for decorator in node.decorator_list
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2707 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2708 for idx, decorator in enumerate(resolvedDecorators):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2709 if decorator in {"classmethod", "staticmethod"}:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2710 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2711
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2712 if decorator in caches:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2713 self.violations.append((node.decorator_list[idx], "M519"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2714 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2715
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2716 def __checkForM520(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2717 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2718 Private method to check for a loop that modifies its iterable.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2719
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2720 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2721 @type ast.For or ast.AsyncFor
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2722 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2723 targets = NameFinder()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2724 targets.visit(node.target)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2725 ctrlNames = set(targets.getNames())
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2726
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2727 iterset = M520NameFinder()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2728 iterset.visit(node.iter)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2729 itersetNames = set(iterset.getNames())
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2730
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2731 for name in sorted(ctrlNames):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2732 if name in itersetNames:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2733 n = targets.getNames()[name][0]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2734 self.violations.append((n, "M520"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2735
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2736 def __checkForM521(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2737 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2738 Private method to check for use of an f-string as docstring.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2739
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2740 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2741 @type ast.FunctionDef or ast.ClassDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2742 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2743 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2744 node.body
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2745 and isinstance(node.body[0], ast.Expr)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2746 and isinstance(node.body[0].value, ast.JoinedStr)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2747 ):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2748 self.violations.append((node.body[0].value, "M521"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2749
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2750 def __checkForM522(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2751 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2752 Private method to check for use of an f-string as docstring.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2753
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2754 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2755 @type ast.With
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2756 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2757 item = node.items[0]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2758 itemContext = item.context_expr
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2759 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2760 hasattr(itemContext, "func")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2761 and hasattr(itemContext.func, "value")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2762 and hasattr(itemContext.func.value, "id")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2763 and itemContext.func.value.id == "contextlib"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2764 and hasattr(itemContext.func, "attr")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2765 and itemContext.func.attr == "suppress"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2766 and len(itemContext.args) == 0
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2767 ):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2768 self.violations.append((node, "M522"))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2769
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2770 def __checkForM523(self, loopNode):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2771 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2772 Private method to check that functions (including lambdas) do not use loop
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2773 variables.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2774
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2775 @param loopNode reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2776 @type ast.For, ast.AsyncFor, ast.While, ast.ListComp, ast.SetComp,ast.DictComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2777 or ast.GeneratorExp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2778 """
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2779 safe_functions = []
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2780 suspiciousVariables = []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2781 for node in ast.walk(loopNode):
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2782 # check if function is immediately consumed to avoid false alarm
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2783 if isinstance(node, ast.Call):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2784 # check for filter&reduce
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2785 if (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2786 isinstance(node.func, ast.Name)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2787 and node.func.id in ("filter", "reduce", "map")
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2788 ) or (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2789 isinstance(node.func, ast.Attribute)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2790 and node.func.attr == "reduce"
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2791 and isinstance(node.func.value, ast.Name)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2792 and node.func.value.id == "functools"
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2793 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2794 for arg in node.args:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2795 if isinstance(arg, BugBearVisitor.FUNCTION_NODES):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2796 safe_functions.append(arg)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2797
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2798 # check for key=
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2799 for keyword in node.keywords:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2800 if keyword.arg == "key" and isinstance(
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2801 keyword.value, BugBearVisitor.FUNCTION_NODES
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2802 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2803 safe_functions.append(keyword.value)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2804
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2805 # mark `return lambda: x` as safe
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2806 # does not (currently) check inner lambdas in a returned expression
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2807 # e.g. `return (lambda: x, )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2808 if isinstance(node, ast.Return) and isinstance(
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2809 node.value, BugBearVisitor.FUNCTION_NODES
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2810 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2811 safe_functions.append(node.value)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2812
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2813 # find unsafe functions
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2814 if (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2815 isinstance(node, BugBearVisitor.FUNCTION_NODES)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2816 and node not in safe_functions
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2817 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2818 argnames = {
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2819 arg.arg for arg in ast.walk(node.args) if isinstance(arg, ast.arg)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2820 }
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2821 if isinstance(node, ast.Lambda):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2822 bodyNodes = ast.walk(node.body)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2823 else:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2824 bodyNodes = itertools.chain.from_iterable(map(ast.walk, node.body))
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2825 errors = []
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2826 for name in bodyNodes:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2827 if isinstance(name, ast.Name) and name.id not in argnames:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2828 if isinstance(name.ctx, ast.Load):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2829 errors.append((name.lineno, name.col_offset, name.id, name))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2830 elif isinstance(name.ctx, ast.Store):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2831 argnames.add(name.id)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2832 for err in errors:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2833 if err[2] not in argnames and err not in self.__M523Seen:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2834 self.__M523Seen.add(err) # dedupe across nested loops
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2835 suspiciousVariables.append(err)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2836
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2837 if suspiciousVariables:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2838 reassignedInLoop = set(self.__getAssignedNames(loopNode))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2839
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2840 for err in sorted(suspiciousVariables):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2841 if reassignedInLoop.issuperset(err[2]):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2842 self.violations.append((err[3], "M523", err[2]))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2843
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2844 def __checkForM524_M527(self, node):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2845 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2846 Private method to check for inheritance from abstract classes in abc and lack of
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2847 any methods decorated with abstract*.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2848
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2849 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2850 @type ast.ClassDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2851 """ # __IGNORE_WARNING_D234r__
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2852
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2853 def isAbcClass(value, name="ABC"):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2854 if isinstance(value, ast.keyword):
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2855 return value.arg == "metaclass" and isAbcClass(value.value, "ABCMeta")
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2856
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2857 # class foo(ABC)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2858 # class foo(abc.ABC)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2859 return (isinstance(value, ast.Name) and value.id == name) or (
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2860 isinstance(value, ast.Attribute)
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2861 and value.attr == name
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2862 and isinstance(value.value, ast.Name)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2863 and value.value.id == "abc"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2864 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2865
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2866 def isAbstractDecorator(expr):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2867 return (isinstance(expr, ast.Name) and expr.id[:8] == "abstract") or (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2868 isinstance(expr, ast.Attribute) and expr.attr[:8] == "abstract"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2869 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2870
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2871 def isOverload(expr):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2872 return (isinstance(expr, ast.Name) and expr.id == "overload") or (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2873 isinstance(expr, ast.Attribute) and expr.attr == "overload"
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2874 )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2875
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2876 def emptyBody(body):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2877 def isStrOrEllipsis(node):
10170
6cf1ee737d8f Corrected some more code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10169
diff changeset
2878 return isinstance(node, ast.Constant) and (
6cf1ee737d8f Corrected some more code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10169
diff changeset
2879 node.value is Ellipsis or isinstance(node.value, str)
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2880 )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2881
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2882 # Function body consist solely of `pass`, `...`, and/or (doc)string literals
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2883 return all(
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2884 isinstance(stmt, ast.Pass)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2885 or (isinstance(stmt, ast.Expr) and isStrOrEllipsis(stmt.value))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2886 for stmt in body
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2887 )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2888
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2889 # don't check multiple inheritance
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2890 if len(node.bases) + len(node.keywords) > 1:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2891 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2892
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2893 # only check abstract classes
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2894 if not any(map(isAbcClass, (*node.bases, *node.keywords))):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2895 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2896
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2897 hasMethod = False
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2898 hasAbstractMethod = False
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2899
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2900 if not any(map(isAbcClass, (*node.bases, *node.keywords))):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2901 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2902
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2903 for stmt in node.body:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2904 # Ignore abc's that declares a class attribute that must be set
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2905 if isinstance(stmt, ast.AnnAssign) and stmt.value is None:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2906 hasAbstractMethod = True
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2907 continue
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2908
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2909 # only check function defs
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2910 if not isinstance(stmt, (ast.FunctionDef, ast.AsyncFunctionDef)):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2911 continue
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2912 hasMethod = True
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2913
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2914 hasAbstractDecorator = any(map(isAbstractDecorator, stmt.decorator_list))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2915
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2916 hasAbstractMethod |= hasAbstractDecorator
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2917
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2918 if (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2919 not hasAbstractDecorator
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2920 and emptyBody(stmt.body)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2921 and not any(map(isOverload, stmt.decorator_list))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2922 ):
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2923 self.violations.append((stmt, "M527", stmt.name))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2924
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2925 if hasMethod and not hasAbstractMethod:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2926 self.violations.append((node, "M524", node.name))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2927
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2928 def __checkForM525(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2929 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2930 Private method to check for exceptions being handled multiple times.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2931
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2932 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2933 @type ast.Try
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2934 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2935 seen = []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2936
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2937 for handler in node.handlers:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2938 if isinstance(handler.type, (ast.Name, ast.Attribute)):
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2939 name = ".".join(composeCallPath(handler.type))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2940 seen.append(name)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2941 elif isinstance(handler.type, ast.Tuple):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2942 # to avoid checking the same as M514, remove duplicates per except
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2943 uniques = set()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2944 for entry in handler.type.elts:
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2945 name = ".".join(composeCallPath(entry))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2946 uniques.add(name)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2947 seen.extend(uniques)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2948
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2949 # sort to have a deterministic output
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2950 duplicates = sorted({x for x in seen if seen.count(x) > 1})
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2951 for duplicate in duplicates:
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2952 self.violations.append((node, "M525", duplicate, self.__inTryStar))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2953
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2954 def __checkForM526(self, node):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2955 """
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2956 Private method to check for Star-arg unpacking after keyword argument.
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2957
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2958 @param node reference to the node to be processed
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2959 @type ast.Call
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2960 """
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2961 if not node.keywords:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2962 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2963
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2964 starreds = [arg for arg in node.args if isinstance(arg, ast.Starred)]
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2965 if not starreds:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2966 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2967
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2968 firstKeyword = node.keywords[0].value
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2969 for starred in starreds:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2970 if (starred.lineno, starred.col_offset) > (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2971 firstKeyword.lineno,
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2972 firstKeyword.col_offset,
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2973 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2974 self.violations.append((node, "M526"))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2975
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2976 def __checkForM528(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2977 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2978 Private method to check for warn without stacklevel.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2979
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2980 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2981 @type ast.Call
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2982 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2983 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2984 isinstance(node.func, ast.Attribute)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2985 and node.func.attr == "warn"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2986 and isinstance(node.func.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2987 and node.func.value.id == "warnings"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2988 and not any(kw.arg == "stacklevel" for kw in node.keywords)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2989 and len(node.args) < 3
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2990 and not any(isinstance(a, ast.Starred) for a in node.args)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2991 and not any(kw.arg is None for kw in node.keywords)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2992 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2993 self.violations.append((node, "M528"))
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2994
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2995 def __checkForM531(self, loopNode):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2996 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2997 Private method to check that 'itertools.groupby' isn't iterated over more than
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2998 once.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2999
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3000 A warning is emitted when the generator returned by 'groupby()' is used
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3001 more than once inside a loop body or when it's used in a nested loop.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3002
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3003 @param loopNode reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3004 @type ast.For or ast.AsyncFor
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3005 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3006 # for <loop_node.target> in <loop_node.iter>: ...
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3007 if isinstance(loopNode.iter, ast.Call):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3008 node = loopNode.iter
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3009 if (isinstance(node.func, ast.Name) and node.func.id in ("groupby",)) or (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3010 isinstance(node.func, ast.Attribute)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3011 and node.func.attr == "groupby"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3012 and isinstance(node.func.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3013 and node.func.value.id == "itertools"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3014 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3015 # We have an invocation of groupby which is a simple unpacking
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3016 if isinstance(loopNode.target, ast.Tuple) and isinstance(
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3017 loopNode.target.elts[1], ast.Name
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3018 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3019 groupName = loopNode.target.elts[1].id
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3020 else:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3021 # Ignore any 'groupby()' invocation that isn't unpacked
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3022 return
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3023
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3024 numUsages = 0
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3025 for node in self.__walkList(loopNode.body):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3026 # Handled nested loops
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3027 if isinstance(node, ast.For):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3028 for nestedNode in self.__walkList(node.body):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3029 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3030 isinstance(nestedNode, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3031 and nestedNode.id == groupName
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3032 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3033 self.violations.append((nestedNode, "M531"))
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3034
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3035 # Handle multiple uses
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3036 if isinstance(node, ast.Name) and node.id == groupName:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3037 numUsages += 1
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3038 if numUsages > 1:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3039 self.violations.append((nestedNode, "M531"))
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3040
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3041 def __checkForM532(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3042 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3043 Private method to check for possible unintentional typing annotation.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3044
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3045 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3046 @type ast.AnnAssign
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3047 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3048 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3049 node.value is None
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3050 and hasattr(node.target, "value")
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3051 and isinstance(node.target.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3052 and (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3053 isinstance(node.target, ast.Subscript)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3054 or (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3055 isinstance(node.target, ast.Attribute)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3056 and node.target.value.id != "self"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3057 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3058 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3059 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3060 self.violations.append((node, "M532"))
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3061
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3062 def __checkForM533(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3063 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3064 Private method to check a set for duplicate items.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3065
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3066 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3067 @type ast.Set
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3068 """
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3069 seen = set()
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3070 for elt in node.elts:
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3071 if not isinstance(elt, ast.Constant):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3072 continue
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3073 if elt.value in seen:
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3074 self.violations.append((node, "M533", repr(elt.value)))
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3075 else:
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3076 seen.add(elt.value)
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3077
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3078 def __checkForM534(self, node):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3079 """
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3080 Private method to check that re.sub/subn/split arguments flags/count/maxsplit
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3081 are passed as keyword arguments.
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3082
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3083 @param node reference to the node to be processed
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3084 @type ast.Call
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3085 """
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3086 if not isinstance(node.func, ast.Attribute):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3087 return
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3088 func = node.func
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3089 if not isinstance(func.value, ast.Name) or func.value.id != "re":
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3090 return
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3091
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3092 def check(numArgs, paramName):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3093 if len(node.args) > numArgs:
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3094 arg = node.args[numArgs]
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3095 self.violations.append((arg, "M534", func.attr, paramName))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3096
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3097 if func.attr in ("sub", "subn"):
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3098 check(3, "count")
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3099 elif func.attr == "split":
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3100 check(2, "maxsplit")
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3101
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3102 def __checkForM535(self, node):
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3103 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3104 Private method to check that a static key isn't used in a dict comprehension.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3105
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3106 Record a warning if a likely unchanging key is used - either a constant,
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3107 or a variable that isn't coming from the generator expression.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3108
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3109 @param node reference to the node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3110 @type ast.DictComp
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3111 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3112 if isinstance(node.key, ast.Constant):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3113 self.violations.append((node, "M535", node.key.value))
10359
de0420dac60e Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10356
diff changeset
3114 elif isinstance(
de0420dac60e Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10356
diff changeset
3115 node.key, ast.Name
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3116 ) and node.key.id not in self.__getDictCompLoopAndNamedExprVarNames(node):
10359
de0420dac60e Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10356
diff changeset
3117 self.violations.append((node, "M535", node.key.id))
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3118
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3119 def __checkForM539(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3120 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3121 Private method to check for correct ContextVar usage.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3122
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3123 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3124 @type ast.Call
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3125 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3126 if not (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3127 (isinstance(node.func, ast.Name) and node.func.id == "ContextVar")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3128 or (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3129 isinstance(node.func, ast.Attribute)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3130 and node.func.attr == "ContextVar"
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3131 and isinstance(node.func.value, ast.Name)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3132 and node.func.value.id == "contextvars"
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3133 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3134 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3135 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3136
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3137 # ContextVar only takes one kw currently, but better safe than sorry
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3138 for kw in node.keywords:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3139 if kw.arg == "default":
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3140 break
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3141 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3142 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3143
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3144 visitor = FunctionDefDefaultsVisitor("M539", "M539")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3145 visitor.visit(kw.value)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3146 self.violations.extend(visitor.errors)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3147
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3148 def __checkForM540AddNote(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3149 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3150 Private method to check add_note usage.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3151
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3152 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3153 @type ast.Attribute
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3154 @return flag
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3155 @rtype bool
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3156 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3157 if (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3158 node.attr == "add_note"
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3159 and isinstance(node.value, ast.Name)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3160 and self.__M540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3161 and node.value.id == self.__M540CaughtException.name
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3162 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3163 self.__M540CaughtException.hasNote = True
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3164 return True
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3165
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3166 return False
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3167
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3168 def __checkForM540Usage(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3169 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3170 Private method to check the usage of exceptions with added note.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3171
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3172 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3173 @type ast.expr or None
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
3174 """ # noqa: D234y
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
3175
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3176 def superwalk(node: ast.AST | list[ast.AST]):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3177 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3178 Function to walk an AST node or a list of AST nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3179
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3180 @param node reference to the node or a list of nodes to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3181 @type ast.AST or list[ast.AST]
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3182 @yield next node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3183 @ytype ast.AST
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3184 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3185 if isinstance(node, list):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3186 for n in node:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3187 yield from ast.walk(n)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3188 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3189 yield from ast.walk(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3190
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3191 if not self.__M540CaughtException or node is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3192 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3193
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3194 for n in superwalk(node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3195 if isinstance(n, ast.Name) and n.id == self.__M540CaughtException.name:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3196 self.__M540CaughtException = None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3197 break
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3198
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3199 def __checkForM541(self, node):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3200 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3201 Private method to check for duplicate key value pairs in a dictionary literal.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3202
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3203 @param node reference to the node to be processed
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3204 @type ast.Dict
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3205 """ # noqa: D234r
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3206
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3207 def convertToValue(item):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3208 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3209 Function to extract the value of a given item.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3210
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3211 @param item node to extract value from
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3212 @type ast.Ast
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3213 @return value of the node
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3214 @rtype Any
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3215 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3216 if isinstance(item, ast.Constant):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3217 return item.value
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3218 elif isinstance(item, ast.Tuple):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3219 return tuple(convertToValue(i) for i in item.elts)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3220 elif isinstance(item, ast.Name):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3221 return M541VariableKeyType(item.id)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3222 else:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3223 return M541UnhandledKeyType()
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3224
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3225 keys = [convertToValue(key) for key in node.keys]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3226 keyCounts = Counter(keys)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3227 duplicateKeys = [key for key, count in keyCounts.items() if count > 1]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3228 for key in duplicateKeys:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3229 keyIndices = [i for i, iKey in enumerate(keys) if iKey == key]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3230 seen = set()
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3231 for index in keyIndices:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3232 value = convertToValue(node.values[index])
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3233 if value in seen:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3234 keyNode = node.keys[index]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3235 self.violations.append((keyNode, "M541"))
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3236 seen.add(value)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3237
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3238 def __checkForM569(self, node):
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3239 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3240 Private method to check for changes to a loop's mutable iterable.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3241
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3242 @param node loop node to be checked
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3243 @type ast.For
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3244 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3245 if isinstance(node.iter, ast.Name):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3246 name = self.toNameStr(node.iter)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3247 elif isinstance(node.iter, ast.Attribute):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3248 name = self.toNameStr(node.iter)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3249 else:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3250 return
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3251 checker = M569Checker(name, self)
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3252 checker.visit(node.body)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3253 for mutation in checker.mutations:
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3254 self.violations.append((mutation, "M569"))
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3255
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3256
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3257 class M569Checker(ast.NodeVisitor):
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3258 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3259 Class traversing a 'for' loop body to check for modifications to a loop's
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3260 mutable iterable.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3261 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3262
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3263 # https://docs.python.org/3/library/stdtypes.html#mutable-sequence-types
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3264 MUTATING_FUNCTIONS = (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3265 "append",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3266 "sort",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3267 "reverse",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3268 "remove",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3269 "clear",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3270 "extend",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3271 "insert",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3272 "pop",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3273 "popitem",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3274 )
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3275
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3276 def __init__(self, name, bugbear):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3277 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3278 Constructor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3279
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3280 @param name name of the iterator
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3281 @type str
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3282 @param bugbear reference to the bugbear visitor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3283 @type BugBearVisitor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3284 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3285 self.__name = name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3286 self.__bb = bugbear
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3287 self.mutations = []
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3288
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3289 def visit_Delete(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3290 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3291 Public method handling 'Delete' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3292
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3293 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3294 @type ast.Delete
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3295 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3296 for target in node.targets:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3297 if isinstance(target, ast.Subscript):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3298 name = self.__bb.toNameStr(target.value)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3299 elif isinstance(target, (ast.Attribute, ast.Name)):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3300 name = self.__bb.toNameStr(target)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3301 else:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3302 name = "" # fallback
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3303 self.generic_visit(target)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3304
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3305 if name == self.__name:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3306 self.mutations.append(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3307
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3308 def visit_Call(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3309 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3310 Public method handling 'Call' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3311
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3312 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3313 @type ast.Call
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3314 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3315 if isinstance(node.func, ast.Attribute):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3316 name = self.__bb.toNameStr(node.func.value)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3317 functionObject = name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3318 functionName = node.func.attr
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3319
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3320 if (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3321 functionObject == self.__name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3322 and functionName in self.MUTATING_FUNCTIONS
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3323 ):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3324 self.mutations.append(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3325
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3326 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3327
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3328 def visit(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3329 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3330 Public method to inspect an ast node.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3331
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3332 Like super-visit but supports iteration over lists.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3333
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3334 @param node AST node to be traversed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3335 @type TYPE
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3336 @return reference to the last processed node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3337 @rtype ast.Node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3338 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3339 if not isinstance(node, list):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3340 return super().visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3341
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3342 for elem in node:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3343 super().visit(elem)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3344 return node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3345
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3346
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3347 class ExceptBaseExceptionVisitor(ast.NodeVisitor):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3348 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3349 Class to determine, if a 'BaseException' is re-raised.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3350 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3351
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3352 def __init__(self, exceptNode):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3353 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3354 Constructor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3355
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3356 @param exceptNode exception node to be inspected
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3357 @type ast.ExceptHandler
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3358 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3359 super().__init__()
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3360 self.__root = exceptNode
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3361 self.__reRaised = False
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3362
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3363 def reRaised(self) -> bool:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3364 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3365 Public method to check, if the exception is re-raised.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3366
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3367 @return flag indicating a re-raised exception
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3368 @rtype bool
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3369 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3370 self.visit(self.__root)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3371 return self.__reRaised
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3372
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3373 def visit_Raise(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3374 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3375 Public method to handle 'Raise' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3376
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3377 If we find a corresponding `raise` or `raise e` where e was from
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3378 `except BaseException as e:` then we mark re_raised as True and can
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3379 stop scanning.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3380
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3381 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3382 @type ast.Raise
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3383 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3384 if node.exc is None or (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3385 isinstance(node.exc, ast.Name) and node.exc.id == self.__root.name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3386 ):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3387 self.__reRaised = True
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3388 return
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3389
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3390 super().generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3391
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3392 def visit_ExceptHandler(self, node: ast.ExceptHandler):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3393 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3394 Public method to handle 'ExceptHandler' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3395
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3396 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3397 @type ast.ExceptHandler
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3398 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3399 if node is not self.__root:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3400 return # entered a nested except - stop searching
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3401
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3402 super().generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3403
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3404
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3405 class NameFinder(ast.NodeVisitor):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3406 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3407 Class to extract a name out of a tree of nodes.
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3408 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3409
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3410 def __init__(self):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3411 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3412 Constructor
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3413 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
3414 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3415
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3416 self.__names = {}
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3417
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3418 def visit_Name(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3419 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3420 Public method to handle 'Name' nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3421
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3422 @param node reference to the node to be processed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3423 @type ast.Name
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3424 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3425 self.__names.setdefault(node.id, []).append(node)
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3426
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3427 def visit(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3428 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3429 Public method to traverse a given AST node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3430
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3431 @param node AST node to be traversed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3432 @type ast.Node
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3433 @return reference to the last processed node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3434 @rtype ast.Node
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3435 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3436 if isinstance(node, list):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3437 for elem in node:
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
3438 super().visit(elem)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3439 return node
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3440 else:
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3441 return super().visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3442
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3443 def getNames(self):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3444 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3445 Public method to return the extracted names and Name nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3446
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3447 @return dictionary containing the names as keys and the list of nodes
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3448 @rtype dict
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3449 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3450 return self.__names
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
3451
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3452
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3453 class NamedExprFinder(ast.NodeVisitor):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3454 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3455 Class to extract names defined through an ast.NamedExpr.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3456 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3457
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3458 def __init__(self):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3459 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3460 Constructor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3461 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3462 super().__init__()
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3463
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3464 self.__names = {}
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3465
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3466 def visit_NamedExpr(self, node: ast.NamedExpr):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3467 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3468 Public method handling 'NamedExpr' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3469
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3470 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3471 @type ast.NamedExpr
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3472 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3473 self.__names.setdefault(node.target.id, []).append(node.target)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3474
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3475 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3476
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3477 def visit(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3478 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3479 Public method to traverse a given AST node.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3480
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3481 Like super-visit but supports iteration over lists.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3482
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3483 @param node AST node to be traversed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3484 @type TYPE
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3485 @return reference to the last processed node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3486 @rtype ast.Node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3487 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3488 if not isinstance(node, list):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3489 super().visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3490
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3491 for elem in node:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3492 super().visit(elem)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3493
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3494 return node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3495
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3496 def getNames(self):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3497 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3498 Public method to return the extracted names and Name nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3499
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3500 @return dictionary containing the names as keys and the list of nodes
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3501 @rtype dict
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3502 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3503 return self.__names
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3504
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3505
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3506 class FunctionDefDefaultsVisitor(ast.NodeVisitor):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3507 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3508 Class used by M506, M508 and M539.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3509 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3510
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3511 def __init__(
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3512 self,
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3513 errorCodeCalls, # M506 or M539
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3514 errorCodeLiterals, # M508 or M539
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3515 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3516 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3517 Constructor
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3518
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3519 @param errorCodeCalls error code for ast.Call nodes
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3520 @type str
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3521 @param errorCodeLiterals error code for literal nodes
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3522 @type str
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3523 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3524 self.__errorCodeCalls = errorCodeCalls
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3525 self.__errorCodeLiterals = errorCodeLiterals
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3526 for nodeType in BugbearMutableLiterals + BugbearMutableComprehensions:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3527 setattr(
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3528 self, f"visit_{nodeType}", self.__visitMutableLiteralOrComprehension
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3529 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3530 self.errors = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3531 self.__argDepth = 0
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3532
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3533 super().__init__()
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3534
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3535 def __visitMutableLiteralOrComprehension(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3536 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3537 Private method to flag mutable literals and comprehensions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3538
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3539 @param node AST node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3540 @type ast.Dict, ast.List, ast.Set, ast.ListComp, ast.DictComp or ast.SetComp
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3541 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3542 # Flag M506 if mutable literal/comprehension is not nested.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3543 # We only flag these at the top level of the expression as we
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3544 # cannot easily guarantee that nested mutable structures are not
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3545 # made immutable by outer operations, so we prefer no false positives.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3546 # e.g.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3547 # >>> def this_is_fine(a=frozenset({"a", "b", "c"})): ...
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3548 #
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3549 # >>> def this_is_not_fine_but_hard_to_detect(a=(lambda x: x)([1, 2, 3]))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3550 #
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3551 # We do still search for cases of B008 within mutable structures though.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3552 if self.__argDepth == 1:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3553 self.errors.append((node, self.__errorCodeCalls))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3554
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3555 # Check for nested functions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3556 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3557
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3558 def visit_Call(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3559 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3560 Public method to process Call nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3561
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3562 @param node AST node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3563 @type ast.Call
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3564 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3565 callPath = ".".join(composeCallPath(node.func))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3566 if callPath in BugbearMutableCalls:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3567 self.errors.append((node, self.__errorCodeCalls))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3568 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3569 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3570
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3571 if callPath in BugbearImmutableCalls:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3572 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3573 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3574
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3575 # Check if function call is actually a float infinity/NaN literal
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3576 if callPath == "float" and len(node.args) == 1:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3577 try:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3578 value = float(ast.literal_eval(node.args[0]))
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
3579 except Exception: # secok
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3580 pass
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3581 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3582 if math.isfinite(value):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3583 self.errors.append((node, self.__errorCodeLiterals))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3584 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3585 self.errors.append((node, self.__errorCodeLiterals))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3586
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3587 # Check for nested functions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3588 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3589
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3590 def visit_Lambda(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3591 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3592 Public method to process Lambda nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3593
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3594 @param node AST node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3595 @type ast.Lambda
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3596 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3597 # Don't recurse into lambda expressions
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3598 # as they are evaluated at call time.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3599 pass
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3600
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3601 def visit(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3602 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3603 Public method to traverse an AST node or a list of AST nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3604
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3605 This is an extended method that can also handle a list of AST nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3606
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3607 @param node AST node or list of AST nodes to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3608 @type ast.AST or list of ast.AST
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3609 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3610 self.__argDepth += 1
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3611 if isinstance(node, list):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3612 for elem in node:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3613 if elem is not None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3614 super().visit(elem)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3615 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3616 super().visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3617 self.__argDepth -= 1
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3618
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3619
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3620 class M520NameFinder(NameFinder):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3621 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3622 Class to extract a name out of a tree of nodes ignoring names defined within the
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3623 local scope of a comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3624 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3625
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3626 def visit_GeneratorExp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3627 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3628 Public method to handle a generator expressions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3629
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3630 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3631 @type ast.GeneratorExp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3632 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3633 self.visit(node.generators)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3634
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3635 def visit_ListComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3636 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3637 Public method to handle a list comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3638
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3639 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3640 @type TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3641 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3642 self.visit(node.generators)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3643
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3644 def visit_DictComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3645 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3646 Public method to handle a dictionary comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3647
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3648 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3649 @type TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3650 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3651 self.visit(node.generators)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3652
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3653 def visit_comprehension(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3654 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3655 Public method to handle the 'for' of a comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3656
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3657 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3658 @type ast.comprehension
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3659 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3660 self.visit(node.iter)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3661
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3662 def visit_Lambda(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3663 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3664 Public method to handle a Lambda function.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3665
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3666 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3667 @type ast.Lambda
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3668 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3669 self.visit(node.body)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3670 for lambdaArg in node.args.args:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3671 self.getNames().pop(lambdaArg.arg, None)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3672
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3673
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3674 class ReturnVisitor(ast.NodeVisitor):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3675 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3676 Class implementing a node visitor to check return statements.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3677 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3678
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3679 Assigns = "assigns"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3680 Refs = "refs"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3681 Returns = "returns"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3682
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3683 def __init__(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3684 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3685 Constructor
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3686 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
3687 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3688
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3689 self.__stack = []
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3690 self.violations = []
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3691 self.__loopCount = 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3692
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3693 @property
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3694 def assigns(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3695 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3696 Public method to get the Assign nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3697
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3698 @return dictionary containing the node name as key and line number
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3699 as value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3700 @rtype dict
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3701 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3702 return self.__stack[-1][ReturnVisitor.Assigns]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3703
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3704 @property
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3705 def refs(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3706 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3707 Public method to get the References nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3708
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3709 @return dictionary containing the node name as key and line number
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3710 as value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3711 @rtype dict
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3712 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3713 return self.__stack[-1][ReturnVisitor.Refs]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3714
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3715 @property
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3716 def returns(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3717 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3718 Public method to get the Return nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3719
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3720 @return dictionary containing the node name as key and line number
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3721 as value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3722 @rtype dict
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3723 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3724 return self.__stack[-1][ReturnVisitor.Returns]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3725
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3726 def visit_For(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3727 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3728 Public method to handle a for loop.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3729
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3730 @param node reference to the for node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3731 @type ast.For
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3732 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3733 self.__visitLoop(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3734
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3735 def visit_AsyncFor(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3736 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3737 Public method to handle an async for loop.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3738
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3739 @param node reference to the async for node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3740 @type ast.AsyncFor
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3741 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3742 self.__visitLoop(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3743
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3744 def visit_While(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3745 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3746 Public method to handle a while loop.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3747
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3748 @param node reference to the while node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3749 @type ast.While
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3750 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3751 self.__visitLoop(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3752
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3753 def __visitLoop(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3754 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3755 Private method to handle loop nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3756
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3757 @param node reference to the loop node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3758 @type ast.For, ast.AsyncFor or ast.While
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3759 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3760 self.__loopCount += 1
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3761 self.generic_visit(node)
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3762 self.__loopCount -= 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3763
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3764 def __visitWithStack(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3765 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3766 Private method to traverse a given function node using a stack.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3767
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3768 @param node AST node to be traversed
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3769 @type ast.FunctionDef or ast.AsyncFunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3770 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3771 self.__stack.append(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3772 {
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3773 ReturnVisitor.Assigns: defaultdict(list),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3774 ReturnVisitor.Refs: defaultdict(list),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3775 ReturnVisitor.Returns: [],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3776 }
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3777 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3778
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3779 self.generic_visit(node)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3780 self.__checkFunction(node)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3781 self.__stack.pop()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3782
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3783 def visit_FunctionDef(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3784 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3785 Public method to handle a function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3786
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3787 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3788 @type ast.FunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3789 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3790 self.__visitWithStack(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3791
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3792 def visit_AsyncFunctionDef(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3793 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3794 Public method to handle a function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3795
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3796 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3797 @type ast.AsyncFunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3798 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3799 self.__visitWithStack(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3800
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3801 def visit_Return(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3802 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3803 Public method to handle a return node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3804
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3805 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3806 @type ast.Return
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3807 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3808 self.returns.append(node)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3809 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3810
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3811 def visit_Assign(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3812 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3813 Public method to handle an assign node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3814
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3815 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3816 @type ast.Assign
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3817 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3818 if not self.__stack:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3819 return
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3820
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3821 self.generic_visit(node.value)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3822
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3823 target = node.targets[0]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3824 if isinstance(target, ast.Tuple) and not isinstance(node.value, ast.Tuple):
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3825 # skip unpacking assign
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3826 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3827
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3828 self.__visitAssignTarget(target)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3829
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3830 def visit_Name(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3831 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3832 Public method to handle a name node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3833
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3834 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3835 @type ast.Name
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3836 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3837 if self.__stack:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3838 self.refs[node.id].append(node.lineno)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3839
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3840 def __visitAssignTarget(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3841 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3842 Private method to handle an assign target node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3843
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3844 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3845 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3846 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3847 if isinstance(node, ast.Tuple):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3848 for elt in node.elts:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3849 self.__visitAssignTarget(elt)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3850 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3851
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3852 if not self.__loopCount and isinstance(node, ast.Name):
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3853 self.assigns[node.id].append(node.lineno)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3854 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3855
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3856 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3857
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3858 def __checkFunction(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3859 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3860 Private method to check a function definition node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3861
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3862 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3863 @type ast.AsyncFunctionDef or ast.FunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3864 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3865 if not self.returns or not node.body:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3866 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3867
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3868 if len(node.body) == 1 and isinstance(node.body[-1], ast.Return):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3869 # skip functions that consist of `return None` only
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3870 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3871
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3872 if not self.__resultExists():
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3873 self.__checkUnnecessaryReturnNone()
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3874 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3875
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3876 self.__checkImplicitReturnValue()
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3877 self.__checkImplicitReturn(node.body[-1])
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3878
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3879 for n in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3880 if n.value:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3881 self.__checkUnnecessaryAssign(n.value)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3882
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3883 def __isNone(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3884 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3885 Private method to check, if a node value is None.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3886
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3887 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3888 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3889 @return flag indicating the node contains a None value
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3890 @rtype bool
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3891 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3892 return AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3893
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3894 def __isFalse(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3895 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3896 Private method to check, if a node value is False.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3897
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3898 @param node reference to the node to check
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3899 @type ast.AST
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3900 @return flag indicating the node contains a False value
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3901 @rtype bool
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3902 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3903 return (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3904 AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is False
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3905 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3906
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3907 def __resultExists(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3908 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3909 Private method to check the existance of a return result.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3910
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3911 @return flag indicating the existence of a return result
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3912 @rtype bool
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3913 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3914 for node in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3915 value = node.value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3916 if value and not self.__isNone(value):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3917 return True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3918
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3919 return False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3920
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3921 def __checkImplicitReturnValue(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3922 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3923 Private method to check for implicit return values.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3924 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3925 for node in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3926 if not node.value:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3927 self.violations.append((node, "M832"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3928
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3929 def __checkUnnecessaryReturnNone(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3930 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3931 Private method to check for an unnecessary 'return None' statement.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3932 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3933 for node in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3934 if self.__isNone(node.value):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3935 self.violations.append((node, "M831"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3936
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3937 def __checkImplicitReturn(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3938 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3939 Private method to check for an implicit return statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3940
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3941 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3942 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3943 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3944 if isinstance(node, ast.If):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3945 if not node.body or not node.orelse:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3946 self.violations.append((node, "M833"))
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3947 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3948
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3949 self.__checkImplicitReturn(node.body[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3950 self.__checkImplicitReturn(node.orelse[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3951 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3952
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3953 if isinstance(node, (ast.For, ast.AsyncFor)) and node.orelse:
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3954 self.__checkImplicitReturn(node.orelse[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3955 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3956
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3957 if isinstance(node, (ast.With, ast.AsyncWith)):
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3958 self.__checkImplicitReturn(node.body[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3959 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3960
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3961 if isinstance(node, ast.Assert) and self.__isFalse(node.test):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3962 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3963
6889
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
3964 try:
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
3965 okNodes = (ast.Return, ast.Raise, ast.While, ast.Try)
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
3966 except AttributeError:
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
3967 okNodes = (ast.Return, ast.Raise, ast.While)
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
3968 if not isinstance(node, okNodes):
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3969 self.violations.append((node, "M833"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3970
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3971 def __checkUnnecessaryAssign(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3972 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3973 Private method to check for an unnecessary assign statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3974
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3975 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3976 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3977 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3978 if not isinstance(node, ast.Name):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3979 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3980
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3981 varname = node.id
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3982 returnLineno = node.lineno
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3983
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3984 if varname not in self.assigns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3985 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3986
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3987 if varname not in self.refs:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3988 self.violations.append((node, "M834"))
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3989 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3990
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3991 if self.__hasRefsBeforeNextAssign(varname, returnLineno):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3992 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3993
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3994 self.violations.append((node, "M834"))
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3995
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3996 def __hasRefsBeforeNextAssign(self, varname, returnLineno):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3997 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3998 Private method to check for references before a following assign
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3999 statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4000
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4001 @param varname variable name to check for
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4002 @type str
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4003 @param returnLineno line number of the return statement
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4004 @type int
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4005 @return flag indicating the existence of references
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4006 @rtype bool
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4007 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4008 beforeAssign = 0
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4009 afterAssign = None
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4010
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4011 for lineno in sorted(self.assigns[varname]):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4012 if lineno > returnLineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4013 afterAssign = lineno
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4014 break
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4015
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4016 if lineno <= returnLineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4017 beforeAssign = lineno
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4018
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4019 for lineno in self.refs[varname]:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4020 if lineno == returnLineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4021 continue
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4022
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4023 if afterAssign:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4024 if beforeAssign < lineno <= afterAssign:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4025 return True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4026
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4027 elif beforeAssign < lineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4028 return True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4029
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4030 return False
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4031
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4032
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4033 class DateTimeVisitor(ast.NodeVisitor):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4034 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4035 Class implementing a node visitor to check datetime function calls.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4036
9274
86fab0c74430 Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9221
diff changeset
4037 Note: This class is modeled after flake8_datetimez checker.
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4038 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4039
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4040 def __init__(self):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4041 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4042 Constructor
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4043 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
4044 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4045
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4046 self.violations = []
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4047
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4048 def __getFromKeywords(self, keywords, name):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4049 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4050 Private method to get a keyword node given its name.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4051
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4052 @param keywords list of keyword argument nodes
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4053 @type list of ast.AST
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4054 @param name name of the keyword node
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4055 @type str
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4056 @return keyword node
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4057 @rtype ast.AST
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4058 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4059 for keyword in keywords:
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4060 if keyword.arg == name:
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4061 return keyword
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4062
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4063 return None
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4064
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4065 def visit_Call(self, node):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4066 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4067 Public method to handle a function call.
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4068
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4069 Every datetime related function call is check for use of the naive
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4070 variant (i.e. use without TZ info).
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4071
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4072 @param node reference to the node to be processed
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4073 @type ast.Call
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4074 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4075 # datetime.something()
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4076 isDateTimeClass = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4077 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4078 and isinstance(node.func.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4079 and node.func.value.id == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4080 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4081
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4082 # datetime.datetime.something()
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4083 isDateTimeModuleAndClass = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4084 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4085 and isinstance(node.func.value, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4086 and node.func.value.attr == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4087 and isinstance(node.func.value.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4088 and node.func.value.value.id == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4089 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4090
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4091 if isDateTimeClass:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4092 if node.func.attr == "datetime":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4093 # datetime.datetime(2000, 1, 1, 0, 0, 0, 0,
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4094 # datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4095 isCase1 = len(node.args) >= 8 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4096 AstUtilities.isNameConstant(node.args[7])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4097 and AstUtilities.getValue(node.args[7]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4098 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4099
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4100 # datetime.datetime(2000, 1, 1, tzinfo=datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4101 tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4102 isCase2 = tzinfoKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4103 AstUtilities.isNameConstant(tzinfoKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4104 and AstUtilities.getValue(tzinfoKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4105 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4106
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4107 if not (isCase1 or isCase2):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4108 self.violations.append((node, "M301"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4109
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4110 elif node.func.attr == "time":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4111 # time(12, 10, 45, 0, datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4112 isCase1 = len(node.args) >= 5 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4113 AstUtilities.isNameConstant(node.args[4])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4114 and AstUtilities.getValue(node.args[4]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4115 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4116
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4117 # datetime.time(12, 10, 45, tzinfo=datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4118 tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4119 isCase2 = tzinfoKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4120 AstUtilities.isNameConstant(tzinfoKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4121 and AstUtilities.getValue(tzinfoKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4122 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4123
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4124 if not (isCase1 or isCase2):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4125 self.violations.append((node, "M321"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4126
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4127 elif node.func.attr == "date":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4128 self.violations.append((node, "M311"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4129
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4130 if isDateTimeClass or isDateTimeModuleAndClass:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4131 if node.func.attr == "today":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4132 self.violations.append((node, "M302"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4133
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4134 elif node.func.attr == "utcnow":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4135 self.violations.append((node, "M303"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4136
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4137 elif node.func.attr == "utcfromtimestamp":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4138 self.violations.append((node, "M304"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4139
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4140 elif node.func.attr in "now":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4141 # datetime.now(UTC)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4142 isCase1 = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4143 len(node.args) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4144 and len(node.keywords) == 0
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4145 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4146 AstUtilities.isNameConstant(node.args[0])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4147 and AstUtilities.getValue(node.args[0]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4148 )
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4149 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4150
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4151 # datetime.now(tz=UTC)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4152 tzKeyword = self.__getFromKeywords(node.keywords, "tz")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4153 isCase2 = tzKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4154 AstUtilities.isNameConstant(tzKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4155 and AstUtilities.getValue(tzKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4156 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4157
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4158 if not (isCase1 or isCase2):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4159 self.violations.append((node, "M305"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4160
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4161 elif node.func.attr == "fromtimestamp":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4162 # datetime.fromtimestamp(1234, UTC)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4163 isCase1 = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4164 len(node.args) == 2
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4165 and len(node.keywords) == 0
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4166 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4167 AstUtilities.isNameConstant(node.args[1])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4168 and AstUtilities.getValue(node.args[1]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4169 )
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4170 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4171
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4172 # datetime.fromtimestamp(1234, tz=UTC)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4173 tzKeyword = self.__getFromKeywords(node.keywords, "tz")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4174 isCase2 = tzKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4175 AstUtilities.isNameConstant(tzKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4176 and AstUtilities.getValue(tzKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4177 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4178
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4179 if not (isCase1 or isCase2):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4180 self.violations.append((node, "M306"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4181
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4182 elif node.func.attr == "strptime":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4183 # datetime.strptime(...).replace(tzinfo=UTC)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4184 parent = getattr(node, "_dtCheckerParent", None)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4185 pparent = getattr(parent, "_dtCheckerParent", None)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4186 if not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4187 isinstance(parent, ast.Attribute) and parent.attr == "replace"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4188 ) or not isinstance(pparent, ast.Call):
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4189 isCase1 = False
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4190 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4191 tzinfoKeyword = self.__getFromKeywords(pparent.keywords, "tzinfo")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4192 isCase1 = tzinfoKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4193 AstUtilities.isNameConstant(tzinfoKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4194 and AstUtilities.getValue(tzinfoKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4195 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4196
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4197 if not isCase1:
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4198 self.violations.append((node, "M307"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4199
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4200 elif node.func.attr == "fromordinal":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4201 self.violations.append((node, "M308"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4202
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4203 # date.something()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4204 isDateClass = (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4205 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4206 and isinstance(node.func.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4207 and node.func.value.id == "date"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4208 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4209
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4210 # datetime.date.something()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4211 isDateModuleAndClass = (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4212 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4213 and isinstance(node.func.value, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4214 and node.func.value.attr == "date"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4215 and isinstance(node.func.value.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4216 and node.func.value.value.id == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4217 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4218
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4219 if isDateClass or isDateModuleAndClass:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4220 if node.func.attr == "today":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4221 self.violations.append((node, "M312"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4222
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4223 elif node.func.attr == "fromtimestamp":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4224 self.violations.append((node, "M313"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4225
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4226 elif node.func.attr == "fromordinal":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4227 self.violations.append((node, "M314"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4228
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4229 elif node.func.attr == "fromisoformat":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4230 self.violations.append((node, "M315"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4231
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4232 self.generic_visit(node)
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4233
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4234
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4235 class SysVersionVisitor(ast.NodeVisitor):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4236 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4237 Class implementing a node visitor to check the use of sys.version and
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4238 sys.version_info.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4239
9274
86fab0c74430 Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9221
diff changeset
4240 Note: This class is modeled after flake8-2020 checker.
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4241 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4242
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4243 def __init__(self):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4244 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4245 Constructor
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4246 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
4247 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4248
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4249 self.violations = []
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4250 self.__fromImports = {}
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4251
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4252 def visit_ImportFrom(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4253 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4254 Public method to handle a from ... import ... statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4255
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4256 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4257 @type ast.ImportFrom
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4258 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4259 for alias in node.names:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4260 if node.module is not None and not alias.asname:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4261 self.__fromImports[alias.name] = node.module
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4262
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4263 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4264
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4265 def __isSys(self, attr, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4266 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4267 Private method to check for a reference to sys attribute.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4268
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4269 @param attr attribute name
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4270 @type str
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4271 @param node reference to the node to be checked
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4272 @type ast.Node
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4273 @return flag indicating a match
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4274 @rtype bool
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4275 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4276 match = False
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4277 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4278 isinstance(node, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4279 and isinstance(node.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4280 and node.value.id == "sys"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4281 and node.attr == attr
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4282 ) or (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4283 isinstance(node, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4284 and node.id == attr
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4285 and self.__fromImports.get(node.id) == "sys"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4286 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4287 match = True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4288
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4289 return match
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4290
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4291 def __isSysVersionUpperSlice(self, node, n):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4292 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4293 Private method to check the upper slice of sys.version.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4294
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4295 @param node reference to the node to be checked
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4296 @type ast.Node
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4297 @param n slice value to check against
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4298 @type int
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4299 @return flag indicating a match
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4300 @rtype bool
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4301 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4302 return (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4303 self.__isSys("version", node.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4304 and isinstance(node.slice, ast.Slice)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4305 and node.slice.lower is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4306 and AstUtilities.isNumber(node.slice.upper)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4307 and AstUtilities.getValue(node.slice.upper) == n
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4308 and node.slice.step is None
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4309 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4310
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4311 def visit_Subscript(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4312 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4313 Public method to handle a subscript.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4314
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4315 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4316 @type ast.Subscript
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4317 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4318 if self.__isSysVersionUpperSlice(node, 1):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4319 self.violations.append((node.value, "M423"))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4320 elif self.__isSysVersionUpperSlice(node, 3):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4321 self.violations.append((node.value, "M401"))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4322 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4323 self.__isSys("version", node.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4324 and isinstance(node.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4325 and AstUtilities.isNumber(node.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4326 and AstUtilities.getValue(node.slice.value) == 2
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4327 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4328 self.violations.append((node.value, "M402"))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4329 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4330 self.__isSys("version", node.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4331 and isinstance(node.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4332 and AstUtilities.isNumber(node.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4333 and AstUtilities.getValue(node.slice.value) == 0
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4334 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4335 self.violations.append((node.value, "M421"))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4336
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4337 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4338
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4339 def visit_Compare(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4340 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4341 Public method to handle a comparison.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4342
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4343 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4344 @type ast.Compare
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4345 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4346 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4347 isinstance(node.left, ast.Subscript)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4348 and self.__isSys("version_info", node.left.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4349 and isinstance(node.left.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4350 and AstUtilities.isNumber(node.left.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4351 and AstUtilities.getValue(node.left.slice.value) == 0
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4352 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4353 and isinstance(node.ops[0], ast.Eq)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4354 and AstUtilities.isNumber(node.comparators[0])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4355 and AstUtilities.getValue(node.comparators[0]) == 3
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4356 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4357 self.violations.append((node.left, "M411"))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4358 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4359 self.__isSys("version", node.left)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4360 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4361 and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4362 and AstUtilities.isString(node.comparators[0])
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4363 ):
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4364 if len(AstUtilities.getValue(node.comparators[0])) == 1:
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4365 errorCode = "M422"
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4366 else:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4367 errorCode = "M403"
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4368 self.violations.append((node.left, errorCode))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4369 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4370 isinstance(node.left, ast.Subscript)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4371 and self.__isSys("version_info", node.left.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4372 and isinstance(node.left.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4373 and AstUtilities.isNumber(node.left.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4374 and AstUtilities.getValue(node.left.slice.value) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4375 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4376 and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4377 and AstUtilities.isNumber(node.comparators[0])
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4378 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4379 self.violations.append((node, "M413"))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4380 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4381 isinstance(node.left, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4382 and self.__isSys("version_info", node.left.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4383 and node.left.attr == "minor"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4384 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4385 and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4386 and AstUtilities.isNumber(node.comparators[0])
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4387 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4388 self.violations.append((node, "M414"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4389
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4390 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4391
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4392 def visit_Attribute(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4393 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4394 Public method to handle an attribute.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4395
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4396 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4397 @type ast.Attribute
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4398 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4399 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4400 isinstance(node.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4401 and node.value.id == "six"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4402 and node.attr == "PY3"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4403 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4404 self.violations.append((node, "M412"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4405
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4406 self.generic_visit(node)
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4407
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4408 def visit_Name(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4409 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4410 Public method to handle an name.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4411
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4412 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4413 @type ast.Name
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4414 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4415 if node.id == "PY3" and self.__fromImports.get(node.id) == "six":
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4416 self.violations.append((node, "M412"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4417
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4418 self.generic_visit(node)
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4419
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4420
4555
861e1741985c Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents: 4540
diff changeset
4421 #
7639
422fd05e9c91 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7637
diff changeset
4422 # eflag: noqa = M891

eric ide

mercurial