src/eric7/Plugins/CheckerPlugins/CodeStyleChecker/Unused/UnusedChecker.py

Mon, 24 Feb 2025 15:43:49 +0100

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Mon, 24 Feb 2025 15:43:49 +0100
branch
eric7
changeset 11148
15e30f0c76a8
parent 11147
dee6e106b4d3
child 11150
73d80859079c
permissions
-rw-r--r--

Adjusted the code to the modified issue codes.

10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
1 # -*- coding: utf-8 -*-
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
2
11090
f5f5f5803935 Updated copyright for 2025.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3 # Copyright (c) 2023 - 2025 Detlev Offenbach <detlev@die-offenbachs.de>
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
4 #
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
5
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
6 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
7 Module implementing a checker for unused arguments, variables, ... .
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
8 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
9
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
10 import ast
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
11 import collections
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
12 import copy
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
13
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
14 import AstUtilities
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
15
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
16
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
17 class UnusedChecker:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
18 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
19 Class implementing a checker for unused arguments, variables, ... .
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
20 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
21
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
22 Codes = [
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
23 ## Unused Arguments
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
24 "U-100",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
25 "U-101",
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
26 ## Unused Globals
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
27 "U-200",
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
28 ]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
29
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
30 def __init__(self, source, filename, tree, select, ignore, expected, repeat, args):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
31 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
32 Constructor
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
33
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
34 @param source source code to be checked
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
35 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
36 @param filename name of the source file
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
37 @type str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
38 @param tree AST tree of the source code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
39 @type ast.Module
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
40 @param select list of selected codes
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
41 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
42 @param ignore list of codes to be ignored
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
43 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
44 @param expected list of expected codes
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
45 @type list of str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
46 @param repeat flag indicating to report each occurrence of a code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
47 @type bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
48 @param args dictionary of arguments for the various checks
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
49 @type dict
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
50 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
51 self.__select = tuple(select)
11142
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
52 self.__ignore = tuple(ignore)
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
53 self.__expected = expected[:]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
54 self.__repeat = repeat
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
55 self.__filename = filename
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
56 self.__source = source[:]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
57 self.__tree = copy.deepcopy(tree)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
58 self.__args = args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
59
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
60 # statistics counters
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
61 self.counters = {}
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
62
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
63 # collection of detected errors
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
64 self.errors = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
65
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
66 checkersWithCodes = [
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
67 (self.__checkUnusedArguments, ("U-100", "U-101")),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
68 (self.__checkUnusedGlobals, ("U-200",)),
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
69 ]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
70
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
71 self.__checkers = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
72 for checker, codes in checkersWithCodes:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
73 if any(not (code and self.__ignoreCode(code)) for code in codes):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
74 self.__checkers.append(checker)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
75
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
76 def __ignoreCode(self, code):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
77 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
78 Private method to check if the message code should be ignored.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
79
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
80 @param code message code to check for
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
81 @type str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
82 @return flag indicating to ignore the given code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
83 @rtype bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
84 """
11145
d328a7b74fd8 Corrected some code formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11142
diff changeset
85 return code in self.__ignore or (
d328a7b74fd8 Corrected some code formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11142
diff changeset
86 code.startswith(self.__ignore) and not code.startswith(self.__select)
11142
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
87 )
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
88
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
89 def __error(self, lineNumber, offset, code, *args):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
90 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
91 Private method to record an issue.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
92
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
93 @param lineNumber line number of the issue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
94 @type int
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
95 @param offset position within line of the issue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
96 @type int
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
97 @param code message code
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
98 @type str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
99 @param args arguments for the message
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
100 @type list
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
101 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
102 if self.__ignoreCode(code):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
103 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
104
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
105 if code in self.counters:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
106 self.counters[code] += 1
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
107 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
108 self.counters[code] = 1
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
109
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
110 # Don't care about expected codes
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
111 if code in self.__expected:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
112 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
113
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
114 if code and (self.counters[code] == 1 or self.__repeat):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
115 # record the issue with one based line number
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
116 self.errors.append(
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
117 {
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
118 "file": self.__filename,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
119 "line": lineNumber + 1,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
120 "offset": offset,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
121 "code": code,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
122 "args": args,
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
123 }
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
124 )
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
125
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
126 def run(self):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
127 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
128 Public method to check the given source against miscellaneous
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
129 conditions.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
130 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
131 if not self.__filename:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
132 # don't do anything, if essential data is missing
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
133 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
134
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
135 if not self.__checkers:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
136 # don't do anything, if no codes were selected
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
137 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
138
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
139 for check in self.__checkers:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
140 check()
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
141
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
142 #######################################################################
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
143 ## Unused Arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
144 ##
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
145 ## adapted from: flake8-unused-arguments v0.0.13
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
146 #######################################################################
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
147
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
148 def __checkUnusedArguments(self):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
149 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
150 Private method to check function and method definitions for unused arguments.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
151 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
152 finder = FunctionFinder(self.__args["IgnoreNestedFunctions"])
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
153 finder.visit(self.__tree)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
154
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
155 for functionNode in finder.functionNodes():
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
156 decoratorNames = set(self.__getDecoratorNames(functionNode))
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
157
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
158 # ignore overload functions, it's not a surprise when they're empty
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
159 if self.__args["IgnoreOverload"] and "overload" in decoratorNames:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
160 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
161
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
162 # ignore overridden functions
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
163 if self.__args["IgnoreOverride"] and "override" in decoratorNames:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
164 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
165
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
166 # ignore abstractmethods, it's not a surprise when they're empty
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
167 if self.__args["IgnoreAbstract"] and "abstractmethod" in decoratorNames:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
168 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
169
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
170 # ignore Qt slot methods
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
171 if self.__args["IgnoreSlotMethods"] and (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
172 "pyqtSlot" in decoratorNames or "Slot" in decoratorNames
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
173 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
174 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
175
10066
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
176 if self.__args["IgnoreEventHandlerMethods"] and self.__isEventHandlerMethod(
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
177 functionNode
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
178 ):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
179 continue
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
180
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
181 # ignore stub functions
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
182 if self.__args["IgnoreStubs"] and self.__isStubFunction(functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
183 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
184
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
185 # ignore lambdas
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
186 if self.__args["IgnoreLambdas"] and isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
187 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
188
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
189 # ignore __double_underscore_methods__()
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
190 if self.__args["IgnoreDunderMethods"] and self.__isDunderMethod(
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
191 functionNode
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
192 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
193 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
194
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
195 for i, argument in self.__getUnusedArguments(functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
196 name = argument.arg
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
197 if self.__args["IgnoreVariadicNames"]:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
198 if (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
199 functionNode.args.vararg
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
200 and functionNode.args.vararg.arg == name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
201 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
202 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
203 if functionNode.args.kwarg and functionNode.args.kwarg.arg == name:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
204 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
205
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
206 # ignore self or whatever the first argument is for a classmethod
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
207 if i == 0 and (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
208 name in ("self", "cls") or "classmethod" in decoratorNames
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
209 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
210 continue
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
211
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
212 lineNumber = argument.lineno
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
213 offset = argument.col_offset
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
214
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
215 errorCode = "U-101" if name.startswith("_") else "U-100"
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
216 self.__error(lineNumber - 1, offset, errorCode, name)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
217
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
218 def __getDecoratorNames(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
219 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
220 Private method to yield the decorator names of the function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
221
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
222 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
223 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
224 @yield decorator name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
225 @ytype str
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
226 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
227 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
228 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
229
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
230 for decorator in functionNode.decorator_list:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
231 if isinstance(decorator, ast.Name):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
232 yield decorator.id
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
233 elif isinstance(decorator, ast.Attribute):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
234 yield decorator.attr
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
235 elif isinstance(decorator, ast.Call):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
236 if isinstance(decorator.func, ast.Name):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
237 yield decorator.func.id
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
238 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
239 yield decorator.func.attr
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
240
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
241 def __isStubFunction(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
242 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
243 Private method to check, if the given function node defines a stub function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
244
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
245 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
246 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
247 @return flag indicating a stub function
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
248 @rtype bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
249 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
250 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
251 return AstUtilities.isEllipsis(functionNode.body)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
252
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
253 statement = functionNode.body[0]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
254 if isinstance(statement, ast.Expr) and AstUtilities.isString(statement.value):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
255 if len(functionNode.body) > 1:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
256 # first statement is a docstring, let's skip it
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
257 statement = functionNode.body[1]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
258 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
259 # it's a function with only a docstring, that's a stub
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
260 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
261
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
262 if isinstance(statement, ast.Pass):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
263 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
264 if isinstance(statement, ast.Expr) and AstUtilities.isEllipsis(statement.value):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
265 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
266
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
267 if isinstance(statement, ast.Raise):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
268 # like 'raise NotImplementedError()'
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
269 if (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
270 isinstance(statement.exc, ast.Call)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
271 and hasattr(statement.exc.func, "id")
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
272 and statement.exc.func.id == "NotImplementedError"
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
273 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
274 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
275
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
276 # like 'raise NotImplementedError'
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
277 elif (
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
278 isinstance(statement.exc, ast.Name)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
279 and hasattr(statement.exc, "id")
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
280 and statement.exc.id == "NotImplementedError"
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
281 ):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
282 return True
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
283
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
284 return False
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
285
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
286 def __isDunderMethod(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
287 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
288 Private method to check, if the function node defines a special function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
289
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
290 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
291 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
292 @return flag indicating a special function
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
293 @rtype bool
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
294 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
295 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
296 return False
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
297
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
298 if not hasattr(functionNode, "name"):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
299 return False
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
300
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
301 name = functionNode.name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
302 return len(name) > 4 and name.startswith("__") and name.endswith("__")
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
303
10066
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
304 def __isEventHandlerMethod(self, functionNode):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
305 """
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
306 Private method to check, if the function node defines a Qt event handler.
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
307
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
308 Qt event handler methods are assumed to end with 'Event' or have the name
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
309 'event' or 'eventFilter'. Only standard methodes (i.e. ast.FunctionDef)
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
310 are assumed to be potential event handlers.
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
311
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
312 @param functionNode reference to the node defining the function or lambda
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
313 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
314 @return flag indicating a Qt event handler method
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
315 @rtype bool
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
316 """
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
317 if isinstance(functionNode, (ast.Lambda, ast.AsyncFunctionDef)):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
318 return False
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
319
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
320 if not hasattr(functionNode, "name"):
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
321 return False
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
322
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
323 name = functionNode.name
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
324 return name.endswith("Event") or name in ("event", "eventFilter")
251638443e17 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10056
diff changeset
325
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
326 def __getUnusedArguments(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
327 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
328 Private method to get a list of unused arguments of the given function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
329
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
330 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
331 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
332 @return list of tuples of the argument position and the argument
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
333 @rtype list of tuples of (int, ast.arg)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
334 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
335 arguments = list(enumerate(self.__getArguments(functionNode)))
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
336
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
337 class NameFinder(ast.NodeVisitor):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
338 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
339 Class to find the used argument names.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
340 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
341
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
342 def visit_Name(self, name):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
343 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
344 Public method to check a Name node.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
345
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
346 @param name reference to the name node to be checked
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
347 @type ast.Name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
348 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
349 nonlocal arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
350
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
351 if isinstance(name.ctx, ast.Store):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
352 return
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
353
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
354 arguments = [
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
355 (argIndex, arg) for argIndex, arg in arguments if arg.arg != name.id
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
356 ]
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
357
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
358 NameFinder().visit(functionNode)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
359 return arguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
360
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
361 def __getArguments(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
362 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
363 Private method to get all argument names of the given function.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
364
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
365 @param functionNode reference to the node defining the function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
366 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
367 @return list of argument names
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
368 @rtype list of ast.arg
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
369 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
370 args = functionNode.args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
371
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
372 orderedArguments = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
373
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
374 # plain old args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
375 orderedArguments.extend(args.args)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
376
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
377 # *arg name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
378 if args.vararg is not None:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
379 orderedArguments.append(args.vararg)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
380
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
381 # *, key, word, only, args
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
382 orderedArguments.extend(args.kwonlyargs)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
383
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
384 # **kwarg name
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
385 if args.kwarg is not None:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
386 orderedArguments.append(args.kwarg)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
387
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
388 return orderedArguments
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
389
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
390 #######################################################################
10056
ac1c214e0a05 Corrected some comments.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10054
diff changeset
391 ## Unused Globals
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
392 ##
10185
29e896e9e74e Updated some codestyle checkers for imports and too complex annotations.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10127
diff changeset
393 ## adapted from: flake8-unused-globals v0.1.10
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
394 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
395
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
396 def __checkUnusedGlobals(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
397 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
398 Private method to check for unused global variables.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
399 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
400 errors = {}
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
401 loadCounter = GlobalVariableLoadCounter()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
402 loadCounter.visit(self.__tree)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
403
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
404 globalVariables = self.__extractGlobalVariables()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
405
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
406 for varId, loads in loadCounter.getLoads():
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
407 if varId in globalVariables and loads == 0:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
408 storeInfo = loadCounter.getStoreInfo(varId)
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
409 errorInfo = (storeInfo.lineno - 1, storeInfo.offset, "U-200", varId)
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
410 errors[varId] = errorInfo
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
411
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
412 for node in self.__tree.body[::-1]:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
413 if isinstance(node, ast.Assign):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
414 for target in node.targets:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
415 if isinstance(target, ast.Name) and target.id in errors:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
416 errors.pop(target.id)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
417 elif (
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
418 isinstance(node, ast.AnnAssign)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
419 and isinstance(node.target, ast.Name)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
420 and node.target.id in errors
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
421 ):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
422 errors.pop(node.target.id)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
423 else:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
424 break
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
425
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
426 if self.__args["IgnoreDunderGlobals"]:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
427 # eliminate some special cases
10373
093dcebe5ecb Corrected some uses of dict.keys(), dict.values() and dict.items().
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10185
diff changeset
428 for name in list(errors):
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
429 if name.startswith("__") and name.endswith("__"):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
430 errors.pop(name)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
431
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
432 for varId in errors:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
433 self.__error(*errors[varId])
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
434
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
435 def __extractGlobalVariables(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
436 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
437 Private method to get the names of all global variables.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
438
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
439 @return set containing the defined global variable names
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
440 @rtype set of str
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
441 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
442 variables = set()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
443
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
444 for assignment in self.__tree.body:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
445 if isinstance(assignment, ast.Assign):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
446 for target in assignment.targets:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
447 if isinstance(target, ast.Name):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
448 variables.add(target.id)
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
449 elif isinstance(assignment, ast.AnnAssign) and isinstance(
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
450 assignment.target, ast.Name
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
451 ):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
452 variables.add(assignment.target.id)
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
453
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
454 return variables
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
455
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
456
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
457 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
458 ## Class used by 'Unused Arguments'
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
459 ##
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
460 ## adapted from: flake8-unused-arguments v0.0.13
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
461 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
462
10052
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
463
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
464 class FunctionFinder(ast.NodeVisitor):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
465 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
466 Class to find all defined functions and methods.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
467 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
468
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
469 def __init__(self, onlyTopLevel=False):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
470 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
471 Constructor
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
472
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
473 @param onlyTopLevel flag indicating to search for top level functions only
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
474 (defaults to False)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
475 @type bool (optional)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
476 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
477 super().__init__()
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
478
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
479 self.__functions = []
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
480 self.__onlyTopLevel = onlyTopLevel
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
481
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
482 def functionNodes(self):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
483 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
484 Public method to get the list of detected functions and lambdas.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
485
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
486 @return list of detected functions and lambdas
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
487 @rtype list of ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
488 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
489 return self.__functions
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
490
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
491 def __visitFunctionTypes(self, functionNode):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
492 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
493 Private method to handle an AST node defining a function or lambda.
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
494
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
495 @param functionNode reference to the node defining a function or lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
496 @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
497 """
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
498 self.__functions.append(functionNode)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
499 if not self.__onlyTopLevel:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
500 if isinstance(functionNode, ast.Lambda):
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
501 self.visit(functionNode.body)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
502 else:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
503 for obj in functionNode.body:
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
504 self.visit(obj)
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
505
041d0785dd42 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
506 visit_AsyncFunctionDef = visit_FunctionDef = visit_Lambda = __visitFunctionTypes
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
507
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
508
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
509 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
510 ## Class used by 'Unused Globals'
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
511 ##
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
512 ## adapted from: flake8-unused-globals v0.1.9
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
513 #######################################################################
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
514
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
515
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
516 GlobalVariableStoreInfo = collections.namedtuple(
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
517 "GlobalVariableStoreInfo", ["lineno", "offset"]
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
518 )
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
519
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
520
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
521 class GlobalVariableLoadCounter(ast.NodeVisitor):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
522 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
523 Class to find all defined global variables and count their usages.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
524 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
525
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
526 def __init__(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
527 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
528 Constructor
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
529 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
530 super().__init__()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
531
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
532 self.__loads = {}
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
533 self.__storeInfo = {}
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
534
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
535 def visit_Name(self, nameNode):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
536 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
537 Public method to record the definition and use of a global variable.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
538
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
539 @param nameNode reference to the name node to be processed
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
540 @type ast.Name
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
541 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
542 if isinstance(nameNode.ctx, ast.Load) and nameNode.id in self.__loads:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
543 self.__loads[nameNode.id] += 1
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
544 elif (
10054
d7a47f0cff2b Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10053
diff changeset
545 isinstance(nameNode.ctx, ast.Store) and nameNode.id not in self.__storeInfo
10053
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
546 ):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
547 self.__loads[nameNode.id] = 0
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
548 self.__storeInfo[nameNode.id] = GlobalVariableStoreInfo(
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
549 lineno=nameNode.lineno, offset=nameNode.col_offset
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
550 )
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
551
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
552 def getLoads(self):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
553 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
554 Public method to get an iterator of the detected variable loads.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
555
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
556 @return DESCRIPTION
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
557 @rtype TYPE
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
558 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
559 return self.__loads.items()
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
560
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
561 def getStoreInfo(self, variableId):
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
562 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
563 Public method to get the store info data of a given variable ID.
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
564
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
565 @param variableId variable ID to retrieve the store info for
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
566 @type str
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
567 @return named tuple containing the line number and column offset
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
568 @rtype GlobalVariableStoreInfo
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
569 """
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
570 try:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
571 return self.__storeInfo[variableId]
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
572 except KeyError:
9914b7b4b11c Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10052
diff changeset
573 return None

eric ide

mercurial