Mon, 24 Feb 2025 15:43:49 +0100
Adjusted the code to the modified issue codes.
10052 | 1 | # -*- coding: utf-8 -*- |
2 | ||
11090
f5f5f5803935
Updated copyright for 2025.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10439
diff
changeset
|
3 | # Copyright (c) 2023 - 2025 Detlev Offenbach <detlev@die-offenbachs.de> |
10052 | 4 | # |
5 | ||
6 | """ | |
7 | Module implementing a checker for unused arguments, variables, ... . | |
8 | """ | |
9 | ||
10 | import ast | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
11 | import collections |
10052 | 12 | import copy |
13 | ||
14 | import AstUtilities | |
15 | ||
16 | ||
17 | class UnusedChecker: | |
18 | """ | |
19 | Class implementing a checker for unused arguments, variables, ... . | |
20 | """ | |
21 | ||
22 | Codes = [ | |
23 | ## Unused Arguments | |
11147
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
24 | "U-100", |
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
25 | "U-101", |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
26 | ## Unused Globals |
11147
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
27 | "U-200", |
10052 | 28 | ] |
29 | ||
30 | def __init__(self, source, filename, tree, select, ignore, expected, repeat, args): | |
31 | """ | |
32 | Constructor | |
33 | ||
34 | @param source source code to be checked | |
35 | @type list of str | |
36 | @param filename name of the source file | |
37 | @type str | |
38 | @param tree AST tree of the source code | |
39 | @type ast.Module | |
40 | @param select list of selected codes | |
41 | @type list of str | |
42 | @param ignore list of codes to be ignored | |
43 | @type list of str | |
44 | @param expected list of expected codes | |
45 | @type list of str | |
46 | @param repeat flag indicating to report each occurrence of a code | |
47 | @type bool | |
48 | @param args dictionary of arguments for the various checks | |
49 | @type dict | |
50 | """ | |
51 | self.__select = tuple(select) | |
11142
2f0fb22c1d63
Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
52 | self.__ignore = tuple(ignore) |
10052 | 53 | self.__expected = expected[:] |
54 | self.__repeat = repeat | |
55 | self.__filename = filename | |
56 | self.__source = source[:] | |
57 | self.__tree = copy.deepcopy(tree) | |
58 | self.__args = args | |
59 | ||
60 | # statistics counters | |
61 | self.counters = {} | |
62 | ||
63 | # collection of detected errors | |
64 | self.errors = [] | |
65 | ||
66 | checkersWithCodes = [ | |
11147
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
67 | (self.__checkUnusedArguments, ("U-100", "U-101")), |
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
68 | (self.__checkUnusedGlobals, ("U-200",)), |
10052 | 69 | ] |
70 | ||
71 | self.__checkers = [] | |
72 | for checker, codes in checkersWithCodes: | |
73 | if any(not (code and self.__ignoreCode(code)) for code in codes): | |
74 | self.__checkers.append(checker) | |
75 | ||
76 | def __ignoreCode(self, code): | |
77 | """ | |
78 | Private method to check if the message code should be ignored. | |
79 | ||
80 | @param code message code to check for | |
81 | @type str | |
82 | @return flag indicating to ignore the given code | |
83 | @rtype bool | |
84 | """ | |
11145
d328a7b74fd8
Corrected some code formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11142
diff
changeset
|
85 | return code in self.__ignore or ( |
d328a7b74fd8
Corrected some code formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11142
diff
changeset
|
86 | code.startswith(self.__ignore) and not code.startswith(self.__select) |
11142
2f0fb22c1d63
Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11090
diff
changeset
|
87 | ) |
10052 | 88 | |
89 | def __error(self, lineNumber, offset, code, *args): | |
90 | """ | |
91 | Private method to record an issue. | |
92 | ||
93 | @param lineNumber line number of the issue | |
94 | @type int | |
95 | @param offset position within line of the issue | |
96 | @type int | |
97 | @param code message code | |
98 | @type str | |
99 | @param args arguments for the message | |
100 | @type list | |
101 | """ | |
102 | if self.__ignoreCode(code): | |
103 | return | |
104 | ||
105 | if code in self.counters: | |
106 | self.counters[code] += 1 | |
107 | else: | |
108 | self.counters[code] = 1 | |
109 | ||
110 | # Don't care about expected codes | |
111 | if code in self.__expected: | |
112 | return | |
113 | ||
114 | if code and (self.counters[code] == 1 or self.__repeat): | |
115 | # record the issue with one based line number | |
116 | self.errors.append( | |
117 | { | |
118 | "file": self.__filename, | |
119 | "line": lineNumber + 1, | |
120 | "offset": offset, | |
121 | "code": code, | |
122 | "args": args, | |
123 | } | |
124 | ) | |
125 | ||
126 | def run(self): | |
127 | """ | |
128 | Public method to check the given source against miscellaneous | |
129 | conditions. | |
130 | """ | |
131 | if not self.__filename: | |
132 | # don't do anything, if essential data is missing | |
133 | return | |
134 | ||
135 | if not self.__checkers: | |
136 | # don't do anything, if no codes were selected | |
137 | return | |
138 | ||
139 | for check in self.__checkers: | |
140 | check() | |
141 | ||
142 | ####################################################################### | |
143 | ## Unused Arguments | |
144 | ## | |
145 | ## adapted from: flake8-unused-arguments v0.0.13 | |
146 | ####################################################################### | |
147 | ||
148 | def __checkUnusedArguments(self): | |
149 | """ | |
150 | Private method to check function and method definitions for unused arguments. | |
151 | """ | |
152 | finder = FunctionFinder(self.__args["IgnoreNestedFunctions"]) | |
153 | finder.visit(self.__tree) | |
154 | ||
155 | for functionNode in finder.functionNodes(): | |
156 | decoratorNames = set(self.__getDecoratorNames(functionNode)) | |
157 | ||
158 | # ignore overload functions, it's not a surprise when they're empty | |
159 | if self.__args["IgnoreOverload"] and "overload" in decoratorNames: | |
160 | continue | |
161 | ||
162 | # ignore overridden functions | |
163 | if self.__args["IgnoreOverride"] and "override" in decoratorNames: | |
164 | continue | |
165 | ||
166 | # ignore abstractmethods, it's not a surprise when they're empty | |
167 | if self.__args["IgnoreAbstract"] and "abstractmethod" in decoratorNames: | |
168 | continue | |
169 | ||
170 | # ignore Qt slot methods | |
171 | if self.__args["IgnoreSlotMethods"] and ( | |
172 | "pyqtSlot" in decoratorNames or "Slot" in decoratorNames | |
173 | ): | |
174 | continue | |
175 | ||
10066
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
176 | if self.__args["IgnoreEventHandlerMethods"] and self.__isEventHandlerMethod( |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
177 | functionNode |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
178 | ): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
179 | continue |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
180 | |
10052 | 181 | # ignore stub functions |
182 | if self.__args["IgnoreStubs"] and self.__isStubFunction(functionNode): | |
183 | continue | |
184 | ||
185 | # ignore lambdas | |
186 | if self.__args["IgnoreLambdas"] and isinstance(functionNode, ast.Lambda): | |
187 | continue | |
188 | ||
189 | # ignore __double_underscore_methods__() | |
190 | if self.__args["IgnoreDunderMethods"] and self.__isDunderMethod( | |
191 | functionNode | |
192 | ): | |
193 | continue | |
194 | ||
195 | for i, argument in self.__getUnusedArguments(functionNode): | |
196 | name = argument.arg | |
197 | if self.__args["IgnoreVariadicNames"]: | |
198 | if ( | |
199 | functionNode.args.vararg | |
200 | and functionNode.args.vararg.arg == name | |
201 | ): | |
202 | continue | |
203 | if functionNode.args.kwarg and functionNode.args.kwarg.arg == name: | |
204 | continue | |
205 | ||
206 | # ignore self or whatever the first argument is for a classmethod | |
207 | if i == 0 and ( | |
208 | name in ("self", "cls") or "classmethod" in decoratorNames | |
209 | ): | |
210 | continue | |
211 | ||
212 | lineNumber = argument.lineno | |
213 | offset = argument.col_offset | |
214 | ||
11147
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
215 | errorCode = "U-101" if name.startswith("_") else "U-100" |
10052 | 216 | self.__error(lineNumber - 1, offset, errorCode, name) |
217 | ||
218 | def __getDecoratorNames(self, functionNode): | |
219 | """ | |
220 | Private method to yield the decorator names of the function. | |
221 | ||
222 | @param functionNode reference to the node defining the function or lambda | |
223 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
224 | @yield decorator name | |
225 | @ytype str | |
226 | """ | |
227 | if isinstance(functionNode, ast.Lambda): | |
228 | return | |
229 | ||
230 | for decorator in functionNode.decorator_list: | |
231 | if isinstance(decorator, ast.Name): | |
232 | yield decorator.id | |
233 | elif isinstance(decorator, ast.Attribute): | |
234 | yield decorator.attr | |
235 | elif isinstance(decorator, ast.Call): | |
236 | if isinstance(decorator.func, ast.Name): | |
237 | yield decorator.func.id | |
238 | else: | |
239 | yield decorator.func.attr | |
240 | ||
241 | def __isStubFunction(self, functionNode): | |
242 | """ | |
243 | Private method to check, if the given function node defines a stub function. | |
244 | ||
245 | @param functionNode reference to the node defining the function or lambda | |
246 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
247 | @return flag indicating a stub function | |
248 | @rtype bool | |
249 | """ | |
250 | if isinstance(functionNode, ast.Lambda): | |
251 | return AstUtilities.isEllipsis(functionNode.body) | |
252 | ||
253 | statement = functionNode.body[0] | |
254 | if isinstance(statement, ast.Expr) and AstUtilities.isString(statement.value): | |
255 | if len(functionNode.body) > 1: | |
256 | # first statement is a docstring, let's skip it | |
257 | statement = functionNode.body[1] | |
258 | else: | |
259 | # it's a function with only a docstring, that's a stub | |
260 | return True | |
261 | ||
262 | if isinstance(statement, ast.Pass): | |
263 | return True | |
264 | if isinstance(statement, ast.Expr) and AstUtilities.isEllipsis(statement.value): | |
265 | return True | |
266 | ||
267 | if isinstance(statement, ast.Raise): | |
268 | # like 'raise NotImplementedError()' | |
269 | if ( | |
270 | isinstance(statement.exc, ast.Call) | |
271 | and hasattr(statement.exc.func, "id") | |
272 | and statement.exc.func.id == "NotImplementedError" | |
273 | ): | |
274 | return True | |
275 | ||
276 | # like 'raise NotImplementedError' | |
277 | elif ( | |
278 | isinstance(statement.exc, ast.Name) | |
279 | and hasattr(statement.exc, "id") | |
280 | and statement.exc.id == "NotImplementedError" | |
281 | ): | |
282 | return True | |
283 | ||
284 | return False | |
285 | ||
286 | def __isDunderMethod(self, functionNode): | |
287 | """ | |
288 | Private method to check, if the function node defines a special function. | |
289 | ||
290 | @param functionNode reference to the node defining the function or lambda | |
291 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
292 | @return flag indicating a special function | |
293 | @rtype bool | |
294 | """ | |
295 | if isinstance(functionNode, ast.Lambda): | |
296 | return False | |
297 | ||
298 | if not hasattr(functionNode, "name"): | |
299 | return False | |
300 | ||
301 | name = functionNode.name | |
302 | return len(name) > 4 and name.startswith("__") and name.endswith("__") | |
303 | ||
10066
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
304 | def __isEventHandlerMethod(self, functionNode): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
305 | """ |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
306 | Private method to check, if the function node defines a Qt event handler. |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
307 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
308 | Qt event handler methods are assumed to end with 'Event' or have the name |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
309 | 'event' or 'eventFilter'. Only standard methodes (i.e. ast.FunctionDef) |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
310 | are assumed to be potential event handlers. |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
311 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
312 | @param functionNode reference to the node defining the function or lambda |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
313 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
314 | @return flag indicating a Qt event handler method |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
315 | @rtype bool |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
316 | """ |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
317 | if isinstance(functionNode, (ast.Lambda, ast.AsyncFunctionDef)): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
318 | return False |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
319 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
320 | if not hasattr(functionNode, "name"): |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
321 | return False |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
322 | |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
323 | name = functionNode.name |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
324 | return name.endswith("Event") or name in ("event", "eventFilter") |
251638443e17
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10056
diff
changeset
|
325 | |
10052 | 326 | def __getUnusedArguments(self, functionNode): |
327 | """ | |
328 | Private method to get a list of unused arguments of the given function. | |
329 | ||
330 | @param functionNode reference to the node defining the function or lambda | |
331 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
332 | @return list of tuples of the argument position and the argument | |
333 | @rtype list of tuples of (int, ast.arg) | |
334 | """ | |
335 | arguments = list(enumerate(self.__getArguments(functionNode))) | |
336 | ||
337 | class NameFinder(ast.NodeVisitor): | |
338 | """ | |
339 | Class to find the used argument names. | |
340 | """ | |
341 | ||
342 | def visit_Name(self, name): | |
343 | """ | |
344 | Public method to check a Name node. | |
345 | ||
346 | @param name reference to the name node to be checked | |
347 | @type ast.Name | |
348 | """ | |
349 | nonlocal arguments | |
350 | ||
351 | if isinstance(name.ctx, ast.Store): | |
352 | return | |
353 | ||
354 | arguments = [ | |
355 | (argIndex, arg) for argIndex, arg in arguments if arg.arg != name.id | |
356 | ] | |
357 | ||
358 | NameFinder().visit(functionNode) | |
359 | return arguments | |
360 | ||
361 | def __getArguments(self, functionNode): | |
362 | """ | |
363 | Private method to get all argument names of the given function. | |
364 | ||
365 | @param functionNode reference to the node defining the function or lambda | |
366 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
367 | @return list of argument names | |
368 | @rtype list of ast.arg | |
369 | """ | |
370 | args = functionNode.args | |
371 | ||
372 | orderedArguments = [] | |
373 | ||
374 | # plain old args | |
375 | orderedArguments.extend(args.args) | |
376 | ||
377 | # *arg name | |
378 | if args.vararg is not None: | |
379 | orderedArguments.append(args.vararg) | |
380 | ||
381 | # *, key, word, only, args | |
382 | orderedArguments.extend(args.kwonlyargs) | |
383 | ||
384 | # **kwarg name | |
385 | if args.kwarg is not None: | |
386 | orderedArguments.append(args.kwarg) | |
387 | ||
388 | return orderedArguments | |
389 | ||
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
390 | ####################################################################### |
10056
ac1c214e0a05
Corrected some comments.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10054
diff
changeset
|
391 | ## Unused Globals |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
392 | ## |
10185
29e896e9e74e
Updated some codestyle checkers for imports and too complex annotations.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10127
diff
changeset
|
393 | ## adapted from: flake8-unused-globals v0.1.10 |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
394 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
395 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
396 | def __checkUnusedGlobals(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
397 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
398 | Private method to check for unused global variables. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
399 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
400 | errors = {} |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
401 | loadCounter = GlobalVariableLoadCounter() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
402 | loadCounter.visit(self.__tree) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
403 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
404 | globalVariables = self.__extractGlobalVariables() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
405 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
406 | for varId, loads in loadCounter.getLoads(): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
407 | if varId in globalVariables and loads == 0: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
408 | storeInfo = loadCounter.getStoreInfo(varId) |
11147
dee6e106b4d3
Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
11145
diff
changeset
|
409 | errorInfo = (storeInfo.lineno - 1, storeInfo.offset, "U-200", varId) |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
410 | errors[varId] = errorInfo |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
411 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
412 | for node in self.__tree.body[::-1]: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
413 | if isinstance(node, ast.Assign): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
414 | for target in node.targets: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
415 | if isinstance(target, ast.Name) and target.id in errors: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
416 | errors.pop(target.id) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
417 | elif ( |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
418 | isinstance(node, ast.AnnAssign) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
419 | and isinstance(node.target, ast.Name) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
420 | and node.target.id in errors |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
421 | ): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
422 | errors.pop(node.target.id) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
423 | else: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
424 | break |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
425 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
426 | if self.__args["IgnoreDunderGlobals"]: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
427 | # eliminate some special cases |
10373
093dcebe5ecb
Corrected some uses of dict.keys(), dict.values() and dict.items().
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10185
diff
changeset
|
428 | for name in list(errors): |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
429 | if name.startswith("__") and name.endswith("__"): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
430 | errors.pop(name) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
431 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
432 | for varId in errors: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
433 | self.__error(*errors[varId]) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
434 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
435 | def __extractGlobalVariables(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
436 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
437 | Private method to get the names of all global variables. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
438 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
439 | @return set containing the defined global variable names |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
440 | @rtype set of str |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
441 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
442 | variables = set() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
443 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
444 | for assignment in self.__tree.body: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
445 | if isinstance(assignment, ast.Assign): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
446 | for target in assignment.targets: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
447 | if isinstance(target, ast.Name): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
448 | variables.add(target.id) |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
449 | elif isinstance(assignment, ast.AnnAssign) and isinstance( |
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
450 | assignment.target, ast.Name |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
451 | ): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
452 | variables.add(assignment.target.id) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
453 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
454 | return variables |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
455 | |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
456 | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
457 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
458 | ## Class used by 'Unused Arguments' |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
459 | ## |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
460 | ## adapted from: flake8-unused-arguments v0.0.13 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
461 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
462 | |
10052 | 463 | |
464 | class FunctionFinder(ast.NodeVisitor): | |
465 | """ | |
466 | Class to find all defined functions and methods. | |
467 | """ | |
468 | ||
469 | def __init__(self, onlyTopLevel=False): | |
470 | """ | |
471 | Constructor | |
472 | ||
473 | @param onlyTopLevel flag indicating to search for top level functions only | |
474 | (defaults to False) | |
475 | @type bool (optional) | |
476 | """ | |
477 | super().__init__() | |
478 | ||
479 | self.__functions = [] | |
480 | self.__onlyTopLevel = onlyTopLevel | |
481 | ||
482 | def functionNodes(self): | |
483 | """ | |
484 | Public method to get the list of detected functions and lambdas. | |
485 | ||
486 | @return list of detected functions and lambdas | |
487 | @rtype list of ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
488 | """ | |
489 | return self.__functions | |
490 | ||
491 | def __visitFunctionTypes(self, functionNode): | |
492 | """ | |
493 | Private method to handle an AST node defining a function or lambda. | |
494 | ||
495 | @param functionNode reference to the node defining a function or lambda | |
496 | @type ast.AsyncFunctionDef, ast.FunctionDef or ast.Lambda | |
497 | """ | |
498 | self.__functions.append(functionNode) | |
499 | if not self.__onlyTopLevel: | |
500 | if isinstance(functionNode, ast.Lambda): | |
501 | self.visit(functionNode.body) | |
502 | else: | |
503 | for obj in functionNode.body: | |
504 | self.visit(obj) | |
505 | ||
506 | visit_AsyncFunctionDef = visit_FunctionDef = visit_Lambda = __visitFunctionTypes | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
507 | |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
508 | |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
509 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
510 | ## Class used by 'Unused Globals' |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
511 | ## |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
512 | ## adapted from: flake8-unused-globals v0.1.9 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
513 | ####################################################################### |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
514 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
515 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
516 | GlobalVariableStoreInfo = collections.namedtuple( |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
517 | "GlobalVariableStoreInfo", ["lineno", "offset"] |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
518 | ) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
519 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
520 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
521 | class GlobalVariableLoadCounter(ast.NodeVisitor): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
522 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
523 | Class to find all defined global variables and count their usages. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
524 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
525 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
526 | def __init__(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
527 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
528 | Constructor |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
529 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
530 | super().__init__() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
531 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
532 | self.__loads = {} |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
533 | self.__storeInfo = {} |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
534 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
535 | def visit_Name(self, nameNode): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
536 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
537 | Public method to record the definition and use of a global variable. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
538 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
539 | @param nameNode reference to the name node to be processed |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
540 | @type ast.Name |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
541 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
542 | if isinstance(nameNode.ctx, ast.Load) and nameNode.id in self.__loads: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
543 | self.__loads[nameNode.id] += 1 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
544 | elif ( |
10054
d7a47f0cff2b
Regenerated source documentation.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10053
diff
changeset
|
545 | isinstance(nameNode.ctx, ast.Store) and nameNode.id not in self.__storeInfo |
10053
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
546 | ): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
547 | self.__loads[nameNode.id] = 0 |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
548 | self.__storeInfo[nameNode.id] = GlobalVariableStoreInfo( |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
549 | lineno=nameNode.lineno, offset=nameNode.col_offset |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
550 | ) |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
551 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
552 | def getLoads(self): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
553 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
554 | Public method to get an iterator of the detected variable loads. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
555 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
556 | @return DESCRIPTION |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
557 | @rtype TYPE |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
558 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
559 | return self.__loads.items() |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
560 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
561 | def getStoreInfo(self, variableId): |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
562 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
563 | Public method to get the store info data of a given variable ID. |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
564 | |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
565 | @param variableId variable ID to retrieve the store info for |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
566 | @type str |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
567 | @return named tuple containing the line number and column offset |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
568 | @rtype GlobalVariableStoreInfo |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
569 | """ |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
570 | try: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
571 | return self.__storeInfo[variableId] |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
572 | except KeyError: |
9914b7b4b11c
Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
10052
diff
changeset
|
573 | return None |