src/eric7/Plugins/CheckerPlugins/CodeStyleChecker/Miscellaneous/MiscellaneousChecker.py

Mon, 24 Feb 2025 15:43:49 +0100

author
Detlev Offenbach <detlev@die-offenbachs.de>
date
Mon, 24 Feb 2025 15:43:49 +0100
branch
eric7
changeset 11148
15e30f0c76a8
parent 11147
dee6e106b4d3
child 11150
73d80859079c
permissions
-rw-r--r--

Adjusted the code to the modified issue codes.

4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
1 # -*- coding: utf-8 -*-
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
2
11090
f5f5f5803935 Updated copyright for 2025.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11000
diff changeset
3 # Copyright (c) 2015 - 2025 Detlev Offenbach <detlev@die-offenbachs.de>
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
4 #
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
5
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
6 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
7 Module implementing a checker for miscellaneous checks.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
8 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
9
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
10 import ast
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
11 import builtins
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
12 import contextlib
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
13 import copy
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
14 import itertools
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
15 import math
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
16 import re
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
17 import sys
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
18 import tokenize
9473
3f23dbf37dbe Resorted the import statements using isort.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9327
diff changeset
19
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
20 from collections import Counter, defaultdict, namedtuple
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
21 from dataclasses import dataclass
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
22 from keyword import iskeyword
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
23 from string import Formatter
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
24
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
25 try:
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
26 # Python 3.10+
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
27 from itertools import pairwise
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
28 except ImportError:
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
29 # replacement for Python < 3.10
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
30 from itertools import tee
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
31
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
32 def pairwise(iterable):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
33 a, b = tee(iterable)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
34 next(b, None)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
35 return zip(a, b)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
36
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
37
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
38 import AstUtilities
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
39
8168
bdb0258faf42 Code Style Checker: reorganized the code a little bit.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8166
diff changeset
40 from .eradicate import Eradicator
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
41 from .MiscellaneousDefaults import MiscellaneousCheckerDefaultArgs
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
42
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
43 BugbearMutableLiterals = ("Dict", "List", "Set")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
44 BugbearMutableComprehensions = ("ListComp", "DictComp", "SetComp")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
45 BugbearMutableCalls = (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
46 "Counter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
47 "OrderedDict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
48 "collections.Counter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
49 "collections.OrderedDict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
50 "collections.defaultdict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
51 "collections.deque",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
52 "defaultdict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
53 "deque",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
54 "dict",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
55 "list",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
56 "set",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
57 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
58 BugbearImmutableCalls = (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
59 "tuple",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
60 "frozenset",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
61 "types.MappingProxyType",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
62 "MappingProxyType",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
63 "re.compile",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
64 "operator.attrgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
65 "operator.itemgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
66 "operator.methodcaller",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
67 "attrgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
68 "itemgetter",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
69 "methodcaller",
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
70 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
71
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
72
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
73 def composeCallPath(node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
74 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
75 Generator function to assemble the call path of a given node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
76
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
77 @param node node to assemble call path for
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
78 @type ast.Node
7988
c4c17121eff8 Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7980
diff changeset
79 @yield call path components
c4c17121eff8 Updated source code documentation with the new tags.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7980
diff changeset
80 @ytype str
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
81 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
82 if isinstance(node, ast.Attribute):
8205
4a0f1f896341 Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8198
diff changeset
83 yield from composeCallPath(node.value)
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
84 yield node.attr
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
85 elif isinstance(node, ast.Call):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
86 yield from composeCallPath(node.func)
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
87 elif isinstance(node, ast.Name):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
88 yield node.id
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
89
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
90
8207
d359172d11be Applied some more code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8205
diff changeset
91 class MiscellaneousChecker:
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
92 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
93 Class implementing a checker for miscellaneous checks.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
94 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
95
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
96 Codes = [
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
97 ## Coding line
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
98 "M-101",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
99 "M-102",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
100 ## Copyright
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
101 "M-111",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
102 "M-112",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
103 ## Shadowed Builtins
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
104 "M-131",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
105 "M-132",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
106 ## Comprehensions
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
107 "M-180",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
108 "M-181",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
109 "M-182",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
110 "M-183",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
111 "M-184",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
112 "M-185",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
113 "M-186",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
114 "M-188",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
115 "M-189",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
116 "M-189a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
117 "M-189b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
118 "M-190",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
119 "M-190a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
120 "M-190b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
121 "M-191",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
122 "M-193",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
123 "M-193a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
124 "M-193b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
125 "M-193c",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
126 "M-194",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
127 "M-195",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
128 "M-196",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
129 "M-197",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
130 "M-198",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
131 "M-199",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
132 "M-200",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
133 ## Dictionaries with sorted keys
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
134 "M-251",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
135 ## Property
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
136 "M-260",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
137 "M-261",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
138 "M-262",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
139 "M-263",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
140 "M-264",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
141 "M-265",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
142 "M-266",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
143 "M-267",
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
144 ## Naive datetime usage
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
145 "M-301",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
146 "M-302",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
147 "M-303",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
148 "M-304",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
149 "M-305",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
150 "M-306",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
151 "M-307",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
152 "M-308",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
153 "M-311",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
154 "M-312",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
155 "M-313",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
156 "M-314",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
157 "M-315",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
158 "M-321",
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
159 ## sys.version and sys.version_info usage
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
160 "M-401",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
161 "M-402",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
162 "M-403",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
163 "M-411",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
164 "M-412",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
165 "M-413",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
166 "M-414",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
167 "M-421",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
168 "M-422",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
169 "M-423",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
170 ## Bugbear
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
171 "M-501",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
172 "M-502",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
173 "M-503",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
174 "M-504",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
175 "M-505",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
176 "M-506",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
177 "M-507",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
178 "M-508",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
179 "M-509",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
180 "M-510",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
181 "M-511",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
182 "M-512",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
183 "M-513",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
184 "M-514",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
185 "M-515",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
186 "M-516",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
187 "M-517",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
188 "M-518",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
189 "M-519",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
190 "M-520",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
191 "M-521",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
192 "M-522",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
193 "M-523",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
194 "M-524",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
195 "M-525",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
196 "M-526",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
197 "M-527",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
198 "M-528",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
199 "M-529",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
200 "M-530",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
201 "M-531",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
202 "M-532",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
203 "M-533",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
204 "M-534",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
205 "M-535",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
206 "M-536",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
207 "M-537",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
208 "M-539",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
209 "M-540",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
210 "M-541",
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
211 ## Bugbear, opininonated
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
212 "M-569",
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
213 ## Bugbear++
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
214 "M-581",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
215 "M-582",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
216 ## Format Strings
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
217 "M-601",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
218 "M-611",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
219 "M-612",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
220 "M-613",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
221 "M-621",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
222 "M-622",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
223 "M-623",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
224 "M-624",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
225 "M-625",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
226 "M-631",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
227 "M-632",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
228 ## Future statements
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
229 "M-701",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
230 "M-702",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
231 ## Gettext
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
232 "M-711",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
233 ## print() statements
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
234 "M-801",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
235 ## one element tuple
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
236 "M-811",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
237 ## return statements
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
238 "M-831",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
239 "M-832",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
240 "M-833",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
241 "M-834",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
242 ## line continuation
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
243 "M-841",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
244 ## implicitly concatenated strings
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
245 "M-851",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
246 "M-852",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
247 "M-853",
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
248 ## commented code
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
249 "M-891",
11140
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
250 ## structural pattern matching
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
251 "M-901",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
252 "M-902",
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
253 ]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
254
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
255 Formatter = Formatter()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
256 FormatFieldRegex = re.compile(r"^((?:\s|.)*?)(\..*|\[.*\])?$")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
257
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
258 BuiltinsWhiteList = [
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
259 "__name__",
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
260 "__doc__",
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
261 "credits",
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
262 ]
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
263
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
264 def __init__(self, source, filename, tree, select, ignore, expected, repeat, args):
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
265 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
266 Constructor
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
267
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
268 @param source source code to be checked
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
269 @type list of str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
270 @param filename name of the source file
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
271 @type str
8198
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
272 @param tree AST tree of the source code
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
273 @type ast.Module
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
274 @param select list of selected codes
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
275 @type list of str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
276 @param ignore list of codes to be ignored
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
277 @type list of str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
278 @param expected list of expected codes
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
279 @type list of str
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
280 @param repeat flag indicating to report each occurrence of a code
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
281 @type bool
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
282 @param args dictionary of arguments for the miscellaneous checks
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
283 @type dict
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
284 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
285 self.__select = tuple(select)
11142
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11140
diff changeset
286 self.__ignore = tuple(ignore)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
287 self.__expected = expected[:]
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
288 self.__repeat = repeat
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
289 self.__filename = filename
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
290 self.__source = source[:]
8198
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
291 self.__tree = copy.deepcopy(tree)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
292 self.__args = args
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
293
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
294 linesIterator = iter(self.__source)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
295 self.__tokens = list(tokenize.generate_tokens(lambda: next(linesIterator)))
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
296
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
297 self.__pep3101FormatRegex = re.compile(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
298 r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%'
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
299 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
300
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
301 self.__builtins = [b for b in dir(builtins) if b not in self.BuiltinsWhiteList]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
302
7972
4fc11172df1b Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7923
diff changeset
303 self.__eradicator = Eradicator()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
304
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
305 # statistics counters
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
306 self.counters = {}
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
307
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
308 # collection of detected errors
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
309 self.errors = []
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
310
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
311 checkersWithCodes = [
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
312 (self.__checkCoding, ("M-101", "M-102")),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
313 (self.__checkCopyright, ("M-111", "M-112")),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
314 (self.__checkBuiltins, ("M-131", "M-132")),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
315 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
316 self.__checkComprehensions,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
317 (
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
318 "M-180",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
319 "M-181",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
320 "M-182",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
321 "M-183",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
322 "M-184",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
323 "M-185",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
324 "M-186",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
325 "M-188",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
326 "M-189",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
327 "M-189a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
328 "M-189b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
329 "M-190",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
330 "M-190a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
331 "M-190b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
332 "M-191",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
333 "M-193",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
334 "M-193a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
335 "M-193b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
336 "M-193c",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
337 "M-194",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
338 "M-195",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
339 "M-196",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
340 "M-197",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
341 "M-198",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
342 "M-199",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
343 "M-200",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
344 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
345 ),
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
346 (self.__checkDictWithSortedKeys, ("M-251",)),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
347 (
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
348 self.__checkProperties,
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
349 (
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
350 "M-260",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
351 "M-261",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
352 "M-262",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
353 "M-263",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
354 "M-264",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
355 "M-265",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
356 "M-266",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
357 "M-267",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
358 ),
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
359 ),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
360 (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
361 self.__checkDateTime,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
362 (
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
363 "M-301",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
364 "M-302",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
365 "M-303",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
366 "M-304",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
367 "M-305",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
368 "M-306",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
369 "M-307",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
370 "M-308",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
371 "M-311",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
372 "M-312",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
373 "M-313",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
374 "M-314",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
375 "M-315",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
376 "M-321",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
377 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
378 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
379 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
380 self.__checkSysVersion,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
381 (
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
382 "M-401",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
383 "M-402",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
384 "M-403",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
385 "M-411",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
386 "M-412",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
387 "M-413",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
388 "M-414",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
389 "M-421",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
390 "M-422",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
391 "M-423",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
392 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
393 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
394 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
395 self.__checkBugBear,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
396 (
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
397 "M-501",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
398 "M-502",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
399 "M-503",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
400 "M-504",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
401 "M-505",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
402 "M-506",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
403 "M-507",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
404 "M-508",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
405 "M-509",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
406 "M-510",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
407 "M-511",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
408 "M-512",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
409 "M-513",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
410 "M-514",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
411 "M-515",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
412 "M-516",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
413 "M-517",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
414 "M-518",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
415 "M-519",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
416 "M-520",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
417 "M-521",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
418 "M-522",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
419 "M-523",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
420 "M-524",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
421 "M-525",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
422 "M-526",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
423 "M-527",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
424 "M-528",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
425 "M-529",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
426 "M-530",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
427 "M-531",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
428 "M-532",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
429 "M-533",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
430 "M-534",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
431 "M-535",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
432 "M-536",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
433 "M-537",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
434 "M-539",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
435 "M-540",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
436 "M-541",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
437 "M-569",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
438 "M-581",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
439 "M-582",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
440 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
441 ),
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
442 (self.__checkPep3101, ("M-601",)),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
443 (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
444 self.__checkFormatString,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
445 (
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
446 "M-611",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
447 "M-612",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
448 "M-613",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
449 "M-621",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
450 "M-622",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
451 "M-623",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
452 "M-624",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
453 "M-625",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
454 "M-631",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
455 "M-632",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
456 ),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
457 ),
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
458 (self.__checkFuture, ("M-701", "M-702")),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
459 (self.__checkGettext, ("M-711",)),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
460 (self.__checkPrintStatements, ("M-801",)),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
461 (self.__checkTuple, ("M-811",)),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
462 (self.__checkReturn, ("M-831", "M-832", "M-833", "M-834")),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
463 (self.__checkLineContinuation, ("M-841",)),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
464 (self.__checkImplicitStringConcat, ("M-851", "M-852")),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
465 (self.__checkExplicitStringConcat, ("M-853",)),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
466 (self.__checkCommentedCode, ("M-891",)),
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
467 (self.__checkDefaultMatchCase, ("M-901", "M-902")),
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
468 ]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
469
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
470 # the eradicate whitelist
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
471 commentedCodeCheckerArgs = self.__args.get(
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
472 "CommentedCodeChecker",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
473 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
474 )
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
475 commentedCodeCheckerWhitelist = commentedCodeCheckerArgs.get(
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
476 "WhiteList",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
477 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["WhiteList"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
478 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
479 self.__eradicator.update_whitelist(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
480 commentedCodeCheckerWhitelist, extend_default=False
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
481 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
482
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
483 self.__checkers = []
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
484 for checker, codes in checkersWithCodes:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
485 if any(not (code and self.__ignoreCode(code)) for code in codes):
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
486 self.__checkers.append(checker)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
487
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
488 def __ignoreCode(self, code):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
489 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
490 Private method to check if the message code should be ignored.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
491
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
492 @param code message code to check for
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
493 @type str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
494 @return flag indicating to ignore the given code
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
495 @rtype bool
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
496 """
11145
d328a7b74fd8 Corrected some code formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11142
diff changeset
497 return code in self.__ignore or (
d328a7b74fd8 Corrected some code formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11142
diff changeset
498 code.startswith(self.__ignore) and not code.startswith(self.__select)
11142
2f0fb22c1d63 Fixed a few issues in the code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11140
diff changeset
499 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
500
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
501 def __error(self, lineNumber, offset, code, *args):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
502 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
503 Private method to record an issue.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
504
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
505 @param lineNumber line number of the issue
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
506 @type int
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
507 @param offset position within line of the issue
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
508 @type int
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
509 @param code message code
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
510 @type str
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
511 @param args arguments for the message
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
512 @type list
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
513 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
514 if self.__ignoreCode(code):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
515 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
516
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
517 if code in self.counters:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
518 self.counters[code] += 1
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
519 else:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
520 self.counters[code] = 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
521
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
522 # Don't care about expected codes
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
523 if code in self.__expected:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
524 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
525
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
526 if code and (self.counters[code] == 1 or self.__repeat):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
527 # record the issue with one based line number
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
528 self.errors.append(
7610
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
529 {
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
530 "file": self.__filename,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
531 "line": lineNumber + 1,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
532 "offset": offset,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
533 "code": code,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
534 "args": args,
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
535 }
df7025fe26a3 Code Style Checker: reworked the API between frontend and backend to get some more flexibility for the future.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7360
diff changeset
536 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
537
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
538 def run(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
539 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
540 Public method to check the given source against miscellaneous
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
541 conditions.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
542 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
543 if not self.__filename:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
544 # don't do anything, if essential data is missing
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
545 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
546
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
547 if not self.__checkers:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
548 # don't do anything, if no codes were selected
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
549 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
550
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
551 for check in self.__checkers:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
552 check()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
553
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
554 def __getCoding(self):
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
555 """
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
556 Private method to get the defined coding of the source.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
557
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
558 @return tuple containing the line number and the coding
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
559 @rtype tuple of int and str
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
560 """
6106
921d070cec82 Finished implementing support for EditorConfig.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6100
diff changeset
561 for lineno, line in enumerate(self.__source[:5]):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
562 matched = re.search(r"coding[:=]\s*([-\w_.]+)", line, re.IGNORECASE)
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
563 if matched:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
564 return lineno, matched.group(1)
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
565 else:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
566 return 0, ""
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
567
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
568 def __checkCoding(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
569 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
570 Private method to check the presence of a coding line and valid
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
571 encodings.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
572 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
573 if len(self.__source) == 0:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
574 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
575
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
576 encodings = [
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
577 e.lower().strip()
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
578 for e in self.__args.get(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
579 "CodingChecker", MiscellaneousCheckerDefaultArgs["CodingChecker"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
580 ).split(",")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
581 ]
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
582 lineno, coding = self.__getCoding()
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
583 if coding:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
584 if coding.lower() not in encodings:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
585 self.__error(lineno, 0, "M-102", coding)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
586 else:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
587 self.__error(0, 0, "M-101")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
588
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
589 def __checkCopyright(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
590 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
591 Private method to check the presence of a copyright statement.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
592 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
593 source = "".join(self.__source)
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
594 copyrightArgs = self.__args.get(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
595 "CopyrightChecker", MiscellaneousCheckerDefaultArgs["CopyrightChecker"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
596 )
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
597 copyrightMinFileSize = copyrightArgs.get(
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
598 "MinFilesize",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
599 MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["MinFilesize"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
600 )
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
601 copyrightAuthor = copyrightArgs.get(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
602 "Author", MiscellaneousCheckerDefaultArgs["CopyrightChecker"]["Author"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
603 )
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
604 copyrightRegexStr = (
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
605 r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}"
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
606 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
607
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
608 tocheck = max(1024, copyrightMinFileSize)
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
609 topOfSource = source[:tocheck]
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
610 if len(topOfSource) < copyrightMinFileSize:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
611 return
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
612
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
613 copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"), re.IGNORECASE)
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
614 if not copyrightRe.search(topOfSource):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
615 self.__error(0, 0, "M-111")
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
616 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
617
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
618 if copyrightAuthor:
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
619 copyrightAuthorRe = re.compile(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
620 copyrightRegexStr.format(author=copyrightAuthor), re.IGNORECASE
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
621 )
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
622 if not copyrightAuthorRe.search(topOfSource):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
623 self.__error(0, 0, "M-112")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
624
7040
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
625 def __checkCommentedCode(self):
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
626 """
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
627 Private method to check for commented code.
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
628 """
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
629 source = "".join(self.__source)
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
630 commentedCodeCheckerArgs = self.__args.get(
7980
2c3f14a3c595 CodeStyleCheckerDialog: added a commented code whitelist patterns to the Miscellaneous Checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7972
diff changeset
631 "CommentedCodeChecker",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
632 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
633 )
7040
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
634 aggressive = commentedCodeCheckerArgs.get(
f89952e5fc11 Code Style Checker: added check for commented code that should be removed.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7021
diff changeset
635 "Aggressive",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
636 MiscellaneousCheckerDefaultArgs["CommentedCodeChecker"]["Aggressive"],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
637 )
7972
4fc11172df1b Code Style Checker: upgraded eradicate.py to version 2.0.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7923
diff changeset
638 for markedLine in self.__eradicator.commented_out_code_line_numbers(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
639 source, aggressive=aggressive
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
640 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
641 self.__error(markedLine - 1, 0, "M-891")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
642
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
643 def __checkLineContinuation(self):
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
644 """
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
645 Private method to check line continuation using backslash.
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
646 """
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
647 # generate source lines without comments
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
648 comments = [tok for tok in self.__tokens if tok[0] == tokenize.COMMENT]
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
649 stripped = self.__source[:]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
650 for comment in comments:
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
651 lineno = comment[3][0]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
652 start = comment[2][1]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
653 stop = comment[3][1]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
654 content = stripped[lineno - 1]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
655 withoutComment = content[:start] + content[stop:]
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
656 stripped[lineno - 1] = withoutComment.rstrip()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
657
7042
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
658 # perform check with 'cleaned' source
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
659 for lineIndex, line in enumerate(stripped):
2be5b245e1b8 Code Style Checker: added check for line continuation methods not suggested by PEP-8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7040
diff changeset
660 strippedLine = line.strip()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
661 if strippedLine.endswith("\\") and not strippedLine.startswith(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
662 ("assert", "with")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
663 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
664 self.__error(lineIndex, len(line), "M-841")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
665
4506
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
666 def __checkPrintStatements(self):
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
667 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
668 Private method to check for print statements.
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
669 """
57666e501a42 Started to add more code style checkers.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff changeset
670 for node in ast.walk(self.__tree):
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
671 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
672 isinstance(node, ast.Call) and getattr(node.func, "id", None) == "print"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
673 ) or (hasattr(ast, "Print") and isinstance(node, ast.Print)):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
674 self.__error(node.lineno - 1, node.col_offset, "M-801")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
675
4507
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
676 def __checkTuple(self):
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
677 """
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
678 Private method to check for one element tuples.
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
679 """
1a5bc1ac7c2e Added a check for one element tuples.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4506
diff changeset
680 for node in ast.walk(self.__tree):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
681 if isinstance(node, ast.Tuple) and len(node.elts) == 1:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
682 self.__error(node.lineno - 1, node.col_offset, "M-811")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
683
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
684 def __checkFuture(self):
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
685 """
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
686 Private method to check the __future__ imports.
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
687 """
5588
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
688 expectedImports = {
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
689 i.strip()
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
690 for i in self.__args.get("FutureChecker", "").split(",")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
691 if bool(i.strip())
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
692 }
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
693 if len(expectedImports) == 0:
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
694 # nothing to check for; disabling the check
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
695 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
696
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
697 imports = set()
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
698 node = None
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
699 hasCode = False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
700
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
701 for node in ast.walk(self.__tree):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
702 if isinstance(node, ast.ImportFrom) and node.module == "__future__":
5588
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
703 imports |= {name.name for name in node.names}
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
704 elif isinstance(node, ast.Expr):
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
705 if not AstUtilities.isString(node.value):
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
706 hasCode = True
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
707 break
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
708 elif not (AstUtilities.isString(node) or isinstance(node, ast.Module)):
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
709 hasCode = True
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
710 break
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
711
4540
45627d092846 Fixed the futures checker raising false psitives when a file only contains a docstring.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4515
diff changeset
712 if isinstance(node, ast.Module) or not hasCode:
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
713 return
4508
a3b38825acf0 Added a check for __future__ imports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4507
diff changeset
714
8205
4a0f1f896341 Applied some code simplifications suggested by the new Simplify checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8198
diff changeset
715 if imports < expectedImports:
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
716 if imports:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
717 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
718 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
719 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
720 "M-701",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
721 ", ".join(expectedImports),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
722 ", ".join(imports),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
723 )
4509
7797ee4a45f9 Redid the future imports checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4508
diff changeset
724 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
725 self.__error(
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
726 node.lineno - 1,
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
727 node.col_offset,
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
728 "M-702",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
729 ", ".join(expectedImports),
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
730 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
731
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
732 def __checkPep3101(self):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
733 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
734 Private method to check for old style string formatting.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
735 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
736 for lineno, line in enumerate(self.__source):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
737 match = self.__pep3101FormatRegex.search(line)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
738 if match:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
739 lineLen = len(line)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
740 pos = line.find("%")
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
741 formatPos = pos
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
742 formatter = "%"
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
743 if line[pos + 1] == "(":
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
744 pos = line.find(")", pos)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
745 c = line[pos]
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
746 while c not in "diouxXeEfFgGcrs":
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
747 pos += 1
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
748 if pos >= lineLen:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
749 break
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
750 c = line[pos]
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
751 if c in "diouxXeEfFgGcrs":
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
752 formatter += c
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
753 self.__error(lineno, formatPos, "M-601", formatter)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
754
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
755 def __checkFormatString(self):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
756 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
757 Private method to check string format strings.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
758 """
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
759 coding = self.__getCoding()[1]
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
760 if not coding:
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
761 # default to utf-8
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
762 coding = "utf-8"
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
763
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
764 visitor = TextVisitor()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
765 visitor.visit(self.__tree)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
766 for node in visitor.nodes:
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
767 text = node.value
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
768 if isinstance(text, bytes):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
769 try:
4515
d7cebe39ffba Some refinements to the miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4511
diff changeset
770 text = text.decode(coding)
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
771 except UnicodeDecodeError:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
772 continue
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
773 fields, implicit, explicit = self.__getFields(text)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
774 if implicit:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
775 if node in visitor.calls:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
776 self.__error(node.lineno - 1, node.col_offset, "M-611")
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
777 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
778 if node.is_docstring:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
779 self.__error(node.lineno - 1, node.col_offset, "M-612")
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
780 else:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
781 self.__error(node.lineno - 1, node.col_offset, "M-613")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
782
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
783 if node in visitor.calls:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
784 call, strArgs = visitor.calls[node]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
785
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
786 numbers = set()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
787 names = set()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
788 # Determine which fields require a keyword and which an arg
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
789 for name in fields:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
790 fieldMatch = self.FormatFieldRegex.match(name)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
791 try:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
792 number = int(fieldMatch.group(1))
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
793 except ValueError:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
794 number = -1
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
795 # negative numbers are considered keywords
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
796 if number >= 0:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
797 numbers.add(number)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
798 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
799 names.add(fieldMatch.group(1))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
800
5588
6ba512d9f46a Continued fixing code style issues detected by the extended style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5585
diff changeset
801 keywords = {keyword.arg for keyword in call.keywords}
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
802 numArgs = len(call.args)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
803 if strArgs:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
804 numArgs -= 1
7894
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
805 hasKwArgs = any(kw.arg is None for kw in call.keywords)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
806 hasStarArgs = sum(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
807 1 for arg in call.args if isinstance(arg, ast.Starred)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
808 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
809
7894
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
810 if hasKwArgs:
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
811 keywords.discard(None)
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
812 if hasStarArgs:
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
813 numArgs -= 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
814
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
815 # if starargs or kwargs is not None, it can't count the
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
816 # parameters but at least check if the args are used
8222
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
817 if hasKwArgs and not names:
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
818 # No names but kwargs
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
819 self.__error(call.lineno - 1, call.col_offset, "M-623")
8222
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
820 if hasStarArgs and not numbers:
5994b80b8760 Applied some more code simplifications suggested by the new Simplify checker (Y102: use single if) (batch 1).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8218
diff changeset
821 # No numbers but args
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
822 self.__error(call.lineno - 1, call.col_offset, "M-624")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
823
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
824 if not hasKwArgs and not hasStarArgs:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
825 # can actually verify numbers and names
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
826 for number in sorted(numbers):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
827 if number >= numArgs:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
828 self.__error(
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
829 call.lineno - 1, call.col_offset, "M-621", number
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
830 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
831
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
832 for name in sorted(names):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
833 if name not in keywords:
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
834 self.__error(
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
835 call.lineno - 1, call.col_offset, "M-622", name
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
836 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
837
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
838 for arg in range(numArgs):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
839 if arg not in numbers:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
840 self.__error(call.lineno - 1, call.col_offset, "M-631", arg)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
841
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
842 for keyword in keywords:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
843 if keyword not in names:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
844 self.__error(call.lineno - 1, call.col_offset, "M-632", keyword)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
845
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
846 if implicit and explicit:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
847 self.__error(call.lineno - 1, call.col_offset, "M-625")
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
848
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
849 def __getFields(self, string):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
850 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
851 Private method to extract the format field information.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
852
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
853 @param string format string to be parsed
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
854 @type str
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
855 @return format field information as a tuple with fields, implicit
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
856 field definitions present and explicit field definitions present
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
857 @rtype tuple of set of str, bool, bool
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
858 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
859 fields = set()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
860 cnt = itertools.count()
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
861 implicit = False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
862 explicit = False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
863 try:
6188
5a6ae3be31e6 Fixed some loop related coding issues detected by the extended code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6184
diff changeset
864 for _literal, field, spec, conv in self.Formatter.parse(string):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
865 if field is not None and (conv is None or conv in "rsa"):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
866 if not field:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
867 field = str(next(cnt))
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
868 implicit = True
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
869 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
870 explicit = True
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
871 fields.add(field)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
872 fields.update(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
873 parsedSpec[1]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
874 for parsedSpec in self.Formatter.parse(spec)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
875 if parsedSpec[1] is not None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
876 )
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
877 except ValueError:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
878 return set(), False, False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
879 else:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
880 return fields, implicit, explicit
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
881
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
882 def __checkBuiltins(self):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
883 """
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
884 Private method to check, if built-ins are shadowed.
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
885 """
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
886 functionDefs = [ast.FunctionDef]
8243
cc717c2ae956 Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8228
diff changeset
887 with contextlib.suppress(AttributeError):
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
888 functionDefs.append(ast.AsyncFunctionDef)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
889
5619
ab999dc48132 Made the built-ins checker configurable.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5617
diff changeset
890 ignoreBuiltinAssignments = self.__args.get(
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
891 "BuiltinsChecker", MiscellaneousCheckerDefaultArgs["BuiltinsChecker"]
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
892 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
893
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
894 for node in ast.walk(self.__tree):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
895 if isinstance(node, ast.Assign):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
896 # assign statement
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
897 for element in node.targets:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
898 if isinstance(element, ast.Name) and element.id in self.__builtins:
5617
1b9e3d94864a Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5589
diff changeset
899 value = node.value
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
900 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
901 isinstance(value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
902 and element.id in ignoreBuiltinAssignments
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
903 and value.id in ignoreBuiltinAssignments[element.id]
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
904 ):
5617
1b9e3d94864a Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5589
diff changeset
905 # ignore compatibility assignments
1b9e3d94864a Removed obsolete checker for M121 (blind except) because that is already checked by pycodestyle.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5589
diff changeset
906 continue
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
907 self.__error(
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
908 element.lineno - 1, element.col_offset, "M-131", element.id
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
909 )
5589
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
910 elif isinstance(element, (ast.Tuple, ast.List)):
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
911 for tupleElement in element.elts:
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
912 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
913 isinstance(tupleElement, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
914 and tupleElement.id in self.__builtins
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
915 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
916 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
917 tupleElement.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
918 tupleElement.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
919 "M-131",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
920 tupleElement.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
921 )
5589
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
922 elif isinstance(node, ast.For):
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
923 # for loop
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
924 target = node.target
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
925 if isinstance(target, ast.Name) and target.id in self.__builtins:
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
926 self.__error(
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
927 target.lineno - 1, target.col_offset, "M-131", target.id
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
928 )
5589
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
929 elif isinstance(target, (ast.Tuple, ast.List)):
ad8f37c6a306 Fixed code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5588
diff changeset
930 for element in target.elts:
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
931 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
932 isinstance(element, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
933 and element.id in self.__builtins
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
934 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
935 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
936 element.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
937 element.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
938 "M-131",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
939 element.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
940 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
941 elif any(isinstance(node, functionDef) for functionDef in functionDefs):
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
942 # (asynchronous) function definition
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
943 for arg in node.args.args:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
944 if isinstance(arg, ast.arg) and arg.arg in self.__builtins:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
945 self.__error(arg.lineno - 1, arg.col_offset, "M-132", arg.arg)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
946
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
947 def __checkComprehensions(self):
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
948 """
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
949 Private method to check some comprehension related things.
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
950
11134
3243a66db84a Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11090
diff changeset
951 This method is adapted from: flake8-comprehensions v3.16.0
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
952 Original: Copyright (c) 2017 Adam Johnson
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
953 """
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
954 compType = {
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
955 ast.DictComp: "dict",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
956 ast.ListComp: "list",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
957 ast.SetComp: "set",
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
958 }
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
959
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
960 visitedMapCalls = set()
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
961
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
962 for node in ast.walk(self.__tree):
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
963 if isinstance(node, ast.Call) and isinstance(node.func, ast.Name):
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
964 numPositionalArgs = len(node.args)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
965 numKeywordArgs = len(node.keywords)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
966
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
967 if (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
968 numPositionalArgs == 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
969 and isinstance(node.args[0], ast.GeneratorExp)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
970 and node.func.id in ("list", "set")
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
971 ):
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
972 errorCode = {
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
973 "list": "M-180",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
974 "set": "M-181",
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
975 }[node.func.id]
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
976 self.__error(node.lineno - 1, node.col_offset, errorCode)
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
977
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
978 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
979 numPositionalArgs == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
980 and node.func.id == "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
981 and len(node.keywords) == 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
982 and isinstance(node.args[0], (ast.GeneratorExp, ast.ListComp))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
983 and isinstance(node.args[0].elt, ast.Tuple)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
984 and len(node.args[0].elt.elts) == 2
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
985 ):
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
986 if isinstance(node.args[0], ast.GeneratorExp):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
987 errorCode = "M-182"
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
988 else:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
989 errorCode = "M-184"
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
990 self.__error(node.lineno - 1, node.col_offset, errorCode)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
991
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
992 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
993 numPositionalArgs == 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
994 and isinstance(node.args[0], ast.ListComp)
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
995 and node.func.id in ("list", "set", "any", "all")
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
996 ):
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
997 errorCode = {
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
998 "list": "M-191",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
999 "set": "M-183",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1000 "any": "M-199",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1001 "all": "M-199",
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
1002 }[node.func.id]
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1003 self.__error(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1004 node.lineno - 1, node.col_offset, errorCode, node.func.id
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1005 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1006
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1007 elif numPositionalArgs == 1 and (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1008 isinstance(node.args[0], ast.Tuple)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1009 and node.func.id == "tuple"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1010 or isinstance(node.args[0], ast.List)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1011 and node.func.id == "list"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1012 ):
5585
dab20c39f08c Added checks for shadowed Python builtins and unneccessary comprehensions and generators.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 5389
diff changeset
1013 errorCode = {
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1014 "tuple": "M-189a",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1015 "list": "M-190a",
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1016 }[node.func.id]
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1017 self.__error(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1018 node.lineno - 1,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1019 node.col_offset,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1020 errorCode,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1021 type(node.args[0]).__name__.lower(),
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1022 node.func.id,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1023 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1024
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1025 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1026 numPositionalArgs == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1027 and numKeywordArgs == 0
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1028 and isinstance(node.args[0], (ast.Dict, ast.DictComp))
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1029 and node.func.id == "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1030 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1031 if isinstance(node.args[0], ast.Dict):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1032 type_ = "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1033 else:
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1034 type_ = "dict comprehension"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1035 self.__error(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1036 node.lineno - 1,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1037 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1038 "M-198",
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1039 type_,
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1040 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1041
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1042 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1043 numPositionalArgs == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1044 and isinstance(node.args[0], (ast.Tuple, ast.List))
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1045 and (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1046 node.func.id in ("tuple", "list", "set")
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1047 or (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1048 node.func.id == "dict"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1049 and all(
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1050 isinstance(elt, ast.Tuple) and len(elt.elts) == 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1051 for elt in node.args[0].elts
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1052 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1053 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1054 )
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1055 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1056 errorCode = {
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1057 "tuple": "M-189b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1058 "list": "M-190b",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1059 "set": "M-185",
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1060 "dict": "M-186",
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1061 }[node.func.id]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1062 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1063 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1064 node.col_offset,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1065 errorCode,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1066 type(node.args[0]).__name__.lower(),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1067 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1068 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1069
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1070 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1071 numPositionalArgs == 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1072 and not any(isinstance(a, ast.Starred) for a in node.args)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1073 and not any(k.arg is None for k in node.keywords)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1074 and node.func.id == "dict"
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1075 ) or (
10371
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1076 numPositionalArgs == 0
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1077 and numKeywordArgs == 0
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1078 and node.func.id in ("tuple", "list")
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1079 ):
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1080 self.__error(
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1081 node.lineno - 1, node.col_offset, "M-188", node.func.id
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1082 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1083
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1084 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1085 node.func.id in {"list", "reversed"}
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1086 and numPositionalArgs > 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1087 and isinstance(node.args[0], ast.Call)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1088 and isinstance(node.args[0].func, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1089 and node.args[0].func.id == "sorted"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1090 ):
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1091 if node.func.id == "reversed":
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1092 reverseFlagValue = False
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1093 for kw in node.args[0].keywords:
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1094 if kw.arg != "reverse":
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1095 continue
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1096 reverseFlagValue = (
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1097 bool(kw.value.value)
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1098 if isinstance(kw.value, ast.Constant)
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1099 else None
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1100 )
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1101
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1102 if reverseFlagValue is None:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1103 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1104 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1105 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1106 "M-193a",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1107 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1108 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1109 )
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1110 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1111 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1112 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1113 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1114 "M-193b",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1115 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1116 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1117 not reverseFlagValue,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1118 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1119
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1120 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1121 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1122 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1123 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1124 "M-193c",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1125 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1126 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1127 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1128
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1129 elif (
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1130 numPositionalArgs > 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1131 and isinstance(node.args[0], ast.Call)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1132 and isinstance(node.args[0].func, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1133 and (
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1134 (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1135 node.func.id in {"set", "sorted"}
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1136 and node.args[0].func.id
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1137 in {"list", "reversed", "sorted", "tuple"}
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1138 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1139 or (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1140 node.func.id in {"list", "tuple"}
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1141 and node.args[0].func.id in {"list", "tuple"}
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1142 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1143 or (node.func.id == "set" and node.args[0].func.id == "set")
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1144 )
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1145 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1146 self.__error(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1147 node.lineno - 1,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1148 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1149 "M-194",
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1150 node.args[0].func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1151 node.func.id,
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1152 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1153
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1154 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1155 node.func.id in {"reversed", "set", "sorted"}
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1156 and numPositionalArgs > 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1157 and isinstance(node.args[0], ast.Subscript)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1158 and isinstance(node.args[0].slice, ast.Slice)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1159 and node.args[0].slice.lower is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1160 and node.args[0].slice.upper is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1161 and isinstance(node.args[0].slice.step, ast.UnaryOp)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1162 and isinstance(node.args[0].slice.step.op, ast.USub)
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1163 and isinstance(node.args[0].slice.step.operand, ast.Constant)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1164 and node.args[0].slice.step.operand.n == 1
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1165 ):
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1166 self.__error(
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1167 node.lineno - 1, node.col_offset, "M-195", node.func.id
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1168 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1169
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1170 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1171 node.func.id == "map"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1172 and node not in visitedMapCalls
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1173 and len(node.args) == 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1174 and isinstance(node.args[0], ast.Lambda)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1175 ):
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1176 self.__error(
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1177 node.lineno - 1,
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1178 node.col_offset,
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1179 "M-197",
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1180 "generator expression",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1181 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1182
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1183 elif (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1184 node.func.id in ("list", "set", "dict")
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1185 and len(node.args) == 1
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1186 and isinstance(node.args[0], ast.Call)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1187 and isinstance(node.args[0].func, ast.Name)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1188 and node.args[0].func.id == "map"
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1189 and len(node.args[0].args) == 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1190 and isinstance(node.args[0].args[0], ast.Lambda)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1191 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1192 # To avoid raising M197 on the map() call inside the list/set/dict.
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1193 mapCall = node.args[0]
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1194 visitedMapCalls.add(mapCall)
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1195
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1196 rewriteable = True
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1197 if node.func.id == "dict":
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1198 # For the generator expression to be rewriteable as a
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1199 # dict comprehension, its lambda must return a 2-tuple.
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1200 lambdaNode = node.args[0].args[0]
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1201 if (
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1202 not isinstance(lambdaNode.body, (ast.List, ast.Tuple))
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1203 or len(lambdaNode.body.elts) != 2
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1204 ):
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1205 rewriteable = False
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1206
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1207 if rewriteable:
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1208 comprehensionType = f"{node.func.id} comprehension"
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1209 self.__error(
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1210 node.lineno - 1, node.col_offset, "M-197", comprehensionType
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1211 )
10360
9ffdb1490bd2 Updated the 'Miscellaneous' checker to "flake8-comprehensions 3.14.0".
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10359
diff changeset
1212
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1213 elif isinstance(node, (ast.DictComp, ast.ListComp, ast.SetComp)) and (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1214 len(node.generators) == 1
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1215 and not node.generators[0].ifs
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1216 and not node.generators[0].is_async
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1217 ):
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1218 if (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1219 isinstance(node, (ast.ListComp, ast.SetComp))
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1220 and isinstance(node.elt, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1221 and isinstance(node.generators[0].target, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1222 and node.elt.id == node.generators[0].target.id
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1223 ) or (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1224 isinstance(node, ast.DictComp)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1225 and isinstance(node.key, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1226 and isinstance(node.value, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1227 and isinstance(node.generators[0].target, ast.Tuple)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1228 and len(node.generators[0].target.elts) == 2
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1229 and isinstance(node.generators[0].target.elts[0], ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1230 and node.generators[0].target.elts[0].id == node.key.id
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1231 and isinstance(node.generators[0].target.elts[1], ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1232 and node.generators[0].target.elts[1].id == node.value.id
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1233 ):
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1234 self.__error(
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1235 node.lineno - 1,
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1236 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1237 "M-196",
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1238 compType[node.__class__],
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1239 )
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1240
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1241 elif (
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1242 isinstance(node, ast.DictComp)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1243 and isinstance(node.key, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1244 and isinstance(node.value, ast.Constant)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1245 and isinstance(node.generators[0].target, ast.Name)
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1246 and node.key.id == node.generators[0].target.id
8759
7efebdfa5dc2 Updated the comprehensions check of the Miscellaneous code style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8312
diff changeset
1247 ):
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1248 self.__error(
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1249 node.lineno - 1,
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1250 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1251 "M-200",
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1252 compType[node.__class__],
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1253 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1254
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1255 def __dictShouldBeChecked(self, node):
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1256 """
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1257 Private function to test, if the node should be checked.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1258
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1259 @param node reference to the AST node
10437
2f70ca07f0af Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10417
diff changeset
1260 @type ast.Dict
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1261 @return flag indicating to check the node
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1262 @rtype bool
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1263 """
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1264 if not all(AstUtilities.isString(key) for key in node.keys):
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1265 return False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1266
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
1267 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1268 "__IGNORE_WARNING__" in self.__source[node.lineno - 1]
10884
2be906d60ffb Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10754
diff changeset
1269 or "__IGNORE_WARNING_M251__" in self.__source[node.lineno - 1]
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
1270 ):
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1271 return False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1272
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1273 lineNumbers = [key.lineno for key in node.keys]
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1274 return len(lineNumbers) == len(set(lineNumbers))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1275
6177
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1276 def __checkDictWithSortedKeys(self):
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1277 """
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1278 Private method to check, if dictionary keys appear in sorted order.
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1279 """
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1280 for node in ast.walk(self.__tree):
6178
905ea208884a Some refinements of the last changeset.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6177
diff changeset
1281 if isinstance(node, ast.Dict) and self.__dictShouldBeChecked(node):
6177
af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6106
diff changeset
1282 for key1, key2 in zip(node.keys, node.keys[1:]):
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1283 if key2.value < key1.value:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1284 self.__error(
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1285 key2.lineno - 1,
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1286 key2.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1287 "M-251",
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1288 key2.value,
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
1289 key1.value,
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1290 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1291
6182
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1292 def __checkGettext(self):
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1293 """
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1294 Private method to check the 'gettext' import statement.
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1295 """
f293e95b914d Code Style Checker: added check for the 'gettext' import statement
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6180
diff changeset
1296 for node in ast.walk(self.__tree):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1297 if isinstance(node, ast.ImportFrom) and any(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1298 name.asname == "_" for name in node.names
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
1299 ):
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1300 self.__error(
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1301 node.lineno - 1, node.col_offset, "M-711", node.names[0].name
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1302 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1303
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1304 def __checkBugBear(self):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1305 """
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
1306 Private method for bugbear checks.
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1307 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1308 visitor = BugBearVisitor()
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1309 visitor.visit(self.__tree)
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1310 for violation in visitor.violations:
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1311 node = violation[0]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1312 reason = violation[1]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1313 params = violation[2:]
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1314 self.__error(node.lineno - 1, node.col_offset, reason, *params)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1315
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1316 def __checkReturn(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1317 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1318 Private method to check return statements.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1319 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1320 visitor = ReturnVisitor()
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1321 visitor.visit(self.__tree)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1322 for violation in visitor.violations:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1323 node = violation[0]
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1324 reason = violation[1]
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
1325 self.__error(node.lineno - 1, node.col_offset, reason)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1326
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1327 def __checkDateTime(self):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1328 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1329 Private method to check use of naive datetime functions.
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
1330 """
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1331 # step 1: generate an augmented node tree containing parent info
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1332 # for each child node
8198
1c765dc90c21 Code Style Checker: changed code such, that the AST tree is built only once and passed to each checker module.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8168
diff changeset
1333 tree = copy.deepcopy(self.__tree)
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1334 for node in ast.walk(tree):
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1335 for childNode in ast.iter_child_nodes(node):
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1336 childNode._dtCheckerParent = node
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1337
7637
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1338 # step 2: perform checks and report issues
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1339 visitor = DateTimeVisitor()
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1340 visitor.visit(tree)
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1341 for violation in visitor.violations:
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1342 node = violation[0]
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1343 reason = violation[1]
c878e8255972 Removed some more Python2 related code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7610
diff changeset
1344 self.__error(node.lineno - 1, node.col_offset, reason)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1345
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1346 def __checkSysVersion(self):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1347 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1348 Private method to check the use of sys.version and sys.version_info.
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1349 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1350 visitor = SysVersionVisitor()
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1351 visitor.visit(self.__tree)
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1352 for violation in visitor.violations:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1353 node = violation[0]
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1354 reason = violation[1]
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
1355 self.__error(node.lineno - 1, node.col_offset, reason)
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1356
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1357 def __checkProperties(self):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1358 """
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1359 Private method to check for issue with property related methods.
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1360 """
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1361 properties = []
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1362 for node in ast.walk(self.__tree):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1363 if isinstance(node, ast.ClassDef):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1364 properties.clear()
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1365
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1366 elif isinstance(node, ast.FunctionDef):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1367 propertyCount = 0
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1368 for decorator in node.decorator_list:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1369 # property getter method
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1370 if isinstance(decorator, ast.Name) and decorator.id == "property":
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1371 propertyCount += 1
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1372 properties.append(node.name)
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1373 if len(node.args.args) != 1:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1374 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1375 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1376 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1377 "M-260",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1378 len(node.args.args),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1379 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1380
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1381 if isinstance(decorator, ast.Attribute):
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1382 # property setter method
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1383 if decorator.attr == "setter":
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1384 propertyCount += 1
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1385 if node.name != decorator.value.id:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1386 if node.name in properties:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1387 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1388 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1389 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1390 "M-265",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1391 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1392 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1393 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1394 else:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1395 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1396 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1397 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1398 "M-263",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1399 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1400 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1401 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1402 if len(node.args.args) != 2:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1403 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1404 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1405 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1406 "M-261",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1407 len(node.args.args),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1408 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1409
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1410 # property deleter method
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1411 if decorator.attr == "deleter":
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1412 propertyCount += 1
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1413 if node.name != decorator.value.id:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1414 if node.name in properties:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1415 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1416 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1417 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1418 "M-266",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1419 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1420 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1421 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1422 else:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1423 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1424 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1425 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1426 "M-264",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1427 decorator.value.id,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1428 node.name,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1429 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1430 if len(node.args.args) != 1:
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1431 self.__error(
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1432 node.lineno - 1,
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1433 node.col_offset,
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1434 "M-262",
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1435 len(node.args.args),
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1436 )
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1437
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1438 if propertyCount > 1:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1439 self.__error(node.lineno - 1, node.col_offset, "M-267", node.name)
10085
b5808c3a9967 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10048
diff changeset
1440
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1441 #######################################################################
10362
cfa7034cccf6 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10361
diff changeset
1442 ## The following methods check for implicitly concatenated strings.
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1443 ##
10997
d470b58626d2 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10884
diff changeset
1444 ## These methods are adapted from: flake8-implicit-str-concat v0.5.0
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1445 ## Original: Copyright (c) 2023 Dylan Turner
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1446 #######################################################################
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1447
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1448 if sys.version_info < (3, 12):
10371
1f54843e8152 Fixed an issue in the miscellaneous checker causing false reports.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10362
diff changeset
1449
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1450 def __isImplicitStringConcat(self, first, second):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1451 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1452 Private method to check, if the given strings indicate an implicit string
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1453 concatenation.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1454
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1455 @param first first token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1456 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1457 @param second second token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1458 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1459 @return flag indicating an implicit string concatenation
10437
2f70ca07f0af Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10417
diff changeset
1460 @rtype bool
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1461 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1462 return first.type == second.type == tokenize.STRING
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1463
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1464 else:
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1465
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1466 def __isImplicitStringConcat(self, first, second):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1467 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1468 Private method to check, if the given strings indicate an implicit string
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1469 concatenation.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1470
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1471 @param first first token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1472 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1473 @param second second token
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1474 @type tuple
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1475 @return flag indicating an implicit string concatenation
10437
2f70ca07f0af Converted some source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10417
diff changeset
1476 @rtype bool
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1477 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1478 return (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1479 (first.type == second.type == tokenize.STRING)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1480 or (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1481 first.type == tokenize.STRING
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1482 and second.type == tokenize.FSTRING_START
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1483 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1484 or (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1485 first.type == tokenize.FSTRING_END
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1486 and second.type == tokenize.STRING
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1487 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1488 or (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1489 first.type == tokenize.FSTRING_END
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1490 and second.type == tokenize.FSTRING_START
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1491 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1492 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1493
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1494 def __checkImplicitStringConcat(self):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1495 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1496 Private method to check for implicitly concatenated strings.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1497 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1498 tokensWithoutWhitespace = (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1499 tok
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1500 for tok in self.__tokens
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1501 if tok.type
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1502 not in (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1503 tokenize.NL,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1504 tokenize.NEWLINE,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1505 tokenize.INDENT,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1506 tokenize.DEDENT,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1507 tokenize.COMMENT,
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1508 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1509 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1510 for a, b in pairwise(tokensWithoutWhitespace):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1511 if self.__isImplicitStringConcat(a, b):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1512 self.__error(
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1513 a.end[0] - 1,
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1514 a.end[1],
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
1515 "M-851" if a.end[0] == b.start[0] else "M-852",
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1516 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1517
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1518 def __checkExplicitStringConcat(self):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1519 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1520 Private method to check for explicitly concatenated strings.
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1521 """
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1522 for node in ast.walk(self.__tree):
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1523 if (
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1524 isinstance(node, ast.BinOp)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1525 and isinstance(node.op, ast.Add)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1526 and all(
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1527 AstUtilities.isBaseString(operand)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1528 or isinstance(operand, ast.JoinedStr)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1529 for operand in (node.left, node.right)
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1530 )
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1531 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1532 self.__error(node.lineno - 1, node.col_offset, "M-853")
10361
e6ff9a4f6ee5 Added checks for implicit string concatenation (based on flake8-implicit-str-concat 0.4.0) to the Miscellaneous checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10360
diff changeset
1533
11140
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1534 #################################################################################
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1535 ## The following method checks default match cases.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1536 #################################################################################
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1537
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1538 def __checkDefaultMatchCase(self):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1539 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1540 Private method to check the default match case.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1541 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1542 visitor = DefaultMatchCaseVisitor()
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1543 visitor.visit(self.__tree)
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1544 for violation in visitor.violations:
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1545 node = violation[0]
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1546 reason = violation[1]
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1547 self.__error(node.lineno - 1, node.col_offset, reason)
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
1548
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1549
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1550 class TextVisitor(ast.NodeVisitor):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1551 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1552 Class implementing a node visitor for bytes and str instances.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1553
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1554 It tries to detect docstrings as string of the first expression of each
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1555 module, class or function.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1556 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1557
9274
86fab0c74430 Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9221
diff changeset
1558 # modeled after the string format flake8 extension
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1559
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1560 def __init__(self):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1561 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1562 Constructor
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1563 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1564 super().__init__()
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1565 self.nodes = []
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1566 self.calls = {}
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1567
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1568 def __addNode(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1569 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1570 Private method to add a node to our list of nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1571
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1572 @param node reference to the node to add
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1573 @type ast.AST
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1574 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1575 if not hasattr(node, "is_docstring"):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1576 node.is_docstring = False
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1577 self.nodes.append(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1578
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1579 def visit_Constant(self, node):
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1580 """
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1581 Public method to handle constant nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1582
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1583 @param node reference to the bytes node
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1584 @type ast.Constant
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1585 """
10119
64147a7e6393 Removed support for Python 3.7 because that is EOL.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10085
diff changeset
1586 if AstUtilities.isBaseString(node):
64147a7e6393 Removed support for Python 3.7 because that is EOL.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10085
diff changeset
1587 self.__addNode(node)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1588 else:
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1589 super().generic_visit(node)
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1590
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1591 def __visitDefinition(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1592 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1593 Private method handling class and function definitions.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1594
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1595 @param node reference to the node to handle
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1596 @type ast.FunctionDef, ast.AsyncFunctionDef or ast.ClassDef
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1597 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1598 # Manually traverse class or function definition
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1599 # * Handle decorators normally
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1600 # * Use special check for body content
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1601 # * Don't handle the rest (e.g. bases)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1602 for decorator in node.decorator_list:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1603 self.visit(decorator)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1604 self.__visitBody(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1605
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1606 def __visitBody(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1607 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1608 Private method to traverse the body of the node manually.
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1609
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1610 If the first node is an expression which contains a string or bytes it
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1611 marks that as a docstring.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1612
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1613 @param node reference to the node to traverse
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1614 @type ast.AST
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1615 """
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1616 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1617 node.body
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1618 and isinstance(node.body[0], ast.Expr)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1619 and AstUtilities.isBaseString(node.body[0].value)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1620 ):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1621 node.body[0].value.is_docstring = True
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1622
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1623 for subnode in node.body:
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1624 self.visit(subnode)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1625
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1626 def visit_Module(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1627 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1628 Public method to handle a module.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1629
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1630 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1631 @type ast.Module
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1632 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1633 self.__visitBody(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1634
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1635 def visit_ClassDef(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1636 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1637 Public method to handle a class definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1638
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1639 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1640 @type ast.ClassDef
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1641 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1642 # Skipped nodes: ('name', 'bases', 'keywords', 'starargs', 'kwargs')
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1643 self.__visitDefinition(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1644
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1645 def visit_FunctionDef(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1646 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1647 Public method to handle a function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1648
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1649 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1650 @type ast.FunctionDef
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1651 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1652 # Skipped nodes: ('name', 'args', 'returns')
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1653 self.__visitDefinition(node)
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1654
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1655 def visit_AsyncFunctionDef(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1656 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1657 Public method to handle an asynchronous function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1658
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1659 @param node reference to the node to handle
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1660 @type ast.AsyncFunctionDef
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1661 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1662 # Skipped nodes: ('name', 'args', 'returns')
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1663 self.__visitDefinition(node)
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
1664
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1665 def visit_Call(self, node):
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1666 """
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1667 Public method to handle a function call.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1668
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1669 @param node reference to the node to handle
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1670 @type ast.Call
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1671 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1672 if isinstance(node.func, ast.Attribute) and node.func.attr == "format":
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1673 if AstUtilities.isBaseString(node.func.value):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1674 self.calls[node.func.value] = (node, False)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1675 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1676 isinstance(node.func.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1677 and node.func.value.id == "str"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1678 and node.args
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1679 and AstUtilities.isBaseString(node.args[0])
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
1680 ):
4511
b5e4e7efa904 Added a checker for string format strings.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 4510
diff changeset
1681 self.calls[node.args[0]] = (node, True)
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1682 super().generic_visit(node)
4555
861e1741985c Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents: 4540
diff changeset
1683
6180
8d72871c16ba Code Style Checker: added checks for logging statements
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6178
diff changeset
1684
10175
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1685 #######################################################################
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1686 ## BugBearVisitor
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1687 ##
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1688 ## adapted from: flake8-bugbear v24.12.12
10175
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1689 ##
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1690 ## Original: Copyright (c) 2016 Łukasz Langa
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1691 #######################################################################
57ed3cb66e9a Changed some code comments of adapted third party packages.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10170
diff changeset
1692
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1693 BugBearContext = namedtuple("BugBearContext", ["node", "stack"])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1694
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
1695
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1696 @dataclass
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1697 class M540CaughtException:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1698 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1699 Class to hold the data for a caught exception.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1700 """
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
1701
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
1702 name: str
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1703 hasNote: bool
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1704
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1705
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1706 class M541UnhandledKeyType:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1707 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1708 Class to hold a dictionary key of a type that we do not check for duplicates.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1709 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1710
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1711
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1712 class M541VariableKeyType:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1713 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1714 Class to hold the name of a variable key type.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1715 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1716
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1717 def __init__(self, name):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1718 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1719 Constructor
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1720
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1721 @param name name of the variable key type
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1722 @type str
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1723 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1724 self.name = name
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1725
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1726
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1727 class BugBearVisitor(ast.NodeVisitor):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1728 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1729 Class implementing a node visitor to check for various topics.
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1730 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1731
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1732 CONTEXTFUL_NODES = (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1733 ast.Module,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1734 ast.ClassDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1735 ast.AsyncFunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1736 ast.FunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1737 ast.Lambda,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1738 ast.ListComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1739 ast.SetComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1740 ast.DictComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1741 ast.GeneratorExp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1742 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1743
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1744 FUNCTION_NODES = (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1745 ast.AsyncFunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1746 ast.FunctionDef,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1747 ast.Lambda,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1748 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1749
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1750 NodeWindowSize = 4
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1751
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1752 def __init__(self):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1753 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1754 Constructor
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1755 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
1756 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1757
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1758 self.nodeWindow = []
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
1759 self.violations = []
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1760 self.contexts = []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1761
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1762 self.__M523Seen = set()
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1763 self.__M505Imports = set()
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
1764 self.__M540CaughtException = None
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1765
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1766 self.__inTryStar = ""
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1767
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1768 @property
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1769 def nodeStack(self):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1770 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1771 Public method to get a reference to the most recent node stack.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1772
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1773 @return reference to the most recent node stack
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1774 @rtype list
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1775 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1776 if len(self.contexts) == 0:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1777 return []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1778
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1779 context, stack = self.contexts[-1]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1780 return stack
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1781
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1782 def __isIdentifier(self, arg):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1783 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1784 Private method to check if arg is a valid identifier.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1785
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1786 See https://docs.python.org/2/reference/lexical_analysis.html#identifiers
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1787
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1788 @param arg reference to an argument node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1789 @type ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1790 @return flag indicating a valid identifier
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1791 @rtype TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1792 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1793 if not AstUtilities.isString(arg):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1794 return False
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1795
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1796 return (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1797 re.match(r"^[A-Za-z_][A-Za-z0-9_]*$", AstUtilities.getValue(arg))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1798 is not None
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1799 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1800
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1801 def toNameStr(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1802 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1803 Public method to turn Name and Attribute nodes to strings, handling any
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1804 depth of attribute accesses.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1805
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1806
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1807 @param node reference to the node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1808 @type ast.Name or ast.Attribute
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1809 @return string representation
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1810 @rtype str
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1811 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1812 if isinstance(node, ast.Name):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1813 return node.id
10516
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1814 elif isinstance(node, ast.Call):
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
1815 return self.toNameStr(node.func)
10516
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1816 elif isinstance(node, ast.Attribute):
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1817 inner = self.toNameStr(node.value)
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1818 if inner is None:
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1819 return None
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1820 return f"{inner}.{node.attr}"
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1821 else:
72baef0baa76 Miscellaneous Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10510
diff changeset
1822 return None
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1823
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1824 def __typesafeIssubclass(self, obj, classOrTuple):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1825 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1826 Private method implementing a type safe issubclass() function.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1827
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1828 @param obj reference to the object to be tested
10417
c6011e501282 Modernized some code and converted Debug Client and Debugger source code documentation to the new style.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10371
diff changeset
1829 @type Any
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1830 @param classOrTuple type to check against
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1831 @type type
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1832 @return flag indicating a subclass
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1833 @rtype bool
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1834 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1835 try:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1836 return issubclass(obj, classOrTuple)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1837 except TypeError:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1838 # User code specifies a type that is not a type in our current run.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1839 # Might be their error, might be a difference in our environments.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1840 # We don't know so we ignore this.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1841 return False
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1842
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1843 def __getAssignedNames(self, loopNode):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1844 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1845 Private method to get the names of a for loop.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1846
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1847 @param loopNode reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1848 @type ast.For
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1849 @yield DESCRIPTION
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1850 @ytype TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1851 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1852 loopTargets = (ast.For, ast.AsyncFor, ast.comprehension)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1853 for node in self.__childrenInScope(loopNode):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1854 if isinstance(node, (ast.Assign)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1855 for child in node.targets:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1856 yield from self.__namesFromAssignments(child)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1857 if isinstance(node, loopTargets + (ast.AnnAssign, ast.AugAssign)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1858 yield from self.__namesFromAssignments(node.target)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1859
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1860 def __namesFromAssignments(self, assignTarget):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1861 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1862 Private method to get names of an assignment.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1863
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1864 @param assignTarget reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1865 @type ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1866 @yield name of the assignment
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1867 @ytype str
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1868 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1869 if isinstance(assignTarget, ast.Name):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1870 yield assignTarget.id
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1871 elif isinstance(assignTarget, ast.Starred):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1872 yield from self.__namesFromAssignments(assignTarget.value)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1873 elif isinstance(assignTarget, (ast.List, ast.Tuple)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1874 for child in assignTarget.elts:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1875 yield from self.__namesFromAssignments(child)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1876
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1877 def __childrenInScope(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1878 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1879 Private method to get all child nodes in the given scope.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1880
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1881 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1882 @type ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1883 @yield reference to a child node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1884 @ytype ast.Node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1885 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1886 yield node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1887 if not isinstance(node, BugBearVisitor.FUNCTION_NODES):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1888 for child in ast.iter_child_nodes(node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
1889 yield from self.__childrenInScope(child)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
1890
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1891 def __flattenExcepthandler(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1892 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1893 Private method to flatten the list of exceptions handled by an except handler.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1894
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1895 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1896 @type ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1897 @yield reference to the exception type node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1898 @ytype ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1899 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1900 if not isinstance(node, ast.Tuple):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1901 yield node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1902 return
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1903
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1904 exprList = node.elts.copy()
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1905 while len(exprList):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1906 expr = exprList.pop(0)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1907 if isinstance(expr, ast.Starred) and isinstance(
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1908 expr.value, (ast.List, ast.Tuple)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1909 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1910 exprList.extend(expr.value.elts)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1911 continue
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1912 yield expr
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1913
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1914 def __checkRedundantExcepthandlers(self, names, node, inTryStar):
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1915 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1916 Private method to check for redundant exception types in an exception handler.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1917
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1918 @param names list of exception types to be checked
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1919 @type list of ast.Name
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1920 @param node reference to the exception handler node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1921 @type ast.ExceptionHandler
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1922 @param inTryStar character indicating an 'except*' handler
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
1923 @type str
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1924 @return tuple containing the error data
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1925 @rtype tuple of (ast.Node, str, str, str, str)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1926 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1927 redundantExceptions = {
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1928 "OSError": {
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1929 # All of these are actually aliases of OSError since Python 3.3
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1930 "IOError",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1931 "EnvironmentError",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1932 "WindowsError",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1933 "mmap.error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1934 "socket.error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1935 "select.error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1936 },
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1937 "ValueError": {
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1938 "binascii.Error",
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1939 },
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1940 }
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1941
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1942 # See if any of the given exception names could be removed, e.g. from:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1943 # (MyError, MyError) # duplicate names
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1944 # (MyError, BaseException) # everything derives from the Base
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1945 # (Exception, TypeError) # builtins where one subclasses another
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1946 # (IOError, OSError) # IOError is an alias of OSError since Python3.3
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1947 # but note that other cases are impractical to handle from the AST.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1948 # We expect this is mostly useful for users who do not have the
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1949 # builtin exception hierarchy memorised, and include a 'shadowed'
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1950 # subtype without realising that it's redundant.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1951 good = sorted(set(names), key=names.index)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1952 if "BaseException" in good:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1953 good = ["BaseException"]
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1954 # Remove redundant exceptions that the automatic system either handles
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1955 # poorly (usually aliases) or can't be checked (e.g. it's not an
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1956 # built-in exception).
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1957 for primary, equivalents in redundantExceptions.items():
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1958 if primary in good:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1959 good = [g for g in good if g not in equivalents]
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1960
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1961 for name, other in itertools.permutations(tuple(good), 2):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1962 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1963 self.__typesafeIssubclass(
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1964 getattr(builtins, name, type), getattr(builtins, other, ())
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1965 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1966 and name in good
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1967 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1968 good.remove(name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1969 if good != names:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1970 desc = good[0] if len(good) == 1 else "({0})".format(", ".join(good))
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1971 as_ = " as " + node.name if node.name is not None else ""
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
1972 return (node, "M-514", ", ".join(names), as_, desc, inTryStar)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1973
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1974 return None
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1975
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1976 def __walkList(self, nodes):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1977 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1978 Private method to walk a given list of nodes.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1979
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1980 @param nodes list of nodes to walk
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1981 @type list of ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1982 @yield node references as determined by the ast.walk() function
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1983 @ytype ast.Node
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1984 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1985 for node in nodes:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1986 yield from ast.walk(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
1987
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1988 def __getNamesFromTuple(self, node):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1989 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1990 Private method to get the names from an ast.Tuple node.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1991
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1992 @param node ast node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1993 @type ast.Tuple
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1994 @yield names
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1995 @ytype str
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1996 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1997 for dim in node.elts:
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1998 if isinstance(dim, ast.Name):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
1999 yield dim.id
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2000 elif isinstance(dim, ast.Tuple):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2001 yield from self.__getNamesFromTuple(dim)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2002
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2003 def __getDictCompLoopAndNamedExprVarNames(self, node):
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2004 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2005 Private method to get the names of comprehension loop variables.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2006
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2007 @param node ast node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2008 @type ast.DictComp
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2009 @yield loop variable names
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2010 @ytype str
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2011 """
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2012 finder = NamedExprFinder()
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2013 for gen in node.generators:
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2014 if isinstance(gen.target, ast.Name):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2015 yield gen.target.id
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2016 elif isinstance(gen.target, ast.Tuple):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2017 yield from self.__getNamesFromTuple(gen.target)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2018
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2019 finder.visit(gen.ifs)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2020
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2021 yield from finder.getNames().keys()
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2022
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2023 def __inClassInit(self):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2024 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2025 Private method to check, if we are inside an '__init__' method.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2026
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2027 @return flag indicating being within the '__init__' method
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2028 @rtype bool
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2029 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2030 return (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2031 len(self.contexts) >= 2
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2032 and isinstance(self.contexts[-2].node, ast.ClassDef)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2033 and isinstance(self.contexts[-1].node, ast.FunctionDef)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2034 and self.contexts[-1].node.name == "__init__"
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2035 )
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2036
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2037 def visit_Return(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2038 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2039 Public method to handle 'Return' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2040
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2041 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2042 @type ast.Return
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2043 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2044 if self.__inClassInit() and node.value is not None:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2045 self.violations.append((node, "M-537"))
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2046
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2047 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2048
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2049 def visit_Yield(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2050 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2051 Public method to handle 'Yield' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2052
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2053 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2054 @type ast.Yield
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2055 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2056 if self.__inClassInit():
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2057 self.violations.append((node, "M-537"))
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2058
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2059 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2060
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2061 def visit_YieldFrom(self, node) -> None:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2062 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2063 Public method to handle 'YieldFrom' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2064
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2065 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2066 @type ast.YieldFrom
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2067 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2068 if self.__inClassInit():
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2069 self.violations.append((node, "M-537"))
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2070
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2071 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2072
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2073 def visit(self, node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2074 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2075 Public method to traverse a given AST node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2076
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2077 @param node AST node to be traversed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2078 @type ast.Node
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2079 """
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2080 isContextful = isinstance(node, BugBearVisitor.CONTEXTFUL_NODES)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2081
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2082 if isContextful:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2083 context = BugBearContext(node, [])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2084 self.contexts.append(context)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2085
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2086 self.nodeStack.append(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2087 self.nodeWindow.append(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2088 self.nodeWindow = self.nodeWindow[-BugBearVisitor.NodeWindowSize :]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2089
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
2090 super().visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2091
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2092 self.nodeStack.pop()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2093
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2094 if isContextful:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2095 self.contexts.pop()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2096
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2097 self.__checkForM518(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2098
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2099 def visit_ExceptHandler(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2100 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2101 Public method to handle exception handlers.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2102
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2103 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2104 @type ast.ExceptHandler
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2105 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2106 if node.type is None:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2107 # bare except is handled by pycodestyle already
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2108 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2109 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2110
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2111 oldM540CaughtException = self.__M540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2112 if node.name is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2113 self.__M540CaughtException = None
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2114 else:
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2115 self.__M540CaughtException = M540CaughtException(node.name, False)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2116
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2117 names = self.__checkForM513_M514_M529_M530(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2118
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2119 if "BaseException" in names and not ExceptBaseExceptionVisitor(node).reRaised():
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2120 self.violations.append((node, "M-536"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2121
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2122 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2123
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2124 if (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2125 self.__M540CaughtException is not None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2126 and self.__M540CaughtException.hasNote
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2127 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2128 self.violations.append((node, "M-540"))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2129 self.__M540CaughtException = oldM540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2130
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2131 def visit_UAdd(self, node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2132 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2133 Public method to handle unary additions.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2134
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2135 @param node reference to the node to be processed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2136 @type ast.UAdd
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2137 """
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2138 trailingNodes = list(map(type, self.nodeWindow[-4:]))
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2139 if trailingNodes == [ast.UnaryOp, ast.UAdd, ast.UnaryOp, ast.UAdd]:
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2140 originator = self.nodeWindow[-4]
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2141 self.violations.append((originator, "M-502"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2142
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2143 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2144
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2145 def visit_Call(self, node):
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2146 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2147 Public method to handle a function call.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2148
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2149 @param node reference to the node to be processed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2150 @type ast.Call
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2151 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2152 isM540AddNote = False
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2153
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2154 if isinstance(node.func, ast.Attribute):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2155 self.__checkForM505(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2156 isM540AddNote = self.__checkForM540AddNote(node.func)
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2157 else:
8243
cc717c2ae956 Applied some more code simplifications suggested by the new Simplify checker (Y105: use contextlib.suppress) (batch 2).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8228
diff changeset
2158 with contextlib.suppress(AttributeError, IndexError):
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2159 # bad super() call
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2160 if isinstance(node.func, ast.Name) and node.func.id == "super":
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2161 args = node.args
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2162 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2163 len(args) == 2
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2164 and isinstance(args[0], ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2165 and isinstance(args[0].value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2166 and args[0].value.id == "self"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2167 and args[0].attr == "__class__"
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2168 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2169 self.violations.append((node, "M-582"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2170
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2171 # bad getattr and setattr
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2172 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2173 node.func.id in ("getattr", "hasattr")
10169
0f70a4ef4592 Made some modification in preparation for Python 3.12.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10163
diff changeset
2174 and node.args[1].value == "__call__"
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2175 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2176 self.violations.append((node, "M-504"))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2177 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2178 node.func.id == "getattr"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2179 and len(node.args) == 2
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2180 and self.__isIdentifier(node.args[1])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2181 and iskeyword(AstUtilities.getValue(node.args[1]))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2182 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2183 self.violations.append((node, "M-509"))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2184 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2185 node.func.id == "setattr"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2186 and len(node.args) == 3
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2187 and self.__isIdentifier(node.args[1])
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2188 and iskeyword(AstUtilities.getValue(node.args[1]))
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2189 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2190 self.violations.append((node, "M-510"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2191
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2192 self.__checkForM526(node)
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2193
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2194 self.__checkForM528(node)
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2195 self.__checkForM534(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2196 self.__checkForM539(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2197
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2198 # no need for copying, if used in nested calls it will be set to None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2199 currentM540CaughtException = self.__M540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2200 if not isM540AddNote:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2201 self.__checkForM540Usage(node.args)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2202 self.__checkForM540Usage(node.keywords)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2203
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2204 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2205
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2206 if isM540AddNote:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2207 # Avoid nested calls within the parameter list using the variable itself.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2208 # e.g. `e.add_note(str(e))`
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2209 self.__M540CaughtException = currentM540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2210
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2211 def visit_Module(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2212 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2213 Public method to handle a module node.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2214
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2215 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2216 @type ast.Module
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2217 """
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2218 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2219
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2220 def visit_Assign(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2221 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2222 Public method to handle assignments.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2223
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2224 @param node reference to the node to be processed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2225 @type ast.Assign
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2226 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2227 self.__checkForM540Usage(node.value)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2228 if len(node.targets) == 1:
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2229 target = node.targets[0]
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2230 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2231 isinstance(target, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2232 and isinstance(target.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2233 and (target.value.id, target.attr) == ("os", "environ")
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2234 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2235 self.violations.append((node, "M-503"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2236
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2237 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2238
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2239 def visit_For(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2240 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2241 Public method to handle 'for' statements.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2242
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2243 @param node reference to the node to be processed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2244 @type ast.For
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2245 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2246 self.__checkForM507(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2247 self.__checkForM520(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2248 self.__checkForM523(node)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2249 self.__checkForM531(node)
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
2250 self.__checkForM569(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2251
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2252 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2253
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2254 def visit_AsyncFor(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2255 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2256 Public method to handle 'for' statements.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2257
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2258 @param node reference to the node to be processed
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2259 @type ast.AsyncFor
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2260 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2261 self.__checkForM507(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2262 self.__checkForM520(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2263 self.__checkForM523(node)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2264 self.__checkForM531(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2265
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2266 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2267
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2268 def visit_While(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2269 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2270 Public method to handle 'while' statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2271
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2272 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2273 @type ast.While
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2274 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2275 self.__checkForM523(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2276
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2277 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2278
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2279 def visit_ListComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2280 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2281 Public method to handle list comprehensions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2282
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2283 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2284 @type ast.ListComp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2285 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2286 self.__checkForM523(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2287
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2288 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2289
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2290 def visit_SetComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2291 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2292 Public method to handle set comprehensions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2293
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2294 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2295 @type ast.SetComp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2296 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2297 self.__checkForM523(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2298
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2299 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2300
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2301 def visit_DictComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2302 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2303 Public method to handle dictionary comprehensions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2304
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2305 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2306 @type ast.DictComp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2307 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2308 self.__checkForM523(node)
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2309 self.__checkForM535(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2310
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2311 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2312
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2313 def visit_GeneratorExp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2314 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2315 Public method to handle generator expressions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2316
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2317 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2318 @type ast.GeneratorExp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2319 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2320 self.__checkForM523(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2321
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
2322 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2323
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2324 def visit_Assert(self, node):
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2325 """
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2326 Public method to handle 'assert' statements.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2327
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2328 @param node reference to the node to be processed
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2329 @type ast.Assert
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2330 """
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2331 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2332 AstUtilities.isNameConstant(node.test)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2333 and AstUtilities.getValue(node.test) is False
7256
4ef3b78ebb4e Continued to resolve code style issue M841.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7249
diff changeset
2334 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2335 self.violations.append((node, "M-511"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2336
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2337 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2338
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2339 def visit_AsyncFunctionDef(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2340 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2341 Public method to handle async function definitions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2342
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2343 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2344 @type ast.AsyncFunctionDef
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2345 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2346 self.__checkForM506_M508(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2347
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2348 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2349
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2350 def visit_FunctionDef(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2351 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2352 Public method to handle function definitions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2353
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2354 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2355 @type ast.FunctionDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2356 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2357 self.__checkForM506_M508(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2358 self.__checkForM519(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2359 self.__checkForM521(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2360
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2361 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2362
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2363 def visit_ClassDef(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2364 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2365 Public method to handle class definitions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2366
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2367 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2368 @type ast.ClassDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2369 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2370 self.__checkForM521(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2371 self.__checkForM524_M527(node)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2372
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2373 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2374
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2375 def visit_Try(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2376 """
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2377 Public method to handle 'try' statements.
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2378
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2379 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2380 @type ast.Try
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2381 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2382 self.__checkForM512(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2383 self.__checkForM525(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2384
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2385 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2386
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2387 def visit_TryStar(self, node):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2388 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2389 Public method to handle 'except*' statements.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2390
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2391 @param node reference to the node to be processed
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2392 @type ast.TryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2393 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2394 outerTryStar = self.__inTryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2395 self.__inTryStar = "*"
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2396 self.visit_Try(node)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2397 self.__inTryStar = outerTryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2398
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2399 def visit_Compare(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2400 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2401 Public method to handle comparison statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2402
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2403 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2404 @type ast.Compare
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2405 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2406 self.__checkForM515(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2407
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2408 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2409
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2410 def visit_Raise(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2411 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2412 Public method to handle 'raise' statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2413
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2414 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2415 @type ast.Raise
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2416 """
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2417 if node.exc is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2418 self.__M540CaughtException = None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2419 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2420 self.__checkForM540Usage(node.exc)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2421 self.__checkForM540Usage(node.cause)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2422 self.__checkForM516(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2423
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2424 self.generic_visit(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2425
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2426 def visit_With(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2427 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2428 Public method to handle 'with' statements.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2429
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2430 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2431 @type ast.With
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2432 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2433 self.__checkForM517(node)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2434 self.__checkForM522(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2435
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2436 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2437
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2438 def visit_JoinedStr(self, node):
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2439 """
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2440 Public method to handle f-string arguments.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2441
7021
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2442 @param node reference to the node to be processed
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2443 @type ast.JoinedStr
2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6942
diff changeset
2444 """
7894
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
2445 for value in node.values:
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
2446 if isinstance(value, ast.FormattedValue):
4370a8b30648 Changed the minimum supported Python version to 3.6.0.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7784
diff changeset
2447 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2448
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2449 self.violations.append((node, "M-581"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2450
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2451 def visit_AnnAssign(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2452 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2453 Public method to check annotated assign statements.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2454
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2455 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2456 @type ast.AnnAssign
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2457 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2458 self.__checkForM532(node)
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2459 self.__checkForM540Usage(node.value)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2460
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2461 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2462
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2463 def visit_Import(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2464 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2465 Public method to check imports.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2466
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2467 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2468 @type ast.Import
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2469 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2470 self.__checkForM505(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2471
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2472 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2473
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2474 def visit_ImportFrom(self, node):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2475 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2476 Public method to check from imports.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2477
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2478 @param node reference to the node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2479 @type ast.Import
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2480 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2481 self.visit_Import(node)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2482
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2483 def visit_Set(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2484 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2485 Public method to check a set.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2486
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2487 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2488 @type ast.Set
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2489 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2490 self.__checkForM533(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2491
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2492 self.generic_visit(node)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2493
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2494 def visit_Dict(self, node):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2495 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2496 Public method to check a dictionary.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2497
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2498 @param node reference to the node to be processed
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2499 @type ast.Dict
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2500 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2501 self.__checkForM541(node)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2502
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2503 self.generic_visit(node)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2504
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2505 def __checkForM505(self, node):
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2506 """
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2507 Private method to check the use of *strip().
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2508
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2509 @param node reference to the node to be processed
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2510 @type ast.Call
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
2511 """
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2512 if isinstance(node, ast.Import):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2513 for name in node.names:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2514 self.__M505Imports.add(name.asname or name.name)
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2515 elif isinstance(node, ast.ImportFrom):
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2516 for name in node.names:
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2517 self.__M505Imports.add(f"{node.module}.{name.name or name.asname}")
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2518 elif isinstance(node, ast.Call) and isinstance(node.func, ast.Attribute):
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2519 if node.func.attr not in ("lstrip", "rstrip", "strip"):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2520 return # method name doesn't match
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2521
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2522 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2523 isinstance(node.func.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2524 and node.func.value.id in self.__M505Imports
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2525 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2526 return # method is being run on an imported module
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2527
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2528 if len(node.args) != 1 or not AstUtilities.isString(node.args[0]):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2529 return # used arguments don't match the builtin strip
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2530
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2531 value = AstUtilities.getValue(node.args[0])
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2532 if len(value) == 1:
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2533 return # stripping just one character
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2534
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
2535 if len(value) == len(set(value)):
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2536 return # no characters appear more than once
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2537
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2538 self.violations.append((node, "M-505"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2539
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2540 def __checkForM506_M508(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2541 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2542 Private method to check the use of mutable literals, comprehensions and calls.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2543
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2544 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2545 @type ast.AsyncFunctionDef or ast.FunctionDef
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2546 """
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2547 visitor = FunctionDefDefaultsVisitor("M-506", "M-508")
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2548 visitor.visit(node.args.defaults + node.args.kw_defaults)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2549 self.violations.extend(visitor.errors)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2550
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2551 def __checkForM507(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2552 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2553 Private method to check for unused loop variables.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2554
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2555 @param node reference to the node to be processed
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2556 @type ast.For or ast.AsyncFor
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2557 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2558 targets = NameFinder()
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2559 targets.visit(node.target)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
2560 ctrlNames = set(filter(lambda s: not s.startswith("_"), targets.getNames()))
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2561 body = NameFinder()
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2562 for expr in node.body:
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2563 body.visit(expr)
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2564 usedNames = set(body.getNames())
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2565 for name in sorted(ctrlNames - usedNames):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2566 n = targets.getNames()[name][0]
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2567 self.violations.append((n, "M-507", name))
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
2568
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2569 def __checkForM512(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2570 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2571 Private method to check for return/continue/break inside finally blocks.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2572
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2573 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2574 @type ast.Try
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2575 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2576
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2577 def _loop(node, badNodeTypes):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2578 if isinstance(node, (ast.AsyncFunctionDef, ast.FunctionDef)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2579 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2580
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2581 if isinstance(node, (ast.While, ast.For)):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2582 badNodeTypes = (ast.Return,)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2583
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2584 elif isinstance(node, badNodeTypes):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2585 self.violations.append((node, "M-512", self.__inTryStar))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2586
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2587 for child in ast.iter_child_nodes(node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2588 _loop(child, badNodeTypes)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2589
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2590 for child in node.finalbody:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2591 _loop(child, (ast.Return, ast.Continue, ast.Break))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2592
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2593 def __checkForM513_M514_M529_M530(self, node):
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2594 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2595 Private method to check various exception handler situations.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2596
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2597 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2598 @type ast.ExceptHandler
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2599 @return list of exception handler names
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2600 @rtype list of str
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2601 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2602 handlers = self.__flattenExcepthandler(node.type)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2603 names = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2604 badHandlers = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2605 ignoredHandlers = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2606
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2607 for handler in handlers:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2608 if isinstance(handler, (ast.Name, ast.Attribute)):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2609 name = self.toNameStr(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2610 if name is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2611 ignoredHandlers.append(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2612 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2613 names.append(name)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2614 elif isinstance(handler, (ast.Call, ast.Starred)):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2615 ignoredHandlers.append(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2616 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2617 badHandlers.append(handler)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2618 if badHandlers:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2619 self.violations.append((node, "M-530"))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2620 if len(names) == 0 and not badHandlers and not ignoredHandlers:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2621 self.violations.append((node, "M-529", self.__inTryStar))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2622 elif (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2623 len(names) == 1
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2624 and not badHandlers
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2625 and not ignoredHandlers
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2626 and isinstance(node.type, ast.Tuple)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2627 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2628 self.violations.append((node, "M-513", *names, self.__inTryStar))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2629 else:
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2630 maybeError = self.__checkRedundantExcepthandlers(
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2631 names, node, self.__inTryStar
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2632 )
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2633 if maybeError is not None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2634 self.violations.append(maybeError)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2635 return names
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2636
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2637 def __checkForM515(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2638 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2639 Private method to check for pointless comparisons.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2640
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2641 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2642 @type ast.Compare
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2643 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2644 if isinstance(self.nodeStack[-2], ast.Expr):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2645 self.violations.append((node, "M-515"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2646
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2647 def __checkForM516(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2648 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2649 Private method to check for raising a literal instead of an exception.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2650
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2651 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2652 @type ast.Raise
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2653 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2654 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2655 AstUtilities.isNameConstant(node.exc)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2656 or AstUtilities.isNumber(node.exc)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2657 or AstUtilities.isString(node.exc)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2658 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2659 self.violations.append((node, "M-516"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2660
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2661 def __checkForM517(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2662 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2663 Private method to check for use of the evil syntax
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2664 'with assertRaises(Exception): or 'with pytest.raises(Exception):'.
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2665
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2666 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2667 @type ast.With
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2668 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2669 item = node.items[0]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2670 itemContext = item.context_expr
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2671 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2672 hasattr(itemContext, "func")
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2673 and (
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2674 (
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2675 isinstance(itemContext.func, ast.Attribute)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2676 and (
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2677 itemContext.func.attr == "assertRaises"
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2678 or (
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2679 itemContext.func.attr == "raises"
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2680 and isinstance(itemContext.func.value, ast.Name)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2681 and itemContext.func.value.id == "pytest"
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2682 and "match" not in (kwd.arg for kwd in itemContext.keywords)
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2683 )
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2684 )
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2685 )
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2686 or (
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2687 isinstance(itemContext.func, ast.Name)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2688 and itemContext.func.id == "raises"
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2689 and isinstance(itemContext.func.ctx, ast.Load)
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
2690 and "pytest.raises" in self.__M505Imports
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2691 and "match" not in (kwd.arg for kwd in itemContext.keywords)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2692 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2693 )
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2694 and len(itemContext.args) == 1
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2695 and isinstance(itemContext.args[0], ast.Name)
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2696 and itemContext.args[0].id in ("Exception", "BaseException")
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2697 and not item.optional_vars
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2698 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2699 self.violations.append((node, "M-517"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2700
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2701 def __checkForM518(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2702 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2703 Private method to check for useless expressions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2704
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2705 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2706 @type ast.FunctionDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2707 """
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2708 if not isinstance(node, ast.Expr):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2709 return
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2710
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2711 if isinstance(
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2712 node.value,
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2713 (ast.List, ast.Set, ast.Dict, ast.Tuple),
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2714 ) or (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2715 isinstance(node.value, ast.Constant)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2716 and (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2717 isinstance(
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2718 node.value.value,
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2719 (int, float, complex, bytes, bool),
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2720 )
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2721 or node.value.value is None
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2722 )
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
2723 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2724 self.violations.append((node, "M-518", node.value.__class__.__name__))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2725
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2726 def __checkForM519(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2727 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2728 Private method to check for use of 'functools.lru_cache' or 'functools.cache'.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2729
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2730 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2731 @type ast.FunctionDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2732 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2733 caches = {
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2734 "functools.cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2735 "functools.lru_cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2736 "cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2737 "lru_cache",
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2738 }
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2739
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2740 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2741 len(node.decorator_list) == 0
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2742 or len(self.contexts) < 2
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2743 or not isinstance(self.contexts[-2].node, ast.ClassDef)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2744 ):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2745 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2746
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2747 # Preserve decorator order so we can get the lineno from the decorator node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2748 # rather than the function node (this location definition changes in Python 3.8)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2749 resolvedDecorators = (
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
2750 ".".join(composeCallPath(decorator)) for decorator in node.decorator_list
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2751 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2752 for idx, decorator in enumerate(resolvedDecorators):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2753 if decorator in {"classmethod", "staticmethod"}:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2754 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2755
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2756 if decorator in caches:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2757 self.violations.append((node.decorator_list[idx], "M-519"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2758 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2759
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2760 def __checkForM520(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2761 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2762 Private method to check for a loop that modifies its iterable.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2763
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2764 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2765 @type ast.For or ast.AsyncFor
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2766 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2767 targets = NameFinder()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2768 targets.visit(node.target)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2769 ctrlNames = set(targets.getNames())
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2770
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2771 iterset = M520NameFinder()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2772 iterset.visit(node.iter)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2773 itersetNames = set(iterset.getNames())
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2774
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2775 for name in sorted(ctrlNames):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2776 if name in itersetNames:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2777 n = targets.getNames()[name][0]
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2778 self.violations.append((n, "M-520"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2779
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2780 def __checkForM521(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2781 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2782 Private method to check for use of an f-string as docstring.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2783
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2784 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2785 @type ast.FunctionDef or ast.ClassDef
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2786 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2787 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2788 node.body
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2789 and isinstance(node.body[0], ast.Expr)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2790 and isinstance(node.body[0].value, ast.JoinedStr)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2791 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2792 self.violations.append((node.body[0].value, "M-521"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2793
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2794 def __checkForM522(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2795 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2796 Private method to check for use of an f-string as docstring.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2797
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2798 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2799 @type ast.With
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2800 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2801 item = node.items[0]
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2802 itemContext = item.context_expr
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2803 if (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2804 hasattr(itemContext, "func")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2805 and hasattr(itemContext.func, "value")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2806 and hasattr(itemContext.func.value, "id")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2807 and itemContext.func.value.id == "contextlib"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2808 and hasattr(itemContext.func, "attr")
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2809 and itemContext.func.attr == "suppress"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2810 and len(itemContext.args) == 0
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2811 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2812 self.violations.append((node, "M-522"))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2813
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2814 def __checkForM523(self, loopNode):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2815 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2816 Private method to check that functions (including lambdas) do not use loop
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2817 variables.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2818
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2819 @param loopNode reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2820 @type ast.For, ast.AsyncFor, ast.While, ast.ListComp, ast.SetComp,ast.DictComp,
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2821 or ast.GeneratorExp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2822 """
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2823 safe_functions = []
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2824 suspiciousVariables = []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2825 for node in ast.walk(loopNode):
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2826 # check if function is immediately consumed to avoid false alarm
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2827 if isinstance(node, ast.Call):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2828 # check for filter&reduce
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2829 if (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2830 isinstance(node.func, ast.Name)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2831 and node.func.id in ("filter", "reduce", "map")
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2832 ) or (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2833 isinstance(node.func, ast.Attribute)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2834 and node.func.attr == "reduce"
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2835 and isinstance(node.func.value, ast.Name)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2836 and node.func.value.id == "functools"
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2837 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2838 for arg in node.args:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2839 if isinstance(arg, BugBearVisitor.FUNCTION_NODES):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2840 safe_functions.append(arg)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2841
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2842 # check for key=
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2843 for keyword in node.keywords:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2844 if keyword.arg == "key" and isinstance(
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2845 keyword.value, BugBearVisitor.FUNCTION_NODES
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2846 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2847 safe_functions.append(keyword.value)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2848
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2849 # mark `return lambda: x` as safe
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2850 # does not (currently) check inner lambdas in a returned expression
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2851 # e.g. `return (lambda: x, )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2852 if isinstance(node, ast.Return) and isinstance(
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2853 node.value, BugBearVisitor.FUNCTION_NODES
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2854 ):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2855 safe_functions.append(node.value)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2856
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2857 # find unsafe functions
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2858 if (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2859 isinstance(node, BugBearVisitor.FUNCTION_NODES)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2860 and node not in safe_functions
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2861 ):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2862 argnames = {
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2863 arg.arg for arg in ast.walk(node.args) if isinstance(arg, ast.arg)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2864 }
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2865 if isinstance(node, ast.Lambda):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2866 bodyNodes = ast.walk(node.body)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2867 else:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2868 bodyNodes = itertools.chain.from_iterable(map(ast.walk, node.body))
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2869 errors = []
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2870 for name in bodyNodes:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2871 if isinstance(name, ast.Name) and name.id not in argnames:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2872 if isinstance(name.ctx, ast.Load):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2873 errors.append((name.lineno, name.col_offset, name.id, name))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2874 elif isinstance(name.ctx, ast.Store):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2875 argnames.add(name.id)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2876 for err in errors:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2877 if err[2] not in argnames and err not in self.__M523Seen:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2878 self.__M523Seen.add(err) # dedupe across nested loops
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2879 suspiciousVariables.append(err)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2880
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2881 if suspiciousVariables:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2882 reassignedInLoop = set(self.__getAssignedNames(loopNode))
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2883
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2884 for err in sorted(suspiciousVariables):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2885 if reassignedInLoop.issuperset(err[2]):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2886 self.violations.append((err[3], "M-523", err[2]))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2887
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2888 def __checkForM524_M527(self, node):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2889 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2890 Private method to check for inheritance from abstract classes in abc and lack of
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2891 any methods decorated with abstract*.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2892
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2893 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2894 @type ast.ClassDef
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
2895 """ # __IGNORE_WARNING_D-234r__
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2896
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2897 def isAbcClass(value, name="ABC"):
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2898 if isinstance(value, ast.keyword):
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2899 return value.arg == "metaclass" and isAbcClass(value.value, "ABCMeta")
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2900
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2901 # class foo(ABC)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2902 # class foo(abc.ABC)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2903 return (isinstance(value, ast.Name) and value.id == name) or (
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2904 isinstance(value, ast.Attribute)
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2905 and value.attr == name
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2906 and isinstance(value.value, ast.Name)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2907 and value.value.id == "abc"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2908 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2909
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2910 def isAbstractDecorator(expr):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2911 return (isinstance(expr, ast.Name) and expr.id[:8] == "abstract") or (
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2912 isinstance(expr, ast.Attribute) and expr.attr[:8] == "abstract"
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2913 )
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2914
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2915 def isOverload(expr):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2916 return (isinstance(expr, ast.Name) and expr.id == "overload") or (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2917 isinstance(expr, ast.Attribute) and expr.attr == "overload"
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2918 )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2919
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2920 def emptyBody(body):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2921 def isStrOrEllipsis(node):
10170
6cf1ee737d8f Corrected some more code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10169
diff changeset
2922 return isinstance(node, ast.Constant) and (
6cf1ee737d8f Corrected some more code style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10169
diff changeset
2923 node.value is Ellipsis or isinstance(node.value, str)
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2924 )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2925
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2926 # Function body consist solely of `pass`, `...`, and/or (doc)string literals
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2927 return all(
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2928 isinstance(stmt, ast.Pass)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2929 or (isinstance(stmt, ast.Expr) and isStrOrEllipsis(stmt.value))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2930 for stmt in body
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2931 )
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2932
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2933 # don't check multiple inheritance
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2934 if len(node.bases) + len(node.keywords) > 1:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2935 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2936
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2937 # only check abstract classes
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2938 if not any(map(isAbcClass, (*node.bases, *node.keywords))):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2939 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2940
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2941 hasMethod = False
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2942 hasAbstractMethod = False
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2943
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2944 if not any(map(isAbcClass, (*node.bases, *node.keywords))):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2945 return
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2946
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2947 for stmt in node.body:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2948 # Ignore abc's that declares a class attribute that must be set
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
2949 if isinstance(stmt, ast.AnnAssign) and stmt.value is None:
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2950 hasAbstractMethod = True
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2951 continue
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2952
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2953 # only check function defs
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2954 if not isinstance(stmt, (ast.FunctionDef, ast.AsyncFunctionDef)):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2955 continue
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2956 hasMethod = True
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2957
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2958 hasAbstractDecorator = any(map(isAbstractDecorator, stmt.decorator_list))
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2959
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2960 hasAbstractMethod |= hasAbstractDecorator
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2961
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2962 if (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2963 not hasAbstractDecorator
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2964 and emptyBody(stmt.body)
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2965 and not any(map(isOverload, stmt.decorator_list))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2966 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2967 self.violations.append((stmt, "M-527", stmt.name))
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2968
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
2969 if hasMethod and not hasAbstractMethod:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2970 self.violations.append((node, "M-524", node.name))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2971
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2972 def __checkForM525(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2973 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2974 Private method to check for exceptions being handled multiple times.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2975
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2976 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2977 @type ast.Try
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2978 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2979 seen = []
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2980
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2981 for handler in node.handlers:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2982 if isinstance(handler.type, (ast.Name, ast.Attribute)):
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2983 name = ".".join(composeCallPath(handler.type))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2984 seen.append(name)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2985 elif isinstance(handler.type, ast.Tuple):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2986 # to avoid checking the same as M514, remove duplicates per except
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2987 uniques = set()
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2988 for entry in handler.type.elts:
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
2989 name = ".".join(composeCallPath(entry))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2990 uniques.add(name)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2991 seen.extend(uniques)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2992
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2993 # sort to have a deterministic output
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2994 duplicates = sorted({x for x in seen if seen.count(x) > 1})
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2995 for duplicate in duplicates:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
2996 self.violations.append((node, "M-525", duplicate, self.__inTryStar))
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
2997
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2998 def __checkForM526(self, node):
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
2999 """
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3000 Private method to check for Star-arg unpacking after keyword argument.
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3001
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3002 @param node reference to the node to be processed
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3003 @type ast.Call
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3004 """
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3005 if not node.keywords:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3006 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3007
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3008 starreds = [arg for arg in node.args if isinstance(arg, ast.Starred)]
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3009 if not starreds:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3010 return
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3011
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3012 firstKeyword = node.keywords[0].value
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3013 for starred in starreds:
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3014 if (starred.lineno, starred.col_offset) > (
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3015 firstKeyword.lineno,
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3016 firstKeyword.col_offset,
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3017 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3018 self.violations.append((node, "M-526"))
9595
2bd590c40309 Updated some checker methods.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9482
diff changeset
3019
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3020 def __checkForM528(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3021 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3022 Private method to check for warn without stacklevel.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3023
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3024 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3025 @type ast.Call
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3026 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3027 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3028 isinstance(node.func, ast.Attribute)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3029 and node.func.attr == "warn"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3030 and isinstance(node.func.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3031 and node.func.value.id == "warnings"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3032 and not any(kw.arg == "stacklevel" for kw in node.keywords)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3033 and len(node.args) < 3
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3034 and not any(isinstance(a, ast.Starred) for a in node.args)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3035 and not any(kw.arg is None for kw in node.keywords)
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3036 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3037 self.violations.append((node, "M-528"))
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3038
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3039 def __checkForM531(self, loopNode):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3040 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3041 Private method to check that 'itertools.groupby' isn't iterated over more than
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3042 once.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3043
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3044 A warning is emitted when the generator returned by 'groupby()' is used
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3045 more than once inside a loop body or when it's used in a nested loop.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3046
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3047 @param loopNode reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3048 @type ast.For or ast.AsyncFor
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3049 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3050 # for <loop_node.target> in <loop_node.iter>: ...
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3051 if isinstance(loopNode.iter, ast.Call):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3052 node = loopNode.iter
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3053 if (isinstance(node.func, ast.Name) and node.func.id in ("groupby",)) or (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3054 isinstance(node.func, ast.Attribute)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3055 and node.func.attr == "groupby"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3056 and isinstance(node.func.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3057 and node.func.value.id == "itertools"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3058 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3059 # We have an invocation of groupby which is a simple unpacking
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3060 if isinstance(loopNode.target, ast.Tuple) and isinstance(
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3061 loopNode.target.elts[1], ast.Name
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3062 ):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3063 groupName = loopNode.target.elts[1].id
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3064 else:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3065 # Ignore any 'groupby()' invocation that isn't unpacked
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3066 return
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3067
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3068 numUsages = 0
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3069 for node in self.__walkList(loopNode.body):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3070 # Handled nested loops
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3071 if isinstance(node, ast.For):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3072 for nestedNode in self.__walkList(node.body):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3073 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3074 isinstance(nestedNode, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3075 and nestedNode.id == groupName
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3076 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3077 self.violations.append((nestedNode, "M-531"))
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3078
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3079 # Handle multiple uses
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3080 if isinstance(node, ast.Name) and node.id == groupName:
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3081 numUsages += 1
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3082 if numUsages > 1:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3083 self.violations.append((nestedNode, "M-531"))
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3084
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3085 def __checkForM532(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3086 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3087 Private method to check for possible unintentional typing annotation.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3088
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3089 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3090 @type ast.AnnAssign
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3091 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3092 if (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3093 node.value is None
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3094 and hasattr(node.target, "value")
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3095 and isinstance(node.target.value, ast.Name)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3096 and (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3097 isinstance(node.target, ast.Subscript)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3098 or (
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3099 isinstance(node.target, ast.Attribute)
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3100 and node.target.value.id != "self"
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3101 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3102 )
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3103 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3104 self.violations.append((node, "M-532"))
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3105
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3106 def __checkForM533(self, node):
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3107 """
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3108 Private method to check a set for duplicate items.
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3109
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3110 @param node reference to the node to be processed
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3111 @type ast.Set
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3112 """
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3113 seen = set()
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3114 for elt in node.elts:
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3115 if not isinstance(elt, ast.Constant):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3116 continue
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3117 if elt.value in seen:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3118 self.violations.append((node, "M-533", repr(elt.value)))
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3119 else:
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3120 seen.add(elt.value)
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3121
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3122 def __checkForM534(self, node):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3123 """
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3124 Private method to check that re.sub/subn/split arguments flags/count/maxsplit
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3125 are passed as keyword arguments.
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3126
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3127 @param node reference to the node to be processed
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3128 @type ast.Call
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3129 """
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3130 if not isinstance(node.func, ast.Attribute):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3131 return
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3132 func = node.func
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3133 if not isinstance(func.value, ast.Name) or func.value.id != "re":
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3134 return
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3135
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3136 def check(numArgs, paramName):
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3137 if len(node.args) > numArgs:
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3138 arg = node.args[numArgs]
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3139 self.violations.append((arg, "M-534", func.attr, paramName))
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3140
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3141 if func.attr in ("sub", "subn"):
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3142 check(3, "count")
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3143 elif func.attr == "split":
10186
91c3ba0767ad Updated the 'flake8-bugbear' based checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10175
diff changeset
3144 check(2, "maxsplit")
10048
df836ff707fd Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9653
diff changeset
3145
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3146 def __checkForM535(self, node):
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3147 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3148 Private method to check that a static key isn't used in a dict comprehension.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3149
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3150 Record a warning if a likely unchanging key is used - either a constant,
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3151 or a variable that isn't coming from the generator expression.
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3152
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3153 @param node reference to the node to be processed
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3154 @type ast.DictComp
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3155 """
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3156 if isinstance(node.key, ast.Constant):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3157 self.violations.append((node, "M-535", node.key.value))
10359
de0420dac60e Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10356
diff changeset
3158 elif isinstance(
de0420dac60e Corrected some code formatting and style issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10356
diff changeset
3159 node.key, ast.Name
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3160 ) and node.key.id not in self.__getDictCompLoopAndNamedExprVarNames(node):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3161 self.violations.append((node, "M-535", node.key.id))
10356
09c698245a5c Updated the 'Miscellaneous' checker to support more cases.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10186
diff changeset
3162
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3163 def __checkForM539(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3164 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3165 Private method to check for correct ContextVar usage.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3166
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3167 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3168 @type ast.Call
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3169 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3170 if not (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3171 (isinstance(node.func, ast.Name) and node.func.id == "ContextVar")
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3172 or (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3173 isinstance(node.func, ast.Attribute)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3174 and node.func.attr == "ContextVar"
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3175 and isinstance(node.func.value, ast.Name)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3176 and node.func.value.id == "contextvars"
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3177 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3178 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3179 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3180
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3181 # ContextVar only takes one kw currently, but better safe than sorry
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3182 for kw in node.keywords:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3183 if kw.arg == "default":
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3184 break
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3185 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3186 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3187
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3188 visitor = FunctionDefDefaultsVisitor("M-539", "M-539")
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3189 visitor.visit(kw.value)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3190 self.violations.extend(visitor.errors)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3191
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3192 def __checkForM540AddNote(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3193 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3194 Private method to check add_note usage.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3195
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3196 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3197 @type ast.Attribute
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3198 @return flag
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3199 @rtype bool
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3200 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3201 if (
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3202 node.attr == "add_note"
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3203 and isinstance(node.value, ast.Name)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3204 and self.__M540CaughtException
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3205 and node.value.id == self.__M540CaughtException.name
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3206 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3207 self.__M540CaughtException.hasNote = True
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3208 return True
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3209
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3210 return False
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3211
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3212 def __checkForM540Usage(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3213 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3214 Private method to check the usage of exceptions with added note.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3215
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3216 @param node reference to the node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3217 @type ast.expr or None
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
3218 """ # noqa: D-234y
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
3219
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3220 def superwalk(node: ast.AST | list[ast.AST]):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3221 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3222 Function to walk an AST node or a list of AST nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3223
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3224 @param node reference to the node or a list of nodes to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3225 @type ast.AST or list[ast.AST]
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3226 @yield next node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3227 @ytype ast.AST
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3228 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3229 if isinstance(node, list):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3230 for n in node:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3231 yield from ast.walk(n)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3232 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3233 yield from ast.walk(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3234
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3235 if not self.__M540CaughtException or node is None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3236 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3237
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3238 for n in superwalk(node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3239 if isinstance(n, ast.Name) and n.id == self.__M540CaughtException.name:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3240 self.__M540CaughtException = None
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3241 break
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3242
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3243 def __checkForM541(self, node):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3244 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3245 Private method to check for duplicate key value pairs in a dictionary literal.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3246
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3247 @param node reference to the node to be processed
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3248 @type ast.Dict
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
3249 """ # noqa: D-234r
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3250
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3251 def convertToValue(item):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3252 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3253 Function to extract the value of a given item.
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3254
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3255 @param item node to extract value from
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3256 @type ast.Ast
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3257 @return value of the node
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3258 @rtype Any
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3259 """
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3260 if isinstance(item, ast.Constant):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3261 return item.value
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3262 elif isinstance(item, ast.Tuple):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3263 return tuple(convertToValue(i) for i in item.elts)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3264 elif isinstance(item, ast.Name):
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3265 return M541VariableKeyType(item.id)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3266 else:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3267 return M541UnhandledKeyType()
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3268
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3269 keys = [convertToValue(key) for key in node.keys]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3270 keyCounts = Counter(keys)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3271 duplicateKeys = [key for key, count in keyCounts.items() if count > 1]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3272 for key in duplicateKeys:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3273 keyIndices = [i for i, iKey in enumerate(keys) if iKey == key]
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3274 seen = set()
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3275 for index in keyIndices:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3276 value = convertToValue(node.values[index])
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3277 if value in seen:
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3278 keyNode = node.keys[index]
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3279 self.violations.append((keyNode, "M-541"))
11138
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3280 seen.add(value)
1f743bad6fd3 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11134
diff changeset
3281
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3282 def __checkForM569(self, node):
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3283 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3284 Private method to check for changes to a loop's mutable iterable.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3285
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3286 @param node loop node to be checked
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3287 @type ast.For
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3288 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3289 if isinstance(node.iter, ast.Name):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3290 name = self.toNameStr(node.iter)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3291 elif isinstance(node.iter, ast.Attribute):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3292 name = self.toNameStr(node.iter)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3293 else:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3294 return
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3295 checker = M569Checker(name, self)
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3296 checker.visit(node.body)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3297 for mutation in checker.mutations:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3298 self.violations.append((mutation, "M-569"))
10639
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3299
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3300
757bfe32983f Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10516
diff changeset
3301 class M569Checker(ast.NodeVisitor):
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3302 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3303 Class traversing a 'for' loop body to check for modifications to a loop's
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3304 mutable iterable.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3305 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3306
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3307 # https://docs.python.org/3/library/stdtypes.html#mutable-sequence-types
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3308 MUTATING_FUNCTIONS = (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3309 "append",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3310 "sort",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3311 "reverse",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3312 "remove",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3313 "clear",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3314 "extend",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3315 "insert",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3316 "pop",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3317 "popitem",
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3318 )
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3319
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3320 def __init__(self, name, bugbear):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3321 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3322 Constructor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3323
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3324 @param name name of the iterator
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3325 @type str
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3326 @param bugbear reference to the bugbear visitor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3327 @type BugBearVisitor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3328 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3329 self.__name = name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3330 self.__bb = bugbear
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3331 self.mutations = []
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3332
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3333 def visit_Delete(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3334 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3335 Public method handling 'Delete' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3336
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3337 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3338 @type ast.Delete
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3339 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3340 for target in node.targets:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3341 if isinstance(target, ast.Subscript):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3342 name = self.__bb.toNameStr(target.value)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3343 elif isinstance(target, (ast.Attribute, ast.Name)):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3344 name = self.__bb.toNameStr(target)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3345 else:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3346 name = "" # fallback
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3347 self.generic_visit(target)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3348
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3349 if name == self.__name:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3350 self.mutations.append(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3351
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3352 def visit_Call(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3353 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3354 Public method handling 'Call' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3355
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3356 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3357 @type ast.Call
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3358 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3359 if isinstance(node.func, ast.Attribute):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3360 name = self.__bb.toNameStr(node.func.value)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3361 functionObject = name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3362 functionName = node.func.attr
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3363
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3364 if (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3365 functionObject == self.__name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3366 and functionName in self.MUTATING_FUNCTIONS
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3367 ):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3368 self.mutations.append(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3369
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3370 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3371
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3372 def visit(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3373 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3374 Public method to inspect an ast node.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3375
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3376 Like super-visit but supports iteration over lists.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3377
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3378 @param node AST node to be traversed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3379 @type TYPE
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3380 @return reference to the last processed node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3381 @rtype ast.Node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3382 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3383 if not isinstance(node, list):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3384 return super().visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3385
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3386 for elem in node:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3387 super().visit(elem)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3388 return node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3389
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3390
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3391 class ExceptBaseExceptionVisitor(ast.NodeVisitor):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3392 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3393 Class to determine, if a 'BaseException' is re-raised.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3394 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3395
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3396 def __init__(self, exceptNode):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3397 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3398 Constructor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3399
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3400 @param exceptNode exception node to be inspected
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3401 @type ast.ExceptHandler
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3402 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3403 super().__init__()
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3404 self.__root = exceptNode
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3405 self.__reRaised = False
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3406
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3407 def reRaised(self) -> bool:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3408 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3409 Public method to check, if the exception is re-raised.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3410
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3411 @return flag indicating a re-raised exception
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3412 @rtype bool
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3413 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3414 self.visit(self.__root)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3415 return self.__reRaised
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3416
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3417 def visit_Raise(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3418 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3419 Public method to handle 'Raise' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3420
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3421 If we find a corresponding `raise` or `raise e` where e was from
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3422 `except BaseException as e:` then we mark re_raised as True and can
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3423 stop scanning.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3424
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3425 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3426 @type ast.Raise
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3427 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3428 if node.exc is None or (
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3429 isinstance(node.exc, ast.Name) and node.exc.id == self.__root.name
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3430 ):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3431 self.__reRaised = True
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3432 return
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3433
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3434 super().generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3435
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3436 def visit_ExceptHandler(self, node: ast.ExceptHandler):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3437 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3438 Public method to handle 'ExceptHandler' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3439
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3440 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3441 @type ast.ExceptHandler
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3442 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3443 if node is not self.__root:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3444 return # entered a nested except - stop searching
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3445
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3446 super().generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3447
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3448
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3449 class NameFinder(ast.NodeVisitor):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3450 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3451 Class to extract a name out of a tree of nodes.
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3452 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3453
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3454 def __init__(self):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3455 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3456 Constructor
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3457 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
3458 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3459
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3460 self.__names = {}
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3461
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3462 def visit_Name(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3463 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3464 Public method to handle 'Name' nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3465
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3466 @param node reference to the node to be processed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3467 @type ast.Name
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3468 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3469 self.__names.setdefault(node.id, []).append(node)
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3470
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3471 def visit(self, node):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3472 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3473 Public method to traverse a given AST node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3474
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3475 @param node AST node to be traversed
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3476 @type ast.Node
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3477 @return reference to the last processed node
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3478 @rtype ast.Node
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3479 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3480 if isinstance(node, list):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3481 for elem in node:
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
3482 super().visit(elem)
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3483 return node
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3484 else:
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3485 return super().visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3486
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3487 def getNames(self):
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3488 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3489 Public method to return the extracted names and Name nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3490
6184
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3491 @return dictionary containing the names as keys and the list of nodes
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3492 @rtype dict
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3493 """
789e88d94899 Code Style Checker: added some checks of the bugbear checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6183
diff changeset
3494 return self.__names
6183
29384109306c Code Style Checker: started to add some bugbear code checks
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6182
diff changeset
3495
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3496
10510
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3497 class NamedExprFinder(ast.NodeVisitor):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3498 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3499 Class to extract names defined through an ast.NamedExpr.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3500 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3501
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3502 def __init__(self):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3503 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3504 Constructor
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3505 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3506 super().__init__()
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3507
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3508 self.__names = {}
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3509
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3510 def visit_NamedExpr(self, node: ast.NamedExpr):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3511 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3512 Public method handling 'NamedExpr' nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3513
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3514 @param node reference to the node to be processed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3515 @type ast.NamedExpr
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3516 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3517 self.__names.setdefault(node.target.id, []).append(node.target)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3518
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3519 self.generic_visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3520
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3521 def visit(self, node):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3522 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3523 Public method to traverse a given AST node.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3524
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3525 Like super-visit but supports iteration over lists.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3526
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3527 @param node AST node to be traversed
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3528 @type TYPE
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3529 @return reference to the last processed node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3530 @rtype ast.Node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3531 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3532 if not isinstance(node, list):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3533 super().visit(node)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3534
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3535 for elem in node:
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3536 super().visit(elem)
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3537
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3538 return node
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3539
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3540 def getNames(self):
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3541 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3542 Public method to return the extracted names and Name nodes.
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3543
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3544 @return dictionary containing the names as keys and the list of nodes
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3545 @rtype dict
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3546 """
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3547 return self.__names
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3548
fa7b8ebfbe13 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10439
diff changeset
3549
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3550 class FunctionDefDefaultsVisitor(ast.NodeVisitor):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3551 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3552 Class used by M506, M508 and M539.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3553 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3554
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3555 def __init__(
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3556 self,
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3557 errorCodeCalls, # M506 or M539
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3558 errorCodeLiterals, # M508 or M539
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3559 ):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3560 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3561 Constructor
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3562
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3563 @param errorCodeCalls error code for ast.Call nodes
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3564 @type str
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3565 @param errorCodeLiterals error code for literal nodes
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3566 @type str
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3567 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3568 self.__errorCodeCalls = errorCodeCalls
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3569 self.__errorCodeLiterals = errorCodeLiterals
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3570 for nodeType in BugbearMutableLiterals + BugbearMutableComprehensions:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3571 setattr(
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3572 self, f"visit_{nodeType}", self.__visitMutableLiteralOrComprehension
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3573 )
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3574 self.errors = []
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3575 self.__argDepth = 0
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3576
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3577 super().__init__()
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3578
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3579 def __visitMutableLiteralOrComprehension(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3580 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3581 Private method to flag mutable literals and comprehensions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3582
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3583 @param node AST node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3584 @type ast.Dict, ast.List, ast.Set, ast.ListComp, ast.DictComp or ast.SetComp
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3585 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3586 # Flag M506 if mutable literal/comprehension is not nested.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3587 # We only flag these at the top level of the expression as we
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3588 # cannot easily guarantee that nested mutable structures are not
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3589 # made immutable by outer operations, so we prefer no false positives.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3590 # e.g.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3591 # >>> def this_is_fine(a=frozenset({"a", "b", "c"})): ...
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3592 #
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3593 # >>> def this_is_not_fine_but_hard_to_detect(a=(lambda x: x)([1, 2, 3]))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3594 #
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3595 # We do still search for cases of B008 within mutable structures though.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3596 if self.__argDepth == 1:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3597 self.errors.append((node, self.__errorCodeCalls))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3598
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3599 # Check for nested functions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3600 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3601
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3602 def visit_Call(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3603 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3604 Public method to process Call nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3605
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3606 @param node AST node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3607 @type ast.Call
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3608 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3609 callPath = ".".join(composeCallPath(node.func))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3610 if callPath in BugbearMutableCalls:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3611 self.errors.append((node, self.__errorCodeCalls))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3612 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3613 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3614
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3615 if callPath in BugbearImmutableCalls:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3616 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3617 return
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3618
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3619 # Check if function call is actually a float infinity/NaN literal
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3620 if callPath == "float" and len(node.args) == 1:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3621 try:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3622 value = float(ast.literal_eval(node.args[0]))
11000
f8371a2dd08f Corrected some code style and formatting issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10999
diff changeset
3623 except Exception: # secok
10999
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3624 pass
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3625 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3626 if math.isfinite(value):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3627 self.errors.append((node, self.__errorCodeLiterals))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3628 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3629 self.errors.append((node, self.__errorCodeLiterals))
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3630
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3631 # Check for nested functions.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3632 self.generic_visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3633
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3634 def visit_Lambda(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3635 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3636 Public method to process Lambda nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3637
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3638 @param node AST node to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3639 @type ast.Lambda
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3640 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3641 # Don't recurse into lambda expressions
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3642 # as they are evaluated at call time.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3643 pass
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3644
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3645 def visit(self, node):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3646 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3647 Public method to traverse an AST node or a list of AST nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3648
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3649 This is an extended method that can also handle a list of AST nodes.
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3650
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3651 @param node AST node or list of AST nodes to be processed
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3652 @type ast.AST or list of ast.AST
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3653 """
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3654 self.__argDepth += 1
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3655 if isinstance(node, list):
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3656 for elem in node:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3657 if elem is not None:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3658 super().visit(elem)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3659 else:
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3660 super().visit(node)
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3661 self.__argDepth -= 1
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3662
c3cf24fe9113 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 10997
diff changeset
3663
9327
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3664 class M520NameFinder(NameFinder):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3665 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3666 Class to extract a name out of a tree of nodes ignoring names defined within the
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3667 local scope of a comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3668 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3669
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3670 def visit_GeneratorExp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3671 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3672 Public method to handle a generator expressions.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3673
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3674 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3675 @type ast.GeneratorExp
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3676 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3677 self.visit(node.generators)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3678
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3679 def visit_ListComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3680 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3681 Public method to handle a list comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3682
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3683 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3684 @type TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3685 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3686 self.visit(node.generators)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3687
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3688 def visit_DictComp(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3689 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3690 Public method to handle a dictionary comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3691
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3692 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3693 @type TYPE
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3694 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3695 self.visit(node.generators)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3696
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3697 def visit_comprehension(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3698 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3699 Public method to handle the 'for' of a comprehension.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3700
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3701 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3702 @type ast.comprehension
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3703 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3704 self.visit(node.iter)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3705
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3706 def visit_Lambda(self, node):
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3707 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3708 Public method to handle a Lambda function.
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3709
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3710 @param node reference to the node to be processed
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3711 @type ast.Lambda
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3712 """
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3713 self.visit(node.body)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3714 for lambdaArg in node.args.args:
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3715 self.getNames().pop(lambdaArg.arg, None)
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3716
2b768afcaee1 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9274
diff changeset
3717
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3718 class ReturnVisitor(ast.NodeVisitor):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3719 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3720 Class implementing a node visitor to check return statements.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3721 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3722
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3723 Assigns = "assigns"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3724 Refs = "refs"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3725 Returns = "returns"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3726
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3727 def __init__(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3728 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3729 Constructor
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3730 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
3731 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3732
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3733 self.__stack = []
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3734 self.violations = []
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3735 self.__loopCount = 0
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3736
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3737 @property
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3738 def assigns(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3739 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3740 Public method to get the Assign nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3741
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3742 @return dictionary containing the node name as key and line number
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3743 as value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3744 @rtype dict
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3745 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3746 return self.__stack[-1][ReturnVisitor.Assigns]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3747
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3748 @property
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3749 def refs(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3750 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3751 Public method to get the References nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3752
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3753 @return dictionary containing the node name as key and line number
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3754 as value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3755 @rtype dict
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3756 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3757 return self.__stack[-1][ReturnVisitor.Refs]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3758
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3759 @property
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3760 def returns(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3761 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3762 Public method to get the Return nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3763
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3764 @return dictionary containing the node name as key and line number
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3765 as value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3766 @rtype dict
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3767 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3768 return self.__stack[-1][ReturnVisitor.Returns]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3769
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3770 def visit_For(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3771 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3772 Public method to handle a for loop.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3773
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3774 @param node reference to the for node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3775 @type ast.For
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3776 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3777 self.__visitLoop(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3778
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3779 def visit_AsyncFor(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3780 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3781 Public method to handle an async for loop.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3782
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3783 @param node reference to the async for node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3784 @type ast.AsyncFor
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3785 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3786 self.__visitLoop(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3787
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3788 def visit_While(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3789 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3790 Public method to handle a while loop.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3791
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3792 @param node reference to the while node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3793 @type ast.While
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3794 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3795 self.__visitLoop(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3796
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3797 def __visitLoop(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3798 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3799 Private method to handle loop nodes.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3800
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3801 @param node reference to the loop node to handle
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3802 @type ast.For, ast.AsyncFor or ast.While
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3803 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3804 self.__loopCount += 1
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3805 self.generic_visit(node)
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3806 self.__loopCount -= 1
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3807
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3808 def __visitWithStack(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3809 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3810 Private method to traverse a given function node using a stack.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3811
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3812 @param node AST node to be traversed
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3813 @type ast.FunctionDef or ast.AsyncFunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3814 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3815 self.__stack.append(
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3816 {
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3817 ReturnVisitor.Assigns: defaultdict(list),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3818 ReturnVisitor.Refs: defaultdict(list),
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3819 ReturnVisitor.Returns: [],
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3820 }
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3821 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3822
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3823 self.generic_visit(node)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3824 self.__checkFunction(node)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3825 self.__stack.pop()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3826
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3827 def visit_FunctionDef(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3828 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3829 Public method to handle a function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3830
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3831 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3832 @type ast.FunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3833 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3834 self.__visitWithStack(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3835
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3836 def visit_AsyncFunctionDef(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3837 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3838 Public method to handle a function definition.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3839
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3840 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3841 @type ast.AsyncFunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3842 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3843 self.__visitWithStack(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3844
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3845 def visit_Return(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3846 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3847 Public method to handle a return node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3848
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3849 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3850 @type ast.Return
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3851 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3852 self.returns.append(node)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3853 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3854
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3855 def visit_Assign(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3856 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3857 Public method to handle an assign node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3858
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3859 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3860 @type ast.Assign
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3861 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3862 if not self.__stack:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3863 return
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3864
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3865 self.generic_visit(node.value)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3866
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3867 target = node.targets[0]
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3868 if isinstance(target, ast.Tuple) and not isinstance(node.value, ast.Tuple):
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3869 # skip unpacking assign
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3870 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3871
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3872 self.__visitAssignTarget(target)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3873
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3874 def visit_Name(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3875 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3876 Public method to handle a name node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3877
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3878 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3879 @type ast.Name
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3880 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3881 if self.__stack:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3882 self.refs[node.id].append(node.lineno)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3883
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3884 def __visitAssignTarget(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3885 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3886 Private method to handle an assign target node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3887
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3888 @param node reference to the node to handle
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3889 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3890 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3891 if isinstance(node, ast.Tuple):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3892 for elt in node.elts:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3893 self.__visitAssignTarget(elt)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3894 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3895
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3896 if not self.__loopCount and isinstance(node, ast.Name):
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3897 self.assigns[node.id].append(node.lineno)
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3898 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3899
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3900 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3901
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3902 def __checkFunction(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3903 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3904 Private method to check a function definition node.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3905
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3906 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3907 @type ast.AsyncFunctionDef or ast.FunctionDef
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3908 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3909 if not self.returns or not node.body:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3910 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3911
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3912 if len(node.body) == 1 and isinstance(node.body[-1], ast.Return):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3913 # skip functions that consist of `return None` only
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3914 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3915
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3916 if not self.__resultExists():
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3917 self.__checkUnnecessaryReturnNone()
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3918 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3919
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3920 self.__checkImplicitReturnValue()
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3921 self.__checkImplicitReturn(node.body[-1])
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3922
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3923 for n in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3924 if n.value:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3925 self.__checkUnnecessaryAssign(n.value)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3926
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3927 def __isNone(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3928 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3929 Private method to check, if a node value is None.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3930
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3931 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3932 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3933 @return flag indicating the node contains a None value
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3934 @rtype bool
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3935 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3936 return AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3937
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3938 def __isFalse(self, node):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3939 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3940 Private method to check, if a node value is False.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3941
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3942 @param node reference to the node to check
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3943 @type ast.AST
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3944 @return flag indicating the node contains a False value
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3945 @rtype bool
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3946 """
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3947 return (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3948 AstUtilities.isNameConstant(node) and AstUtilities.getValue(node) is False
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3949 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3950
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3951 def __resultExists(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3952 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3953 Private method to check the existance of a return result.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3954
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3955 @return flag indicating the existence of a return result
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3956 @rtype bool
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3957 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3958 for node in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3959 value = node.value
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3960 if value and not self.__isNone(value):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3961 return True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3962
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3963 return False
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3964
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3965 def __checkImplicitReturnValue(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3966 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3967 Private method to check for implicit return values.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3968 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3969 for node in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3970 if not node.value:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3971 self.violations.append((node, "M-832"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3972
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3973 def __checkUnnecessaryReturnNone(self):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3974 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3975 Private method to check for an unnecessary 'return None' statement.
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3976 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3977 for node in self.returns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3978 if self.__isNone(node.value):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3979 self.violations.append((node, "M-831"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3980
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3981 def __checkImplicitReturn(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3982 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3983 Private method to check for an implicit return statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3984
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3985 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3986 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3987 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3988 if isinstance(node, ast.If):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3989 if not node.body or not node.orelse:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
3990 self.violations.append((node, "M-833"))
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3991 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3992
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3993 self.__checkImplicitReturn(node.body[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3994 self.__checkImplicitReturn(node.orelse[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3995 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
3996
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
3997 if isinstance(node, (ast.For, ast.AsyncFor)) and node.orelse:
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3998 self.__checkImplicitReturn(node.orelse[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
3999 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4000
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
4001 if isinstance(node, (ast.With, ast.AsyncWith)):
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4002 self.__checkImplicitReturn(node.body[-1])
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4003 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4004
7651
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
4005 if isinstance(node, ast.Assert) and self.__isFalse(node.test):
ca87b7490449 Code Style Checker: updated the return style checker.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7639
diff changeset
4006 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4007
6889
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
4008 try:
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
4009 okNodes = (ast.Return, ast.Raise, ast.While, ast.Try)
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
4010 except AttributeError:
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
4011 okNodes = (ast.Return, ast.Raise, ast.While)
334257ef9435 MiscellaneousChecker: fixed some Python2 related issues.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6882
diff changeset
4012 if not isinstance(node, okNodes):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4013 self.violations.append((node, "M-833"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4014
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4015 def __checkUnnecessaryAssign(self, node):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4016 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4017 Private method to check for an unnecessary assign statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4018
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4019 @param node reference to the node to check
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4020 @type ast.AST
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4021 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4022 if not isinstance(node, ast.Name):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4023 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4024
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4025 varname = node.id
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4026 returnLineno = node.lineno
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4027
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4028 if varname not in self.assigns:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4029 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4030
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4031 if varname not in self.refs:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4032 self.violations.append((node, "M-834"))
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4033 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4034
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4035 if self.__hasRefsBeforeNextAssign(varname, returnLineno):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4036 return
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4037
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4038 self.violations.append((node, "M-834"))
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4039
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4040 def __hasRefsBeforeNextAssign(self, varname, returnLineno):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4041 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4042 Private method to check for references before a following assign
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4043 statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4044
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4045 @param varname variable name to check for
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4046 @type str
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4047 @param returnLineno line number of the return statement
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4048 @type int
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4049 @return flag indicating the existence of references
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4050 @rtype bool
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4051 """
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4052 beforeAssign = 0
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4053 afterAssign = None
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4054
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4055 for lineno in sorted(self.assigns[varname]):
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4056 if lineno > returnLineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4057 afterAssign = lineno
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4058 break
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4059
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4060 if lineno <= returnLineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4061 beforeAssign = lineno
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4062
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4063 for lineno in self.refs[varname]:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4064 if lineno == returnLineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4065 continue
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4066
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4067 if afterAssign:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4068 if beforeAssign < lineno <= afterAssign:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4069 return True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4070
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4071 elif beforeAssign < lineno:
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4072 return True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4073
6882
65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 6645
diff changeset
4074 return False
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4075
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4076
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4077 class DateTimeVisitor(ast.NodeVisitor):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4078 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4079 Class implementing a node visitor to check datetime function calls.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4080
9274
86fab0c74430 Added some TODO markers to update some checker code.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9221
diff changeset
4081 Note: This class is modeled after flake8_datetimez checker.
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4082 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4083
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4084 def __init__(self):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4085 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4086 Constructor
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4087 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
4088 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4089
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4090 self.violations = []
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4091
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4092 def __getFromKeywords(self, keywords, name):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4093 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4094 Private method to get a keyword node given its name.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4095
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4096 @param keywords list of keyword argument nodes
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4097 @type list of ast.AST
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4098 @param name name of the keyword node
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4099 @type str
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4100 @return keyword node
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4101 @rtype ast.AST
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4102 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4103 for keyword in keywords:
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4104 if keyword.arg == name:
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4105 return keyword
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4106
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4107 return None
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4108
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4109 def visit_Call(self, node):
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4110 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4111 Public method to handle a function call.
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4112
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4113 Every datetime related function call is check for use of the naive
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4114 variant (i.e. use without TZ info).
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4115
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4116 @param node reference to the node to be processed
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4117 @type ast.Call
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4118 """
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4119 # datetime.something()
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4120 isDateTimeClass = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4121 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4122 and isinstance(node.func.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4123 and node.func.value.id == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4124 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4125
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4126 # datetime.datetime.something()
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4127 isDateTimeModuleAndClass = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4128 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4129 and isinstance(node.func.value, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4130 and node.func.value.attr == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4131 and isinstance(node.func.value.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4132 and node.func.value.value.id == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4133 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4134
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4135 if isDateTimeClass:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4136 if node.func.attr == "datetime":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4137 # datetime.datetime(2000, 1, 1, 0, 0, 0, 0,
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4138 # datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4139 isCase1 = len(node.args) >= 8 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4140 AstUtilities.isNameConstant(node.args[7])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4141 and AstUtilities.getValue(node.args[7]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4142 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4143
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4144 # datetime.datetime(2000, 1, 1, tzinfo=datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4145 tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4146 isCase2 = tzinfoKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4147 AstUtilities.isNameConstant(tzinfoKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4148 and AstUtilities.getValue(tzinfoKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4149 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4150
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4151 if not (isCase1 or isCase2):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4152 self.violations.append((node, "M-301"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4153
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4154 elif node.func.attr == "time":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4155 # time(12, 10, 45, 0, datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4156 isCase1 = len(node.args) >= 5 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4157 AstUtilities.isNameConstant(node.args[4])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4158 and AstUtilities.getValue(node.args[4]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4159 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4160
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4161 # datetime.time(12, 10, 45, tzinfo=datetime.timezone.utc)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4162 tzinfoKeyword = self.__getFromKeywords(node.keywords, "tzinfo")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4163 isCase2 = tzinfoKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4164 AstUtilities.isNameConstant(tzinfoKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4165 and AstUtilities.getValue(tzinfoKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4166 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4167
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4168 if not (isCase1 or isCase2):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4169 self.violations.append((node, "M-321"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4170
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4171 elif node.func.attr == "date":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4172 self.violations.append((node, "M-311"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4173
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4174 if isDateTimeClass or isDateTimeModuleAndClass:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4175 if node.func.attr == "today":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4176 self.violations.append((node, "M-302"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4177
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4178 elif node.func.attr == "utcnow":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4179 self.violations.append((node, "M-303"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4180
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4181 elif node.func.attr == "utcfromtimestamp":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4182 self.violations.append((node, "M-304"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4183
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4184 elif node.func.attr in "now":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4185 # datetime.now(UTC)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4186 isCase1 = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4187 len(node.args) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4188 and len(node.keywords) == 0
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4189 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4190 AstUtilities.isNameConstant(node.args[0])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4191 and AstUtilities.getValue(node.args[0]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4192 )
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4193 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4194
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4195 # datetime.now(tz=UTC)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4196 tzKeyword = self.__getFromKeywords(node.keywords, "tz")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4197 isCase2 = tzKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4198 AstUtilities.isNameConstant(tzKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4199 and AstUtilities.getValue(tzKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4200 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4201
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4202 if not (isCase1 or isCase2):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4203 self.violations.append((node, "M-305"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4204
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4205 elif node.func.attr == "fromtimestamp":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4206 # datetime.fromtimestamp(1234, UTC)
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4207 isCase1 = (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4208 len(node.args) == 2
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4209 and len(node.keywords) == 0
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4210 and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4211 AstUtilities.isNameConstant(node.args[1])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4212 and AstUtilities.getValue(node.args[1]) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4213 )
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4214 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4215
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4216 # datetime.fromtimestamp(1234, tz=UTC)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4217 tzKeyword = self.__getFromKeywords(node.keywords, "tz")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4218 isCase2 = tzKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4219 AstUtilities.isNameConstant(tzKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4220 and AstUtilities.getValue(tzKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4221 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4222
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4223 if not (isCase1 or isCase2):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4224 self.violations.append((node, "M-306"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4225
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4226 elif node.func.attr == "strptime":
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4227 # datetime.strptime(...).replace(tzinfo=UTC)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4228 parent = getattr(node, "_dtCheckerParent", None)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4229 pparent = getattr(parent, "_dtCheckerParent", None)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4230 if not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4231 isinstance(parent, ast.Attribute) and parent.attr == "replace"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4232 ) or not isinstance(pparent, ast.Call):
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4233 isCase1 = False
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4234 else:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4235 tzinfoKeyword = self.__getFromKeywords(pparent.keywords, "tzinfo")
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4236 isCase1 = tzinfoKeyword is not None and not (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4237 AstUtilities.isNameConstant(tzinfoKeyword.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4238 and AstUtilities.getValue(tzinfoKeyword.value) is None
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4239 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4240
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4241 if not isCase1:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4242 self.violations.append((node, "M-307"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4243
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4244 elif node.func.attr == "fromordinal":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4245 self.violations.append((node, "M-308"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4246
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4247 # date.something()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4248 isDateClass = (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4249 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4250 and isinstance(node.func.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4251 and node.func.value.id == "date"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4252 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4253
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4254 # datetime.date.something()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4255 isDateModuleAndClass = (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4256 isinstance(node.func, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4257 and isinstance(node.func.value, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4258 and node.func.value.attr == "date"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4259 and isinstance(node.func.value.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4260 and node.func.value.value.id == "datetime"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4261 )
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4262
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4263 if isDateClass or isDateModuleAndClass:
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4264 if node.func.attr == "today":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4265 self.violations.append((node, "M-312"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4266
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4267 elif node.func.attr == "fromtimestamp":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4268 self.violations.append((node, "M-313"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4269
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4270 elif node.func.attr == "fromordinal":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4271 self.violations.append((node, "M-314"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4272
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4273 elif node.func.attr == "fromisoformat":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4274 self.violations.append((node, "M-315"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4275
7045
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4276 self.generic_visit(node)
c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7042
diff changeset
4277
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4278
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4279 class SysVersionVisitor(ast.NodeVisitor):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4280 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4281 Class implementing a node visitor to check the use of sys.version and
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4282 sys.version_info.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4283
11140
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4284 Note: This class is modeled after flake8-2020 v1.8.1.
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4285 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4286
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4287 def __init__(self):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4288 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4289 Constructor
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4290 """
8218
7c09585bd960 Applied some more code simplifications suggested by the new Simplify checker (super(Foo, self) => super()).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 8207
diff changeset
4291 super().__init__()
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4292
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4293 self.violations = []
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4294 self.__fromImports = {}
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4295
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4296 def visit_ImportFrom(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4297 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4298 Public method to handle a from ... import ... statement.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4299
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4300 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4301 @type ast.ImportFrom
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4302 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4303 for alias in node.names:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4304 if node.module is not None and not alias.asname:
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4305 self.__fromImports[alias.name] = node.module
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4306
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4307 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4308
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4309 def __isSys(self, attr, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4310 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4311 Private method to check for a reference to sys attribute.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4312
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4313 @param attr attribute name
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4314 @type str
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4315 @param node reference to the node to be checked
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4316 @type ast.Node
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4317 @return flag indicating a match
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4318 @rtype bool
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4319 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4320 match = False
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4321 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4322 isinstance(node, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4323 and isinstance(node.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4324 and node.value.id == "sys"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4325 and node.attr == attr
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4326 ) or (
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4327 isinstance(node, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4328 and node.id == attr
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4329 and self.__fromImports.get(node.id) == "sys"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4330 ):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4331 match = True
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4332
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4333 return match
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4334
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4335 def __isSysVersionUpperSlice(self, node, n):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4336 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4337 Private method to check the upper slice of sys.version.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4338
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4339 @param node reference to the node to be checked
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4340 @type ast.Node
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4341 @param n slice value to check against
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4342 @type int
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4343 @return flag indicating a match
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4344 @rtype bool
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4345 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4346 return (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4347 self.__isSys("version", node.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4348 and isinstance(node.slice, ast.Slice)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4349 and node.slice.lower is None
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4350 and AstUtilities.isNumber(node.slice.upper)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4351 and AstUtilities.getValue(node.slice.upper) == n
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4352 and node.slice.step is None
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4353 )
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4354
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4355 def visit_Subscript(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4356 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4357 Public method to handle a subscript.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4358
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4359 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4360 @type ast.Subscript
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4361 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4362 if self.__isSysVersionUpperSlice(node, 1):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4363 self.violations.append((node.value, "M-423"))
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4364 elif self.__isSysVersionUpperSlice(node, 3):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4365 self.violations.append((node.value, "M-401"))
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4366 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4367 self.__isSys("version", node.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4368 and isinstance(node.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4369 and AstUtilities.isNumber(node.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4370 and AstUtilities.getValue(node.slice.value) == 2
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4371 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4372 self.violations.append((node.value, "M-402"))
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4373 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4374 self.__isSys("version", node.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4375 and isinstance(node.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4376 and AstUtilities.isNumber(node.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4377 and AstUtilities.getValue(node.slice.value) == 0
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4378 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4379 self.violations.append((node.value, "M-421"))
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4380
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4381 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4382
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4383 def visit_Compare(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4384 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4385 Public method to handle a comparison.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4386
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4387 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4388 @type ast.Compare
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4389 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4390 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4391 isinstance(node.left, ast.Subscript)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4392 and self.__isSys("version_info", node.left.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4393 and isinstance(node.left.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4394 and AstUtilities.isNumber(node.left.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4395 and AstUtilities.getValue(node.left.slice.value) == 0
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4396 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4397 and isinstance(node.ops[0], ast.Eq)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4398 and AstUtilities.isNumber(node.comparators[0])
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4399 and AstUtilities.getValue(node.comparators[0]) == 3
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4400 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4401 self.violations.append((node.left, "M-411"))
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4402 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4403 self.__isSys("version", node.left)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4404 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4405 and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4406 and AstUtilities.isString(node.comparators[0])
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4407 ):
7289
6f4761a73f5f MiscellaneousChecker: prepared the code for some changes in Python 3.8.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7256
diff changeset
4408 if len(AstUtilities.getValue(node.comparators[0])) == 1:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4409 errorCode = "M-422"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4410 else:
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4411 errorCode = "M-403"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4412 self.violations.append((node.left, errorCode))
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4413 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4414 isinstance(node.left, ast.Subscript)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4415 and self.__isSys("version_info", node.left.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4416 and isinstance(node.left.slice, ast.Index)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4417 and AstUtilities.isNumber(node.left.slice.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4418 and AstUtilities.getValue(node.left.slice.value) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4419 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4420 and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4421 and AstUtilities.isNumber(node.comparators[0])
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4422 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4423 self.violations.append((node, "M-413"))
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4424 elif (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4425 isinstance(node.left, ast.Attribute)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4426 and self.__isSys("version_info", node.left.value)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4427 and node.left.attr == "minor"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4428 and len(node.ops) == 1
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4429 and isinstance(node.ops[0], (ast.Lt, ast.LtE, ast.Gt, ast.GtE))
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4430 and AstUtilities.isNumber(node.comparators[0])
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4431 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4432 self.violations.append((node, "M-414"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4433
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4434 self.generic_visit(node)
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4435
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4436 def visit_Attribute(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4437 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4438 Public method to handle an attribute.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4439
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4440 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4441 @type ast.Attribute
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4442 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4443 if (
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4444 isinstance(node.value, ast.Name)
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4445 and node.value.id == "six"
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4446 and node.attr == "PY3"
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4447 ):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4448 self.violations.append((node, "M-412"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4449
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4450 self.generic_visit(node)
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4451
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4452 def visit_Name(self, node):
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4453 """
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4454 Public method to handle an name.
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4455
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4456 @param node reference to the node to be processed
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4457 @type ast.Name
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4458 """
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4459 if node.id == "PY3" and self.__fromImports.get(node.id) == "six":
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4460 self.violations.append((node, "M-412"))
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4461
7245
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4462 self.generic_visit(node)
b47179fbb9d8 Code Style Checker (Miscellaneous Checker)
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 7057
diff changeset
4463
9221
bf71ee032bb4 Reformatted the source code using the 'Black' utility.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 9209
diff changeset
4464
11140
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4465 class DefaultMatchCaseVisitor(ast.NodeVisitor):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4466 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4467 Class implementing a node visitor to check default match cases.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4468
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4469 Note: This class is modeled after flake8-spm v0.0.1.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4470 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4471
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4472 def __init__(self):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4473 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4474 Constructor
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4475 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4476 super().__init__()
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4477
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4478 self.violations = []
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4479
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4480 def visit_Match(self, node):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4481 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4482 Public method to handle Match nodes.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4483
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4484 @param node reference to the node to be processed
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4485 @type ast.Match
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4486 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4487 for badNode, issueCode in self.__badNodes(node):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4488 self.violations.append((badNode, issueCode))
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4489
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4490 self.generic_visit(node)
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4491
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4492 def __badNodes(self, node):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4493 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4494 Private method to yield bad match nodes.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4495
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4496 @param node reference to the node to be processed
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4497 @type ast.Match
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4498 @yield tuple containing a reference to bad match case node and the corresponding
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4499 issue code
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4500 @ytype tyuple of (ast.AST, str)
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4501 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4502 for case in node.cases:
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4503 if self.__emptyMatchDefault(case):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4504 if self.__lastStatementDoesNotRaise(case):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4505 yield self.__findBadNode(case), "M-901"
11140
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4506 elif self.__returnPrecedesExceptionRaising(case):
11147
dee6e106b4d3 Modified the code style checker such, that the issue category and issue number are separated by a '-' to make up the issue code (e.g E-901).
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11145
diff changeset
4507 yield self.__findBadNode(case), "M-902"
11140
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4508
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4509 def __emptyMatchDefault(self, case):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4510 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4511 Private method to check for an empty default match case.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4512
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4513 @param case reference to the node to be processed
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4514 @type ast.match_case
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4515 @return flag indicating an empty default match case
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4516 @rtype bool
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4517 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4518 pattern = case.pattern
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4519 return isinstance(pattern, ast.MatchAs) and (
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4520 pattern.pattern is None
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4521 or (
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4522 isinstance(pattern.pattern, ast.MatchAs)
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4523 and pattern.pattern.pattern is None
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4524 )
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4525 )
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4526
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4527 def __lastStatementDoesNotRaise(self, case):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4528 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4529 Private method to check that the last case statement does not raise an
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4530 exception.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4531
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4532 @param case reference to the node to be processed
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4533 @type ast.match_case
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4534 @return flag indicating that the last case statement does not raise an
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4535 exception
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4536 @rtype bool
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4537 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4538 return not isinstance(case.body[-1], ast.Raise)
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4539
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4540 def __returnPrecedesExceptionRaising(self, case):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4541 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4542 Private method to check that no return precedes an exception raising.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4543
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4544 @param case reference to the node to be processed
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4545 @type ast.match_case
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4546 @return flag indicating that a return precedes an exception raising
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4547 @rtype bool
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4548 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4549 returnIndex = -1
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4550 raiseIndex = -1
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4551 for index, body in enumerate(case.body):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4552 if isinstance(body, ast.Return):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4553 returnIndex = index
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4554 elif isinstance(body, ast.Raise):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4555 raiseIndex = index
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4556 return returnIndex >= 0 and returnIndex < raiseIndex
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4557
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4558 def __findBadNode(self, case) -> ast.AST:
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4559 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4560 Private method returning a reference to the bad node of a case node.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4561
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4562 @param case reference to the node to be processed
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4563 @type ast.match_case
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4564 @return reference to the bad node
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4565 @rtype ast.AST
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4566 """
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4567 for body in case.body:
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4568 # Handle special case when return precedes exception raising.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4569 # In this case the bad node is that with the return statement.
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4570 if isinstance(body, ast.Return):
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4571 return body
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4572
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4573 return case.body[-1]
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4574
b823386f7591 Code Style Checker
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11138
diff changeset
4575
4555
861e1741985c Adjustments to future imports for Python 2 compatibility.
T.Rzepka <Tobias.Rzepka@gmail.com>
parents: 4540
diff changeset
4576 #
11148
15e30f0c76a8 Adjusted the code to the modified issue codes.
Detlev Offenbach <detlev@die-offenbachs.de>
parents: 11147
diff changeset
4577 # eflag: noqa = M-891

eric ide

mercurial