Thu, 02 Dec 2021 18:53:26 +0100
Continued implementing a checker for import statements (import order).
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
1 | # -*- coding: utf-8 -*- |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
2 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
3 | # Copyright (c) 2021 Detlev Offenbach <detlev@die-offenbachs.de> |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
4 | # |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
5 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
6 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
7 | Module implementing a checker for import statements. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
8 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
9 | |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
10 | import ast |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
11 | import copy |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
12 | import sys |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
13 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
14 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
15 | class ImportsChecker: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
16 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
17 | Class implementing a checker for import statements. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
18 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
19 | Codes = [ |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
20 | ## Local imports |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
21 | "I101", "I102", "I103", |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
22 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
23 | ## Imports order |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
24 | "I201", "I202", "I203", "I204", |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
25 | ] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
26 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
27 | def __init__(self, source, filename, tree, select, ignore, expected, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
28 | repeat, args): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
29 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
30 | Constructor |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
31 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
32 | @param source source code to be checked |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
33 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
34 | @param filename name of the source file |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
35 | @type str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
36 | @param tree AST tree of the source code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
37 | @type ast.Module |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
38 | @param select list of selected codes |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
39 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
40 | @param ignore list of codes to be ignored |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
41 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
42 | @param expected list of expected codes |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
43 | @type list of str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
44 | @param repeat flag indicating to report each occurrence of a code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
45 | @type bool |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
46 | @param args dictionary of arguments for the various checks |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
47 | @type dict |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
48 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
49 | self.__select = tuple(select) |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
50 | self.__ignore = ("",) if select else tuple(ignore) |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
51 | self.__expected = expected[:] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
52 | self.__repeat = repeat |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
53 | self.__filename = filename |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
54 | self.__source = source[:] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
55 | self.__tree = copy.deepcopy(tree) |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
56 | self.__args = args |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
57 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
58 | # statistics counters |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
59 | self.counters = {} |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
60 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
61 | # collection of detected errors |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
62 | self.errors = [] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
63 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
64 | checkersWithCodes = [ |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
65 | (self.__checkLocalImports, ("I101", "I102", "I103")), |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
66 | (self.__checkImportOrder, ("I201", "I202", "I203", "I204")) |
8789
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
67 | ] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
68 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
69 | self.__checkers = [] |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
70 | for checker, codes in checkersWithCodes: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
71 | if any(not (code and self.__ignoreCode(code)) |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
72 | for code in codes): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
73 | self.__checkers.append(checker) |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
74 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
75 | def __ignoreCode(self, code): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
76 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
77 | Private method to check if the message code should be ignored. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
78 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
79 | @param code message code to check for |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
80 | @type str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
81 | @return flag indicating to ignore the given code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
82 | @rtype bool |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
83 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
84 | return (code.startswith(self.__ignore) and |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
85 | not code.startswith(self.__select)) |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
86 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
87 | def __error(self, lineNumber, offset, code, *args): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
88 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
89 | Private method to record an issue. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
90 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
91 | @param lineNumber line number of the issue |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
92 | @type int |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
93 | @param offset position within line of the issue |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
94 | @type int |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
95 | @param code message code |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
96 | @type str |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
97 | @param args arguments for the message |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
98 | @type list |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
99 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
100 | if self.__ignoreCode(code): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
101 | return |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
102 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
103 | if code in self.counters: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
104 | self.counters[code] += 1 |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
105 | else: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
106 | self.counters[code] = 1 |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
107 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
108 | # Don't care about expected codes |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
109 | if code in self.__expected: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
110 | return |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
111 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
112 | if code and (self.counters[code] == 1 or self.__repeat): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
113 | # record the issue with one based line number |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
114 | self.errors.append( |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
115 | { |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
116 | "file": self.__filename, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
117 | "line": lineNumber + 1, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
118 | "offset": offset, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
119 | "code": code, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
120 | "args": args, |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
121 | } |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
122 | ) |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
123 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
124 | def run(self): |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
125 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
126 | Public method to check the given source against miscellaneous |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
127 | conditions. |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
128 | """ |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
129 | if not self.__filename: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
130 | # don't do anything, if essential data is missing |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
131 | return |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
132 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
133 | if not self.__checkers: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
134 | # don't do anything, if no codes were selected |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
135 | return |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
136 | |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
137 | for check in self.__checkers: |
b165effc3c62
Started implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
diff
changeset
|
138 | check() |
8801
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
139 | |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
140 | def getStandardModules(self): |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
141 | """ |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
142 | Public method to get a list of modules of the standard library. |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
143 | |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
144 | @return set of builtin modules |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
145 | @rtype set of str |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
146 | """ |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
147 | try: |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
148 | return sys.stdlib_module_names |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
149 | except AttributeError: |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
150 | return { |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
151 | "__future__", "__main__", "_dummy_thread", "_thread", "abc", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
152 | "aifc", "argparse", "array", "ast", "asynchat", "asyncio", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
153 | "asyncore", "atexit", "audioop", "base64", "bdb", "binascii", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
154 | "binhex", "bisect", "builtins", "bz2", "calendar", "cgi", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
155 | "cgitb", "chunk", "cmath", "cmd", "code", "codecs", "codeop", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
156 | "collections", "colorsys", "compileall", "concurrent", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
157 | "configparser", "contextlib", "contextvars", "copy", "copyreg", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
158 | "cProfile", "crypt", "csv", "ctypes", "curses", "dataclasses", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
159 | "datetime", "dbm", "decimal", "difflib", "dis", "distutils", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
160 | "doctest", "dummy_threading", "email", "encodings", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
161 | "ensurepip", "enum", "errno", "faulthandler", "fcntl", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
162 | "filecmp", "fileinput", "fnmatch", "formatter", "fractions", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
163 | "ftplib", "functools", "gc", "getopt", "getpass", "gettext", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
164 | "glob", "grp", "gzip", "hashlib", "heapq", "hmac", "html", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
165 | "http", "imaplib", "imghdr", "imp", "importlib", "inspect", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
166 | "io", "ipaddress", "itertools", "json", "keyword", "lib2to3", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
167 | "linecache", "locale", "logging", "lzma", "mailbox", "mailcap", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
168 | "marshal", "math", "mimetypes", "mmap", "modulefinder", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
169 | "msilib", "msvcrt", "multiprocessing", "netrc", "nis", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
170 | "nntplib", "numbers", "operator", "optparse", "os", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
171 | "ossaudiodev", "parser", "pathlib", "pdb", "pickle", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
172 | "pickletools", "pipes", "pkgutil", "platform", "plistlib", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
173 | "poplib", "posix", "pprint", "profile", "pstats", "pty", "pwd", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
174 | "py_compile", "pyclbr", "pydoc", "queue", "quopri", "random", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
175 | "re", "readline", "reprlib", "resource", "rlcompleter", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
176 | "runpy", "sched", "secrets", "select", "selectors", "shelve", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
177 | "shlex", "shutil", "signal", "site", "smtpd", "smtplib", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
178 | "sndhdr", "socket", "socketserver", "spwd", "sqlite3", "ssl", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
179 | "stat", "statistics", "string", "stringprep", "struct", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
180 | "subprocess", "sunau", "symbol", "symtable", "sys", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
181 | "sysconfig", "syslog", "tabnanny", "tarfile", "telnetlib", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
182 | "tempfile", "termios", "test", "textwrap", "threading", "time", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
183 | "timeit", "tkinter", "token", "tokenize", "trace", "traceback", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
184 | "tracemalloc", "tty", "turtle", "turtledemo", "types", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
185 | "typing", "unicodedata", "unittest", "urllib", "uu", "uuid", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
186 | "venv", "warnings", "wave", "weakref", "webbrowser", "winreg", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
187 | "winsound", "wsgiref", "xdrlib", "xml", "xmlrpc", "zipapp", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
188 | "zipfile", "zipimport", "zlib", "zoneinfo", |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
189 | } |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
190 | |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
191 | ####################################################################### |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
192 | ## Local imports |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
193 | ## |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
194 | ## adapted from: flake8-local-import v1.0.6 |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
195 | ####################################################################### |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
196 | |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
197 | def __checkLocalImports(self): |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
198 | """ |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
199 | Private method to check local imports. |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
200 | """ |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
201 | from .LocalImportVisitor import LocalImportVisitor |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
202 | |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
203 | visitor = LocalImportVisitor(self.__args, self) |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
204 | visitor.visit(copy.deepcopy(self.__tree)) |
8fbb21be8579
Continued implementing a checker for import statements.
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8789
diff
changeset
|
205 | for violation in visitor.violations: |
8802
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
206 | if not self.__ignoreCode(violation[1]): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
207 | node = violation[0] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
208 | reason = violation[1] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
209 | self.__error(node.lineno - 1, node.col_offset, reason) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
210 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
211 | ####################################################################### |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
212 | ## Import order |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
213 | ## |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
214 | ## adapted from: flake8-alphabetize v0.0.17 |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
215 | ####################################################################### |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
216 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
217 | def __checkImportOrder(self): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
218 | """ |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
219 | Private method to check the order of import statements. |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
220 | """ |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
221 | from .ImportNode import ImportNode |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
222 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
223 | errors = [] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
224 | imports = [] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
225 | importNodes, listNode = self.__findNodes(self.__tree) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
226 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
227 | # check for an error in '__all__' |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
228 | allError = self.__findErrorInAll(listNode) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
229 | if allError is not None: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
230 | errors.append(allError) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
231 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
232 | for importNode in importNodes: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
233 | if ( |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
234 | isinstance(importNode, ast.Import) and |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
235 | len(importNode.names) > 1 |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
236 | ): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
237 | # skip suck imports because its already handled by pycodestyle |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
238 | continue |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
239 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
240 | imports.append(ImportNode( |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
241 | self.__args.get("ApplicationPackageNames", []), |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
242 | importNode, self)) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
243 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
244 | lenImports = len(imports) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
245 | if lenImports > 0: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
246 | p = imports[0] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
247 | if p.error is not None: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
248 | errors.append(p.error) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
249 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
250 | if lenImports > 1: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
251 | for n in imports[1:]: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
252 | if n.error is not None: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
253 | errors.append(n.error) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
254 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
255 | if n == p: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
256 | errors.append((n.node, "I203", str(p), str(n))) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
257 | elif n < p: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
258 | errors.append((n.node, "I201", str(n), str(p))) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
259 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
260 | p = n |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
261 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
262 | for error in errors: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
263 | if not self.__ignoreCode(error[1]): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
264 | node = error[0] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
265 | reason = error[1] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
266 | args = error[2:] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
267 | self.__error(node.lineno - 1, node.col_offset, reason, *args) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
268 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
269 | def __findNodes(self, tree): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
270 | """ |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
271 | Private method to find all import and import from nodes of the given |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
272 | tree. |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
273 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
274 | @param tree reference to the ast node tree to be parsed |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
275 | @type ast.AST |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
276 | @return tuple containing a list of import nodes and the '__all__' node |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
277 | @rtype tuple of (ast.Import | ast.ImportFrom, ast.List | ast.Tuple) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
278 | """ |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
279 | importNodes = [] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
280 | listNode = None |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
281 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
282 | if isinstance(tree, ast.Module): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
283 | body = tree.body |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
284 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
285 | for n in body: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
286 | if isinstance(n, (ast.Import, ast.ImportFrom)): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
287 | importNodes.append(n) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
288 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
289 | elif isinstance(n, ast.Assign): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
290 | for t in n.targets: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
291 | if isinstance(t, ast.Name) and t.id == "__all__": |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
292 | value = n.value |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
293 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
294 | if isinstance(value, (ast.List, ast.Tuple)): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
295 | listNode = value |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
296 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
297 | return importNodes, listNode |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
298 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
299 | def __findErrorInAll(self, node): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
300 | """ |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
301 | Private method to check the '__all__' node for errors. |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
302 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
303 | @param node reference to the '__all__' node |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
304 | @type ast.List or ast.Tuple |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
305 | @return tuple containing a reference to the node and an error code |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
306 | @rtype rtype tuple of (ast.List | ast.Tuple, str) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
307 | """ |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
308 | if node is not None: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
309 | actualList = [] |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
310 | for el in node.elts: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
311 | if isinstance(el, ast.Constant): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
312 | actualList.append(el.value) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
313 | elif isinstance(el, ast.Str): |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
314 | actualList.append(el.s) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
315 | else: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
316 | # Can't handle anything that isn't a string literal |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
317 | return None |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
318 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
319 | expectedList = sorted(actualList) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
320 | if expectedList != actualList: |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
321 | return (node, "I204", ", ".join(expectedList)) |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
322 | |
129a973fc33e
Continued implementing a checker for import statements (import order).
Detlev Offenbach <detlev@die-offenbachs.de>
parents:
8801
diff
changeset
|
323 | return None |