eric: eric6/Plugins/CheckerPlugins/CodeStyleChecker/MiscellaneousChecker.py@4ef3b78ebb4e (annotated)

0e8d3b0c4889 MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7045

diff changeset

850

defaults = node.args.defaults[:]

0e8d3b0c4889 MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7045

diff changeset

852

defaults += node.args.kw_defaults[:]

0e8d3b0c4889 MiscellaneousChecker: changed code to cope with some strange situation where the arguments of a function definition don't have the kw_defaults attribute (AST).

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7045

diff changeset

854

pass

5621

80cce672d505 Added a checker for using mutable types as default functiona rgument (M821).

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 5619

diff changeset

856

if any(isinstance(default, mutableType)

5703

7650c11cc5f2 MiscChecker, ast: No special case for Python 2 needed.

T.Rzepka <Tobias.Rzepka@gmail.com>

parents: 5649

diff changeset

858

typeName = type(default).__name__

6183

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

860

callPath = '.'.join(composeCallPath(default.func))

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

862

self.__error(default.lineno - 1,

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

864

"M823", callPath + "()")

6183

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

866

self.__error(default.lineno - 1,

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

868

"M822", typeName)

6183

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

870

self.__error(default.lineno - 1,

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

872

"M821", typeName)

6178

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

874

def __dictShouldBeChecked(self, node):

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

876

Private function to test, if the node should be checked.

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

878

@param node reference to the AST node

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

880

@rtype bool

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

882

if not all(isinstance(key, ast.Str) for key in node.keys):

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

884

4ef3b78ebb4e Continued to resolve code style issue M841.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7249

diff changeset

886

"__IGNORE_WARNING__" in self.__source[node.lineno - 1] or

4ef3b78ebb4e Continued to resolve code style issue M841.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7249

diff changeset

888

):

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

890

905ea208884a Some refinements of the last changeset.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6177

diff changeset

892

return len(lineNumbers) == len(set(lineNumbers))

6177

af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6106

diff changeset

894

def __checkDictWithSortedKeys(self):

af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6106

diff changeset

896

Private method to check, if dictionary keys appear in sorted order.

af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6106

diff changeset

898

for node in ast.walk(self.__tree):

6177

af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6106

diff changeset

900

for key1, key2 in zip(node.keys, node.keys[1:]):

af76e795c4ce Code Style Checker: added check for dictionaries with sorted keys (M201)

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6106

diff changeset

902

self.__error(key2.lineno - 1, key2.col_offset,

6180

8d72871c16ba Code Style Checker: added checks for logging statements

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6178

diff changeset

904

8d72871c16ba Code Style Checker: added checks for logging statements

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6178

diff changeset

906

"""

8d72871c16ba Code Style Checker: added checks for logging statements

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6178

diff changeset

908

"""

8d72871c16ba Code Style Checker: added checks for logging statements

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6178

diff changeset

910

visitor.visit(self.__tree)

8d72871c16ba Code Style Checker: added checks for logging statements

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6178

diff changeset

912

self.__error(node.lineno - 1, node.col_offset, reason)

f293e95b914d Code Style Checker: added check for the 'gettext' import statement

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6180

diff changeset

914

def __checkGettext(self):

f293e95b914d Code Style Checker: added check for the 'gettext' import statement

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6180

diff changeset

916

Private method to check the 'gettext' import statement.

f293e95b914d Code Style Checker: added check for the 'gettext' import statement

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6180

diff changeset

918

for node in ast.walk(self.__tree):

4ef3b78ebb4e Continued to resolve code style issue M841.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7249

diff changeset

920

isinstance(node, ast.ImportFrom) and

4ef3b78ebb4e Continued to resolve code style issue M841.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 7249

diff changeset

922

):

f293e95b914d Code Style Checker: added check for the 'gettext' import statement

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6180

diff changeset

924

node.names[0].name)

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

926

def __checkBugBear(self):

7021

2894aa889a4e MiscellaneousChecker: added checks for use of 'gettattr' and 'setattr', bas super() calls and 'assert False' statements.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6942

diff changeset

928

Private method for bugbear checks.

29384109306c Code Style Checker: started to add some bugbear code checks

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6182

diff changeset

930

visitor = BugBearVisitor()

6184

789e88d94899 Code Style Checker: added some checks of the bugbear checker

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6183

diff changeset

932

for violation in visitor.violations:

789e88d94899 Code Style Checker: added some checks of the bugbear checker

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6183

diff changeset

934

reason = violation[1]

789e88d94899 Code Style Checker: added some checks of the bugbear checker

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6183

diff changeset

936

self.__error(node.lineno - 1, node.col_offset, reason, *params)

65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6645

diff changeset

938

def __checkReturn(self):

65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6645

diff changeset

940

Private method to check return statements.

65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6645

diff changeset

942

visitor = ReturnVisitor()

65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6645

diff changeset

944

for violation in visitor.violations:

65d1bf4b7427 MiscellaneousChecker: added a checker for advised forms of the return statement.

Detlev Offenbach <detlev@die-offenbachs.de>

parents: 6645

diff changeset

946

reason = violation[1]

7045

c2bf08f87a1d Code Style Checker: added checks for naive uses of datetime classes.

Detlev Offenbach <detlev@die-offenbach

 # -*- coding: utf-8 -*-
 # Copyright (c) 2015 - 2019 Detlev Offenbach <detlev@die-offenbachs.de>
 #
 """
 Module implementing a checker for miscellaneous checks.
 """
 import sys
 import ast
 import re
 import itertools
 from string import Formatter
 from collections import defaultdict
 import tokenize
 def composeCallPath(node):
     """
     Generator function to assemble the call path of a given node.
     @param node node to assemble call path for
     @type ast.Node
     @return call path components
     @rtype str
     """
     if isinstance(node, ast.Attribute):
         for v in composeCallPath(node.value):
             yield v
         yield node.attr
     elif isinstance(node, ast.Name):
         yield node.id
 class MiscellaneousChecker(object):
     """
     Class implementing a checker for miscellaneous checks.
     """
     Codes = [
         ## Coding line
         "M101", "M102",
         ## Copyright
         "M111", "M112",
         ## Shadowed Builtins
         "M131", "M132",
         ## Comprehensions
         "M181", "M182", "M183", "M184",
         "M185", "M186", "M187",
         "M191", "M192", "M193",
         "M195", "M196", "M197", "M198",
         ## Dictionaries with sorted keys
         "M201",
         ## Naive datetime usage
         "M301", "M302", "M303", "M304", "M305", "M306", "M307", "M308",
         "M311", "M312", "M313", "M314", "M315",
         "M321",
         ## sys.version and sys.version_info usage
         "M401", "M402", "M403",
         "M411", "M412", "M413", "M414",
         "M421", "M422", "M423",
         ## Bugbear
         "M501", "M502", "M503", "M504", "M505", "M506", "M507", "M508",
         "M509",
         "M511", "M512", "M513",
         "M521", "M522", "M523", "M524",
         ## Format Strings
         "M601",
         "M611", "M612", "M613",
         "M621", "M622", "M623", "M624", "M625",
         "M631", "M632",
         ## Logging
         "M651", "M652", "M653", "M654", "M655",
         ## Future statements
         "M701", "M702",
         ## Gettext
         "M711",
         ## print
         "M801",
         ## one element tuple
         "M811",
         ## Mutable Defaults
         "M821", "M822",
         ## return statements
         "M831", "M832", "M833", "M834",
         ## line continuation
         "M841",
         ## commented code
         "M891",
         ## syntax error
         "M901",
     ]
     Formatter = Formatter()
     FormatFieldRegex = re.compile(r'^((?:\s|.)*?)(\..*|\[.*\])?$')
     BuiltinsWhiteList = [
         "__name__",
         "__doc__",
         "credits",
     ]
     def __init__(self, source, filename, select, ignore, expected, repeat,
                  args):
         """
         Constructor
         @param source source code to be checked
         @type list of str
         @param filename name of the source file
         @type str
         @param select list of selected codes
         @type list of str
         @param ignore list of codes to be ignored
         @type list of str
         @param expected list of expected codes
         @type list of str
         @param repeat flag indicating to report each occurrence of a code
         @type bool
         @param args dictionary of arguments for the miscellaneous checks
         @type dict
         """
         self.__select = tuple(select)
         self.__ignore = ('',) if select else tuple(ignore)
         self.__expected = expected[:]
         self.__repeat = repeat
         self.__filename = filename
         self.__source = source[:]
         self.__args = args
         self.__pep3101FormatRegex = re.compile(
             r'^(?:[^\'"]*[\'"][^\'"]*[\'"])*\s*%|^\s*%')
         if sys.version_info >= (3, 0):
             import builtins
             self.__builtins = [b for b in dir(builtins)
                                if b not in self.BuiltinsWhiteList]
         else:
             import __builtin__
             self.__builtins = [b for b in dir(__builtin__)
                                if b not in self.BuiltinsWhiteList]
         # statistics counters
         self.counters = {}
         # collection of detected errors
         self.errors = []
         checkersWithCodes = [
             (self.__checkCoding, ("M101", "M102")),
             (self.__checkCopyright, ("M111", "M112")),
             (self.__checkBuiltins, ("M131", "M132")),
             (self.__checkComprehensions, ("M181", "M182", "M183", "M184",
                                           "M185", "M186", "M187",
                                           "M191", "M192", "M193",
                                           "M195", "M196", "M197", "M198")),
             (self.__checkDictWithSortedKeys, ("M201",)),
             (self.__checkDateTime, ("M301", "M302", "M303", "M304", "M305",
                                     "M306", "M307", "M308", "M311", "M312",
                                     "M313", "M314", "M315", "M321")),
             (self.__checkSysVersion, ("M401", "M402", "M403",
                                       "M411", "M412", "M413", "M414",
                                       "M421", "M422", "M423")),
             (self.__checkBugBear, ("M501", "M502", "M503", "M504", "M505",
                                    "M506", "M507", "M508", "M509",
                                    "M511", "M512", "M513",
                                    "M521", "M522", "M523", "M524")),
             (self.__checkPep3101, ("M601",)),
             (self.__checkFormatString, ("M611", "M612", "M613",
                                         "M621", "M622", "M623", "M624", "M625",
                                         "M631", "M632")),
             (self.__checkLogging, ("M651", "M652", "M653", "M654", "M655")),
             (self.__checkFuture, ("M701", "M702")),
             (self.__checkGettext, ("M711",)),
             (self.__checkPrintStatements, ("M801",)),
             (self.__checkTuple, ("M811",)),
             (self.__checkMutableDefault, ("M821", "M822")),
             (self.__checkReturn, ("M831", "M832", "M833", "M834")),
             (self.__checkLineContinuation, ("M841",)),
             (self.__checkCommentedCode, ("M891",)),
         ]
         self.__defaultArgs = {
             "BuiltinsChecker": {
                 "chr": ["unichr", ],
                 "str": ["unicode", ],
             },
             "CodingChecker": 'latin-1, utf-8',
             "CopyrightChecker": {
                 "Author": "",
                 "MinFilesize": 0,
             },
             "CommentedCodeChecker": {
                 "Aggressive": False,
             }
         }
         self.__checkers = []
         for checker, codes in checkersWithCodes:
             if any(not (code and self.__ignoreCode(code))
                     for code in codes):
                 self.__checkers.append(checker)
     def __ignoreCode(self, code):
         """
         Private method to check if the message code should be ignored.
         @param code message code to check for
         @type str
         @return flag indicating to ignore the given code
         @rtype bool
         """
         return (code.startswith(self.__ignore) and
                 not code.startswith(self.__select))
     def __error(self, lineNumber, offset, code, *args):
         """
         Private method to record an issue.
         @param lineNumber line number of the issue
         @type int
         @param offset position within line of the issue
         @type int
         @param code message code
         @type str
         @param args arguments for the message
         @type list
         """
         if self.__ignoreCode(code):
             return
         if code in self.counters:
             self.counters[code] += 1
         else:
             self.counters[code] = 1
         # Don't care about expected codes
         if code in self.__expected:
             return
         if code and (self.counters[code] == 1 or self.__repeat):
             # record the issue with one based line number
             self.errors.append(
                 (self.__filename, lineNumber + 1, offset, (code, args)))
     def __reportInvalidSyntax(self):
         """
         Private method to report a syntax error.
         """
         exc_type, exc = sys.exc_info()[:2]
         if len(exc.args) > 1:
             offset = exc.args[1]
             if len(offset) > 2:
                 offset = offset[1:3]
         else:
             offset = (1, 0)
         self.__error(offset[0] - 1, offset[1] or 0,
                      'M901', exc_type.__name__, exc.args[0])
     def __generateTree(self):
         """
         Private method to generate an AST for our source.
         @return generated AST
         @rtype ast.AST
         """
         source = "".join(self.__source)
         # Check type for py2: if not str it's unicode
         if sys.version_info[0] == 2:
             try:
                 source = source.encode('utf-8')
             except UnicodeError:
                 pass
         return compile(source, self.__filename, 'exec', ast.PyCF_ONLY_AST)
     def run(self):
         """
         Public method to check the given source against miscellaneous
         conditions.
         """
         if not self.__filename:
             # don't do anything, if essential data is missing
             return
         if not self.__checkers:
             # don't do anything, if no codes were selected
             return
         try:
             self.__tree = self.__generateTree()
         except (SyntaxError, TypeError):
             self.__reportInvalidSyntax()
             return
         for check in self.__checkers:
             check()
     def __getCoding(self):
         """
         Private method to get the defined coding of the source.
         @return tuple containing the line number and the coding
         @rtype tuple of int and str
         """
         for lineno, line in enumerate(self.__source[:5]):
             matched = re.search(r'coding[:=]\s*([-\w_.]+)',
                                 line, re.IGNORECASE)
             if matched:
                 return lineno, matched.group(1)
         else:
             return 0, ""
     def __checkCoding(self):
         """
         Private method to check the presence of a coding line and valid
         encodings.
         """
         if len(self.__source) == 0:
             return
         encodings = [e.lower().strip()
                      for e in self.__args.get(
                      "CodingChecker", self.__defaultArgs["CodingChecker"])
                      .split(",")]
         lineno, coding = self.__getCoding()
         if coding:
             if coding.lower() not in encodings:
                 self.__error(lineno, 0, "M102", coding)
         else:
             self.__error(0, 0, "M101")
     def __checkCopyright(self):
         """
         Private method to check the presence of a copyright statement.
         """
         source = "".join(self.__source)
         copyrightArgs = self.__args.get(
             "CopyrightChecker", self.__defaultArgs["CopyrightChecker"])
         copyrightMinFileSize = copyrightArgs.get(
             "MinFilesize",
             self.__defaultArgs["CopyrightChecker"]["MinFilesize"])
         copyrightAuthor = copyrightArgs.get(
             "Author",
             self.__defaultArgs["CopyrightChecker"]["Author"])
         copyrightRegexStr = (
             r"Copyright\s+(\(C\)\s+)?(\d{{4}}\s+-\s+)?\d{{4}}\s+{author}"
         )
         tocheck = max(1024, copyrightMinFileSize)
         topOfSource = source[:tocheck]
         if len(topOfSource) < copyrightMinFileSize:
             return
         copyrightRe = re.compile(copyrightRegexStr.format(author=r".*"),
                                  re.IGNORECASE)
         if not copyrightRe.search(topOfSource):
             self.__error(0, 0, "M111")
             return
         if copyrightAuthor:
             copyrightAuthorRe = re.compile(
                 copyrightRegexStr.format(author=copyrightAuthor),
                 re.IGNORECASE)
             if not copyrightAuthorRe.search(topOfSource):
                 self.__error(0, 0, "M112")
     def __checkCommentedCode(self):
         """
         Private method to check for commented code.
         """
         from eradicate import commented_out_code_line_numbers
         source = "".join(self.__source)
         commentedCodeCheckerArgs = self.__args.get(
             "CommentedCodeChecker", self.__defaultArgs["CommentedCodeChecker"])
         aggressive = commentedCodeCheckerArgs.get(
             "Aggressive",
             self.__defaultArgs["CommentedCodeChecker"]["Aggressive"])
         for markedLine in commented_out_code_line_numbers(
                 source, aggressive=aggressive):
             self.__error(markedLine - 1, 0, "M891")
     def __checkLineContinuation(self):
         """
         Private method to check line continuation using backslash.
         """
         # generate source lines without comments
         linesIterator = iter(self.__source)
         tokens = tokenize.generate_tokens(lambda: next(linesIterator))
         comments = [token for token in tokens if token[0] == tokenize.COMMENT]
         stripped = self.__source[:]
         for comment in comments:
             lineno = comment[3][0]
             start = comment[2][1]
             stop = comment[3][1]
             content = stripped[lineno - 1]
             withoutComment = content[:start] + content[stop:]
             stripped[lineno - 1] = withoutComment.rstrip()
         # perform check with 'cleaned' source
         for lineIndex, line in enumerate(stripped):
             strippedLine = line.strip()
             if (strippedLine.endswith('\\') and
                     not strippedLine.startswith(('assert', 'with'))):
                 self.__error(lineIndex, len(line), "M841")
     def __checkPrintStatements(self):
         """
         Private method to check for print statements.
         """
         for node in ast.walk(self.__tree):
             if (
                 (isinstance(node, ast.Call) and
                  getattr(node.func, 'id', None) == 'print') or
                 (hasattr(ast, 'Print') and isinstance(node, ast.Print))
             ):
                 self.__error(node.lineno - 1, node.col_offset, "M801")
     def __checkTuple(self):
         """
         Private method to check for one element tuples.
         """
         for node in ast.walk(self.__tree):
             if (
                 isinstance(node, ast.Tuple) and
                 len(node.elts) == 1
             ):
                 self.__error(node.lineno - 1, node.col_offset, "M811")
     def __checkFuture(self):
         """
         Private method to check the __future__ imports.
         """
         expectedImports = {
             i.strip()
             for i in self.__args.get("FutureChecker", "").split(",")
             if bool(i.strip())}
         if len(expectedImports) == 0:
             # nothing to check for; disabling the check
             return
         imports = set()
         node = None
         hasCode = False
         for node in ast.walk(self.__tree):
             if (isinstance(node, ast.ImportFrom) and
                     node.module == '__future__'):
                 imports |= {name.name for name in node.names}
             elif isinstance(node, ast.Expr):
                 if not isinstance(node.value, ast.Str):
                     hasCode = True
                     break
             elif not isinstance(node, (ast.Module, ast.Str)):
                 hasCode = True
                 break
         if isinstance(node, ast.Module) or not hasCode:
             return
         if not (imports >= expectedImports):
             if imports:
                 self.__error(node.lineno - 1, node.col_offset, "M701",
                              ", ".join(expectedImports), ", ".join(imports))
             else:
                 self.__error(node.lineno - 1, node.col_offset, "M702",
                              ", ".join(expectedImports))
     def __checkPep3101(self):
         """
         Private method to check for old style string formatting.
         """
         for lineno, line in enumerate(self.__source):
             match = self.__pep3101FormatRegex.search(line)
             if match:
                 lineLen = len(line)
                 pos = line.find('%')
                 formatPos = pos
                 formatter = '%'
                 if line[pos + 1] == "(":
                     pos = line.find(")", pos)
                 c = line[pos]
                 while c not in "diouxXeEfFgGcrs":
                     pos += 1
                     if pos >= lineLen:
                         break
                     c = line[pos]
                 if c in "diouxXeEfFgGcrs":
                     formatter += c
                 self.__error(lineno, formatPos, "M601", formatter)
     def __checkFormatString(self):
         """
         Private method to check string format strings.
         """
         coding = self.__getCoding()[1]
         if not coding:
             # default to utf-8
             coding = "utf-8"
         visitor = TextVisitor()
         visitor.visit(self.__tree)
         for node in visitor.nodes:
             text = node.s
             if sys.version_info[0] > 2 and isinstance(text, bytes):
                 try:
                     text = text.decode(coding)
                 except UnicodeDecodeError:
                     continue
             fields, implicit, explicit = self.__getFields(text)
             if implicit:
                 if node in visitor.calls:
                     self.__error(node.lineno - 1, node.col_offset, "M611")
                 else:
                     if node.is_docstring:
                         self.__error(node.lineno - 1, node.col_offset, "M612")
                     else:
                         self.__error(node.lineno - 1, node.col_offset, "M613")
             if node in visitor.calls:
                 call, strArgs = visitor.calls[node]
                 numbers = set()
                 names = set()
                 # Determine which fields require a keyword and which an arg
                 for name in fields:
                     fieldMatch = self.FormatFieldRegex.match(name)
                     try:
                         number = int(fieldMatch.group(1))
                     except ValueError:
                         number = -1
                     # negative numbers are considered keywords
                     if number >= 0:
                         numbers.add(number)
                     else:
                         names.add(fieldMatch.group(1))
                 keywords = {keyword.arg for keyword in call.keywords}
                 numArgs = len(call.args)
                 if strArgs:
                     numArgs -= 1
                 if sys.version_info < (3, 5):
                     hasKwArgs = bool(call.kwargs)
                     hasStarArgs = bool(call.starargs)
                 else:
                     hasKwArgs = any(kw.arg is None for kw in call.keywords)
                     hasStarArgs = sum(1 for arg in call.args
                                       if isinstance(arg, ast.Starred))
                     if hasKwArgs:
                         keywords.discard(None)
                     if hasStarArgs:
                         numArgs -= 1
                 # if starargs or kwargs is not None, it can't count the
                 # parameters but at least check if the args are used
                 if hasKwArgs:
                     if not names:
                         # No names but kwargs
                         self.__error(call.lineno - 1, call.col_offset, "M623")
                 if hasStarArgs:
                     if not numbers:
                         # No numbers but args
                         self.__error(call.lineno - 1, call.col_offset, "M624")
                 if not hasKwArgs and not hasStarArgs:
                     # can actually verify numbers and names
                     for number in sorted(numbers):
                         if number >= numArgs:
                             self.__error(call.lineno - 1, call.col_offset,
                                          "M621", number)
                     for name in sorted(names):
                         if name not in keywords:
                             self.__error(call.lineno - 1, call.col_offset,
                                          "M622", name)
                 for arg in range(numArgs):
                     if arg not in numbers:
                         self.__error(call.lineno - 1, call.col_offset, "M631",
                                      arg)
                 for keyword in keywords:
                     if keyword not in names:
                         self.__error(call.lineno - 1, call.col_offset, "M632",
                                      keyword)
                 if implicit and explicit:
                     self.__error(call.lineno - 1, call.col_offset, "M625")
     def __getFields(self, string):
         """
         Private method to extract the format field information.
         @param string format string to be parsed
         @type str
         @return format field information as a tuple with fields, implicit
             field definitions present and explicit field definitions present
         @rtype tuple of set of str, bool, bool
         """
         fields = set()
         cnt = itertools.count()
         implicit = False
         explicit = False
         try:
             for _literal, field, spec, conv in self.Formatter.parse(string):
                 if field is not None and (conv is None or conv in 'rsa'):
                     if not field:
                         field = str(next(cnt))
                         implicit = True
                     else:
                         explicit = True
                     fields.add(field)
                     fields.update(parsedSpec[1]
                                   for parsedSpec in self.Formatter.parse(spec)
                                   if parsedSpec[1] is not None)
         except ValueError:
             return set(), False, False
         else:
             return fields, implicit, explicit
     def __checkBuiltins(self):
         """
         Private method to check, if built-ins are shadowed.
         """
         functionDefs = [ast.FunctionDef]
         try:
             functionDefs.append(ast.AsyncFunctionDef)
         except AttributeError:
             pass
         ignoreBuiltinAssignments = self.__args.get(
             "BuiltinsChecker", self.__defaultArgs["BuiltinsChecker"])
         for node in ast.walk(self.__tree):
             if isinstance(node, ast.Assign):
                 # assign statement
                 for element in node.targets:
                     if (
                         isinstance(element, ast.Name) and
                         element.id in self.__builtins
                     ):
                         value = node.value
                         if (
                             isinstance(value, ast.Name) and
                             element.id in ignoreBuiltinAssignments and
                             value.id in ignoreBuiltinAssignments[element.id]
                         ):
                             # ignore compatibility assignments
                             continue
                         self.__error(element.lineno - 1, element.col_offset,
                                      "M131", element.id)
                     elif isinstance(element, (ast.Tuple, ast.List)):
                         for tupleElement in element.elts:
                             if (
                                 isinstance(tupleElement, ast.Name) and
                                 tupleElement.id in self.__builtins
                             ):
                                 self.__error(tupleElement.lineno - 1,
                                              tupleElement.col_offset,
                                              "M131", tupleElement.id)
             elif isinstance(node, ast.For):
                 # for loop
                 target = node.target
                 if (
                     isinstance(target, ast.Name) and
                     target.id in self.__builtins
                 ):
                     self.__error(target.lineno - 1, target.col_offset,
                                  "M131", target.id)
                 elif isinstance(target, (ast.Tuple, ast.List)):
                     for element in target.elts:
                         if (
                             isinstance(element, ast.Name) and
                             element.id in self.__builtins
                         ):
                             self.__error(element.lineno - 1,
                                          element.col_offset,
                                          "M131", element.id)
             elif any(isinstance(node, functionDef)
                      for functionDef in functionDefs):
                 # (asynchronous) function definition
                 if sys.version_info >= (3, 0):
                     for arg in node.args.args:
                         if (
                             isinstance(arg, ast.arg) and
                             arg.arg in self.__builtins
                         ):
                             self.__error(arg.lineno - 1, arg.col_offset,
                                          "M132", arg.arg)
                 else:
                     for arg in node.args.args:
                         if (
                             isinstance(arg, ast.Name) and
                             arg.id in self.__builtins
                         ):
                             self.__error(arg.lineno - 1, arg.col_offset,
                                          "M132", arg.id)
     def __checkComprehensions(self):
         """
         Private method to check some comprehension related things.
         """
         for node in ast.walk(self.__tree):
             if isinstance(node, ast.Call) and isinstance(node.func, ast.Name):
                 nArgs = len(node.args)
                 if (
                     nArgs == 1 and
                     isinstance(node.args[0], ast.GeneratorExp) and
                     node.func.id in ('list', 'set')
                 ):
                     errorCode = {
                         "list": "M181",
                         "set": "M182",
                     }[node.func.id]
                     self.__error(node.lineno - 1, node.col_offset, errorCode)
                 elif (
                     nArgs == 1 and
                     isinstance(node.args[0], ast.GeneratorExp) and
                     isinstance(node.args[0].elt, ast.Tuple) and
                     len(node.args[0].elt.elts) == 2 and
                     node.func.id == "dict"
                 ):
                     self.__error(node.lineno - 1, node.col_offset, "M183")
                 elif (
                     nArgs == 1 and
                     isinstance(node.args[0], ast.ListComp) and
                     node.func.id in ('list', 'set', 'dict')
                 ):
                     errorCode = {
                         'list': 'M195',
                         'dict': 'M185',
                         'set': 'M184',
                     }[node.func.id]
                     self.__error(node.lineno - 1, node.col_offset, errorCode)
                 elif nArgs == 1 and (
                     isinstance(node.args[0], ast.Tuple) and
                     node.func.id == "tuple" or
                     isinstance(node.args[0], ast.List) and
                     node.func.id == "list"
                 ):
                     errorCode = {
                         'tuple': 'M197',
                         'list': 'M198',
                     }[node.func.id]
                     self.__error(node.lineno - 1, node.col_offset, errorCode,
                                  type(node.args[0]).__name__.lower(),
                                  node.func.id)
                 elif (
                     nArgs == 1 and
                     isinstance(node.args[0], (ast.Tuple, ast.List)) and
                     node.func.id in ("tuple", "list", "set", "dict")
                 ):
                     errorCode = {
                         "tuple": "M192",
                         "list": "M193",
                         "set": "M191",
                         "dict": "M191",
                     }[node.func.id]
                     self.__error(node.lineno - 1, node.col_offset, errorCode,
                                  type(node.args[0]).__name__.lower(),
                                  node.func.id)
                 elif (
                     nArgs == 1 and
                     isinstance(node.args[0], ast.ListComp) and
                     node.func.id in ('all', 'any', 'enumerate', 'frozenset',
                                      'max', 'min', 'sorted', 'sum', 'tuple',)
                 ):
                     self.__error(node.lineno - 1, node.col_offset, "M187",
                                  node.func.id)
                 elif (
                     nArgs == 0 and
                     not any(isinstance(a, ast.Starred) for a in node.args) and
                     not any(k.arg is None for k in node.keywords) and
                     node.func.id in ("tuple", "list", "dict")
                 ):
                     self.__error(node.lineno - 1, node.col_offset, "M186",
                                  node.func.id)
                 elif isinstance(node, ast.Compare) and (
                     len(node.ops) == 1 and
                     isinstance(node.ops[0], ast.In) and
                     len(node.comparators) == 1 and
                     isinstance(node.comparators[0], ast.ListComp)
                 ):
                     self.__error(node.lineno - 1, node.col_offset, "M196")
     def __checkMutableDefault(self):
         """
         Private method to check for use of mutable types as default arguments.
         """
         mutableTypes = (
             ast.Call,
             ast.Dict,
             ast.List,
             ast.Set,
         )
         mutableCalls = (
             "Counter",
             "OrderedDict",
             "collections.Counter",
             "collections.OrderedDict",
             "collections.defaultdict",
             "collections.deque",
             "defaultdict",
             "deque",
             "dict",
             "list",
             "set",
         )
         immutableCalls = (
             "tuple",
             "frozenset",
         )
         functionDefs = [ast.FunctionDef]
         try:
             functionDefs.append(ast.AsyncFunctionDef)
         except AttributeError:
             pass
         for node in ast.walk(self.__tree):
             if any(isinstance(node, functionDef)
                    for functionDef in functionDefs):
                 defaults = node.args.defaults[:]
                 try:
                     defaults += node.args.kw_defaults[:]
                 except AttributeError:
                     pass
                 for default in defaults:
                     if any(isinstance(default, mutableType)
                            for mutableType in mutableTypes):
                         typeName = type(default).__name__
                         if isinstance(default, ast.Call):
                             callPath = '.'.join(composeCallPath(default.func))
                             if callPath in mutableCalls:
                                 self.__error(default.lineno - 1,
                                              default.col_offset,
                                              "M823", callPath + "()")
                             elif callPath not in immutableCalls:
                                 self.__error(default.lineno - 1,
                                              default.col_offset,
                                              "M822", typeName)
                         else:
                             self.__error(default.lineno - 1,
                                          default.col_offset,
                                          "M821", typeName)
     def __dictShouldBeChecked(self, node):
         """
         Private function to test, if the node should be checked.
         @param node reference to the AST node
         @return flag indicating to check the node
         @rtype bool
         """
         if not all(isinstance(key, ast.Str) for key in node.keys):
             return False
         if (
             "__IGNORE_WARNING__" in self.__source[node.lineno - 1] or
             "__IGNORE_WARNING_M201__" in self.__source[node.lineno - 1]
         ):
             return False
         lineNumbers = [key.lineno for key in node.keys]
         return len(lineNumbers) == len(set(lineNumbers))
     def __checkDictWithSortedKeys(self):
         """
         Private method to check, if dictionary keys appear in sorted order.
         """
         for node in ast.walk(self.__tree):
             if isinstance(node, ast.Dict) and self.__dictShouldBeChecked(node):
                 for key1, key2 in zip(node.keys, node.keys[1:]):
                     if key2.s < key1.s:
                         self.__error(key2.lineno - 1, key2.col_offset,
                                      "M201", key2.s, key1.s)
     def __checkLogging(self):
         """
         Private method to check logging statements.
         """
         visitor = LoggingVisitor()
         visitor.visit(self.__tree)
         for node, reason in visitor.violations:
             self.__error(node.lineno - 1, node.col_offset, reason)
     def __checkGettext(self):
         """
         Private method to check the 'gettext' import statement.
         """
         for node in ast.walk(self.__tree):
             if (
                 isinstance(node, ast.ImportFrom) and
                 any(name.asname == '_' for name in node.names)
             ):
                 self.__error(node.lineno - 1, node.col_offset, "M711",
                              node.names[0].name)
     def __checkBugBear(self):
         """
         Private method for bugbear checks.
         """
         visitor = BugBearVisitor()
         visitor.visit(self.__tree)
         for violation in visitor.violations:
             node = violation[0]
             reason = violation[1]
             params = violation[2:]
             self.__error(node.lineno - 1, node.col_offset, reason, *params)
     def __checkReturn(self):
         """
         Private method to check return statements.
         """
         visitor = ReturnVisitor()
         visitor.visit(self.__tree)
         for violation in visitor.violations:
             node = violation[0]
             reason = violation[1]
             self.__error(node.lineno - 1, node.col_offset, reason)
 




c2bf08f87a1d
Code Style Checker: added checks for naive uses of datetime classes.

Detlev Offenbach <detlev@die-offenbach

Mercurial Repositories > eric / annotate

eric6/Plugins/CheckerPlugins/CodeStyleChecker/MiscellaneousChecker.py@4ef3b78ebb4e (annotated)

eric6/Plugins/CheckerPlugins/CodeStyleChecker/MiscellaneousChecker.py